Remove debug package, fix URL, make setup quiet, Spec file cleanup, rpmlint

check

sblim-testsuite.spec

@@ -1,58 +1,54 @@
-#
+%define debug_package %{nil}
-# $Id: sblim-testsuite.spec,v 1.5 2008/10/24 12:46:21 vcrhonek Exp $
-#
-# Package spec for sblim-testsuite
-#
 
-BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
+Name:           sblim-testsuite
-BuildArch: noarch
+Version:        1.2.5
+Release:        2%{?dist}
+Summary:        SBLIM testsuite
 
-Summary: SBLIM testsuite
+Group:          Applications/System
-Name: sblim-testsuite
+License:        CPL
-Version: 1.2.5
+URL:            http://sblim.wiki.sourceforge.net/
-Release: 1%{?dist}
+Source0:        http://downloads.sourceforge.net/sblim/%{name}-%{version}.tar.bz2
-Group: Systems Management/Base
+BuildRoot:      %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
-URL: http://www.sourceforge.net
+BuildArch:      noarch
-License: CPL
 
-Source0: http://downloads.sourceforge.net/sblim/%{name}-%{version}.tar.bz2
+Requires:       perl >= 5.6
+Requires:       sblim-wbemcli >= 1.5
 
-Requires: perl >= 5.6
+%description
-Requires: sblim-wbemcli >= 1.5
+SBLIM automated testsuite scripts.
-
-%Description
-SBLIM automated testsuite scripts
 
 %prep
-
+%setup -q
-%setup
 
 %build
-
 %configure
-make
+make %{?_smp_mflags}
 
 %install
-[ "$RPM_BUILD_ROOT" != "/" ] && rm -rf $RPM_BUILD_ROOT
+rm -rf $RPM_BUILD_ROOT
-make DESTDIR=$RPM_BUILD_ROOT install
+make install DESTDIR=$RPM_BUILD_ROOT
-
 
 %clean
-[ "$RPM_BUILD_ROOT" != "/" ] && rm -rf $RPM_BUILD_ROOT
+rm -rf $RPM_BUILD_ROOT
 
 %files
-%defattr(-,root,root)
+%defattr(-,root,root,-)
 %doc %{_datadir}/doc/%{name}-%{version}
 %{_datadir}/%{name}
 %{_localstatedir}/lib/%{name}
 
 %changelog
+* Tue Nov  4 2008 Vitezslav Crhonek <vcrhonek@redhat.com> - 1.2.5-2
+- Remove debug package, fix URL, make setup quiet
+- Spec file cleanup, rpmlint check
+
 * Fri Oct 24 2008 Vitezslav Crhonek <vcrhonek@redhat.com> - 1.2.5-1
 - Update to 1.2.5
   Resolves: #468327
 
-* Thu Oct 28 2005 Viktor Mihajlovski <mihajlov@de.ibm.com> 1.2.4-1
+* Thu Oct 28 2005 Viktor Mihajlovski <mihajlov@de.ibm.com> - 1.2.4-1
-  - New release
+- New release
 
-* Thu Jul 28 2005 Viktor Mihajlovski <mihajlov@de.ibm.com> 1.2.3-0
+* Thu Jul 28 2005 Viktor Mihajlovski <mihajlov@de.ibm.com> - 1.2.3-0
-  - Updates for rpmlint complaints
+- Updates for rpmlint complaints