Fix warnings affecting cucumber-wire test suite.

Resolves: rhbz#1863722
epel9
Vít Ondruch 4 years ago
parent b857d1aeee
commit d16892d5da

@ -0,0 +1,25 @@
From a88115f8668ff9c2ca91e11afc0529105c06446f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?David=20Rodr=C3=ADguez?= <deivid.rodriguez@riseup.net>
Date: Sun, 12 Jan 2020 13:41:59 +0100
Subject: [PATCH] Remove unintended `private` call
From reading https://bugs.ruby-lang.org/issues/13249, I don't think
`private` is having any effect here, since it's only supposed to affect
further methods defined inside the current class method (if at all), and
this method does not define any method inside itself.
---
lib/cucumber/core/test/result.rb | 1 -
1 file changed, 1 deletion(-)
diff --git a/lib/cucumber/core/test/result.rb b/lib/cucumber/core/test/result.rb
index 136002a..21d06c8 100644
--- a/lib/cucumber/core/test/result.rb
+++ b/lib/cucumber/core/test/result.rb
@@ -9,7 +9,6 @@ module Result
STRICT_AFFECTED_TYPES = [:flaky, :undefined, :pending].freeze
def self.ok?(type, be_strict = StrictConfiguration.new)
- private
class_name = type.to_s.slice(0, 1).capitalize + type.to_s.slice(1..-1)
const_get(class_name).ok?(be_strict.strict?(type))
end

@ -3,7 +3,7 @@
Name: rubygem-%{gem_name} Name: rubygem-%{gem_name}
Version: 3.2.0 Version: 3.2.0
Release: 7%{?dist} Release: 8%{?dist}
Summary: Core library for the Cucumber BDD app Summary: Core library for the Cucumber BDD app
License: MIT License: MIT
URL: https://cucumber.io URL: https://cucumber.io
@ -11,6 +11,9 @@ Source0: https://rubygems.org/gems/%{gem_name}-%{version}.gem
# git clone https://github.com/cucumber/cucumber-ruby-core.git && cd cucumber-ruby-core # git clone https://github.com/cucumber/cucumber-ruby-core.git && cd cucumber-ruby-core
# git checkout v3.2.0 && tar czvf rubygem-cucumber-core-3.2.0-spec.tar.gz spec/ # git checkout v3.2.0 && tar czvf rubygem-cucumber-core-3.2.0-spec.tar.gz spec/
Source1: %{name}-%{version}-spec.tar.gz Source1: %{name}-%{version}-spec.tar.gz
# Fix warnings affecting cucumber-wire test suite.
# https://github.com/cucumber/cucumber-ruby-core/pull/191
Patch0: rubygem-cucumber-core-6.0.0-Remove-unintended-private-call.patch
BuildRequires: ruby(release) BuildRequires: ruby(release)
BuildRequires: rubygems-devel BuildRequires: rubygems-devel
BuildRequires: ruby BuildRequires: ruby
@ -37,6 +40,8 @@ Documentation for %{name}.
%prep %prep
%setup -q -n %{gem_name}-%{version} -b 1 %setup -q -n %{gem_name}-%{version} -b 1
%patch0 -p1
# We do not have gherkin 5 in Fedora yet. # We do not have gherkin 5 in Fedora yet.
%gemspec_remove_dep -s ../%{gem_name}-%{version}.gemspec -g gherkin '>= 5.0.0' %gemspec_remove_dep -s ../%{gem_name}-%{version}.gemspec -g gherkin '>= 5.0.0'
%gemspec_add_dep -s ../%{gem_name}-%{version}.gemspec -g gherkin '>= 4.1.0' %gemspec_add_dep -s ../%{gem_name}-%{version}.gemspec -g gherkin '>= 4.1.0'
@ -81,6 +86,10 @@ popd
%doc %{gem_instdir}/CHANGELOG.md %doc %{gem_instdir}/CHANGELOG.md
%changelog %changelog
* Tue Aug 11 2020 Vít Ondruch <vondruch@redhat.com> - 3.2.0-8
- Fix warnings affecting cucumber-wire test suite.
Resolves: rhbz#1863722
* Tue Aug 11 10:13:05 GMT 2020 Vít Ondruch <vondruch@redhat.com> - 3.2.0-7 * Tue Aug 11 10:13:05 GMT 2020 Vít Ondruch <vondruch@redhat.com> - 3.2.0-7
- Add `BR: rubygem(kramdown-parser-gfm)` which was extrected into independency - Add `BR: rubygem(kramdown-parser-gfm)` which was extrected into independency
package. package.

Loading…
Cancel
Save