Compare commits
No commits in common. 'c9' and 'i9c-beta' have entirely different histories.
@ -1 +1 @@
|
||||
SOURCES/jwcrypto-0.8.tar.gz
|
||||
SOURCES/jwcrypto-1.5.6.tar.gz
|
||||
|
@ -1 +1 @@
|
||||
038ee5faf896548477c0b57c3cacb92add36e550 SOURCES/jwcrypto-0.8.tar.gz
|
||||
e3fdb8f42c60e947cbe58346d086850d915a2b60 SOURCES/jwcrypto-1.5.6.tar.gz
|
||||
|
@ -1,74 +0,0 @@
|
||||
From 90477a3b6e73da69740e00b8161f53fea19b831f Mon Sep 17 00:00:00 2001
|
||||
From: Simo Sorce <simo@redhat.com>
|
||||
Date: Tue, 5 Mar 2024 16:57:17 -0500
|
||||
Subject: [PATCH] Address potential DoS with high compression ratio
|
||||
|
||||
Fixes CVE-2024-28102
|
||||
|
||||
Signed-off-by: Simo Sorce <simo@redhat.com>
|
||||
---
|
||||
jwcrypto/jwe.py | 7 +++++++
|
||||
jwcrypto/tests.py | 26 ++++++++++++++++++++++++++
|
||||
2 files changed, 33 insertions(+)
|
||||
|
||||
diff --git a/jwcrypto/jwe.py b/jwcrypto/jwe.py
|
||||
index 9412881..5df500b 100644
|
||||
--- a/jwcrypto/jwe.py
|
||||
+++ b/jwcrypto/jwe.py
|
||||
@@ -10,5 +10,8 @@
|
||||
from jwcrypto.jwa import JWA
|
||||
|
||||
+# Limit the amount of data we are willing to decompress by default.
|
||||
+default_max_compressed_size = 256 * 1024
|
||||
+
|
||||
|
||||
# RFC 7516 - 4.1
|
||||
# name: (description, supported?)
|
||||
@@ -387,6 +387,10 @@ def _decrypt(self, key, ppe):
|
||||
|
||||
compress = jh.get('zip', None)
|
||||
if compress == 'DEF':
|
||||
+ if len(data) > default_max_compressed_size:
|
||||
+ raise InvalidJWEData(
|
||||
+ 'Compressed data exceeds maximum allowed'
|
||||
+ 'size' + f' ({default_max_compressed_size})')
|
||||
self.plaintext = zlib.decompress(data, -zlib.MAX_WBITS)
|
||||
elif compress is None:
|
||||
self.plaintext = data
|
||||
diff --git a/jwcrypto/tests.py b/jwcrypto/tests.py
|
||||
index bb2ff10..59049f8 100644
|
||||
--- a/jwcrypto/tests.py
|
||||
+++ b/jwcrypto/tests.py
|
||||
@@ -1526,6 +1526,32 @@ def test_pbes2_hs256_aeskw_custom_params(self):
|
||||
token.deserialize(jwt=e)
|
||||
json_decode(token.claims)
|
||||
|
||||
+ def test_jwe_decompression_max(self):
|
||||
+ key = jwk.JWK(kty='oct', k=base64url_encode(b'A' * (128 // 8)))
|
||||
+ payload = '{"u": "' + "u" * 400000000 + '", "uu":"' \
|
||||
+ + "u" * 400000000 + '"}'
|
||||
+ protected_header = {
|
||||
+ "alg": "A128KW",
|
||||
+ "enc": "A128GCM",
|
||||
+ "typ": "JWE",
|
||||
+ "zip": "DEF",
|
||||
+ }
|
||||
+ enc = jwe.JWE(payload.encode('utf-8'),
|
||||
+ recipient=key,
|
||||
+ protected=protected_header).serialize(compact=True)
|
||||
+ with self.assertRaises(jwe.InvalidJWEData):
|
||||
+ check = jwe.JWE()
|
||||
+ check.deserialize(enc)
|
||||
+ check.decrypt(key)
|
||||
+
|
||||
+ defmax = jwe.default_max_compressed_size
|
||||
+ jwe.default_max_compressed_size = 1000000000
|
||||
+ # ensure we can eraise the limit and decrypt
|
||||
+ check = jwe.JWE()
|
||||
+ check.deserialize(enc)
|
||||
+ check.decrypt(key)
|
||||
+ jwe.default_max_compressed_size = defmax
|
||||
+
|
||||
|
||||
class JWATests(unittest.TestCase):
|
||||
def test_jwa_create(self):
|
@ -0,0 +1,40 @@
|
||||
diff -Naur jwcrypto-1.5.6/jwcrypto/jwk.py jwcrypto-1.5.6-new/jwcrypto/jwk.py
|
||||
--- jwcrypto-1.5.6/jwcrypto/jwk.py 2024-02-07 13:52:39.000000000 -0300
|
||||
+++ jwcrypto-1.5.6-new/jwcrypto/jwk.py 2024-06-12 13:06:28.553972422 -0300
|
||||
@@ -11,7 +11,15 @@
|
||||
from cryptography.hazmat.primitives.asymmetric import ec
|
||||
from cryptography.hazmat.primitives.asymmetric import rsa
|
||||
|
||||
-from typing_extensions import deprecated
|
||||
+try:
|
||||
+ from typing_extensions import deprecated
|
||||
+except ImportError:
|
||||
+ def deprecated(_fn, *args):
|
||||
+ def inner(func):
|
||||
+ return func
|
||||
+
|
||||
+ return inner
|
||||
+
|
||||
|
||||
from jwcrypto.common import JWException
|
||||
from jwcrypto.common import base64url_decode, base64url_encode
|
||||
diff -Naur jwcrypto-1.5.6/jwcrypto/jwt.py jwcrypto-1.5.6-new/jwcrypto/jwt.py
|
||||
--- jwcrypto-1.5.6/jwcrypto/jwt.py 2024-02-07 13:52:39.000000000 -0300
|
||||
+++ jwcrypto-1.5.6-new/jwcrypto/jwt.py 2024-06-12 13:26:48.534696766 -0300
|
||||
@@ -4,7 +4,15 @@
|
||||
import time
|
||||
import uuid
|
||||
|
||||
-from typing_extensions import deprecated
|
||||
+try:
|
||||
+ from typing_extensions import deprecated
|
||||
+except ImportError:
|
||||
+ def deprecated(*args):
|
||||
+ def inner(func):
|
||||
+ return func
|
||||
+
|
||||
+ return inner
|
||||
+
|
||||
|
||||
from jwcrypto.common import JWException, JWKeyNotFound
|
||||
from jwcrypto.common import json_decode, json_encode
|
Loading…
Reference in new issue