parent
43e98dfd72
commit
34dadcb7fc
@ -1,2 +1,3 @@
|
|||||||
/breeze-fedora-0.2.tar.gz
|
/breeze-fedora-0.2.tar.gz
|
||||||
/plasma-workspace-5.11.5.tar.xz
|
/plasma-workspace-5.11.5.tar.xz
|
||||||
|
/plasma-workspace-5.11.95.tar.xz
|
||||||
|
@ -1,50 +0,0 @@
|
|||||||
From 1c098f6efa9ce449bc94e71bf8e317e1d607c4f8 Mon Sep 17 00:00:00 2001
|
|
||||||
From: Maciej Sitarz <macieksitarz@wp.pl>
|
|
||||||
Date: Mon, 8 Jan 2018 15:01:11 +0000
|
|
||||||
Subject: [PATCH 13/13] Fix for xembedsniproxy crash due to NULL returned from
|
|
||||||
xcb_image_get()
|
|
||||||
|
|
||||||
Summary:
|
|
||||||
In my environment (Fedora 27, plasma-workspace-5.11.4-1.fc27.x86_64) xembedsniproxy crashes.
|
|
||||||
This is caused by NULL being returned by xcb_image_get().
|
|
||||||
|
|
||||||
This should fix or at least mitigate the problems from bugs:
|
|
||||||
https://bugs.kde.org/show_bug.cgi?id=355463
|
|
||||||
https://bugs.kde.org/show_bug.cgi?id=359664
|
|
||||||
https://bugzilla.redhat.com/show_bug.cgi?id=1497829
|
|
||||||
|
|
||||||
Reviewers: #plasma, davidedmundson
|
|
||||||
|
|
||||||
Reviewed By: #plasma, davidedmundson
|
|
||||||
|
|
||||||
Subscribers: broulik, plasma-devel
|
|
||||||
|
|
||||||
Tags: #plasma
|
|
||||||
|
|
||||||
Differential Revision: https://phabricator.kde.org/D9732
|
|
||||||
---
|
|
||||||
xembed-sni-proxy/sniproxy.cpp | 8 +++++++-
|
|
||||||
1 file changed, 7 insertions(+), 1 deletion(-)
|
|
||||||
|
|
||||||
diff --git a/xembed-sni-proxy/sniproxy.cpp b/xembed-sni-proxy/sniproxy.cpp
|
|
||||||
index 7fb00dbb..932109d9 100644
|
|
||||||
--- a/xembed-sni-proxy/sniproxy.cpp
|
|
||||||
+++ b/xembed-sni-proxy/sniproxy.cpp
|
|
||||||
@@ -288,7 +288,13 @@ QImage SNIProxy::getImageNonComposite() const
|
|
||||||
xcb_image_t *image = xcb_image_get(c, m_windowId, 0, 0, geom->width, geom->height, 0xFFFFFFFF, XCB_IMAGE_FORMAT_Z_PIXMAP);
|
|
||||||
|
|
||||||
// Don't hook up cleanup yet, we may use a different QImage after all
|
|
||||||
- QImage naiveConversion = QImage(image->data, image->width, image->height, QImage::Format_ARGB32);
|
|
||||||
+ QImage naiveConversion;
|
|
||||||
+ if (image) {
|
|
||||||
+ naiveConversion = QImage(image->data, image->width, image->height, QImage::Format_ARGB32);
|
|
||||||
+ } else {
|
|
||||||
+ qCDebug(SNIPROXY) << "Skip NULL image returned from xcb_image_get() for" << m_windowId << Title();
|
|
||||||
+ return QImage();
|
|
||||||
+ }
|
|
||||||
|
|
||||||
if (isTransparentImage(naiveConversion)) {
|
|
||||||
QImage elaborateConversion = QImage(convertFromNative(image));
|
|
||||||
--
|
|
||||||
2.14.3
|
|
||||||
|
|
@ -1,2 +1 @@
|
|||||||
SHA512 (breeze-fedora-0.2.tar.gz) = ff800e686b0dcb498f321bb94d3a8274c89c092f5408ef1ec3fc65333f046aea43444144ecaf166792f807014383af87b1180dc7540905fc10dc375309f8b2a8
|
SHA512 (plasma-workspace-5.11.95.tar.xz) = a1ccf5e6df989444488ac23caf08b7e49766f23d926ff4b377fe69061b40c157120ed62bc744b5b0575040de99509a54a3f00c886135136a0bff492465c82bed
|
||||||
SHA512 (plasma-workspace-5.11.5.tar.xz) = 6f15e529665a5fbe24ee0420d1c8fe96ff97dbd2788ae120cd1834889b307b5979ca2aedd4f97d3cadcc7ed5cdb06c0e5f9c704ec732468db4b8ecf89270826f
|
|
||||||
|
Loading…
Reference in new issue