Spec clean-up

- Can run spelling test unconditionally now
- BR: perl(ExtUtils::Manifest)
- Don't BR: perl(Test::Perl::Critic) if we're bootstrapping
- Use %{_fixperms} macro rather than our own chmod incantation
- Run developer tests in a separate test run
- Drop redundant %{?perl_default_filter}
- Don't use macros for commands

perl-Test-Synopsis.spec

@@ -1,26 +1,25 @@
 Name:		perl-Test-Synopsis
 Version:	0.06
-Release:	8%{?dist}
+Release:	9%{?dist}
 Summary:	Test your SYNOPSIS code
 Group:		Development/Libraries
 License:	GPL+ or Artistic
 URL:		http://search.cpan.org/dist/Test-Synopsis/
 Source0:	http://search.cpan.org/CPAN/authors/id/M/MI/MIYAGAWA/Test-Synopsis-%{version}.tar.gz
-BuildRoot:	%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
+BuildRoot:	%{_tmppath}/%{name}-%{version}-%{release}-root-%(id -nu)
 BuildArch:	noarch
 BuildRequires:	perl(ExtUtils::MakeMaker)
+BuildRequires:	perl(ExtUtils::Manifest)
 BuildRequires:	perl(Test::Builder::Module)
-BuildRequires:	perl(Test::Perl::Critic)
 BuildRequires:	perl(Test::Pod) >= 1.00
-# aspell-en not available in EL-6 onwards (#590700)
-%if 0%{?fedora} || 0%{?rhel} < 6
 BuildRequires:	perl(Test::Spelling), aspell-en
+# Test::Perl::Critic -> Perl::Critic -> List::MoreUtils -> Test::LeakTrace -> Test::Synopsis
+%if 0%{!?perl_bootstrap:1}
+BuildRequires:	perl(Test::Perl::Critic)
 %endif
-Requires:	perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version))
+Requires:	perl(:MODULE_COMPAT_%(eval "`perl -V:version`"; echo $version))
 Requires:	perl(Test::Builder::Module)
 
-%{?perl_default_filter}
-
 %description
 Test::Synopsis is an (author) test module to find .pm or .pod files under your
 lib directory and then make sure the example snippet code in your SYNOPSIS
@@ -41,10 +40,11 @@ rm -rf %{buildroot}
 make pure_install DESTDIR=%{buildroot}
 find %{buildroot} -type f -name .packlist -exec rm -f {} \;
 find %{buildroot} -depth -type d -exec rmdir {} \; 2>/dev/null
-chmod -R u+w %{buildroot}
+%{_fixperms} %{buildroot}
 
 %check
-make test TEST_FILES="t/*.t xt/*.t"
+make test
+make test TEST_FILES="xt/*.t"
 
 %clean
 rm -rf %{buildroot}
@@ -56,6 +56,15 @@ rm -rf %{buildroot}
 %{_mandir}/man3/Test::Synopsis.3pm*
 
 %changelog
+* Wed Jan 25 2012 Paul Howarth <paul@city-fan.org> - 0.06-9
+- Can run spelling test unconditionally now
+- BR: perl(ExtUtils::Manifest)
+- Don't BR: perl(Test::Perl::Critic) if we're bootstrapping
+- Use %%{_fixperms} macro rather than our own chmod incantation
+- Run developer tests in a separate test run
+- Drop redundant %%{?perl_default_filter}
+- Don't use macros for commands
+
 * Fri Jan 13 2012 Fedora Release Engineering <rel-eng@lists.fedoraproject.org> - 0.06-8
 - Rebuilt for https://fedoraproject.org/wiki/Fedora_17_Mass_Rebuild
 
@@ -66,16 +75,16 @@ rm -rf %{buildroot}
 - Rebuilt for https://fedoraproject.org/wiki/Fedora_15_Mass_Rebuild
 
 * Wed Dec 22 2010 Marcela Maslanova <mmaslano@redhat.com> - 0.06-5
-- 661697 rebuild for fixing problems with vendorach/lib
+- Rebuild to fix problems with vendorarch/lib (#661697)
 
-* Tue Jun 15 2010 Paul Howarth <paul@city-fan.org> 0.06-4
+* Tue Jun 15 2010 Paul Howarth <paul@city-fan.org> - 0.06-4
 - Whittle down for Fedora submission
 
-* Mon May 17 2010 Paul Howarth <paul@city-fan.org> 0.06-3
+* Mon May 17 2010 Paul Howarth <paul@city-fan.org> - 0.06-3
 - Fix dist tag for RHEL-6 Beta
 
-* Tue Feb  2 2010 Paul Howarth <paul@city-fan.org> 0.06-2
+* Tue Feb  2 2010 Paul Howarth <paul@city-fan.org> - 0.06-2
 - Add buildreq perl(Test::Perl::Critic) if we have Perl 5.8.8 or later
 
-* Fri Nov 27 2009 Paul Howarth <paul@city-fan.org> 0.06-1
+* Fri Nov 27 2009 Paul Howarth <paul@city-fan.org> - 0.06-1
 - Initial RPM version