rpms
/
perl-Test-Perl-Critic
21
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Drop tests subpackage and clean up

Browse Source 
- Drop -tests subpackage (general lack of interest in this), but include
  them as documentation for the main package
- Drop redundant BR: perl(ExtUtils::MakeMaker)
- Drop redundant unversioned explicit requires
- Drop %defattr, redundant since rpm 4.4
- Make %files list more explicit
- Don't use macros for commands
- Run the author tests in %check
- BR: perl(Test::Pod) and perl(Test::Pod::Coverage)
- Use tabs
epel9
Paul Howarth 13 years ago
parent 1ff121e129
commit fc4da8936e
1 changed files with 78 additions and 77 deletions
Show Stats Download Patch File Download Diff File

119
perl-Test-Perl-Critic.spec
Unescape View File

@ -1,35 +1,34 @@
Name: perl-Test-Perl-Critic Name: perl-Test-Perl-Critic
Summary: Use Perl::Critic in test programs Summary: Use Perl::Critic in test programs
Version: 1.02 Version: 1.02
Release: 6%{?dist} Release: 7%{?dist}
License: GPL+ or Artistic
Group: Development/Libraries Group: Development/Libraries
Source0: http://search.cpan.org/CPAN/authors/id/T/TH/THALJEF/Test-Perl-Critic-%{version}.tar.gz License: GPL+ or Artistic
URL: http://search.cpan.org/dist/Test-Perl-Critic/ URL: http://search.cpan.org/dist/Test-Perl-Critic/
BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) Source0: http://search.cpan.org/CPAN/authors/id/T/TH/THALJEF/Test-Perl-Critic-%{version}.tar.gz
Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version)) BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(id -nu)
BuildArch: noarch BuildArch: noarch
BuildRequires: perl(Carp) BuildRequires: perl(Carp)
BuildRequires: perl(English) BuildRequires: perl(English)
BuildRequires: perl(ExtUtils::MakeMaker)
BuildRequires: perl(Module::Build) >= 0.35 BuildRequires: perl(Module::Build) >= 0.35
BuildRequires: perl(Perl::Critic) >= 1.105 BuildRequires: perl(Perl::Critic) >= 1.105
BuildRequires: perl(Perl::Critic::Utils) >= 1.105 BuildRequires: perl(Perl::Critic::Utils) >= 1.105
BuildRequires: perl(Perl::Critic::Violation) >= 1.105 BuildRequires: perl(Perl::Critic::Violation) >= 1.105
BuildRequires: perl(Test::Builder) BuildRequires: perl(Test::Builder)
BuildRequires: perl(Test::More) BuildRequires: perl(Test::More)
BuildRequires: perl(Test::Pod)
Requires: perl(Carp) BuildRequires: perl(Test::Pod::Coverage)
Requires: perl(English) Requires: perl(:MODULE_COMPAT_%(eval "`perl -V:version`"; echo $version))
Requires: perl(Perl::Critic) >= 1.105 Requires: perl(Perl::Critic) >= 1.105
Requires: perl(Perl::Critic::Utils) >= 1.105 Requires: perl(Perl::Critic::Utils) >= 1.105
Requires: perl(Perl::Critic::Violation) >= 1.105 Requires: perl(Perl::Critic::Violation) >= 1.105
Requires: perl(Test::Builder)
# Avoid doc-file dependencies from tests
%{?perl_default_filter} %{?perl_default_filter}
%{?perl_default_subpackage_tests}
# Obsolete/provide old -tests subpackage (can be removed in F19 development cycle)
Obsoletes: %{name}-tests < %{version}-%{release}
Provides: %{name}-tests = %{version}-%{release}
%description %description
Test::Perl::Critic wraps the Perl::Critic engine in a convenient Test::Perl::Critic wraps the Perl::Critic engine in a convenient
@ -38,40 +37,42 @@ framework. This makes it easy to integrate coding-standards enforcement
into the build process. For ultimate convenience (at the expense of some into the build process. For ultimate convenience (at the expense of some
flexibility), see the criticism pragma. flexibility), see the criticism pragma.
%prep %prep
%setup -q -n Test-Perl-Critic-%{version} %setup -q -n Test-Perl-Critic-%{version}
%build %build
%{__perl} Build.PL installdirs=vendor perl Build.PL installdirs=vendor
./Build ./Build
%install %install
rm -rf $RPM_BUILD_ROOT rm -rf %{buildroot}
./Build install destdir=$RPM_BUILD_ROOT create_packlist=0 ./Build install destdir=%{buildroot} create_packlist=0
%{_fixperms} $RPM_BUILD_ROOT/* %{_fixperms} %{buildroot}
%check %check
# Tests are failing with odd unpack errors. TEST_AUTHOR=1 ./Build test
# TEST_AUTHOR=1 ./Build test
./Build test
%clean %clean
rm -rf $RPM_BUILD_ROOT rm -rf %{buildroot}
%files %files
%defattr(-,root,root,-) %doc Changes LICENSE README %{?perl_default_filter:t/ xt/}
%doc Changes LICENSE README
%{perl_vendorlib}/Test/ %{perl_vendorlib}/Test/
%{_mandir}/man3/*.3pm* %{_mandir}/man3/Test::Perl::Critic.3pm*
%changelog %changelog
* Wed Mar 21 2012 Paul Howarth <paul@city-fan.org> - 1.02-7
- Drop -tests subpackage (general lack of interest in this), but include
them as documentation for the main package
- Drop redundant BR: perl(ExtUtils::MakeMaker)
- Drop redundant unversioned explicit requires
- Drop %%defattr, redundant since rpm 4.4
- Make %%files list more explicit
- Don't use macros for commands
- Run the author tests in %%check
- BR: perl(Test::Pod) and perl(Test::Pod::Coverage)
- Use tabs
* Fri Jan 13 2012 Fedora Release Engineering <rel-eng@lists.fedoraproject.org> - 1.02-6 * Fri Jan 13 2012 Fedora Release Engineering <rel-eng@lists.fedoraproject.org> - 1.02-6
- Rebuilt for https://fedoraproject.org/wiki/Fedora_17_Mass_Rebuild - Rebuilt for https://fedoraproject.org/wiki/Fedora_17_Mass_Rebuild
@ -82,34 +83,34 @@ rm -rf $RPM_BUILD_ROOT
- Rebuilt for https://fedoraproject.org/wiki/Fedora_15_Mass_Rebuild - Rebuilt for https://fedoraproject.org/wiki/Fedora_15_Mass_Rebuild
* Wed Dec 22 2010 Marcela Maslanova <mmaslano@redhat.com> - 1.02-3 * Wed Dec 22 2010 Marcela Maslanova <mmaslano@redhat.com> - 1.02-3
- 661697 rebuild for fixing problems with vendorach/lib - Rebuild to fix problems with vendorarch/lib (#661697)
* Fri May 07 2010 Marcela Maslanova <mmaslano@redhat.com> - 1.02-2 * Fri May 07 2010 Marcela Maslanova <mmaslano@redhat.com> - 1.02-2
- Mass rebuild with perl-5.12.0 - Mass rebuild with perl-5.12.0
* Sun Mar 14 2010 Chris Weyl <cweyl@alumni.drew.edu> 1.02-1 * Sun Mar 14 2010 Chris Weyl <cweyl@alumni.drew.edu> - 1.02-1
- update by Fedora::App::MaintainerTools 0.006 - Update by Fedora::App::MaintainerTools 0.006
- updating to latest GA CPAN version (1.02) - Updating to latest GA CPAN version (1.02)
- added a new br on perl(Carp) (version 0) - Added a new br on perl(Carp) (version 0)
- added a new br on perl(English) (version 0) - Added a new br on perl(English) (version 0)
- altered br on perl(Module::Build) (0 => 0.35) - Altered br on perl(Module::Build) (0 => 0.35)
- altered br on perl(Perl::Critic) (0.21 => 1.105) - Altered br on perl(Perl::Critic) (0.21 => 1.105)
- added a new br on perl(Perl::Critic::Utils) (version 1.105) - Added a new br on perl(Perl::Critic::Utils) (version 1.105)
- added a new br on perl(Perl::Critic::Violation) (version 1.105) - Added a new br on perl(Perl::Critic::Violation) (version 1.105)
- added a new br on perl(Test::Builder) (version 0) - Added a new br on perl(Test::Builder) (version 0)
- added a new br on perl(Test::More) (version 0) - Added a new br on perl(Test::More) (version 0)
- force-adding ExtUtils::MakeMaker as a BR - Force-adding ExtUtils::MakeMaker as a BR
- dropped old BR on perl(Test::Pod) - Dropped old BR on perl(Test::Pod)
- dropped old BR on perl(Test::Pod::Coverage) - Dropped old BR on perl(Test::Pod::Coverage)
- added a new req on perl(Carp) (version 0) - Added a new req on perl(Carp) (version 0)
- added a new req on perl(English) (version 0) - Added a new req on perl(English) (version 0)
- added a new req on perl(Perl::Critic) (version 1.105) - Added a new req on perl(Perl::Critic) (version 1.105)
- added a new req on perl(Perl::Critic::Utils) (version 1.105) - Added a new req on perl(Perl::Critic::Utils) (version 1.105)
- added a new req on perl(Perl::Critic::Violation) (version 1.105) - Added a new req on perl(Perl::Critic::Violation) (version 1.105)
- added a new req on perl(Test::Builder) (version 0) - Added a new req on perl(Test::Builder) (version 0)
* Fri Dec 4 2009 Stepan Kasal <skasal@redhat.com> - 1.01-8 * Fri Dec 4 2009 Stepan Kasal <skasal@redhat.com> - 1.01-8
- rebuild against perl 5.10.1 - Rebuild against perl 5.10.1
* Sun Jul 26 2009 Fedora Release Engineering <rel-eng@lists.fedoraproject.org> - 1.01-7 * Sun Jul 26 2009 Fedora Release Engineering <rel-eng@lists.fedoraproject.org> - 1.01-7
- Rebuilt for https://fedoraproject.org/wiki/Fedora_12_Mass_Rebuild - Rebuilt for https://fedoraproject.org/wiki/Fedora_12_Mass_Rebuild
@ -121,19 +122,19 @@ rm -rf $RPM_BUILD_ROOT
- Rebuild for perl 5.10 (again) - Rebuild for perl 5.10 (again)
* Tue Jan 15 2008 Tom "spot" Callaway <tcallawa@redhat.com> - 1.01-4 * Tue Jan 15 2008 Tom "spot" Callaway <tcallawa@redhat.com> - 1.01-4
- disable tests, take out patch, doesn't fix test failures - Disable tests, take out patch, doesn't fix test failures
* Tue Jan 15 2008 Tom "spot" Callaway <tcallawa@redhat.com> - 1.01-3 * Tue Jan 15 2008 Tom "spot" Callaway <tcallawa@redhat.com> - 1.01-3
- patch for test failure - Patch for test failure
* Mon Jan 14 2008 Tom "spot" Callaway <tcallawa@redhat.com> - 1.01-2 * Mon Jan 14 2008 Tom "spot" Callaway <tcallawa@redhat.com> - 1.01-2
- rebuild for new perl - Rebuild for new perl
* Sat Jan 27 2007 Jose Pedro Oliveira <jpo at di.uminho.pt> - 1.01-1 * Sat Jan 27 2007 Jose Pedro Oliveira <jpo at di.uminho.pt> - 1.01-1
- Update to 1.01. - Update to 1.01
* Sun Nov 12 2006 Jose Pedro Oliveira <jpo at di.uminho.pt> - 0.08-1 * Sun Nov 12 2006 Jose Pedro Oliveira <jpo at di.uminho.pt> - 0.08-1
- Update to 0.08. - Update to 0.08
* Sat Sep 23 2006 Jose Pedro Oliveira <jpo at di.uminho.pt> - 0.07-1 * Sat Sep 23 2006 Jose Pedro Oliveira <jpo at di.uminho.pt> - 0.07-1
- First build. - First build

Write Preview
Loading…
Cancel
Save