Tidy up for EPEL-8 build

- Specify all build dependencies
- Expand %description
- Add patch to fix POD so we get properly-coded manpage
- Modernize spec using %{make_build} and %{make_install}
- Make %files list more explicit
- Use author-independent source URL

Regexp-Common-2013030901-pod.patch

@@ -0,0 +1,14 @@
+Use proper entity name for accented character, so we get properly-encoded
+output.
+
+--- lib/Regexp/Common.pm
++++ lib/Regexp/Common.pm
+@@ -821,7 +821,7 @@
+ Charles Thomas, Chris Vertonghen, the CPAN Testers, David Hand,
+ Fany, Geoffrey Leach, Hermann-Marcus Behrens, Jerome Quelin, Jim Cromie,
+ Lars Wilke, Linda Julien, Mike Arms, Mike Castle, Mikko, Murat Uenalan,
+-RafaE<235>l Garcia-Suarez, Ron Savage, Sam Vilain, Slaven Rezic, Smylers,
++RafaE<euml>l Garcia-Suarez, Ron Savage, Sam Vilain, Slaven Rezic, Smylers,
+ Tim Maher, and all the others I've forgotten.
+ 
+ =head1 AUTHOR

perl-Regexp-Common.spec

@@ -1,21 +1,24 @@
 Name:		perl-Regexp-Common
 Version:	2017060201
-Release:	10%{?dist}
+Release:	11%{?dist}
-Summary:	Regexp::Common Perl module
+Summary:	Provide commonly requested regular expressions
 # Old Artistic 1.0 is also valid, but we won't list it here since it is non-free.
 # Also, it would throw off the automated license check and flag this package.
 License:	Artistic 2.0 or MIT or BSD
 URL:		https://metacpan.org/release/Regexp-Common
-Source0:	https://cpan.metacpan.org/authors/id/A/AB/ABIGAIL/Regexp-Common-%{version}.tar.gz
+Source0:	https://cpan.metacpan.org/modules/by-module/Regexp/Regexp-Common-%{version}.tar.gz
-
+Patch0:		Regexp-Common-2013030901-pod.patch
 BuildArch:	noarch
-
+# Module Build
-BuildRequires:  %{__perl}
+BuildRequires:	coreutils
-BuildRequires:  %{__make}
+BuildRequires:	findutils
-
+BuildRequires:	make
 BuildRequires:	perl-generators
-BuildRequires:	perl(ExtUtils::MakeMaker)
+BuildRequires:	perl-interpreter
+BuildRequires:	perl(ExtUtils::MakeMaker) >= 6.76
+# Module Runtime
 BuildRequires:	perl(Carp)
+BuildRequires:	perl(charnames)
 BuildRequires:	perl(Config)
 BuildRequires:	perl(Exporter)
 BuildRequires:	perl(overload)
@@ -23,36 +26,63 @@ BuildRequires:  perl(re)
 BuildRequires:	perl(strict)
 BuildRequires:	perl(vars)
 BuildRequires:	perl(warnings)
-
+# Test Suite
-# for improved tests
+BuildRequires:	perl(constant)
+BuildRequires:	perl(lib)
 BuildRequires:	perl(Test::More)
+# Optional Tests
 BuildRequires:	perl(Test::Regexp)
-
+# Dependencies
-Requires:	perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version))
+Requires:	perl(:MODULE_COMPAT_%(eval "`perl -V:version`"; echo $version))
+Requires:	perl(Carp)
 
 %description
-Regexp::Common - Provide commonly requested regular expressions
+By default, this module exports a single hash (`%%RE') that stores or generates
+commonly needed regular expressions. Patterns currently provided include:
+
+ * balanced parentheses and brackets
+ * delimited text (with escapes)
+ * integers and floating-point numbers in any base (up to 36)
+ * comments in 44 languages
+ * offensive language
+ * lists of any pattern
+ * IPv4 addresses
+ * URIs
+ * Zip codes
 
 %prep
 %setup -q -n Regexp-Common-%{version}
 
+# Fix POD so we get properly-coded manpage
+%patch0
+
 %build
-%{__perl} Makefile.PL INSTALLDIRS=vendor NO_PACKLIST=1
+perl Makefile.PL INSTALLDIRS=vendor NO_PACKLIST=1 NO_PERLLOCAL=1
-%{__make} %{?_smp_mflags}
+%{make_build}
 
 %install
-%{__make} pure_install PERL_INSTALL_ROOT=$RPM_BUILD_ROOT
+%{make_install}
-chmod -R u+w $RPM_BUILD_ROOT/*
+%{_fixperms} -c %{buildroot}
 
 %check
-%{__make} test
+make test
 
 %files
-%doc TODO README
+%license COPYRIGHT*
-%{perl_vendorlib}/Regexp
+%doc TODO README Changes
-%{_mandir}/man3/*
+%{perl_vendorlib}/Regexp/
+%{_mandir}/man3/Regexp::Common*
 
 %changelog
+* Sun Sep 22 2019 Paul Howarth <paul@city-fan.org> - 2017060201-11
+- Tidy up for EPEL-8 build
+  - Specify all build dependencies
+  - Expand %%description
+  - Add patch to fix POD so we get properly-coded manpage
+  - Modernize spec using %%{make_build} and %%{make_install}
+  - Make %%files list more explicit
+  - Use author-independent source URL
+
 * Fri Jul 26 2019 Fedora Release Engineering <releng@fedoraproject.org> - 2017060201-10
 - Rebuilt for https://fedoraproject.org/wiki/Fedora_31_Mass_Rebuild