Compare commits

..

No commits in common. 'epel9' and 'i9' have entirely different histories.
epel9 ... i9

2
.gitignore vendored

@ -1 +1 @@
/Perl-Critic-[0-9.]*.tar.gz SOURCES/Perl-Critic-1.150.tar.gz

@ -0,0 +1 @@
9f17b8a6a871ab96dfbfc64b0ad78475f781e495 SOURCES/Perl-Critic-1.150.tar.gz

@ -1,4 +1,4 @@
From 3fe891edfb8957d6f89f16cb9bca7e72a7811572 Mon Sep 17 00:00:00 2001 From 15c7267a07b8a1f49b4d8f8a76a363e6a3b87727 Mon Sep 17 00:00:00 2001
From: Paul Howarth <paul@city-fan.org> From: Paul Howarth <paul@city-fan.org>
Date: Fri, 21 Jul 2017 11:50:35 +0100 Date: Fri, 21 Jul 2017 11:50:35 +0100
Subject: [PATCH] Change default spell check tool from aspell to hunspell Subject: [PATCH] Change default spell check tool from aspell to hunspell
@ -22,6 +22,7 @@ minimum version requirement if incorporating this change.
.../BuiltinFunctions/ProhibitLvalueSubstr.pm | 2 +- .../BuiltinFunctions/ProhibitLvalueSubstr.pm | 2 +-
.../Policy/Documentation/PodSpelling.pm | 20 +++++++++---------- .../Policy/Documentation/PodSpelling.pm | 20 +++++++++----------
.../RequireCheckingReturnValueOfEval.pm | 2 +- .../RequireCheckingReturnValueOfEval.pm | 2 +-
.../InputOutput/ProhibitBarewordDirHandles.pm | 2 ++
.../Policy/Modules/RequireBarewordIncludes.pm | 2 ++ .../Policy/Modules/RequireBarewordIncludes.pm | 2 ++
.../ProhibitCaptureWithoutTest.pm | 2 ++ .../ProhibitCaptureWithoutTest.pm | 2 ++
.../ProhibitComplexRegexes.pm | 2 +- .../ProhibitComplexRegexes.pm | 2 +-
@ -36,23 +37,23 @@ minimum version requirement if incorporating this change.
lib/Perl/Critic/Utils/PPI.pm | 2 +- lib/Perl/Critic/Utils/PPI.pm | 2 +-
t/20_policy_pod_spelling.t | 4 ++-- t/20_policy_pod_spelling.t | 4 ++--
xt/40_perlcriticrc-code | 2 +- xt/40_perlcriticrc-code | 2 +-
19 files changed, 38 insertions(+), 20 deletions(-) 20 files changed, 40 insertions(+), 20 deletions(-)
diff --git a/bin/perlcritic b/bin/perlcritic diff --git a/bin/perlcritic b/bin/perlcritic
index e96ca78c..ddc73558 100644 index 1c9280649..806d5d7ae 100644
--- a/bin/perlcritic --- a/bin/perlcritic
+++ b/bin/perlcritic +++ b/bin/perlcritic
@@ -30,7 +30,7 @@ __END__ @@ -31,7 +31,7 @@ __END__
=for stopwords DGR INI-style vim-fu minibuffer -noprofile API =for stopwords DGR INI-style vim-fu minibuffer -noprofile API
-profileproto -profile-proto ben Jore formatter Peshak pbp Komodo -profileproto -profile-proto ben Jore formatter Peshak pbp Komodo
-screenshots tty emacs gVIM plugin Perlish templating ActivePerl screenshots tty emacs gVIM plugin Perlish templating ActivePerl
+screenshots tty emacs grep gVIM plugin Perlish templating ActivePerl -ActiveState Twitter macOS
ActiveState Twitter +ActiveState Twitter macOS 9a
=head1 NAME =head1 NAME
diff --git a/lib/Perl/Critic/Policy/BuiltinFunctions/ProhibitBooleanGrep.pm b/lib/Perl/Critic/Policy/BuiltinFunctions/ProhibitBooleanGrep.pm diff --git a/lib/Perl/Critic/Policy/BuiltinFunctions/ProhibitBooleanGrep.pm b/lib/Perl/Critic/Policy/BuiltinFunctions/ProhibitBooleanGrep.pm
index c39ecd6e..32312c12 100644 index 25d9287a2..400b5c064 100644
--- a/lib/Perl/Critic/Policy/BuiltinFunctions/ProhibitBooleanGrep.pm --- a/lib/Perl/Critic/Policy/BuiltinFunctions/ProhibitBooleanGrep.pm
+++ b/lib/Perl/Critic/Policy/BuiltinFunctions/ProhibitBooleanGrep.pm +++ b/lib/Perl/Critic/Policy/BuiltinFunctions/ProhibitBooleanGrep.pm
@@ -86,6 +86,8 @@ __END__ @@ -86,6 +86,8 @@ __END__
@ -63,9 +64,9 @@ index c39ecd6e..32312c12 100644
+ +
=head1 NAME =head1 NAME
Perl::Critic::Policy::BuiltinFunctions::ProhibitBooleanGrep - Use C<List::MoreUtils::any> instead of C<grep> in boolean context. Perl::Critic::Policy::BuiltinFunctions::ProhibitBooleanGrep - Use C<any> from C<List::Util>, C<List::SomeUtils>, or C<List::MoreUtils> instead of C<grep> in boolean context.
diff --git a/lib/Perl/Critic/Policy/BuiltinFunctions/ProhibitLvalueSubstr.pm b/lib/Perl/Critic/Policy/BuiltinFunctions/ProhibitLvalueSubstr.pm diff --git a/lib/Perl/Critic/Policy/BuiltinFunctions/ProhibitLvalueSubstr.pm b/lib/Perl/Critic/Policy/BuiltinFunctions/ProhibitLvalueSubstr.pm
index 0a77ff00..ddba991d 100644 index 54d44edfe..35b73361b 100644
--- a/lib/Perl/Critic/Policy/BuiltinFunctions/ProhibitLvalueSubstr.pm --- a/lib/Perl/Critic/Policy/BuiltinFunctions/ProhibitLvalueSubstr.pm
+++ b/lib/Perl/Critic/Policy/BuiltinFunctions/ProhibitLvalueSubstr.pm +++ b/lib/Perl/Critic/Policy/BuiltinFunctions/ProhibitLvalueSubstr.pm
@@ -64,7 +64,7 @@ __END__ @@ -64,7 +64,7 @@ __END__
@ -78,10 +79,10 @@ index 0a77ff00..ddba991d 100644
=head1 NAME =head1 NAME
diff --git a/lib/Perl/Critic/Policy/Documentation/PodSpelling.pm b/lib/Perl/Critic/Policy/Documentation/PodSpelling.pm diff --git a/lib/Perl/Critic/Policy/Documentation/PodSpelling.pm b/lib/Perl/Critic/Policy/Documentation/PodSpelling.pm
index 0e133176..98e39f21 100644 index 39dd61c3c..17f05408b 100644
--- a/lib/Perl/Critic/Policy/Documentation/PodSpelling.pm --- a/lib/Perl/Critic/Policy/Documentation/PodSpelling.pm
+++ b/lib/Perl/Critic/Policy/Documentation/PodSpelling.pm +++ b/lib/Perl/Critic/Policy/Documentation/PodSpelling.pm
@@ -39,7 +39,7 @@ sub supported_parameters { @@ -37,7 +37,7 @@ sub supported_parameters {
{ {
name => 'spell_command', name => 'spell_command',
description => 'The command to invoke to check spelling.', description => 'The command to invoke to check spelling.',
@ -138,7 +139,7 @@ index 0e133176..98e39f21 100644
Pod::Spell->new()->parse_from_file("lib/Your/Module.pm")' >> to see what is Pod::Spell->new()->parse_from_file("lib/Your/Module.pm")' >> to see what is
actually being checked for spelling. actually being checked for spelling.
diff --git a/lib/Perl/Critic/Policy/ErrorHandling/RequireCheckingReturnValueOfEval.pm b/lib/Perl/Critic/Policy/ErrorHandling/RequireCheckingReturnValueOfEval.pm diff --git a/lib/Perl/Critic/Policy/ErrorHandling/RequireCheckingReturnValueOfEval.pm b/lib/Perl/Critic/Policy/ErrorHandling/RequireCheckingReturnValueOfEval.pm
index 1144d6b0..924bfe2c 100644 index 22bed5580..60e4ff73e 100644
--- a/lib/Perl/Critic/Policy/ErrorHandling/RequireCheckingReturnValueOfEval.pm --- a/lib/Perl/Critic/Policy/ErrorHandling/RequireCheckingReturnValueOfEval.pm
+++ b/lib/Perl/Critic/Policy/ErrorHandling/RequireCheckingReturnValueOfEval.pm +++ b/lib/Perl/Critic/Policy/ErrorHandling/RequireCheckingReturnValueOfEval.pm
@@ -317,7 +317,7 @@ __END__ @@ -317,7 +317,7 @@ __END__
@ -150,8 +151,21 @@ index 1144d6b0..924bfe2c 100644
=head1 NAME =head1 NAME
diff --git a/lib/Perl/Critic/Policy/InputOutput/ProhibitBarewordDirHandles.pm b/lib/Perl/Critic/Policy/InputOutput/ProhibitBarewordDirHandles.pm
index 1415f272e..6151e9a22 100644
--- a/lib/Perl/Critic/Policy/InputOutput/ProhibitBarewordDirHandles.pm
+++ b/lib/Perl/Critic/Policy/InputOutput/ProhibitBarewordDirHandles.pm
@@ -61,6 +61,8 @@ __END__
=pod
+=for stopwords Perl7
+
=head1 NAME
Perl::Critic::Policy::InputOutput::ProhibitBarewordDirHandles - Write C<opendir my $dh, $dirname;> instead of C<opendir DH, $dirname;>.
diff --git a/lib/Perl/Critic/Policy/Modules/RequireBarewordIncludes.pm b/lib/Perl/Critic/Policy/Modules/RequireBarewordIncludes.pm diff --git a/lib/Perl/Critic/Policy/Modules/RequireBarewordIncludes.pm b/lib/Perl/Critic/Policy/Modules/RequireBarewordIncludes.pm
index d570f207..934964b6 100644 index ccf05bc50..fda78fb1c 100644
--- a/lib/Perl/Critic/Policy/Modules/RequireBarewordIncludes.pm --- a/lib/Perl/Critic/Policy/Modules/RequireBarewordIncludes.pm
+++ b/lib/Perl/Critic/Policy/Modules/RequireBarewordIncludes.pm +++ b/lib/Perl/Critic/Policy/Modules/RequireBarewordIncludes.pm
@@ -46,6 +46,8 @@ __END__ @@ -46,6 +46,8 @@ __END__
@ -164,7 +178,7 @@ index d570f207..934964b6 100644
Perl::Critic::Policy::Modules::RequireBarewordIncludes - Write C<require Module> instead of C<require 'Module.pm'>. Perl::Critic::Policy::Modules::RequireBarewordIncludes - Write C<require Module> instead of C<require 'Module.pm'>.
diff --git a/lib/Perl/Critic/Policy/RegularExpressions/ProhibitCaptureWithoutTest.pm b/lib/Perl/Critic/Policy/RegularExpressions/ProhibitCaptureWithoutTest.pm diff --git a/lib/Perl/Critic/Policy/RegularExpressions/ProhibitCaptureWithoutTest.pm b/lib/Perl/Critic/Policy/RegularExpressions/ProhibitCaptureWithoutTest.pm
index 8dc04937..5d971e1a 100644 index db8c446d4..afd380440 100644
--- a/lib/Perl/Critic/Policy/RegularExpressions/ProhibitCaptureWithoutTest.pm --- a/lib/Perl/Critic/Policy/RegularExpressions/ProhibitCaptureWithoutTest.pm
+++ b/lib/Perl/Critic/Policy/RegularExpressions/ProhibitCaptureWithoutTest.pm +++ b/lib/Perl/Critic/Policy/RegularExpressions/ProhibitCaptureWithoutTest.pm
@@ -307,6 +307,8 @@ __END__ @@ -307,6 +307,8 @@ __END__
@ -177,10 +191,10 @@ index 8dc04937..5d971e1a 100644
Perl::Critic::Policy::RegularExpressions::ProhibitCaptureWithoutTest - Capture variable used outside conditional. Perl::Critic::Policy::RegularExpressions::ProhibitCaptureWithoutTest - Capture variable used outside conditional.
diff --git a/lib/Perl/Critic/Policy/RegularExpressions/ProhibitComplexRegexes.pm b/lib/Perl/Critic/Policy/RegularExpressions/ProhibitComplexRegexes.pm diff --git a/lib/Perl/Critic/Policy/RegularExpressions/ProhibitComplexRegexes.pm b/lib/Perl/Critic/Policy/RegularExpressions/ProhibitComplexRegexes.pm
index 647ffb4a..a6ce7af6 100644 index d988378d8..27df0013e 100644
--- a/lib/Perl/Critic/Policy/RegularExpressions/ProhibitComplexRegexes.pm --- a/lib/Perl/Critic/Policy/RegularExpressions/ProhibitComplexRegexes.pm
+++ b/lib/Perl/Critic/Policy/RegularExpressions/ProhibitComplexRegexes.pm +++ b/lib/Perl/Critic/Policy/RegularExpressions/ProhibitComplexRegexes.pm
@@ -99,7 +99,7 @@ __END__ @@ -97,7 +97,7 @@ __END__
=pod =pod
@ -190,10 +204,10 @@ index 647ffb4a..a6ce7af6 100644
=head1 NAME =head1 NAME
diff --git a/lib/Perl/Critic/Policy/RegularExpressions/ProhibitFixedStringMatches.pm b/lib/Perl/Critic/Policy/RegularExpressions/ProhibitFixedStringMatches.pm diff --git a/lib/Perl/Critic/Policy/RegularExpressions/ProhibitFixedStringMatches.pm b/lib/Perl/Critic/Policy/RegularExpressions/ProhibitFixedStringMatches.pm
index 63704bad..dc9e1778 100644 index bf994b65c..222c008c7 100644
--- a/lib/Perl/Critic/Policy/RegularExpressions/ProhibitFixedStringMatches.pm --- a/lib/Perl/Critic/Policy/RegularExpressions/ProhibitFixedStringMatches.pm
+++ b/lib/Perl/Critic/Policy/RegularExpressions/ProhibitFixedStringMatches.pm +++ b/lib/Perl/Critic/Policy/RegularExpressions/ProhibitFixedStringMatches.pm
@@ -82,6 +82,8 @@ __END__ @@ -78,6 +78,8 @@ __END__
=pod =pod
@ -203,10 +217,10 @@ index 63704bad..dc9e1778 100644
Perl::Critic::Policy::RegularExpressions::ProhibitFixedStringMatches - Use C<eq> or hash instead of fixed-pattern regexps. Perl::Critic::Policy::RegularExpressions::ProhibitFixedStringMatches - Use C<eq> or hash instead of fixed-pattern regexps.
diff --git a/lib/Perl/Critic/Policy/RegularExpressions/ProhibitSingleCharAlternation.pm b/lib/Perl/Critic/Policy/RegularExpressions/ProhibitSingleCharAlternation.pm diff --git a/lib/Perl/Critic/Policy/RegularExpressions/ProhibitSingleCharAlternation.pm b/lib/Perl/Critic/Policy/RegularExpressions/ProhibitSingleCharAlternation.pm
index e1d8ee51..6bc416d7 100644 index 0b5c69d97..939b7662c 100644
--- a/lib/Perl/Critic/Policy/RegularExpressions/ProhibitSingleCharAlternation.pm --- a/lib/Perl/Critic/Policy/RegularExpressions/ProhibitSingleCharAlternation.pm
+++ b/lib/Perl/Critic/Policy/RegularExpressions/ProhibitSingleCharAlternation.pm +++ b/lib/Perl/Critic/Policy/RegularExpressions/ProhibitSingleCharAlternation.pm
@@ -82,6 +82,8 @@ __END__ @@ -80,6 +80,8 @@ __END__
=pod =pod
@ -216,10 +230,10 @@ index e1d8ee51..6bc416d7 100644
Perl::Critic::Policy::RegularExpressions::ProhibitSingleCharAlternation - Use C<[abc]> instead of C<a|b|c>. Perl::Critic::Policy::RegularExpressions::ProhibitSingleCharAlternation - Use C<[abc]> instead of C<a|b|c>.
diff --git a/lib/Perl/Critic/Policy/RegularExpressions/ProhibitUnusedCapture.pm b/lib/Perl/Critic/Policy/RegularExpressions/ProhibitUnusedCapture.pm diff --git a/lib/Perl/Critic/Policy/RegularExpressions/ProhibitUnusedCapture.pm b/lib/Perl/Critic/Policy/RegularExpressions/ProhibitUnusedCapture.pm
index 5cecad63..4a357ebd 100644 index 54121cc5e..1f9b99c7c 100644
--- a/lib/Perl/Critic/Policy/RegularExpressions/ProhibitUnusedCapture.pm --- a/lib/Perl/Critic/Policy/RegularExpressions/ProhibitUnusedCapture.pm
+++ b/lib/Perl/Critic/Policy/RegularExpressions/ProhibitUnusedCapture.pm +++ b/lib/Perl/Critic/Policy/RegularExpressions/ProhibitUnusedCapture.pm
@@ -715,7 +715,7 @@ __END__ @@ -751,7 +751,7 @@ __END__
=pod =pod
@ -229,10 +243,10 @@ index 5cecad63..4a357ebd 100644
=head1 NAME =head1 NAME
diff --git a/lib/Perl/Critic/Policy/RegularExpressions/ProhibitUnusualDelimiters.pm b/lib/Perl/Critic/Policy/RegularExpressions/ProhibitUnusualDelimiters.pm diff --git a/lib/Perl/Critic/Policy/RegularExpressions/ProhibitUnusualDelimiters.pm b/lib/Perl/Critic/Policy/RegularExpressions/ProhibitUnusualDelimiters.pm
index cfdce6be..a69e064c 100644 index 2977f7592..807c9724b 100644
--- a/lib/Perl/Critic/Policy/RegularExpressions/ProhibitUnusualDelimiters.pm --- a/lib/Perl/Critic/Policy/RegularExpressions/ProhibitUnusualDelimiters.pm
+++ b/lib/Perl/Critic/Policy/RegularExpressions/ProhibitUnusualDelimiters.pm +++ b/lib/Perl/Critic/Policy/RegularExpressions/ProhibitUnusualDelimiters.pm
@@ -77,6 +77,8 @@ __END__ @@ -74,6 +74,8 @@ __END__
=pod =pod
@ -242,10 +256,10 @@ index cfdce6be..a69e064c 100644
Perl::Critic::Policy::RegularExpressions::ProhibitUnusualDelimiters - Use only C<//> or C<{}> to delimit regexps. Perl::Critic::Policy::RegularExpressions::ProhibitUnusualDelimiters - Use only C<//> or C<{}> to delimit regexps.
diff --git a/lib/Perl/Critic/Policy/RegularExpressions/RequireBracesForMultiline.pm b/lib/Perl/Critic/Policy/RegularExpressions/RequireBracesForMultiline.pm diff --git a/lib/Perl/Critic/Policy/RegularExpressions/RequireBracesForMultiline.pm b/lib/Perl/Critic/Policy/RegularExpressions/RequireBracesForMultiline.pm
index c3a063ca..ac8344f3 100644 index 230e1cf76..17fbfaf55 100644
--- a/lib/Perl/Critic/Policy/RegularExpressions/RequireBracesForMultiline.pm --- a/lib/Perl/Critic/Policy/RegularExpressions/RequireBracesForMultiline.pm
+++ b/lib/Perl/Critic/Policy/RegularExpressions/RequireBracesForMultiline.pm +++ b/lib/Perl/Critic/Policy/RegularExpressions/RequireBracesForMultiline.pm
@@ -77,6 +77,8 @@ __END__ @@ -74,6 +74,8 @@ __END__
=pod =pod
@ -255,10 +269,10 @@ index c3a063ca..ac8344f3 100644
Perl::Critic::Policy::RegularExpressions::RequireBracesForMultiline - Use C<{> and C<}> to delimit multi-line regexps. Perl::Critic::Policy::RegularExpressions::RequireBracesForMultiline - Use C<{> and C<}> to delimit multi-line regexps.
diff --git a/lib/Perl/Critic/Policy/Variables/ProhibitPunctuationVars.pm b/lib/Perl/Critic/Policy/Variables/ProhibitPunctuationVars.pm diff --git a/lib/Perl/Critic/Policy/Variables/ProhibitPunctuationVars.pm b/lib/Perl/Critic/Policy/Variables/ProhibitPunctuationVars.pm
index f136daf8..953ddd6c 100644 index 05ecd19ba..0e9ebb464 100644
--- a/lib/Perl/Critic/Policy/Variables/ProhibitPunctuationVars.pm --- a/lib/Perl/Critic/Policy/Variables/ProhibitPunctuationVars.pm
+++ b/lib/Perl/Critic/Policy/Variables/ProhibitPunctuationVars.pm +++ b/lib/Perl/Critic/Policy/Variables/ProhibitPunctuationVars.pm
@@ -367,6 +367,8 @@ __END__ @@ -362,6 +362,8 @@ __END__
=pod =pod
@ -268,7 +282,7 @@ index f136daf8..953ddd6c 100644
Perl::Critic::Policy::Variables::ProhibitPunctuationVars - Write C<$EVAL_ERROR> instead of C<$@>. Perl::Critic::Policy::Variables::ProhibitPunctuationVars - Write C<$EVAL_ERROR> instead of C<$@>.
diff --git a/lib/Perl/Critic/Policy/Variables/RequireLexicalLoopIterators.pm b/lib/Perl/Critic/Policy/Variables/RequireLexicalLoopIterators.pm diff --git a/lib/Perl/Critic/Policy/Variables/RequireLexicalLoopIterators.pm b/lib/Perl/Critic/Policy/Variables/RequireLexicalLoopIterators.pm
index 6c3b0842..3be56443 100644 index be45acd03..4ca201211 100644
--- a/lib/Perl/Critic/Policy/Variables/RequireLexicalLoopIterators.pm --- a/lib/Perl/Critic/Policy/Variables/RequireLexicalLoopIterators.pm
+++ b/lib/Perl/Critic/Policy/Variables/RequireLexicalLoopIterators.pm +++ b/lib/Perl/Critic/Policy/Variables/RequireLexicalLoopIterators.pm
@@ -66,7 +66,7 @@ __END__ @@ -66,7 +66,7 @@ __END__
@ -281,10 +295,10 @@ index 6c3b0842..3be56443 100644
=head1 NAME =head1 NAME
diff --git a/lib/Perl/Critic/Utils.pm b/lib/Perl/Critic/Utils.pm diff --git a/lib/Perl/Critic/Utils.pm b/lib/Perl/Critic/Utils.pm
index 43833170..ef023c82 100644 index 56634afe3..42c66caad 100644
--- a/lib/Perl/Critic/Utils.pm --- a/lib/Perl/Critic/Utils.pm
+++ b/lib/Perl/Critic/Utils.pm +++ b/lib/Perl/Critic/Utils.pm
@@ -1397,6 +1397,8 @@ __END__ @@ -1387,6 +1387,8 @@ __END__
=pod =pod
@ -294,7 +308,7 @@ index 43833170..ef023c82 100644
Perl::Critic::Utils - General utility subroutines and constants for Perl::Critic and derivative distributions. Perl::Critic::Utils - General utility subroutines and constants for Perl::Critic and derivative distributions.
diff --git a/lib/Perl/Critic/Utils/PPI.pm b/lib/Perl/Critic/Utils/PPI.pm diff --git a/lib/Perl/Critic/Utils/PPI.pm b/lib/Perl/Critic/Utils/PPI.pm
index 5700d3f4..aeb31cf4 100644 index c8ee41ffa..7d4b11e7c 100644
--- a/lib/Perl/Critic/Utils/PPI.pm --- a/lib/Perl/Critic/Utils/PPI.pm
+++ b/lib/Perl/Critic/Utils/PPI.pm +++ b/lib/Perl/Critic/Utils/PPI.pm
@@ -235,7 +235,7 @@ __END__ @@ -235,7 +235,7 @@ __END__
@ -307,7 +321,7 @@ index 5700d3f4..aeb31cf4 100644
=head1 NAME =head1 NAME
diff --git a/t/20_policy_pod_spelling.t b/t/20_policy_pod_spelling.t diff --git a/t/20_policy_pod_spelling.t b/t/20_policy_pod_spelling.t
index 3d97d80c..a3bbf72c 100644 index 597740ea0..d1c88a3da 100644
--- a/t/20_policy_pod_spelling.t --- a/t/20_policy_pod_spelling.t
+++ b/t/20_policy_pod_spelling.t +++ b/t/20_policy_pod_spelling.t
@@ -58,10 +58,10 @@ $code = <<'END_PERL'; @@ -58,10 +58,10 @@ $code = <<'END_PERL';
@ -324,7 +338,7 @@ index 3d97d80c..a3bbf72c 100644
if ( ! eval { ! pcritique($policy, \$code) } ) { if ( ! eval { ! pcritique($policy, \$code) } ) {
skip 'Test environment is not English', $NUMBER_OF_TESTS; skip 'Test environment is not English', $NUMBER_OF_TESTS;
diff --git a/xt/40_perlcriticrc-code b/xt/40_perlcriticrc-code diff --git a/xt/40_perlcriticrc-code b/xt/40_perlcriticrc-code
index c63df2ca..b0df69f9 100644 index cc72b1d41..3a58da152 100644
--- a/xt/40_perlcriticrc-code --- a/xt/40_perlcriticrc-code
+++ b/xt/40_perlcriticrc-code +++ b/xt/40_perlcriticrc-code
@@ -17,7 +17,7 @@ strict = 1 @@ -17,7 +17,7 @@ strict = 1
@ -337,5 +351,5 @@ index c63df2ca..b0df69f9 100644
[Documentation::RequirePodSections] [Documentation::RequirePodSections]
-- --
2.30.2 2.39.2

@ -6,10 +6,10 @@
%endif %endif
Name: perl-Perl-Critic Name: perl-Perl-Critic
Version: 1.140 Version: 1.150
Release: 1%{?dist} Release: 1%{?dist}
Summary: Critique Perl source code for best-practices Summary: Critique Perl source code for best-practices
License: GPL+ or Artistic License: GPL-1.0-or-later OR Artistic-1.0-Perl
URL: https://metacpan.org/release/Perl-Critic URL: https://metacpan.org/release/Perl-Critic
Source0: https://cpan.metacpan.org/modules/by-module/Perl/Perl-Critic-%{version}.tar.gz Source0: https://cpan.metacpan.org/modules/by-module/Perl/Perl-Critic-%{version}.tar.gz
Patch0: 0001-Change-default-spell-check-tool-from-aspell-to-hunsp.patch Patch0: 0001-Change-default-spell-check-tool-from-aspell-to-hunsp.patch
@ -21,15 +21,15 @@ BuildRequires: coreutils
BuildRequires: findutils BuildRequires: findutils
BuildRequires: perl-generators BuildRequires: perl-generators
BuildRequires: perl-interpreter BuildRequires: perl-interpreter
BuildRequires: perl(Fatal)
BuildRequires: perl(lib) BuildRequires: perl(lib)
BuildRequires: perl(Module::Build) >= 0.42 BuildRequires: perl(Module::Build) >= 0.42
BuildRequires: perl(Task::Weaken)
# Module requirements # Module requirements
BuildRequires: hunspell >= 1.2.12 BuildRequires: hunspell >= 1.2.12
BuildRequires: hunspell-en BuildRequires: hunspell-en
BuildRequires: perl(B::Keywords) >= 1.05 BuildRequires: perl(:VERSION) >= 5.10.1
BuildRequires: perl(base) BuildRequires: perl(B::Keywords) >= 1.23
BuildRequires: perl(Carp) BuildRequires: perl(Carp)
BuildRequires: perl(Config::Tiny) >= 2 BuildRequires: perl(Config::Tiny) >= 2
BuildRequires: perl(English) BuildRequires: perl(English)
@ -42,22 +42,20 @@ BuildRequires: perl(File::Spec::Unix)
BuildRequires: perl(File::Temp) BuildRequires: perl(File::Temp)
BuildRequires: perl(File::Which) BuildRequires: perl(File::Which)
BuildRequires: perl(Getopt::Long) BuildRequires: perl(Getopt::Long)
BuildRequires: perl(IO::String) BuildRequires: perl(List::SomeUtils) >= 0.55
BuildRequires: perl(List::MoreUtils) >= 0.19
BuildRequires: perl(List::Util) BuildRequires: perl(List::Util)
BuildRequires: perl(Module::Pluggable) >= 3.1 BuildRequires: perl(Module::Pluggable) >= 3.1
BuildRequires: perl(parent)
BuildRequires: perl(Perl::Tidy) BuildRequires: perl(Perl::Tidy)
BuildRequires: perl(Pod::Parser)
BuildRequires: perl(Pod::PlainText) BuildRequires: perl(Pod::PlainText)
BuildRequires: perl(Pod::Select) BuildRequires: perl(Pod::Select)
BuildRequires: perl(Pod::Spell) >= 1 BuildRequires: perl(Pod::Spell) >= 1
BuildRequires: perl(Pod::Usage) BuildRequires: perl(Pod::Usage)
BuildRequires: perl(PPI) >= 1.265 BuildRequires: perl(PPI) >= 1.271
BuildRequires: perl(PPIx::QuoteLike) BuildRequires: perl(PPIx::QuoteLike)
BuildRequires: perl(PPIx::Regexp) >= 0.010 BuildRequires: perl(PPIx::Regexp) >= 0.010
BuildRequires: perl(PPIx::Regexp::Util) >= 0.068 BuildRequires: perl(PPIx::Regexp::Util) >= 0.068
BuildRequires: perl(PPIx::Utilities::Node) BuildRequires: perl(PPIx::Utils::Traversal) >= 0.003
BuildRequires: perl(PPIx::Utilities::Statement) >= 1.001
BuildRequires: perl(Readonly) >= 2 BuildRequires: perl(Readonly) >= 2
BuildRequires: perl(Scalar::Util) BuildRequires: perl(Scalar::Util)
BuildRequires: perl(strict) BuildRequires: perl(strict)
@ -72,9 +70,7 @@ BuildRequires: perl(warnings)
%if 0%{?fedora} > 23 || 0%{?rhel} > 7 %if 0%{?fedora} > 23 || 0%{?rhel} > 7
BuildRequires: glibc-langpack-en BuildRequires: glibc-langpack-en
%endif %endif
BuildRequires: perl(Fatal)
BuildRequires: perl(File::Spec::Functions) BuildRequires: perl(File::Spec::Functions)
BuildRequires: perl(Test::Deep)
BuildRequires: perl(Test::Memory::Cycle) BuildRequires: perl(Test::Memory::Cycle)
BuildRequires: perl(Test::More) BuildRequires: perl(Test::More)
@ -93,12 +89,11 @@ BuildRequires: perl(Test::Without::Module)
%endif %endif
# Optional/not automatically detected runtime dependencies # Optional/not automatically detected runtime dependencies
Requires: perl(:MODULE_COMPAT_%(eval "`perl -V:version`"; echo $version))
Requires: hunspell >= 1.2.12 Requires: hunspell >= 1.2.12
Requires: perl(B::Keywords) >= 1.23
Requires: perl(File::Which) Requires: perl(File::Which)
Requires: perl(Module::Pluggable) >= 3.1 Requires: perl(Module::Pluggable) >= 3.1
Requires: perl(Pod::Parser) Requires: perl(PPI) >= 1.271
Requires: perl(PPI) >= 1.265
Requires: perl(Term::ANSIColor) >= 2.02 Requires: perl(Term::ANSIColor) >= 2.02
%description %description
@ -163,6 +158,138 @@ LC_ALL=en_US ./Build test
%{_mandir}/man3/Test::Perl::Critic::Policy.3* %{_mandir}/man3/Test::Perl::Critic::Policy.3*
%changelog %changelog
* Tue Sep 19 2023 Arkady L. Shane <tigro@msvsphere-os.ru> - 1.150-1
- Rebuilt for MSVSphere 9.2
* Sun Mar 5 2023 Paul Howarth <paul@city-fan.org> - 1.150-1
- Update to 1.150 (rhnz#2175475)
Enhancements
- Added Test::Builder and Text::Wrap to the list of default exceptions in
Variables::ProhibitPackageVars (GH#1025)
Internals
- We now use PPIx::Utils instead of PPIx::Utilities, which is more recently
maintained
* Fri Jan 20 2023 Fedora Release Engineering <releng@fedoraproject.org> - 1.148-2
- Rebuilt for https://fedoraproject.org/wiki/Fedora_38_Mass_Rebuild
* Sun Jan 8 2023 Paul Howarth <paul@city-fan.org> - 1.148-1
- Update to 1.148 (rhbz#2159041)
Possible breakage
- Removed Perl::Critic::Utils::DataConversion; any add-on policies that used
it will need to copy the functions from there into their own code
Documentation
- ProhibitCascadingIfElse no longer suggests using given/when
Internals
- We no longer require Test::Deep for testing
- Test::Kwalitee is now only recommended, not required
- Random micro-optimizations, like using hashes for array contents checking,
and using any() instead of calling grep as a boolean
* Thu Dec 22 2022 Paul Howarth <paul@city-fan.org> - 1.146-1
- Update to 1.146 (rhbz#2155727)
New features
- ProhibitBarewordDirHandles now checks for sysopen as well as open (GH#732)
- Added a Dockerfile in the extras/ directory for those who want to run P::C
in a container (GH#832)
- Subroutines::ProhibitBuiltinHomonyms now can take an "allows" parameter to
specify subroutines that won't violate the policy (GH#14, GH#932)
- ProhibitStringyEval now allows package declarations in evals when
allow_includes = true; this is a common way packages are declared (GH#908)
Bug Fixes
- Fixed some problems with how Perl::Critic determined scope (GH#793)
- Fixed improper violation for lexical subroutines in
Subroutines::ProhibitBuiltinHomonyms (GH#973, GH#955, GH#546)
- ValuesAndExpressions::RequireNumberSeparators no longer complains if your
version numbers do not have number separators in them (GH#856, GH#904)
- Fixed a false positive with split() in ProhibitUnusedCapture (GH#888)
Internals
- We no longer use or need IO::String (GH#997)
- Removed requirements and mentions of modules no longer used:
- Fatal
- IO::String
- IPC::Open2
- Pod::Parser
- Task::Weaken
* Tue Dec 6 2022 Paul Howarth <paul@city-fan.org> - 1.144-1
- Update to 1.144 (rhbz#2151095)
- Perl::Critic now requires Perl 5.10.1
New features
- The ProhibitAugmentedAssignmentInDeclaration policy now allows augmented
assignments to "our" variables, if the allow_our option is enabled (GH#993)
- ProhibitExplicitISA now recommends "use parent" instead of "use base"
(GH#987)
- RequireUseWarnings now recognizes that "use v5.36" implies warnings (GH#984)
- Subroutines::ProhibitNestedSubs now allows that lexical subroutines can be
inside other subroutines (GH#946, GH#971, GH#972)
- RequireUseStrict now knows that Test::Spec enables it (GH#906)
- ProhibitUnusedCapture now understands @{^CAPTURE} and %%{^CAPTURE_ALL} that
were added in Perl 5.26.0 (GH#778)
- Allow numeric operators on special number strings 'NaN' and 'inf' (GH#803)
Fixes
- Miscellanea::ProhibitUselessNoCritic no longer filters out errors about
itself, just as Miscellanea::ProhibitUnrestrictedNoCritic cannot (GH#939)
- Fixed GH#878: bareword filehandle dies on "open(CHECK, '/foo');"
Internals
- Updated to using Perl 5.10.1; starting migrating to Perl 5.10-isms like
defined-or
Documentation
- Updated some outdated docs in Perl::Critic::Utils (GH#951)
* Tue Nov 29 2022 Paul Howarth <paul@city-fan.org> - 1.142-1
- Update to 1.142 (rhbz#2149154)
- This is the last version of Perl::Critic that will run on Perl 5.6.1; the
next release will require Perl 5.10.1
New Features
- Add new policy InputOutput::ProhibitBarewordDirHandles, comparable to
ProhibitBarewordFilehandles (GH#912)
- References::ProhibitDoubleSigils policy now allows for Perl's postfix
dereference syntax and does not report a policy violation (GH#578)
- Added Test::Class::Moose and MooseX::MethodAttributes::Role to the list of
modules that are equivalent to "use strict" (GH#808, GH#886)
- Subroutines::RequireArgUnpacking now detects anonymous subroutines with
attributes, prototypes or signatures (GH#684)
- ProhibitVoidMap and ProhibitVoidGrep now detect void context inside subs
(GH#905), such as: sub { map { foo($_) } @list; return }
- RequireArgUnpacking now allows a closure to be recognized as a way that
subroutine arguments can be unpacked; this is specified with an optional
allow_closures configuration option (GH#737)
- ProhibitTwoArgOpen now disallows one-arg opens as well; also, it no longer
allows two-arg opening of STDIN/STDOUT/STDERR (GH#652, GH#653)
Fixes
- ProhibitLeadingZeros would not handle sysopen and lexical variables
correctly; this has been fixed (GH#789)
Documentation
- We note that the any() function is available in both List::MoreUtils and
List::SomeUtils
- Added instructions to perlcritic on how to integrate with Visual Studio
Code
Internals
- Switch to using List::SomeUtils instead of List::MoreUtils
- Use SPDX-format license tag
* Fri Jul 22 2022 Fedora Release Engineering <releng@fedoraproject.org> - 1.140-8
- Rebuilt for https://fedoraproject.org/wiki/Fedora_37_Mass_Rebuild
* Fri Jun 03 2022 Jitka Plesnikova <jplesnik@redhat.com> - 1.140-7
- Perl 5.36 re-rebuild of bootstrapped packages
* Wed Jun 01 2022 Jitka Plesnikova <jplesnik@redhat.com> - 1.140-6
- Perl 5.36 rebuild
* Fri Jan 21 2022 Fedora Release Engineering <releng@fedoraproject.org> - 1.140-5
- Rebuilt for https://fedoraproject.org/wiki/Fedora_36_Mass_Rebuild
* Thu Jul 22 2021 Fedora Release Engineering <releng@fedoraproject.org> - 1.140-4
- Rebuilt for https://fedoraproject.org/wiki/Fedora_35_Mass_Rebuild
* Mon May 24 2021 Jitka Plesnikova <jplesnik@redhat.com> - 1.140-3
- Perl 5.34 re-rebuild of bootstrapped packages
* Sat May 22 2021 Jitka Plesnikova <jplesnik@redhat.com> - 1.140-2
- Perl 5.34 rebuild
* Wed Mar 24 2021 Paul Howarth <paul@city-fan.org> - 1.140-1 * Wed Mar 24 2021 Paul Howarth <paul@city-fan.org> - 1.140-1
- Update to 1.140 - Update to 1.140
- Subroutines::RequireFinalReturn now lets you specify a terminal_methods - Subroutines::RequireFinalReturn now lets you specify a terminal_methods

@ -1 +0,0 @@
SHA512 (Perl-Critic-1.140.tar.gz) = 46afc8260d2b500edbb29836be993f065270ed9ffa6aa00611a980b294025b794286bc820afeabb94b7d1cdd9bfb4e715e44e466fb0340cb9d938e031b54a6f0
Loading…
Cancel
Save