Spec clean-up

- Drop redundant perl and perl(ExtUtils::AutoInstall) buildreqs
- BR: perl(Carp), perl(Scalar::Util) ≥ 1.11, perl(Test::More)
- Use DESTDIR rather than PERL_INSTALL_ROOT
- Set AUTOMATED_TESTING=1 to enable Pod test
- Use search.cpan.org source URL
- Fix typo in %description
- Make %files list more explicit
- Don't use macros for commands
- Use tabs

.gitignore

@@ -1 +1 @@
-Params-Coerce-0.14.tar.gz
+/Params-Coerce-[0-9.]*.tar.gz

perl-Params-Coerce.spec

@@ -1,47 +1,42 @@
-Name:           perl-Params-Coerce
+Name:		perl-Params-Coerce
-Version:        0.14
+Version:	0.14
-Release:        10%{?dist}
+Release:	11%{?dist}
-Summary:        Allows your classes to do coercion of parameters
+Summary:	Allows your classes to do coercion of parameters
-License:        GPL+ or Artistic
+License:	GPL+ or Artistic
-Group:          Development/Libraries
+Group:		Development/Libraries
-URL:            http://search.cpan.org/dist/Params-Coerce/
+URL:		http://search.cpan.org/dist/Params-Coerce/
-Source0:        http://www.cpan.org/authors/id/A/AD/ADAMK/Params-Coerce-%{version}.tar.gz
+Source0:	http://search.cpan.org/CPAN/authors/id/A/AD/ADAMK/Params-Coerce-%{version}.tar.gz
-BuildRoot:      %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
+BuildArch:	noarch
-BuildArch:      noarch
+BuildRoot:	%{_tmppath}/%{name}-%{version}-%{release}-root-%(id -nu)
-
+BuildRequires:	perl(Carp)
-BuildRequires:  perl >= 0:5.005
+BuildRequires:	perl(Params::Util) >= 0.05
-BuildRequires:  perl(Params::Util) >= 0.05
+BuildRequires:	perl(Scalar::Util) >= 1.11
-BuildRequires:  perl(ExtUtils::AutoInstall) >= 0.49, perl(Test::Pod) >= 1.00
+BuildRequires:	perl(Test::More)
-
+BuildRequires:	perl(Test::Pod) >= 1.00
-# cpanspec autogenerated requires...
+Requires:	perl(:MODULE_COMPAT_%(eval "`perl -V:version`"; echo $version))
-#Requires:       perl(Params::Util) >= 0.05
-
-Requires:       perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version))
 
 %description
 A big part of good API design is that we should be able to be flexible in
 the ways that we take parameters. Params::Coerce attempts to encourage this,
 by making it easier to take a variety of different arguments, while adding 
-negligable additional complexity to your code.
+negligible additional complexity to your code.
 
 %prep
 %setup -q -n Params-Coerce-%{version}
 
 %build
-%{__perl} Makefile.PL INSTALLDIRS=vendor
+perl Makefile.PL INSTALLDIRS=vendor
 make %{?_smp_mflags}
 
 %install
 rm -rf %{buildroot}
-
+make pure_install DESTDIR=%{buildroot}
-make pure_install PERL_INSTALL_ROOT=%{buildroot}
 find %{buildroot} -type f -name .packlist -exec rm -f {} \;
-find %{buildroot} -depth -type d -exec rmdir {} 2>/dev/null \;
+find %{buildroot} -depth -type d -exec rmdir {} \; 2>/dev/null
-
+%{_fixperms} %{buildroot}
-%{_fixperms} %{buildroot}/*
 
 %check
-make test
+make test AUTOMATED_TESTING=1
 
 %clean
 rm -rf %{buildroot}
@@ -49,10 +44,22 @@ rm -rf %{buildroot}
 %files
 %defattr(-,root,root,-)
 %doc Changes LICENSE README
-%{perl_vendorlib}/*
+%{perl_vendorlib}/Params/
-%{_mandir}/man3/*
+%{_mandir}/man3/Params::Coerce.3pm*
 
 %changelog
+* Wed Feb 15 2012 Paul Howarth <paul@city-fan.org> - 0.14-11
+- Spec clean-up:
+  - Drop redundant perl and perl(ExtUtils::AutoInstall) buildreqs
+  - BR: perl(Carp), perl(Scalar::Util) ≥ 1.11, perl(Test::More)
+  - Use DESTDIR rather than PERL_INSTALL_ROOT
+  - Set AUTOMATED_TESTING=1 to enable Pod test
+  - Use search.cpan.org source URL
+  - Fix typo in %%description
+  - Make %%files list more explicit
+  - Don't use macros for commands
+  - Use tabs
+
 * Fri Jan 13 2012 Fedora Release Engineering <rel-eng@lists.fedoraproject.org> - 0.14-10
 - Rebuilt for https://fedoraproject.org/wiki/Fedora_17_Mass_Rebuild
 
@@ -63,13 +70,13 @@ rm -rf %{buildroot}
 - Rebuilt for https://fedoraproject.org/wiki/Fedora_15_Mass_Rebuild
 
 * Tue Dec 21 2010 Marcela Maslanova <mmaslano@redhat.com> - 0.14-7
-- 661697 rebuild for fixing problems with vendorach/lib
+- Rebuild to fix problems with vendorarch/lib (#661697)
 
 * Tue May 04 2010 Marcela Maslanova <mmaslano@redhat.com> - 0.14-6
 - Mass rebuild with perl-5.12.0
 
 * Mon Dec  7 2009 Stepan Kasal <skasal@redhat.com> - 0.14-5
-- rebuild against perl 5.10.1
+- Rebuild against perl 5.10.1
 
 * Sun Jul 26 2009 Fedora Release Engineering <rel-eng@lists.fedoraproject.org> - 0.14-4
 - Rebuilt for https://fedoraproject.org/wiki/Fedora_12_Mass_Rebuild
@@ -77,14 +84,14 @@ rm -rf %{buildroot}
 * Thu Feb 26 2009 Fedora Release Engineering <rel-eng@lists.fedoraproject.org> - 0.14-3
 - Rebuilt for https://fedoraproject.org/wiki/Fedora_11_Mass_Rebuild
 
-* Tue Mar  4 2008 Tom "spot" Callaway <tcallawa@redhat.com> 0.14-2
+* Tue Mar  4 2008 Tom "spot" Callaway <tcallawa@redhat.com> - 0.14-2
-- rebuild for new perl
+- Rebuild for new perl
 
-* Sun Oct 15 2006 Chris Weyl <cweyl@alumni.drew.edu> 0.14-1
+* Sun Oct 15 2006 Chris Weyl <cweyl@alumni.drew.edu> - 0.14-1
-- update to 0.14
+- Update to 0.14
 
-* Thu Sep 07 2006 Chris Weyl <cweyl@alumni.drew.edu> 0.13-2
+* Thu Sep 07 2006 Chris Weyl <cweyl@alumni.drew.edu> - 0.13-2
-- add additional verbosity to %%description 
+- Add additional verbosity to %%description 
 
-* Tue Sep 05 2006 Chris Weyl <cweyl@alumni.drew.edu> 0.13-1
+* Tue Sep 05 2006 Chris Weyl <cweyl@alumni.drew.edu> - 0.13-1
-- Specfile autogenerated by cpanspec 1.69.1.
+- Specfile autogenerated by cpanspec 1.69.1