Modernize spec file

perl-Module-Manifest.spec

@@ -1,60 +1,62 @@
 Name:           perl-Module-Manifest
 Version:        1.08
-Release:        7%{?dist}
+Release:        8%{?dist}
 Summary:        Parse and examine a Perl distribution MANIFEST file
 License:        GPL+ or Artistic
 Group:          Development/Libraries
 URL:            http://search.cpan.org/dist/Module-Manifest/
 Source0:        http://www.cpan.org/authors/id/A/AD/ADAMK/Module-Manifest-%{version}.tar.gz
-BuildRoot:      %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
 BuildArch:      noarch
-BuildRequires:  perl >= 0:5.005
+BuildRequires:  perl(Cwd)
 BuildRequires:  perl(ExtUtils::MakeMaker)
+# Run-time:
+BuildRequires:  perl(Carp)
+BuildRequires:  perl(File::Spec) >= 0.80
+BuildRequires:  perl(File::Spec::Unix)
 BuildRequires:  perl(Params::Util) >= 0.10
+# Tests:
+BuildRequires:  perl(File::Spec::Functions)
 BuildRequires:  perl(Test::Exception) >= 0.27
 BuildRequires:  perl(Test::More) >= 0.42
 BuildRequires:  perl(Test::Warn) >= 0.11
+Requires:       perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version))
 Requires:       perl(File::Spec) >= 0.80
 Requires:       perl(Params::Util) >= 0.10
-Requires:       perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version))
+
+# Do not export under-specified dependencies
+%global __requires_exclude %{?__requires_exclude:%__requires_exclude|}^perl\\((File::Spec|Params::Util)\\)
 
 %description
-Module::Manifest is a simple utility module created originally for use in
+Module::Manifest can load a MANIFEST file that comes in a Perl distribution
-Module::Inspector.
+tarball, examine the contents, and perform some simple tasks. It can also load
+the MANIFEST.SKIP file and check that.
 
 %prep
 %setup -q -n Module-Manifest-%{version}
+chmod -x examples/*
 
 %build
 %{__perl} Makefile.PL INSTALLDIRS=vendor
 make %{?_smp_mflags}
 
 %install
-rm -rf $RPM_BUILD_ROOT
-
 make pure_install PERL_INSTALL_ROOT=$RPM_BUILD_ROOT
-
 find $RPM_BUILD_ROOT -type f -name .packlist -exec rm -f {} \;
-find $RPM_BUILD_ROOT -depth -type d -exec rmdir {} 2>/dev/null \;
-
 %{_fixperms} $RPM_BUILD_ROOT/*
-# Remove executable bit from %%doc files
-%{__chmod} 0644 examples/*
-
 
 %check
 make test
 
-%clean
-rm -rf $RPM_BUILD_ROOT
-
 %files
-%defattr(-,root,root,-)
 %doc Changes LICENSE README examples
 %{perl_vendorlib}/*
 %{_mandir}/man3/*
 
 %changelog
+* Thu Aug 09 2012 Petr Pisar <ppisar@redhat.com> - 1.08-8
+- Modernize spec file
+- Specify all dependencies
+
 * Fri Jul 20 2012 Fedora Release Engineering <rel-eng@lists.fedoraproject.org> - 1.08-7
 - Rebuilt for https://fedoraproject.org/wiki/Fedora_18_Mass_Rebuild