Spec clean-up

- Spec clean-up:
  - Make %files list more explicit
  - Categorize build requirements for build/module/test
  - Don't use macros for commands
  - Use tabs
  - Fix typo in %description

perl-Algorithm-C3.spec

@@ -1,47 +1,42 @@
-Name:           perl-Algorithm-C3
+Name:		perl-Algorithm-C3
-Version:        0.08
+Version:	0.08
-Release:        8%{?dist}
+Release:	9%{?dist}
-Summary:        Module for merging hierarchies using the C3 algorithm
+Summary:	Module for merging hierarchies using the C3 algorithm
-License:        GPL+ or Artistic
+License:	GPL+ or Artistic
-Group:          Development/Libraries
+Group:		Development/Libraries
-URL:            http://search.cpan.org/dist/Algorithm-C3/
+URL:		http://search.cpan.org/dist/Algorithm-C3/
-Source0:        http://search.cpan.org/CPAN/authors/id/F/FL/FLORA/Algorithm-C3-%{version}.tar.gz
+Source0:	http://search.cpan.org/CPAN/authors/id/F/FL/FLORA/Algorithm-C3-%{version}.tar.gz
-BuildRoot:      %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
+BuildRoot:	%{_tmppath}/%{name}-%{version}-%{release}-root-%(id -nu)
-BuildArch:      noarch
+BuildArch:	noarch
-Requires:       perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version))
+# Build
-
+BuildRequires:	perl(Module::Build)
-# core
+# Module
-BuildRequires:  perl(Test::More) >= 0.47
+BuildRequires:	perl(Carp) >= 0.01
-# cpan
+# Test
-BuildRequires:  perl(Module::Build)
+BuildRequires:	perl(Test::More) >= 0.47
-# for testing....
+BuildRequires:	perl(Test::Pod)
-BuildRequires:  perl(Test::Pod)
+BuildRequires:	perl(Test::Pod::Coverage)
-BuildRequires:  perl(Test::Pod::Coverage)
+# Runtime
-
+Requires:	perl(:MODULE_COMPAT_%(eval "`perl -V:version`"; echo $version))
-
-### auto-added brs!
-BuildRequires:  perl(Carp) >= 0.01
 
 %description
 This module implements the C3 algorithm.  Most of the uses I have for C3
-revolve around class building and metamodels, but it could also be used for
+revolve around class building and metamodels but it could also be used for
 things like dependency resolution as well since it tends to do such a nice
-job of preserving local precendence orderings.
+job of preserving local precedence orderings.
 
 %prep
 %setup -q -n Algorithm-C3-%{version}
 
 %build
-%{__perl} Build.PL installdirs=vendor
+perl Build.PL installdirs=vendor
 ./Build
 
 %install
 rm -rf %{buildroot}
-
 ./Build install destdir=%{buildroot} create_packlist=0
-find %{buildroot} -depth -type d -exec rmdir {} 2>/dev/null \;
+find %{buildroot} -depth -type d -exec rmdir {} \; 2>/dev/null
-
+%{_fixperms} %{buildroot}
-%{_fixperms} %{buildroot}/*
 
 %check
 ./Build test
@@ -52,10 +47,18 @@ rm -rf %{buildroot}
 %files
 %defattr(-,root,root,-)
 %doc Changes README t/
-%{perl_vendorlib}/*
+%{perl_vendorlib}/Algorithm/
-%{_mandir}/man3/*
+%{_mandir}/man3/Algorithm::C3.3pm*
 
 %changelog
+* Mon Jan 16 2012 Paul Howarth <paul@city-fan.org> - 0.08-9
+- Spec clean-up:
+  - Make %%files list more explicit
+  - Categorize build requirements for build/module/test
+  - Don't use macros for commands
+  - Use tabs
+  - Fix typo in %%description
+
 * Fri Jan 13 2012 Fedora Release Engineering <rel-eng@lists.fedoraproject.org> - 0.08-8
 - Rebuilt for https://fedoraproject.org/wiki/Fedora_17_Mass_Rebuild
 
@@ -66,38 +69,38 @@ rm -rf %{buildroot}
 - Rebuilt for https://fedoraproject.org/wiki/Fedora_15_Mass_Rebuild
 
 * Tue Dec 14 2010 Marcela Maslanova <mmaslano@redhat.com> - 0.08-5
-- 661697 rebuild for fixing problems with vendorach/lib
+- Rebuild to fixproblems with vendorarch/lib (#661697)
 
 * Thu Apr 29 2010 Marcela Maslanova <mmaslano@redhat.com> - 0.08-4
 - Mass rebuild with perl-5.12.0
 
 * Mon Dec  7 2009 Stepan Kasal <skasal@redhat.com> - 0.08-3
-- rebuild against perl 5.10.1
+- Rebuild against perl 5.10.1
 
 * Sat Jul 25 2009 Fedora Release Engineering <rel-eng@lists.fedoraproject.org> - 0.08-2
 - Rebuilt for https://fedoraproject.org/wiki/Fedora_12_Mass_Rebuild
 
-* Sun Jun 07 2009 Chris Weyl <cweyl@alumni.drew.edu> 0.08-1
+* Sun Jun 07 2009 Chris Weyl <cweyl@alumni.drew.edu> - 0.08-1
-- auto-update to 0.08 (by cpan-spec-update 0.01)
+- Auto-update to 0.08 (by cpan-spec-update 0.01)
-- altered br on perl(Test::More) (0 => 0.47)
+- Altered br on perl(Test::More) (0 => 0.47)
-- added a new br on perl(Carp) (version 0.01)
+- Added a new br on perl(Carp) (version 0.01)
 
 * Thu Feb 26 2009 Fedora Release Engineering <rel-eng@lists.fedoraproject.org> - 0.07-3
 - Rebuilt for https://fedoraproject.org/wiki/Fedora_11_Mass_Rebuild
 
-* Tue Mar 04 2008 Tom "spot" Callaway <tcallawa@redhat.com> 0.07-2
+* Tue Mar 04 2008 Tom "spot" Callaway <tcallawa@redhat.com> - 0.07-2
-- rebuild for new perl
+- Rebuild for new perl
 
-* Thu May 31 2007 Chris Weyl <cweyl@alumni.drew.edu> 0.07-1
+* Thu May 31 2007 Chris Weyl <cweyl@alumni.drew.edu> - 0.07-1
-- update to 0.07
+- Update to 0.07
-- include t/ in doc
+- Include t/ in doc
-- minor spec reworkage to deal with the once and future perl split
+- Minor spec reworkage to deal with the once and future perl split
 
-* Tue Nov 21 2006 Chris Weyl <cweyl@alumni.drew.edu> 0.06-1
+* Tue Nov 21 2006 Chris Weyl <cweyl@alumni.drew.edu> - 0.06-1
-- update to 0.06
+- Update to 0.06
 
-* Wed Sep 06 2006 Chris Weyl <cweyl@alumni.drew.edu> 0.05-2
+* Wed Sep 06 2006 Chris Weyl <cweyl@alumni.drew.edu> - 0.05-2
-- bump
+- Bump
 
-* Tue Sep 05 2006 Chris Weyl <cweyl@alumni.drew.edu> 0.05-1
+* Tue Sep 05 2006 Chris Weyl <cweyl@alumni.drew.edu> - 0.05-1
-- Specfile autogenerated by cpanspec 1.69.1.
+- Specfile autogenerated by cpanspec 1.69.1