parent
8470e705a1
commit
585061350c
@ -0,0 +1,32 @@
|
||||
commit 1d2e10afb2ffc35cb3623f57a15f712359f18e75
|
||||
Author: Herb Wartens <wartens2@llnl.gov>
|
||||
Date: Tue Aug 1 10:36:16 2023 -0400
|
||||
|
||||
rpcb_clnt.c: Eliminate double frees in delete_cache()
|
||||
|
||||
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2224666
|
||||
Signed-off-by: Steve Dickson <steved@redhat.com>
|
||||
|
||||
diff --git a/src/rpcb_clnt.c b/src/rpcb_clnt.c
|
||||
index c0a9e12..68fe69a 100644
|
||||
--- a/src/rpcb_clnt.c
|
||||
+++ b/src/rpcb_clnt.c
|
||||
@@ -262,12 +262,15 @@ delete_cache(addr)
|
||||
for (cptr = front; cptr != NULL; cptr = cptr->ac_next) {
|
||||
if (!memcmp(cptr->ac_taddr->buf, addr->buf, addr->len)) {
|
||||
/* Unlink from cache. We'll destroy it after releasing the mutex. */
|
||||
- if (cptr->ac_uaddr)
|
||||
+ if (cptr->ac_uaddr) {
|
||||
free(cptr->ac_uaddr);
|
||||
- if (prevptr)
|
||||
+ cptr->ac_uaddr = NULL;
|
||||
+ }
|
||||
+ if (prevptr) {
|
||||
prevptr->ac_next = cptr->ac_next;
|
||||
- else
|
||||
+ } else {
|
||||
front = cptr->ac_next;
|
||||
+ }
|
||||
cachesize--;
|
||||
break;
|
||||
}
|
@ -0,0 +1,48 @@
|
||||
commit 89c63bdfd79b1c94384daaaa03a9e3582540f843
|
||||
Author: Herb Wartens <wartens2@llnl.gov>
|
||||
Date: Tue Aug 1 10:21:42 2023 -0400
|
||||
|
||||
rpcb_clnt.c: memory leak in destroy_addr
|
||||
|
||||
Null pointers so they are not used again
|
||||
|
||||
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2225226
|
||||
Signed-off-by: Steve Dickson <steved@redhat.com>
|
||||
|
||||
diff --git a/src/rpcb_clnt.c b/src/rpcb_clnt.c
|
||||
index d178d86..c0a9e12 100644
|
||||
--- a/src/rpcb_clnt.c
|
||||
+++ b/src/rpcb_clnt.c
|
||||
@@ -104,17 +104,27 @@ destroy_addr(addr)
|
||||
{
|
||||
if (addr == NULL)
|
||||
return;
|
||||
- if(addr->ac_host != NULL)
|
||||
+ if (addr->ac_host != NULL) {
|
||||
free(addr->ac_host);
|
||||
- if(addr->ac_netid != NULL)
|
||||
+ addr->ac_host = NULL;
|
||||
+ }
|
||||
+ if (addr->ac_netid != NULL) {
|
||||
free(addr->ac_netid);
|
||||
- if(addr->ac_uaddr != NULL)
|
||||
+ addr->ac_netid = NULL;
|
||||
+ }
|
||||
+ if (addr->ac_uaddr != NULL) {
|
||||
free(addr->ac_uaddr);
|
||||
- if(addr->ac_taddr != NULL) {
|
||||
- if(addr->ac_taddr->buf != NULL)
|
||||
+ addr->ac_uaddr = NULL;
|
||||
+ }
|
||||
+ if (addr->ac_taddr != NULL) {
|
||||
+ if(addr->ac_taddr->buf != NULL) {
|
||||
free(addr->ac_taddr->buf);
|
||||
+ addr->ac_taddr->buf = NULL;
|
||||
+ }
|
||||
+ addr->ac_taddr = NULL;
|
||||
}
|
||||
free(addr);
|
||||
+ addr = NULL;
|
||||
}
|
||||
|
||||
/*
|
Loading…
Reference in new issue