parent
84a464daf8
commit
1660564df6
@ -1,38 +0,0 @@
|
|||||||
From 9d4e460b298a39ee2be2443af97413e7063fa8d2 Mon Sep 17 00:00:00 2001
|
|
||||||
From: Fabian Homborg <FHomborg@gmail.com>
|
|
||||||
Date: Fri, 4 Jan 2019 08:45:53 +0100
|
|
||||||
Subject: [PATCH] string: Fix crash with _GLIBCXX_ASSERTIONS
|
|
||||||
|
|
||||||
This asserted because we accessed wcstring::front() when it was empty.
|
|
||||||
|
|
||||||
Instead, check explicitly for it being empty before.
|
|
||||||
|
|
||||||
Fixes #5479
|
|
||||||
---
|
|
||||||
src/builtin_string.cpp | 10 +++++++---
|
|
||||||
1 file changed, 7 insertions(+), 3 deletions(-)
|
|
||||||
|
|
||||||
diff --git a/src/builtin_string.cpp b/src/builtin_string.cpp
|
|
||||||
index 6e810a32..bbc7e40c 100644
|
|
||||||
--- a/src/builtin_string.cpp
|
|
||||||
+++ b/src/builtin_string.cpp
|
|
||||||
@@ -622,9 +622,13 @@ class wildcard_matcher_t : public string_matcher_t {
|
|
||||||
}
|
|
||||||
}
|
|
||||||
if (opts.entire) {
|
|
||||||
- // If the pattern is empty, this becomes one ANY_STRING that matches everything.
|
|
||||||
- if (wcpattern.front() != ANY_STRING) wcpattern.insert(0, 1, ANY_STRING);
|
|
||||||
- if (wcpattern.back() != ANY_STRING) wcpattern.push_back(ANY_STRING);
|
|
||||||
+ if (!wcpattern.empty()) {
|
|
||||||
+ if (wcpattern.front() != ANY_STRING) wcpattern.insert(0, 1, ANY_STRING);
|
|
||||||
+ if (wcpattern.back() != ANY_STRING) wcpattern.push_back(ANY_STRING);
|
|
||||||
+ } else {
|
|
||||||
+ // If the pattern is empty, this becomes one ANY_STRING that matches everything.
|
|
||||||
+ wcpattern.push_back(ANY_STRING);
|
|
||||||
+ }
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
--
|
|
||||||
2.20.1
|
|
||||||
|
|
@ -1 +1 @@
|
|||||||
SHA512 (fish-3.0.0.tar.gz) = e4159821d4263e5afb67adee82e30cfed0ad30f3772dd95beb0df71423ff52c21354970f64967f2de9fd1d31caa702208cfd9f2ce281bbf33114f3aa7cd539a2
|
SHA512 (fish-3.0.2.tar.gz) = cd4a8e6a0d7770ef17e92d3d20ea23e754b9fa53e5ee5459ab5838fcbbcac69544ca2f83551e93a004b140cc14ec556860a711ce216197753c1704901518c9c3
|
||||||
|
Loading…
Reference in new issue