parent
bdbe815cf7
commit
7f8ab51a59
@ -1,57 +0,0 @@
|
|||||||
From b842c77bf6957c318d1a74c70f584f56751ff43c Mon Sep 17 00:00:00 2001
|
|
||||||
From: Jeremy Katz <katzj@hubspot.com>
|
|
||||||
Date: Wed, 15 Feb 2012 09:22:49 -0500
|
|
||||||
Subject: [PATCH/facter] Make ec2 facts work on CentOS again
|
|
||||||
|
|
||||||
Refactoring the ec2 facts lost the support for CentOS where the
|
|
||||||
hardware address in arp -an is uppercased. Fix and add a unit
|
|
||||||
test now that there are those
|
|
||||||
---
|
|
||||||
lib/facter/util/ec2.rb | 2 +-
|
|
||||||
spec/fixtures/unit/util/ec2/centos-arp-ec2.out | 1 +
|
|
||||||
spec/unit/util/ec2_spec.rb | 7 +++++++
|
|
||||||
3 files changed, 9 insertions(+), 1 deletions(-)
|
|
||||||
create mode 100644 spec/fixtures/unit/util/ec2/centos-arp-ec2.out
|
|
||||||
|
|
||||||
diff --git a/lib/facter/util/ec2.rb b/lib/facter/util/ec2.rb
|
|
||||||
index bcfda60..d42254a 100644
|
|
||||||
--- a/lib/facter/util/ec2.rb
|
|
||||||
+++ b/lib/facter/util/ec2.rb
|
|
||||||
@@ -46,7 +46,7 @@ module Facter::Util::EC2
|
|
||||||
arp_table = Facter::Util::Resolution.exec(arp_command)
|
|
||||||
if not arp_table.nil?
|
|
||||||
arp_table.each_line do |line|
|
|
||||||
- return true if line.include?(mac_address)
|
|
||||||
+ return true if line.downcase.include?(mac_address)
|
|
||||||
end
|
|
||||||
end
|
|
||||||
return false
|
|
||||||
diff --git a/spec/fixtures/unit/util/ec2/centos-arp-ec2.out b/spec/fixtures/unit/util/ec2/centos-arp-ec2.out
|
|
||||||
new file mode 100644
|
|
||||||
index 0000000..24d2ec0
|
|
||||||
--- /dev/null
|
|
||||||
+++ b/spec/fixtures/unit/util/ec2/centos-arp-ec2.out
|
|
||||||
@@ -0,0 +1 @@
|
|
||||||
+? (10.240.93.1) at FE:FF:FF:FF:FF:FF [ether] on eth0
|
|
||||||
\ No newline at end of file
|
|
||||||
diff --git a/spec/unit/util/ec2_spec.rb b/spec/unit/util/ec2_spec.rb
|
|
||||||
index 62fdcb7..f1fbe3c 100755
|
|
||||||
--- a/spec/unit/util/ec2_spec.rb
|
|
||||||
+++ b/spec/unit/util/ec2_spec.rb
|
|
||||||
@@ -22,6 +22,13 @@ describe Facter::Util::EC2 do
|
|
||||||
Facter::Util::EC2.has_ec2_arp?.should == true
|
|
||||||
end
|
|
||||||
|
|
||||||
+ it "should succeed if arp table contains FE:FF:FF:FF:FF:FF" do
|
|
||||||
+ ec2arp = my_fixture_read("centos-arp-ec2.out")
|
|
||||||
+ Facter::Util::Resolution.expects(:exec).with("arp -an").\
|
|
||||||
+ at_least_once.returns(ec2arp)
|
|
||||||
+ Facter::Util::EC2.has_ec2_arp?.should == true
|
|
||||||
+ end
|
|
||||||
+
|
|
||||||
it "should fail if arp table does not contain fe:ff:ff:ff:ff:ff" do
|
|
||||||
ec2arp = my_fixture_read("linux-arp-not-ec2.out")
|
|
||||||
Facter::Util::Resolution.expects(:exec).with("arp -an").
|
|
||||||
--
|
|
||||||
1.7.6
|
|
||||||
|
|
@ -1,18 +0,0 @@
|
|||||||
-----BEGIN PGP SIGNATURE-----
|
|
||||||
Version: GnuPG/MacGPG2 v2.0.17 (Darwin)
|
|
||||||
Comment: GPGTools - http://gpgtools.org
|
|
||||||
|
|
||||||
iQIcBAABAgAGBQJPIFqMAAoJEBBUt6JL1uwwT5cP/jEqju21TRu75ols8i1TcRxB
|
|
||||||
nErei95jzwfQf3NIY8e+8zC3SQY5bYCH+QCXVoEcVZPefRGVAhOIIM/Eh/Sx+zVt
|
|
||||||
okRpvql/cYbq7wVyzfSctNWAvsK5p41BvKSRapxRHhlfMMdxYLV8v/yfTwUQnhIu
|
|
||||||
5UK04N+3QsnQ2B27gqEbkRMwaUiCVm7YPJ7Jc2lnqmCHHyqPC6dyHNyLaaPWkeDO
|
|
||||||
iEZsaoYac+DOdfaKQT1pG7ucwqYRdQYyzhlUJmTtiY93oQpgfr//YrdA8Edvp/E6
|
|
||||||
0VvVntuRY2TIeYVBHf960lnzeu0cYzYMxTh9IcFKxnemf0q0GV9PuUHw1KJMQ1Ot
|
|
||||||
h2bTZneUg4qMUCW3neiqfHakTpOJODsILmC6l0xzNIDZlQGeYpUDBwotmXVD7ks4
|
|
||||||
YFAtLIygIAVElG3JupQyL3iTwWD+7tVO3U/dtXf9XUFO4DP8QlifgMffqhB0oPhw
|
|
||||||
C/k4AftCmWqxYKHFM5hledBsWR6K/iOEHahyG/J5VOyrNluNBNaBTvILNWCKld9S
|
|
||||||
QeKyD8RlGVr8d6rIHFd1uGTm0oNWUoLht4ZvfE5I3Z/0MDd8B3i+/Wvyem/uE7/y
|
|
||||||
eRAG+O+pBCNXYX1hHLB2rHAglXuR82V27botCj4AJZGpmjBScSMisPwAF6eBvyuj
|
|
||||||
vg7pGbWelsVTTq3Tk7fK
|
|
||||||
=KHea
|
|
||||||
-----END PGP SIGNATURE-----
|
|
@ -0,0 +1,17 @@
|
|||||||
|
-----BEGIN PGP SIGNATURE-----
|
||||||
|
Version: GnuPG v1.4.11 (Darwin)
|
||||||
|
|
||||||
|
iQIcBAABAgAGBQJPRrX/AAoJEBBUt6JL1uww5jMP/1EdteiAyZDJfKaJ5sguDpt8
|
||||||
|
OEfxjBRDZblCFwOUIpt62enP3nwdepaToWAJF2ehL74K5jKMuDhlJAxN0WLq+m8q
|
||||||
|
qm3hHWIKBac6CgeBFUX81DlLog+p9EU2HCBhzajBohfwCXjn74kczwskIhR9vrcx
|
||||||
|
wH3/oG3BKKO51Gi/k6uXHkKJvIPpomAqGxvm5VpjE9e3vUkQMlxWL4jCeDIexByL
|
||||||
|
ykviFtsdgzQRBOTSQRtz2okDJxZVVRux+Y4qQnsQe8C2YrDoXK8lzwhHjNVq1fr/
|
||||||
|
XFM/4OXQawPmE7Jw+5DoAtJR4Ur3tRqHfkCK7dITv4tK4WuSCrrZa6r1bGWMhnwD
|
||||||
|
WFPF5+aXIoX3IMtG0YFcarOPNj+X9Z+cs1oUBC2/eZQwStp9zRoLUSMV5w59Shgi
|
||||||
|
6LnV7Rfk50C9QZhK8o/FxsRQthLLyMhYf9SPPJTBw2oCqTDgDLLcgnEYLUHYCDr+
|
||||||
|
xscTEGa9p1maWfy2T2BnLEZOjDe8od3dXFH+7f7YjAMCXxbWM4PWb9EPQeCyXPX3
|
||||||
|
9I620FNeiIFOLw3SLV77clgFufPHTYisyyp3/4ch83wzQRJMMdGSnX8BzBY57N/d
|
||||||
|
PJblmp+hBOXXYBqJq4QPOzMVrf2dsMXfwRJf9S/XVcjx9ryVrC0eEUZJZRdMZl/6
|
||||||
|
JFLvLFKS/8y++eI5Gem4
|
||||||
|
=ztk/
|
||||||
|
-----END PGP SIGNATURE-----
|
Loading…
Reference in new issue