MSVSphere Packaging Team
5 months ago
parent
9da42e50b8
commit
045899fa67
@ -0,0 +1,86 @@
|
|||||||
|
diff --git a/cups/http-addr.c b/cups/http-addr.c
|
||||||
|
index 86749c848..5b035e02b 100644
|
||||||
|
--- a/cups/http-addr.c
|
||||||
|
+++ b/cups/http-addr.c
|
||||||
|
@@ -196,31 +196,29 @@ httpAddrListen(http_addr_t *addr, /* I - Address to bind to */
|
||||||
|
{
|
||||||
|
mode_t mask; /* Umask setting */
|
||||||
|
|
||||||
|
- /*
|
||||||
|
- * Remove any existing domain socket file...
|
||||||
|
- */
|
||||||
|
-
|
||||||
|
- unlink(addr->un.sun_path);
|
||||||
|
-
|
||||||
|
- /*
|
||||||
|
- * Save the current umask and set it to 0 so that all users can access
|
||||||
|
- * the domain socket...
|
||||||
|
- */
|
||||||
|
-
|
||||||
|
- mask = umask(0);
|
||||||
|
-
|
||||||
|
- /*
|
||||||
|
- * Bind the domain socket...
|
||||||
|
- */
|
||||||
|
+ // Remove any existing domain socket file...
|
||||||
|
+ if ((status = unlink(addr->un.sun_path)) < 0)
|
||||||
|
+ {
|
||||||
|
+ DEBUG_printf(("1httpAddrListen: Unable to unlink \"%s\": %s", addr->un.sun_path, strerror(errno)));
|
||||||
|
+ if (errno == ENOENT)
|
||||||
|
+ status = 0;
|
||||||
|
+ }
|
||||||
|
|
||||||
|
- status = bind(fd, (struct sockaddr *)addr, (socklen_t)httpAddrLength(addr));
|
||||||
|
+ if (!status)
|
||||||
|
+ {
|
||||||
|
+ // Save the current umask and set it to 0 so that all users can access
|
||||||
|
+ // the domain socket...
|
||||||
|
+ mask = umask(0);
|
||||||
|
|
||||||
|
- /*
|
||||||
|
- * Restore the umask and fix permissions...
|
||||||
|
- */
|
||||||
|
+ // Bind the domain socket...
|
||||||
|
+ if ((status = bind(fd, (struct sockaddr *)addr, (socklen_t)httpAddrLength(addr))) < 0)
|
||||||
|
+ {
|
||||||
|
+ DEBUG_printf(("1httpAddrListen: Unable to bind domain socket \"%s\": %s", addr->un.sun_path, strerror(errno)));
|
||||||
|
+ }
|
||||||
|
|
||||||
|
- umask(mask);
|
||||||
|
- chmod(addr->un.sun_path, 0140777);
|
||||||
|
+ // Restore the umask...
|
||||||
|
+ umask(mask);
|
||||||
|
+ }
|
||||||
|
}
|
||||||
|
else
|
||||||
|
#endif /* AF_LOCAL */
|
||||||
|
diff --git a/scheduler/conf.c b/scheduler/conf.c
|
||||||
|
index bb6049b2c..4c703c9b9 100644
|
||||||
|
--- a/scheduler/conf.c
|
||||||
|
+++ b/scheduler/conf.c
|
||||||
|
@@ -3062,6 +3062,25 @@ read_cupsd_conf(cups_file_t *fp) /* I - File to read from */
|
||||||
|
|
||||||
|
cupsd_listener_t *lis; /* New listeners array */
|
||||||
|
|
||||||
|
+ /*
|
||||||
|
+ * If we are launched on-demand, do not use domain sockets from the config
|
||||||
|
+ * file. Also check that the domain socket path is not too long...
|
||||||
|
+ */
|
||||||
|
+
|
||||||
|
+#ifdef HAVE_ONDEMAND
|
||||||
|
+ if (*value == '/' && OnDemand)
|
||||||
|
+ {
|
||||||
|
+ if (strcmp(value, CUPS_DEFAULT_DOMAINSOCKET))
|
||||||
|
+ cupsdLogMessage(CUPSD_LOG_INFO, "Ignoring %s address %s at line %d - only using domain socket from launchd/systemd.", line, value, linenum);
|
||||||
|
+ continue;
|
||||||
|
+ }
|
||||||
|
+#endif // HAVE_ONDEMAND
|
||||||
|
+
|
||||||
|
+ if (*value == '/' && strlen(value) > (sizeof(addr->addr.un.sun_path) - 1))
|
||||||
|
+ {
|
||||||
|
+ cupsdLogMessage(CUPSD_LOG_INFO, "Ignoring %s address %s at line %d - too long.", line, value, linenum);
|
||||||
|
+ continue;
|
||||||
|
+ }
|
||||||
|
|
||||||
|
/*
|
||||||
|
* Get the address list...
|
||||||
@ -0,0 +1,43 @@
|
|||||||
|
diff -up cups-2.2.6/cups/http-addrlist.c.cupsgetjobs-pollhup cups-2.2.6/cups/http-addrlist.c
|
||||||
|
--- cups-2.2.6/cups/http-addrlist.c.cupsgetjobs-pollhup 2023-12-19 18:25:15.484637450 +0100
|
||||||
|
+++ cups-2.2.6/cups/http-addrlist.c 2023-12-19 18:28:57.129163387 +0100
|
||||||
|
@@ -313,6 +313,39 @@ httpAddrConnect2(
|
||||||
|
{
|
||||||
|
# ifdef HAVE_POLL
|
||||||
|
DEBUG_printf(("pfds[%d].revents=%x\n", i, pfds[i].revents));
|
||||||
|
+
|
||||||
|
+# ifdef _WIN32
|
||||||
|
+ if (((WSAGetLastError() == WSAEINPROGRESS) && (pfds[i].revents & POLLIN) && (pfds[i].revents & POLLOUT)) ||
|
||||||
|
+ ((pfds[i].revents & POLLHUP) && (pfds[i].revents & (POLLIN|POLLOUT))))
|
||||||
|
+# else
|
||||||
|
+ if (((errno == EINPROGRESS) && (pfds[i].revents & POLLIN) && (pfds[i].revents & POLLOUT)) ||
|
||||||
|
+ ((pfds[i].revents & POLLHUP) && (pfds[i].revents & (POLLIN|POLLOUT))))
|
||||||
|
+# endif /* _WIN32 */
|
||||||
|
+ {
|
||||||
|
+ // Some systems generate POLLIN or POLLOUT together with POLLHUP when doing
|
||||||
|
+ // asynchronous connections. The solution seems to be to use getsockopt to
|
||||||
|
+ // check the SO_ERROR value and ignore the POLLHUP if there is no error or
|
||||||
|
+ // the error is EINPROGRESS.
|
||||||
|
+
|
||||||
|
+ int sres, /* Return value from getsockopt() - 0, or -1 if error */
|
||||||
|
+ serr; /* Option SO_ERROR value */
|
||||||
|
+ socklen_t slen = sizeof(serr); /* Option value size */
|
||||||
|
+
|
||||||
|
+ sres = getsockopt(fds[i], SOL_SOCKET, SO_ERROR, &serr, &slen);
|
||||||
|
+
|
||||||
|
+ if (sres || serr)
|
||||||
|
+ {
|
||||||
|
+ pfds[i].revents |= POLLERR;
|
||||||
|
+# ifdef DEBUG
|
||||||
|
+ DEBUG_printf(("1httpAddrConnect2: getsockopt returned: %d with error: %s", sres, strerror(serr)));
|
||||||
|
+# endif
|
||||||
|
+ }
|
||||||
|
+ else if (pfds[i].revents && (pfds[i].revents & POLLHUP) && (pfds[i].revents & (POLLIN | POLLOUT)))
|
||||||
|
+ {
|
||||||
|
+ pfds[i].revents &= ~POLLHUP;
|
||||||
|
+ }
|
||||||
|
+ }
|
||||||
|
+
|
||||||
|
if (pfds[i].revents && !(pfds[i].revents & (POLLERR | POLLHUP)))
|
||||||
|
# else
|
||||||
|
if (FD_ISSET(fds[i], &input_set) && !FD_ISSET(fds[i], &error_set))
|
||||||
@ -0,0 +1,36 @@
|
|||||||
|
From db9cecdd932e58c51d2d659f63415ad47d151717 Mon Sep 17 00:00:00 2001
|
||||||
|
From: Zdenek Dohnal <zdohnal@redhat.com>
|
||||||
|
Date: Fri, 1 Sep 2023 17:11:54 +0200
|
||||||
|
Subject: [PATCH] scheduler/conf.c: Print to stderr if we don't open
|
||||||
|
cups-files.conf
|
||||||
|
|
||||||
|
In case cupsd can't open the cups-files.conf, the error message is lost
|
||||||
|
if journal and syslog don't exist or work on system (usually in
|
||||||
|
containers).
|
||||||
|
|
||||||
|
Log the error into stderr at this place to get the error message if
|
||||||
|
needed.
|
||||||
|
---
|
||||||
|
scheduler/conf.c | 6 +-----
|
||||||
|
1 file changed, 1 insertion(+), 5 deletions(-)
|
||||||
|
|
||||||
|
diff --git a/scheduler/conf.c b/scheduler/conf.c
|
||||||
|
index b18535162..4fa7eb1df 100644
|
||||||
|
--- a/scheduler/conf.c
|
||||||
|
+++ b/scheduler/conf.c
|
||||||
|
@@ -811,11 +811,7 @@ cupsdReadConfiguration(void)
|
||||||
|
cupsdLogMessage(CUPSD_LOG_INFO, "No %s, using defaults.", CupsFilesFile);
|
||||||
|
else
|
||||||
|
{
|
||||||
|
-#ifdef HAVE_SYSTEMD_SD_JOURNAL_H
|
||||||
|
- sd_journal_print(LOG_ERR, "Unable to open \"%s\" - %s", CupsFilesFile, strerror(errno));
|
||||||
|
-#else
|
||||||
|
- syslog(LOG_LPR, "Unable to open \"%s\" - %s", CupsFilesFile, strerror(errno));
|
||||||
|
-#endif /* HAVE_SYSTEMD_SD_JOURNAL_H */
|
||||||
|
+ fprintf(stderr, "Unable to read \"%s\" - %s\n", CupsFilesFile, strerror(errno));
|
||||||
|
|
||||||
|
return (0);
|
||||||
|
}
|
||||||
|
--
|
||||||
|
2.41.0
|
||||||
|
|
||||||
@ -0,0 +1,94 @@
|
|||||||
|
diff --git a/scheduler/conf.c b/scheduler/conf.c
|
||||||
|
index c113eb3..77ce179 100644
|
||||||
|
--- a/scheduler/conf.c
|
||||||
|
+++ b/scheduler/conf.c
|
||||||
|
@@ -573,6 +573,18 @@ cupsdReadConfiguration(void)
|
||||||
|
|
||||||
|
cupsdDeleteAllListeners();
|
||||||
|
|
||||||
|
+ /*
|
||||||
|
+ * Allocate Listeners array
|
||||||
|
+ */
|
||||||
|
+
|
||||||
|
+ Listeners = cupsArrayNew(NULL, NULL);
|
||||||
|
+
|
||||||
|
+ if (!Listeners)
|
||||||
|
+ {
|
||||||
|
+ fprintf(stderr, "Unable to allocate memory for array Listeners.\n");
|
||||||
|
+ return (0);
|
||||||
|
+ }
|
||||||
|
+
|
||||||
|
old_remote_port = RemotePort;
|
||||||
|
RemotePort = 0;
|
||||||
|
|
||||||
|
@@ -1080,28 +1092,6 @@ cupsdReadConfiguration(void)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
- /*
|
||||||
|
- * Check that we have at least one listen/port line; if not, report this
|
||||||
|
- * as an error and exit!
|
||||||
|
- */
|
||||||
|
-
|
||||||
|
- if (cupsArrayCount(Listeners) == 0)
|
||||||
|
- {
|
||||||
|
- /*
|
||||||
|
- * No listeners!
|
||||||
|
- */
|
||||||
|
-
|
||||||
|
- cupsdLogMessage(CUPSD_LOG_EMERG,
|
||||||
|
- "No valid Listen or Port lines were found in the "
|
||||||
|
- "configuration file.");
|
||||||
|
-
|
||||||
|
- /*
|
||||||
|
- * Commit suicide...
|
||||||
|
- */
|
||||||
|
-
|
||||||
|
- cupsdEndProcess(getpid(), 0);
|
||||||
|
- }
|
||||||
|
-
|
||||||
|
/*
|
||||||
|
* Set the default locale using the language and charset...
|
||||||
|
*/
|
||||||
|
@@ -3162,17 +3152,6 @@ read_cupsd_conf(cups_file_t *fp) /* I - File to read from */
|
||||||
|
* Allocate another listener...
|
||||||
|
*/
|
||||||
|
|
||||||
|
- if (!Listeners)
|
||||||
|
- Listeners = cupsArrayNew(NULL, NULL);
|
||||||
|
-
|
||||||
|
- if (!Listeners)
|
||||||
|
- {
|
||||||
|
- cupsdLogMessage(CUPSD_LOG_ERROR,
|
||||||
|
- "Unable to allocate %s at line %d - %s.",
|
||||||
|
- line, linenum, strerror(errno));
|
||||||
|
- break;
|
||||||
|
- }
|
||||||
|
-
|
||||||
|
if ((lis = calloc(1, sizeof(cupsd_listener_t))) == NULL)
|
||||||
|
{
|
||||||
|
cupsdLogMessage(CUPSD_LOG_ERROR,
|
||||||
|
diff --git a/scheduler/main.c b/scheduler/main.c
|
||||||
|
index a6e2c3a..b935c52 100644
|
||||||
|
--- a/scheduler/main.c
|
||||||
|
+++ b/scheduler/main.c
|
||||||
|
@@ -2113,6 +2113,21 @@ service_checkin(void)
|
||||||
|
service_add_listener(fd, 0);
|
||||||
|
}
|
||||||
|
#endif /* HAVE_LAUNCHD */
|
||||||
|
+
|
||||||
|
+ if (cupsArrayCount(Listeners) == 0)
|
||||||
|
+ {
|
||||||
|
+ /*
|
||||||
|
+ * No listeners!
|
||||||
|
+ */
|
||||||
|
+
|
||||||
|
+ cupsdLogMessage(CUPSD_LOG_EMERG, "No listener sockets present.");
|
||||||
|
+
|
||||||
|
+ /*
|
||||||
|
+ * Commit suicide...
|
||||||
|
+ */
|
||||||
|
+
|
||||||
|
+ cupsdEndProcess(getpid(), 0);
|
||||||
|
+ }
|
||||||
|
}
|
||||||
@ -0,0 +1,31 @@
|
|||||||
|
diff --git a/scheduler/colorman.c b/scheduler/colorman.c
|
||||||
|
index 8af4e5c..9bfdb0c 100644
|
||||||
|
--- a/scheduler/colorman.c
|
||||||
|
+++ b/scheduler/colorman.c
|
||||||
|
@@ -1083,7 +1083,7 @@ colord_create_profile(
|
||||||
|
|
||||||
|
dbus_message_iter_get_basic(&args, &profile_path);
|
||||||
|
cupsdLogMessage(CUPSD_LOG_DEBUG, "Created profile \"%s\".", profile_path);
|
||||||
|
- cupsArrayAdd(profiles, strdup(profile_path));
|
||||||
|
+ cupsArrayAdd(profiles, profile_path);
|
||||||
|
|
||||||
|
out:
|
||||||
|
|
||||||
|
diff --git a/scheduler/job.c b/scheduler/job.c
|
||||||
|
index 0223bee..47d4c72 100644
|
||||||
|
--- a/scheduler/job.c
|
||||||
|
+++ b/scheduler/job.c
|
||||||
|
@@ -1496,11 +1496,11 @@ cupsdDeleteJob(cupsd_job_t *job, /* I - Job */
|
||||||
|
job->num_files = 0;
|
||||||
|
}
|
||||||
|
|
||||||
|
+ unload_job(job);
|
||||||
|
+
|
||||||
|
if (job->history)
|
||||||
|
free_job_history(job);
|
||||||
|
|
||||||
|
- unload_job(job);
|
||||||
|
-
|
||||||
|
cupsArrayRemove(Jobs, job);
|
||||||
|
cupsArrayRemove(ActiveJobs, job);
|
||||||
|
cupsArrayRemove(PrintingJobs, job);
|
||||||
@ -0,0 +1,12 @@
|
|||||||
|
diff --git a/scheduler/cups.socket.in b/scheduler/cups.socket.in
|
||||||
|
index 613b977a6..1deee826a 100644
|
||||||
|
--- a/scheduler/cups.socket.in
|
||||||
|
+++ b/scheduler/cups.socket.in
|
||||||
|
@@ -4,6 +4,7 @@ PartOf=org.cups.cupsd.service
|
||||||
|
|
||||||
|
[Socket]
|
||||||
|
ListenStream=@CUPS_DEFAULT_DOMAINSOCKET@
|
||||||
|
+RemoveOnStop=on
|
||||||
|
|
||||||
|
[Install]
|
||||||
|
WantedBy=sockets.target
|
||||||
Loading…
Reference in new issue