parent
7f8bf27d61
commit
b258fa8bfe
@ -0,0 +1,43 @@
|
||||
From 799ef819e75bdddbf4e983e6990a6a6a51c61bdb Mon Sep 17 00:00:00 2001
|
||||
From: Emanuele Giuseppe Esposito <eesposit@redhat.com>
|
||||
Date: Wed, 14 Dec 2022 09:21:32 +0100
|
||||
Subject: [PATCH] Ensure network ready before cloud-init service runs on RHEL
|
||||
(#1893)
|
||||
|
||||
RH-Author: Emanuele Giuseppe Esposito <eesposit@redhat.com>
|
||||
RH-MergeRequest: 85: Ensure network ready before cloud-init service runs on RHEL (#1893)
|
||||
RH-Bugzilla: 2153183
|
||||
RH-Acked-by: Mohamed Gamal Morsy <mmorsy@redhat.com>
|
||||
RH-Acked-by: Camilla Conte <cconte@redhat.com>
|
||||
RH-Commit: [1/1] d1abf2692aeddea9eac69f6ff8b173e188c3e013
|
||||
|
||||
Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=2153183
|
||||
|
||||
commit 6e725f36647407d201af0603d7db11fc96a93d4d
|
||||
Author: James Falcon <james.falcon@canonical.com>
|
||||
Date: Tue Dec 13 10:55:23 2022 -0600
|
||||
|
||||
Ensure network ready before cloud-init service runs on RHEL (#1893)
|
||||
|
||||
LP: #1998655
|
||||
|
||||
Signed-off-by: Emanuele Giuseppe Esposito <eesposit@redhat.com>
|
||||
---
|
||||
systemd/cloud-init.service.tmpl | 1 +
|
||||
1 file changed, 1 insertion(+)
|
||||
|
||||
diff --git a/systemd/cloud-init.service.tmpl b/systemd/cloud-init.service.tmpl
|
||||
index c170aef7..fc984d5c 100644
|
||||
--- a/systemd/cloud-init.service.tmpl
|
||||
+++ b/systemd/cloud-init.service.tmpl
|
||||
@@ -16,6 +16,7 @@ After=networking.service
|
||||
"miraclelinux", "openEuler", "rhel", "rocky", "virtuozzo"] %}
|
||||
After=network.service
|
||||
After=NetworkManager.service
|
||||
+After=NetworkManager-wait-online.service
|
||||
{% endif %}
|
||||
{% if variant in ["suse"] %}
|
||||
After=wicked.service
|
||||
--
|
||||
2.38.1
|
||||
|
@ -0,0 +1,84 @@
|
||||
From c7ad2c8d1ddddcb9acaa1ffebb8e3b9752201f91 Mon Sep 17 00:00:00 2001
|
||||
From: Emanuele Giuseppe Esposito <eesposit@redhat.com>
|
||||
Date: Tue, 31 Jan 2023 15:28:33 +0100
|
||||
Subject: [PATCH] cc_set_hostname: ignore /var/lib/cloud/data/set-hostname if
|
||||
it's empty (#1967)
|
||||
|
||||
RH-Author: Emanuele Giuseppe Esposito <eesposit@redhat.com>
|
||||
RH-MergeRequest: 89: cc_set_hostname: ignore /var/lib/cloud/data/set-hostname if it's empty (#1967)
|
||||
RH-Bugzilla: 2165942
|
||||
RH-Acked-by: Mohamed Gamal Morsy <mmorsy@redhat.com>
|
||||
RH-Acked-by: Miroslav Rezanina <mrezanin@redhat.com>
|
||||
RH-Commit: [1/1] 53809c47b4d7f5b30cbeb2903a48f1ee42f68c53
|
||||
|
||||
Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=2165942
|
||||
|
||||
commit 9c7502a801763520639c66125eb373123d1e4f44
|
||||
Author: Emanuele Giuseppe Esposito <eesposit@redhat.com>
|
||||
Date: Wed Jan 18 17:55:16 2023 +0100
|
||||
|
||||
cc_set_hostname: ignore /var/lib/cloud/data/set-hostname if it's empty (#1967)
|
||||
|
||||
If the file exists but is empty, do nothing.
|
||||
Otherwise cloud-init will crash because it does not handle the empty file.
|
||||
|
||||
RHBZ: 2140893
|
||||
|
||||
Signed-off-by: Emanuele Giuseppe Esposito <eesposit@redhat.com>
|
||||
|
||||
Signed-off-by: Emanuele Giuseppe Esposito <eesposit@redhat.com>
|
||||
---
|
||||
cloudinit/config/cc_set_hostname.py | 2 +-
|
||||
tests/unittests/config/test_cc_set_hostname.py | 17 +++++++++++++++++
|
||||
2 files changed, 18 insertions(+), 1 deletion(-)
|
||||
|
||||
diff --git a/cloudinit/config/cc_set_hostname.py b/cloudinit/config/cc_set_hostname.py
|
||||
index 2674fa20..7e3d5b74 100644
|
||||
--- a/cloudinit/config/cc_set_hostname.py
|
||||
+++ b/cloudinit/config/cc_set_hostname.py
|
||||
@@ -86,7 +86,7 @@ def handle(name, cfg, cloud, log, _args):
|
||||
# distro._read_hostname implementation so we only validate one artifact.
|
||||
prev_fn = os.path.join(cloud.get_cpath("data"), "set-hostname")
|
||||
prev_hostname = {}
|
||||
- if os.path.exists(prev_fn):
|
||||
+ if os.path.exists(prev_fn) and os.stat(prev_fn).st_size > 0:
|
||||
prev_hostname = util.load_json(util.load_file(prev_fn))
|
||||
hostname_changed = hostname != prev_hostname.get(
|
||||
"hostname"
|
||||
diff --git a/tests/unittests/config/test_cc_set_hostname.py b/tests/unittests/config/test_cc_set_hostname.py
|
||||
index 3d1d86ee..2c92949f 100644
|
||||
--- a/tests/unittests/config/test_cc_set_hostname.py
|
||||
+++ b/tests/unittests/config/test_cc_set_hostname.py
|
||||
@@ -5,6 +5,7 @@ import os
|
||||
import shutil
|
||||
import tempfile
|
||||
from io import BytesIO
|
||||
+from pathlib import Path
|
||||
from unittest import mock
|
||||
|
||||
from configobj import ConfigObj
|
||||
@@ -242,5 +243,21 @@ class TestHostname(t_help.FilesystemMockingTestCase):
|
||||
str(ctx_mgr.exception),
|
||||
)
|
||||
|
||||
+ def test_ignore_empty_previous_artifact_file(self):
|
||||
+ cfg = {
|
||||
+ "hostname": "blah",
|
||||
+ "fqdn": "blah.blah.blah.yahoo.com",
|
||||
+ }
|
||||
+ distro = self._fetch_distro("debian")
|
||||
+ paths = helpers.Paths({"cloud_dir": self.tmp})
|
||||
+ ds = None
|
||||
+ cc = cloud.Cloud(ds, paths, {}, distro, None)
|
||||
+ self.patchUtils(self.tmp)
|
||||
+ prev_fn = Path(cc.get_cpath("data")) / "set-hostname"
|
||||
+ prev_fn.touch()
|
||||
+ cc_set_hostname.handle("cc_set_hostname", cfg, cc, LOG, [])
|
||||
+ contents = util.load_file("/etc/hostname")
|
||||
+ self.assertEqual("blah", contents.strip())
|
||||
+
|
||||
|
||||
# vi: ts=4 expandtab
|
||||
--
|
||||
2.39.1
|
||||
|
Loading…
Reference in new issue