Revert decommit pooled pages by default patch (fix random crash)

epel9
Than Ngo 1 month ago
parent b9075d0e1f
commit cc4c497ae7

@ -0,0 +1,32 @@
commit 1ab1a14ad97394d384d8dc6de51bb229625e66d6
Author: Benoît Lizé <lizeb@chromium.org>
Date: Mon Sep 16 12:01:14 2024 +0200
[cppgc] Decommit pooled pages by default
This reduces committed memory by a large amount, which matters on
Windows. See the field trial results, which measure committed memory:
https://screenshot.googleplex.com/kEBAScqJSEXuRoy
Bug: chromium:326303884
Change-Id: I619257871bcdb7ed50a71f41af341d0df634428a
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5864909
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Anton Bikineev <bikineev@chromium.org>
Commit-Queue: Anton Bikineev <bikineev@chromium.org>
Auto-Submit: Benoit Lize <lizeb@chromium.org>
Cr-Commit-Position: refs/heads/main@{#96107}
diff --git a/v8/src/flags/flag-definitions.h b/v8/src/flags/flag-definitions.h
index 69946faf5ed..85c4b68612e 100644
--- a/v8/src/flags/flag-definitions.h
+++ b/v8/src/flags/flag-definitions.h
@@ -821,7 +821,7 @@ DEFINE_BOOL(trace_block_coverage, false,
"trace collected block coverage information")
DEFINE_BOOL(trace_protector_invalidation, false,
"trace protector cell invalidations")
-DEFINE_BOOL(decommit_pooled_pages, false,
+DEFINE_BOOL(decommit_pooled_pages, true,
"decommit, rather than discard pooled pages")
#ifdef V8_MINORMS_STRING_SHORTCUTTING

@ -339,6 +339,9 @@ Patch141: chromium-118-dma_buf_export_sync_file-conflict.patch
Patch150: chromium-124-qt6.patch Patch150: chromium-124-qt6.patch
Patch151: chromium-131-qt-ui.patch Patch151: chromium-131-qt-ui.patch
# revert, it causes ramdom crash on aarch64
Patch300: chromium-131-revert-decommit-pooled-pages-by-default.patch
# disable memory tagging (epel8 on aarch64) due to new feature IFUNC-Resolver # disable memory tagging (epel8 on aarch64) due to new feature IFUNC-Resolver
# it is not supported in old glibc < 2.30, error: fatal error: 'sys/ifunc.h' file not found # it is not supported in old glibc < 2.30, error: fatal error: 'sys/ifunc.h' file not found
Patch305: chromium-124-el8-arm64-memory_tagging.patch Patch305: chromium-124-el8-arm64-memory_tagging.patch
@ -1057,6 +1060,10 @@ Qt6 UI for chromium.
%patch -P151 -p1 -b .qt-ui %patch -P151 -p1 -b .qt-ui
%endif %endif
%ifarch aarch64 ppc64le
%patch -P300 -p1 -R -b .revert-decommit-pooled-pages-by-default
%endif
%if 0%{?rhel} == 8 %if 0%{?rhel} == 8
%ifarch aarch64 %ifarch aarch64
%patch -P305 -p1 -b .el8-memory_tagging %patch -P305 -p1 -b .el8-memory_tagging
@ -1934,6 +1941,7 @@ getent group chrome-remote-desktop >/dev/null || groupadd -r chrome-remote-deskt
%changelog %changelog
* Sat Nov 23 2024 Than Ngo <than@redhat.com> - 131.0.6778.85-2 * Sat Nov 23 2024 Than Ngo <than@redhat.com> - 131.0.6778.85-2
- Enable qt-ui - Enable qt-ui
- Workaround for random crash
* Wed Nov 20 2024 Than Ngo <than@redhat.com> - 131.0.6778.85-1 * Wed Nov 20 2024 Than Ngo <than@redhat.com> - 131.0.6778.85-1
- Update to 131.0.6778.85 - Update to 131.0.6778.85

Loading…
Cancel
Save