import NetworkManager-libreswan-1.2.10-5.el8

9 months ago · 1fa022508d
commit 1fa022508d
6 changed files with 24853 additions and 0 deletions
--- a/.NetworkManager-libreswan.metadata
+++ b/.NetworkManager-libreswan.metadata
@ -0,0 +1 @@
+a3ec22a8e76f3358d9f69dc505d22267e936dbae SOURCES/NetworkManager-libreswan-1.2.10.tar.xz
--- a/.gitignore
+++ b/.gitignore
@ -0,0 +1 @@
+SOURCES/NetworkManager-libreswan-1.2.10.tar.xz
--- a/SOURCES/0001-po-import-translations-from-Red-Hat-translators.patch
+++ b/SOURCES/0001-po-import-translations-from-Red-Hat-translators.patch
--- a/SOURCES/0002-properties-set-advanced-dialog-modal.patch
+++ b/SOURCES/0002-properties-set-advanced-dialog-modal.patch
@ -0,0 +1,26 @@
+From eaf501ab7cb732a152097d2af5636b03fd3f029d Mon Sep 17 00:00:00 2001
+From: Francesco Giudici <fgiudici@redhat.com>
+Date: Mon, 15 Apr 2019 14:51:26 +0200
+Subject: [PATCH] properties: set advanced dialog modal
+
+https://bugzilla.redhat.com/show_bug.cgi?id=1697329
+---
+ properties/nm-libreswan-dialog.ui | 2 ++
+ 1 file changed, 2 insertions(+)
+
+diff --git a/properties/nm-libreswan-dialog.ui b/properties/nm-libreswan-dialog.ui
+index 73522d4..e355c08 100644
+--- a/properties/nm-libreswan-dialog.ui
+++ b/properties/nm-libreswan-dialog.ui
+@@ -451,6 +451,8 @@
+     <property name="can_focus">False</property>
+     <property name="border_width">12</property>
+     <property name="title" translatable="yes">IPsec Advanced Options</property>
+    <property name="modal">True</property>
+    <property name="destroy_with_parent">True</property>
+     <property name="type_hint">dialog</property>
+     <child internal-child="vbox">
+       <object class="GtkBox" id="dialog-vbox1">
+-- 
+2.20.1
+
--- a/SOURCES/0003-service-fix-wrong-refcounting-in-D-Bus-handler-for-C.patch
+++ b/SOURCES/0003-service-fix-wrong-refcounting-in-D-Bus-handler-for-C.patch
@ -0,0 +1,68 @@
+From 4be4c56b4f8a52b1cd5f8aadee273706c28ae332 Mon Sep 17 00:00:00 2001
+From: Beniamino Galvani <bgalvani@redhat.com>
+Date: Sat, 13 Jan 2024 18:10:02 +0100
+Subject: [PATCH 1/1] service: fix wrong refcounting in D-Bus handler for
+ Callback()
+
+The Callback() D-Bus method is handled via a GDBus-generated skeleton
+code in nm-libreswan-helper-service-dbus.c, function
+_nmdbus_libreswan_helper_skeleton_handle_method_call(). The function
+emits signal "handle-callback" to let the program handle the incoming
+method. As documented in the GDoc comments, the signal handler must
+return TRUE if it handles the call.
+
+```
+  /**
+   * NMDBusLibreswanHelper::handle-callback:
+   * @object: A #NMDBusLibreswanHelper.
+   * @invocation: A #GDBusMethodInvocation.
+   * @arg_environment: Argument passed by remote caller.
+
+   * Signal emitted when a remote caller is invoking the Callback()
+     D-Bus method.
+
+   * If a signal handler returns %TRUE, it means the signal handler
+     will handle the invocation (e.g. take a reference to @invocation
+     and eventually call nmdbus_libreswan_helper_complete_callback()
+     or e.g. g_dbus_method_invocation_return_error() on it) and no
+     other signal handlers will run. If no signal handler handles the
+     invocation, the %G_DBUS_ERROR_UNKNOWN_METHOD error is returned.
+
+   * Returns: %G_DBUS_METHOD_INVOCATION_HANDLED or %TRUE if the
+     invocation was handled, %G_DBUS_METHOD_INVOCATION_UNHANDLED or
+     %FALSE to let other signal handlers run.
+   */
+```
+
+At the moment, in case of error the handler first calls
+nmdbus_libreswan_helper_complete_callback() which decreases the
+refcount of "invocation", and then returns FALSE which tells the
+skeleton code to return an error, also unreferencing the
+invocation. This causes a crash.
+
+Since the G_DBUS_METHOD_INVOCATION_HANDLED alias for TRUE is only
+available since GLib 2.68 (while we target 2.36), just return TRUE.
+
+Fixes: acb9eb9de50b ('service: process the configuration in the service, not the helper')
+(cherry picked from commit 8ceb901719acac3778e1d76779d9c14289185157)
+---
+ src/nm-libreswan-service.c | 3 ++-
+ 1 file changed, 2 insertions(+), 1 deletion(-)
+
+diff --git a/src/nm-libreswan-service.c b/src/nm-libreswan-service.c
+index fc470a6..4850729 100644
+--- a/src/nm-libreswan-service.c
+++ b/src/nm-libreswan-service.c
+@@ -1379,7 +1379,8 @@ out:
+ 	}
+ 
+ 	nmdbus_libreswan_helper_complete_callback (object, invocation);
+-	return success;
+
+	return TRUE;
+ }
+ 
+ /****************************************************************/
+-- 
+2.43.0
+
--- a/SPECS/NetworkManager-libreswan.spec
+++ b/SPECS/NetworkManager-libreswan.spec
@ -0,0 +1,348 @@
+%if 0%{?fedora} < 28 && 0%{?rhel} < 8
+%bcond_without libnm_glib
+%else
+# Disable the legacy version by default
+%bcond_with libnm_glib
+%endif
+
+%global nm_version        1:1.2.0
+%global nma_version       1.2.0
+
+Summary:   NetworkManager VPN plug-in for IPsec VPN
+Name:      NetworkManager-libreswan
+Version:   1.2.10
+Release:   5%{?dist}
+License:   GPLv2+
+URL:       http://www.gnome.org/projects/NetworkManager/
+Group:     System Environment/Base
+Source0:   https://download.gnome.org/sources/NetworkManager-libreswan/1.2/%{name}-%{version}.tar.xz
+Patch0:    0001-po-import-translations-from-Red-Hat-translators.patch
+Patch1:    0002-properties-set-advanced-dialog-modal.patch
+Patch2:    0003-service-fix-wrong-refcounting-in-D-Bus-handler-for-C.patch
+
+BuildRequires: gtk3-devel
+BuildRequires: libnl3-devel
+BuildRequires: NetworkManager-libnm-devel >= %{nm_version}
+BuildRequires: libnma-devel >= %{nma_version}
+BuildRequires: libsecret-devel
+BuildRequires: intltool gettext
+
+%if %with libnm_glib
+BuildRequires: NetworkManager-devel >= %{nm_version}
+BuildRequires: NetworkManager-glib-devel >= %{nm_version}
+BuildRequires: libnm-gtk-devel >= %{nma_version}
+%endif
+
+Requires: NetworkManager >= %{nm_version}
+Requires: dbus
+Requires: /usr/sbin/ipsec
+
+Provides: NetworkManager-openswan = %{version}-%{release}
+Obsoletes: NetworkManager-openswan < %{version}-%{release}
+
+%global _privatelibs libnm-libreswan-properties[.]so.*
+%global __provides_exclude ^(%{_privatelibs})$
+%global __requires_exclude ^(%{_privatelibs})$
+
+%description
+This package contains software for integrating the libreswan VPN software
+with NetworkManager and the GNOME desktop
+
+%package -n NetworkManager-libreswan-gnome
+Summary: NetworkManager VPN plugin for libreswan - GNOME files
+Group:   System Environment/Base
+
+Requires: %{name}%{?_isa} = %{version}-%{release}
+Requires: shared-mime-info
+
+Provides: NetworkManager-openswan-gnome = %{version}-%{release}
+Obsoletes: NetworkManager-openswan-gnome < %{version}-%{release}
+
+%description -n NetworkManager-libreswan-gnome
+This package contains software for integrating VPN capabilities with
+the libreswan server with NetworkManager (GNOME files).
+
+%prep
+%autosetup -p1 -n %{name}-%{version}
+
+%build
+%configure \
+        --disable-static \
+%if %without libnm_glib
+        --without-libnm-glib \
+%endif
+        --enable-more-warnings=yes \
+        --with-dist-version=%{version}-%{release}
+make %{?_smp_mflags}
+
+%install
+make install DESTDIR=%{buildroot}
+rm -f %{buildroot}%{_libdir}/NetworkManager/lib*.la
+
+%find_lang %{name}
+
+%post
+update-desktop-database &> /dev/null || :
+
+%postun
+update-desktop-database &> /dev/null || :
+
+%files -f %{name}.lang
+%{_libdir}/NetworkManager/libnm-vpn-plugin-libreswan.so
+%{_sysconfdir}/dbus-1/system.d/nm-libreswan-service.conf
+%{_prefix}/lib/NetworkManager/VPN/nm-libreswan-service.name
+%{_libexecdir}/nm-libreswan-service
+%{_libexecdir}/nm-libreswan-service-helper
+%{_mandir}/man5/nm-settings-libreswan.5.gz
+%doc AUTHORS ChangeLog NEWS
+%license COPYING
+
+%files -n NetworkManager-libreswan-gnome
+%{_libexecdir}/nm-libreswan-auth-dialog
+%{_libdir}/NetworkManager/libnm-vpn-plugin-libreswan-editor.so
+%dir %{_datadir}/gnome-vpn-properties/libreswan
+%{_datadir}/gnome-vpn-properties/libreswan/nm-libreswan-dialog.ui
+%{_datadir}/appdata/network-manager-libreswan.metainfo.xml
+
+%if %with libnm_glib
+%{_libdir}/NetworkManager/libnm-*-properties.so
+%{_sysconfdir}/NetworkManager/VPN/nm-libreswan-service.name
+%endif
+
+%changelog
+* Fri Mar 29 2024 MSVSphere Packaging Team <packager@msvsphere-os.ru> - 1.2.10-5
+- Rebuilt for MSVSphere 8.10 beta
+
+* Mon Feb  5 2024 Wen Liang <wenliang@redhat.com> - 1.2.10-5
+- Fix crash in libreswan_add_profile_wrong_password (RHEL-13123)
+
+* Tue Jul  9 2019 Francesco Giudici <fgiudici@redhat.com> - 1.2.10-4
+- Fix Gnome IPsec advanced options dialog (rh #1697329)
+
+* Mon Dec 10 2018 Lubomir Rintel <lkundrak@v3.sk> - 1.2.10-3
+- Update the translations (rh #1608329)
+
+* Thu Oct 16 2018 Lubomir Rintel <lkundrak@v3.sk> - 1.2.10-2
+- Import the translations (rh #1608329)
+
+* Mon Oct 15 2018 Francesco Giudici <fgiudici@redhat.com> - 1.2.10-1
+- Update to 1.2.10 release (rh #1637867)
+- Fix import functionality (rh #1633174)
+
+* Wed Oct  3 2018 Beniamino Galvani <bgalvani@redhat.com> - 1.2.8-2
+- Rebuild with updated annobin (rh #1630605)
+
+* Mon Sep 17 2018 Francesco Giudici <fgiudici@redhat.com> - 1.2.8-1
+- Update to 1.2.8 release
+
+* Mon Aug 13 2018 Francesco Giudici <fgiudici@redhat.com> - 1.2.8-0.1
+- Update to latest development snapshot of NetworkManager-libreswan 1.2.8
+- Introduced IKEv2 support (rh #1557035)
+- Introduced support to more Libreswan properties (rh #1557035)
+- Updated translations
+
+* Wed Feb 07 2018 Fedora Release Engineering <releng@fedoraproject.org> - 1.2.4-6
+- Rebuilt for https://fedoraproject.org/wiki/Fedora_28_Mass_Rebuild
+
+* Thu Nov 30 2017 Lubomir Rintel <lkundrak@v3.sk> - 1.2.4-4
+- Drop libnm-glib for Fedora 28
+
+* Wed Aug 02 2017 Fedora Release Engineering <releng@fedoraproject.org> - 1.2.4-4
+- Rebuilt for https://fedoraproject.org/wiki/Fedora_27_Binutils_Mass_Rebuild
+
+* Wed Jul 26 2017 Fedora Release Engineering <releng@fedoraproject.org> - 1.2.4-3
+- Rebuilt for https://fedoraproject.org/wiki/Fedora_27_Mass_Rebuild
+
+* Fri Feb 10 2017 Fedora Release Engineering <releng@fedoraproject.org> - 1.2.4-2
+- Rebuilt for https://fedoraproject.org/wiki/Fedora_26_Mass_Rebuild
+
+* Thu Jun 30 2016 Thomas Haller <thaller@redhat.com> - 1.2.4-1
+- Update to 1.2.4 release
+- Move base VPN plugin library to base libreswan package
+- Don't require nm-connection-editor anymore
+
+* Wed May 11 2016 Lubomir Rintel <lkundrak@v3.sk> - 1.2.2-1
+- Update to 1.2.2 release
+
+* Wed Apr 20 2016 Lubomir Rintel <lkundrak@v3.sk> - 1.2.0-1
+- Update to 1.2.0 release
+
+* Tue Apr  5 2016 Lubomir Rintel <lkundrak@v3.sk> - 1.2.0-0.4.rc1
+- Update to NetworkManager-libreswan 1.2-rc1
+
+* Tue Mar  1 2016 Lubomir Rintel <lkundrak@v3.sk> - 1.2.0-0.4.beta2
+- Update to NetworkManager-libreswan 1.2-beta2
+
+* Wed Feb 03 2016 Fedora Release Engineering <releng@fedoraproject.org> - 1.2.0-0.4.beta1
+- Rebuilt for https://fedoraproject.org/wiki/Fedora_24_Mass_Rebuild
+
+* Mon Feb 1 2016 Lubomir Rintel <lkundrak@v3.sk> - 1.2.0-0.3.beta1
+- Update to support Main mode & better Libreswan integration
+
+* Tue Jan 19 2016 Lubomir Rintel <lkundrak@v3.sk> - 1.2.0-0.2.beta1
+- Update to NetworkManager-libreswan 1.2-beta1
+
+* Wed Dec 16 2015 Lubomir Rintel <lkundrak@v3.sk> - 1.2.0-0.1.20151216gite52aff0
+- A newer git snapshot with import/export support
+
+* Mon Nov 16 2015 Lubomir Rintel <lkundrak@v3.sk> - 1.2.0-0.1.20151116git15db395
+- Rename to NetworkManager-libreswan
+- A newer git snapshot with multiple connection support
+
+* Fri Oct 23 2015 Lubomir Rintel <lkundrak@v3.sk> - 1.2.0-0.1.20151023git8a39c0f
+- Update to a newer git snapshot
+
+* Tue Sep 1 2015 Lubomir Rintel <lkundrak@v3.sk> - 1.2.0-0.1.20150901git92f1611
+- Update to 1.2 git snapshot with libnm-based properties plugin
+
+* Fri Aug 28 2015 Lubomir Rintel <lkundrak@v3.sk> - 1.0.6-2
+- Don't unconditionally set cisco-unity=yes
+
+* Thu Aug 27 2015 Lubomir Rintel <lkundrak@v3.sk> - 1.0.6-1
+- Update to 1.0.6 release
+
+* Tue Jun 16 2015 Fedora Release Engineering <rel-eng@lists.fedoraproject.org> - 1.0.2-2
+- Rebuilt for https://fedoraproject.org/wiki/Fedora_23_Mass_Rebuild
+
+* Tue May 5 2015 Lubomir Rintel <lkundrak@v3.sk> - 1.0.2-1
+- Update to 1.0.2 release
+
+* Mon Dec 22 2014 Dan Williams <dcbw@redhat.com> - 1.0.0-1
+- Update to 1.0
+
+* Fri Aug 15 2014 Fedora Release Engineering <rel-eng@lists.fedoraproject.org> - 0.9.8.4-4
+- Rebuilt for https://fedoraproject.org/wiki/Fedora_21_22_Mass_Rebuild
+
+* Fri Jun 06 2014 Fedora Release Engineering <rel-eng@lists.fedoraproject.org> - 0.9.8.4-3
+- Rebuilt for https://fedoraproject.org/wiki/Fedora_21_Mass_Rebuild
+
+* Thu Dec 12 2013 Avesh Agarwal <avagarwa@redhat.com> - 0.9.8.4-2
+- Fixes 1035786 (and its duplicate 1040924)
+
+* Tue Dec 10 2013 Avesh Agarwal <avagarwa@redhat.com> - 0.9.8.4-1
+- New upstream release 0.9.8.4
+- Fixed 926225
+- Fixed dependency to libreswan.
+- Created a new sub package NetworkManager-openswan-gnome
+- Various other spec file fixes.
+- Additional code changes are as follows:
+- Fixed an issue where proper network stack is not loaded unless
+  _stackmanager is run before starting pluto daemon service.
+- Fixed the termination operation of pluto daemon to comply with
+  libreswan changes.
+- Fixed various debug messages.
+- Fixed initiation of pluto daemon by this plugin to reflect the
+  changes in libreaswan.
+- Fixed defaults values for more parameters to help the VPN
+  connection stay more reliable.
+- Rewrote pluto watch API which watches the pluto process for its status.
+  Fixed memory leak issues as not all child processes were reaped correctly.
+  Also g_spwan_close_pid was not being called after children were reaped.
+  Also modified debugs and added more to help with debugging in the future.
+- Fixed an issue where nm-openswan service is searching for ipsec binary in
+  both /sbin and /usr/sbin leading to same operation twice, as /sbin is just
+  symlink to /usr/sbin, so removed /sbin from the search paths.
+- Fixed some libreswan related macro changes.
+- Fixed netmask issue when sending IP information to the nm openswan
+  plugin service.
+- Fixed the current code as it does not set the default route field
+  NM_VPN_PLUGIN_IP4_CONFIG_NEVER_DEFAULT when sending VPN information
+  to nm-openswan plugin. This fix sets the field to TRUE.
+- Fixed some issues found by coverity scan.
+- Fixed an issue where writing configuration on stdin should not end with
+  \n as it gives error. It used to work previously, but not with latest
+  NetworkManager versions.
+- libreswan related fixes, as some macros have been modified after forking
+  to libreswan from openswan.
+- openswan/libreswan does not provide tun0 interface, so fixed the code
+  where it sends tun0 interface.
+- Fix prcoessing of nm-openswan-dialog.ui file and added more error notifications.
+- Fixed dead code based on coverity scan.
+- Fixed gnomekeyring lib dependencies.
+- Fixed Networkmanager and related lib dependencies.
+- Fixed gtk label max width issue by setting it to 35.
+- NM-openswan was missing support for nm-openswan-auth-dialog.desktop.in.in.
+  So added a new nm-openswan-auth-dialog.desktop.in.in, and modified related
+  Makefile and configure.ac files.
+
+* Mon Aug 5 2013 Avesh Agarwal <avagarwa@redhat.com> - 0.9.8.0-1
+- Rebase to latest upstream version 0.9.8.0
+- Fixed several issues with the packaging
+
+* Fri Aug 02 2013 Fedora Release Engineering <rel-eng@lists.fedoraproject.org> - 0.9.3.995-6.git20120302
+- Rebuilt for https://fedoraproject.org/wiki/Fedora_20_Mass_Rebuild
+
+* Wed Feb 13 2013 Fedora Release Engineering <rel-eng@lists.fedoraproject.org> - 0.9.3.995-5.git20120302
+- Rebuilt for https://fedoraproject.org/wiki/Fedora_19_Mass_Rebuild
+
+* Thu Dec 13 2012 Avesh Agarwal <avagarwa@redhat.com> - 0.9.3.995-4
+Resolves: #845599, #865883
+
+* Wed Jul 18 2012 Fedora Release Engineering <rel-eng@lists.fedoraproject.org> - 0.9.3.995-3.git20120302
+- Rebuilt for https://fedoraproject.org/wiki/Fedora_18_Mass_Rebuild
+
+* Fri Apr 27 2012 Avesh Agarwal <avagarwa@redhat.com> - 0.9.3.995-2
+- Ported changes from rhel to fedora
+
+* Fri Mar  2 2012 Dan Williams <dcbw@redhat.com> - 0.9.3.995-1
+- Update to 0.9.3.995 (0.9.4-beta1)
+- ui: add support for external UI mode, eg GNOME Shell
+
+* Thu Jan 12 2012 Fedora Release Engineering <rel-eng@lists.fedoraproject.org> - 0.9.0-3
+- Rebuilt for https://fedoraproject.org/wiki/Fedora_17_Mass_Rebuild
+
+* Tue Dec 06 2011 Adam Jackson <ajax@redhat.com> - 0.9.0-2
+- Rebuild for new libpng
+
+* Fri Aug 26 2011 Dan Williams <dcbw@redhat.com> - 0.9.0-1
+- Update to 0.9.0
+- ui: translation fixes
+
+* Thu Jul 21 2011 Dan Williams <dcbw@redhat.com> - 0.8.999-2.git20110721
+- Update to git snapshot
+- Fixes for secrets handling and saving
+
+* Tue May 03 2011 Dan Williams <dcbw@redhat.com> - 0.8.999-1
+- Update to 0.8.999 (0.9-rc2)
+- Port to GTK 3.0 and GtkBuilder
+- Fix some issues with secrets storage
+
+* Sun Mar 27 2011 Christopher Aillon <caillon@redhat.com> - 0.8.0-9.20100411git
+- Rebuild against NetworkManager 0.9
+
+* Wed Feb 16 2011 Avesh Agarwal <avagarwa@redhat.com> - 0.8.0-8.20100411git
+- fixes for compile time errors
+
+* Mon Feb 07 2011 Fedora Release Engineering <rel-eng@lists.fedoraproject.org> - 0.8.0-7.20100411git
+- Rebuilt for https://fedoraproject.org/wiki/Fedora_15_Mass_Rebuild
+
+* Tue Sep 7 2010 Avesh Agarwal <avagarwa@redhat.com> - 0.8.0-6.20100411git
+- Modified import and export interfaces to import_from_file and export_to_file, respectively,
+  due to changes in NMVpnPluginUiInterface struct in NM (bz 631159).
+
+* Mon Jul 26 2010 Avesh Agarwal <avagarwa@redhat.com> - 0.8.0-5.20100411git
+Resolves: #616910
+- Support for reading phase1 and phase2 algorithms through GUI
+
+* Tue Jul 13 2010 Avesh Agarwal <avagarwa@redhat.com> - 0.8.0-4.20100411git
+- Modified fix for the bz 607352
+- Fix to read connection configuration from stdin
+- Fix to read Xauth user password from stdin
+- Fix to delete the secret file as soon as read by Openswan
+
+* Thu Jul 8 2010 Avesh Agarwal <avagarwa@redhat.com> - 0.8.0-3.20100411git
+- Modified the patch so that it does not pass user password to
+  "ipsec whack" command.
+
+* Thu Jul 8 2010 Avesh Agarwal <avagarwa@redhat.com> - 0.8.0-2.20100411git
+- Modified to initiate VPN connections with openswan whack interface
+- Fixed the issue of world readable conf and secret files
+- Cleaned conf and secret files after VPN connection is stopped
+- Fixed the issue of storing sensitive information like user
+  password in a file (rhbz# 607352)
+- Changed PLUTO_SERVERBANNER to PLUTO_PEER_BANNER due
+  to the same change in Openswan
+- Modifed GUI to remove unused configuration boxes
+
+* Tue Jun 15 2010 Avesh Agarwal <avagarwa@redhat.com> - 0.8.0-1.20100%{version}t
+- Initial build
				`@ -0,0 +1 @@`
				`a3ec22a8e76f3358d9f69dc505d22267e936dbae SOURCES/NetworkManager-libreswan-1.2.10.tar.xz`
				`@ -0,0 +1 @@`
				`SOURCES/NetworkManager-libreswan-1.2.10.tar.xz`