backport cf96d52790bc8d05a9e556e33af0b6fec1a4cb0e to display an error message when plugins are missing.
parent
4a518422c7
commit
5b25732e22
@ -0,0 +1,39 @@
|
||||
From cf96d52790bc8d05a9e556e33af0b6fec1a4cb0e Mon Sep 17 00:00:00 2001
|
||||
From: Moritz Lipp <mlq@pwmt.org>
|
||||
Date: Tue, 28 May 2013 17:00:37 +0200
|
||||
Subject: [PATCH 1/1] Report missing plugin/unsupported file type
|
||||
|
||||
---
|
||||
document.c | 1 +
|
||||
zathura.c | 3 +++
|
||||
2 files changed, 4 insertions(+)
|
||||
|
||||
diff --git a/document.c b/document.c
|
||||
index 2e6e557..7ca21ff 100644
|
||||
--- a/document.c
|
||||
+++ b/document.c
|
||||
@@ -110,6 +110,7 @@ zathura_document_open(zathura_plugin_manager_t* plugin_manager, const char*
|
||||
|
||||
if (plugin == NULL) {
|
||||
girara_error("unknown file type\n");
|
||||
+ error = ZATHURA_ERROR_UNKNOWN;
|
||||
goto error_free;
|
||||
}
|
||||
|
||||
diff --git a/zathura.c b/zathura.c
|
||||
index cdf4eac..a0a8f57 100644
|
||||
--- a/zathura.c
|
||||
+++ b/zathura.c
|
||||
@@ -562,6 +562,9 @@ document_open(zathura_t* zathura, const char* path, const char* password,
|
||||
zathura_document_t* document = zathura_document_open(zathura->plugins.manager, path, password, &error);
|
||||
|
||||
if (document == NULL) {
|
||||
+ if (error == NULL ) {
|
||||
+ girara_notify(zathura->ui.session, GIRARA_ERROR, _("Unsupported file type. Please install the necessary plugin."), false, NULL, NULL, NULL);
|
||||
+ }
|
||||
if (error == ZATHURA_ERROR_INVALID_PASSWORD) {
|
||||
zathura_password_dialog_info_t* password_dialog_info = malloc(sizeof(zathura_password_dialog_info_t));
|
||||
if (password_dialog_info != NULL) {
|
||||
--
|
||||
1.7.10.4
|
||||
|
Loading…
Reference in new issue