You can not select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
34 lines
1.5 KiB
34 lines
1.5 KiB
2 years ago
|
From 04326c02ca80666e66a5da8e6a46c2fc4476000c Mon Sep 17 00:00:00 2001
|
||
|
|
From: =?UTF-8?q?Zbigniew=20J=C4=99drzejewski-Szmek?= <zbyszek@in.waw.pl>
|
||
|
|
Date: Wed, 5 Dec 2018 21:34:24 +0100
|
||
|
|
Subject: [PATCH] coredump: fix message when we fail to save a journald
|
||
|
|
coredump
|
||
|
|
|
||
|
|
If creation of the message failed, we'd write a bogus entry:
|
||
|
|
systemd-coredump[1400]: Cannot store coredump of 416 (systemd-journal): No space left on device
|
||
|
|
systemd-coredump[1400]: MESSAGE=Process 416 (systemd-journal) of user 0 dumped core.
|
||
|
|
systemd-coredump[1400]: Coredump diverted to
|
||
|
|
|
||
|
|
(cherry-picked from commit f0136e09221364f931c3a3b715da4e4d3ee9f2ac)
|
||
|
|
|
||
|
|
Related: #1664976
|
||
|
|
---
|
||
|
|
src/coredump/coredump.c | 4 ++--
|
||
|
|
1 file changed, 2 insertions(+), 2 deletions(-)
|
||
|
|
|
||
|
|
diff --git a/src/coredump/coredump.c b/src/coredump/coredump.c
|
||
|
|
index ffa88f612d..2a130e8838 100644
|
||
|
|
--- a/src/coredump/coredump.c
|
||
|
|
+++ b/src/coredump/coredump.c
|
||
|
|
@@ -783,8 +783,8 @@ log:
|
||
|
|
core_message = strjoin("MESSAGE=Process ", context[CONTEXT_PID],
|
||
|
|
" (", context[CONTEXT_COMM], ") of user ",
|
||
|
|
context[CONTEXT_UID], " dumped core.",
|
||
|
|
- journald_crash ? "\nCoredump diverted to " : NULL,
|
||
|
|
- journald_crash ? filename : NULL);
|
||
|
|
+ journald_crash && filename ? "\nCoredump diverted to " : NULL,
|
||
|
|
+ journald_crash && filename ? filename : NULL);
|
||
|
|
if (!core_message)
|
||
|
|
return log_oom();
|
||
|
|
|