You can not select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
57 lines
2.7 KiB
57 lines
2.7 KiB
2 years ago
|
From fde3fa3e9c0330c7de645ce2140f9dd39640a693 Mon Sep 17 00:00:00 2001
|
||
|
|
From: =?UTF-8?q?Zbigniew=20J=C4=99drzejewski-Szmek?= <zbyszek@in.waw.pl>
|
||
|
|
Date: Fri, 7 Dec 2018 10:48:10 +0100
|
||
|
|
Subject: [PATCH] journal-remote: set a limit on the number of fields in a
|
||
|
|
message
|
||
|
|
|
||
|
|
Existing use of E2BIG is replaced with ENOBUFS (entry too long), and E2BIG is
|
||
|
|
reused for the new error condition (too many fields).
|
||
|
|
|
||
|
|
This matches the change done for systemd-journald, hence forming the second
|
||
|
|
part of the fix for CVE-2018-16865
|
||
|
|
(https://bugzilla.redhat.com/show_bug.cgi?id=1653861).
|
||
|
|
|
||
|
|
(cherry-picked from commit ef4d6abe7c7fab6cbff975b32e76b09feee56074)
|
||
|
|
|
||
|
|
Resolves: #1664977
|
||
|
|
---
|
||
|
|
src/journal-remote/journal-remote-main.c | 7 +++++--
|
||
|
|
src/journal-remote/journal-remote.c | 5 ++++-
|
||
|
|
2 files changed, 9 insertions(+), 3 deletions(-)
|
||
|
|
|
||
|
|
diff --git a/src/journal-remote/journal-remote-main.c b/src/journal-remote/journal-remote-main.c
|
||
|
|
index e9b3702e8a..5b0bbba310 100644
|
||
|
|
--- a/src/journal-remote/journal-remote-main.c
|
||
|
|
+++ b/src/journal-remote/journal-remote-main.c
|
||
|
|
@@ -211,9 +211,12 @@ static int process_http_upload(
|
||
|
|
if (r == -EAGAIN)
|
||
|
|
break;
|
||
|
|
if (r < 0) {
|
||
|
|
- if (r == -E2BIG)
|
||
|
|
- log_warning_errno(r, "Entry is too above maximum of %u, aborting connection %p.",
|
||
|
|
+ if (r == -ENOBUFS)
|
||
|
|
+ log_warning_errno(r, "Entry is above the maximum of %u, aborting connection %p.",
|
||
|
|
DATA_SIZE_MAX, connection);
|
||
|
|
+ else if (r == -E2BIG)
|
||
|
|
+ log_warning_errno(r, "Entry with more fields than the maximum of %u, aborting connection %p.",
|
||
|
|
+ ENTRY_FIELD_COUNT_MAX, connection);
|
||
|
|
else
|
||
|
|
log_warning_errno(r, "Failed to process data, aborting connection %p: %m",
|
||
|
|
connection);
|
||
|
|
diff --git a/src/journal-remote/journal-remote.c b/src/journal-remote/journal-remote.c
|
||
|
|
index beb75a1cb4..67e3a70c06 100644
|
||
|
|
--- a/src/journal-remote/journal-remote.c
|
||
|
|
+++ b/src/journal-remote/journal-remote.c
|
||
|
|
@@ -408,7 +408,10 @@ int journal_remote_handle_raw_source(
|
||
|
|
log_debug("%zu active sources remaining", s->active);
|
||
|
|
return 0;
|
||
|
|
} else if (r == -E2BIG) {
|
||
|
|
- log_notice_errno(E2BIG, "Entry too big, skipped");
|
||
|
|
+ log_notice("Entry with too many fields, skipped");
|
||
|
|
+ return 1;
|
||
|
|
+ } else if (r == -ENOBUFS) {
|
||
|
|
+ log_notice("Entry too big, skipped");
|
||
|
|
return 1;
|
||
|
|
} else if (r == -EAGAIN) {
|
||
|
|
return 0;
|