You can not select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
65 lines
2.2 KiB
65 lines
2.2 KiB
1 year ago
|
From b7b6493dd0a58931afbb7c7d818c1ebb6460b2bc Mon Sep 17 00:00:00 2001
|
||
1 year ago
|
From: Jan Macku <jamacku@redhat.com>
|
||
|
|
Date: Tue, 9 May 2023 13:15:06 +0200
|
||
|
|
Subject: [PATCH] manager: don't taint the host if cgroups v1 is used
|
||
|
|
|
||
|
|
In upstream of systemd, cgroups v1 are not considered as supported.
|
||
|
|
This is not true for RHEL, don't taint the host when cgroups v1 are enabled.
|
||
|
|
|
||
|
|
rhel-only
|
||
|
|
|
||
|
1 year ago
|
Resolves: #2193456
|
||
|
1 year ago
|
---
|
||
|
|
man/org.freedesktop.systemd1.xml | 6 ------
|
||
|
|
src/core/manager.c | 3 ---
|
||
|
|
src/test/test-manager.c | 5 -----
|
||
|
|
3 files changed, 14 deletions(-)
|
||
|
|
|
||
|
|
diff --git a/man/org.freedesktop.systemd1.xml b/man/org.freedesktop.systemd1.xml
|
||
|
|
index 40510c43eb..13a84af747 100644
|
||
|
|
--- a/man/org.freedesktop.systemd1.xml
|
||
|
|
+++ b/man/org.freedesktop.systemd1.xml
|
||
|
|
@@ -1589,12 +1589,6 @@ node /org/freedesktop/systemd1 {
|
||
|
|
<listitem><para>Support for cgroups is unavailable.</para></listitem>
|
||
|
|
</varlistentry>
|
||
|
|
|
||
|
|
- <varlistentry>
|
||
|
|
- <term><literal>cgroupsv1</literal></term>
|
||
|
|
-
|
||
|
|
- <listitem><para>The system is using the old cgroup hierarchy.</para></listitem>
|
||
|
|
- </varlistentry>
|
||
|
|
-
|
||
|
|
<varlistentry>
|
||
|
|
<term><literal>local-hwclock</literal></term>
|
||
|
|
|
||
|
|
diff --git a/src/core/manager.c b/src/core/manager.c
|
||
|
|
index a59afafb58..657263eb73 100644
|
||
|
|
--- a/src/core/manager.c
|
||
|
|
+++ b/src/core/manager.c
|
||
|
|
@@ -4491,9 +4491,6 @@ char* manager_taint_string(const Manager *m) {
|
||
|
|
if (access("/proc/cgroups", F_OK) < 0)
|
||
|
|
stage[n++] = "cgroups-missing";
|
||
|
|
|
||
|
|
- if (cg_all_unified() == 0)
|
||
|
|
- stage[n++] = "cgroupsv1";
|
||
|
|
-
|
||
|
|
if (clock_is_localtime(NULL) > 0)
|
||
|
|
stage[n++] = "local-hwclock";
|
||
|
|
|
||
|
|
diff --git a/src/test/test-manager.c b/src/test/test-manager.c
|
||
|
|
index 89f9277b28..2faf715d76 100644
|
||
|
|
--- a/src/test/test-manager.c
|
||
|
|
+++ b/src/test/test-manager.c
|
||
|
|
@@ -14,11 +14,6 @@ TEST(manager_taint_string) {
|
||
|
|
* to test for them. Let's do just one. */
|
||
|
|
assert_se(!strstr(a, "split-usr"));
|
||
|
|
|
||
|
|
- if (cg_all_unified() == 0)
|
||
|
|
- assert_se(strstr(a, "cgroupsv1"));
|
||
|
|
- else
|
||
|
|
- assert_se(!strstr(a, "cgroupsv1"));
|
||
|
|
-
|
||
|
|
m.taint_usr = true;
|
||
|
|
_cleanup_free_ char *b = manager_taint_string(&m);
|
||
|
|
assert_se(b);
|