From 212e697b9d6f981a85e5848ff8e6afe985962226 Mon Sep 17 00:00:00 2001 From: CentOS Sources Date: Tue, 16 May 2023 06:04:04 +0000 Subject: [PATCH] import stalld-1.17.1-1.el8 --- .gitignore | 1 + .stalld.metadata | 1 + .../Start-stalld-service-as-initrc_t.patch | 27 ++ SPECS/stalld.spec | 242 ++++++++++++++++++ 4 files changed, 271 insertions(+) create mode 100644 .gitignore create mode 100644 .stalld.metadata create mode 100644 SOURCES/Start-stalld-service-as-initrc_t.patch create mode 100644 SPECS/stalld.spec diff --git a/.gitignore b/.gitignore new file mode 100644 index 0000000..3542b24 --- /dev/null +++ b/.gitignore @@ -0,0 +1 @@ +SOURCES/stalld-1.17.1.tar.bz2 diff --git a/.stalld.metadata b/.stalld.metadata new file mode 100644 index 0000000..1288e53 --- /dev/null +++ b/.stalld.metadata @@ -0,0 +1 @@ +449566fc8c5f8568a92ed0a04d15c31d64878741 SOURCES/stalld-1.17.1.tar.bz2 diff --git a/SOURCES/Start-stalld-service-as-initrc_t.patch b/SOURCES/Start-stalld-service-as-initrc_t.patch new file mode 100644 index 0000000..4a88577 --- /dev/null +++ b/SOURCES/Start-stalld-service-as-initrc_t.patch @@ -0,0 +1,27 @@ +From 476152742021303d2defeb69f524bcc302618081 Mon Sep 17 00:00:00 2001 +From: Leah Leshchinsky +Date: Mon, 29 Aug 2022 14:07:39 -0400 +Subject: [PATCH] Start stalld service as initrc_t + +Stalld currently runs as an unconfined_service_t. + +Edit to service file so that the daemon is launched as an initrc_t. + +Signed-off-by: Leah Leshchinsky + +diff --git a/redhat/stalld.service b/redhat/stalld.service +index e0eb4b77b0a7..bcd4b767f629 100644 +--- a/redhat/stalld.service ++++ b/redhat/stalld.service +@@ -9,7 +9,7 @@ ExecStartPre=/usr/bin/throttlectl off + + # In case the regex passed to IT or IP includes C escape sequences, + # use ${IT} or ${IP} instead of $IT or $IP +-ExecStart=/usr/bin/stalld --systemd $CLIST $AGGR $BP $BR $BD $THRESH $LOGGING $FG $PF $IT $IP ++ExecStart=/bin/sh -c "/usr/bin/stalld --systemd $CLIST $AGGR $BP $BR $BD $THRESH $LOGGING $FG $PF $IT $IP" + ExecStopPost=/usr/bin/throttlectl on + CPUSchedulingPolicy=fifo + CPUSchedulingPriority=10 +-- +2.31.1 + diff --git a/SPECS/stalld.spec b/SPECS/stalld.spec new file mode 100644 index 0000000..b7acb9d --- /dev/null +++ b/SPECS/stalld.spec @@ -0,0 +1,242 @@ +Name: stalld +Version: 1.17.1 +Release: 1%{?dist} +Summary: Daemon that finds starving tasks and gives them a temporary boost + +License: GPLv2 +URL: https://gitlab.com/rt-linux-tools/%{name}/%{name}.git +Source0: https://gitlab.com/rt-linux-tools/%{name}/-/archive/v%{version}/%{name}-%{version}.tar.bz2 + +BuildRequires: glibc-devel +BuildRequires: gcc +BuildRequires: make +BuildRequires: systemd-rpm-macros + +Requires: systemd + +Patch0: Start-stalld-service-as-initrc_t.patch + +%description +The stalld program monitors the set of system threads, +looking for threads that are ready-to-run but have not +been given processor time for some threshold period. +When a starving thread is found, it is given a temporary +boost using the SCHED_DEADLINE policy. The default is to +allow 10 microseconds of runtime for 1 second of clock time. + +%prep +%autosetup -p1 + +%build +%make_build CFLAGS="%{optflags} %{build_cflags} -DVERSION="\\\"%{version}\\\""" LDFLAGS="%{build_ldflags}" + +%install +%make_install DOCDIR=%{_docdir} MANDIR=%{_mandir} BINDIR=%{_bindir} DATADIR=%{_datadir} VERSION=%{version} +%make_install -C redhat UNITDIR=%{_unitdir} + +%files +%{_bindir}/%{name} +%{_bindir}/throttlectl +%{_unitdir}/%{name}.service +%config(noreplace) %{_sysconfdir}/sysconfig/stalld +%doc %{_docdir}/README.md +%doc %{_mandir}/man8/stalld.8* +%license gpl-2.0.txt + +%post +%systemd_post %{name}.service + +%preun +%systemd_preun %{name}.service + +%postun +%systemd_postun_with_restart %{name}.service + +%changelog +* Tue Oct 18 2022 Leah Leshchinsky - 1.17.1-1 +- stalld: Fix memory leak in print_boosted_info() +- utils: Check if the system is in lockdown mode +- stalld: print process comm and cpu when boosting +Resolves: rhbz#2120800 + +* Thu Sep 08 2022 Leah Leshchinsky - 1.17-2 +- Start stalld service as initrc_t +Resolves:rhbz#2112366 + +* Thu Jul 14 2022 John Kacur - 1.17-1 +- rebase to upstream v1.17 +Resolves:rhbz#2107273 + +* Thu Mar 31 2022 Fernando Pacheco - 1.16-1 +- stald/utils: Space, lines and voids clenaups +- stalld: Add an option to easily set stalld as SCHED_DEADLINE +- stalld: Comments cleanup +- src/utils: Comments cleanup +- src/throttling: Comments cleanup +- src/stalld.h Comments cleanup + Resolves: rhbz#2068549 + +* Mon Nov 15 2021 Fernando Pacheco - 1.15-1 +- stalld: Fix incorrect open() return value checks +- stalld: Pass errno to strerror() on sig*set() failures +- throttling: Always null terminate sched_rt_runtime_us output +- stalld: Remove unreachable statement in detect_task_format() +- tests: Fix uninitialized value action.sa_mask +- utils: Bail if malloc() returns null in parse_cpu_list() +- stalld: Use correct format specifier for long types + Resolves: rhbz#1990057, rhbz#1996799, rhbz#1996825 + +* Mon Jul 19 2021 Fernando Pacheco - 1.14.1-1 +- stalld: Coding style cleanup +- stalld: spaces in place of +- throttling: Use RT_RUNTIME_PATH in rt_throttling_is_off() +- throttling: Check open() on turn_off_rt_throttling +- throttling: Adjust variables in restore_rt_throttling() +- stalld.c: utils.c: Remove complex assignments from variable declarations +- stalld.h: Define MAX_PATH/DIR_PATH/FILE_NAME and use them +- stalld: Adjust variables in parse_old_task_format() +- utils.c: Use MAX_PATH for pidfile +- stalld.c: Remove variable declaration from the middle of the function +- stalld: Respect -l option in single threaded mode (1983100) +- utils: s/try_to_open_file/check_file_exists/ +- utils: use check_file_exists in setup_hr_tick() +- utils: Check for the new sched_features path + +* Fri Jul 02 2021 Fernando Pacheco - 1.13-1 +- stalld: Fix log message on boost_cpu_starving_vector() +- stalld: Add the overload control to the single-threaded mode +- stalld: Add the adaptive mode option +- stalld: Use the last mode set in the cmdline +- stalld: Fallback to the adaptive mode if force_fifo is selected +- stalld: Make single-threaded mode the default one (1920041) +- stalld.service: Always restart stalld on exit +- utils.c: Fail if user is not root +- utils.c: Make the path to sched_debug path dynamic (1977663) + +* Tue Jun 29 2021 Fernando Pacheco - 1.12-1 +- stalld.8: fix diff cruft left in manpage source +- stalld.c: clean up handling of nr_running +- stalld.c: remove duplicate parameter to fill_waiting_task() (1934582) +- stalld.service: Run stalld as sched_fifo via systemd +- stalld: Add error handling in get_cpu_idle_time() (1966259) +- packaging: clean up Makefiles and rpm specfile (1972806) +- stalld: Always print current function for info messages +- stalld: Always print current function for warn messages +- stalld: Always print current function for die messages +- utils: change PATHMAX to 4096 (1934581) + +* Thu May 13 2021 Clark Williams - 1.11-1 +- redhat/stalld.spec: pick up gating test version for changelog +- utils.c: set daemon umask to restrict global write/execute (1934586) +- hardening fixes from coverity scan (1934590) + +* Tue Apr 27 2021 Clark Williams - 1.10-1 +- utils: Fix bounds check on cpu and end_cpu variables +- stalld: Support denylisting of tasks in stalld +- src/utils: use right argument for warning printf + +* Wed Feb 17 2021 Clark Williams - 1.9-2 +- update to pick up latest gating test + +* Wed Feb 17 2021 Clark Williams - 1.9-1 +- Set starvation threshold default to 30 seconds +- rework read buffer allocation to properly find page size +- Add the -g/--granularity option +- Change the default granularity to five seconds +- Implement idle detection +- Implement the single-threaded mode +- Add HRTICK_DL support + +* Fri Feb 5 2021 Clark Williams - 1.8-1 +- Fix Readiness Protocol Mismatch with systemd +- test01: update to use buildin atomic operations +- test01: add throttling check + +* Tue Feb 2 2021 Clark Williams - 1.7-1 +- rework detect_task_format and buffer_size logic +- make CFLAGS for local compile match rpmbuild CFLAGS + +* Tue Jan 26 2021 Clark Williams - 1.6-1 +- add systemd handling of RT Throttling + +* Wed Jan 20 2021 Clark Williams - 1.5-1 +- fix signal handler to catch SIGTERM + +* Fri Dec 11 2020 Clark Williams - 1.4-1 +- stalld: Set rt_runtime to -1 before trying the SCHED_DEADLINE +- Fix incorrect recursion of specfile version field + +* Fri Nov 20 2020 Clark Williams - 1.3-1 +- Readme: Add information about repositories +- Add version management and version option +- create doc and scripts directory and add info on releases + +* Mon Nov 2 2020 Clark Williams - 1.2-1 +- utils.c: added info() functions +- detect and correctly parse old-style /proc/sched_debug +- src/stalld: Fix an retval check while reading sched_debug +- src/throttling: Fix a compilation warning +- ensure we only count task lines in old-format sched_debug info +- Add comments, clean up trailing whitespace +- src/utils: Fix runtime parameters check +- stalld: Do not take actions if log_only is set +- remove warning from parse_old_task_format + +* Tue Oct 27 2020 Clark Williams - 1.1-1 +- Fix an option in README.md; consistency in user facing docs. +- Makefile: add 'static' target to link stalld statically +- gitignore: ignore object files and the stalld executable +- use FIFO for boosting (v3) +- stalld.c: fix sched_debug parsing and modify waiting task parsing +- redhat: update release for features and bugfix +- stalld: Do not die if sched_debug returns an invalid value +- src/stalld: Do not die if the comm is too large +- src/stalld: Do not die if cannot write a message to the log +- src/stalld: Do not die if the main runs while a thread is monitoring the CPU +- implement RT throttling management and refactor source files +- more refactoring +- src/stalld: Reuse already read nr_running nr_rt_running +- src/stalld: Gracefully handle CPUs not found on sched_debug +- src/stalld: Use dynamically allocated memory to read sched_debug +- src/utils: Die with a divizion by zero if verbose +- src/stalld: Add config_buffer_size variable +- src/stalld: Increase the sched_debug read buffer if it gets too small +- src/stalld: Fix an retval check while reading sched_debug +- src/throttling: Fix a compilation warning + +* Sun Oct 4 2020 Clark Williams - 1.0-4 +- Fix an option in README.md; consistency in user facing docs. +- gitignore: ignore object files and the stalld executable +- Makefile: add 'static' target to link stalld statically +- use FIFO for boosting (v3) +- stalld: update usage message to include --force_fifo/-F option +- stalld.c: fix sched_debug parsing and modify waiting task parsing + +* Tue Sep 1 2020 Clark Williams - 1.0-3 +- Place BuildRequires on individual lines +- Fix changelog notations +- Modify build command to pass in CFLAGS and LDFLAGS +- fix compiler warnings in stalld.c + +* Mon Aug 31 2020 Clark Williams - 1.0-2 +- use _docdir macro for README.md +- use _mandir macro for stalld.8 manpage +- use tabs for spacing +- added push Makefile target to copy latest to upstream URL + +* Tue Aug 25 2020 Clark Williams - 1.0-1 +- rename project to stalld +- set version to 1.0 +- clean up rpmlint complaints + +* Fri Aug 21 2020 Clark Williams - 0.2-1 +- add pidfile logic + +* Thu Aug 20 2020 Clark Williams - 0.1-1 +- Added systemd service to redhat subdirectory +- added make and rpm logic for systemd files + +* Wed Aug 19 2020 Clark Williams - 0.0-1 +- initial version of specfile +- Makefile mods for RPM builds +- added systemd service and config files