You can not select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
35 lines
1.2 KiB
35 lines
1.2 KiB
4 years ago
|
From d9cc2d4659950df230dfe30e5445b91d4c15604e Mon Sep 17 00:00:00 2001
|
||
|
|
From: Frediano Ziglio <freddy77@gmail.com>
|
||
|
|
Date: Wed, 29 Apr 2020 15:09:13 +0100
|
||
|
|
Subject: [PATCH spice-common 1/4] quic: Check we have some data to start
|
||
|
|
decoding quic image
|
||
|
|
|
||
|
|
All paths already pass some data to quic_decode_begin but for the
|
||
|
|
test check it, it's not that expensive test.
|
||
|
|
Checking for not 0 is enough, all other words will potentially be
|
||
|
|
read calling more_io_words but we need one to avoid a potential
|
||
|
|
initial buffer overflow or deferencing an invalid pointer.
|
||
|
|
|
||
|
|
Signed-off-by: Frediano Ziglio <freddy77@gmail.com>
|
||
|
|
Acked-by: Uri Lublin <uril@redhat.com>
|
||
|
|
---
|
||
|
|
common/quic.c | 2 +-
|
||
|
|
1 file changed, 1 insertion(+), 1 deletion(-)
|
||
|
|
|
||
|
|
diff --git a/subprojects/spice-common/common/quic.c b/subprojects/spice-common/common/quic.c
|
||
|
|
index 55a5d6c..e03f3af 100644
|
||
|
|
--- a/subprojects/spice-common/common/quic.c
|
||
|
|
+++ b/subprojects/spice-common/common/quic.c
|
||
|
|
@@ -1136,7 +1136,7 @@ int quic_decode_begin(QuicContext *quic, uint32_t *io_ptr, unsigned int num_io_w
|
||
|
|
int channels;
|
||
|
|
int bpc;
|
||
|
|
|
||
|
|
- if (!encoder_reset(encoder, io_ptr, io_ptr_end)) {
|
||
|
|
+ if (!num_io_words || !encoder_reset(encoder, io_ptr, io_ptr_end)) {
|
||
|
|
return QUIC_ERROR;
|
||
|
|
}
|
||
|
|
|
||
|
|
--
|
||
|
|
2.25.4
|
||
|
|
|