|
|
|
@ -1,164 +0,0 @@
|
|
|
|
|
From f87021fee1023457bf693dae95ccfe765c3bff61 Mon Sep 17 00:00:00 2001
|
|
|
|
|
From: Tim Diggins <tim@red56.uk>
|
|
|
|
|
Date: Fri, 4 Mar 2022 12:16:58 +0000
|
|
|
|
|
Subject: [PATCH] fix expectations for ruby 3 treatment of hash arg
|
|
|
|
|
|
|
|
|
|
---
|
|
|
|
|
spec/line_editor_spec.rb | 4 ++--
|
|
|
|
|
spec/shell/basic_spec.rb | 34 +++++++++++++++++-----------------
|
|
|
|
|
2 files changed, 19 insertions(+), 19 deletions(-)
|
|
|
|
|
|
|
|
|
|
diff --git a/spec/line_editor_spec.rb b/spec/line_editor_spec.rb
|
|
|
|
|
index 575fd336..f034ec8d 100644
|
|
|
|
|
--- a/spec/line_editor_spec.rb
|
|
|
|
|
+++ b/spec/line_editor_spec.rb
|
|
|
|
|
@@ -13,7 +13,7 @@
|
|
|
|
|
describe ".readline" do
|
|
|
|
|
it "uses the Readline line editor" do
|
|
|
|
|
editor = double("Readline")
|
|
|
|
|
- expect(Thor::LineEditor::Readline).to receive(:new).with("Enter your name ", :default => "Brian").and_return(editor)
|
|
|
|
|
+ expect(Thor::LineEditor::Readline).to receive(:new).with("Enter your name ", {:default => "Brian"}).and_return(editor)
|
|
|
|
|
expect(editor).to receive(:readline).and_return("George")
|
|
|
|
|
expect(Thor::LineEditor.readline("Enter your name ", :default => "Brian")).to eq("George")
|
|
|
|
|
end
|
|
|
|
|
@@ -35,7 +35,7 @@
|
|
|
|
|
describe ".readline" do
|
|
|
|
|
it "uses the Basic line editor" do
|
|
|
|
|
editor = double("Basic")
|
|
|
|
|
- expect(Thor::LineEditor::Basic).to receive(:new).with("Enter your name ", :default => "Brian").and_return(editor)
|
|
|
|
|
+ expect(Thor::LineEditor::Basic).to receive(:new).with("Enter your name ", {:default => "Brian"}).and_return(editor)
|
|
|
|
|
expect(editor).to receive(:readline).and_return("George")
|
|
|
|
|
expect(Thor::LineEditor.readline("Enter your name ", :default => "Brian")).to eq("George")
|
|
|
|
|
end
|
|
|
|
|
diff --git a/spec/shell/basic_spec.rb b/spec/shell/basic_spec.rb
|
|
|
|
|
index b51c5e8a..b795a80a 100644
|
|
|
|
|
--- a/spec/shell/basic_spec.rb
|
|
|
|
|
+++ b/spec/shell/basic_spec.rb
|
|
|
|
|
@@ -70,80 +70,80 @@ def shell
|
|
|
|
|
|
|
|
|
|
it "prints a message to the user with the available options, expects case-sensitive matching, and determines the correctness of the answer" do
|
|
|
|
|
flavors = %w(strawberry chocolate vanilla)
|
|
|
|
|
- expect(Thor::LineEditor).to receive(:readline).with('What\'s your favorite Neopolitan flavor? [strawberry, chocolate, vanilla] ', :limited_to => flavors).and_return("chocolate")
|
|
|
|
|
+ expect(Thor::LineEditor).to receive(:readline).with('What\'s your favorite Neopolitan flavor? [strawberry, chocolate, vanilla] ', {:limited_to => flavors}).and_return("chocolate")
|
|
|
|
|
expect(shell.ask('What\'s your favorite Neopolitan flavor?', :limited_to => flavors)).to eq("chocolate")
|
|
|
|
|
end
|
|
|
|
|
|
|
|
|
|
it "prints a message to the user with the available options, expects case-sensitive matching, and reasks the question after an incorrect response" do
|
|
|
|
|
flavors = %w(strawberry chocolate vanilla)
|
|
|
|
|
expect($stdout).to receive(:print).with("Your response must be one of: [strawberry, chocolate, vanilla]. Please try again.\n")
|
|
|
|
|
- expect(Thor::LineEditor).to receive(:readline).with('What\'s your favorite Neopolitan flavor? [strawberry, chocolate, vanilla] ', :limited_to => flavors).and_return("moose tracks", "chocolate")
|
|
|
|
|
+ expect(Thor::LineEditor).to receive(:readline).with('What\'s your favorite Neopolitan flavor? [strawberry, chocolate, vanilla] ', {:limited_to => flavors}).and_return("moose tracks", "chocolate")
|
|
|
|
|
expect(shell.ask('What\'s your favorite Neopolitan flavor?', :limited_to => flavors)).to eq("chocolate")
|
|
|
|
|
end
|
|
|
|
|
|
|
|
|
|
it "prints a message to the user with the available options, expects case-sensitive matching, and reasks the question after a case-insensitive match" do
|
|
|
|
|
flavors = %w(strawberry chocolate vanilla)
|
|
|
|
|
expect($stdout).to receive(:print).with("Your response must be one of: [strawberry, chocolate, vanilla]. Please try again.\n")
|
|
|
|
|
- expect(Thor::LineEditor).to receive(:readline).with('What\'s your favorite Neopolitan flavor? [strawberry, chocolate, vanilla] ', :limited_to => flavors).and_return("cHoCoLaTe", "chocolate")
|
|
|
|
|
+ expect(Thor::LineEditor).to receive(:readline).with('What\'s your favorite Neopolitan flavor? [strawberry, chocolate, vanilla] ', {:limited_to => flavors}).and_return("cHoCoLaTe", "chocolate")
|
|
|
|
|
expect(shell.ask('What\'s your favorite Neopolitan flavor?', :limited_to => flavors)).to eq("chocolate")
|
|
|
|
|
end
|
|
|
|
|
|
|
|
|
|
it "prints a message to the user with the available options, expects case-insensitive matching, and determines the correctness of the answer" do
|
|
|
|
|
flavors = %w(strawberry chocolate vanilla)
|
|
|
|
|
- expect(Thor::LineEditor).to receive(:readline).with('What\'s your favorite Neopolitan flavor? [strawberry, chocolate, vanilla] ', :limited_to => flavors, :case_insensitive => true).and_return("CHOCOLATE")
|
|
|
|
|
+ expect(Thor::LineEditor).to receive(:readline).with('What\'s your favorite Neopolitan flavor? [strawberry, chocolate, vanilla] ', {:limited_to => flavors, :case_insensitive => true}).and_return("CHOCOLATE")
|
|
|
|
|
expect(shell.ask('What\'s your favorite Neopolitan flavor?', :limited_to => flavors, :case_insensitive => true)).to eq("chocolate")
|
|
|
|
|
end
|
|
|
|
|
|
|
|
|
|
it "prints a message to the user with the available options, expects case-insensitive matching, and reasks the question after an incorrect response" do
|
|
|
|
|
flavors = %w(strawberry chocolate vanilla)
|
|
|
|
|
expect($stdout).to receive(:print).with("Your response must be one of: [strawberry, chocolate, vanilla]. Please try again.\n")
|
|
|
|
|
- expect(Thor::LineEditor).to receive(:readline).with('What\'s your favorite Neopolitan flavor? [strawberry, chocolate, vanilla] ', :limited_to => flavors, :case_insensitive => true).and_return("moose tracks", "chocolate")
|
|
|
|
|
+ expect(Thor::LineEditor).to receive(:readline).with('What\'s your favorite Neopolitan flavor? [strawberry, chocolate, vanilla] ', {:limited_to => flavors, :case_insensitive => true}).and_return("moose tracks", "chocolate")
|
|
|
|
|
expect(shell.ask('What\'s your favorite Neopolitan flavor?', :limited_to => flavors, :case_insensitive => true)).to eq("chocolate")
|
|
|
|
|
end
|
|
|
|
|
|
|
|
|
|
it "prints a message to the user containing a default and sets the default if only enter is pressed" do
|
|
|
|
|
- expect(Thor::LineEditor).to receive(:readline).with('What\'s your favorite Neopolitan flavor? (vanilla) ', :default => "vanilla").and_return("")
|
|
|
|
|
+ expect(Thor::LineEditor).to receive(:readline).with('What\'s your favorite Neopolitan flavor? (vanilla) ', {:default => "vanilla"}).and_return("")
|
|
|
|
|
expect(shell.ask('What\'s your favorite Neopolitan flavor?', :default => "vanilla")).to eq("vanilla")
|
|
|
|
|
end
|
|
|
|
|
|
|
|
|
|
it "prints a message to the user with the available options and reasks the question after an incorrect response and then returns the default" do
|
|
|
|
|
flavors = %w(strawberry chocolate vanilla)
|
|
|
|
|
expect($stdout).to receive(:print).with("Your response must be one of: [strawberry, chocolate, vanilla]. Please try again.\n")
|
|
|
|
|
- expect(Thor::LineEditor).to receive(:readline).with('What\'s your favorite Neopolitan flavor? [strawberry, chocolate, vanilla] (vanilla) ', :default => "vanilla", :limited_to => flavors).and_return("moose tracks", "")
|
|
|
|
|
+ expect(Thor::LineEditor).to receive(:readline).with('What\'s your favorite Neopolitan flavor? [strawberry, chocolate, vanilla] (vanilla) ', {:default => "vanilla", :limited_to => flavors}).and_return("moose tracks", "")
|
|
|
|
|
expect(shell.ask("What's your favorite Neopolitan flavor?", :default => "vanilla", :limited_to => flavors)).to eq("vanilla")
|
|
|
|
|
end
|
|
|
|
|
end
|
|
|
|
|
|
|
|
|
|
describe "#yes?" do
|
|
|
|
|
it "asks the user and returns true if the user replies yes" do
|
|
|
|
|
- expect(Thor::LineEditor).to receive(:readline).with("Should I overwrite it? ", :add_to_history => false).and_return("y")
|
|
|
|
|
+ expect(Thor::LineEditor).to receive(:readline).with("Should I overwrite it? ", {:add_to_history => false}).and_return("y")
|
|
|
|
|
expect(shell.yes?("Should I overwrite it?")).to be true
|
|
|
|
|
end
|
|
|
|
|
|
|
|
|
|
it "asks the user and returns false if the user replies no" do
|
|
|
|
|
- expect(Thor::LineEditor).to receive(:readline).with("Should I overwrite it? ", :add_to_history => false).and_return("n")
|
|
|
|
|
+ expect(Thor::LineEditor).to receive(:readline).with("Should I overwrite it? ", {:add_to_history => false}).and_return("n")
|
|
|
|
|
expect(shell.yes?("Should I overwrite it?")).not_to be true
|
|
|
|
|
end
|
|
|
|
|
|
|
|
|
|
it "asks the user and returns false if the user replies with an answer other than yes or no" do
|
|
|
|
|
- expect(Thor::LineEditor).to receive(:readline).with("Should I overwrite it? ", :add_to_history => false).and_return("foobar")
|
|
|
|
|
+ expect(Thor::LineEditor).to receive(:readline).with("Should I overwrite it? ", {:add_to_history => false}).and_return("foobar")
|
|
|
|
|
expect(shell.yes?("Should I overwrite it?")).to be false
|
|
|
|
|
end
|
|
|
|
|
end
|
|
|
|
|
|
|
|
|
|
describe "#no?" do
|
|
|
|
|
it "asks the user and returns true if the user replies no" do
|
|
|
|
|
- expect(Thor::LineEditor).to receive(:readline).with("Should I overwrite it? ", :add_to_history => false).and_return("n")
|
|
|
|
|
+ expect(Thor::LineEditor).to receive(:readline).with("Should I overwrite it? ", {:add_to_history => false}).and_return("n")
|
|
|
|
|
expect(shell.no?("Should I overwrite it?")).to be true
|
|
|
|
|
end
|
|
|
|
|
|
|
|
|
|
it "asks the user and returns false if the user replies yes" do
|
|
|
|
|
- expect(Thor::LineEditor).to receive(:readline).with("Should I overwrite it? ", :add_to_history => false).and_return("Yes")
|
|
|
|
|
+ expect(Thor::LineEditor).to receive(:readline).with("Should I overwrite it? ", {:add_to_history => false}).and_return("Yes")
|
|
|
|
|
expect(shell.no?("Should I overwrite it?")).to be false
|
|
|
|
|
end
|
|
|
|
|
|
|
|
|
|
it "asks the user and returns false if the user replies with an answer other than yes or no" do
|
|
|
|
|
- expect(Thor::LineEditor).to receive(:readline).with("Should I overwrite it? ", :add_to_history => false).and_return("foobar")
|
|
|
|
|
+ expect(Thor::LineEditor).to receive(:readline).with("Should I overwrite it? ", {:add_to_history => false}).and_return("foobar")
|
|
|
|
|
expect(shell.no?("Should I overwrite it?")).to be false
|
|
|
|
|
end
|
|
|
|
|
end
|
|
|
|
|
@@ -431,13 +431,13 @@ def #456 Lanç...
|
|
|
|
|
expect(content).to eq(<<-TABLE)
|
|
|
|
|
Name Number Color
|
|
|
|
|
Erik 1234567890123 green
|
|
|
|
|
-TABLE
|
|
|
|
|
+ TABLE
|
|
|
|
|
end
|
|
|
|
|
end
|
|
|
|
|
|
|
|
|
|
describe "#file_collision" do
|
|
|
|
|
it "shows a menu with options" do
|
|
|
|
|
- expect(Thor::LineEditor).to receive(:readline).with('Overwrite foo? (enter "h" for help) [Ynaqh] ', :add_to_history => false).and_return("n")
|
|
|
|
|
+ expect(Thor::LineEditor).to receive(:readline).with('Overwrite foo? (enter "h" for help) [Ynaqh] ', {:add_to_history => false}).and_return("n")
|
|
|
|
|
shell.file_collision("foo")
|
|
|
|
|
end
|
|
|
|
|
|
|
|
|
|
@@ -478,7 +478,7 @@ def #456 Lanç...
|
|
|
|
|
end
|
|
|
|
|
|
|
|
|
|
it "always returns true if the user chooses always" do
|
|
|
|
|
- expect(Thor::LineEditor).to receive(:readline).with('Overwrite foo? (enter "h" for help) [Ynaqh] ', :add_to_history => false).and_return("a")
|
|
|
|
|
+ expect(Thor::LineEditor).to receive(:readline).with('Overwrite foo? (enter "h" for help) [Ynaqh] ', {:add_to_history => false}).and_return("a")
|
|
|
|
|
|
|
|
|
|
expect(shell.file_collision("foo")).to be true
|
|
|
|
|
|
|
|
|
|
@@ -488,7 +488,7 @@ def #456 Lanç...
|
|
|
|
|
|
|
|
|
|
describe "when a block is given" do
|
|
|
|
|
it "displays diff and merge options to the user" do
|
|
|
|
|
- expect(Thor::LineEditor).to receive(:readline).with('Overwrite foo? (enter "h" for help) [Ynaqdhm] ', :add_to_history => false).and_return("s")
|
|
|
|
|
+ expect(Thor::LineEditor).to receive(:readline).with('Overwrite foo? (enter "h" for help) [Ynaqdhm] ', {:add_to_history => false}).and_return("s")
|
|
|
|
|
shell.file_collision("foo") {}
|
|
|
|
|
end
|
|
|
|
|
|