You can not select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
35 lines
2.1 KiB
35 lines
2.1 KiB
5 years ago
|
From 750aa3b0de06dad41539bdb402123b5416a3475d Mon Sep 17 00:00:00 2001
|
||
|
|
From: Jordan Owens <jkowens@gmail.com>
|
||
|
|
Date: Tue, 10 Mar 2020 10:24:05 -0400
|
||
|
|
Subject: [PATCH] Fix failing tests
|
||
|
|
|
||
|
|
Rack added support for Multi-part ranges and apparently changed the
|
||
|
|
format of cookie expires timestamp format to match specs.
|
||
|
|
---
|
||
|
|
.../spec/lib/rack/protection/cookie_tossing_spec.rb | 12 ++++++------
|
||
|
|
1 file changed, 6 insertions(+), 6 deletions(-)
|
||
|
|
|
||
|
|
diff --git a/rack-protection/spec/lib/rack/protection/cookie_tossing_spec.rb b/rack-protection/spec/lib/rack/protection/cookie_tossing_spec.rb
|
||
|
|
index af46ffc2b..f973bd476 100644
|
||
|
|
--- a/rack-protection/spec/lib/rack/protection/cookie_tossing_spec.rb
|
||
|
|
+++ b/rack-protection/spec/lib/rack/protection/cookie_tossing_spec.rb
|
||
|
|
@@ -28,12 +28,12 @@
|
||
|
|
get '/some/path', {}, 'HTTP_COOKIE' => 'rack.%73ession=EVIL_SESSION_TOKEN; rack.session=EVIL_SESSION_TOKEN; rack.session=SESSION_TOKEN'
|
||
|
|
|
||
|
|
expected_header = <<-END.chomp
|
||
|
|
-rack.%2573ession=; domain=example.org; path=/; expires=Thu, 01 Jan 1970 00:00:00 -0000
|
||
|
|
-rack.%2573ession=; domain=example.org; path=/some; expires=Thu, 01 Jan 1970 00:00:00 -0000
|
||
|
|
-rack.%2573ession=; domain=example.org; path=/some/path; expires=Thu, 01 Jan 1970 00:00:00 -0000
|
||
|
|
-rack.session=; domain=example.org; path=/; expires=Thu, 01 Jan 1970 00:00:00 -0000
|
||
|
|
-rack.session=; domain=example.org; path=/some; expires=Thu, 01 Jan 1970 00:00:00 -0000
|
||
|
|
-rack.session=; domain=example.org; path=/some/path; expires=Thu, 01 Jan 1970 00:00:00 -0000
|
||
|
|
+rack.%2573ession=; domain=example.org; path=/; expires=Thu, 01 Jan 1970 00:00:00 GMT
|
||
|
|
+rack.%2573ession=; domain=example.org; path=/some; expires=Thu, 01 Jan 1970 00:00:00 GMT
|
||
|
|
+rack.%2573ession=; domain=example.org; path=/some/path; expires=Thu, 01 Jan 1970 00:00:00 GMT
|
||
|
|
+rack.session=; domain=example.org; path=/; expires=Thu, 01 Jan 1970 00:00:00 GMT
|
||
|
|
+rack.session=; domain=example.org; path=/some; expires=Thu, 01 Jan 1970 00:00:00 GMT
|
||
|
|
+rack.session=; domain=example.org; path=/some/path; expires=Thu, 01 Jan 1970 00:00:00 GMT
|
||
|
|
END
|
||
|
|
expect(last_response.headers['Set-Cookie']).to eq(expected_header)
|
||
|
|
end
|