Compare commits

...

No commits in common. 'c9' and 'i8c-stream-2.5' have entirely different histories.

3
.gitignore vendored

@ -1,2 +1 @@
SOURCES/mysql2-0.5.3-tests.txz
SOURCES/mysql2-0.5.3.gem
SOURCES/mysql2-0.4.10.gem

@ -1,2 +1 @@
efae18a40b17065bff7f04732e8165d64393531c SOURCES/mysql2-0.5.3-tests.txz
75e6935c4d9a2b1c047d9e9b69c4c6d4c7e0faef SOURCES/mysql2-0.5.3.gem
b4d1606147276f61105759b45a0f4f06d8ac6750 SOURCES/mysql2-0.4.10.gem

@ -0,0 +1,15 @@
diff --git a/spec/mysql2/statement_spec.rb b/spec/mysql2/statement_spec.rb
index 50b2e99..3db7886 100644
--- a/spec/mysql2/statement_spec.rb
+++ b/spec/mysql2/statement_spec.rb
@@ -731,7 +731,6 @@ RSpec.describe Mysql2::Statement do
it 'should return number of rows affected by an insert' do
stmt = @client.prepare 'INSERT INTO lastIdTest (blah) VALUES (?)'
- expect(stmt.affected_rows).to eq 0
stmt.execute 1
expect(stmt.affected_rows).to eq 1
end
--
2.14.3

@ -0,0 +1,162 @@
From 235eaa482ce2cfa0dfbe1e4e7123d1a1f6bbf136 Mon Sep 17 00:00:00 2001
From: Jun Aruga <junaruga@users.noreply.github.com>
Date: Sat, 25 Nov 2017 20:10:10 +0100
Subject: [PATCH 1/2] Suppress Fixnum and Bignum warnings on Ruby 2.4. (#907)
---
spec/mysql2/client_spec.rb | 8 ++++----
spec/mysql2/result_spec.rb | 12 ++++++------
spec/mysql2/statement_spec.rb | 12 ++++++------
spec/spec_helper.rb | 4 ++++
4 files changed, 20 insertions(+), 16 deletions(-)
diff --git a/spec/mysql2/client_spec.rb b/spec/mysql2/client_spec.rb
index dfb92a2..9de040b 100644
--- a/spec/mysql2/client_spec.rb
+++ b/spec/mysql2/client_spec.rb
@@ -572,7 +572,7 @@ RSpec.describe Mysql2::Client do
end
it "#socket should return a Fixnum (file descriptor from C)" do
- expect(@client.socket).to be_an_instance_of(Fixnum)
+ expect(@client.socket).to be_an_instance_of(0.class)
expect(@client.socket).not_to eql(0)
end
@@ -852,7 +852,7 @@ RSpec.describe Mysql2::Client do
info = @client.info
expect(info).to be_an_instance_of(Hash)
expect(info).to have_key(:id)
- expect(info[:id]).to be_an_instance_of(Fixnum)
+ expect(info[:id]).to be_an_instance_of(0.class)
expect(info).to have_key(:version)
expect(info[:version]).to be_an_instance_of(String)
end
@@ -883,7 +883,7 @@ RSpec.describe Mysql2::Client do
server_info = @client.server_info
expect(server_info).to be_an_instance_of(Hash)
expect(server_info).to have_key(:id)
- expect(server_info[:id]).to be_an_instance_of(Fixnum)
+ expect(server_info[:id]).to be_an_instance_of(0.class)
expect(server_info).to have_key(:version)
expect(server_info[:version]).to be_an_instance_of(String)
end
@@ -974,7 +974,7 @@ RSpec.describe Mysql2::Client do
end
it "#thread_id should be a Fixnum" do
- expect(@client.thread_id).to be_an_instance_of(Fixnum)
+ expect(@client.thread_id).to be_an_instance_of(0.class)
end
it "should respond to #ping" do
diff --git a/spec/mysql2/result_spec.rb b/spec/mysql2/result_spec.rb
index c8e26c5..e8ee8d0 100644
--- a/spec/mysql2/result_spec.rb
+++ b/spec/mysql2/result_spec.rb
@@ -204,7 +204,7 @@ RSpec.describe Mysql2::Result do
end
it "should return Fixnum for a TINYINT value" do
- expect([Fixnum, Bignum]).to include(@test_result['tiny_int_test'].class)
+ expect(num_classes).to include(@test_result['tiny_int_test'].class)
expect(@test_result['tiny_int_test']).to eql(1)
end
@@ -248,27 +248,27 @@ RSpec.describe Mysql2::Result do
end
it "should return Fixnum for a SMALLINT value" do
- expect([Fixnum, Bignum]).to include(@test_result['small_int_test'].class)
+ expect(num_classes).to include(@test_result['small_int_test'].class)
expect(@test_result['small_int_test']).to eql(10)
end
it "should return Fixnum for a MEDIUMINT value" do
- expect([Fixnum, Bignum]).to include(@test_result['medium_int_test'].class)
+ expect(num_classes).to include(@test_result['medium_int_test'].class)
expect(@test_result['medium_int_test']).to eql(10)
end
it "should return Fixnum for an INT value" do
- expect([Fixnum, Bignum]).to include(@test_result['int_test'].class)
+ expect(num_classes).to include(@test_result['int_test'].class)
expect(@test_result['int_test']).to eql(10)
end
it "should return Fixnum for a BIGINT value" do
- expect([Fixnum, Bignum]).to include(@test_result['big_int_test'].class)
+ expect(num_classes).to include(@test_result['big_int_test'].class)
expect(@test_result['big_int_test']).to eql(10)
end
it "should return Fixnum for a YEAR value" do
- expect([Fixnum, Bignum]).to include(@test_result['year_test'].class)
+ expect(num_classes).to include(@test_result['year_test'].class)
expect(@test_result['year_test']).to eql(2009)
end
diff --git a/spec/mysql2/statement_spec.rb b/spec/mysql2/statement_spec.rb
index e0fccad..50b2e99 100644
--- a/spec/mysql2/statement_spec.rb
+++ b/spec/mysql2/statement_spec.rb
@@ -372,7 +372,7 @@ RSpec.describe Mysql2::Statement do
end
it "should return Fixnum for a TINYINT value" do
- expect([Fixnum, Bignum]).to include(@test_result['tiny_int_test'].class)
+ expect(num_classes).to include(@test_result['tiny_int_test'].class)
expect(@test_result['tiny_int_test']).to eql(1)
end
@@ -420,27 +420,27 @@ RSpec.describe Mysql2::Statement do
end
it "should return Fixnum for a SMALLINT value" do
- expect([Fixnum, Bignum]).to include(@test_result['small_int_test'].class)
+ expect(num_classes).to include(@test_result['small_int_test'].class)
expect(@test_result['small_int_test']).to eql(10)
end
it "should return Fixnum for a MEDIUMINT value" do
- expect([Fixnum, Bignum]).to include(@test_result['medium_int_test'].class)
+ expect(num_classes).to include(@test_result['medium_int_test'].class)
expect(@test_result['medium_int_test']).to eql(10)
end
it "should return Fixnum for an INT value" do
- expect([Fixnum, Bignum]).to include(@test_result['int_test'].class)
+ expect(num_classes).to include(@test_result['int_test'].class)
expect(@test_result['int_test']).to eql(10)
end
it "should return Fixnum for a BIGINT value" do
- expect([Fixnum, Bignum]).to include(@test_result['big_int_test'].class)
+ expect(num_classes).to include(@test_result['big_int_test'].class)
expect(@test_result['big_int_test']).to eql(10)
end
it "should return Fixnum for a YEAR value" do
- expect([Fixnum, Bignum]).to include(@test_result['year_test'].class)
+ expect(num_classes).to include(@test_result['year_test'].class)
expect(@test_result['year_test']).to eql(2009)
end
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb
index 53c098a..045e783 100644
--- a/spec/spec_helper.rb
+++ b/spec/spec_helper.rb
@@ -36,6 +36,10 @@ RSpec.configure do |config|
end
end
+ def num_classes
+ 0.class == Integer ? [Integer] : [Fixnum, Bignum]
+ end
+
config.before :each do
@client = new_client
end
--
2.14.3

@ -0,0 +1,37 @@
diff --git a/ext/mysql2/result.c b/ext/mysql2/result.c
index ccb49a5..67f75be 100644
--- a/ext/mysql2/result.c
+++ b/ext/mysql2/result.c
@@ -278,12 +278,12 @@ static void rb_mysql_result_alloc_result_buffers(VALUE self, MYSQL_FIELD *fields
wrapper->result_buffers[i].buffer_length = sizeof(signed char);
break;
case MYSQL_TYPE_SHORT: // short int
+ case MYSQL_TYPE_YEAR: // short int
wrapper->result_buffers[i].buffer = xcalloc(1, sizeof(short int));
wrapper->result_buffers[i].buffer_length = sizeof(short int);
break;
case MYSQL_TYPE_INT24: // int
case MYSQL_TYPE_LONG: // int
- case MYSQL_TYPE_YEAR: // int
wrapper->result_buffers[i].buffer = xcalloc(1, sizeof(int));
wrapper->result_buffers[i].buffer_length = sizeof(int);
break;
@@ -413,6 +413,7 @@ static VALUE rb_mysql_result_fetch_row_stmt(VALUE self, MYSQL_FIELD * fields, co
}
break;
case MYSQL_TYPE_SHORT: // short int
+ case MYSQL_TYPE_YEAR: // short int
if (result_buffer->is_unsigned) {
val = UINT2NUM(*((unsigned short int*)result_buffer->buffer));
} else {
@@ -421,7 +422,6 @@ static VALUE rb_mysql_result_fetch_row_stmt(VALUE self, MYSQL_FIELD * fields, co
break;
case MYSQL_TYPE_INT24: // int
case MYSQL_TYPE_LONG: // int
- case MYSQL_TYPE_YEAR: // int
if (result_buffer->is_unsigned) {
val = UINT2NUM(*((unsigned int*)result_buffer->buffer));
} else {
--
2.14.3

@ -0,0 +1,15 @@
diff --git a/ext/mysql2/client.c b/ext/mysql2/client.c
index 665147a2..482f1877 100644
--- a/ext/mysql2/client.c
+++ b/ext/mysql2/client.c
@@ -872,8 +872,8 @@ static VALUE _mysql_client_options(VALUE self, int opt, VALUE value) {
break;
case MYSQL_OPT_LOCAL_INFILE:
- intval = (value == Qfalse ? 0 : 1);
- retval = &intval;
+ boolval = (value == Qfalse ? 0 : 1);
+ retval = &boolval;
break;
case MYSQL_OPT_RECONNECT:

@ -1,22 +0,0 @@
From cca57b97ad6d1b1b985376be110b89d2b487dea6 Mon Sep 17 00:00:00 2001
From: Aaron Patterson <tenderlove@ruby-lang.org>
Date: Tue, 30 Nov 2021 12:59:43 -0800
Subject: [PATCH] fix assertion on maria
downgrade psych
---
spec/mysql2/client_spec.rb | 2 +-
diff --git a/spec/mysql2/client_spec.rb b/spec/mysql2/client_spec.rb
index 1519e0f5d..41fb834bf 100644
--- a/spec/mysql2/client_spec.rb
+++ b/spec/mysql2/client_spec.rb
@@ -573,7 +573,7 @@ def run_gc
end
expect do
@client.query("SELECT SLEEP(1)")
- end.to raise_error(Mysql2::Error, /Lost connection to MySQL server/)
+ end.to raise_error(Mysql2::Error, /Lost connection/)
if RUBY_PLATFORM !~ /mingw|mswin/
expect do

@ -5,25 +5,33 @@
%global gem_name mysql2
Name: rubygem-%{gem_name}
Version: 0.5.3
Release: 11%{?dist}
Version: 0.4.10
Release: 4%{?dist}
Summary: A simple, fast Mysql library for Ruby, binding to libmysql
License: MIT
URL: https://github.com/brianmario/mysql2
URL: http://github.com/brianmario/mysql2
Source0: https://rubygems.org/gems/%{gem_name}-%{version}.gem
# git clone --no-checkout https://github.com/brianmario/mysql2.git
# cd mysql2 && git archive -v -o mysql2-0.5.3-tests.txz 0.5.3 spec/
Source1: %{gem_name}-%{version}-tests.txz
# Fix test assertion for mariadb-connector-c
# https://github.com/brianmario/mysql2/commit/cca57b97ad6d1b1b985376be110b89d2b487dea6
Patch2: rubygem-mysql2-0.5.3-fix-assertion-mariadb-connector-c.patch
# Fix a client option local_infile not enabled
# with mariadb-connector-c 3.0.2 on big endian environment.
# Temporary patch until mariadb-connector-c version 3.0.3 released.
# https://github.com/brianmario/mysql2/pull/914
# https://github.com/MariaDB/mariadb-connector-c/commit/434b67e
Patch0: rubygem-mysql2-0.4.10-mariadb-connector-c-3.0.2-fix-wrong-local-infile-on-big-endian.patch
# Fix YEAR type wrong value on big endian environment.
# https://github.com/brianmario/mysql2/pull/921
Patch1: rubygem-mysql2-0.4.10-fix-wrong-type-year-value-on-big-endian.patch
# Suppress Fixnum and Bignum warnings on Ruby 2.4.
# https://github.com/brianmario/mysql2/commit/0e4fcc3
Patch2: rubygem-mysql2-0.4.10-Suppress-Fixnum-and-Bignum-warnings-on-Ruby2.4.patch
# Skip test to prepare statement and no query on MariaDB 10.2.
# https://github.com/brianmario/mysql2/commit/a2fadb6
Patch3: rubygem-mysql2-0.4.10-Skip-statement-and-no-query-test-on-MariaDB-10.2.patch
# Required in lib/mysql2.rb
Requires: rubygem(bigdecimal)
BuildRequires: ruby(release)
BuildRequires: rubygems-devel
BuildRequires: ruby-devel
BuildRequires: gcc
BuildRequires: mariadb-connector-c-devel
%if %{with tests}
BuildRequires: mariadb-server
@ -31,6 +39,10 @@ BuildRequires: rubygem(rspec)
# Used in mysql_install_db
BuildRequires: %{_bindir}/hostname
BuildRequires: rubygem(bigdecimal)
# Used in spec/em/em_spec.rb
# Comment out to prevent a build error by conflicting requests.
# Nothing provides libruby.so.2.4()(64bit) needed by rubygem-eventmachine.
#BuildRequires: rubygem(eventmachine)
%endif
%description
@ -49,15 +61,18 @@ BuildArch: noarch
Documentation for %{name}
%prep
%setup -q -n %{gem_name}-%{version} -b 1
gem unpack %{SOURCE0}
pushd %{_builddir}/spec
%patch2 -p2
popd
%setup -q -D -T -n %{gem_name}-%{version}
%patch0 -p1
%patch1 -p1
gem spec %{SOURCE0} -l --ruby > %{gem_name}.gemspec
%build
# Create the gem as gem install only works on a gem file
gem build ../%{gem_name}-%{version}.gemspec
gem build %{gem_name}.gemspec
# %%gem_install compiles any C extensions and installs the gem into ./%%gem_dir
# by default, so that we can move it into the buildroot in %%install
@ -79,8 +94,6 @@ rm -rf %{buildroot}%{gem_instdir}/ext
%if %{with tests}
%check
pushd .%{gem_instdir}
# Move the tests into place
ln -s %{_builddir}/spec spec
TOP_DIR=$(pwd)
# Use testing port because the standard mysqld port 3306 is occupied.
@ -115,7 +128,7 @@ for i in $(seq 10); do
done
# See https://github.com/brianmario/mysql2/blob/master/.travis_setup.sh
mysql -u $MYSQL_TEST_USER \
mysql -u root \
-e 'CREATE DATABASE /*M!50701 IF NOT EXISTS */ test' \
-S "${MYSQL_TEST_SOCKET}" \
-P "${MYSQL_TEST_PORT}"
@ -124,7 +137,7 @@ mysql -u $MYSQL_TEST_USER \
cat <<EOF > spec/configuration.yml
root:
host: localhost
username: ${MYSQL_TEST_USER}
username: root
password:
database: test
port: ${MYSQL_TEST_PORT}
@ -139,27 +152,18 @@ user:
socket: ${MYSQL_TEST_SOCKET}
EOF
cat "%{PATCH2}" | patch -p1
cat "%{PATCH3}" | patch -p1
# Comment out an issue (maybe test specified issue) for coredump or
# SystemStackError: stack level too deep.
sed -i '/^ it "returns error messages and sql state in Encoding.default_internal if set" do$/,/^ end$/ s/^/#/' \
spec/mysql2/error_spec.rb
# This test would require changes in host configuration.
sed -i '/^ it "should be able to connect via SSL options" do$/,/^ end$/ s/^/#/' \
spec/mysql2/client_spec.rb
# performance_schema.session_account_connect_attrs is unexpectedly empty.
# https://github.com/brianmario/mysql2/issues/965
sed -i '/^ it "should set default program_name in connect_attrs" do$/,/^ end$/ s/^/#/' \
spec/mysql2/client_spec.rb
sed -i '/^ it "should set custom connect_attrs" do$/,/^ end$/ s/^/#/' \
spec/mysql2/client_spec.rb
# This test was passing when going through `rescue` branch up to MariaDB 10.4.
# It fails since MariaDB 10.5.2 instroduced Performance Schema.
# https://github.com/brianmario/mysql2/issues/1152
sed -i '/stmt_count/a\\ pending "Does not work with MariaDB"' \
spec/mysql2/statement_spec.rb
# Since MariaDB 10.5. the return error message contains mangled input.
# https://github.com/brianmario/mysql2/issues/1152
sed -i '/expect(bad_err.message).to include/ s/^/#/' spec/mysql2/error_spec.rb
rspec -Ilib:%{buildroot}%{gem_extdir_mri} -f d spec
popd
@ -181,63 +185,13 @@ kill "$(cat "${MYSQL_TEST_PID_FILE}")"
%doc %{gem_docdir}
%doc %{gem_instdir}/README.md
%doc %{gem_instdir}/CHANGELOG.md
%{gem_instdir}/examples
%{gem_instdir}/spec
%changelog
* Thu Feb 17 2022 Pavel Valena <pvalena@redhat.com> - 0.5.3-11
- Fix test assertion for mariadb-connector-c
* Tue Aug 10 2021 Mohan Boddu <mboddu@redhat.com> - 0.5.3-10
- Rebuilt for IMA sigs, glibc 2.34, aarch64 flags
Related: rhbz#1991688
* Fri Jul 16 2021 Pavel Valena <pvalena@redhat.com> - 0.5.3-9
- Fix FTBFS: remove rubygem-eventmachine dependnecy
Resolves: rhbz#1982404
* Fri Apr 16 2021 Mohan Boddu <mboddu@redhat.com> - 0.5.3-8
- Rebuilt for RHEL 9 BETA on Apr 15th 2021. Related: rhbz#1947937
* Thu Feb 11 2021 Vít Ondruch <vondruch@redhat.com> - 0.5.3-7
- Fix FTBFS due to MariaDB 10.5+ incompatibilies.
Resolves: rhbz#1914515
Resolves: rhbz#1923277
* Wed Jan 27 2021 Fedora Release Engineering <releng@fedoraproject.org> - 0.5.3-7
- Rebuilt for https://fedoraproject.org/wiki/Fedora_34_Mass_Rebuild
* Thu Jan 7 03:21:32 CET 2021 Pavel Valena <pvalena@redhat.com> - 0.5.3-6
- Rebuilt for https://fedoraproject.org/wiki/Changes/Ruby_3.0
* Wed Jul 29 2020 Fedora Release Engineering <releng@fedoraproject.org> - 0.5.3-5
- Rebuilt for https://fedoraproject.org/wiki/Fedora_33_Mass_Rebuild
* Thu Jul 2 2020 Alex Chernyakhovsky <achernya@mit.edu> - 0.5.3-4
- Update tests to build and run on F32
* Thu Jan 30 2020 Fedora Release Engineering <releng@fedoraproject.org> - 0.5.3-3
- Rebuilt for https://fedoraproject.org/wiki/Fedora_32_Mass_Rebuild
* Fri Jan 17 2020 Vít Ondruch <vondruch@redhat.com> - 0.5.3-2
- Rebuilt for https://fedoraproject.org/wiki/Changes/Ruby_2.7
* Mon Dec 02 2019 Jun Aruga <jaruga@redhat.com> - 0.5.3-1
- New upstream release 0.5.3
* Fri Jul 26 2019 Fedora Release Engineering <releng@fedoraproject.org> - 0.5.2-4
- Rebuilt for https://fedoraproject.org/wiki/Fedora_31_Mass_Rebuild
* Sat Feb 02 2019 Fedora Release Engineering <releng@fedoraproject.org> - 0.5.2-3
- Rebuilt for https://fedoraproject.org/wiki/Fedora_30_Mass_Rebuild
* Mon Jan 21 2019 Mamoru TASAKA <mtasaka@fedoraproject.org> - 0.5.2-2
- F-30: rebuild against ruby26
* Thu Jul 19 2018 Jun Aruga <jaruga@redhat.com> - 0.5.2-1
- New upstream release 0.5.2
* Sat Jul 14 2018 Fedora Release Engineering <releng@fedoraproject.org> - 0.4.10-5
- Rebuilt for https://fedoraproject.org/wiki/Fedora_29_Mass_Rebuild
* Tue Dec 12 2023 MSVSphere Packaging Team <packager@msvsphere-os.ru> - 0.4.10-4
- Rebuilt for MSVSphere 8.8
* Fri Feb 09 2018 Fedora Release Engineering <releng@fedoraproject.org> - 0.4.10-4
- Rebuilt for https://fedoraproject.org/wiki/Fedora_28_Mass_Rebuild

Loading…
Cancel
Save