You can not select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
69 lines
2.5 KiB
69 lines
2.5 KiB
2 years ago
|
From 8452a7925e18d6d57e2ac787b192097d4136b104 Mon Sep 17 00:00:00 2001
|
||
|
|
From: Vitaly Kuznetsov <vkuznets@redhat.com>
|
||
|
|
Date: Thu, 18 Aug 2022 17:01:13 +0200
|
||
|
|
Subject: [PATCH 2/2] i386: do kvm_put_msr_feature_control() first thing when
|
||
|
|
vCPU is reset
|
||
|
|
|
||
|
|
RH-Author: Vitaly Kuznetsov <vkuznets@redhat.com>
|
||
|
|
RH-MergeRequest: 217: i386: fix 'system_reset' when the VM is in VMX root operation
|
||
|
|
RH-Bugzilla: 2117546
|
||
|
|
RH-Acked-by: Emanuele Giuseppe Esposito <eesposit@redhat.com>
|
||
|
|
RH-Acked-by: Miroslav Rezanina <mrezanin@redhat.com>
|
||
|
|
RH-Acked-by: Peter Xu <peterx@redhat.com>
|
||
|
|
RH-Commit: [2/2] 08d5992691ba70561ce0a5b7f4504618f96a2ee6
|
||
|
|
|
||
|
|
kvm_put_sregs2() fails to reset 'locked' CR4/CR0 bits upon vCPU reset when
|
||
|
|
it is in VMX root operation. Do kvm_put_msr_feature_control() before
|
||
|
|
kvm_put_sregs2() to (possibly) kick vCPU out of VMX root operation. It also
|
||
|
|
seems logical to do kvm_put_msr_feature_control() before
|
||
|
|
kvm_put_nested_state() and not after it, especially when 'real' nested
|
||
|
|
state is set.
|
||
|
|
|
||
|
|
Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
|
||
|
|
Message-Id: <20220818150113.479917-3-vkuznets@redhat.com>
|
||
|
|
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
|
||
|
|
(cherry picked from commit 45ed68a1a3a19754ade954d75a3c9d13ff560e5c)
|
||
|
|
Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
|
||
|
|
---
|
||
|
|
target/i386/kvm/kvm.c | 17 ++++++++++++-----
|
||
|
|
1 file changed, 12 insertions(+), 5 deletions(-)
|
||
|
|
|
||
|
|
diff --git a/target/i386/kvm/kvm.c b/target/i386/kvm/kvm.c
|
||
|
|
index 9feb98fe0b..ef70e2c85f 100644
|
||
|
|
--- a/target/i386/kvm/kvm.c
|
||
|
|
+++ b/target/i386/kvm/kvm.c
|
||
|
|
@@ -4356,6 +4356,18 @@ int kvm_arch_put_registers(CPUState *cpu, int level)
|
||
|
|
|
||
|
|
assert(cpu_is_stopped(cpu) || qemu_cpu_is_self(cpu));
|
||
|
|
|
||
|
|
+ /*
|
||
|
|
+ * Put MSR_IA32_FEATURE_CONTROL first, this ensures the VM gets out of VMX
|
||
|
|
+ * root operation upon vCPU reset. kvm_put_msr_feature_control() should also
|
||
|
|
+ * preceed kvm_put_nested_state() when 'real' nested state is set.
|
||
|
|
+ */
|
||
|
|
+ if (level >= KVM_PUT_RESET_STATE) {
|
||
|
|
+ ret = kvm_put_msr_feature_control(x86_cpu);
|
||
|
|
+ if (ret < 0) {
|
||
|
|
+ return ret;
|
||
|
|
+ }
|
||
|
|
+ }
|
||
|
|
+
|
||
|
|
/* must be before kvm_put_nested_state so that EFER.SVME is set */
|
||
|
|
ret = has_sregs2 ? kvm_put_sregs2(x86_cpu) : kvm_put_sregs(x86_cpu);
|
||
|
|
if (ret < 0) {
|
||
|
|
@@ -4367,11 +4379,6 @@ int kvm_arch_put_registers(CPUState *cpu, int level)
|
||
|
|
if (ret < 0) {
|
||
|
|
return ret;
|
||
|
|
}
|
||
|
|
-
|
||
|
|
- ret = kvm_put_msr_feature_control(x86_cpu);
|
||
|
|
- if (ret < 0) {
|
||
|
|
- return ret;
|
||
|
|
- }
|
||
|
|
}
|
||
|
|
|
||
|
|
if (level == KVM_PUT_FULL_STATE) {
|
||
|
|
--
|
||
|
|
2.31.1
|
||
|
|
|