You can not select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
161 lines
7.1 KiB
161 lines
7.1 KiB
4 months ago
|
From d37035373a266644b241aab1f041ab09c9185540 Mon Sep 17 00:00:00 2001
|
||
|
|
From: Jon Maloy <jmaloy@redhat.com>
|
||
|
|
Date: Thu, 18 Jul 2024 09:29:54 -0400
|
||
|
|
Subject: [PATCH 4/6] hw/display/virtio-gpu: Protect from DMA re-entrancy bugs
|
||
|
|
MIME-Version: 1.0
|
||
|
|
Content-Type: text/plain; charset=UTF-8
|
||
|
|
Content-Transfer-Encoding: 8bit
|
||
|
|
|
||
|
|
RH-Author: Jon Maloy <jmaloy@redhat.com>
|
||
|
|
RH-MergeRequest: 380: QEMU: virtio: DMA reentrancy issue leads to double free vulnerability
|
||
|
|
RH-Jira: RHEL-32276
|
||
|
|
RH-Acked-by: Gerd Hoffmann <None>
|
||
|
|
RH-Acked-by: Miroslav Rezanina <mrezanin@redhat.com>
|
||
|
|
RH-Commit: [4/6] e3cd21742228528a1a74ea62d55b5941d3efb261 (redhat/rhel/src/qemu-kvm/jons-qemu-kvm-2)
|
||
|
|
|
||
|
|
JIRA: https://issues.redhat.com/browse/RHEL-32276
|
||
|
|
CVE: CVE-2024-3446
|
||
|
|
Upstream: Merged
|
||
|
|
|
||
|
|
commit ba28e0ff4d95b56dc334aac2730ab3651ffc3132
|
||
|
|
Author: Philippe Mathieu-Daudé <philmd@linaro.org>
|
||
|
|
Date: Thu Apr 4 20:56:27 2024 +0200
|
||
|
|
|
||
|
|
hw/display/virtio-gpu: Protect from DMA re-entrancy bugs
|
||
|
|
|
||
|
|
Replace qemu_bh_new_guarded() by virtio_bh_new_guarded()
|
||
|
|
so the bus and device use the same guard. Otherwise the
|
||
|
|
DMA-reentrancy protection can be bypassed:
|
||
|
|
|
||
|
|
$ cat << EOF | qemu-system-i386 -display none -nodefaults \
|
||
|
|
-machine q35,accel=qtest \
|
||
|
|
-m 512M \
|
||
|
|
-device virtio-gpu \
|
||
|
|
-qtest stdio
|
||
|
|
outl 0xcf8 0x80000820
|
||
|
|
outl 0xcfc 0xe0004000
|
||
|
|
outl 0xcf8 0x80000804
|
||
|
|
outw 0xcfc 0x06
|
||
|
|
write 0xe0004030 0x4 0x024000e0
|
||
|
|
write 0xe0004028 0x1 0xff
|
||
|
|
write 0xe0004020 0x4 0x00009300
|
||
|
|
write 0xe000401c 0x1 0x01
|
||
|
|
write 0x101 0x1 0x04
|
||
|
|
write 0x103 0x1 0x1c
|
||
|
|
write 0x9301c8 0x1 0x18
|
||
|
|
write 0x105 0x1 0x1c
|
||
|
|
write 0x107 0x1 0x1c
|
||
|
|
write 0x109 0x1 0x1c
|
||
|
|
write 0x10b 0x1 0x00
|
||
|
|
write 0x10d 0x1 0x00
|
||
|
|
write 0x10f 0x1 0x00
|
||
|
|
write 0x111 0x1 0x00
|
||
|
|
write 0x113 0x1 0x00
|
||
|
|
write 0x115 0x1 0x00
|
||
|
|
write 0x117 0x1 0x00
|
||
|
|
write 0x119 0x1 0x00
|
||
|
|
write 0x11b 0x1 0x00
|
||
|
|
write 0x11d 0x1 0x00
|
||
|
|
write 0x11f 0x1 0x00
|
||
|
|
write 0x121 0x1 0x00
|
||
|
|
write 0x123 0x1 0x00
|
||
|
|
write 0x125 0x1 0x00
|
||
|
|
write 0x127 0x1 0x00
|
||
|
|
write 0x129 0x1 0x00
|
||
|
|
write 0x12b 0x1 0x00
|
||
|
|
write 0x12d 0x1 0x00
|
||
|
|
write 0x12f 0x1 0x00
|
||
|
|
write 0x131 0x1 0x00
|
||
|
|
write 0x133 0x1 0x00
|
||
|
|
write 0x135 0x1 0x00
|
||
|
|
write 0x137 0x1 0x00
|
||
|
|
write 0x139 0x1 0x00
|
||
|
|
write 0xe0007003 0x1 0x00
|
||
|
|
EOF
|
||
|
|
...
|
||
|
|
=================================================================
|
||
|
|
==276099==ERROR: AddressSanitizer: heap-use-after-free on address 0x60d000011178
|
||
|
|
at pc 0x562cc3b736c7 bp 0x7ffed49dee60 sp 0x7ffed49dee58
|
||
|
|
READ of size 8 at 0x60d000011178 thread T0
|
||
|
|
#0 0x562cc3b736c6 in virtio_gpu_ctrl_response hw/display/virtio-gpu.c:180:42
|
||
|
|
#1 0x562cc3b7c40b in virtio_gpu_ctrl_response_nodata hw/display/virtio-gpu.c:192:5
|
||
|
|
#2 0x562cc3b7c40b in virtio_gpu_simple_process_cmd hw/display/virtio-gpu.c:1015:13
|
||
|
|
#3 0x562cc3b82873 in virtio_gpu_process_cmdq hw/display/virtio-gpu.c:1050:9
|
||
|
|
#4 0x562cc4a85514 in aio_bh_call util/async.c:169:5
|
||
|
|
#5 0x562cc4a85c52 in aio_bh_poll util/async.c:216:13
|
||
|
|
#6 0x562cc4a1a79b in aio_dispatch util/aio-posix.c:423:5
|
||
|
|
#7 0x562cc4a8a2da in aio_ctx_dispatch util/async.c:358:5
|
||
|
|
#8 0x7f36840547a8 in g_main_context_dispatch (/lib/x86_64-linux-gnu/libglib-2.0.so.0+0x547a8)
|
||
|
|
#9 0x562cc4a8b753 in glib_pollfds_poll util/main-loop.c:290:9
|
||
|
|
#10 0x562cc4a8b753 in os_host_main_loop_wait util/main-loop.c:313:5
|
||
|
|
#11 0x562cc4a8b753 in main_loop_wait util/main-loop.c:592:11
|
||
|
|
#12 0x562cc3938186 in qemu_main_loop system/runstate.c:782:9
|
||
|
|
#13 0x562cc43b7af5 in qemu_default_main system/main.c:37:14
|
||
|
|
#14 0x7f3683a6c189 in __libc_start_call_main csu/../sysdeps/nptl/libc_start_call_main.h:58:16
|
||
|
|
#15 0x7f3683a6c244 in __libc_start_main csu/../csu/libc-start.c:381:3
|
||
|
|
#16 0x562cc2a58ac0 in _start (qemu-system-i386+0x231bac0)
|
||
|
|
|
||
|
|
0x60d000011178 is located 56 bytes inside of 136-byte region [0x60d000011140,0x60d0000111c8)
|
||
|
|
freed by thread T0 here:
|
||
|
|
#0 0x562cc2adb662 in __interceptor_free (qemu-system-i386+0x239e662)
|
||
|
|
#1 0x562cc3b86b21 in virtio_gpu_reset hw/display/virtio-gpu.c:1524:9
|
||
|
|
#2 0x562cc416e20e in virtio_reset hw/virtio/virtio.c:2145:9
|
||
|
|
#3 0x562cc37c5644 in virtio_pci_reset hw/virtio/virtio-pci.c:2249:5
|
||
|
|
#4 0x562cc4233758 in memory_region_write_accessor system/memory.c:497:5
|
||
|
|
#5 0x562cc4232eea in access_with_adjusted_size system/memory.c:573:18
|
||
|
|
|
||
|
|
previously allocated by thread T0 here:
|
||
|
|
#0 0x562cc2adb90e in malloc (qemu-system-i386+0x239e90e)
|
||
|
|
#1 0x7f368405a678 in g_malloc (/lib/x86_64-linux-gnu/libglib-2.0.so.0+0x5a678)
|
||
|
|
#2 0x562cc4163ffc in virtqueue_split_pop hw/virtio/virtio.c:1612:12
|
||
|
|
#3 0x562cc4163ffc in virtqueue_pop hw/virtio/virtio.c:1783:16
|
||
|
|
#4 0x562cc3b91a95 in virtio_gpu_handle_ctrl hw/display/virtio-gpu.c:1112:15
|
||
|
|
#5 0x562cc4a85514 in aio_bh_call util/async.c:169:5
|
||
|
|
#6 0x562cc4a85c52 in aio_bh_poll util/async.c:216:13
|
||
|
|
#7 0x562cc4a1a79b in aio_dispatch util/aio-posix.c:423:5
|
||
|
|
|
||
|
|
SUMMARY: AddressSanitizer: heap-use-after-free hw/display/virtio-gpu.c:180:42 in virtio_gpu_ctrl_response
|
||
|
|
|
||
|
|
With this change, the same reproducer triggers:
|
||
|
|
|
||
|
|
qemu-system-i386: warning: Blocked re-entrant IO on MemoryRegion: virtio-pci-common-virtio-gpu at addr: 0x6
|
||
|
|
|
||
|
|
Fixes: CVE-2024-3446
|
||
|
|
Cc: qemu-stable@nongnu.org
|
||
|
|
Reported-by: Alexander Bulekov <alxndr@bu.edu>
|
||
|
|
Reported-by: Yongkang Jia <kangel@zju.edu.cn>
|
||
|
|
Reported-by: Xiao Lei <nop.leixiao@gmail.com>
|
||
|
|
Reported-by: Yiming Tao <taoym@zju.edu.cn>
|
||
|
|
Buglink: https://bugs.launchpad.net/qemu/+bug/1888606
|
||
|
|
Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>
|
||
|
|
Acked-by: Michael S. Tsirkin <mst@redhat.com>
|
||
|
|
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
|
||
|
|
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
|
||
|
|
Message-Id: <20240409105537.18308-3-philmd@linaro.org>
|
||
|
|
|
||
|
|
Signed-off-by: Jon Maloy <jmaloy@redhat.com>
|
||
|
|
---
|
||
|
|
hw/display/virtio-gpu.c | 6 ++----
|
||
|
|
1 file changed, 2 insertions(+), 4 deletions(-)
|
||
|
|
|
||
|
|
diff --git a/hw/display/virtio-gpu.c b/hw/display/virtio-gpu.c
|
||
|
|
index c28ce1ea72..64fdc18478 100644
|
||
|
|
--- a/hw/display/virtio-gpu.c
|
||
|
|
+++ b/hw/display/virtio-gpu.c
|
||
|
|
@@ -1334,10 +1334,8 @@ void virtio_gpu_device_realize(DeviceState *qdev, Error **errp)
|
||
|
|
|
||
|
|
g->ctrl_vq = virtio_get_queue(vdev, 0);
|
||
|
|
g->cursor_vq = virtio_get_queue(vdev, 1);
|
||
|
|
- g->ctrl_bh = qemu_bh_new_guarded(virtio_gpu_ctrl_bh, g,
|
||
|
|
- &qdev->mem_reentrancy_guard);
|
||
|
|
- g->cursor_bh = qemu_bh_new_guarded(virtio_gpu_cursor_bh, g,
|
||
|
|
- &qdev->mem_reentrancy_guard);
|
||
|
|
+ g->ctrl_bh = virtio_bh_new_guarded(qdev, virtio_gpu_ctrl_bh, g);
|
||
|
|
+ g->cursor_bh = virtio_bh_new_guarded(qdev, virtio_gpu_cursor_bh, g);
|
||
|
|
g->reset_bh = qemu_bh_new(virtio_gpu_reset_bh, g);
|
||
|
|
qemu_cond_init(&g->reset_cond);
|
||
|
|
QTAILQ_INIT(&g->reslist);
|
||
|
|
--
|
||
|
|
2.39.3
|
||
|
|
|