You can not select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
37 lines
1.4 KiB
37 lines
1.4 KiB
3 months ago
|
commit 89ff31db581df98eb34f19471421f5cfcfb1cefd (HEAD -> master)
|
||
|
|
Author: Ray Strode <rstrode@redhat.com>
|
||
|
|
Date: Fri Sep 27 15:31:03 2024 -0400
|
||
|
|
|
||
|
|
internals: Root conversation and closure data
|
||
|
|
|
||
|
|
If the conversation and closure data are not rooted to the class
|
||
|
|
then they can be garbage collected before the conversation function
|
||
|
|
is invoked.
|
||
|
|
|
||
|
|
That leads to a crash in pam_lastlog during session open time.
|
||
|
|
|
||
|
|
This commit addressed the issue by assigning the state to the class
|
||
|
|
as properties.
|
||
|
|
|
||
|
|
diff --git a/src/pam/__internals.py b/src/pam/__internals.py
|
||
|
|
index 99a0397..9e33188 100644
|
||
|
|
--- a/src/pam/__internals.py
|
||
|
|
+++ b/src/pam/__internals.py
|
||
|
|
@@ -311,11 +311,11 @@ class PamAuthenticator:
|
||
|
|
|
||
|
|
# do this up front so we can safely throw an exception if there's
|
||
|
|
# anything wrong with it
|
||
|
|
- app_data = {'msgs': self.messages, 'password': password, 'encoding': encoding}
|
||
|
|
- conv = PamConv(__conv, c_void_p.from_buffer(py_object(app_data)))
|
||
|
|
+ self.app_data = {'msgs': self.messages, 'password': password, 'encoding': encoding}
|
||
|
|
+ self.conv = PamConv(__conv, c_void_p.from_buffer(py_object(self.app_data)))
|
||
|
|
|
||
|
|
self.handle = PamHandle()
|
||
|
|
- retval = self.pam_start(service, username, byref(conv),
|
||
|
|
+ retval = self.pam_start(service, username, byref(self.conv),
|
||
|
|
byref(self.handle))
|
||
|
|
|
||
|
|
if retval != PAM_SUCCESS: # pragma: no cover
|
||
|
|
|
||
|
|
|