From 8d3762642db71e76865af37f70712e58bee11a33 Mon Sep 17 00:00:00 2001 From: CentOS Sources Date: Tue, 15 Nov 2022 01:42:47 -0500 Subject: [PATCH] import python-blivet-3.4.0-16.el9 --- .gitignore | 2 + .python-blivet.metadata | 2 + SOURCES/0001-force-lvm-cli-plugin.patch | 35 + SOURCES/0002-remove-btrfs-plugin.patch | 28 + ...03-Revert-More-consistent-lvm-errors.patch | 330 ++ ...unify-importing-mock-module-in-tests.patch | 538 +++ .../0006-Fix-util.virt_detect-on-Xen.patch | 23 + ...x-activating-old-style-LVM-snapshots.patch | 35 + ...vices-with-names-that-look-like-BIOS.patch | 75 + ...0009-Do-not-set-chunk-size-for-RAID1.patch | 151 + .../0010-Fix-running-tests-in-gating.patch | 231 ++ ...-ignore-the-new-devices-file-for-now.patch | 68 + ...ssage-printed-for-missing-dependecie.patch | 65 + ...-size-for-thinpools-bigger-than-15.8.patch | 90 + SOURCES/0014-LVM-devices-file-support.patch | 774 ++++ ...ll-log_exception_info-calls-with-log.patch | 53 + ...g-message-for-the-LVM-devices-filter.patch | 33 + ...unusable-disks-from-PartitionFactory.patch | 81 + ...nfo-in-LVMPhysicalVolume-from-the-ca.patch | 29 + ...n-changing-disklabel-on-disks-with-a.patch | 41 + ...ice-should-not-obsolete-ActionRemove.patch | 65 + ..._name-after-adding-removing-a-PV-fro.patch | 63 + ...support-for-creating-LVM-cache-pools.patch | 588 +++ ...t-current_size-in-LVMVolumeGroupDevi.patch | 29 + ...disks-in-test_get_related_disks-as-n.patch | 36 + ...upport-for-NPIV-enabled-zFCP-devices.patch | 789 ++++ .../0026-Add-a-very-simple-NVMe-module.patch | 129 + .../0027-DDF-RAID-support-using-mdadm.patch | 107 + SPECS/python-blivet.spec | 3455 +++++++++++++++++ 29 files changed, 7945 insertions(+) create mode 100644 .gitignore create mode 100644 .python-blivet.metadata create mode 100644 SOURCES/0001-force-lvm-cli-plugin.patch create mode 100644 SOURCES/0002-remove-btrfs-plugin.patch create mode 100644 SOURCES/0003-Revert-More-consistent-lvm-errors.patch create mode 100644 SOURCES/0005-Fix-unify-importing-mock-module-in-tests.patch create mode 100644 SOURCES/0006-Fix-util.virt_detect-on-Xen.patch create mode 100644 SOURCES/0007-Fix-activating-old-style-LVM-snapshots.patch create mode 100644 SOURCES/0008-Fix-resolving-devices-with-names-that-look-like-BIOS.patch create mode 100644 SOURCES/0009-Do-not-set-chunk-size-for-RAID1.patch create mode 100644 SOURCES/0010-Fix-running-tests-in-gating.patch create mode 100644 SOURCES/0011-Tell-LVM-to-ignore-the-new-devices-file-for-now.patch create mode 100644 SOURCES/0012-Improve-error-message-printed-for-missing-dependecie.patch create mode 100644 SOURCES/0013-Use-bigger-chunk-size-for-thinpools-bigger-than-15.8.patch create mode 100644 SOURCES/0014-LVM-devices-file-support.patch create mode 100644 SOURCES/0015-iscsi-Replace-all-log_exception_info-calls-with-log.patch create mode 100644 SOURCES/0016-Fix-log-message-for-the-LVM-devices-filter.patch create mode 100644 SOURCES/0017-Exclude-unusable-disks-from-PartitionFactory.patch create mode 100644 SOURCES/0018-Fix-getting-PV-info-in-LVMPhysicalVolume-from-the-ca.patch create mode 100644 SOURCES/0019-Do-not-crash-when-changing-disklabel-on-disks-with-a.patch create mode 100644 SOURCES/0020-ActionDestroyDevice-should-not-obsolete-ActionRemove.patch create mode 100644 SOURCES/0021-Correctly-set-vg_name-after-adding-removing-a-PV-fro.patch create mode 100644 SOURCES/0022-Add-support-for-creating-LVM-cache-pools.patch create mode 100644 SOURCES/0023-Use-LVM-PV-format-current_size-in-LVMVolumeGroupDevi.patch create mode 100644 SOURCES/0024-tests-Mark-fake-disks-in-test_get_related_disks-as-n.patch create mode 100644 SOURCES/0025-Add-support-for-NPIV-enabled-zFCP-devices.patch create mode 100644 SOURCES/0026-Add-a-very-simple-NVMe-module.patch create mode 100644 SOURCES/0027-DDF-RAID-support-using-mdadm.patch create mode 100644 SPECS/python-blivet.spec diff --git a/.gitignore b/.gitignore new file mode 100644 index 0000000..22c65de --- /dev/null +++ b/.gitignore @@ -0,0 +1,2 @@ +SOURCES/blivet-3.4.0-tests.tar.gz +SOURCES/blivet-3.4.0.tar.gz diff --git a/.python-blivet.metadata b/.python-blivet.metadata new file mode 100644 index 0000000..f6bdfc3 --- /dev/null +++ b/.python-blivet.metadata @@ -0,0 +1,2 @@ +d0a86df7bbaeda7be9990b7f7b15ec36b325ec7a SOURCES/blivet-3.4.0-tests.tar.gz +aafc429e224dfd204cb1c284bb70de52920f7b20 SOURCES/blivet-3.4.0.tar.gz diff --git a/SOURCES/0001-force-lvm-cli-plugin.patch b/SOURCES/0001-force-lvm-cli-plugin.patch new file mode 100644 index 0000000..2a15b22 --- /dev/null +++ b/SOURCES/0001-force-lvm-cli-plugin.patch @@ -0,0 +1,35 @@ +From 2f90040ff66eacc9715e370cd49ffb72d8d1f36f Mon Sep 17 00:00:00 2001 +From: Vojtech Trefny +Date: Wed, 11 Jul 2018 15:36:24 +0200 +Subject: [PATCH] Force command line based libblockdev LVM plugin + +--- + blivet/__init__.py | 9 +++++++-- + 1 file changed, 7 insertions(+), 2 deletions(-) + +diff --git a/blivet/__init__.py b/blivet/__init__.py +index c5a75bb..cb75917 100644 +--- a/blivet/__init__.py ++++ b/blivet/__init__.py +@@ -63,11 +63,16 @@ gi.require_version("BlockDev", "2.0") + from gi.repository import GLib + from gi.repository import BlockDev as blockdev + if arch.is_s390(): +- _REQUESTED_PLUGIN_NAMES = set(("lvm", "btrfs", "swap", "crypto", "loop", "mdraid", "mpath", "dm", "s390", "nvdimm")) ++ _REQUESTED_PLUGIN_NAMES = set(("btrfs", "swap", "crypto", "loop", "mdraid", "mpath", "dm", "s390", "nvdimm")) + else: +- _REQUESTED_PLUGIN_NAMES = set(("lvm", "btrfs", "swap", "crypto", "loop", "mdraid", "mpath", "dm", "nvdimm")) ++ _REQUESTED_PLUGIN_NAMES = set(("btrfs", "swap", "crypto", "loop", "mdraid", "mpath", "dm", "nvdimm")) + + _requested_plugins = blockdev.plugin_specs_from_names(_REQUESTED_PLUGIN_NAMES) ++# XXX force non-dbus LVM plugin ++lvm_plugin = blockdev.PluginSpec() ++lvm_plugin.name = blockdev.Plugin.LVM ++lvm_plugin.so_name = "libbd_lvm.so.2" ++_requested_plugins.append(lvm_plugin) + try: + # do not check for dependencies during libblockdev initializtion, do runtime + # checks instead +-- +1.8.3.1 + diff --git a/SOURCES/0002-remove-btrfs-plugin.patch b/SOURCES/0002-remove-btrfs-plugin.patch new file mode 100644 index 0000000..5755e9e --- /dev/null +++ b/SOURCES/0002-remove-btrfs-plugin.patch @@ -0,0 +1,28 @@ +From 6bf3378d3d2a1b6a4338df0c4dd36a783a641633 Mon Sep 17 00:00:00 2001 +From: Vojtech Trefny +Date: Mon, 16 Jul 2018 14:26:11 +0200 +Subject: [PATCH] Remove btrfs from requested libblockdev plugins + +--- + blivet/__init__.py | 4 ++-- + 1 file changed, 2 insertions(+), 2 deletions(-) + +diff --git a/blivet/__init__.py b/blivet/__init__.py +index cb75917..09f8b1c 100644 +--- a/blivet/__init__.py ++++ b/blivet/__init__.py +@@ -63,9 +63,9 @@ gi.require_version("BlockDev", "2.0") + from gi.repository import GLib + from gi.repository import BlockDev as blockdev + if arch.is_s390(): +- _REQUESTED_PLUGIN_NAMES = set(("btrfs", "swap", "crypto", "loop", "mdraid", "mpath", "dm", "s390", "nvdimm")) ++ _REQUESTED_PLUGIN_NAMES = set(("swap", "crypto", "loop", "mdraid", "mpath", "dm", "s390", "nvdimm")) + else: +- _REQUESTED_PLUGIN_NAMES = set(("btrfs", "swap", "crypto", "loop", "mdraid", "mpath", "dm", "nvdimm")) ++ _REQUESTED_PLUGIN_NAMES = set(("swap", "crypto", "loop", "mdraid", "mpath", "dm", "nvdimm")) + + _requested_plugins = blockdev.plugin_specs_from_names(_REQUESTED_PLUGIN_NAMES) + # XXX force non-dbus LVM plugin +-- +1.8.3.1 + diff --git a/SOURCES/0003-Revert-More-consistent-lvm-errors.patch b/SOURCES/0003-Revert-More-consistent-lvm-errors.patch new file mode 100644 index 0000000..69306a8 --- /dev/null +++ b/SOURCES/0003-Revert-More-consistent-lvm-errors.patch @@ -0,0 +1,330 @@ +From 3a42d9e2afdf04dbbfd2c507f5b2392193fda25b Mon Sep 17 00:00:00 2001 +From: Vojtech Trefny +Date: Wed, 26 May 2021 12:15:54 +0200 +Subject: [PATCH] Revert "More consistent lvm errors (API break)" + +This reverts commit 49ec071c6d0673224a0774d613904387c52c7381. +--- + blivet/devices/lvm.py | 72 +++++++++++++++++----------------- + tests/devices_test/lvm_test.py | 14 +++---- + 2 files changed, 43 insertions(+), 43 deletions(-) + +diff --git a/blivet/devices/lvm.py b/blivet/devices/lvm.py +index a55515fc..6d23bfba 100644 +--- a/blivet/devices/lvm.py ++++ b/blivet/devices/lvm.py +@@ -307,7 +307,7 @@ class LVMVolumeGroupDevice(ContainerDevice): + def _add_log_vol(self, lv): + """ Add an LV to this VG. """ + if lv in self._lvs: +- raise errors.DeviceError("lv is already part of this vg") ++ raise ValueError("lv is already part of this vg") + + # verify we have the space, then add it + # do not verify for growing vg (because of ks) +@@ -340,7 +340,7 @@ class LVMVolumeGroupDevice(ContainerDevice): + def _remove_log_vol(self, lv): + """ Remove an LV from this VG. """ + if lv not in self.lvs: +- raise errors.DeviceError("specified lv is not part of this vg") ++ raise ValueError("specified lv is not part of this vg") + + self._lvs.remove(lv) + +@@ -415,7 +415,7 @@ class LVMVolumeGroupDevice(ContainerDevice): + @thpool_reserve.setter + def thpool_reserve(self, value): + if value is not None and not isinstance(value, ThPoolReserveSpec): +- raise AttributeError("Invalid thpool_reserve given, must be of type ThPoolReserveSpec") ++ raise ValueError("Invalid thpool_reserve given, must be of type ThPoolReserveSpec") + self._thpool_reserve = value + + @property +@@ -646,14 +646,14 @@ class LVMLogicalVolumeBase(DMDevice, RaidDevice): + if seg_type not in [None, "linear", "thin", "thin-pool", "cache", "vdo-pool", "vdo"] + lvm.raid_seg_types: + raise ValueError("Invalid or unsupported segment type: %s" % seg_type) + if seg_type and seg_type in lvm.raid_seg_types and not pvs: +- raise errors.DeviceError("List of PVs has to be given for every non-linear LV") ++ raise ValueError("List of PVs has to be given for every non-linear LV") + elif (not seg_type or seg_type == "linear") and pvs: + if not all(isinstance(pv, LVPVSpec) for pv in pvs): +- raise errors.DeviceError("Invalid specification of PVs for a linear LV: either no or complete " +- "specification (with all space split into PVs has to be given") ++ raise ValueError("Invalid specification of PVs for a linear LV: either no or complete " ++ "specification (with all space split into PVs has to be given") + elif sum(spec.size for spec in pvs) != size: +- raise errors.DeviceError("Invalid specification of PVs for a linear LV: the sum of space " +- "assigned to PVs is not equal to the size of the LV") ++ raise ValueError("Invalid specification of PVs for a linear LV: the sum of space " ++ "assigned to PVs is not equal to the size of the LV") + + # When this device's format is set in the superclass constructor it will + # try to access self.snapshots. +@@ -702,13 +702,13 @@ class LVMLogicalVolumeBase(DMDevice, RaidDevice): + self._from_lvs = from_lvs + if self._from_lvs: + if exists: +- raise errors.DeviceError("Only new LVs can be created from other LVs") ++ raise ValueError("Only new LVs can be created from other LVs") + if size or maxsize or percent: +- raise errors.DeviceError("Cannot specify size for a converted LV") ++ raise ValueError("Cannot specify size for a converted LV") + if fmt: +- raise errors.DeviceError("Cannot specify format for a converted LV") ++ raise ValueError("Cannot specify format for a converted LV") + if any(lv.vg != self.vg for lv in self._from_lvs): +- raise errors.DeviceError("Conversion of LVs only possible inside a VG") ++ raise ValueError("Conversion of LVs only possible inside a VG") + + self._cache = None + if cache_request and not self.exists: +@@ -723,13 +723,13 @@ class LVMLogicalVolumeBase(DMDevice, RaidDevice): + elif isinstance(pv_spec, StorageDevice): + self._pv_specs.append(LVPVSpec(pv_spec, Size(0))) + else: +- raise AttributeError("Invalid PV spec '%s' for the '%s' LV" % (pv_spec, self.name)) ++ raise ValueError("Invalid PV spec '%s' for the '%s' LV" % (pv_spec, self.name)) + # Make sure any destination PVs are actually PVs in this VG + if not set(spec.pv for spec in self._pv_specs).issubset(set(self.vg.parents)): + missing = [r.name for r in + set(spec.pv for spec in self._pv_specs).difference(set(self.vg.parents))] + msg = "invalid destination PV(s) %s for LV %s" % (missing, self.name) +- raise errors.DeviceError(msg) ++ raise ValueError(msg) + if self._pv_specs: + self._assign_pv_space() + +@@ -1072,7 +1072,7 @@ class LVMLogicalVolumeBase(DMDevice, RaidDevice): + else: + msg = "the specified internal LV '%s' doesn't belong to this LV ('%s')" % (int_lv.lv_name, + self.name) +- raise errors.DeviceError(msg) ++ raise ValueError(msg) + + def populate_ksdata(self, data): + super(LVMLogicalVolumeBase, self).populate_ksdata(data) +@@ -1171,7 +1171,7 @@ class LVMInternalLogicalVolumeMixin(object): + def _init_check(self): + # an internal LV should have no parents + if self._parent_lv and self._parents: +- raise errors.DeviceError("an internal LV should have no parents") ++ raise ValueError("an internal LV should have no parents") + + @property + def is_internal_lv(self): +@@ -1231,7 +1231,7 @@ class LVMInternalLogicalVolumeMixin(object): + + @readonly.setter + def readonly(self, value): # pylint: disable=unused-argument +- raise errors.DeviceError("Cannot make an internal LV read-write") ++ raise ValueError("Cannot make an internal LV read-write") + + @property + def type(self): +@@ -1267,7 +1267,7 @@ class LVMInternalLogicalVolumeMixin(object): + def _check_parents(self): + # an internal LV should have no parents + if self._parents: +- raise errors.DeviceError("an internal LV should have no parents") ++ raise ValueError("an internal LV should have no parents") + + def _add_to_parents(self): + # nothing to do here, an internal LV has no parents (in the DeviceTree's +@@ -1277,13 +1277,13 @@ class LVMInternalLogicalVolumeMixin(object): + # internal LVs follow different rules limitting size + def _set_size(self, newsize): + if not isinstance(newsize, Size): +- raise AttributeError("new size must of type Size") ++ raise ValueError("new size must of type Size") + + if not self.takes_extra_space: + if newsize <= self.parent_lv.size: # pylint: disable=no-member + self._size = newsize # pylint: disable=attribute-defined-outside-init + else: +- raise errors.DeviceError("Internal LV cannot be bigger than its parent LV") ++ raise ValueError("Internal LV cannot be bigger than its parent LV") + else: + # same rules apply as for any other LV + raise NotTypeSpecific() +@@ -1361,18 +1361,18 @@ class LVMSnapshotMixin(object): + return + + if self.origin and not isinstance(self.origin, LVMLogicalVolumeDevice): +- raise errors.DeviceError("lvm snapshot origin must be a logical volume") ++ raise ValueError("lvm snapshot origin must be a logical volume") + if self.vorigin and not self.exists: +- raise errors.DeviceError("only existing vorigin snapshots are supported") ++ raise ValueError("only existing vorigin snapshots are supported") + + if isinstance(self.origin, LVMLogicalVolumeDevice) and \ + isinstance(self.parents[0], LVMVolumeGroupDevice) and \ + self.origin.vg != self.parents[0]: +- raise errors.DeviceError("lvm snapshot and origin must be in the same vg") ++ raise ValueError("lvm snapshot and origin must be in the same vg") + + if self.is_thin_lv: + if self.origin and self.size and not self.exists: +- raise errors.DeviceError("thin snapshot size is determined automatically") ++ raise ValueError("thin snapshot size is determined automatically") + + @property + def is_snapshot_lv(self): +@@ -1544,7 +1544,7 @@ class LVMThinPoolMixin(object): + def _check_from_lvs(self): + if self._from_lvs: + if len(self._from_lvs) != 2: +- raise errors.DeviceError("two LVs required to create a thin pool") ++ raise ValueError("two LVs required to create a thin pool") + + def _convert_from_lvs(self): + data_lv, metadata_lv = self._from_lvs +@@ -1590,7 +1590,7 @@ class LVMThinPoolMixin(object): + def _add_log_vol(self, lv): + """ Add an LV to this pool. """ + if lv in self._lvs: +- raise errors.DeviceError("lv is already part of this vg") ++ raise ValueError("lv is already part of this vg") + + # TODO: add some checking to prevent overcommit for preexisting + self.vg._add_log_vol(lv) +@@ -1601,7 +1601,7 @@ class LVMThinPoolMixin(object): + def _remove_log_vol(self, lv): + """ Remove an LV from this pool. """ + if lv not in self._lvs: +- raise errors.DeviceError("specified lv is not part of this vg") ++ raise ValueError("specified lv is not part of this vg") + + self._lvs.remove(lv) + self.vg._remove_log_vol(lv) +@@ -1711,14 +1711,14 @@ class LVMThinLogicalVolumeMixin(object): + """Check that this device has parents as expected""" + if isinstance(self.parents, (list, ParentList)): + if len(self.parents) != 1: +- raise errors.DeviceError("constructor requires a single thin-pool LV") ++ raise ValueError("constructor requires a single thin-pool LV") + + container = self.parents[0] + else: + container = self.parents + + if not container or not isinstance(container, LVMLogicalVolumeDevice) or not container.is_thin_pool: +- raise errors.DeviceError("constructor requires a thin-pool LV") ++ raise ValueError("constructor requires a thin-pool LV") + + @property + def is_thin_lv(self): +@@ -1755,7 +1755,7 @@ class LVMThinLogicalVolumeMixin(object): + + def _set_size(self, newsize): + if not isinstance(newsize, Size): +- raise AttributeError("new size must of type Size") ++ raise ValueError("new size must of type Size") + + newsize = self.vg.align(newsize) + newsize = self.vg.align(util.numeric_type(newsize)) +@@ -2229,7 +2229,7 @@ class LVMLogicalVolumeDevice(LVMLogicalVolumeBase, LVMInternalLogicalVolumeMixin + container = self.parents + + if not isinstance(container, LVMVolumeGroupDevice): +- raise AttributeError("constructor requires a LVMVolumeGroupDevice") ++ raise ValueError("constructor requires a LVMVolumeGroupDevice") + + @type_specific + def _add_to_parents(self): +@@ -2240,12 +2240,12 @@ class LVMLogicalVolumeDevice(LVMLogicalVolumeBase, LVMInternalLogicalVolumeMixin + @type_specific + def _check_from_lvs(self): + """Check the LVs to create this LV from""" +- raise errors.DeviceError("Cannot create a new LV of type '%s' from other LVs" % self.seg_type) ++ raise ValueError("Cannot create a new LV of type '%s' from other LVs" % self.seg_type) + + @type_specific + def _convert_from_lvs(self): + """Convert the LVs to create this LV from into its internal LVs""" +- raise errors.DeviceError("Cannot create a new LV of type '%s' from other LVs" % self.seg_type) ++ raise ValueError("Cannot create a new LV of type '%s' from other LVs" % self.seg_type) + + @property + def external_dependencies(self): +@@ -2265,7 +2265,7 @@ class LVMLogicalVolumeDevice(LVMLogicalVolumeBase, LVMInternalLogicalVolumeMixin + @type_specific + def _set_size(self, newsize): + if not isinstance(newsize, Size): +- raise AttributeError("new size must be of type Size") ++ raise ValueError("new size must be of type Size") + + newsize = self.vg.align(newsize) + log.debug("trying to set lv %s size to %s", self.name, newsize) +@@ -2274,7 +2274,7 @@ class LVMLogicalVolumeDevice(LVMLogicalVolumeBase, LVMInternalLogicalVolumeMixin + # space for it. A similar reasoning applies to shrinking the LV. + if not self.exists and newsize > self.size and newsize > self.vg.free_space + self.vg_space_used: + log.error("failed to set size: %s short", newsize - (self.vg.free_space + self.vg_space_used)) +- raise errors.DeviceError("not enough free space in volume group") ++ raise ValueError("not enough free space in volume group") + + LVMLogicalVolumeBase._set_size(self, newsize) + +@@ -2622,7 +2622,7 @@ class LVMCache(Cache): + spec.size = spec.pv.format.free + space_to_assign -= spec.pv.format.free + if space_to_assign > 0: +- raise errors.DeviceError("Not enough free space in the PVs for this cache: %s short" % space_to_assign) ++ raise ValueError("Not enough free space in the PVs for this cache: %s short" % space_to_assign) + + @property + def size(self): +diff --git a/tests/devices_test/lvm_test.py b/tests/devices_test/lvm_test.py +index 670c91c9..4156d0bf 100644 +--- a/tests/devices_test/lvm_test.py ++++ b/tests/devices_test/lvm_test.py +@@ -36,10 +36,10 @@ class LVMDeviceTest(unittest.TestCase): + lv = LVMLogicalVolumeDevice("testlv", parents=[vg], + fmt=blivet.formats.get_format("xfs")) + +- with six.assertRaisesRegex(self, errors.DeviceError, "lvm snapshot origin must be a logical volume"): ++ with six.assertRaisesRegex(self, ValueError, "lvm snapshot origin must be a logical volume"): + LVMLogicalVolumeDevice("snap1", parents=[vg], origin=pv) + +- with six.assertRaisesRegex(self, errors.DeviceError, "only existing vorigin snapshots are supported"): ++ with six.assertRaisesRegex(self, ValueError, "only existing vorigin snapshots are supported"): + LVMLogicalVolumeDevice("snap1", parents=[vg], vorigin=True) + + lv.exists = True +@@ -64,7 +64,7 @@ class LVMDeviceTest(unittest.TestCase): + pool = LVMLogicalVolumeDevice("pool1", parents=[vg], size=Size("500 MiB"), seg_type="thin-pool") + thinlv = LVMLogicalVolumeDevice("thinlv", parents=[pool], size=Size("200 MiB"), seg_type="thin") + +- with six.assertRaisesRegex(self, errors.DeviceError, "lvm snapshot origin must be a logical volume"): ++ with six.assertRaisesRegex(self, ValueError, "lvm snapshot origin must be a logical volume"): + LVMLogicalVolumeDevice("snap1", parents=[pool], origin=pv, seg_type="thin") + + # now make the constructor succeed so we can test some properties +@@ -258,21 +258,21 @@ class LVMDeviceTest(unittest.TestCase): + vg = LVMVolumeGroupDevice("testvg", parents=[pv, pv2]) + + # pvs have to be specified for non-linear LVs +- with self.assertRaises(errors.DeviceError): ++ with self.assertRaises(ValueError): + lv = LVMLogicalVolumeDevice("testlv", parents=[vg], size=Size("512 MiB"), + fmt=blivet.formats.get_format("xfs"), + exists=False, seg_type="raid1") +- with self.assertRaises(errors.DeviceError): ++ with self.assertRaises(ValueError): + lv = LVMLogicalVolumeDevice("testlv", parents=[vg], size=Size("512 MiB"), + fmt=blivet.formats.get_format("xfs"), + exists=False, seg_type="striped") + + # no or complete specification has to be given for linear LVs +- with self.assertRaises(errors.DeviceError): ++ with self.assertRaises(ValueError): + lv = LVMLogicalVolumeDevice("testlv", parents=[vg], size=Size("512 MiB"), + fmt=blivet.formats.get_format("xfs"), + exists=False, pvs=[pv]) +- with self.assertRaises(errors.DeviceError): ++ with self.assertRaises(ValueError): + pv_spec = LVPVSpec(pv, Size("256 MiB")) + pv_spec2 = LVPVSpec(pv2, Size("250 MiB")) + lv = LVMLogicalVolumeDevice("testlv", parents=[vg], size=Size("512 MiB"), +-- +2.31.1 + diff --git a/SOURCES/0005-Fix-unify-importing-mock-module-in-tests.patch b/SOURCES/0005-Fix-unify-importing-mock-module-in-tests.patch new file mode 100644 index 0000000..cb050e4 --- /dev/null +++ b/SOURCES/0005-Fix-unify-importing-mock-module-in-tests.patch @@ -0,0 +1,538 @@ +From ad34dfa2f983bb3159af8b5780193e0427b505e9 Mon Sep 17 00:00:00 2001 +From: Vojtech Trefny +Date: Thu, 10 Jun 2021 15:01:26 +0200 +Subject: [PATCH] Fix/unify importing mock module in tests + +mock is available in the unittest module since Python 3.3, we need +to use the old mock module not only with Python 2 but also with +the early versions of Python 3. +--- + tests/action_test.py | 5 ++- + tests/dbus_test.py | 9 +++-- + tests/devicefactory_test.py | 6 ++-- + tests/devicelibs_test/disk_test.py | 6 ++-- + tests/devicelibs_test/edd_test.py | 6 +++- + tests/devices_test/dependencies_test.py | 6 ++-- + tests/devices_test/device_methods_test.py | 8 +++-- + tests/devices_test/device_names_test.py | 6 ++-- + tests/devices_test/device_properties_test.py | 8 ++--- + tests/devices_test/disk_test.py | 7 ++-- + tests/devices_test/lvm_test.py | 7 ++-- + tests/devices_test/partition_test.py | 6 ++-- + tests/devices_test/tags_test.py | 6 ++-- + tests/devicetree_test.py | 6 ++-- + tests/events_test.py | 6 ++-- + tests/formats_test/disklabel_test.py | 6 ++-- + tests/formats_test/luks_test.py | 6 ++-- + tests/formats_test/lvmpv_test.py | 2 -- + tests/formats_test/methods_test.py | 6 ++-- + tests/formats_test/selinux_test.py | 6 ++-- + tests/formats_test/swap_test.py | 2 -- + tests/misc_test.py | 6 ++-- + tests/partitioning_test.py | 6 ++-- + tests/populator_test.py | 6 ++-- + tests/storagetestcase.py | 5 ++- + tests/test_compat.py | 38 -------------------- + tests/udev_test.py | 6 +++- + tests/unsupported_disklabel_test.py | 7 ++-- + tests/util_test.py | 6 ++-- + 29 files changed, 104 insertions(+), 102 deletions(-) + delete mode 100644 tests/test_compat.py + +diff --git a/tests/action_test.py b/tests/action_test.py +index 38a2e872..f60cf5d7 100644 +--- a/tests/action_test.py ++++ b/tests/action_test.py +@@ -1,9 +1,8 @@ +-from six import PY3 + import unittest + +-if PY3: ++try: + from unittest.mock import Mock +-else: ++except ImportError: + from mock import Mock + + from tests.storagetestcase import StorageTestCase +diff --git a/tests/dbus_test.py b/tests/dbus_test.py +index 293ac073..9bb9102a 100644 +--- a/tests/dbus_test.py ++++ b/tests/dbus_test.py +@@ -1,7 +1,10 @@ +-import test_compat # pylint: disable=unused-import +- + import random +-from six.moves.mock import Mock, patch # pylint: disable=no-name-in-module,import-error ++ ++try: ++ from unittest.mock import patch, Mock ++except ImportError: ++ from mock import patch, Mock ++ + from unittest import TestCase + + import dbus +diff --git a/tests/devicefactory_test.py b/tests/devicefactory_test.py +index dc0d6408..93c8bdb7 100644 +--- a/tests/devicefactory_test.py ++++ b/tests/devicefactory_test.py +@@ -4,8 +4,10 @@ import unittest + from decimal import Decimal + import os + +-import test_compat # pylint: disable=unused-import +-from six.moves.mock import patch # pylint: disable=no-name-in-module,import-error ++try: ++ from unittest.mock import patch ++except ImportError: ++ from mock import patch + + import blivet + +diff --git a/tests/devicelibs_test/disk_test.py b/tests/devicelibs_test/disk_test.py +index e67ef5b1..9cb39951 100644 +--- a/tests/devicelibs_test/disk_test.py ++++ b/tests/devicelibs_test/disk_test.py +@@ -1,8 +1,10 @@ + # pylint: skip-file +-import test_compat ++try: ++ from unittest.mock import Mock, patch, sentinel ++except ImportError: ++ from mock import Mock, patch, sentinel + + import six +-from six.moves.mock import Mock, patch, sentinel + import unittest + + from blivet.devicelibs import disk as disklib +diff --git a/tests/devicelibs_test/edd_test.py b/tests/devicelibs_test/edd_test.py +index 23d736f4..21bbcffc 100644 +--- a/tests/devicelibs_test/edd_test.py ++++ b/tests/devicelibs_test/edd_test.py +@@ -1,5 +1,9 @@ ++try: ++ from unittest import mock ++except ImportError: ++ import mock ++ + import unittest +-import mock + import os + import inspect + import logging +diff --git a/tests/devices_test/dependencies_test.py b/tests/devices_test/dependencies_test.py +index c012751d..493d1c9f 100644 +--- a/tests/devices_test/dependencies_test.py ++++ b/tests/devices_test/dependencies_test.py +@@ -1,8 +1,6 @@ +-# vim:set fileencoding=utf-8 +-from six import PY3 +-if PY3: ++try: + from unittest.mock import patch, PropertyMock +-else: ++except ImportError: + from mock import patch, PropertyMock + + import unittest +diff --git a/tests/devices_test/device_methods_test.py b/tests/devices_test/device_methods_test.py +index f00509be..8a70b5bb 100644 +--- a/tests/devices_test/device_methods_test.py ++++ b/tests/devices_test/device_methods_test.py +@@ -1,9 +1,11 @@ +-import test_compat # pylint: disable=unused-import +- + import six +-from six.moves.mock import patch, Mock, PropertyMock # pylint: disable=no-name-in-module,import-error + import unittest + ++try: ++ from unittest.mock import patch, Mock, PropertyMock ++except ImportError: ++ from mock import patch, PropertyMock ++ + from blivet.devices import StorageDevice + from blivet.devices import DiskDevice, PartitionDevice + from blivet.devices import LVMVolumeGroupDevice, LVMLogicalVolumeDevice +diff --git a/tests/devices_test/device_names_test.py b/tests/devices_test/device_names_test.py +index 2a66f983..ca44d38c 100644 +--- a/tests/devices_test/device_names_test.py ++++ b/tests/devices_test/device_names_test.py +@@ -1,7 +1,9 @@ + # vim:set fileencoding=utf-8 +-import test_compat # pylint: disable=unused-import ++try: ++ from unittest.mock import patch ++except ImportError: ++ from mock import patch + +-from six.moves.mock import patch # pylint: disable=no-name-in-module,import-error + import six + import unittest + +diff --git a/tests/devices_test/device_properties_test.py b/tests/devices_test/device_properties_test.py +index 240ac088..8928707f 100644 +--- a/tests/devices_test/device_properties_test.py ++++ b/tests/devices_test/device_properties_test.py +@@ -1,6 +1,3 @@ +-# vim:set fileencoding=utf-8 +-import test_compat # pylint: disable=unused-import +- + import six + import unittest + +@@ -9,7 +6,10 @@ gi.require_version("BlockDev", "2.0") + + from gi.repository import BlockDev as blockdev + +-from six.moves.mock import Mock, patch # pylint: disable=no-name-in-module,import-error ++try: ++ from unittest.mock import patch, Mock ++except ImportError: ++ from mock import patch, Mock + + import blivet + +diff --git a/tests/devices_test/disk_test.py b/tests/devices_test/disk_test.py +index e9852303..cc8454e1 100644 +--- a/tests/devices_test/disk_test.py ++++ b/tests/devices_test/disk_test.py +@@ -1,7 +1,8 @@ + # pylint: skip-file +-import test_compat +- +-from six.moves.mock import patch ++try: ++ from unittest.mock import patch ++except ImportError: ++ from mock import patch + import unittest + + from blivet.devices import DiskDevice +diff --git a/tests/devices_test/lvm_test.py b/tests/devices_test/lvm_test.py +index 670c91c9..f50933c4 100644 +--- a/tests/devices_test/lvm_test.py ++++ b/tests/devices_test/lvm_test.py +@@ -1,8 +1,9 @@ +-# vim:set fileencoding=utf-8 +-import test_compat # pylint: disable=unused-import ++try: ++ from unittest.mock import patch, PropertyMock ++except ImportError: ++ from mock import patch, PropertyMock + + import six +-from six.moves.mock import patch, PropertyMock # pylint: disable=no-name-in-module,import-error + import unittest + + import blivet +diff --git a/tests/devices_test/partition_test.py b/tests/devices_test/partition_test.py +index 0abd88df..4748dafe 100644 +--- a/tests/devices_test/partition_test.py ++++ b/tests/devices_test/partition_test.py +@@ -1,5 +1,4 @@ + # vim:set fileencoding=utf-8 +-import test_compat # pylint: disable=unused-import + + from collections import namedtuple + import os +@@ -7,7 +6,10 @@ import six + import unittest + import parted + +-from six.moves.mock import Mock, patch # pylint: disable=no-name-in-module,import-error ++try: ++ from unittest.mock import patch, Mock ++except ImportError: ++ from mock import patch, Mock + + from blivet.devices import DiskFile + from blivet.devices import PartitionDevice +diff --git a/tests/devices_test/tags_test.py b/tests/devices_test/tags_test.py +index 1edc37f6..49a2d72e 100644 +--- a/tests/devices_test/tags_test.py ++++ b/tests/devices_test/tags_test.py +@@ -1,6 +1,8 @@ +-import test_compat # pylint: disable=unused-import ++try: ++ from unittest.mock import patch ++except ImportError: ++ from mock import patch + +-from six.moves.mock import patch # pylint: disable=no-name-in-module,import-error + import unittest + + from blivet.devices import DiskDevice, FcoeDiskDevice, iScsiDiskDevice, MultipathDevice, StorageDevice, ZFCPDiskDevice +diff --git a/tests/devicetree_test.py b/tests/devicetree_test.py +index 11f8469d..fbf31c77 100644 +--- a/tests/devicetree_test.py ++++ b/tests/devicetree_test.py +@@ -1,6 +1,8 @@ +-import test_compat # pylint: disable=unused-import ++try: ++ from unittest.mock import patch, Mock, PropertyMock, sentinel ++except ImportError: ++ from mock import patch, Mock, PropertyMock, sentinel + +-from six.moves.mock import Mock, patch, PropertyMock, sentinel # pylint: disable=no-name-in-module,import-error + import os + import six + import unittest +diff --git a/tests/events_test.py b/tests/events_test.py +index 5906b4e2..22666f6d 100644 +--- a/tests/events_test.py ++++ b/tests/events_test.py +@@ -1,6 +1,8 @@ +-import test_compat # pylint: disable=unused-import ++try: ++ from unittest.mock import patch, Mock ++except ImportError: ++ from mock import patch, Mock + +-from six.moves.mock import Mock, patch # pylint: disable=no-name-in-module,import-error + import time + from unittest import TestCase + +diff --git a/tests/formats_test/disklabel_test.py b/tests/formats_test/disklabel_test.py +index 0cfa736d..f514a778 100644 +--- a/tests/formats_test/disklabel_test.py ++++ b/tests/formats_test/disklabel_test.py +@@ -1,7 +1,9 @@ +-import test_compat # pylint: disable=unused-import ++try: ++ from unittest import mock ++except ImportError: ++ import mock + + import parted +-from six.moves import mock # pylint: disable=no-name-in-module,import-error + import unittest + + import blivet +diff --git a/tests/formats_test/luks_test.py b/tests/formats_test/luks_test.py +index be0d50b0..1edbdcb2 100644 +--- a/tests/formats_test/luks_test.py ++++ b/tests/formats_test/luks_test.py +@@ -1,6 +1,8 @@ +-import test_compat # pylint: disable=unused-import ++try: ++ from unittest.mock import patch ++except ImportError: ++ from mock import patch + +-from six.moves.mock import patch # pylint: disable=no-name-in-module,import-error + import unittest + + from blivet.formats.luks import LUKS +diff --git a/tests/formats_test/lvmpv_test.py b/tests/formats_test/lvmpv_test.py +index 792a2f1d..cbd2c419 100644 +--- a/tests/formats_test/lvmpv_test.py ++++ b/tests/formats_test/lvmpv_test.py +@@ -1,5 +1,3 @@ +-import test_compat # pylint: disable=unused-import +- + from blivet.formats.lvmpv import LVMPhysicalVolume + + from blivet.size import Size +diff --git a/tests/formats_test/methods_test.py b/tests/formats_test/methods_test.py +index b2674ea7..2743b7db 100644 +--- a/tests/formats_test/methods_test.py ++++ b/tests/formats_test/methods_test.py +@@ -1,7 +1,9 @@ +-import test_compat # pylint: disable=unused-import ++try: ++ from unittest.mock import patch, sentinel, PropertyMock ++except ImportError: ++ from mock import patch, sentinel, PropertyMock + + import six +-from six.moves.mock import patch, sentinel, PropertyMock # pylint: disable=no-name-in-module,import-error + import unittest + + from blivet.errors import DeviceFormatError +diff --git a/tests/formats_test/selinux_test.py b/tests/formats_test/selinux_test.py +index 02e39011..26df5fe9 100644 +--- a/tests/formats_test/selinux_test.py ++++ b/tests/formats_test/selinux_test.py +@@ -1,9 +1,9 @@ + # pylint: disable=unused-import + import os +-from six import PY3 +-if PY3: ++ ++try: + from unittest.mock import patch, ANY +-else: ++except ImportError: + from mock import patch, ANY + + import unittest +diff --git a/tests/formats_test/swap_test.py b/tests/formats_test/swap_test.py +index 56356144..8968ca15 100644 +--- a/tests/formats_test/swap_test.py ++++ b/tests/formats_test/swap_test.py +@@ -1,5 +1,3 @@ +-import test_compat # pylint: disable=unused-import +- + import six + import unittest + +diff --git a/tests/misc_test.py b/tests/misc_test.py +index 3c8cf344..10ea1320 100644 +--- a/tests/misc_test.py ++++ b/tests/misc_test.py +@@ -1,7 +1,9 @@ + import unittest + +-import test_compat # pylint: disable=unused-import +-from six.moves.mock import patch # pylint: disable=no-name-in-module,import-error ++try: ++ from unittest.mock import patch ++except ImportError: ++ from mock import patch + + import blivet + +diff --git a/tests/partitioning_test.py b/tests/partitioning_test.py +index b7aa5045..9b27f0c0 100644 +--- a/tests/partitioning_test.py ++++ b/tests/partitioning_test.py +@@ -1,6 +1,8 @@ +-import test_compat # pylint: disable=unused-import ++try: ++ from unittest.mock import patch, Mock ++except ImportError: ++ from mock import patch, Mock + +-from six.moves.mock import Mock, patch # pylint: disable=no-name-in-module,import-error + import six + import unittest + +diff --git a/tests/populator_test.py b/tests/populator_test.py +index a7748a9d..2a8532f0 100644 +--- a/tests/populator_test.py ++++ b/tests/populator_test.py +@@ -1,7 +1,9 @@ +-import test_compat # pylint: disable=unused-import ++try: ++ from unittest.mock import call, patch, sentinel, Mock, PropertyMock ++except ImportError: ++ from mock import call, patch, sentinel, Mock, PropertyMock + + import gi +-from six.moves.mock import call, patch, sentinel, Mock, PropertyMock # pylint: disable=no-name-in-module,import-error + import six + import unittest + +diff --git a/tests/storagetestcase.py b/tests/storagetestcase.py +index 1844dec5..1b856914 100644 +--- a/tests/storagetestcase.py ++++ b/tests/storagetestcase.py +@@ -1,6 +1,9 @@ + + import unittest +-from mock import Mock ++try: ++ from unittest.mock import Mock ++except ImportError: ++ from mock import Mock + + import parted + +diff --git a/tests/test_compat.py b/tests/test_compat.py +deleted file mode 100644 +index d0859e24..00000000 +--- a/tests/test_compat.py ++++ /dev/null +@@ -1,38 +0,0 @@ +-# test_compat.py +-# Python (2 -v- 3) compatibility functions. +-# +-# Copyright (C) 2017 Red Hat, Inc. +-# +-# This copyrighted material is made available to anyone wishing to use, +-# modify, copy, or redistribute it subject to the terms and conditions of +-# the GNU Lesser General Public License v.2, or (at your option) any later +-# version. This program is distributed in the hope that it will be useful, +-# but WITHOUT ANY WARRANTY expressed or implied, including the implied +-# warranties of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See +-# the GNU Lesser General Public License for more details. You should have +-# received a copy of the GNU Lesser General Public License along with this +-# program; if not, write to the Free Software Foundation, Inc., 51 Franklin +-# Street, Fifth Floor, Boston, MA 02110-1301, USA. Any Red Hat trademarks +-# that are incorporated in the source code or documentation are not subject +-# to the GNU Lesser General Public License and may only be used or +-# replicated with the express permission of Red Hat, Inc. +-# +-# Red Hat Author(s): David Lehman +-# +- +-import six as _six +- +-mock_move = _six.MovedModule('mock', 'mock', 'unittest.mock') +- +- +-def add_move(mod): +- _six.add_move(mod) +- # https://bitbucket.org/gutworth/six/issues/116/enable-importing-from-within-custom +- _six._importer._add_module(mod, "moves." + mod.name) +- +- +-def setup(): +- add_move(mock_move) +- +- +-setup() +diff --git a/tests/udev_test.py b/tests/udev_test.py +index f9b10620..569a144e 100644 +--- a/tests/udev_test.py ++++ b/tests/udev_test.py +@@ -1,6 +1,10 @@ + + import unittest +-import mock ++ ++try: ++ from unittest import mock ++except ImportError: ++ import mock + + from udev_data import raid_data + +diff --git a/tests/unsupported_disklabel_test.py b/tests/unsupported_disklabel_test.py +index f5b24779..38055333 100644 +--- a/tests/unsupported_disklabel_test.py ++++ b/tests/unsupported_disklabel_test.py +@@ -1,7 +1,8 @@ +-# vim:set fileencoding=utf-8 +-import test_compat # pylint: disable=unused-import ++try: ++ from unittest.mock import patch, sentinel, DEFAULT ++except ImportError: ++ from mock import patch, sentinel, DEFAULT + +-from six.moves.mock import patch, sentinel, DEFAULT # pylint: disable=no-name-in-module,import-error + import six + import unittest + +diff --git a/tests/util_test.py b/tests/util_test.py +index 853b6166..b4f82c1b 100644 +--- a/tests/util_test.py ++++ b/tests/util_test.py +@@ -1,7 +1,9 @@ + # pylint: skip-file +-import test_compat ++try: ++ from unittest import mock ++except ImportError: ++ import mock + +-from six.moves import mock + import os + import six + import tempfile +-- +2.31.1 + diff --git a/SOURCES/0006-Fix-util.virt_detect-on-Xen.patch b/SOURCES/0006-Fix-util.virt_detect-on-Xen.patch new file mode 100644 index 0000000..4c1399a --- /dev/null +++ b/SOURCES/0006-Fix-util.virt_detect-on-Xen.patch @@ -0,0 +1,23 @@ +From d609cebba48744c97ac7e0461f8827ab63198026 Mon Sep 17 00:00:00 2001 +From: Vojtech Trefny +Date: Thu, 10 Jun 2021 16:58:42 +0200 +Subject: [PATCH] Fix util.virt_detect on Xen + +Xen is apparently still alive so we should return True for it too. +--- + blivet/util.py | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/blivet/util.py b/blivet/util.py +index 3bebb003..af60210b 100644 +--- a/blivet/util.py ++++ b/blivet/util.py +@@ -1130,4 +1130,4 @@ def detect_virt(): + except (safe_dbus.DBusCallError, safe_dbus.DBusPropertyError): + return False + else: +- return vm[0] in ('qemu', 'kvm') ++ return vm[0] in ('qemu', 'kvm', 'xen') +-- +2.31.1 + diff --git a/SOURCES/0007-Fix-activating-old-style-LVM-snapshots.patch b/SOURCES/0007-Fix-activating-old-style-LVM-snapshots.patch new file mode 100644 index 0000000..e07ea1e --- /dev/null +++ b/SOURCES/0007-Fix-activating-old-style-LVM-snapshots.patch @@ -0,0 +1,35 @@ +From 8ece3da18b1abb89320d02f4475002e6a3ed7875 Mon Sep 17 00:00:00 2001 +From: Vojtech Trefny +Date: Thu, 20 May 2021 13:40:26 +0200 +Subject: [PATCH] Fix activating old style LVM snapshots + +The old style snapshots are activated together with the origin LV +so we need to make sure it is activated to be able to remove the +snapshot or its format. + +Resolves: rhbz#1961739 +--- + blivet/devices/lvm.py | 10 +++++++--- + 1 file changed, 7 insertions(+), 3 deletions(-) + +diff --git a/blivet/devices/lvm.py b/blivet/devices/lvm.py +index a55515fcb..fb57804d9 100644 +--- a/blivet/devices/lvm.py ++++ b/blivet/devices/lvm.py +@@ -1461,9 +1461,13 @@ def _set_format(self, fmt): # pylint: disable=unused-argument + self._update_format_from_origin() + + @old_snapshot_specific +- def setup(self, orig=False): +- # the old snapshot cannot be setup and torn down +- pass ++ def setup(self, orig=False): # pylint: disable=unused-argument ++ # the old snapshot is activated together with the origin ++ if self.origin and not self.origin.status: ++ try: ++ self.origin.setup() ++ except blockdev.LVMError as lvmerr: ++ log.error("failed to activate origin LV: %s", lvmerr) + + @old_snapshot_specific + def teardown(self, recursive=False): diff --git a/SOURCES/0008-Fix-resolving-devices-with-names-that-look-like-BIOS.patch b/SOURCES/0008-Fix-resolving-devices-with-names-that-look-like-BIOS.patch new file mode 100644 index 0000000..28c7351 --- /dev/null +++ b/SOURCES/0008-Fix-resolving-devices-with-names-that-look-like-BIOS.patch @@ -0,0 +1,75 @@ +From 344e624f91010b6041c22ee8a24c9305b82af969 Mon Sep 17 00:00:00 2001 +From: Vojtech Trefny +Date: Tue, 18 May 2021 12:54:02 +0200 +Subject: [PATCH] Fix resolving devices with names that look like BIOS drive + number + +A RAID array named "10" will not be resolved because we try to +resolve it using EDD data and after this lookup fails, we don't +try the name. + +Resolves: rhbz#1960798 +--- + blivet/devicetree.py | 18 +++++++++--------- + tests/devicetree_test.py | 4 ++++ + 2 files changed, 13 insertions(+), 9 deletions(-) + +diff --git a/blivet/devicetree.py b/blivet/devicetree.py +index 88e9f0e5..f4ae1968 100644 +--- a/blivet/devicetree.py ++++ b/blivet/devicetree.py +@@ -634,20 +634,20 @@ class DeviceTreeBase(object): + (label.startswith("'") and label.endswith("'"))): + label = label[1:-1] + device = self.labels.get(label) +- elif re.match(r'(0x)?[A-Fa-f0-9]{2}(p\d+)?$', devspec): +- # BIOS drive number +- (drive, _p, partnum) = devspec.partition("p") +- spec = int(drive, 16) +- for (edd_name, edd_number) in self.edd_dict.items(): +- if edd_number == spec: +- device = self.get_device_by_name(edd_name + partnum) +- break + elif options and "nodev" in options.split(","): + device = self.get_device_by_name(devspec) + if not device: + device = self.get_device_by_path(devspec) + else: +- if not devspec.startswith("/dev/"): ++ if re.match(r'(0x)?[A-Fa-f0-9]{2}(p\d+)?$', devspec): ++ # BIOS drive number ++ (drive, _p, partnum) = devspec.partition("p") ++ spec = int(drive, 16) ++ for (edd_name, edd_number) in self.edd_dict.items(): ++ if edd_number == spec: ++ device = self.get_device_by_name(edd_name + partnum) ++ break ++ if not device and not devspec.startswith("/dev/"): + device = self.get_device_by_name(devspec) + if not device: + devspec = "/dev/" + devspec +diff --git a/tests/devicetree_test.py b/tests/devicetree_test.py +index 11f8469d..b033343d 100644 +--- a/tests/devicetree_test.py ++++ b/tests/devicetree_test.py +@@ -49,6 +49,9 @@ class DeviceTreeTestCase(unittest.TestCase): + dev3 = StorageDevice("sdp2", exists=True) + dt._add_device(dev3) + ++ dev4 = StorageDevice("10", exists=True) ++ dt._add_device(dev4) ++ + dt.edd_dict.update({"dev1": 0x81, + "dev2": 0x82}) + +@@ -62,6 +65,7 @@ class DeviceTreeTestCase(unittest.TestCase): + self.assertEqual(dt.resolve_device("0x82"), dev2) + + self.assertEqual(dt.resolve_device(dev3.name), dev3) ++ self.assertEqual(dt.resolve_device(dev4.name), dev4) + + def test_device_name(self): + # check that devicetree.names property contains all device's names +-- +2.31.1 + diff --git a/SOURCES/0009-Do-not-set-chunk-size-for-RAID1.patch b/SOURCES/0009-Do-not-set-chunk-size-for-RAID1.patch new file mode 100644 index 0000000..2b40cfa --- /dev/null +++ b/SOURCES/0009-Do-not-set-chunk-size-for-RAID1.patch @@ -0,0 +1,151 @@ +From dc1e2fe7783748528cac2f7aa516c89d1959b052 Mon Sep 17 00:00:00 2001 +From: Vojtech Trefny +Date: Thu, 29 Jul 2021 14:44:22 +0200 +Subject: [PATCH] Do not set chunk size for RAID 1 + +Setting chunk size for RAID 1 doesn't make sense and latest +mdadm started returning error instead of ignoring the --chunk +option when creating an array. + +Resolves: rhbz#1987170 +--- + blivet/devicelibs/raid.py | 12 ++++++++++ + blivet/devices/md.py | 15 ++++++++++--- + tests/devices_test/md_test.py | 41 +++++++++++++++++++++++++++++++++-- + 3 files changed, 63 insertions(+), 5 deletions(-) + +diff --git a/blivet/devicelibs/raid.py b/blivet/devicelibs/raid.py +index 19c3fae98..a9e241c7a 100644 +--- a/blivet/devicelibs/raid.py ++++ b/blivet/devicelibs/raid.py +@@ -462,6 +462,18 @@ def _pad(self, size, chunk_size): + def _get_recommended_stride(self, member_count): + return None + ++ def get_size(self, member_sizes, num_members=None, chunk_size=None, superblock_size_func=None): ++ if not member_sizes: ++ return Size(0) ++ ++ if num_members is None: ++ num_members = len(member_sizes) ++ ++ min_size = min(member_sizes) ++ superblock_size = superblock_size_func(min_size) ++ min_data_size = self._trim(min_size - superblock_size, chunk_size) ++ return self.get_net_array_size(num_members, min_data_size) ++ + + RAID1 = RAID1() + ALL_LEVELS.add_raid_level(RAID1) +diff --git a/blivet/devices/md.py b/blivet/devices/md.py +index 69eee93a5..d1a2faf1f 100644 +--- a/blivet/devices/md.py ++++ b/blivet/devices/md.py +@@ -138,7 +138,7 @@ def __init__(self, name, level=None, major=None, minor=None, size=None, + if self.exists: + self._chunk_size = self.read_chunk_size() + else: +- self._chunk_size = chunk_size or mdraid.MD_CHUNK_SIZE ++ self.chunk_size = chunk_size or Size(0) + + if not self.exists and not isinstance(metadata_version, str): + self.metadata_version = "default" +@@ -208,8 +208,14 @@ def sector_size(self): + + @property + def chunk_size(self): +- if self.exists and self._chunk_size == Size(0): +- self._chunk_size = self.read_chunk_size() ++ if self._chunk_size == Size(0): ++ if self.exists: ++ return self.read_chunk_size() ++ else: ++ if self.level == raid.RAID1: ++ return self._chunk_size ++ else: ++ return mdraid.MD_CHUNK_SIZE + return self._chunk_size + + @chunk_size.setter +@@ -223,6 +229,9 @@ def chunk_size(self, newsize): + if self.exists: + raise ValueError("cannot set chunk size for an existing device") + ++ if self.level == raid.RAID1 and newsize != Size(0): ++ raise ValueError("specifying chunk size is not allowed for raid1") ++ + self._chunk_size = newsize + + def read_chunk_size(self): +diff --git a/tests/devices_test/md_test.py b/tests/devices_test/md_test.py +index 46df76d3d..47a0fa0cc 100644 +--- a/tests/devices_test/md_test.py ++++ b/tests/devices_test/md_test.py +@@ -1,6 +1,11 @@ + import six + import unittest + ++try: ++ from unittest.mock import patch ++except ImportError: ++ from mock import patch ++ + import blivet + + from blivet.devices import StorageDevice +@@ -27,9 +32,27 @@ def test_chunk_size1(self): + raid_array = MDRaidArrayDevice(name="raid", level="raid0", member_devices=2, + total_devices=2, parents=[member1, member2]) + +- # no chunk_size specified -- default value ++ # no chunk_size specified and RAID0 -- default value + self.assertEqual(raid_array.chunk_size, mdraid.MD_CHUNK_SIZE) + ++ with patch("blivet.devices.md.blockdev.md.create") as md_create: ++ raid_array._create() ++ md_create.assert_called_with("/dev/md/raid", "raid0", ["/dev/member1", "/dev/member2"], ++ 0, version="default", bitmap=False, ++ chunk_size=mdraid.MD_CHUNK_SIZE) ++ ++ raid_array = MDRaidArrayDevice(name="raid", level="raid1", member_devices=2, ++ total_devices=2, parents=[member1, member2]) ++ ++ # no chunk_size specified and RAID1 -- no chunk size set (0) ++ self.assertEqual(raid_array.chunk_size, Size(0)) ++ ++ with patch("blivet.devices.md.blockdev.md.create") as md_create: ++ raid_array._create() ++ md_create.assert_called_with("/dev/md/raid", "raid1", ["/dev/member1", "/dev/member2"], ++ 0, version="default", bitmap=True, ++ chunk_size=0) ++ + def test_chunk_size2(self): + + member1 = StorageDevice("member1", fmt=blivet.formats.get_format("mdmember"), +@@ -40,11 +63,25 @@ def test_chunk_size2(self): + raid_array = MDRaidArrayDevice(name="raid", level="raid0", member_devices=2, + total_devices=2, parents=[member1, member2], + chunk_size=Size("1024 KiB")) +- + self.assertEqual(raid_array.chunk_size, Size("1024 KiB")) + ++ # for raid0 setting chunk_size = 0 means "default" ++ raid_array.chunk_size = Size(0) ++ self.assertEqual(raid_array.chunk_size, mdraid.MD_CHUNK_SIZE) ++ + with six.assertRaisesRegex(self, ValueError, "new chunk size must be of type Size"): + raid_array.chunk_size = 1 + + with six.assertRaisesRegex(self, ValueError, "new chunk size must be multiple of 4 KiB"): + raid_array.chunk_size = Size("5 KiB") ++ ++ with six.assertRaisesRegex(self, ValueError, "specifying chunk size is not allowed for raid1"): ++ MDRaidArrayDevice(name="raid", level="raid1", member_devices=2, ++ total_devices=2, parents=[member1, member2], ++ chunk_size=Size("1024 KiB")) ++ ++ raid_array = MDRaidArrayDevice(name="raid", level="raid1", member_devices=2, ++ total_devices=2, parents=[member1, member2]) ++ ++ with six.assertRaisesRegex(self, ValueError, "specifying chunk size is not allowed for raid1"): ++ raid_array.chunk_size = Size("512 KiB") diff --git a/SOURCES/0010-Fix-running-tests-in-gating.patch b/SOURCES/0010-Fix-running-tests-in-gating.patch new file mode 100644 index 0000000..70bd5f8 --- /dev/null +++ b/SOURCES/0010-Fix-running-tests-in-gating.patch @@ -0,0 +1,231 @@ +From 8dbb92d692db9cbfbca0c82a1ed10a0492208534 Mon Sep 17 00:00:00 2001 +From: Vojtech Trefny +Date: Wed, 4 Aug 2021 13:00:53 +0200 +Subject: [PATCH 1/3] edd_test: Locate the edd_data based on the test file + location + +We can't use the blivet.edd module location when running tests +against installed version of blivet. +--- + tests/devicelibs_test/edd_test.py | 5 ++--- + 1 file changed, 2 insertions(+), 3 deletions(-) + +diff --git a/tests/devicelibs_test/edd_test.py b/tests/devicelibs_test/edd_test.py +index 21bbcffc4..0d0824e6b 100644 +--- a/tests/devicelibs_test/edd_test.py ++++ b/tests/devicelibs_test/edd_test.py +@@ -5,7 +5,6 @@ + + import unittest + import os +-import inspect + import logging + import copy + +@@ -114,9 +113,9 @@ def root(self, name): + name = name[:-1] + if name.startswith("/"): + name = name[1:] +- dirname = os.path.dirname(inspect.getfile(edd)) ++ dirname = os.path.abspath(os.path.dirname(__file__)) + return os.path.join(dirname, +- "../../tests/devicelibs_test/edd_data/", ++ "edd_data/", + name) + + def edd_debug(self, *args): + +From 924bc805f692b0f050a8a8b8187769f36aea059f Mon Sep 17 00:00:00 2001 +From: Vojtech Trefny +Date: Wed, 4 Aug 2021 13:02:08 +0200 +Subject: [PATCH 2/3] tests: Allow running tests without the tests directory in + PYTHONPATH + +When running the tests against installed version of blivet, the +"tests" directory is not in PYTHONPATH so we need to import all +helper modules using relative path. +--- + tests/action_test.py | 2 +- + tests/devicelibs_test/edd_test.py | 2 +- + tests/{ => devicelibs_test}/lib.py | 0 + tests/formats_test/fs_test.py | 2 +- + tests/formats_test/fslabeling.py | 2 +- + tests/formats_test/fstesting.py | 2 +- + tests/formats_test/fsuuid.py | 2 +- + tests/formats_test/labeling_test.py | 2 +- + tests/{ => formats_test}/loopbackedtestcase.py | 0 + tests/formats_test/luks_test.py | 2 +- + tests/formats_test/lvmpv_test.py | 2 +- + tests/partitioning_test.py | 2 +- + 12 files changed, 10 insertions(+), 10 deletions(-) + rename tests/{ => devicelibs_test}/lib.py (100%) + rename tests/{ => formats_test}/loopbackedtestcase.py (100%) + +diff --git a/tests/action_test.py b/tests/action_test.py +index f60cf5d7e..8509ce35a 100644 +--- a/tests/action_test.py ++++ b/tests/action_test.py +@@ -5,7 +5,7 @@ + except ImportError: + from mock import Mock + +-from tests.storagetestcase import StorageTestCase ++from storagetestcase import StorageTestCase + import blivet + from blivet.formats import get_format + from blivet.size import Size +diff --git a/tests/devicelibs_test/edd_test.py b/tests/devicelibs_test/edd_test.py +index 0d0824e6b..0db1fd16e 100644 +--- a/tests/devicelibs_test/edd_test.py ++++ b/tests/devicelibs_test/edd_test.py +@@ -10,7 +10,7 @@ + + from blivet import arch + from blivet.devicelibs import edd +-from tests import lib ++from . import lib + + + class FakeDevice(object): +diff --git a/tests/lib.py b/tests/devicelibs_test/lib.py +similarity index 100% +rename from tests/lib.py +rename to tests/devicelibs_test/lib.py +diff --git a/tests/formats_test/fs_test.py b/tests/formats_test/fs_test.py +index ab3499a76..bd6433707 100644 +--- a/tests/formats_test/fs_test.py ++++ b/tests/formats_test/fs_test.py +@@ -10,7 +10,7 @@ + from blivet.formats import get_format + from blivet.devices import PartitionDevice, DiskDevice + +-from tests import loopbackedtestcase ++from . import loopbackedtestcase + + from . import fstesting + +diff --git a/tests/formats_test/fslabeling.py b/tests/formats_test/fslabeling.py +index fbb28eee7..0e0dc2612 100644 +--- a/tests/formats_test/fslabeling.py ++++ b/tests/formats_test/fslabeling.py +@@ -2,7 +2,7 @@ + import abc + import six + +-from tests import loopbackedtestcase ++from . import loopbackedtestcase + from blivet.errors import FSError, FSReadLabelError + from blivet.size import Size + +diff --git a/tests/formats_test/fstesting.py b/tests/formats_test/fstesting.py +index 86b2a1168..e34584d88 100644 +--- a/tests/formats_test/fstesting.py ++++ b/tests/formats_test/fstesting.py +@@ -5,7 +5,7 @@ + import os + import tempfile + +-from tests import loopbackedtestcase ++from . import loopbackedtestcase + from blivet.errors import FSError, FSResizeError, DeviceFormatError + from blivet.size import Size, ROUND_DOWN + from blivet.formats import fs +diff --git a/tests/formats_test/fsuuid.py b/tests/formats_test/fsuuid.py +index c80039457..16aa19a66 100644 +--- a/tests/formats_test/fsuuid.py ++++ b/tests/formats_test/fsuuid.py +@@ -3,7 +3,7 @@ + import six + from unittest import skipIf + +-from tests import loopbackedtestcase ++from . import loopbackedtestcase + from blivet.errors import FSError, FSWriteUUIDError + from blivet.size import Size + from blivet.util import capture_output +diff --git a/tests/formats_test/labeling_test.py b/tests/formats_test/labeling_test.py +index e26cb7df1..d24e66191 100644 +--- a/tests/formats_test/labeling_test.py ++++ b/tests/formats_test/labeling_test.py +@@ -1,10 +1,10 @@ + import unittest + +-from tests import loopbackedtestcase + from blivet.formats import device_formats + import blivet.formats.fs as fs + import blivet.formats.swap as swap + ++from . import loopbackedtestcase + from . import fslabeling + + +diff --git a/tests/loopbackedtestcase.py b/tests/formats_test/loopbackedtestcase.py +similarity index 100% +rename from tests/loopbackedtestcase.py +rename to tests/formats_test/loopbackedtestcase.py +diff --git a/tests/formats_test/luks_test.py b/tests/formats_test/luks_test.py +index 1edbdcb28..5f25f0988 100644 +--- a/tests/formats_test/luks_test.py ++++ b/tests/formats_test/luks_test.py +@@ -9,7 +9,7 @@ + + from blivet.size import Size + +-from tests import loopbackedtestcase ++from . import loopbackedtestcase + + + class LUKSTestCase(loopbackedtestcase.LoopBackedTestCase): +diff --git a/tests/formats_test/lvmpv_test.py b/tests/formats_test/lvmpv_test.py +index cbd2c4195..cdc33ec4d 100644 +--- a/tests/formats_test/lvmpv_test.py ++++ b/tests/formats_test/lvmpv_test.py +@@ -2,7 +2,7 @@ + + from blivet.size import Size + +-from tests import loopbackedtestcase ++from . import loopbackedtestcase + + + class LVMPVTestCase(loopbackedtestcase.LoopBackedTestCase): +diff --git a/tests/partitioning_test.py b/tests/partitioning_test.py +index 9b27f0c0d..e7b7aa375 100644 +--- a/tests/partitioning_test.py ++++ b/tests/partitioning_test.py +@@ -31,7 +31,7 @@ + + from blivet.errors import PartitioningError + +-from tests.imagebackedtestcase import ImageBackedTestCase ++from imagebackedtestcase import ImageBackedTestCase + from blivet.blivet import Blivet + from blivet.util import sparsetmpfile + from blivet.formats import get_format + +From 99385bd67ac944c43bc77f4b5465c672203e2679 Mon Sep 17 00:00:00 2001 +From: Vojtech Trefny +Date: Fri, 6 Aug 2021 14:51:01 +0200 +Subject: [PATCH 3/3] tests: Print version and blivet location when running + tests + +--- + tests/run_tests.py | 5 +++++ + 1 file changed, 5 insertions(+) + +diff --git a/tests/run_tests.py b/tests/run_tests.py +index 32e3f2d3a..8ad8b61ad 100644 +--- a/tests/run_tests.py ++++ b/tests/run_tests.py +@@ -32,6 +32,11 @@ + + testdir = os.path.abspath(os.path.dirname(__file__)) + ++ import blivet ++ print("Running tests with Blivet %s from %s" % (blivet.__version__, ++ os.path.abspath(os.path.dirname(blivet.__file__))), ++ file=sys.stderr) ++ + if args.testname: + for n in args.testname: + suite.addTests(unittest.TestLoader().loadTestsFromName(n)) diff --git a/SOURCES/0011-Tell-LVM-to-ignore-the-new-devices-file-for-now.patch b/SOURCES/0011-Tell-LVM-to-ignore-the-new-devices-file-for-now.patch new file mode 100644 index 0000000..89010bd --- /dev/null +++ b/SOURCES/0011-Tell-LVM-to-ignore-the-new-devices-file-for-now.patch @@ -0,0 +1,68 @@ +From a977e8389a09615615dc76dee8aaaea1cc0ac54b Mon Sep 17 00:00:00 2001 +From: Vojtech Trefny +Date: Thu, 22 Jul 2021 09:26:54 +0200 +Subject: [PATCH 1/2] Tell LVM to ignore the new devices file for now + +We currently don't support working with the devices file and it's +not possible to use lvm.conf filters together with the devices +file so we need to tell LVM to ignore it until we can support it. +--- + blivet/devicelibs/lvm.py | 4 ++++ + blivet/tasks/availability.py | 1 + + 2 files changed, 5 insertions(+) + +diff --git a/blivet/devicelibs/lvm.py b/blivet/devicelibs/lvm.py +index d56a76edc..989ecccaf 100644 +--- a/blivet/devicelibs/lvm.py ++++ b/blivet/devicelibs/lvm.py +@@ -91,6 +91,10 @@ def _set_global_config(): + if filter_string: + devices_string += " %s" % filter_string + ++ # for now ignore the LVM devices file and rely on our filters ++ if availability.LVMDEVICES.available: ++ devices_string += " use_devicesfile=0" ++ + # devices_string can have (inside the brackets) "dir", "scan", + # "preferred_names", "filter", "cache_dir", "write_cache_state", + # "types", "sysfs_scan", "md_component_detection". see man lvm.conf. +diff --git a/blivet/tasks/availability.py b/blivet/tasks/availability.py +index 1fd805901..5d3e295da 100644 +--- a/blivet/tasks/availability.py ++++ b/blivet/tasks/availability.py +@@ -451,6 +451,7 @@ def available_resource(name): + HFORMAT_APP = application("hformat") + JFSTUNE_APP = application("jfs_tune") + KPARTX_APP = application("kpartx") ++LVMDEVICES = application("lvmdevices") + MKDOSFS_APP = application("mkdosfs") + MKDOSFS_NEW_APP = application_by_version("mkdosfs", DOSFSTOOLS_VERSION) + MKE2FS_APP = application_by_version("mke2fs", E2FSPROGS_VERSION) + +From 08c137b5c98b24a9ba3df21f04cd20120c61198c Mon Sep 17 00:00:00 2001 +From: Vojtech Trefny +Date: Thu, 22 Jul 2021 11:33:46 +0200 +Subject: [PATCH 2/2] Make sure LVM config is updated before running pvcreate + +Our internal "global" LVM config is set during reset() but we have +test cases that run pvcreate without running reset() first so we +need to make sure to update the global config before running it +because the config string now also controls whether the new LVM +devices file will be used or not. +--- + blivet/formats/lvmpv.py | 2 ++ + 1 file changed, 2 insertions(+) + +diff --git a/blivet/formats/lvmpv.py b/blivet/formats/lvmpv.py +index e4182adb2..ea84e9e4b 100644 +--- a/blivet/formats/lvmpv.py ++++ b/blivet/formats/lvmpv.py +@@ -125,6 +125,8 @@ def _create(self, **kwargs): + log_method_call(self, device=self.device, + type=self.type, status=self.status) + ++ lvm._set_global_config() ++ + ea_yes = blockdev.ExtraArg.new("-y", "") + blockdev.lvm.pvcreate(self.device, data_alignment=self.data_alignment, extra=[ea_yes]) + diff --git a/SOURCES/0012-Improve-error-message-printed-for-missing-dependecie.patch b/SOURCES/0012-Improve-error-message-printed-for-missing-dependecie.patch new file mode 100644 index 0000000..f267c3c --- /dev/null +++ b/SOURCES/0012-Improve-error-message-printed-for-missing-dependecie.patch @@ -0,0 +1,65 @@ +From 46335861073882b7162221fc0995dc1df3c67749 Mon Sep 17 00:00:00 2001 +From: Vojtech Trefny +Date: Fri, 6 Aug 2021 16:37:51 +0200 +Subject: [PATCH] Improve error message printed for missing dependecies + +The existing error message can be confusing for people that don't +know internals of blivet and libblockdev and the information what +is actually broken or not installed on the system is missing +completely. Example for LVM VDO with missing kvdo module: + +Before: + +device type lvmvdopool requires unavailable_dependencies: +libblockdev lvm plugin (vdo technology) + +After: + +device type lvmvdopool requires unavailable_dependencies: +libblockdev lvm plugin (vdo technology): +libblockdev plugin lvm is loaded but some required technologies +are not available (BD_LVM_TECH_VDO: Kernel module 'kvdo' not +available) +--- + blivet/deviceaction.py | 2 +- + blivet/tasks/availability.py | 4 ++-- + 2 files changed, 3 insertions(+), 3 deletions(-) + +diff --git a/blivet/deviceaction.py b/blivet/deviceaction.py +index 56e29215..0458e4be 100644 +--- a/blivet/deviceaction.py ++++ b/blivet/deviceaction.py +@@ -173,7 +173,7 @@ class DeviceAction(util.ObjectID): + def _check_device_dependencies(self): + unavailable_dependencies = self.device.unavailable_dependencies + if unavailable_dependencies: +- dependencies_str = ", ".join(str(d) for d in unavailable_dependencies) ++ dependencies_str = ", ".join("%s:\n%s" % (str(d), ", ".join(d.availability_errors)) for d in unavailable_dependencies) + raise DependencyError("device type %s requires unavailable_dependencies: %s" % (self.device.type, dependencies_str)) + + def apply(self): +diff --git a/blivet/tasks/availability.py b/blivet/tasks/availability.py +index 1fd80590..1537f3f5 100644 +--- a/blivet/tasks/availability.py ++++ b/blivet/tasks/availability.py +@@ -224,7 +224,7 @@ class BlockDevMethod(Method): + try: + self._tech_info.check_fn(tech, mode) + except GLib.GError as e: +- errors.append(str(e)) ++ errors.append("%s: %s" % (tech.value_name, e.message)) + return errors + + def availability_errors(self, resource): +@@ -242,7 +242,7 @@ class BlockDevMethod(Method): + tech_missing = self._check_technologies() + if tech_missing: + return ["libblockdev plugin %s is loaded but some required " +- "technologies are not available:\n%s" % (self._tech_info.plugin_name, tech_missing)] ++ "technologies are not available (%s)" % (self._tech_info.plugin_name, "; ".join(tech_missing))] + else: + return [] + +-- +2.31.1 + diff --git a/SOURCES/0013-Use-bigger-chunk-size-for-thinpools-bigger-than-15.8.patch b/SOURCES/0013-Use-bigger-chunk-size-for-thinpools-bigger-than-15.8.patch new file mode 100644 index 0000000..68ab727 --- /dev/null +++ b/SOURCES/0013-Use-bigger-chunk-size-for-thinpools-bigger-than-15.8.patch @@ -0,0 +1,90 @@ +From 06cafbbbbff0aae3634eb2908d25d0dc46c2048b Mon Sep 17 00:00:00 2001 +From: Vojtech Trefny +Date: Tue, 9 Nov 2021 15:52:48 +0100 +Subject: [PATCH] Use bigger chunk size for thinpools bigger than ~15.88 TiB + +With our default chunk size of 64 KiB we cannot create bigger +thin pools than 15.88 TiB. Unfortunately we need to specify chunk +size to be able to calculate thin metadata properly so we can't +simply leave this to LVM to determine the correct chunk size. +--- + blivet/devicelibs/lvm.py | 11 +++++++++++ + blivet/devices/lvm.py | 6 +++--- + tests/devices_test/lvm_test.py | 11 +++++++++++ + 3 files changed, 25 insertions(+), 3 deletions(-) + +diff --git a/blivet/devicelibs/lvm.py b/blivet/devicelibs/lvm.py +index d56a76ed..cb6f655e 100644 +--- a/blivet/devicelibs/lvm.py ++++ b/blivet/devicelibs/lvm.py +@@ -20,6 +20,7 @@ + # Author(s): Dave Lehman + # + ++import math + import os + import re + +@@ -51,6 +52,7 @@ LVM_THINP_MIN_METADATA_SIZE = Size("2 MiB") + LVM_THINP_MAX_METADATA_SIZE = Size("16 GiB") + LVM_THINP_MIN_CHUNK_SIZE = Size("64 KiB") + LVM_THINP_MAX_CHUNK_SIZE = Size("1 GiB") ++LVM_THINP_ADDRESSABLE_CHUNK_SIZE = Size("17455015526400 B") # 15.88 TiB + + raid_levels = raid.RAIDLevels(["linear", "striped", "raid1", "raid4", "raid5", "raid6", "raid10"]) + raid_seg_types = list(itertools.chain.from_iterable([level.names for level in raid_levels if level.name != "linear"])) +@@ -225,3 +227,12 @@ def is_lvm_name_valid(name): + return False + + return True ++ ++ ++def recommend_thpool_chunk_size(thpool_size): ++ # calculation of the recommended chunk size by LVM is so complicated that we ++ # can't really replicate it, but we know that 64 KiB chunk size gives us ++ # upper limit of ~15.88 TiB so we will just add 64 KiB to the chunk size ++ # for every ~15.88 TiB of thinpool data size ++ return min(math.ceil(thpool_size / LVM_THINP_ADDRESSABLE_CHUNK_SIZE) * LVM_THINP_MIN_CHUNK_SIZE, ++ LVM_THINP_MAX_CHUNK_SIZE) +diff --git a/blivet/devices/lvm.py b/blivet/devices/lvm.py +index 51d785d9..c61eeb4b 100644 +--- a/blivet/devices/lvm.py ++++ b/blivet/devices/lvm.py +@@ -1634,9 +1634,9 @@ class LVMThinPoolMixin(object): + return + + # we need to know chunk size to calculate recommended metadata size +- if self._chunk_size == 0: +- self._chunk_size = Size(blockdev.LVM_DEFAULT_CHUNK_SIZE) +- log.debug("Using default chunk size: %s", self._chunk_size) ++ if self._chunk_size == 0 or enforced: ++ self._chunk_size = lvm.recommend_thpool_chunk_size(self._size) ++ log.debug("Using recommended chunk size: %s", self._chunk_size) + + old_md_size = self._metadata_size + old_pmspare_size = self.vg.pmspare_size +diff --git a/tests/devices_test/lvm_test.py b/tests/devices_test/lvm_test.py +index 4156d0bf..336c5b99 100644 +--- a/tests/devices_test/lvm_test.py ++++ b/tests/devices_test/lvm_test.py +@@ -442,6 +442,17 @@ class LVMDeviceTest(unittest.TestCase): + self.assertFalse(pool.exists) + self.assertTrue(lvm.lvremove.called) + ++ def test_lvmthinpool_chunk_size(self): ++ pv = StorageDevice("pv1", fmt=blivet.formats.get_format("lvmpv"), ++ size=Size("100 TiB")) ++ vg = LVMVolumeGroupDevice("testvg", parents=[pv]) ++ pool = LVMLogicalVolumeDevice("pool1", parents=[vg], size=Size("500 MiB"), seg_type="thin-pool") ++ self.assertEqual(pool.chunk_size, Size("64 KiB")) ++ ++ pool.size = Size("16 TiB") ++ pool.autoset_md_size(enforced=True) ++ self.assertEqual(pool.chunk_size, Size("128 KiB")) ++ + + class TypeSpecificCallsTest(unittest.TestCase): + def test_type_specific_calls(self): +-- +2.31.1 + diff --git a/SOURCES/0014-LVM-devices-file-support.patch b/SOURCES/0014-LVM-devices-file-support.patch new file mode 100644 index 0000000..5baca1a --- /dev/null +++ b/SOURCES/0014-LVM-devices-file-support.patch @@ -0,0 +1,774 @@ +From 43c5a6ef094e5f333a6dd47c467a1516488e2097 Mon Sep 17 00:00:00 2001 +From: Vojtech Trefny +Date: Mon, 24 May 2021 13:35:39 +0200 +Subject: [PATCH 1/7] Remove action device from LVM reject list + +Because the device doesn't depend on itself the existing code +won't remove the device we are trying to modify from the list. + +Resolves: rhbz#1955942 +--- + blivet/actionlist.py | 1 + + 1 file changed, 1 insertion(+) + +diff --git a/blivet/actionlist.py b/blivet/actionlist.py +index d03e32b9..2de3fed3 100644 +--- a/blivet/actionlist.py ++++ b/blivet/actionlist.py +@@ -260,6 +260,7 @@ class ActionList(object): + log.debug("action: %s", action) + + # Remove lvm filters for devices we are operating on ++ lvm.lvm_cc_removeFilterRejectRegexp(action.device.name) + for device in (d for d in devices if d.depends_on(action.device)): + lvm.lvm_cc_removeFilterRejectRegexp(device.name) + +-- +2.31.1 + + +From 2db8aa0aa6ea03c182f7e8e08cd1371ded13b71c Mon Sep 17 00:00:00 2001 +From: Vojtech Trefny +Date: Mon, 24 May 2021 14:49:12 +0200 +Subject: [PATCH 2/7] Convert LVM filter lists to sets + +To prevent devices being added multiple times and removed only +once. + +Related: rhbz#1955942 +--- + blivet/devicelibs/lvm.py | 12 ++++++------ + tests/devicetree_test.py | 6 +++--- + 2 files changed, 9 insertions(+), 9 deletions(-) + +diff --git a/blivet/devicelibs/lvm.py b/blivet/devicelibs/lvm.py +index 121797ce..9e396cca 100644 +--- a/blivet/devicelibs/lvm.py ++++ b/blivet/devicelibs/lvm.py +@@ -72,8 +72,8 @@ safe_name_characters = "0-9a-zA-Z._-" + # Theoretically we can handle all that can be handled with the LVM --config + # argument. For every time we call an lvm_cc (lvm compose config) funciton + # we regenerate the config_args with all global info. +-config_args_data = {"filterRejects": [], # regular expressions to reject. +- "filterAccepts": []} # regexp to accept ++config_args_data = {"filterRejects": set(), # regular expressions to reject. ++ "filterAccepts": set()} # regexp to accept + + + def _set_global_config(): +@@ -125,7 +125,7 @@ def needs_config_refresh(fn): + def lvm_cc_addFilterRejectRegexp(regexp): + """ Add a regular expression to the --config string.""" + log.debug("lvm filter: adding %s to the reject list", regexp) +- config_args_data["filterRejects"].append(regexp) ++ config_args_data["filterRejects"].add(regexp) + + + @needs_config_refresh +@@ -134,15 +134,15 @@ def lvm_cc_removeFilterRejectRegexp(regexp): + log.debug("lvm filter: removing %s from the reject list", regexp) + try: + config_args_data["filterRejects"].remove(regexp) +- except ValueError: ++ except KeyError: + log.debug("%s wasn't in the reject list", regexp) + return + + + @needs_config_refresh + def lvm_cc_resetFilter(): +- config_args_data["filterRejects"] = [] +- config_args_data["filterAccepts"] = [] ++ config_args_data["filterRejects"] = set() ++ config_args_data["filterAccepts"] = set() + + + def determine_parent_lv(internal_lv, lvs, lv_info): +diff --git a/tests/devicetree_test.py b/tests/devicetree_test.py +index d1f4d8f3..ef163c0a 100644 +--- a/tests/devicetree_test.py ++++ b/tests/devicetree_test.py +@@ -125,7 +125,7 @@ class DeviceTreeTestCase(unittest.TestCase): + dt.actions._actions.append(Mock(name="fake action")) + + lvm.lvm_cc_addFilterRejectRegexp("xxx") +- lvm.config_args_data["filterAccepts"].append("yyy") ++ lvm.config_args_data["filterAccepts"].add("yyy") + + dt.ignored_disks.append(names[0]) + dt.exclusive_disks.append(names[1]) +@@ -144,8 +144,8 @@ class DeviceTreeTestCase(unittest.TestCase): + + self.assertEqual(dt._hidden, empty_list) + +- self.assertEqual(lvm.config_args_data["filterAccepts"], empty_list) +- self.assertEqual(lvm.config_args_data["filterRejects"], empty_list) ++ self.assertEqual(lvm.config_args_data["filterAccepts"], set()) ++ self.assertEqual(lvm.config_args_data["filterRejects"], set()) + + self.assertEqual(dt.exclusive_disks, empty_list) + self.assertEqual(dt.ignored_disks, empty_list) +-- +2.31.1 + + +From e2540422945586ca45848a663e391a91b2fdd714 Mon Sep 17 00:00:00 2001 +From: Vojtech Trefny +Date: Tue, 27 Jul 2021 14:07:05 +0200 +Subject: [PATCH 3/7] Switch LVM devices filter from "reject" to "accept" by + default + +We currently use the LVM reject filter to filter out hidden and +ignored devices, this commit changes the behaviour to reject all +devices by default and accept only physical volumes that are not +hidden or ignored. This is preparation for the switch from the +existing lvm.conf based filtering to the new devices file based +filtering introduced in LVM 2.03.12 which allows only listing +"accepted" devices. This allows us to support both the "old" and +"new" style filtering using the same code. +--- + blivet/actionlist.py | 5 +-- + blivet/devicelibs/lvm.py | 62 +++++++++++---------------- + blivet/devices/lvm.py | 4 +- + blivet/devicetree.py | 8 ++-- + blivet/formats/lvmpv.py | 2 + + blivet/populator/helpers/lvm.py | 6 +++ + blivet/populator/helpers/partition.py | 8 ---- + blivet/populator/populator.py | 4 +- + tests/devicetree_test.py | 37 ++++++++++++++-- + tests/populator_test.py | 6 ++- + 10 files changed, 81 insertions(+), 61 deletions(-) + +diff --git a/blivet/actionlist.py b/blivet/actionlist.py +index 2de3fed3..f3977401 100644 +--- a/blivet/actionlist.py ++++ b/blivet/actionlist.py +@@ -259,10 +259,9 @@ class ActionList(object): + for action in self._actions: + log.debug("action: %s", action) + +- # Remove lvm filters for devices we are operating on +- lvm.lvm_cc_removeFilterRejectRegexp(action.device.name) + for device in (d for d in devices if d.depends_on(action.device)): +- lvm.lvm_cc_removeFilterRejectRegexp(device.name) ++ if device.format.type == "lvmpv": ++ lvm.lvm_devices_add(device.path) + + def _post_process(self, devices=None): + """ Clean up relics from action queue execution. """ +diff --git a/blivet/devicelibs/lvm.py b/blivet/devicelibs/lvm.py +index 9e396cca..96d037b8 100644 +--- a/blivet/devicelibs/lvm.py ++++ b/blivet/devicelibs/lvm.py +@@ -67,40 +67,29 @@ LVMETAD_SOCKET_PATH = "/run/lvm/lvmetad.socket" + + safe_name_characters = "0-9a-zA-Z._-" + +-# Start config_args handling code +-# +-# Theoretically we can handle all that can be handled with the LVM --config +-# argument. For every time we call an lvm_cc (lvm compose config) funciton +-# we regenerate the config_args with all global info. +-config_args_data = {"filterRejects": set(), # regular expressions to reject. +- "filterAccepts": set()} # regexp to accept ++# list of devices that LVM is allowed to use ++# with LVM >= 2.0.13 we'll use this for the --devices option and when creating ++# the /etc/lvm/devices/system.devices file ++# with older versions of LVM we will use this for the --config based filtering ++_lvm_devices = set() + + + def _set_global_config(): + """lvm command accepts lvm.conf type arguments preceded by --config. """ + +- filter_string = "" +- rejects = config_args_data["filterRejects"] +- for reject in rejects: +- filter_string += ("\"r|/%s$|\"," % reject) ++ device_string = "" ++ ++ # now explicitly "accept" all LVM devices ++ for device in _lvm_devices: ++ device_string += "\"a|%s$|\"," % device + +- if filter_string: +- filter_string = "filter=[%s]" % filter_string.strip(",") ++ # now add all devices to the "reject" filter ++ device_string += "\"r|.*|\"" + +- # XXX consider making /tmp/blivet.lvm.XXXXX, writing an lvm.conf there, and +- # setting LVM_SYSTEM_DIR +- devices_string = 'preferred_names=["^/dev/mapper/", "^/dev/md/", "^/dev/sd"]' +- if filter_string: +- devices_string += " %s" % filter_string ++ filter_string = "filter=[%s]" % device_string + +- # for now ignore the LVM devices file and rely on our filters +- if availability.LVMDEVICES.available: +- devices_string += " use_devicesfile=0" ++ config_string = " devices { %s } " % filter_string + +- # devices_string can have (inside the brackets) "dir", "scan", +- # "preferred_names", "filter", "cache_dir", "write_cache_state", +- # "types", "sysfs_scan", "md_component_detection". see man lvm.conf. +- config_string = " devices { %s } " % (devices_string) # strings can be added + if not flags.lvm_metadata_backup: + config_string += "backup {backup=0 archive=0} " + if flags.debug: +@@ -122,27 +111,26 @@ def needs_config_refresh(fn): + + + @needs_config_refresh +-def lvm_cc_addFilterRejectRegexp(regexp): +- """ Add a regular expression to the --config string.""" +- log.debug("lvm filter: adding %s to the reject list", regexp) +- config_args_data["filterRejects"].add(regexp) ++def lvm_devices_add(path): ++ """ Add a device (PV) to the list of devices LVM is allowed to use """ ++ log.debug("lvm filter: device %s added to the list of allowed devices") ++ _lvm_devices.add(path) + + + @needs_config_refresh +-def lvm_cc_removeFilterRejectRegexp(regexp): +- """ Remove a regular expression from the --config string.""" +- log.debug("lvm filter: removing %s from the reject list", regexp) ++def lvm_devices_remove(path): ++ """ Remove a device (PV) to the list of devices LVM is allowed to use """ ++ log.debug("lvm filter: device %s removed from the list of allowed devices") + try: +- config_args_data["filterRejects"].remove(regexp) ++ _lvm_devices.remove(path) + except KeyError: +- log.debug("%s wasn't in the reject list", regexp) ++ log.debug("%s wasn't in the devices list", path) + return + + + @needs_config_refresh +-def lvm_cc_resetFilter(): +- config_args_data["filterRejects"] = set() +- config_args_data["filterAccepts"] = set() ++def lvm_devices_reset(): ++ _lvm_devices.clear() + + + def determine_parent_lv(internal_lv, lvs, lv_info): +diff --git a/blivet/devices/lvm.py b/blivet/devices/lvm.py +index c61eeb4b..9c230f1b 100644 +--- a/blivet/devices/lvm.py ++++ b/blivet/devices/lvm.py +@@ -273,8 +273,8 @@ class LVMVolumeGroupDevice(ContainerDevice): + log_method_call(self, self.name, status=self.status) + if not self.complete: + for pv in self.pvs: +- # Remove the PVs from the ignore filter so we can wipe them. +- lvm.lvm_cc_removeFilterRejectRegexp(pv.name) ++ # add PVS to the list of LVM devices so we can wipe them. ++ lvm.lvm_devices_add(pv.path) + + # Don't run vgremove or vgreduce since there may be another VG with + # the same name that we want to keep/use. +diff --git a/blivet/devicetree.py b/blivet/devicetree.py +index f4ae1968..c6c1b440 100644 +--- a/blivet/devicetree.py ++++ b/blivet/devicetree.py +@@ -96,7 +96,7 @@ class DeviceTreeBase(object): + + self._hidden = [] + +- lvm.lvm_cc_resetFilter() ++ lvm.lvm_devices_reset() + + self.exclusive_disks = exclusive_disks or [] + self.ignored_disks = ignored_disks or [] +@@ -879,7 +879,8 @@ class DeviceTreeBase(object): + self._remove_device(device, force=True, modparent=False) + + self._hidden.append(device) +- lvm.lvm_cc_addFilterRejectRegexp(device.name) ++ if device.format.type == "lvmpv": ++ lvm.lvm_devices_remove(device.path) + + def unhide(self, device): + """ Restore a device's visibility. +@@ -905,7 +906,8 @@ class DeviceTreeBase(object): + self._hidden.remove(hidden) + self._devices.append(hidden) + hidden.add_hook(new=False) +- lvm.lvm_cc_removeFilterRejectRegexp(hidden.name) ++ if hidden.format.type == "lvmpv": ++ lvm.lvm_devices_add(hidden.path) + + def expand_taglist(self, taglist): + """ Expands tags in input list into devices. +diff --git a/blivet/formats/lvmpv.py b/blivet/formats/lvmpv.py +index ea84e9e4..3b00951f 100644 +--- a/blivet/formats/lvmpv.py ++++ b/blivet/formats/lvmpv.py +@@ -124,6 +124,7 @@ class LVMPhysicalVolume(DeviceFormat): + def _create(self, **kwargs): + log_method_call(self, device=self.device, + type=self.type, status=self.status) ++ lvm.lvm_devices_add(self.device) + + lvm._set_global_config() + +@@ -138,6 +139,7 @@ class LVMPhysicalVolume(DeviceFormat): + except blockdev.LVMError: + DeviceFormat._destroy(self, **kwargs) + finally: ++ lvm.lvm_devices_remove(self.device) + udev.settle() + + @property +diff --git a/blivet/populator/helpers/lvm.py b/blivet/populator/helpers/lvm.py +index c7adfa4e..9e7e4630 100644 +--- a/blivet/populator/helpers/lvm.py ++++ b/blivet/populator/helpers/lvm.py +@@ -87,6 +87,12 @@ class LVMFormatPopulator(FormatPopulator): + def _get_kwargs(self): + kwargs = super(LVMFormatPopulator, self)._get_kwargs() + ++ # new PV, add it to the LVM devices list and re-run pvs/lvs/vgs ++ lvm.lvm_devices_add(self.device.path) ++ pvs_info.drop_cache() ++ vgs_info.drop_cache() ++ lvs_info.drop_cache() ++ + pv_info = pvs_info.cache.get(self.device.path, None) + + name = udev.device_get_name(self.data) +diff --git a/blivet/populator/helpers/partition.py b/blivet/populator/helpers/partition.py +index f00323d1..8659bd48 100644 +--- a/blivet/populator/helpers/partition.py ++++ b/blivet/populator/helpers/partition.py +@@ -24,7 +24,6 @@ import copy + import six + + from ... import udev +-from ...devicelibs import lvm + from ...devices import PartitionDevice + from ...errors import DeviceError + from ...formats import get_format +@@ -66,7 +65,6 @@ class PartitionDevicePopulator(DevicePopulator): + if disk is None: + # if the disk is still not in the tree something has gone wrong + log.error("failure finding disk for %s", name) +- lvm.lvm_cc_addFilterRejectRegexp(name) + return + + if not disk.partitioned or not disk.format.supported: +@@ -78,12 +76,6 @@ class PartitionDevicePopulator(DevicePopulator): + # and instantiate a PartitionDevice so our view of the layout is + # complete. + if not disk.partitionable or disk.format.type == "iso9660" or disk.format.hidden: +- # there's no need to filter partitions on members of multipaths or +- # fwraid members from lvm since multipath and dmraid are already +- # active and lvm should therefore know to ignore them +- if not disk.format.hidden: +- lvm.lvm_cc_addFilterRejectRegexp(name) +- + log.debug("ignoring partition %s on %s", name, disk.format.type) + return + +diff --git a/blivet/populator/populator.py b/blivet/populator/populator.py +index 75bb1741..958593ec 100644 +--- a/blivet/populator/populator.py ++++ b/blivet/populator/populator.py +@@ -317,10 +317,10 @@ class PopulatorMixin(object): + continue + + # Make sure lvm doesn't get confused by PVs that belong to +- # incomplete VGs. We will remove the PVs from the reject list when/if ++ # incomplete VGs. We will add the PVs to the accept list when/if + # the time comes to remove the incomplete VG and its PVs. + for pv in vg.pvs: +- lvm.lvm_cc_addFilterRejectRegexp(pv.name) ++ lvm.lvm_devices_remove(pv.path) + + def set_disk_images(self, images): + """ Set the disk images and reflect them in exclusive_disks. +diff --git a/tests/devicetree_test.py b/tests/devicetree_test.py +index ef163c0a..3be4d572 100644 +--- a/tests/devicetree_test.py ++++ b/tests/devicetree_test.py +@@ -124,8 +124,7 @@ class DeviceTreeTestCase(unittest.TestCase): + + dt.actions._actions.append(Mock(name="fake action")) + +- lvm.lvm_cc_addFilterRejectRegexp("xxx") +- lvm.config_args_data["filterAccepts"].add("yyy") ++ lvm.lvm_devices_add("xxx") + + dt.ignored_disks.append(names[0]) + dt.exclusive_disks.append(names[1]) +@@ -144,8 +143,7 @@ class DeviceTreeTestCase(unittest.TestCase): + + self.assertEqual(dt._hidden, empty_list) + +- self.assertEqual(lvm.config_args_data["filterAccepts"], set()) +- self.assertEqual(lvm.config_args_data["filterRejects"], set()) ++ self.assertEqual(lvm._lvm_devices, set()) + + self.assertEqual(dt.exclusive_disks, empty_list) + self.assertEqual(dt.ignored_disks, empty_list) +@@ -438,6 +436,37 @@ class DeviceTreeTestCase(unittest.TestCase): + self.assertEqual(tree.get_related_disks(sda), set([sda, sdb])) + self.assertEqual(tree.get_related_disks(sdb), set([sda, sdb])) + ++ def test_lvm_filter_hide_unhide(self): ++ tree = DeviceTree() ++ ++ sda = DiskDevice("sda", size=Size("30 GiB")) ++ sdb = DiskDevice("sdb", size=Size("30 GiB")) ++ ++ tree._add_device(sda) ++ tree._add_device(sdb) ++ ++ self.assertTrue(sda in tree.devices) ++ self.assertTrue(sdb in tree.devices) ++ ++ sda.format = get_format("lvmpv", device=sda.path) ++ sdb.format = get_format("lvmpv", device=sdb.path) ++ ++ # LVMPhysicalVolume._create would do this ++ lvm.lvm_devices_add(sda.path) ++ lvm.lvm_devices_add(sdb.path) ++ ++ self.assertSetEqual(lvm._lvm_devices, {sda.path, sdb.path}) ++ ++ tree.hide(sda) ++ self.assertSetEqual(lvm._lvm_devices, {sdb.path}) ++ tree.hide(sdb) ++ self.assertSetEqual(lvm._lvm_devices, set()) ++ ++ tree.unhide(sda) ++ self.assertSetEqual(lvm._lvm_devices, {sda.path}) ++ tree.unhide(sdb) ++ self.assertSetEqual(lvm._lvm_devices, {sda.path, sdb.path}) ++ + + class DeviceTreeIgnoredExclusiveMultipathTestCase(unittest.TestCase): + +diff --git a/tests/populator_test.py b/tests/populator_test.py +index 2a8532f0..dd36c16a 100644 +--- a/tests/populator_test.py ++++ b/tests/populator_test.py +@@ -13,6 +13,7 @@ from gi.repository import BlockDev as blockdev + from blivet.devices import DiskDevice, DMDevice, FileDevice, LoopDevice + from blivet.devices import MDRaidArrayDevice, MultipathDevice, OpticalDevice + from blivet.devices import PartitionDevice, StorageDevice, NVDIMMNamespaceDevice ++from blivet.devicelibs import lvm + from blivet.devicetree import DeviceTree + from blivet.formats import get_device_format_class, get_format, DeviceFormat + from blivet.formats.disklabel import DiskLabel +@@ -393,8 +394,7 @@ class PartitionDevicePopulatorTestCase(PopulatorHelperTestCase): + @patch.object(DiskLabel, "parted_disk") + @patch.object(DiskLabel, "parted_device") + @patch.object(PartitionDevice, "probe") +- # TODO: fix the naming of the lvm filter functions +- @patch("blivet.devicelibs.lvm.lvm_cc_addFilterRejectRegexp") ++ @patch("blivet.devicelibs.lvm.lvm_devices_add") + @patch("blivet.udev.device_get_major", return_value=88) + @patch("blivet.udev.device_get_minor", return_value=19) + @patch.object(DeviceTree, "get_device_by_name") +@@ -973,6 +973,8 @@ class LVMFormatPopulatorTestCase(FormatPopulatorTestCase): + self.assertTrue(vg_device is not None) + devicetree._remove_device(vg_device) + ++ self.assertIn(device.path, lvm._lvm_devices) ++ + get_device_by_uuid.reset_mock() + + # pv belongs to a valid vg not in the tree with two lvs +-- +2.31.1 + + +From 15a63b01bd2b6e7fe197fade849f28b83407c166 Mon Sep 17 00:00:00 2001 +From: Vojtech Trefny +Date: Fri, 30 Jul 2021 14:01:04 +0200 +Subject: [PATCH 4/7] Use LVM devices for filtering LVM devices with LVM >= + 2.02.13 + +--- + blivet/devicelibs/lvm.py | 38 +++++++++++++++++++++++++++++--------- + tests/populator_test.py | 9 ++++----- + 2 files changed, 33 insertions(+), 14 deletions(-) + +diff --git a/blivet/devicelibs/lvm.py b/blivet/devicelibs/lvm.py +index 96d037b8..3ab1540b 100644 +--- a/blivet/devicelibs/lvm.py ++++ b/blivet/devicelibs/lvm.py +@@ -67,6 +67,16 @@ LVMETAD_SOCKET_PATH = "/run/lvm/lvmetad.socket" + + safe_name_characters = "0-9a-zA-Z._-" + ++if hasattr(blockdev.LVMTech, "DEVICES"): ++ try: ++ blockdev.lvm.is_tech_avail(blockdev.LVMTech.DEVICES, 0) # pylint: disable=no-member ++ except blockdev.LVMError: ++ HAVE_LVMDEVICES = False ++ else: ++ HAVE_LVMDEVICES = True ++else: ++ HAVE_LVMDEVICES = False ++ + # list of devices that LVM is allowed to use + # with LVM >= 2.0.13 we'll use this for the --devices option and when creating + # the /etc/lvm/devices/system.devices file +@@ -79,25 +89,34 @@ def _set_global_config(): + + device_string = "" + +- # now explicitly "accept" all LVM devices +- for device in _lvm_devices: +- device_string += "\"a|%s$|\"," % device ++ if not HAVE_LVMDEVICES: ++ # now explicitly "accept" all LVM devices ++ for device in _lvm_devices: ++ device_string += "\"a|%s$|\"," % device + +- # now add all devices to the "reject" filter +- device_string += "\"r|.*|\"" ++ # now add all devices to the "reject" filter ++ device_string += "\"r|.*|\"" + +- filter_string = "filter=[%s]" % device_string ++ filter_string = "filter=[%s]" % device_string + +- config_string = " devices { %s } " % filter_string ++ config_string = " devices { %s } " % filter_string ++ else: ++ config_string = " " + + if not flags.lvm_metadata_backup: + config_string += "backup {backup=0 archive=0} " +- if flags.debug: +- config_string += "log {level=7 file=/tmp/lvm.log syslog=0}" ++ config_string += "log {level=7 file=/tmp/lvm.log syslog=0}" + + blockdev.lvm.set_global_config(config_string) + + ++def _set_lvm_devices(): ++ if not HAVE_LVMDEVICES: ++ return ++ ++ blockdev.lvm.set_devices_filter(list(_lvm_devices)) ++ ++ + def needs_config_refresh(fn): + if not availability.BLOCKDEV_LVM_PLUGIN.available: + return lambda *args, **kwargs: None +@@ -105,6 +124,7 @@ def needs_config_refresh(fn): + def fn_with_refresh(*args, **kwargs): + ret = fn(*args, **kwargs) + _set_global_config() ++ _set_lvm_devices() + return ret + + return fn_with_refresh +diff --git a/tests/populator_test.py b/tests/populator_test.py +index dd36c16a..a9584319 100644 +--- a/tests/populator_test.py ++++ b/tests/populator_test.py +@@ -897,6 +897,7 @@ class LVMFormatPopulatorTestCase(FormatPopulatorTestCase): + device = Mock() + device.parents = [] + device.size = Size("10g") ++ device.path = "/dev/sda1" + devicetree._add_device(device) + + # pylint: disable=attribute-defined-outside-init +@@ -924,15 +925,13 @@ class LVMFormatPopulatorTestCase(FormatPopulatorTestCase): + pv_info.pe_start = 0 + pv_info.pv_free = 0 + +- device.path = sentinel.pv_path +- + vg_device = Mock() + vg_device.parents = [] + vg_device.lvs = [] + get_device_by_uuid.return_value = vg_device + + with patch("blivet.static_data.lvm_info.PVsInfo.cache", new_callable=PropertyMock) as mock_pvs_cache: +- mock_pvs_cache.return_value = {sentinel.pv_path: pv_info} ++ mock_pvs_cache.return_value = {device.path: pv_info} + with patch("blivet.udev.device_get_format", return_value=self.udev_type): + helper = self.helper_class(devicetree, data, device) + self.assertFalse(device in vg_device.parents) +@@ -957,7 +956,7 @@ class LVMFormatPopulatorTestCase(FormatPopulatorTestCase): + pv_info.vg_pv_count = 1 + + with patch("blivet.static_data.lvm_info.PVsInfo.cache", new_callable=PropertyMock) as mock_pvs_cache: +- mock_pvs_cache.return_value = {sentinel.pv_path: pv_info} ++ mock_pvs_cache.return_value = {device.path: pv_info} + with patch("blivet.static_data.lvm_info.VGsInfo.cache", new_callable=PropertyMock) as mock_vgs_cache: + mock_vgs_cache.return_value = {pv_info.vg_uuid: Mock()} + with patch("blivet.udev.device_get_format", return_value=self.udev_type): +@@ -1007,7 +1006,7 @@ class LVMFormatPopulatorTestCase(FormatPopulatorTestCase): + get_device_by_uuid.side_effect = gdbu + + with patch("blivet.static_data.lvm_info.PVsInfo.cache", new_callable=PropertyMock) as mock_pvs_cache: +- mock_pvs_cache.return_value = {sentinel.pv_path: pv_info} ++ mock_pvs_cache.return_value = {device.path: pv_info} + with patch("blivet.static_data.lvm_info.VGsInfo.cache", new_callable=PropertyMock) as mock_vgs_cache: + mock_vgs_cache.return_value = {pv_info.vg_uuid: Mock()} + with patch("blivet.static_data.lvm_info.LVsInfo.cache", new_callable=PropertyMock) as mock_lvs_cache: +-- +2.31.1 + + +From d4e1395de3691f30196b6b0e3b2c82e83b27afaf Mon Sep 17 00:00:00 2001 +From: Vojtech Trefny +Date: Fri, 30 Jul 2021 14:01:43 +0200 +Subject: [PATCH 5/7] Make sure PVs are added/deleted to/from the LVM device + file + +We are using the --devices option when running LVM commands which +mean the newly created PV won't be added to the device list by +pvcreate so we need to do that manually. +--- + blivet/formats/lvmpv.py | 5 +++++ + 1 file changed, 5 insertions(+) + +diff --git a/blivet/formats/lvmpv.py b/blivet/formats/lvmpv.py +index 3b00951f..71ec699f 100644 +--- a/blivet/formats/lvmpv.py ++++ b/blivet/formats/lvmpv.py +@@ -131,6 +131,9 @@ class LVMPhysicalVolume(DeviceFormat): + ea_yes = blockdev.ExtraArg.new("-y", "") + blockdev.lvm.pvcreate(self.device, data_alignment=self.data_alignment, extra=[ea_yes]) + ++ if lvm.HAVE_LVMDEVICES: ++ blockdev.lvm.devices_add(self.device) ++ + def _destroy(self, **kwargs): + log_method_call(self, device=self.device, + type=self.type, status=self.status) +@@ -141,6 +144,8 @@ class LVMPhysicalVolume(DeviceFormat): + finally: + lvm.lvm_devices_remove(self.device) + udev.settle() ++ if lvm.HAVE_LVMDEVICES: ++ blockdev.lvm.devices_delete(self.device) + + @property + def destroyable(self): +-- +2.31.1 + + +From c221d313bde21fb2cba701b93fe0c57336cba8ec Mon Sep 17 00:00:00 2001 +From: Vojtech Trefny +Date: Thu, 14 Oct 2021 15:32:24 +0200 +Subject: [PATCH 6/7] Ignore errors for LVM devices file actions + +The LVM devices file feature might be disabled either locally or +globally by LVM config. +--- + blivet/formats/lvmpv.py | 10 ++++++++-- + 1 file changed, 8 insertions(+), 2 deletions(-) + +diff --git a/blivet/formats/lvmpv.py b/blivet/formats/lvmpv.py +index 71ec699f..b27213cc 100644 +--- a/blivet/formats/lvmpv.py ++++ b/blivet/formats/lvmpv.py +@@ -132,7 +132,10 @@ class LVMPhysicalVolume(DeviceFormat): + blockdev.lvm.pvcreate(self.device, data_alignment=self.data_alignment, extra=[ea_yes]) + + if lvm.HAVE_LVMDEVICES: +- blockdev.lvm.devices_add(self.device) ++ try: ++ blockdev.lvm.devices_add(self.device) ++ except blockdev.LVMError as e: ++ log.debug("Failed to add newly created PV %s to the LVM devices file: %s", self.device, str(e)) + + def _destroy(self, **kwargs): + log_method_call(self, device=self.device, +@@ -145,7 +148,10 @@ class LVMPhysicalVolume(DeviceFormat): + lvm.lvm_devices_remove(self.device) + udev.settle() + if lvm.HAVE_LVMDEVICES: +- blockdev.lvm.devices_delete(self.device) ++ try: ++ blockdev.lvm.devices_delete(self.device) ++ except blockdev.LVMError as e: ++ log.debug("Failed to remove PV %s from the LVM devices file: %s", self.device, str(e)) + + @property + def destroyable(self): +-- +2.31.1 + + +From 6b96d4ead6890fffd95840b8935f71ecd9e310ef Mon Sep 17 00:00:00 2001 +From: Vojtech Trefny +Date: Tue, 19 Oct 2021 14:27:05 +0200 +Subject: [PATCH 7/7] Add public functions to add/remove PV to/from the LVM + system.devices + +Anaconda needs to be able to add preexisting PVs to the file +during installation. +--- + blivet/formats/lvmpv.py | 28 ++++++++++++++++++++-------- + 1 file changed, 20 insertions(+), 8 deletions(-) + +diff --git a/blivet/formats/lvmpv.py b/blivet/formats/lvmpv.py +index b27213cc..3fef667e 100644 +--- a/blivet/formats/lvmpv.py ++++ b/blivet/formats/lvmpv.py +@@ -121,6 +121,24 @@ class LVMPhysicalVolume(DeviceFormat): + def supported(self): + return super(LVMPhysicalVolume, self).supported and self._plugin.available + ++ def lvmdevices_add(self): ++ if not lvm.HAVE_LVMDEVICES: ++ raise PhysicalVolumeError("LVM devices file feature is not supported") ++ ++ try: ++ blockdev.lvm.devices_add(self.device) ++ except blockdev.LVMError as e: ++ log.debug("Failed to add PV %s to the LVM devices file: %s", self.device, str(e)) ++ ++ def lvmdevices_remove(self): ++ if not lvm.HAVE_LVMDEVICES: ++ raise PhysicalVolumeError("LVM devices file feature is not supported") ++ ++ try: ++ blockdev.lvm.devices_delete(self.device) ++ except blockdev.LVMError as e: ++ log.debug("Failed to remove PV %s from the LVM devices file: %s", self.device, str(e)) ++ + def _create(self, **kwargs): + log_method_call(self, device=self.device, + type=self.type, status=self.status) +@@ -132,10 +150,7 @@ class LVMPhysicalVolume(DeviceFormat): + blockdev.lvm.pvcreate(self.device, data_alignment=self.data_alignment, extra=[ea_yes]) + + if lvm.HAVE_LVMDEVICES: +- try: +- blockdev.lvm.devices_add(self.device) +- except blockdev.LVMError as e: +- log.debug("Failed to add newly created PV %s to the LVM devices file: %s", self.device, str(e)) ++ self.lvmdevices_add() + + def _destroy(self, **kwargs): + log_method_call(self, device=self.device, +@@ -148,10 +163,7 @@ class LVMPhysicalVolume(DeviceFormat): + lvm.lvm_devices_remove(self.device) + udev.settle() + if lvm.HAVE_LVMDEVICES: +- try: +- blockdev.lvm.devices_delete(self.device) +- except blockdev.LVMError as e: +- log.debug("Failed to remove PV %s from the LVM devices file: %s", self.device, str(e)) ++ self.lvmdevices_remove() + + @property + def destroyable(self): +-- +2.31.1 + diff --git a/SOURCES/0015-iscsi-Replace-all-log_exception_info-calls-with-log.patch b/SOURCES/0015-iscsi-Replace-all-log_exception_info-calls-with-log.patch new file mode 100644 index 0000000..c802d8d --- /dev/null +++ b/SOURCES/0015-iscsi-Replace-all-log_exception_info-calls-with-log.patch @@ -0,0 +1,53 @@ +From 23b7573557e69d9b4dccdd6d52e82b82d8dba115 Mon Sep 17 00:00:00 2001 +From: Vojtech Trefny +Date: Wed, 1 Dec 2021 16:28:15 +0100 +Subject: [PATCH] iscsi: Replace all log_exception_info calls with log.info + +We don't get any useful information from the exception, it's +always the same traceback from a failed DBus call and we only use +these when a called failed because firmware ISCSI is not supported. +The resulting log message also looks like a failure with the +traceback logged and not just as a debug information. + +Resolves: rhbz#2028134 +--- + blivet/iscsi.py | 9 ++++----- + 1 file changed, 4 insertions(+), 5 deletions(-) + +diff --git a/blivet/iscsi.py b/blivet/iscsi.py +index 5ee2082b..bc77ca62 100644 +--- a/blivet/iscsi.py ++++ b/blivet/iscsi.py +@@ -22,7 +22,6 @@ from . import udev + from . import util + from .flags import flags + from .i18n import _ +-from .storage_log import log_exception_info + from . import safe_dbus + import os + import re +@@ -277,8 +276,8 @@ class iSCSI(object): + 'org.freedesktop.DBus.ObjectManager', + 'GetManagedObjects', + None)[0] +- except safe_dbus.DBusCallError: +- log_exception_info(log.info, "iscsi: Failed to get active sessions.") ++ except safe_dbus.DBusCallError as e: ++ log.info("iscsi: Failed to get active sessions: %s", str(e)) + return [] + + sessions = (obj for obj in objects.keys() if re.match(r'.*/iscsi/session[0-9]+$', obj)) +@@ -302,8 +301,8 @@ class iSCSI(object): + args = GLib.Variant("(a{sv})", ([], )) + try: + found_nodes, _n_nodes = self._call_initiator_method("DiscoverFirmware", args) +- except safe_dbus.DBusCallError: +- log_exception_info(log.info, "iscsi: No IBFT info found.") ++ except safe_dbus.DBusCallError as e: ++ log.info("iscsi: No IBFT info found: %s", str(e)) + # an exception here means there is no ibft firmware, just return + return + +-- +2.31.1 + diff --git a/SOURCES/0016-Fix-log-message-for-the-LVM-devices-filter.patch b/SOURCES/0016-Fix-log-message-for-the-LVM-devices-filter.patch new file mode 100644 index 0000000..df27558 --- /dev/null +++ b/SOURCES/0016-Fix-log-message-for-the-LVM-devices-filter.patch @@ -0,0 +1,33 @@ +From 52019b19caaf383daa5f2f0437e0c9e262adb45e Mon Sep 17 00:00:00 2001 +From: Vojtech Trefny +Date: Mon, 13 Dec 2021 14:18:12 +0100 +Subject: [PATCH] Fix log message for the LVM devices filter + +--- + blivet/devicelibs/lvm.py | 4 ++-- + 1 file changed, 2 insertions(+), 2 deletions(-) + +diff --git a/blivet/devicelibs/lvm.py b/blivet/devicelibs/lvm.py +index 3ab1540b..bbde6303 100644 +--- a/blivet/devicelibs/lvm.py ++++ b/blivet/devicelibs/lvm.py +@@ -133,14 +133,14 @@ def needs_config_refresh(fn): + @needs_config_refresh + def lvm_devices_add(path): + """ Add a device (PV) to the list of devices LVM is allowed to use """ +- log.debug("lvm filter: device %s added to the list of allowed devices") ++ log.debug("lvm filter: device %s added to the list of allowed devices", path) + _lvm_devices.add(path) + + + @needs_config_refresh + def lvm_devices_remove(path): + """ Remove a device (PV) to the list of devices LVM is allowed to use """ +- log.debug("lvm filter: device %s removed from the list of allowed devices") ++ log.debug("lvm filter: device %s removed from the list of allowed devices", path) + try: + _lvm_devices.remove(path) + except KeyError: +-- +2.34.1 + diff --git a/SOURCES/0017-Exclude-unusable-disks-from-PartitionFactory.patch b/SOURCES/0017-Exclude-unusable-disks-from-PartitionFactory.patch new file mode 100644 index 0000000..6557f72 --- /dev/null +++ b/SOURCES/0017-Exclude-unusable-disks-from-PartitionFactory.patch @@ -0,0 +1,81 @@ +From f02dbed9143664246d400b0f5654062dff5383fc Mon Sep 17 00:00:00 2001 +From: Vojtech Trefny +Date: Thu, 13 Jan 2022 16:53:30 +0100 +Subject: [PATCH 1/2] Exclude unusable disks from PartitionFactory + +We already remove disks that are too small or not partitionable +in the PartitionSetFactory which allows us to create partitions +on multipath devices where Anaconda tells us to use both the mpath +device and the backing disks, we should do the same for the +PartitionFactory. + +Resolves: rhbz#2017432 +--- + blivet/devicefactory.py | 18 ++++++++++++++++++ + 1 file changed, 18 insertions(+) + +diff --git a/blivet/devicefactory.py b/blivet/devicefactory.py +index 0f7fdfa1..45b38b0f 100644 +--- a/blivet/devicefactory.py ++++ b/blivet/devicefactory.py +@@ -1056,6 +1056,24 @@ class PartitionFactory(DeviceFactory): + **kwargs) + return device + ++ def _configure(self): ++ disks = [] ++ for disk in self.disks: ++ if not disk.partitioned: ++ log.debug("removing unpartitioned disk %s", disk.name) ++ elif not disk.format.supported: ++ log.debug("removing disk with unsupported format %s", disk.name) ++ else: ++ disks.append(disk) ++ ++ if not disks: ++ raise DeviceFactoryError("no usable disks specified for partition") ++ ++ log.debug("setting new factory disks to %s", [d.name for d in disks]) ++ self.disks = disks # pylint: disable=attribute-defined-outside-init ++ ++ super(PartitionFactory, self)._configure() ++ + def _set_disks(self): + self.raw_device.req_disks = self.disks[:] + +-- +2.34.1 + + +From a9adcb050a16ab8231c81ced68302d6ad685ccf4 Mon Sep 17 00:00:00 2001 +From: Vojtech Trefny +Date: Thu, 13 Jan 2022 17:27:08 +0100 +Subject: [PATCH 2/2] Show better error when using unitialized disk in + do_partitioning + +Now all we get is "KeyError: '/dev/sda'" for example. + +Related: rhbz#2017432 +--- + blivet/partitioning.py | 5 ++++- + 1 file changed, 4 insertions(+), 1 deletion(-) + +diff --git a/blivet/partitioning.py b/blivet/partitioning.py +index 53f9cc3f..23b150f9 100644 +--- a/blivet/partitioning.py ++++ b/blivet/partitioning.py +@@ -764,7 +764,10 @@ def allocate_partitions(storage, disks, partitions, freespace, boot_disk=None): + growth = 0 # in sectors + # loop through disks + for _disk in req_disks: +- disklabel = disklabels[_disk.path] ++ try: ++ disklabel = disklabels[_disk.path] ++ except KeyError: ++ raise PartitioningError("Requested disk %s doesn't have a usable disklabel for partitioning" % _disk.name) + best = None + current_free = free + try: +-- +2.34.1 + diff --git a/SOURCES/0018-Fix-getting-PV-info-in-LVMPhysicalVolume-from-the-ca.patch b/SOURCES/0018-Fix-getting-PV-info-in-LVMPhysicalVolume-from-the-ca.patch new file mode 100644 index 0000000..42daec5 --- /dev/null +++ b/SOURCES/0018-Fix-getting-PV-info-in-LVMPhysicalVolume-from-the-ca.patch @@ -0,0 +1,29 @@ +From dc6350f87a1dacdebdbb9cf0be43699bb5f7eadd Mon Sep 17 00:00:00 2001 +From: Vojtech Trefny +Date: Mon, 16 Aug 2021 09:50:34 +0200 +Subject: [PATCH] Fix getting PV info in LVMPhysicalVolume from the cache + +"self.device" is string for formats so accessing "self.device.path" +results in an AttributeError. + +Resolves: rhbz#2079221 +--- + blivet/formats/lvmpv.py | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/blivet/formats/lvmpv.py b/blivet/formats/lvmpv.py +index 3fef667e..483b53a4 100644 +--- a/blivet/formats/lvmpv.py ++++ b/blivet/formats/lvmpv.py +@@ -197,7 +197,7 @@ class LVMPhysicalVolume(DeviceFormat): + if self.exists: + # we don't have any actual value, but the PV exists and is + # active, we should try to determine it +- pv_info = pvs_info.cache.get(self.device.path) ++ pv_info = pvs_info.cache.get(self.device) + if pv_info is None: + log.error("Failed to get free space information for the PV '%s'", self.device) + self._free = Size(0) +-- +2.34.3 + diff --git a/SOURCES/0019-Do-not-crash-when-changing-disklabel-on-disks-with-a.patch b/SOURCES/0019-Do-not-crash-when-changing-disklabel-on-disks-with-a.patch new file mode 100644 index 0000000..0d58051 --- /dev/null +++ b/SOURCES/0019-Do-not-crash-when-changing-disklabel-on-disks-with-a.patch @@ -0,0 +1,41 @@ +From 72ace5d66b567baefde10ff9c4197054830067f1 Mon Sep 17 00:00:00 2001 +From: Vojtech Trefny +Date: Thu, 28 Apr 2022 14:13:04 +0200 +Subject: [PATCH] Do not crash when changing disklabel on disks with active + devices + +The _find_active_devices_on_action_disks function originally +prevented from making any changes on disks with active devices +(active LVs, mounted partitions etc.) This was changed in +b72e957d2b23444824316331ae21d1c594371e9c and the check currently +prevents only reformatting the disklabel on such disks which +should be already impossible on disks with an existing partition. + +This change for the 3.4 stable branch keeps the current behaviour +where the active devices are teared down when running in installer +mode to avoid potential issues with the installer. + +Resolves: rhbz#2078803 +--- + blivet/actionlist.py | 5 ++--- + 1 file changed, 2 insertions(+), 3 deletions(-) + +diff --git a/blivet/actionlist.py b/blivet/actionlist.py +index f3977401..9c06228b 100644 +--- a/blivet/actionlist.py ++++ b/blivet/actionlist.py +@@ -211,9 +211,8 @@ class ActionList(object): + except StorageError as e: + log.info("teardown of %s failed: %s", device.name, e) + else: +- raise RuntimeError("partitions in use on disks with changes " +- "pending: %s" % +- ",".join(problematic)) ++ log.debug("ignoring devices in use on disks with changes: %s", ++ ",".join(problematic)) + + log.info("resetting parted disks...") + for device in devices: +-- +2.34.3 + diff --git a/SOURCES/0020-ActionDestroyDevice-should-not-obsolete-ActionRemove.patch b/SOURCES/0020-ActionDestroyDevice-should-not-obsolete-ActionRemove.patch new file mode 100644 index 0000000..2eb4c94 --- /dev/null +++ b/SOURCES/0020-ActionDestroyDevice-should-not-obsolete-ActionRemove.patch @@ -0,0 +1,65 @@ +From 070b33c1a80e5740abd7878118a23eaaca1e3460 Mon Sep 17 00:00:00 2001 +From: Vojtech Trefny +Date: Wed, 13 Apr 2022 15:43:45 +0200 +Subject: [PATCH] ActionDestroyDevice should not obsolete ActionRemoveMember + +If we want to remove a PV from a VG and then remove the PV device, +the ActionDestroyDevice must not obsolete the ActionRemoveMember +action. Eventhough we are going to remove the device, we still +need to call "vgreduce" first. + +Resolves: rhbz#2076956 +--- + blivet/deviceaction.py | 10 +++++----- + tests/action_test.py | 7 +++++++ + 2 files changed, 12 insertions(+), 5 deletions(-) + +diff --git a/blivet/deviceaction.py b/blivet/deviceaction.py +index 0458e4be..78e113bf 100644 +--- a/blivet/deviceaction.py ++++ b/blivet/deviceaction.py +@@ -463,8 +463,8 @@ class ActionDestroyDevice(DeviceAction): + - obsoletes all actions w/ lower id that act on the same device, + including self, if device does not exist + +- - obsoletes all but ActionDestroyFormat actions w/ lower id on the +- same device if device exists ++ - obsoletes all but ActionDestroyFormat and ActionRemoveMember actions ++ w/ lower id on the same device if device exists + + - obsoletes all actions that add a member to this action's + (container) device +@@ -474,9 +474,9 @@ class ActionDestroyDevice(DeviceAction): + if action.device.id == self.device.id: + if self.id >= action.id and not self.device.exists: + rc = True +- elif self.id > action.id and \ +- self.device.exists and \ +- not (action.is_destroy and action.is_format): ++ elif self.id > action.id and self.device.exists and \ ++ not ((action.is_destroy and action.is_format) or ++ action.is_remove): + rc = True + elif action.is_add and (action.device == self.device): + rc = True +diff --git a/tests/action_test.py b/tests/action_test.py +index 8509ce35..626b9b49 100644 +--- a/tests/action_test.py ++++ b/tests/action_test.py +@@ -1197,6 +1197,13 @@ class DeviceActionTestCase(StorageTestCase): + self.assertEqual(create_sdc2.requires(remove_sdc1), False) + self.assertEqual(remove_sdc1.requires(create_sdc2), False) + ++ # destroy sdc1, the ActionRemoveMember should not be obsoleted ++ sdc1.exists = True ++ destroy_sdc1 = ActionDestroyDevice(sdc1) ++ destroy_sdc1.apply() ++ self.assertFalse(destroy_sdc1.obsoletes(remove_sdc1)) ++ self.assertTrue(destroy_sdc1.requires(remove_sdc1)) ++ + def test_action_sorting(self, *args, **kwargs): + """ Verify correct functioning of action sorting. """ + +-- +2.34.3 + diff --git a/SOURCES/0021-Correctly-set-vg_name-after-adding-removing-a-PV-fro.patch b/SOURCES/0021-Correctly-set-vg_name-after-adding-removing-a-PV-fro.patch new file mode 100644 index 0000000..aa79b78 --- /dev/null +++ b/SOURCES/0021-Correctly-set-vg_name-after-adding-removing-a-PV-fro.patch @@ -0,0 +1,63 @@ +From ea5054b0cab19f3fe09d7010f8721e7f18ae399e Mon Sep 17 00:00:00 2001 +From: Vojtech Trefny +Date: Mon, 2 May 2022 15:30:16 +0200 +Subject: [PATCH] Correctly set vg_name after adding/removing a PV from a VG + +Without setting the LVMPhysicalVolume.vg_name argument to None +after removing the PV from its VG, the PV is still considered +active and cannot be removed. + +Resolves: rhbz#2081278 +--- + blivet/devices/lvm.py | 3 +++ + tests/devices_test/lvm_test.py | 13 +++++++++++++ + 2 files changed, 16 insertions(+) + +diff --git a/blivet/devices/lvm.py b/blivet/devices/lvm.py +index 9c230f1b..a971da8e 100644 +--- a/blivet/devices/lvm.py ++++ b/blivet/devices/lvm.py +@@ -385,6 +385,8 @@ class LVMVolumeGroupDevice(ContainerDevice): + if not parent.format.exists: + parent.format.free = self._get_pv_usable_space(parent) + ++ parent.format.vg_name = self.name ++ + def _remove_parent(self, parent): + # XXX It would be nice to raise an exception if removing this member + # would not leave enough space, but the devicefactory relies on it +@@ -395,6 +397,7 @@ class LVMVolumeGroupDevice(ContainerDevice): + super(LVMVolumeGroupDevice, self)._remove_parent(parent) + parent.format.free = None + parent.format.container_uuid = None ++ parent.format.vg_name = None + + # We can't rely on lvm to tell us about our size, free space, &c + # since we could have modifications queued, unless the VG and all of +diff --git a/tests/devices_test/lvm_test.py b/tests/devices_test/lvm_test.py +index 5efa369e..59c027da 100644 +--- a/tests/devices_test/lvm_test.py ++++ b/tests/devices_test/lvm_test.py +@@ -454,6 +454,19 @@ class LVMDeviceTest(unittest.TestCase): + pool.autoset_md_size(enforced=True) + self.assertEqual(pool.chunk_size, Size("128 KiB")) + ++ def test_add_remove_pv(self): ++ pv1 = StorageDevice("pv1", fmt=blivet.formats.get_format("lvmpv"), ++ size=Size("1024 MiB")) ++ pv2 = StorageDevice("pv2", fmt=blivet.formats.get_format("lvmpv"), ++ size=Size("1024 MiB")) ++ vg = LVMVolumeGroupDevice("testvg", parents=[pv1]) ++ ++ vg._add_parent(pv2) ++ self.assertEqual(pv2.format.vg_name, vg.name) ++ ++ vg._remove_parent(pv2) ++ self.assertEqual(pv2.format.vg_name, None) ++ + + class TypeSpecificCallsTest(unittest.TestCase): + def test_type_specific_calls(self): +-- +2.34.3 + diff --git a/SOURCES/0022-Add-support-for-creating-LVM-cache-pools.patch b/SOURCES/0022-Add-support-for-creating-LVM-cache-pools.patch new file mode 100644 index 0000000..5cf99f4 --- /dev/null +++ b/SOURCES/0022-Add-support-for-creating-LVM-cache-pools.patch @@ -0,0 +1,588 @@ +From 08f0e12c74e4c2ba25629fe92108283dd5ae3ff3 Mon Sep 17 00:00:00 2001 +From: Vojtech Trefny +Date: Thu, 30 Dec 2021 16:08:43 +0100 +Subject: [PATCH 1/4] Add support for creating LVM cache pools + +Resolves: rhbz#2055200 +--- + blivet/blivet.py | 9 +- + blivet/devicelibs/lvm.py | 9 ++ + blivet/devices/lvm.py | 160 +++++++++++++++++++++++++++++++-- + tests/devices_test/lvm_test.py | 26 ++++++ + 4 files changed, 196 insertions(+), 8 deletions(-) + +diff --git a/blivet/blivet.py b/blivet/blivet.py +index c6908eb0..d29fadd0 100644 +--- a/blivet/blivet.py ++++ b/blivet/blivet.py +@@ -576,6 +576,8 @@ class Blivet(object): + :type vdo_pool: bool + :keyword vdo_lv: whether to create a vdo lv + :type vdo_lv: bool ++ :keyword cache_pool: whether to create a cache pool ++ :type cache_pool: bool + :returns: the new device + :rtype: :class:`~.devices.LVMLogicalVolumeDevice` + +@@ -594,6 +596,7 @@ class Blivet(object): + thin_pool = kwargs.pop("thin_pool", False) + vdo_pool = kwargs.pop("vdo_pool", False) + vdo_lv = kwargs.pop("vdo_lv", False) ++ cache_pool = kwargs.pop("cache_pool", False) + parent = kwargs.get("parents", [None])[0] + if (thin_volume or vdo_lv) and parent: + # kwargs["parents"] will contain the pool device, so... +@@ -609,6 +612,8 @@ class Blivet(object): + kwargs["seg_type"] = "vdo-pool" + if vdo_lv: + kwargs["seg_type"] = "vdo" ++ if cache_pool: ++ kwargs["seg_type"] = "cache-pool" + + mountpoint = kwargs.pop("mountpoint", None) + if 'fmt_type' in kwargs: +@@ -640,7 +645,7 @@ class Blivet(object): + swap = False + + prefix = "" +- if thin_pool or vdo_pool: ++ if thin_pool or vdo_pool or cache_pool: + prefix = "pool" + + name = self.suggest_device_name(parent=vg, +@@ -651,7 +656,7 @@ class Blivet(object): + if "%s-%s" % (vg.name, name) in self.names: + raise ValueError("name '%s' is already in use" % name) + +- if thin_pool or thin_volume or vdo_pool or vdo_lv: ++ if thin_pool or thin_volume or vdo_pool or vdo_lv or cache_pool: + cache_req = kwargs.pop("cache_request", None) + if cache_req: + raise ValueError("Creating cached thin and VDO volumes and pools is not supported") +diff --git a/blivet/devicelibs/lvm.py b/blivet/devicelibs/lvm.py +index bbde6303..23935009 100644 +--- a/blivet/devicelibs/lvm.py ++++ b/blivet/devicelibs/lvm.py +@@ -54,6 +54,11 @@ LVM_THINP_MIN_CHUNK_SIZE = Size("64 KiB") + LVM_THINP_MAX_CHUNK_SIZE = Size("1 GiB") + LVM_THINP_ADDRESSABLE_CHUNK_SIZE = Size("17455015526400 B") # 15.88 TiB + ++# cache constants ++LVM_CACHE_MIN_METADATA_SIZE = Size("8 MiB") ++LVM_CACHE_MAX_METADATA_SIZE = Size("16 GiB") ++LVM_CACHE_DEFAULT_MODE = blockdev.LVMCacheMode.WRITETHROUGH ++ + raid_levels = raid.RAIDLevels(["linear", "striped", "raid1", "raid4", "raid5", "raid6", "raid10"]) + raid_seg_types = list(itertools.chain.from_iterable([level.names for level in raid_levels if level.name != "linear"])) + +@@ -248,3 +253,7 @@ def recommend_thpool_chunk_size(thpool_size): + # for every ~15.88 TiB of thinpool data size + return min(math.ceil(thpool_size / LVM_THINP_ADDRESSABLE_CHUNK_SIZE) * LVM_THINP_MIN_CHUNK_SIZE, + LVM_THINP_MAX_CHUNK_SIZE) ++ ++ ++def is_valid_cache_md_size(md_size): ++ return md_size >= LVM_CACHE_MIN_METADATA_SIZE and md_size <= LVM_CACHE_MAX_METADATA_SIZE +diff --git a/blivet/devices/lvm.py b/blivet/devices/lvm.py +index a971da8e..7cb482ab 100644 +--- a/blivet/devices/lvm.py ++++ b/blivet/devices/lvm.py +@@ -43,6 +43,7 @@ from .. import util + from ..storage_log import log_method_call + from .. import udev + from ..size import Size, KiB, MiB, ROUND_UP, ROUND_DOWN ++from ..static_data.lvm_info import lvs_info + from ..tasks import availability + + import logging +@@ -646,7 +647,7 @@ class LVMLogicalVolumeBase(DMDevice, RaidDevice): + percent=None, cache_request=None, pvs=None, from_lvs=None): + + if not exists: +- if seg_type not in [None, "linear", "thin", "thin-pool", "cache", "vdo-pool", "vdo"] + lvm.raid_seg_types: ++ if seg_type not in [None, "linear", "thin", "thin-pool", "cache", "vdo-pool", "vdo", "cache-pool"] + lvm.raid_seg_types: + raise ValueError("Invalid or unsupported segment type: %s" % seg_type) + if seg_type and seg_type in lvm.raid_seg_types and not pvs: + raise ValueError("List of PVs has to be given for every non-linear LV") +@@ -690,8 +691,8 @@ class LVMLogicalVolumeBase(DMDevice, RaidDevice): + # we reserve space for it + self._metadata_size = self.vg.pe_size + self._size -= self._metadata_size +- elif self.seg_type == "thin-pool": +- # LVMThinPoolMixin sets self._metadata_size on its own ++ elif self.seg_type in ("thin-pool", "cache_pool"): ++ # LVMThinPoolMixin and LVMCachePoolMixin set self._metadata_size on their own + if not self.exists and not from_lvs and not grow: + # a thin pool we are not going to grow -> lets calculate metadata + # size now if not given explicitly +@@ -1619,7 +1620,6 @@ class LVMThinPoolMixin(object): + """ A list of this pool's LVs """ + return self._lvs[:] # we don't want folks changing our list + +- @util.requires_property("is_thin_pool") + def autoset_md_size(self, enforced=False): + """ If self._metadata_size not set already, it calculates the recommended value + and sets it while subtracting the size from self.size. +@@ -2032,9 +2032,142 @@ class LVMVDOLogicalVolumeMixin(object): + self.pool._add_log_vol(self) + + ++class LVMCachePoolMixin(object): ++ def __init__(self, metadata_size, cache_mode=None): ++ self._metadata_size = metadata_size or Size(0) ++ self._cache_mode = cache_mode ++ ++ def _init_check(self): ++ if not self.is_cache_pool: ++ return ++ ++ if self._metadata_size and not lvm.is_valid_cache_md_size(self._metadata_size): ++ raise ValueError("invalid metadatasize value") ++ ++ if not self.exists and not self._pv_specs: ++ raise ValueError("at least one fast PV must be specified to create a cache pool") ++ ++ def _check_from_lvs(self): ++ if self._from_lvs: ++ if len(self._from_lvs) != 2: ++ raise errors.DeviceError("two LVs required to create a cache pool") ++ ++ def _convert_from_lvs(self): ++ data_lv, metadata_lv = self._from_lvs ++ ++ data_lv.parent_lv = self # also adds the LV to self._internal_lvs ++ data_lv.int_lv_type = LVMInternalLVtype.data ++ metadata_lv.parent_lv = self ++ metadata_lv.int_lv_type = LVMInternalLVtype.meta ++ ++ self.size = data_lv.size ++ ++ @property ++ def is_cache_pool(self): ++ return self.seg_type == "cache-pool" ++ ++ @property ++ def profile(self): ++ return self._profile ++ ++ @property ++ def type(self): ++ return "lvmcachepool" ++ ++ @property ++ def resizable(self): ++ return False ++ ++ def read_current_size(self): ++ log_method_call(self, exists=self.exists, path=self.path, ++ sysfs_path=self.sysfs_path) ++ if self.size != Size(0): ++ return self.size ++ ++ if self.exists: ++ # cache pools are not active and don't have th device mapper mapping ++ # so we can't get this from sysfs ++ lv_info = lvs_info.cache.get(self.name) ++ if lv_info is None: ++ log.error("Failed to get size for existing cache pool '%s'", self.name) ++ return Size(0) ++ else: ++ return Size(lv_info.size) ++ ++ return Size(0) ++ ++ def autoset_md_size(self, enforced=False): ++ """ If self._metadata_size not set already, it calculates the recommended value ++ and sets it while subtracting the size from self.size. ++ ++ """ ++ ++ log.debug("Auto-setting cache pool metadata size") ++ ++ if self._size <= Size(0): ++ log.debug("Cache pool size not bigger than 0, just setting metadata size to 0") ++ self._metadata_size = 0 ++ return ++ ++ old_md_size = self._metadata_size ++ if self._metadata_size == 0 or enforced: ++ self._metadata_size = blockdev.lvm.cache_get_default_md_size(self._size) ++ log.debug("Using recommended metadata size: %s", self._metadata_size) ++ ++ self._metadata_size = self.vg.align(self._metadata_size, roundup=True) ++ log.debug("Rounded metadata size to extents: %s MiB", self._metadata_size.convert_to("MiB")) ++ ++ if self._metadata_size == old_md_size: ++ log.debug("Rounded metadata size unchanged") ++ else: ++ new_size = self.size - (self._metadata_size - old_md_size) ++ log.debug("Adjusting size from %s MiB to %s MiB", ++ self.size.convert_to("MiB"), new_size.convert_to("MiB")) ++ self.size = new_size ++ ++ def _pre_create(self): ++ # make sure all the LVs this LV should be created from exist (if any) ++ if self._from_lvs and any(not lv.exists for lv in self._from_lvs): ++ raise errors.DeviceError("Component LVs need to be created first") ++ ++ def _create(self): ++ """ Create the device. """ ++ log_method_call(self, self.name, status=self.status) ++ if self._cache_mode: ++ try: ++ cache_mode = blockdev.lvm.cache_get_mode_from_str(self._cache_mode) ++ except blockdev.LVMError as e: ++ raise errors.DeviceError from e ++ else: ++ cache_mode = lvm.LVM_CACHE_DEFAULT_MODE ++ ++ if self._from_lvs: ++ extra = dict() ++ if self.mode: ++ # we need the string here, it will be passed directly to he lvm command ++ extra["cachemode"] = self._cache_mode ++ data_lv = six.next(lv for lv in self._internal_lvs if lv.int_lv_type == LVMInternalLVtype.data) ++ meta_lv = six.next(lv for lv in self._internal_lvs if lv.int_lv_type == LVMInternalLVtype.meta) ++ blockdev.lvm.cache_pool_convert(self.vg.name, data_lv.lvname, meta_lv.lvname, self.lvname, **extra) ++ else: ++ blockdev.lvm.cache_create_pool(self.vg.name, self.lvname, self.size, ++ self.metadata_size, ++ cache_mode, ++ 0, ++ [spec.pv.path for spec in self._pv_specs]) ++ ++ def dracut_setup_args(self): ++ return set() ++ ++ @property ++ def direct(self): ++ """ Is this device directly accessible? """ ++ return False ++ ++ + class LVMLogicalVolumeDevice(LVMLogicalVolumeBase, LVMInternalLogicalVolumeMixin, LVMSnapshotMixin, + LVMThinPoolMixin, LVMThinLogicalVolumeMixin, LVMVDOPoolMixin, +- LVMVDOLogicalVolumeMixin): ++ LVMVDOLogicalVolumeMixin, LVMCachePoolMixin): + """ An LVM Logical Volume """ + + # generally resizable, see :property:`resizable` for details +@@ -2046,7 +2179,7 @@ class LVMLogicalVolumeDevice(LVMLogicalVolumeBase, LVMInternalLogicalVolumeMixin + parent_lv=None, int_type=None, origin=None, vorigin=False, + metadata_size=None, chunk_size=None, profile=None, from_lvs=None, + compression=False, deduplication=False, index_memory=0, +- write_policy=None): ++ write_policy=None, cache_mode=None): + """ + :param name: the device name (generally a device node's basename) + :type name: str +@@ -2116,6 +2249,13 @@ class LVMLogicalVolumeDevice(LVMLogicalVolumeBase, LVMInternalLogicalVolumeMixin + :keyword write_policy: write policy for the volume or None for default + :type write_policy: str + ++ For cache pools only: ++ ++ :keyword metadata_size: the size of the metadata LV ++ :type metadata_size: :class:`~.size.Size` ++ :keyword cache_mode: mode for the cache or None for default (writethrough) ++ :type cache_mode: str ++ + """ + + if isinstance(parents, (list, ParentList)): +@@ -2133,6 +2273,7 @@ class LVMLogicalVolumeDevice(LVMLogicalVolumeBase, LVMInternalLogicalVolumeMixin + LVMSnapshotMixin.__init__(self, origin, vorigin) + LVMThinPoolMixin.__init__(self, metadata_size, chunk_size, profile) + LVMThinLogicalVolumeMixin.__init__(self) ++ LVMCachePoolMixin.__init__(self, metadata_size, cache_mode) + LVMLogicalVolumeBase.__init__(self, name, parents, size, uuid, seg_type, + fmt, exists, sysfs_path, grow, maxsize, + percent, cache_request, pvs, from_lvs) +@@ -2144,6 +2285,7 @@ class LVMLogicalVolumeDevice(LVMLogicalVolumeBase, LVMInternalLogicalVolumeMixin + LVMSnapshotMixin._init_check(self) + LVMThinPoolMixin._init_check(self) + LVMThinLogicalVolumeMixin._init_check(self) ++ LVMCachePoolMixin._init_check(self) + + if self._from_lvs: + self._check_from_lvs() +@@ -2169,6 +2311,8 @@ class LVMLogicalVolumeDevice(LVMLogicalVolumeBase, LVMInternalLogicalVolumeMixin + ret.append(LVMVDOPoolMixin) + if self.is_vdo_lv: + ret.append(LVMVDOLogicalVolumeMixin) ++ if self.is_cache_pool: ++ ret.append(LVMCachePoolMixin) + return ret + + def _try_specific_call(self, name, *args, **kwargs): +@@ -2552,6 +2696,10 @@ class LVMLogicalVolumeDevice(LVMLogicalVolumeBase, LVMInternalLogicalVolumeMixin + + return True + ++ @type_specific ++ def autoset_md_size(self, enforced=False): ++ pass ++ + def attach_cache(self, cache_pool_lv): + if self.is_thin_lv or self.is_snapshot_lv or self.is_internal_lv: + raise errors.DeviceError("Cannot attach a cache pool to the '%s' LV" % self.name) +diff --git a/tests/devices_test/lvm_test.py b/tests/devices_test/lvm_test.py +index 59c027da..0105bcae 100644 +--- a/tests/devices_test/lvm_test.py ++++ b/tests/devices_test/lvm_test.py +@@ -868,3 +868,29 @@ class BlivetLVMVDODependenciesTest(unittest.TestCase): + + vdo_supported = devicefactory.is_supported_device_type(devicefactory.DEVICE_TYPE_LVM_VDO) + self.assertFalse(vdo_supported) ++ ++ ++@unittest.skipUnless(not any(x.unavailable_type_dependencies() for x in DEVICE_CLASSES), "some unsupported device classes required for this test") ++class BlivetNewLVMCachePoolDeviceTest(unittest.TestCase): ++ ++ def test_new_cache_pool(self): ++ b = blivet.Blivet() ++ pv = StorageDevice("pv1", fmt=blivet.formats.get_format("lvmpv"), ++ size=Size("10 GiB"), exists=True) ++ vg = LVMVolumeGroupDevice("testvg", parents=[pv], exists=True) ++ ++ for dev in (pv, vg): ++ b.devicetree._add_device(dev) ++ ++ # check that all the above devices are in the expected places ++ self.assertEqual(set(b.devices), {pv, vg}) ++ self.assertEqual(set(b.vgs), {vg}) ++ ++ self.assertEqual(vg.size, Size("10236 MiB")) ++ ++ cachepool = b.new_lv(name="cachepool", cache_pool=True, ++ parents=[vg], pvs=[pv]) ++ ++ b.create_device(cachepool) ++ ++ self.assertEqual(cachepool.type, "lvmcachepool") +-- +2.34.3 + + +From bfb0e71a92f46baae098370207640962c97d8e77 Mon Sep 17 00:00:00 2001 +From: Vojtech Trefny +Date: Thu, 30 Dec 2021 16:09:04 +0100 +Subject: [PATCH 2/4] examples: Add LVM cache pool example + +Related: rhbz#2055200 +--- + examples/lvm_cachepool.py | 59 +++++++++++++++++++++++++++++++++++++++ + 1 file changed, 59 insertions(+) + create mode 100644 examples/lvm_cachepool.py + +diff --git a/examples/lvm_cachepool.py b/examples/lvm_cachepool.py +new file mode 100644 +index 00000000..ab2e8a72 +--- /dev/null ++++ b/examples/lvm_cachepool.py +@@ -0,0 +1,59 @@ ++import os ++ ++import blivet ++from blivet.size import Size ++from blivet.util import set_up_logging, create_sparse_tempfile ++ ++ ++set_up_logging() ++b = blivet.Blivet() # create an instance of Blivet (don't add system devices) ++ ++# create a disk image file on which to create new devices ++disk1_file = create_sparse_tempfile("disk1", Size("100GiB")) ++b.disk_images["disk1"] = disk1_file ++disk2_file = create_sparse_tempfile("disk2", Size("100GiB")) ++b.disk_images["disk2"] = disk2_file ++ ++b.reset() ++ ++try: ++ disk1 = b.devicetree.get_device_by_name("disk1") ++ disk2 = b.devicetree.get_device_by_name("disk2") ++ ++ b.initialize_disk(disk1) ++ b.initialize_disk(disk2) ++ ++ pv = b.new_partition(size=Size("50GiB"), fmt_type="lvmpv", parents=[disk1]) ++ b.create_device(pv) ++ pv2 = b.new_partition(size=Size("50GiB"), fmt_type="lvmpv", parents=[disk2]) ++ b.create_device(pv2) ++ ++ # allocate the partitions (decide where and on which disks they'll reside) ++ blivet.partitioning.do_partitioning(b) ++ ++ vg = b.new_vg(parents=[pv, pv2]) ++ b.create_device(vg) ++ ++ # new lv with base size 5GiB and growth up to 15GiB and an ext4 filesystem ++ lv = b.new_lv(fmt_type="ext4", size=Size("5GiB"), parents=[vg], name="cached") ++ b.create_device(lv) ++ ++ # new cache pool ++ cpool = b.new_lv(size=Size("1 GiB"), parents=[vg], pvs=[pv2], cache_pool=True, name="fastlv") ++ b.create_device(cpool) ++ ++ # write the new partitions to disk and format them as specified ++ b.do_it() ++ print(b.devicetree) ++ ++ # attach the newly created cache pool to the "slow" LV ++ lv.attach_cache(cpool) ++ ++ b.reset() ++ print(b.devicetree) ++ ++ input("Check the state and hit ENTER to trigger cleanup") ++finally: ++ b.devicetree.teardown_disk_images() ++ os.unlink(disk1_file) ++ os.unlink(disk2_file) +-- +2.34.3 + + +From 1fece0e7f15f7b0d457d3db876d23c3272df09bd Mon Sep 17 00:00:00 2001 +From: Vojtech Trefny +Date: Thu, 30 Dec 2021 16:13:33 +0100 +Subject: [PATCH 3/4] lvm: Use blivet static data when checking if the VG is + active + +Instead of calling 'lvs' again in LVMVolumeGroupDevice.status + +Related: rhbz#2055200 +--- + blivet/devices/lvm.py | 9 ++------- + 1 file changed, 2 insertions(+), 7 deletions(-) + +diff --git a/blivet/devices/lvm.py b/blivet/devices/lvm.py +index 7cb482ab..12d3d073 100644 +--- a/blivet/devices/lvm.py ++++ b/blivet/devices/lvm.py +@@ -220,13 +220,8 @@ class LVMVolumeGroupDevice(ContainerDevice): + + # special handling for incomplete VGs + if not self.complete: +- try: +- lvs_info = blockdev.lvm.lvs(vg_name=self.name) +- except blockdev.LVMError: +- lvs_info = [] +- +- for lv_info in lvs_info: +- if lv_info.attr and lv_info.attr[4] == 'a': ++ for lv_info in lvs_info.cache.values(): ++ if lv_info.vg_name == self.name and lv_info.attr and lv_info.attr[4] == 'a': + return True + + return False +-- +2.34.3 + + +From 8d957f04c2d5f56386b978d1bf890450f38ad108 Mon Sep 17 00:00:00 2001 +From: Vojtech Trefny +Date: Mon, 30 May 2022 17:02:43 +0200 +Subject: [PATCH 4/4] Add option to attach a newly created cache pool to + existing LV + +Because we do not have action for attaching the cache pool, we +cannot schedule both adding the fast PV to the VG and attaching +the cache pool to existing LV. This hack allows to schedule the +attach to happen after the cache pool is created. + +Related: rhbz#2055200 +--- + blivet/devices/lvm.py | 38 +++++++++++++++++++++++++++++++++++--- + 1 file changed, 35 insertions(+), 3 deletions(-) + +diff --git a/blivet/devices/lvm.py b/blivet/devices/lvm.py +index 12d3d073..feb92f2e 100644 +--- a/blivet/devices/lvm.py ++++ b/blivet/devices/lvm.py +@@ -2028,9 +2028,10 @@ class LVMVDOLogicalVolumeMixin(object): + + + class LVMCachePoolMixin(object): +- def __init__(self, metadata_size, cache_mode=None): ++ def __init__(self, metadata_size, cache_mode=None, attach_to=None): + self._metadata_size = metadata_size or Size(0) + self._cache_mode = cache_mode ++ self._attach_to = attach_to + + def _init_check(self): + if not self.is_cache_pool: +@@ -2042,6 +2043,9 @@ class LVMCachePoolMixin(object): + if not self.exists and not self._pv_specs: + raise ValueError("at least one fast PV must be specified to create a cache pool") + ++ if self._attach_to and not self._attach_to.exists: ++ raise ValueError("cache pool can be attached only to an existing LV") ++ + def _check_from_lvs(self): + if self._from_lvs: + if len(self._from_lvs) != 2: +@@ -2150,6 +2154,31 @@ class LVMCachePoolMixin(object): + cache_mode, + 0, + [spec.pv.path for spec in self._pv_specs]) ++ if self._attach_to: ++ self._attach_to.attach_cache(self) ++ ++ def _post_create(self): ++ if self._attach_to: ++ # post_create tries to activate the LV and after attaching it no longer exists ++ return ++ ++ # pylint: disable=bad-super-call ++ super(LVMLogicalVolumeBase, self)._post_create() ++ ++ def add_hook(self, new=True): ++ if self._attach_to: ++ self._attach_to._cache = LVMCache(self._attach_to, size=self.size, exists=False, ++ pvs=self._pv_specs, mode=self._cache_mode) ++ ++ # pylint: disable=bad-super-call ++ super(LVMLogicalVolumeBase, self).add_hook(new=new) ++ ++ def remove_hook(self, modparent=True): ++ if self._attach_to: ++ self._attach_to._cache = None ++ ++ # pylint: disable=bad-super-call ++ super(LVMLogicalVolumeBase, self).remove_hook(modparent=modparent) + + def dracut_setup_args(self): + return set() +@@ -2174,7 +2203,7 @@ class LVMLogicalVolumeDevice(LVMLogicalVolumeBase, LVMInternalLogicalVolumeMixin + parent_lv=None, int_type=None, origin=None, vorigin=False, + metadata_size=None, chunk_size=None, profile=None, from_lvs=None, + compression=False, deduplication=False, index_memory=0, +- write_policy=None, cache_mode=None): ++ write_policy=None, cache_mode=None, attach_to=None): + """ + :param name: the device name (generally a device node's basename) + :type name: str +@@ -2250,6 +2279,9 @@ class LVMLogicalVolumeDevice(LVMLogicalVolumeBase, LVMInternalLogicalVolumeMixin + :type metadata_size: :class:`~.size.Size` + :keyword cache_mode: mode for the cache or None for default (writethrough) + :type cache_mode: str ++ :keyword attach_to: for non-existing cache pools a logical volume the pool should ++ be attached to when created ++ :type attach_to: :class:`LVMLogicalVolumeDevice` + + """ + +@@ -2268,7 +2300,7 @@ class LVMLogicalVolumeDevice(LVMLogicalVolumeBase, LVMInternalLogicalVolumeMixin + LVMSnapshotMixin.__init__(self, origin, vorigin) + LVMThinPoolMixin.__init__(self, metadata_size, chunk_size, profile) + LVMThinLogicalVolumeMixin.__init__(self) +- LVMCachePoolMixin.__init__(self, metadata_size, cache_mode) ++ LVMCachePoolMixin.__init__(self, metadata_size, cache_mode, attach_to) + LVMLogicalVolumeBase.__init__(self, name, parents, size, uuid, seg_type, + fmt, exists, sysfs_path, grow, maxsize, + percent, cache_request, pvs, from_lvs) +-- +2.34.3 + diff --git a/SOURCES/0023-Use-LVM-PV-format-current_size-in-LVMVolumeGroupDevi.patch b/SOURCES/0023-Use-LVM-PV-format-current_size-in-LVMVolumeGroupDevi.patch new file mode 100644 index 0000000..59e40e4 --- /dev/null +++ b/SOURCES/0023-Use-LVM-PV-format-current_size-in-LVMVolumeGroupDevi.patch @@ -0,0 +1,29 @@ +From 4103df5ddaae49d51640d01502e8456409a92be9 Mon Sep 17 00:00:00 2001 +From: Vojtech Trefny +Date: Thu, 5 May 2022 16:35:37 +0200 +Subject: [PATCH] Use LVM PV format current_size in + LVMVolumeGroupDevice._remove + +The member format size is 0 when target size is not set. + +Related: rhbz#2081278 +--- + blivet/devices/lvm.py | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/blivet/devices/lvm.py b/blivet/devices/lvm.py +index feb92f2e..facb1b76 100644 +--- a/blivet/devices/lvm.py ++++ b/blivet/devices/lvm.py +@@ -289,7 +289,7 @@ class LVMVolumeGroupDevice(ContainerDevice): + + # do not run pvmove on empty PVs + member.format.update_size_info() +- if member.format.free < member.format.size: ++ if member.format.free < member.format.current_size: + blockdev.lvm.pvmove(member.path) + blockdev.lvm.vgreduce(self.name, member.path) + +-- +2.34.3 + diff --git a/SOURCES/0024-tests-Mark-fake-disks-in-test_get_related_disks-as-n.patch b/SOURCES/0024-tests-Mark-fake-disks-in-test_get_related_disks-as-n.patch new file mode 100644 index 0000000..6b52a0d --- /dev/null +++ b/SOURCES/0024-tests-Mark-fake-disks-in-test_get_related_disks-as-n.patch @@ -0,0 +1,36 @@ +From a709c4db1bcf2e7ff69158a54ed3a1ea92ba4f97 Mon Sep 17 00:00:00 2001 +From: Vojtech Trefny +Date: Thu, 14 Oct 2021 08:48:05 +0200 +Subject: [PATCH] tests: Mark "fake" disks in test_get_related_disks as + non-existing + +We are using "real" disk names ("sda", "sdb"...) in this test so +we need to avoid reading their real sizes which we do for existing +devices using os.stat. The test can fail if we have a disk with +the same name and small (or zero) size. + +Resolves: rhbz#2062690 +--- + tests/devicetree_test.py | 6 +++--- + 1 file changed, 3 insertions(+), 3 deletions(-) + +diff --git a/tests/devicetree_test.py b/tests/devicetree_test.py +index 3be4d572..c1b97c52 100644 +--- a/tests/devicetree_test.py ++++ b/tests/devicetree_test.py +@@ -406,9 +406,9 @@ class DeviceTreeTestCase(unittest.TestCase): + def test_get_related_disks(self): + tree = DeviceTree() + +- sda = DiskDevice("sda", size=Size('300g')) +- sdb = DiskDevice("sdb", size=Size('300g')) +- sdc = DiskDevice("sdc", size=Size('300G')) ++ sda = DiskDevice("sda", size=Size('300g'), exists=False) ++ sdb = DiskDevice("sdb", size=Size('300g'), exists=False) ++ sdc = DiskDevice("sdc", size=Size('300G'), exists=False) + + tree._add_device(sda) + tree._add_device(sdb) +-- +2.34.3 + diff --git a/SOURCES/0025-Add-support-for-NPIV-enabled-zFCP-devices.patch b/SOURCES/0025-Add-support-for-NPIV-enabled-zFCP-devices.patch new file mode 100644 index 0000000..25d5898 --- /dev/null +++ b/SOURCES/0025-Add-support-for-NPIV-enabled-zFCP-devices.patch @@ -0,0 +1,789 @@ +From 35643156c511c8120f2d562c1664a3c7a5a48cfb Mon Sep 17 00:00:00 2001 +From: Jan Stodola +Date: Thu, 28 Oct 2021 21:17:25 +0200 +Subject: [PATCH 1/8] Fix removing zFCP SCSI devices + +Values parsed from /proc/scsi/scsi were not correctly used to assemble +paths to SCSI devices. + +For example: +/sys/bus/scsi/devices/0:0:00:00/ +was incorrectly accessed instead of: +/sys/bus/scsi/devices/0:0:0:0/ + +Switch to a more reliable way of listing the available SCSI devices. + +Related: rhbz#1937030 +--- + blivet/zfcp.py | 17 ++++------------- + 1 file changed, 4 insertions(+), 13 deletions(-) + +diff --git a/blivet/zfcp.py b/blivet/zfcp.py +index 93af5419..3747290e 100644 +--- a/blivet/zfcp.py ++++ b/blivet/zfcp.py +@@ -20,6 +20,7 @@ + # + + import os ++import re + from . import udev + from . import util + from .i18n import _ +@@ -167,20 +168,10 @@ class ZFCPDevice: + return True + + def offline_scsi_device(self): +- f = open("/proc/scsi/scsi", "r") +- lines = f.readlines() +- f.close() +- # alternatively iterate over /sys/bus/scsi/devices/*:0:*:*/ ++ # A list of existing SCSI devices in format Host:Bus:Target:Lun ++ scsi_devices = [f for f in os.listdir(scsidevsysfs) if re.search(r'^[0-9]+:[0-9]+:[0-9]+:[0-9]+$', f)] + +- for line in lines: +- if not line.startswith("Host"): +- continue +- scsihost = line.split() +- host = scsihost[1] +- channel = "0" +- devid = scsihost[5] +- lun = scsihost[7] +- scsidev = "%s:%s:%s:%s" % (host[4:], channel, devid, lun) ++ for scsidev in scsi_devices: + fcpsysfs = "%s/%s" % (scsidevsysfs, scsidev) + scsidel = "%s/%s/delete" % (scsidevsysfs, scsidev) + +-- +2.34.3 + + +From 771cbf623030b1fa51ec193a2b5e2db229420a7a Mon Sep 17 00:00:00 2001 +From: Jan Stodola +Date: Sun, 21 Nov 2021 02:47:45 +0100 +Subject: [PATCH 2/8] Refactor the ZFCPDevice class + +Add a new base class for zFCP devices. +Move code to the new base class. +Improve documentation. + +Related: rhbz#1937030 +--- + blivet/zfcp.py | 131 +++++++++++++++++++++++++++++++++++-------------- + 1 file changed, 95 insertions(+), 36 deletions(-) + +diff --git a/blivet/zfcp.py b/blivet/zfcp.py +index 3747290e..4a50f65f 100644 +--- a/blivet/zfcp.py ++++ b/blivet/zfcp.py +@@ -21,6 +21,7 @@ + + import os + import re ++from abc import ABC + from . import udev + from . import util + from .i18n import _ +@@ -46,29 +47,19 @@ zfcpsysfs = "/sys/bus/ccw/drivers/zfcp" + scsidevsysfs = "/sys/bus/scsi/devices" + zfcpconf = "/etc/zfcp.conf" + ++class ZFCPDeviceBase(ABC): ++ """An abstract base class for zFCP storage devices.""" + +-class ZFCPDevice: +- """ +- .. warning:: +- Since this is a singleton class, calling deepcopy() on the instance +- just returns ``self`` with no copy being created. +- """ +- +- def __init__(self, devnum, wwpn, fcplun): ++ def __init__(self, devnum): + self.devnum = blockdev.s390.sanitize_dev_input(devnum) +- self.wwpn = blockdev.s390.zfcp_sanitize_wwpn_input(wwpn) +- self.fcplun = blockdev.s390.zfcp_sanitize_lun_input(fcplun) +- + if not self.devnum: + raise ValueError(_("You have not specified a device number or the number is invalid")) +- if not self.wwpn: +- raise ValueError(_("You have not specified a worldwide port name or the name is invalid.")) +- if not self.fcplun: +- raise ValueError(_("You have not specified a FCP LUN or the number is invalid.")) ++ ++ self._device_online_path = os.path.join(zfcpsysfs, self.devnum, "online") + + # Force str and unicode types in case any of the properties are unicode + def _to_string(self): +- return "%s %s %s" % (self.devnum, self.wwpn, self.fcplun) ++ return str(self.devnum) + + def __str__(self): + return stringize(self._to_string()) +@@ -76,33 +67,97 @@ class ZFCPDevice: + def __unicode__(self): + return unicodeize(self._to_string()) + +- def online_device(self): +- online = "%s/%s/online" % (zfcpsysfs, self.devnum) +- portadd = "%s/%s/port_add" % (zfcpsysfs, self.devnum) +- portdir = "%s/%s/%s" % (zfcpsysfs, self.devnum, self.wwpn) +- unitadd = "%s/unit_add" % (portdir) +- unitdir = "%s/%s" % (portdir, self.fcplun) +- failed = "%s/failed" % (unitdir) ++ def _free_device(self): ++ """Remove the device from the I/O ignore list to make it visible to the system. ++ ++ :raises: ValueError if the device cannot be removed from the I/O ignore list ++ """ + +- if not os.path.exists(online): ++ if not os.path.exists(self._device_online_path): + log.info("Freeing zFCP device %s", self.devnum) + util.run_program(["zfcp_cio_free", "-d", self.devnum]) + +- if not os.path.exists(online): ++ if not os.path.exists(self._device_online_path): + raise ValueError(_("zFCP device %s not found, not even in device ignore list.") % + (self.devnum,)) + ++ def _set_zfcp_device_online(self): ++ """Set the zFCP device online. ++ ++ :raises: ValueError if the device cannot be set online ++ """ ++ + try: +- f = open(online, "r") +- devonline = f.readline().strip() +- f.close() ++ with open(self._device_online_path) as f: ++ devonline = f.readline().strip() + if devonline != "1": +- logged_write_line_to_file(online, "1") ++ logged_write_line_to_file(self._device_online_path, "1") + except OSError as e: + raise ValueError(_("Could not set zFCP device %(devnum)s " + "online (%(e)s).") + % {'devnum': self.devnum, 'e': e}) + ++ def _set_zfcp_device_offline(self): ++ """Set the zFCP device offline. ++ ++ :raises: ValueError if the device cannot be set offline ++ """ ++ ++ try: ++ logged_write_line_to_file(self._device_online_path, "0") ++ except OSError as e: ++ raise ValueError(_("Could not set zFCP device %(devnum)s " ++ "offline (%(e)s).") ++ % {'devnum': self.devnum, 'e': e}) ++ ++ def online_device(self): ++ """Initialize the device and make its storage block device(s) ready to use. ++ ++ :returns: True if success ++ :raises: ValueError if the device cannot be initialized ++ """ ++ ++ self._free_device() ++ self._set_zfcp_device_online() ++ return True ++ ++ ++class ZFCPDevice(ZFCPDeviceBase): ++ """A class for zFCP devices that are not configured in NPIV mode. Such ++ devices have to be specified by a device number, WWPN and LUN. ++ """ ++ ++ def __init__(self, devnum, wwpn, fcplun): ++ super().__init__(devnum) ++ ++ self.wwpn = blockdev.s390.zfcp_sanitize_wwpn_input(wwpn) ++ if not self.wwpn: ++ raise ValueError(_("You have not specified a worldwide port name or the name is invalid.")) ++ ++ self.fcplun = blockdev.s390.zfcp_sanitize_lun_input(fcplun) ++ if not self.fcplun: ++ raise ValueError(_("You have not specified a FCP LUN or the number is invalid.")) ++ ++ # Force str and unicode types in case any of the properties are unicode ++ def _to_string(self): ++ return "{} {} {}".format(self.devnum, self.wwpn, self.fcplun) ++ ++ def online_device(self): ++ """Initialize the device and make its storage block device(s) ready to use. ++ ++ :returns: True if success ++ :raises: ValueError if the device cannot be initialized ++ """ ++ ++ super().online_device() ++ ++ portadd = "%s/%s/port_add" % (zfcpsysfs, self.devnum) ++ portdir = "%s/%s/%s" % (zfcpsysfs, self.devnum, self.wwpn) ++ unitadd = "%s/unit_add" % (portdir) ++ unitdir = "%s/%s" % (portdir, self.fcplun) ++ failed = "%s/failed" % (unitdir) ++ ++ # create the sysfs directory for the WWPN/port + if not os.path.exists(portdir): + if os.path.exists(portadd): + # older zfcp sysfs interface +@@ -127,6 +182,7 @@ class ZFCPDevice: + "there.", {'wwpn': self.wwpn, + 'devnum': self.devnum}) + ++ # create the sysfs directory for the LUN/unit + if not os.path.exists(unitdir): + try: + logged_write_line_to_file(unitadd, self.fcplun) +@@ -144,6 +200,7 @@ class ZFCPDevice: + 'wwpn': self.wwpn, + 'devnum': self.devnum}) + ++ # check the state of the LUN + fail = "0" + try: + f = open(failed, "r") +@@ -168,6 +225,8 @@ class ZFCPDevice: + return True + + def offline_scsi_device(self): ++ """Find SCSI devices associated to the zFCP device and remove them from the system.""" ++ + # A list of existing SCSI devices in format Host:Bus:Target:Lun + scsi_devices = [f for f in os.listdir(scsidevsysfs) if re.search(r'^[0-9]+:[0-9]+:[0-9]+:[0-9]+$', f)] + +@@ -196,7 +255,8 @@ class ZFCPDevice: + self.devnum, self.wwpn, self.fcplun) + + def offline_device(self): +- offline = "%s/%s/online" % (zfcpsysfs, self.devnum) ++ """Remove the zFCP device from the system.""" ++ + portadd = "%s/%s/port_add" % (zfcpsysfs, self.devnum) + portremove = "%s/%s/port_remove" % (zfcpsysfs, self.devnum) + unitremove = "%s/%s/%s/unit_remove" % (zfcpsysfs, self.devnum, self.wwpn) +@@ -212,6 +272,7 @@ class ZFCPDevice: + % {'devnum': self.devnum, 'wwpn': self.wwpn, + 'fcplun': self.fcplun, 'e': e}) + ++ # remove the LUN + try: + logged_write_line_to_file(unitremove, self.fcplun) + except OSError as e: +@@ -221,6 +282,7 @@ class ZFCPDevice: + % {'fcplun': self.fcplun, 'wwpn': self.wwpn, + 'devnum': self.devnum, 'e': e}) + ++ # remove the WWPN only if there are no other LUNs attached + if os.path.exists(portadd): + # only try to remove ports with older zfcp sysfs interface + for lun in os.listdir(portdir): +@@ -238,6 +300,7 @@ class ZFCPDevice: + % {'wwpn': self.wwpn, + 'devnum': self.devnum, 'e': e}) + ++ # check if there are other WWPNs existing for the zFCP device number + if os.path.exists(portadd): + # older zfcp sysfs interface + for port in os.listdir(devdir): +@@ -256,12 +319,8 @@ class ZFCPDevice: + self.devnum, luns[0]) + return True + +- try: +- logged_write_line_to_file(offline, "0") +- except OSError as e: +- raise ValueError(_("Could not set zFCP device %(devnum)s " +- "offline (%(e)s).") +- % {'devnum': self.devnum, 'e': e}) ++ # no other WWPNs/LUNs exists for this device number, it's safe to bring it offline ++ self._set_zfcp_device_offline() + + return True + +-- +2.34.3 + + +From 2dc44c00f170d64458a7c89abc91cda61af8387f Mon Sep 17 00:00:00 2001 +From: Jan Stodola +Date: Sun, 21 Nov 2021 02:35:05 +0100 +Subject: [PATCH 3/8] Move offline_scsi_device() to the base class + +Related: rhbz#1937030 +--- + blivet/zfcp.py | 74 ++++++++++++++++++++++++++++++-------------------- + 1 file changed, 44 insertions(+), 30 deletions(-) + +diff --git a/blivet/zfcp.py b/blivet/zfcp.py +index 4a50f65f..af8f841d 100644 +--- a/blivet/zfcp.py ++++ b/blivet/zfcp.py +@@ -110,6 +110,15 @@ class ZFCPDeviceBase(ABC): + "offline (%(e)s).") + % {'devnum': self.devnum, 'e': e}) + ++ def _is_scsi_associated_with_fcp(self, fcphbasysfs, _fcpwwpnsysfs, _fcplunsysfs): ++ """Decide if the SCSI device with the provided SCSI attributes ++ corresponds to the zFCP device. ++ ++ :returns: True or False ++ """ ++ ++ return fcphbasysfs == self.devnum ++ + def online_device(self): + """Initialize the device and make its storage block device(s) ready to use. + +@@ -121,6 +130,30 @@ class ZFCPDeviceBase(ABC): + self._set_zfcp_device_online() + return True + ++ def offline_scsi_device(self): ++ """Find SCSI devices associated to the zFCP device and remove them from the system.""" ++ ++ # A list of existing SCSI devices in format Host:Bus:Target:Lun ++ scsi_devices = [f for f in os.listdir(scsidevsysfs) if re.search(r'^[0-9]+:[0-9]+:[0-9]+:[0-9]+$', f)] ++ ++ for scsidev in scsi_devices: ++ fcpsysfs = os.path.join(scsidevsysfs, scsidev) ++ ++ with open(os.path.join(fcpsysfs, "hba_id")) as f: ++ fcphbasysfs = f.readline().strip() ++ with open(os.path.join(fcpsysfs, "wwpn")) as f: ++ fcpwwpnsysfs = f.readline().strip() ++ with open(os.path.join(fcpsysfs, "fcp_lun")) as f: ++ fcplunsysfs = f.readline().strip() ++ ++ if self._is_scsi_associated_with_fcp(fcphbasysfs, fcpwwpnsysfs, fcplunsysfs): ++ scsidel = os.path.join(scsidevsysfs, scsidev, "delete") ++ logged_write_line_to_file(scsidel, "1") ++ udev.settle() ++ return ++ ++ log.warning("No scsi device found to delete for zfcp %s", self) ++ + + class ZFCPDevice(ZFCPDeviceBase): + """A class for zFCP devices that are not configured in NPIV mode. Such +@@ -142,6 +175,17 @@ class ZFCPDevice(ZFCPDeviceBase): + def _to_string(self): + return "{} {} {}".format(self.devnum, self.wwpn, self.fcplun) + ++ def _is_scsi_associated_with_fcp(self, fcphbasysfs, fcpwwpnsysfs, fcplunsysfs): ++ """Decide if the SCSI device with the provided SCSI attributes ++ corresponds to the zFCP device. ++ ++ :returns: True or False ++ """ ++ ++ return (fcphbasysfs == self.devnum and ++ fcpwwpnsysfs == self.wwpn and ++ fcplunsysfs == self.fcplun) ++ + def online_device(self): + """Initialize the device and make its storage block device(s) ready to use. + +@@ -224,36 +268,6 @@ class ZFCPDevice(ZFCPDeviceBase): + + return True + +- def offline_scsi_device(self): +- """Find SCSI devices associated to the zFCP device and remove them from the system.""" +- +- # A list of existing SCSI devices in format Host:Bus:Target:Lun +- scsi_devices = [f for f in os.listdir(scsidevsysfs) if re.search(r'^[0-9]+:[0-9]+:[0-9]+:[0-9]+$', f)] +- +- for scsidev in scsi_devices: +- fcpsysfs = "%s/%s" % (scsidevsysfs, scsidev) +- scsidel = "%s/%s/delete" % (scsidevsysfs, scsidev) +- +- f = open("%s/hba_id" % (fcpsysfs), "r") +- fcphbasysfs = f.readline().strip() +- f.close() +- f = open("%s/wwpn" % (fcpsysfs), "r") +- fcpwwpnsysfs = f.readline().strip() +- f.close() +- f = open("%s/fcp_lun" % (fcpsysfs), "r") +- fcplunsysfs = f.readline().strip() +- f.close() +- +- if fcphbasysfs == self.devnum \ +- and fcpwwpnsysfs == self.wwpn \ +- and fcplunsysfs == self.fcplun: +- logged_write_line_to_file(scsidel, "1") +- udev.settle() +- return +- +- log.warning("no scsi device found to delete for zfcp %s %s %s", +- self.devnum, self.wwpn, self.fcplun) +- + def offline_device(self): + """Remove the zFCP device from the system.""" + +-- +2.34.3 + + +From f194c6e591c3e409f227fd10d3e9923af91ea893 Mon Sep 17 00:00:00 2001 +From: Jan Stodola +Date: Sat, 6 Nov 2021 21:27:52 +0100 +Subject: [PATCH 4/8] Allow to delete more than one SCSI device + +NPIV zFCP devices can attach more than one SCSI device, so allow to +delete them all. For non-NPIV devices it means possible slowdown, since +all SCSI devices would now be checked. + +Related: rhbz#1937030 +--- + blivet/zfcp.py | 6 ++++-- + 1 file changed, 4 insertions(+), 2 deletions(-) + +diff --git a/blivet/zfcp.py b/blivet/zfcp.py +index af8f841d..3b3f623b 100644 +--- a/blivet/zfcp.py ++++ b/blivet/zfcp.py +@@ -136,6 +136,7 @@ class ZFCPDeviceBase(ABC): + # A list of existing SCSI devices in format Host:Bus:Target:Lun + scsi_devices = [f for f in os.listdir(scsidevsysfs) if re.search(r'^[0-9]+:[0-9]+:[0-9]+:[0-9]+$', f)] + ++ scsi_device_found = False + for scsidev in scsi_devices: + fcpsysfs = os.path.join(scsidevsysfs, scsidev) + +@@ -147,12 +148,13 @@ class ZFCPDeviceBase(ABC): + fcplunsysfs = f.readline().strip() + + if self._is_scsi_associated_with_fcp(fcphbasysfs, fcpwwpnsysfs, fcplunsysfs): ++ scsi_device_found = True + scsidel = os.path.join(scsidevsysfs, scsidev, "delete") + logged_write_line_to_file(scsidel, "1") + udev.settle() +- return + +- log.warning("No scsi device found to delete for zfcp %s", self) ++ if not scsi_device_found: ++ log.warning("No scsi device found to delete for zfcp %s", self) + + + class ZFCPDevice(ZFCPDeviceBase): +-- +2.34.3 + + +From f6615be663434079b3f2a86be5db88b816d8a9e1 Mon Sep 17 00:00:00 2001 +From: Jan Stodola +Date: Sun, 21 Nov 2021 03:01:02 +0100 +Subject: [PATCH 5/8] Add a function for reading the value of a kernel module + parameter + +Related: rhbz#1937030 +--- + blivet/util.py | 33 +++++++++++++++++++++++++++++++++ + tests/util_test.py | 11 +++++++++++ + 2 files changed, 44 insertions(+) + +diff --git a/blivet/util.py b/blivet/util.py +index af60210b..cbef65e0 100644 +--- a/blivet/util.py ++++ b/blivet/util.py +@@ -1131,3 +1131,36 @@ def detect_virt(): + return False + else: + return vm[0] in ('qemu', 'kvm', 'xen') ++ ++ ++def natural_sort_key(device): ++ """ Sorting key for devices which makes sure partitions are sorted in natural ++ way, e.g. 'sda1, sda2, ..., sda10' and not like 'sda1, sda10, sda2, ...' ++ """ ++ if device.type == "partition" and device.parted_partition and device.disk: ++ part_num = getattr(device.parted_partition, "number", -1) ++ return [device.disk.name, part_num] ++ else: ++ return [device.name, 0] ++ ++ ++def get_kernel_module_parameter(module, parameter): ++ """ Return the value of a given kernel module parameter ++ ++ :param str module: a kernel module ++ :param str parameter: a module parameter ++ :returns: the value of the given kernel module parameter or None ++ :rtype: str ++ """ ++ ++ value = None ++ ++ parameter_path = os.path.join("/sys/module", module, "parameters", parameter) ++ try: ++ with open(parameter_path) as f: ++ value = f.read().strip() ++ except IOError as e: ++ log.warning("Couldn't get the value of the parameter '%s' from the kernel module '%s': %s", ++ parameter, module, str(e)) ++ ++ return value +diff --git a/tests/util_test.py b/tests/util_test.py +index b4f82c1b..805447c7 100644 +--- a/tests/util_test.py ++++ b/tests/util_test.py +@@ -182,3 +182,14 @@ class GetSysfsAttrTestCase(unittest.TestCase): + # the unicode replacement character (U+FFFD) should be used instead + model = util.get_sysfs_attr(sysfs, "model") + self.assertEqual(model, "test model\ufffd") ++ ++ ++class GetKernelModuleParameterTestCase(unittest.TestCase): ++ ++ def test_nonexisting_kernel_module(self): ++ self.assertIsNone(util.get_kernel_module_parameter("unknown_module", "unknown_parameter")) ++ ++ def test_get_kernel_module_parameter_value(self): ++ with mock.patch('blivet.util.open', mock.mock_open(read_data='value\n')): ++ value = util.get_kernel_module_parameter("module", "parameter") ++ self.assertEqual(value, "value") +-- +2.34.3 + + +From 17c99a2444ef750bdbf5b24665c5fd3c52e687d9 Mon Sep 17 00:00:00 2001 +From: Jan Stodola +Date: Sun, 21 Nov 2021 03:01:46 +0100 +Subject: [PATCH 6/8] LUN and WWPN should not be used for NPIV zFCP devices + +Log a warning if activating a zFCP device in NPIV mode and WWPN or +LUN have been provided. They are superfluous for NPIV devices. + +Related: rhbz#1937030 +--- + blivet/zfcp.py | 58 +++++++++++++++++++++++++++++++++++++++++++++++++- + 1 file changed, 57 insertions(+), 1 deletion(-) + +diff --git a/blivet/zfcp.py b/blivet/zfcp.py +index 3b3f623b..726e9364 100644 +--- a/blivet/zfcp.py ++++ b/blivet/zfcp.py +@@ -22,6 +22,7 @@ + import os + import re + from abc import ABC ++import glob + from . import udev + from . import util + from .i18n import _ +@@ -47,6 +48,55 @@ zfcpsysfs = "/sys/bus/ccw/drivers/zfcp" + scsidevsysfs = "/sys/bus/scsi/devices" + zfcpconf = "/etc/zfcp.conf" + ++ ++def _is_lun_scan_allowed(): ++ """Return True if automatic LUN scanning is enabled by the kernel.""" ++ ++ allow_lun_scan = util.get_kernel_module_parameter("zfcp", "allow_lun_scan") ++ return allow_lun_scan == "Y" ++ ++ ++def _is_port_in_npiv_mode(device_id): ++ """Return True if the device ID is configured in NPIV mode. See ++ https://www.ibm.com/docs/en/linux-on-systems?topic=devices-use-npiv ++ """ ++ ++ port_in_npiv_mode = False ++ port_type_path = "/sys/bus/ccw/devices/{}/host*/fc_host/host*/port_type".format(device_id) ++ port_type_paths = glob.glob(port_type_path) ++ try: ++ for filename in port_type_paths: ++ with open(filename) as f: ++ port_type = f.read() ++ if re.search(r"(^|\s)NPIV(\s|$)", port_type): ++ port_in_npiv_mode = True ++ except OSError as e: ++ log.warning("Couldn't read the port_type attribute of the %s device: %s", device_id, str(e)) ++ port_in_npiv_mode = False ++ ++ return port_in_npiv_mode ++ ++ ++def is_npiv_enabled(device_id): ++ """Return True if the given zFCP device ID is configured and usable in ++ NPIV (N_Port ID Virtualization) mode. ++ ++ :returns: True or False ++ """ ++ ++ # LUN scanning disabled by the kernel module prevents using the device in NPIV mode ++ if not _is_lun_scan_allowed(): ++ log.warning("Automatic LUN scanning is disabled by the zfcp kernel module.") ++ return False ++ ++ # The port itself has to be configured in NPIV mode ++ if not _is_port_in_npiv_mode(device_id): ++ log.warning("The zFCP device %s is not configured in NPIV mode.", device_id) ++ return False ++ ++ return True ++ ++ + class ZFCPDeviceBase(ABC): + """An abstract base class for zFCP storage devices.""" + +@@ -203,6 +253,13 @@ class ZFCPDevice(ZFCPDeviceBase): + unitdir = "%s/%s" % (portdir, self.fcplun) + failed = "%s/failed" % (unitdir) + ++ # Activating an NPIV enabled device using devnum, WWPN and LUN should still be possible ++ # as this method was used as a workaround until the support for NPIV enabled devices has ++ # been implemented. Just log a warning message and continue. ++ if is_npiv_enabled(self.devnum): ++ log.warning("zFCP device %s in NPIV mode brought online. All LUNs will be activated " ++ "automatically although WWPN and LUN have been provided.", self.devnum) ++ + # create the sysfs directory for the WWPN/port + if not os.path.exists(portdir): + if os.path.exists(portadd): +@@ -327,7 +384,6 @@ class ZFCPDevice(ZFCPDeviceBase): + return True + else: + # newer zfcp sysfs interface with auto port scan +- import glob + luns = glob.glob("%s/0x????????????????/0x????????????????" + % (devdir,)) + if len(luns) != 0: +-- +2.34.3 + + +From a8f97bd0d74e3da9c18bd03d968f5d2f0c3ee46f Mon Sep 17 00:00:00 2001 +From: Jan Stodola +Date: Sat, 6 Nov 2021 21:27:52 +0100 +Subject: [PATCH 7/8] Add new class for NPIV-enabled devices + +Related: rhbz#1937030 +--- + blivet/zfcp.py | 53 +++++++++++++++++++++++++++++++++++++++++++++++--- + 1 file changed, 50 insertions(+), 3 deletions(-) + +diff --git a/blivet/zfcp.py b/blivet/zfcp.py +index 726e9364..e6c0e48a 100644 +--- a/blivet/zfcp.py ++++ b/blivet/zfcp.py +@@ -397,6 +397,44 @@ class ZFCPDevice(ZFCPDeviceBase): + return True + + ++class ZFCPNPIVDevice(ZFCPDeviceBase): ++ """Class for zFCP devices configured in NPIV mode. Only a zFCP device number is ++ needed for such devices. ++ """ ++ ++ def online_device(self): ++ """Initialize the device and make its storage block device(s) ready to use. ++ ++ :returns: True if success ++ :raises: ValueError if the device cannot be initialized ++ """ ++ ++ super().online_device() ++ ++ if not is_npiv_enabled(self.devnum): ++ raise ValueError(_("zFCP device %s cannot be used in NPIV mode.") % self) ++ ++ return True ++ ++ def offline_device(self): ++ """Remove the zFCP device from the system. ++ ++ :returns: True if success ++ :raises: ValueError if the device cannot be brought offline ++ """ ++ ++ try: ++ self.offline_scsi_device() ++ except OSError as e: ++ raise ValueError(_("Could not correctly delete SCSI device of " ++ "zFCP %(zfcpdev)s (%(e)s).") ++ % {'zfcpdev': self, 'e': e}) ++ ++ self._set_zfcp_device_offline() ++ ++ return True ++ ++ + class zFCP: + + """ ZFCP utility class. +@@ -439,7 +477,12 @@ class zFCP: + + fields = line.split() + +- if len(fields) == 3: ++ # NPIV enabled device ++ if len(fields) == 1: ++ devnum = fields[0] ++ wwpn = None ++ fcplun = None ++ elif len(fields) == 3: + devnum = fields[0] + wwpn = fields[1] + fcplun = fields[2] +@@ -458,8 +501,12 @@ class zFCP: + except ValueError as e: + log.warning("%s", str(e)) + +- def add_fcp(self, devnum, wwpn, fcplun): +- d = ZFCPDevice(devnum, wwpn, fcplun) ++ def add_fcp(self, devnum, wwpn=None, fcplun=None): ++ if wwpn and fcplun: ++ d = ZFCPDevice(devnum, wwpn, fcplun) ++ else: ++ d = ZFCPNPIVDevice(devnum) ++ + if d.online_device(): + self.fcpdevs.add(d) + +-- +2.34.3 + + +From 963822ff989c938e74d582216f4f7ded595eccc1 Mon Sep 17 00:00:00 2001 +From: Jan Stodola +Date: Sat, 20 Nov 2021 23:12:43 +0100 +Subject: [PATCH 8/8] Generate correct dracut boot arguments for NPIV devices + +NPIV enabled devices need only the device ID. WWPNs/LUNs are discovered +automatically by the kernel module. + +Resolves: rhbz#1937030 +--- + blivet/devices/disk.py | 10 +++++++++- + 1 file changed, 9 insertions(+), 1 deletion(-) + +diff --git a/blivet/devices/disk.py b/blivet/devices/disk.py +index 67a01ba6..36278507 100644 +--- a/blivet/devices/disk.py ++++ b/blivet/devices/disk.py +@@ -577,7 +577,15 @@ class ZFCPDiskDevice(DiskDevice): + 'lun': self.fcp_lun} + + def dracut_setup_args(self): +- return set(["rd.zfcp=%s,%s,%s" % (self.hba_id, self.wwpn, self.fcp_lun,)]) ++ from ..zfcp import is_npiv_enabled ++ ++ # zFCP devices in NPIV mode need only the device ID ++ if is_npiv_enabled(self.hba_id): ++ dracut_args = set(["rd.zfcp=%s" % self.hba_id]) ++ else: ++ dracut_args = set(["rd.zfcp=%s,%s,%s" % (self.hba_id, self.wwpn, self.fcp_lun,)]) ++ ++ return dracut_args + + + class DASDDevice(DiskDevice): +-- +2.34.3 + diff --git a/SOURCES/0026-Add-a-very-simple-NVMe-module.patch b/SOURCES/0026-Add-a-very-simple-NVMe-module.patch new file mode 100644 index 0000000..6a25884 --- /dev/null +++ b/SOURCES/0026-Add-a-very-simple-NVMe-module.patch @@ -0,0 +1,129 @@ +From 5d54b2ede698d5084aa6c780295fcc9aafbfa357 Mon Sep 17 00:00:00 2001 +From: Vojtech Trefny +Date: Mon, 9 May 2022 13:38:50 +0200 +Subject: [PATCH] Add a very simple NVMe module + +This covers only the basic functionallity needed by Anaconda right +now: populating the config files in /etc/nvme and copying them to +the installed system. The API for the NVMe singleton is based on +the similar modules for iSCSI and FCoE. + +Resolves: rhbz#2073008 +--- + blivet/errors.py | 14 +++++++++ + blivet/nvme.py | 81 ++++++++++++++++++++++++++++++++++++++++++++++++ + 2 files changed, 95 insertions(+) + create mode 100644 blivet/nvme.py + +diff --git a/blivet/errors.py b/blivet/errors.py +index fd51283f..b16cf2c5 100644 +--- a/blivet/errors.py ++++ b/blivet/errors.py +@@ -307,3 +307,17 @@ class EventHandlingError(StorageError): + + class ThreadError(StorageError): + """ An error occurred in a non-main thread. """ ++ ++# other ++ ++ ++class FCoEError(StorageError, OSError): ++ pass ++ ++ ++class ISCSIError(StorageError, OSError): ++ pass ++ ++ ++class NVMeError(StorageError, OSError): ++ pass +diff --git a/blivet/nvme.py b/blivet/nvme.py +new file mode 100644 +index 00000000..17bead15 +--- /dev/null ++++ b/blivet/nvme.py +@@ -0,0 +1,81 @@ ++# ++# nvme.py - NVMe class ++# ++# Copyright (C) 2022 Red Hat, Inc. All rights reserved. ++# ++# This program is free software; you can redistribute it and/or modify ++# it under the terms of the GNU General Public License as published by ++# the Free Software Foundation; either version 2 of the License, or ++# (at your option) any later version. ++# ++# This program is distributed in the hope that it will be useful, ++# but WITHOUT ANY WARRANTY; without even the implied warranty of ++# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the ++# GNU General Public License for more details. ++# ++# You should have received a copy of the GNU General Public License ++# along with this program. If not, see . ++# ++ ++import os ++import shutil ++ ++from . import errors ++from . import util ++ ++import logging ++log = logging.getLogger("blivet") ++ ++HOSTNQN_FILE = "/etc/nvme/hostnqn" ++HOSTID_FILE = "/etc/nvme/hostid" ++ ++ ++class NVMe(object): ++ """ NVMe utility class. ++ ++ .. warning:: ++ Since this is a singleton class, calling deepcopy() on the instance ++ just returns ``self`` with no copy being created. ++ """ ++ ++ def __init__(self): ++ self.started = False ++ ++ # So that users can write nvme() to get the singleton instance ++ def __call__(self): ++ return self ++ ++ def __deepcopy__(self, memo_dict): # pylint: disable=unused-argument ++ return self ++ ++ def startup(self): ++ if self.started: ++ return ++ ++ rc, nqn = util.run_program_and_capture_output(["nvme", "gen-hostnqn"]) ++ if rc != 0: ++ raise errors.NVMeError("Failed to generate hostnqn") ++ ++ with open(HOSTNQN_FILE, "w") as f: ++ f.write(nqn) ++ ++ rc, hid = util.run_program_and_capture_output(["dmidecode", "-s", "system-uuid"]) ++ if rc != 0: ++ raise errors.NVMeError("Failed to generate host ID") ++ ++ with open(HOSTID_FILE, "w") as f: ++ f.write(hid) ++ ++ self.started = True ++ ++ def write(self, root): # pylint: disable=unused-argument ++ # copy the hostnqn and hostid files ++ if not os.path.isdir(root + "/etc/nvme"): ++ os.makedirs(root + "/etc/nvme", 0o755) ++ shutil.copyfile(HOSTNQN_FILE, root + HOSTNQN_FILE) ++ shutil.copyfile(HOSTID_FILE, root + HOSTID_FILE) ++ ++ ++# Create nvme singleton ++nvme = NVMe() ++""" An instance of :class:`NVMe` """ +-- +2.34.3 + diff --git a/SOURCES/0027-DDF-RAID-support-using-mdadm.patch b/SOURCES/0027-DDF-RAID-support-using-mdadm.patch new file mode 100644 index 0000000..80709fe --- /dev/null +++ b/SOURCES/0027-DDF-RAID-support-using-mdadm.patch @@ -0,0 +1,107 @@ +From 3a64795bdb94f525b55375bd89e7e5c8bc3a8921 Mon Sep 17 00:00:00 2001 +From: Vojtech Trefny +Date: Wed, 17 Aug 2022 14:24:21 +0200 +Subject: [PATCH 1/3] Use MD populator instead of DM to handle DDF RAID format + +--- + blivet/formats/dmraid.py | 2 +- + blivet/formats/mdraid.py | 2 +- + 2 files changed, 2 insertions(+), 2 deletions(-) + +diff --git a/blivet/formats/dmraid.py b/blivet/formats/dmraid.py +index 2ba9dcfe5..ce15905dc 100644 +--- a/blivet/formats/dmraid.py ++++ b/blivet/formats/dmraid.py +@@ -43,7 +43,7 @@ class DMRaidMember(DeviceFormat): + # + # One problem that presents is the possibility of someone passing + # a dmraid member to the MDRaidArrayDevice constructor. +- _udev_types = ["adaptec_raid_member", "ddf_raid_member", ++ _udev_types = ["adaptec_raid_member", + "hpt37x_raid_member", "hpt45x_raid_member", + "isw_raid_member", + "jmicron_raid_member", "lsi_mega_raid_member", +diff --git a/blivet/formats/mdraid.py b/blivet/formats/mdraid.py +index 41ddef810..4aa3f3b07 100644 +--- a/blivet/formats/mdraid.py ++++ b/blivet/formats/mdraid.py +@@ -41,7 +41,7 @@ class MDRaidMember(DeviceFormat): + """ An mdraid member disk. """ + _type = "mdmember" + _name = N_("software RAID") +- _udev_types = ["linux_raid_member"] ++ _udev_types = ["linux_raid_member", "ddf_raid_member"] + parted_flag = PARTITION_RAID + _formattable = True # can be formatted + _supported = True # is supported + +From 3ea946fa7ae18dbc413c17f1cd5a6eb23aaf1ea8 Mon Sep 17 00:00:00 2001 +From: Vojtech Trefny +Date: Wed, 17 Aug 2022 14:24:58 +0200 +Subject: [PATCH 2/3] Do not read DDF RAID UUID from udev + +The UUID we get from udev isn't the array UUID, we need to get +that using libblockdev. +--- + blivet/populator/helpers/mdraid.py | 16 ++++++++++------ + 1 file changed, 10 insertions(+), 6 deletions(-) + +diff --git a/blivet/populator/helpers/mdraid.py b/blivet/populator/helpers/mdraid.py +index 3479e3f78..a7602d209 100644 +--- a/blivet/populator/helpers/mdraid.py ++++ b/blivet/populator/helpers/mdraid.py +@@ -98,17 +98,21 @@ class MDFormatPopulator(FormatPopulator): + + def _get_kwargs(self): + kwargs = super(MDFormatPopulator, self)._get_kwargs() +- try: +- # ID_FS_UUID contains the array UUID +- kwargs["md_uuid"] = udev.device_get_uuid(self.data) +- except KeyError: +- log.warning("mdraid member %s has no md uuid", udev.device_get_name(self.data)) ++ kwargs["biosraid"] = udev.device_is_biosraid_member(self.data) ++ if not kwargs["biosraid"]: ++ try: ++ # ID_FS_UUID contains the array UUID ++ kwargs["md_uuid"] = udev.device_get_uuid(self.data) ++ except KeyError: ++ log.warning("mdraid member %s has no md uuid", udev.device_get_name(self.data)) ++ else: ++ # for BIOS RAIDs we can't get the UUID from udev, we'll get it from mdadm in `run` below ++ kwargs["md_uuid"] = None + + # reset the uuid to the member-specific value + # this will be None for members of v0 metadata arrays + kwargs["uuid"] = udev.device_get_md_device_uuid(self.data) + +- kwargs["biosraid"] = udev.device_is_biosraid_member(self.data) + return kwargs + + def run(self): + +From 4e766bb6f2bb487003ed4fa9b8415760c436af81 Mon Sep 17 00:00:00 2001 +From: Vojtech Trefny +Date: Thu, 17 Mar 2022 15:48:25 +0100 +Subject: [PATCH 3/3] Do not crash when a disk populator doesn't return kwargs + +This happens when trying to use Blivet on a system with a BIOS +RAID without dmraid installed. Because we don't fully support +BIOS RAIDs using MD the MDBiosRaidDevicePopulator helper fails +to get kwargs for the BIOS RAID "disk" and populate fails. +--- + blivet/populator/helpers/disk.py | 2 ++ + 1 file changed, 2 insertions(+) + +diff --git a/blivet/populator/helpers/disk.py b/blivet/populator/helpers/disk.py +index 2e5026f7e..9db7b810d 100644 +--- a/blivet/populator/helpers/disk.py ++++ b/blivet/populator/helpers/disk.py +@@ -68,6 +68,8 @@ def run(self): + log_method_call(self, name=name) + + kwargs = self._get_kwargs() ++ if not kwargs: ++ return + device = self._device_class(name, **kwargs) + self._devicetree._add_device(device) + return device diff --git a/SPECS/python-blivet.spec b/SPECS/python-blivet.spec new file mode 100644 index 0000000..c533539 --- /dev/null +++ b/SPECS/python-blivet.spec @@ -0,0 +1,3455 @@ +%define is_rhel 0%{?rhel} != 0 + +# python3 is not available on RHEL <=7 +%if %{is_rhel} && 0%{?rhel} <= 7 +# disable python3 by default +%bcond_with python3 +%else +%bcond_without python3 +%endif + +# python2 is not available on RHEL > 7 and not needed on Fedora > 28 +%if 0%{?rhel} > 7 || 0%{?fedora} > 28 +# disable python2 by default +%bcond_with python2 +%else +%bcond_without python2 +%endif + +Summary: A python module for system storage configuration +Name: python-blivet +Url: https://storageapis.wordpress.com/projects/blivet +Version: 3.4.0 + +#%%global prerelease .b2 +# prerelease, if defined, should be something like .a1, .b1, .b2.dev1, or .c2 +Release: 16%{?prerelease}%{?dist} +Epoch: 1 +License: LGPLv2+ +%global realname blivet +%global realversion %{version}%{?prerelease} +Source0: http://github.com/storaged-project/blivet/archive/%{realname}-%{realversion}.tar.gz +Source1: http://github.com/storaged-project/blivet/archive/%{realname}-%{realversion}-tests.tar.gz +Patch0: 0001-force-lvm-cli-plugin.patch +Patch1: 0002-remove-btrfs-plugin.patch +Patch2: 0003-Revert-More-consistent-lvm-errors.patch +Patch3: 0005-Fix-unify-importing-mock-module-in-tests.patch +Patch4: 0006-Fix-util.virt_detect-on-Xen.patch +Patch5: 0007-Fix-activating-old-style-LVM-snapshots.patch +Patch6: 0008-Fix-resolving-devices-with-names-that-look-like-BIOS.patch +Patch7: 0009-Do-not-set-chunk-size-for-RAID1.patch +Patch8: 0010-Fix-running-tests-in-gating.patch +Patch9: 0011-Tell-LVM-to-ignore-the-new-devices-file-for-now.patch +Patch10: 0012-Improve-error-message-printed-for-missing-dependecie.patch +Patch11: 0013-Use-bigger-chunk-size-for-thinpools-bigger-than-15.8.patch +Patch12: 0014-LVM-devices-file-support.patch +Patch13: 0015-iscsi-Replace-all-log_exception_info-calls-with-log.patch +Patch14: 0016-Fix-log-message-for-the-LVM-devices-filter.patch +Patch15: 0017-Exclude-unusable-disks-from-PartitionFactory.patch +Patch16: 0018-Fix-getting-PV-info-in-LVMPhysicalVolume-from-the-ca.patch +Patch17: 0019-Do-not-crash-when-changing-disklabel-on-disks-with-a.patch +Patch18: 0020-ActionDestroyDevice-should-not-obsolete-ActionRemove.patch +Patch19: 0021-Correctly-set-vg_name-after-adding-removing-a-PV-fro.patch +Patch20: 0022-Add-support-for-creating-LVM-cache-pools.patch +Patch21: 0023-Use-LVM-PV-format-current_size-in-LVMVolumeGroupDevi.patch +Patch22: 0024-tests-Mark-fake-disks-in-test_get_related_disks-as-n.patch +Patch23: 0025-Add-support-for-NPIV-enabled-zFCP-devices.patch +Patch24: 0026-Add-a-very-simple-NVMe-module.patch +Patch25: 0027-DDF-RAID-support-using-mdadm.patch + +# Versions of required components (done so we make sure the buildrequires +# match the requires versions of things). +%global partedver 3.2 +%global pypartedver 3.10.4 +%global utillinuxver 2.15.1 +%global libblockdevver 2.24 +%global libbytesizever 0.3 +%global pyudevver 0.18 + +BuildArch: noarch + +%description +The python-blivet package is a python module for examining and modifying +storage configuration. + +%package -n %{realname}-data +Summary: Data for the %{realname} python module. + +BuildRequires: make +BuildRequires: systemd + +Conflicts: python-blivet < 1:2.0.0 +Conflicts: python3-blivet < 1:2.0.0 + +%description -n %{realname}-data +The %{realname}-data package provides data files required by the %{realname} +python module. + +%if %{with python3} +%package -n python3-%{realname} +Summary: A python3 package for examining and modifying storage configuration. + +%{?python_provide:%python_provide python3-%{realname}} + +BuildRequires: gettext +BuildRequires: python3-devel +BuildRequires: python3-setuptools + +%{?__python3:Requires: %{__python3}} +Requires: python3-six +Requires: python3-pyudev >= %{pyudevver} +Requires: parted >= %{partedver} +Requires: python3-pyparted >= %{pypartedver} +Requires: libselinux-python3 +Requires: python3-blockdev >= %{libblockdevver} +Recommends: libblockdev-btrfs >= %{libblockdevver} +Recommends: libblockdev-crypto >= %{libblockdevver} +Recommends: libblockdev-dm >= %{libblockdevver} +Recommends: libblockdev-fs >= %{libblockdevver} +Recommends: libblockdev-kbd >= %{libblockdevver} +Recommends: libblockdev-loop >= %{libblockdevver} +Recommends: libblockdev-lvm >= %{libblockdevver} +Recommends: libblockdev-mdraid >= %{libblockdevver} +Recommends: libblockdev-mpath >= %{libblockdevver} +Recommends: libblockdev-nvdimm >= %{libblockdevver} +Recommends: libblockdev-part >= %{libblockdevver} +Recommends: libblockdev-swap >= %{libblockdevver} +Recommends: libblockdev-s390 >= %{libblockdevver} +Requires: python3-bytesize >= %{libbytesizever} +Requires: util-linux >= %{utillinuxver} +Requires: lsof +Requires: python3-gobject-base +Requires: systemd-udev +Requires: %{realname}-data = %{epoch}:%{version}-%{release} + +Obsoletes: blivet-data < 1:2.0.0 + +%if %{without python2} +Obsoletes: python2-blivet < 1:2.0.2-2 +Obsoletes: python-blivet < 1:2.0.2-2 +%else +Obsoletes: python-blivet < 1:2.0.0 +%endif + +%description -n python3-%{realname} +The python3-%{realname} is a python3 package for examining and modifying storage +configuration. +%endif + +%if %{with python2} +%package -n python2-%{realname} +Summary: A python2 package for examining and modifying storage configuration. + +%{?python_provide:%python_provide python2-%{realname}} + +BuildRequires: gettext +BuildRequires: python2-devel +BuildRequires: python2-setuptools + +Requires: python2 +Requires: python2-six +Requires: python2-pyudev >= %{pyudevver} +Requires: parted >= %{partedver} +Requires: python2-pyparted >= %{pypartedver} +Requires: python2-libselinux +Requires: python2-blockdev >= %{libblockdevver} +Recommends: libblockdev-btrfs >= %{libblockdevver} +Recommends: libblockdev-crypto >= %{libblockdevver} +Recommends: libblockdev-dm >= %{libblockdevver} +Recommends: libblockdev-fs >= %{libblockdevver} +Recommends: libblockdev-kbd >= %{libblockdevver} +Recommends: libblockdev-loop >= %{libblockdevver} +Recommends: libblockdev-lvm >= %{libblockdevver} +Recommends: libblockdev-mdraid >= %{libblockdevver} +Recommends: libblockdev-mpath >= %{libblockdevver} +Recommends: libblockdev-nvdimm >= %{libblockdevver} +Recommends: libblockdev-part >= %{libblockdevver} +Recommends: libblockdev-swap >= %{libblockdevver} +Recommends: libblockdev-s390 >= %{libblockdevver} +Requires: python2-bytesize >= %{libbytesizever} +Requires: util-linux >= %{utillinuxver} +Requires: lsof +Requires: python2-hawkey +Requires: %{realname}-data = %{epoch}:%{version}-%{release} + +Requires: systemd-udev +Requires: python2-gobject-base + +Obsoletes: blivet-data < 1:2.0.0 +Obsoletes: python-blivet < 1:2.0.0 + +%description -n python2-%{realname} +The python2-%{realname} is a python2 package for examining and modifying storage +configuration. +%endif + +%prep +%autosetup -n %{realname}-%{realversion} -N +%autosetup -n %{realname}-%{realversion} -b1 -p1 + +%build +%{?with_python2:make PYTHON=%{__python2}} +%{?with_python3:make PYTHON=%{__python3}} + +%install +%{?with_python2:make PYTHON=%{__python2} DESTDIR=%{buildroot} install} +%{?with_python3:make PYTHON=%{__python3} DESTDIR=%{buildroot} install} + +%find_lang %{realname} + +%files -n %{realname}-data -f %{realname}.lang +%{_sysconfdir}/dbus-1/system.d/* +%{_datadir}/dbus-1/system-services/* +%{_libexecdir}/* +%{_unitdir}/* + +%if %{with python2} +%files -n python2-%{realname} +%license COPYING +%doc README.md ChangeLog examples +%{python2_sitelib}/* +%endif + +%if %{with python3} +%files -n python3-%{realname} +%license COPYING +%doc README.md ChangeLog examples +%{python3_sitelib}/* +%endif + +%changelog +* Thu Aug 18 2022 Vojtech Trefny - 3.4.0-16 +- DDF RAID support using mdadm + Resolves: rhbz#2109030 + +* Mon Jun 20 2022 Jan Pokorny - 3.4.0-15 +- Add a very simple NVMe module + Resolves: rhbz#2073008 +- Add support for NPIV-enabled zFCP devices + Resolves: rhbz#1937030 +- Fix removing zFCP SCSI devices + Related: rhbz#1937030 +- tests: Mark "fake" disks in test_get_related_disks as non-existing + Resolves: rhbz#2062690 + +* Thu Jun 02 2022 Jan Pokorny - 3.4.0-14 +- Release version increase to fix RHEL upgrade path + Related: rhbz#2081278 + +* Thu Jun 02 2022 Jan Pokorny - 3.4.0-13 +- Fix getting PV info in LVMPhysicalVolume from the cache + Resolves: rhbz#2079221 +- Do not crash when changing disklabel on disks with active devices + Resolves: rhbz#2078803 +- ActionDestroyDevice should not obsolete ActionRemoveMember + Resolves: rhbz#2076956 +- Correctly set vg_name after adding/removing a PV from a VG + Resolves: rhbz#2081278 +- Add support for creating LVM cache pools + Resolves: rhbz#2055200 +- Use LVM PV format current_size in LVMVolumeGroupDevice._remove + Related: rhbz#2081278 + +* Tue Feb 01 2022 Vojtech Trefny - 3.4.0-12 +- Fix log message for the LVM devices filter + Resolves: rhbz#2034277 +- Exclude unusable disks from PartitionFactory + Resolves: rhbz#2017432 + +* Tue Dec 14 2021 Vojtech Trefny - 3.4.0-11 +- Replace all log_exception_info calls with log.info + Resolves: rhbz#2028391 + +* Thu Dec 09 2021 Vojtech Trefny - 3.4.0-10 +- Use LVM devices file instead of filter regex + Resolves: rhbz#1967212 + +* Tue Nov 30 2021 Vojtech Trefny - 3.4.0-9 +- Rebuild with higher release number to fix errata + Related: rhbz#2012121 + +* Fri Nov 26 2021 Vojtech Trefny - 3.4.0-8 +- Improve error message printed for missing dependecies + Resolves: rhbz#2012121 +- Use bigger chunk size for thinpools bigger than ~15.88 TiB + Resolves: rhbz#1971516 + +* Tue Aug 17 2021 Vojtech Trefny - 3.4.0-7 +- Fix script for running tests in gating + Resolves: rhbz#1990237 + +* Wed Aug 11 2021 Vojtech Trefny - 3.4.0-6 +- Remove "Revert Terminology cleanups" patch + Resolves: rhbz#1990982 +- Fix running tests in gating + Resolves: rhbz#1990237 +- Opt out from using LVM devices file in 9 Beta + Resolves: rhbz#1984851 + +* Tue Aug 10 2021 Mohan Boddu - 1:3.4.0-5 +- Rebuilt for IMA sigs, glibc 2.34, aarch64 flags + Related: rhbz#1991688 + +* Mon Aug 2 2021 Vojtech Trefny - 3.4.0-4 +- Do not set chunk size for RAID 1 + Resolves: rhbz#1987176 + +* Sat Jul 17 2021 Neal Gompa - 3.4.0-3 +- Fix resolving devices with names that look like BIOS drive number + Resolves: rhbz#1983310 + +* Wed Jul 7 2021 Vojtech Trefny - 3.4.0-2 +- Fix activating old style LVM snapshots + Resolves: rhbz#1961944 + +* Wed Jun 9 2021 Vojtech Trefny - 3.4.0-1 +- Rebase to latest upstream release 3.4.0 + Resolves: rhbz#1964341 + +* Fri Apr 16 2021 Mohan Boddu - 1:3.3.3-2 +- Rebuilt for RHEL 9 BETA on Apr 15th 2021. Related: rhbz#1947937 + +* Thu Feb 18 2021 Vojtech Trefny - 3.3.3-1 +- apply compression settings from blivet.flags.btrfs_compression (#1926892) (michel) + +* Wed Jan 27 2021 Fedora Release Engineering - 1:3.3.2-2 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_34_Mass_Rebuild + +* Thu Jan 14 2021 Vojtech Trefny - 3.3.2-1 +- Fix "suggest_container_name" for Anaconda (vtrefny) +- Add test for util.get_sysfs_attr (vtrefny) +- Use util.get_sysfs_attr in __is_ignored_blockdev to read device mode (vtrefny) +- Fix possible UnicodeDecodeError when reading sysfs attributes (vtrefny) +- Update LUKS device name after parent partition name change (vtrefny) +- TFT is still broken so let's avoid failures by just doing a build (jkonecny) +- Fix logging information about ignoring hidden devices (vtrefny) +- Add __repr__ and __str__ methods to ParentList (vtrefny) +- Make sure LV name is unique when adding it in device factory (vtrefny) +- In name checks add name which is already in use to error message (vtrefny) +- Refactor suggest device/container name functions (vtrefny) +- Remove an unused attribute from the Blivet class (vponcova) +- Add PyPI build artifacts to .gitignore (vtrefny) +- Sync spec with downstream (vtrefny) + +* Wed Nov 11 2020 Vojtech Trefny - 3.3.1-2 +- Remove btrfs from requested libblockdev plugins on RHEL 9 + +* Tue Oct 20 2020 Vojtech Trefny - 3.3.1-1 +- Make sure the product name is safe when using it for device name (vtrefny) +- Run packit RPM builds on Fedora ELN (vtrefny) +- Allow specifying 'mode' for the sdist command (vtrefny) +- Enable packit RPM builds on pull requests (vtrefny) +- Start the iscsi-init service (#1880673) (vponcova) +- Let parted fix fixable issues with partition table (vtrefny) +- edd: Fix UnboundLocalError when trying to close fd in collect_mbrs (vtrefny) +- Use UnusableConfigurationError for partially hidden multipath devices (vtrefny) +- Close fd if it fails to read the device (nashok) +- Do not run udev.settle in StorageDevice._pre_teardown (vtrefny) +- Try to not use udev.resolve_devspec when querying MountsCache (vtrefny) +- Remove Zanata config file (vtrefny) +- Ignore new pylint warning W0707 "raise-missing-from" (vtrefny) +- Use SSH "link" for l10n repository in Makefile (vtrefny) +- Fix source tarball cleanup in srpm and rpm Makefile targets (vtrefny) + +* Wed Sep 16 2020 Vojtech Trefny - 3.3.0-2 +- Avoid using unnecessary udev.settle calls (#1876162) + +* Thu Aug 20 2020 Vojtech Trefny - 3.3.0-1 +- Account for pmspare grow when adjusting thinpool metadata size (vtrefny) +- Fix ignoring disk devices with parents or children (vtrefny) +- Terminology cleanup, part 3 (vtrefny) +- Terminology cleanups, part 2. (dlehman) +- Clean up some terminology. (dlehman) +- Add tests for udev.device_get_name for RAID devices (vtrefny) +- Fix name resolution for MD devices and partitions on them (vtrefny) +- Fix reading hidden sysfs attribute (vtrefny) +- Add support for specifying sector size for LUKS 2 devices (vtrefny) +- Do not ignore unknown/unsupported device mapper devices (vtrefny) +- Allow specifying custom hash function for LUKS 2 format (vtrefny) +- Ignore devices marked as hidden in sysfs (#1856974) (vtrefny) +- Add basic F2FS support (#1794950) (vtrefny) +- Make safe_device_name device type specific (vtrefny) +- Add exFAT to filesystems we recognize (vtrefny) +- Use xfs_db in read-only mode when getting XFS information (vtrefny) +- Add support for checking and fixing XFS using xfs_repair (vtrefny) +- Ignore zRAM devices in VMBackedTestCase (vtrefny) +- Add tests for XFS resize (vtrefny) +- Add support for XFS format grow (vtrefny) +- Typo fix (vtrefny) +- tests: Skip test_reset when running as non-root (vtrefny) +- tests: Patch LVM availability functions for some tests (vtrefny) +- tests: Patch LVM lvs call for some non-LVM tests (vtrefny) +- Do not propagate ped exception from add_partition (vtrefny) +- Do not use BlockDev.utils_have_kernel_module to check for modules (vtrefny) +- set allowed disk labels for s390x as standard ones (msdos + gpt) plus dasd (dan) +- Do not use FSAVAIL and FSUSE%% options when running lsblk (vtrefny) +- Rewrite README and add it as a long_description in setup.py (vtrefny) +- Round down to nearest MiB value when writing ks parittion info. (sbueno+anaconda) +- Add _teardown method to IntegrityDevice (vtrefny) +- Fix status for DM Integrity format (#1814005) (vtrefny) +- udev: Add function to get list of device's holders (vtrefny) +- Add basic support for LVM writecache devices (vtrefny) +- Add test for SwapSpace max size (vtrefny) +- Do not limit swap to 128 GiB (vtrefny) +- Fix possible UnicodeDecodeError when reading model from sysfs (vtrefny) +- Add install_requires and classifiers to setup.py (vtrefny) +- Import setuptools in setup.py to make bdist_wheel work (vtrefny) +- Set device.original_format to the new format in ActionCreateFormat (vtrefny) +- Fix resizable property for partitions (vtrefny) +- Update TODO. (dlehman) +- Ignore pycodestyle warning E741 (vtrefny) +- Skip test_mounting for filesystems that are not mountable (vtrefny) +- Sync specfile with downstream (japokorn) +- Make extended partitions resizable (vtrefny) +- Fix LV min size for resize in test_action_dependencies (vtrefny) +- Fix checking for filesystem support in action_test (vtrefny) +- Add basic support for LVM VDO devices (vtrefny) +- Update POT file in the Weblate repo during "make potfile" (vtrefny) +- Skip translation canary check if POT file is not available (vtrefny) +- Add blivet-weblate repository as a submodule (vtrefny) +- Remove Zanata from our build process (vtrefny) +- Remove po folder (vtrefny) +- More consistent lvm errors (API break) (japokorn) +- Added support for device tags (japokorn) + +* Wed Jul 29 2020 Vojtech Trefny - 3.2.2-4 +- set allowed disk labels for s390x as standard ones (msdos + gpt) plus dasd + +* Tue Jul 28 2020 Fedora Release Engineering - 1:3.2.2-3 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_33_Mass_Rebuild + +* Sat May 23 2020 Miro Hrončok - 1:3.2.2-2 +- Rebuilt for Python 3.9 + +* Thu May 21 2020 Jan Pokorny - 3.2.2-1 +- Allow setting size for non-existing LUKS devices (vtrefny) +- Fix toggling container encryption in devicefactory (#1827254) (vtrefny) +- Do no include destroyed devices in list of names (#1830515) (vtrefny) +- Fix changing LUKS version in devicefactory (#1834373) (vtrefny) +- Add "is_empty" property to StorageDevice (vtrefny) +- Mark warning "'GError' has no 'message' member" as false positive (vtrefny) +- Use the specified LUKS version for container encryption (vponcova) +- Log current storage state before reset using lsblk (vtrefny) +- Do not remove _netdev mount option specified manually by users (vtrefny) +- Fix renaming encrypted devices in the DeviceFactory (vtrefny) +- Fix typo in string formatter in EddEntry (vtrefny) + +* Tue Apr 21 2020 Vojtech Trefny - 3.2.1-2 +- Invalidate LVM caches in blivet device discovery loop (#1824418) + +* Mon Apr 06 2020 Vojtech Trefny - 3.2.1-1 +- Correctly recognize EFI format on an MD RAID device (#1695913) (vtrefny) +- Do not set empty name instead of invalid one in devicefactory (#1813710) (vtrefny) +- Fix crash for devices without ID_PATH udev property (#1814920) (vtrefny) +- Allow for reserved vg space and a growable thin pool. (#1783946) (dlehman) +- Fix name resolution for md member partitions. (#1798792) (dlehman) + +* Wed Mar 11 2020 Vojtech Trefny - 3.2.0-3 +- Fix name resolution for md member partitions. (#1798792) + +* Thu Jan 30 2020 Fedora Release Engineering - 1:3.2.0-2 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_32_Mass_Rebuild + +* Wed Jan 29 2020 Vojtech Trefny - 3.2.0-1 +- Align base sizes up if smaller than min I/O size. (dlehman) +- Make minimal and optimal alignment getters public. (dlehman) +- Add support for relabeling of the swap format (vtrefny) +- Define the 'relabels' method for all formats (vtrefny) +- Add support for LVMPV format resize (vtrefny) +- Add a new "id_path" attribute for iSCSI and FCoE disks (vtrefny) +- Do not load module when creating an FS instance (vtrefny) +- Add a simple script for running tests manually (vtrefny) +- Remove unused API code (jkonecny) +- devicetree.names is now a property (japokorn) +- initial PowerNV class support (dan) +- Use LUKS2 by default (vponcova) + +* Wed Jan 29 2020 Vojtech Trefny - 3.1.7-1 +- Use SHA256 instead of MD5 for /proc/mounts hash calculation (vtrefny) +- Fix udev test names so they actually get run. (dlehman) +- Add recognition of Dell FW RAID to udev.device_is_disk. (dlehman) +- Fix Blivet DBus service version in service and config files (vtrefny) +- Make sure _chrooted_mountpoint attribute is defined before using it (vtrefny) +- Allow running 'write_label' in dry run mode on non-existing devices (vtrefny) +- Make 'makeupdates' and 'makebumpver' scripts Python 3 compatible (vtrefny) +- Do not hardcode coverage executable name (vtrefny) +- Make sure LVs are writable before wiping. (dlehman) +- Override LVM skip-activation to allow for thorough removal. (dlehman) +- Add setters for requested_size/percent form LVMVolumeGroupDevice (vtrefny) +- Set min size for XFS to 16 MiB (vtrefny) +- Revert "Ignore invalid-overridden-method warning for abstract properties" (vtrefny) +- Fix invalid-overridden-method in events_test (vtrefny) + +* Fri Oct 25 2019 Vojtech Trefny - 3.1.6-1 +- Do not allow creating VGs with PVs with different sector size (vtrefny) +- Add a new "sector_size" property to storage devices. (vtrefny) +- Ignore invalid-overridden-method warning for abstract properties (vtrefny) +- Change NFSMount._availability_errors to a property (vtrefny) +- Fix util.detect_virt function (vtrefny) +- Do not try to normalize size for zero size device factories (vtrefny) +- Always set default key size to 512 bits for ciphers with XTS mode (vtrefny) + +* Thu Oct 03 2019 Miro Hrončok - 1:3.1.5-4 +- Rebuilt for Python 3.8.0rc1 (#1748018) + +* Tue Aug 27 2019 Vojtech Trefny - 3.1.5-3 +- Do not try to normalize size for zero size device factories (#1743753) + +* Fri Aug 16 2019 Miro Hrončok - 1:3.1.5-2 +- Rebuilt for Python 3.8 + +* Thu Aug 15 2019 Vojtech Trefny - 3.1.5-1 +- Move dependencies code from StorageDevice to Device (vtrefny) +- Always use luks_data.min_entropy as a default minimum entropy (vponcova) +- Add 'protected' property setter to LVMVolumeGroupDevice (#1729363) (vtrefny) +- fix of LV max size calculation (japokorn) +- Added min size for partitions (japokorn) +- Improved non-unique UUID handling (japokorn) +- Check if disklabel supports partition names (#1723228) (vtrefny) +- format_device: Revert destroy action if create fails (#1727589) (vtrefny) +- Do not allow resizing of LUKS devices with integrity (vtrefny) +- Return underlying block device as 'slave' for LUKS with integrity (vtrefny) +- Fix removing LUKS devices with integrity (vtrefny) +- Check status before activating dmraid set in populate. (#1723979) (dlehman) +- Use DBus call to see if we're in a vm. (dlehman) +- Use dasd disklabel for vm disks backed by dasds. (dlehman) +- Add a function to detect if running in a vm. (dlehman) +- Remove teardown_all from the populate method (vponcova) +- Correctly handle non-unicode iSCSI initiator names (vtrefny) +- Add, test and use a new method to get size with reserve (vpodzime) +- Beware non-positive sizes in thpool metadata size calculations (vpodzime) +- Log sizes in MiB in thpool auto metadata size calculations (vpodzime) +- Recalculate thpool's metadata size on resize in LVMThinPFactory (vpodzime) +- Move the thpool reserve calculations to LVMFactory (vpodzime) + +* Fri Jul 26 2019 Fedora Release Engineering - 1:3.1.4-3 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_31_Mass_Rebuild + +* Thu Jul 11 2019 Vojtech Trefny - 3.1.4-2 +- Remove teardown_all from the populate method (vponcova) +- initial PowerNV class support (dan) + +* Tue Jun 11 2019 Vojtech Trefny - 3.1.4-1 +- Don't call fnmatch with None (#1698937) (vponcova) +- Do not crash on non-int lun argument when creating iscsi disk object. (rvykydal) +- Make iscsi device attribute modifications backward compatible. (rvykydal) +- Do not store iscsi module nodeinfo in device object. (rvykydal) +- Only call mpath plugin when it is available. (#1697378) (dlehman) +- Include tests archive where appropriate in make targets. (dlehman) +- Add spec file logic to include unit tests in SRPM. (dlehman) +- Add a target to create an archive of the unit tests. (dlehman) +- Remove profanity from an old comment. (dlehman) +- Fix mounting of the filesystem iso9660 (vponcova) +- Remove unnecessary pass statements (vtrefny) +- Check for format tools availability in action_test (vtrefny) +- Skip weak dependencies test if we don't have all libblockdev plugins (vtrefny) +- Properly clean after availability test case (vtrefny) +- Ensure correct type of mpath cache member list. (dlehman) +- Do not crash if 'dm.get_member_raid_sets' fails (#1684851) (vtrefny) +- Fix supported disklabels in 'test_platform_label_types' on EFI (vtrefny) +- Support legacy MBR (msdos) as part of UEFI to enable hybrid builds (pbrobinson) +- Automatically adjust size of growable devices for new format (vtrefny) +- spec: Remove obsolete Group tag and bump min libblockdev version (vtrefny) + +* Thu Mar 21 2019 Vojtech Trefny - 3.1.3-3 +- Ensure correct type of mpath cache member list + +* Mon Mar 11 2019 Vojtech Trefny - 3.1.3-2 +- Support legacy MBR (msdos) as part of UEFI to enable hybrid builds (pbrobinson) + +* Wed Feb 27 2019 Vojtech Trefny - 3.1.3-1 +- Don't crash if blockdev mpath plugin isn't available. (#1672971) (dlehman) +- iscsi: Add default value to unused 'storage' argument in 'write' (vtrefny) +- Add exported property to LVMVolumeGroupDevice (vtrefny) +- Add VG data to static_data (vtrefny) +- Do not try to get format free space for non-existing formats (vtrefny) +- Do not raise exception if can't get PV free space (vtrefny) +- Fix undefined attribute in LVM info cache (vtrefny) +- Use raw_device to get thinpool device in LVMThinPFactory (#1490174) (vtrefny) +- Do not crash if DM RAID activation fails (#1661712) (vtrefny) +- Remove the unused sysroot property (vponcova) +- Remove unused attributes from the Blivet class (vponcova) +- Remove the unused gpt flag (vponcova) +- Copy the iSCSI initiator name file to the installed system (vtrefny) +- Use udev to determine if disk is a multipath member. (dlehman) +- Require libfc instead of fcoe for offloaded FCoE. (#1575953) (dlehman) + +* Sat Feb 02 2019 Fedora Release Engineering - 1:3.1.2-2 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_30_Mass_Rebuild + +* Wed Dec 12 2018 Vojtech Trefny - 3.1.2-1 +- Fix reading LV attributes in LVMVolumeGroupDevice.status (vtrefny) +- Do not try to login to iBFTs with active session (vtrefny) +- Fix xfs sync of chrooted mountpoint. (dlehman) +- Only update sysfs path in ctor for active devices. (dlehman) +- Fix new pep8/pycodestyle warnings (vtrefny) +- Ignore PEP8 W504 warning ("line break after binary operator") (vtrefny) +- pylint: Allow loading all C extensions (vtrefny) +- Use 'pycodestyle' instead of 'pep8' (vtrefny) +- Fix failing populator test without nvdimm plugin (vtrefny) +- Add 'srpm' and 'rpm' targets to Makefile for building (S)RPMs (vtrefny) +- Fix crash on reset on systems without nvdimm plugin (vtrefny) +- Use the size info of internal LVs when getting space usage for existing LVs (v.podzimek) +- Calculate the number of RAID PVs from the origin for cached LVs (v.podzimek) +- Make raid_level a property of an LV object (v.podzimek) +- Add a test for DeviceTree.get_related_disks. (dlehman) +- Fix ixgbe/bnx2fc fcoe disk detection (#1651506) (rvykydal) +- Use RAID name for partitions on an MD array (vtrefny) +- Move btrfs name validation to devicelibs (vtrefny) +- Don't try to set selinux context for nodev or vfat file systems. (dlehman) +- Only try to set selinux context for lost+found on ext file systems. (dlehman) +- Wipe all stale metadata after creating md array. (#1639682) (dlehman) +- Don't try to update sysfs path for non-block devices. (#1579375) (dlehman) +- Don't raise errors without messages (vponcova) +- Install ndctl when NVDIMMs are used. (dlehman) +- Deactivate incomplete VGs along with everything else. (dlehman) +- Work around udev timing issues. (dlehman) +- Fix options for ISCSI functions (#1632656) (vtrefny) +- Use format.status when checking for PV status (vtrefny) +- Remove Anaconda flags (vponcova) +- Remove square brackets when matching internal LVs (v.podzimek) + +* Mon Oct 08 2018 Vojtech Trefny - 3.1.1-2 +- Fix options for ISCSI functions (#1632656) (vtrefny) + +* Wed Sep 26 2018 Vojtech Trefny - 3.1.1-1 +- Check device dependencies only for device actions (vtrefny) +- Allow removing btrfs volumes without btrfs support (vtrefny) +- Adjust LVMPhysicalVolumeMethodsTestCase to new pvcreate option (vtrefny) +- add `-y' to lvm.pvcreate (hongxu.jia) +- Drop omap partition table tests on ARM platforms (pbrobinson) +- Update disk label tests for ARM platforms (pbrobinson) +- Ignore pylint 'no-value-for-parameter' warning (vtrefny) +- arm: add support for EFI on ARMv7 (pbrobinson) +- Aarch64 platforms: Fix gpt defaults for 64 bit arm platforms (pbrobinson) +- arch: arm: drop get_arm_machine function (pbrobinson) +- arch: arm: drop omap specifics for partitioning (pbrobinson) +- Create a separate availability check for dmraid support (vtrefny) + +* Thu Aug 30 2018 Vojtech Trefny - 3.1.0-2 +- arm: add support for EFI on ARMv7 (probinson) +- Aarch64 platforms: Fix gpt defaults for 64 bit arm platforms (probinson) +- arch: arm: drop get_arm_machine function (probinson) +- arch: arm: drop omap specifics for partitioning (probinson) + +* Mon Aug 13 2018 Vojtech Trefny - 3.1.0-1 +- Allow configuring default LUKS2 PBKDF arguments using luks_data (vtrefny) +- Fix the populate_kickstart method in LUKS (vtrefny) +- Allow specifying extra arguments for PBKDF when creating LUKS2 (vtrefny) +- Add support for LUKS2 to DeviceFactory (vtrefny) +- DeviceFactory: use min_luks_entropy from kwargs (vtrefny) +- Fix passing 'min_luks_entropy' when creating LUKS format (vtrefny) +- Use passphrase/key file when resizing LUKS2 format (vtrefny) +- Require libblockdev 2.17 (vtrefny) +- Add support for LUKS2 format (vtrefny) +- Add initial support for DM Integrity "format" (vtrefny) +- Do not try to add LUKSDevice in LUKSFormatPopulator (vtrefny) +- Add support for dm-integrity devices (vtrefny) +- Fixed various issues preventing successful build (japokorn) + +* Thu Aug 2 2018 Peter Robinson 3.1.0-0.5.b2 +- Bump release to fix upgrade path + +* Mon Jul 30 2018 David Lehman - 3.1.0-0.1.b2 +- Do not ignore "Image out-of-sync" internal LVs (vtrefny) +- Fixed error message when slave is missing (japokorn) +- Ensure WWNs are set for multipath and dmraid. (dlehman) +- Use ID_WWN_WITH_EXTENSION for WWNs. (dlehman) +- Ignore pylint error "bad-option-value" for new pylint errors (vtrefny) +- Fix errors found by new pylint 2.0.0 (vtrefny) +- Fix caching logic in ExternalResource. (dlehman) +- Use DiskFile to allow testing missing dependencies as non-root. (dlehman) +- Restore availability caching after disabling for tests. (dlehman) +- Preserve original blockdev plugin list in test cleanup. (dlehman) +- Fix positional/key-word arguments in util.Path (vtrefny) +- fix doc for is_s390() (dan) +- The key size of LUKS should be 0 by default (vponcova) +- Do not use rpm to check for Zanata client (vtrefny) +- Fixed create_device fail behavior (japokorn) +- Fixed KS forcing zerombr onto RO disk (japokorn) +- Fix BIOS device number regex in edd module. (#1552236) (dlehman) +- Shrink devices before growing others with common ancestors. (#1539422) (dlehman) +- Do not copy ksdata. (rvykydal) +- Find and remove stale LVM metadata immediately after creating md array. (dlehman) +- Adapt mock imports for compatibility w/ python2 & python3. (dlehman) +- Use py2-compatible syntax to get system architecture. (dlehman) + +* Tue Jul 17 2018 Vojtech Trefny - 3.1.0-0.4.b1 +- Force command line based libblockdev LVM plugin (vtrefny) + +* Fri Jul 13 2018 Fedora Release Engineering - 1:3.1.0-0.3.b1 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_29_Mass_Rebuild + +* Fri Jun 15 2018 Miro Hrončok - 1:3.1.0-0.2.b1 +- Rebuilt for Python 3.7 + +* Wed May 02 2018 David Lehman - 3.1.0-0.1.b1 +- Add 'nvdimm' tag for NVDIMM namespaces (vtrefny) +- Add test for NVDIMMNamespaceDevicePopulator (vtrefny) +- Add populator helper for NVDIMM namespaces (vtrefny) +- Add 'NVDIMMNamespaceDevice' device representing NVDIMM namespaces (vtrefny) +- Add a function for identifying NVDIMM namespaces (vtrefny) +- Add a singleton for NVDIMM namespaces management (vtrefny) +- Add NVDIMM plugin to list of requested plugins (vtrefny) + +* Fri Apr 20 2018 David Lehman - 3.0.1-1 +- Weak dependencies for libblockdev plugins (japokorn) +- Translate log levels from libblockdev to python log levels (vtrefny) +- Try to wait after stopping an MD array (vtrefny) +- Replace deprecated iscsi_firmware dracut option (rvykydal) +- Fix how we check return value for call_sync in safe_dbus (vtrefny) +- Conditionalize the Python 2 subpackage and don't build it on EL > 7 and + Fedora > 28 (miro) +- Fix python3 conditional in rpm spec file. (dlehman) +- Fix upstream URL in spec (vtrefny) +- Allow device specification by node to udev.get_device. (#1524700) (dlehman) +- Do not try to update potfile during make all (vtrefny) +- Use '-p1' when applying patches with autosetup (vtrefny) +- Remove dependency on pocketlint (vtrefny) +- Dasd is a valid label type on s390x (#1538550) (vponcova) +- fcoe: remove /etc/fcoe dir if it exists before copying configuration + (#1542846) (rvykydal) +- Avoid UnitTest.subTest due to python2 incompatibility. (dlehman) +- Adapt action test mock imports for compatibility w/ python2 & python3. + (dlehman) +- Use explicit super() syntax in config actions for py2 compat. (dlehman) +- Use libblockdev runtime dependency checks (#1501249) (vtrefny) +- Fix minor typos (yurchor) + +* Mon Apr 02 2018 David Lehman - 1:3.0.0-0.6.1.b1 +- Use bcond for with python3, allow it on RHEL > 7 (mhroncok) +- Conditionalize the Python 2 subpackage and don't build it on EL > 7 and Fedora > 28 (mhroncok) + +* Tue Mar 20 2018 David Lehman - 1:3.0.0-0.6.b1 +- Don't use a 'wwn' kwarg for MDBiosRaidArrayDevice (#1557957) (awilliam) + +* Sat Mar 17 2018 Iryna Shcherbina - 1:3.0.0-0.5.b1 +- Update Python 2 dependency declarations to new packaging standards + (See https://fedoraproject.org/wiki/FinalizingFedoraSwitchtoPython3) + +* Mon Mar 12 2018 David Lehman - 1:3.0.0-0.4.b1 +- Allow device specification by node to udev.get_device. (#1524700) + +* Tue Mar 06 2018 Vojtech Trefny - 1:3.0.0-0.3.b1 +- Dasd is a valid label type on s390x (#1538550) + +* Fri Feb 09 2018 Fedora Release Engineering - 1:3.0.0-0.2.b1 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_28_Mass_Rebuild + +* Wed Nov 08 2017 David Lehman - 3.0.0-0.1.b1 +- Add some reasonable default value for LANG variable in size_test (vtrefny) +- Remove ksdata from Blivet. (dlehman) +- Fix AttributeError in fsminsize (#1502587) (vtrefny) +- Remove Blivet.write_dasd_conf and now-unused Blivet.write. (dlehman) +- Move blivet.partspec into pyanaconda. (dlehman) +- Make uboot partition weight match analogs on other platforms. (dlehman) +- Move some cmdline option checking into Flags. (dlehman) +- Move platform module into pyanaconda. (dlehman) +- Add and use new platform detection functions in arch. (dlehman) +- Move disklabel selection logic into DiskLabel. (dlehman) +- Move new partition weight calculation into PartitionDevice. (dlehman) +- Move osinstall and autopart into pyanaconda. (dlehman) +- Move default thin pool space reservation into devices.lvm. (dlehman) +- DM device subsystem is now obtained by libblockdev (japokorn) +- Document DBus interface. (dlehman) +- Mark the DBus interface as unstable. (dlehman) +- Do not try to use protected disks for autopart (vtrefny) +- Use InstallerStorage in setupDiskImagesNonZeroSizeTestCase (vtrefny) +- Clearpart test tag fixes (japokorn) +- Added support for device tags (japokorn) +- Use Ansible playbook to install test dependencies (vtrefny) +- Use addCleanup for VM tests too (vtrefny) +- Skip tests when SELinux is disabled (japokorn) +- Revert "Use libmount for MountsCache" (vtrefny) +- Only run log_method_call when flags.debug is set. (dlehman) +- Adjust Makefile and spec file for Python 2 compatibility (vtrefny) +- Adapt to anaconda_log rename (mkolman) +- Followup for custom six move for mock. (dlehman) +- Silence pylint with regard to custom six move of mock. (dlehman) +- Allow overriding PYTHONPATH when running unit tests. (dlehman) +- Supply some missing patches during device name tests. (dlehman) +- Allow time for event handling in unit tests. (dlehman) +- python2: Don't try to call unbound method w/ wrong class type. (dlehman) +- python2: threading compatibility. (dlehman) +- python2: compatibility for wraps when used on methods. (dlehman) +- python2: adapt to absence of inspect.signature. (dlehman) +- python2: python2 has no unittest.assertLogs. (dlehman) +- python2: Handle unittest.assertRaisesRegex rename. (dlehman) +- python2: Add a custom six move for mock. (dlehman) +- python2: EddEntry support for len() and indexing. (dlehman) +- python2: Don't use 'default' kwarg to 'min' (dlehman) +- python2: Use six.wraps instead of functools.wraps. (dlehman) +- python2: Use six.raise_from for chained exceptions. (dlehman) +- python2: Use six.next for iterator advancement. (dlehman) +- python2: Explicit args to super function. (dlehman) +- python2: Explicitly declare new-style classes. (dlehman) +- python2: Use six.add_metaclass instead of metaclass kwarg. (dlehman) +- Catch AttributeError if pyanaconda is missing in populator_test. (dlehman) +- Use relative imports in blivet.dbus.blivet. (dlehman) +- pylint: disable pylint warning for InstallerStorage.get_free_space (vtrefny) +- pylint: ignore some pylint warnings in tests (vtrefny) +- Use "flags.keep_empty_ext_partitions" instead of "installer_mode" (vtrefny) +- Add a WWN attr to all disk device classes. (dlehman) +- Fix flag access in selinux test. (dlehman) +- Collect HW RAID info before populating devicetree. (dlehman) +- Add HW RAID properties to DiskDevice. (dlehman) +- Add a devicelibs module for disks. (dlehman) +- Add 'jbod' as an alias for 'linear' RAID level. (dlehman) +- Add some tests for DependencyGuard (dlehman) +- Introduce the discard_new flag and use it (vpodzime) +- Use the 'C.UTF-8' locale instead of '' (vpodzime) +- Add anaconda-core, libvirt and paramiko to TEST_DEPENDENCIES (vpodzime) +- Get rid of the merge-pr script (vpodzime) +- Adjust vmtest to new DeviceFactory constructor API (vtrefny) +- Obtain factory defaults from passed-in device, if there is one. (dlehman) +- Use **kwargs for device factory ctor. (dlehman) +- Use a property to adjust factory size based on encrypted bool. (dlehman) +- Functional testing: Add support for libvirt authentication (vtrefny) +- Fixed merge error (japokorn) +- Enable LVMOnMDTestCase (vtrefny) +- LVMThinSnapShotTestCase: Fix creating of the thin snapshot (vtrefny) +- Create a better test summary when running tests in a VM (vtrefny) +- Add a script to run tests in a virtual machine (vtrefny) +- Move BlivetResetTestCases from ImageBackedTestCase to VMBackedTestCase + (vtrefny) +- Add a test case for tests running in a virtual machine (vtrefny) +- Do not try to create format for snapshots in create_device (vtrefny) +- Use None as mountpoint for new snapshots (vtrefny) +- Do not try to unset flags on other devices than partitions (vtrefny) +- Fix TypeError when calling blivet.reset() (vtrefny) +- Broke backwards API compatibility of LUKS handling (japokorn) +- Default to LVM in the device factory. (dlehman) +- Add callbacks for populate (vpodzime) +- Fix checks when changing fslabel using actions (vtrefny) +- Remove deprecated method udev.device_is_realdisk (vtrefny) +- Use libmount for MountsCache (vtrefny) +- Fix initialization of ignored, exclusive disks. (dlehman) +- Fix devicetree tests to use callbacks instead of record_change. (dlehman) +- Change udev.device_is_disk to match disks only (vtrefny) +- Fix udev.resolve_glob to match device path too (vtrefny) +- Add tests for configuration actions (vtrefny) +- Allow changing format label using configuration actions (vtrefny) +- Add new actions for configuring formats and devices (vtrefny) +- Quickfix of merge bugs (japokorn) +- Remove action objects before resetting via dbus. (dlehman) +- Clean up dbus object management a bit. (dlehman) +- Only overwrite current format if the new one is different. (dlehman) +- Add a Factory method to DBusBlivet. (dlehman) +- Update example dbus client to account for Format interface. (dlehman) +- Adjust zanata version for new branch. (dlehman) +- Allow custom chunk size specification for MDRaidArrayDevice (vtrefny) +- Add zanata-python-client to TEST_DEPENDENCIES (bcl) +- Allow custom chunk size specification for MDRaidArrayDevice (vtrefny) +- Add zanata-python-client to TEST_DEPENDENCIES (bcl) +- Add a Commit method to DBusBlivet. (dlehman) +- Update unit tests. (dlehman) +- Move removed devices and formats into different subtrees. (dlehman) +- Use the object manager to look up objects. (dlehman) +- Add mappings of objects by id and object path to ObjectManager. (dlehman) +- Add an id property to DBusObject. (dlehman) +- Add an Action interface to the dbus service. (dlehman) +- Make sure DBusFormat's Type property is always a string. (dlehman) +- Pass blivet objects to blivet methods. (dlehman) +- Fix root detection on btrfs in rescue mode (vtrefny) +- Use device's mount options when mounting existing systems (vtrefny) +- Add a Commit method to DBusBlivet. (dlehman) +- Update unit tests. (dlehman) +- Move removed devices and formats into different subtrees. (dlehman) +- Use the object manager to look up objects. (dlehman) +- Add mappings of objects by id and object path to ObjectManager. (dlehman) +- Add an id property to DBusObject. (dlehman) +- Add an Action interface to the dbus service. (dlehman) +- Make sure DBusFormat's Type property is always a string. (dlehman) +- Pass blivet objects to blivet methods. (dlehman) +- Move some more installer-specific methods and values into blivet.osinstall. + (sbueno+anaconda) +- Mv copy_to_system from blivet.util to blivet.osinstall (sbueno+anaconda) +- Get rid of flags.installer_mode (sbueno+anaconda) +- Create flags.keep_empty_ext_partitions (sbueno+anaconda) +- Create flags.selinux_reset_fcon (sbueno+anaconda) +- Create flags.auto_dev_updates (sbueno+anaconda) +- Add a Format interface to the dbus service. (dlehman) +- Always require the rounding mode to be specified for Size (vpodzime) +- Add method DBusBlivet.InitializeDisk. (dlehman) +- Add a unit test for DBusBlivet.RemoveDevice. (dlehman) +- Maintain a mapping of object path to DBusDevice in DBusBlivet. (dlehman) +- Correctly handle failures in ResolveDevice. (dlehman) +- Add a RemoveDevice method to DBusBlivet. (dlehman) +- Convert event handling change accounting to use blivet callbacks. (dlehman) +- Add a set of callbacks for changes to blivet's view of things. (dlehman) +- Allow replacing an active format within blivet's model. (dlehman) +- Add the beginnings of an example client. (dlehman) +- Add a Device interface to the dbus service. (dlehman) +- Add an ObjectManager interface to the dbus service. (dlehman) +- Make DBusBlivet names more dbus-like. (dlehman) +- Clean up org.freedesktop.DBus.Properties code in DBusObject a bit. (dlehman) +- Move constants into a separate module. (dlehman) +- Convert some private methods to public properties. (dlehman) +- Import the whole dbus module in a couple of places. (dlehman) +- Add a minimal dbus interface. (dlehman) +- Rearrange the setup call to minimize changes on updates. (dlehman) +- Remove unused readthedocs code from setup.py. (dlehman) +- Ignore all merge commits when making rpm log. (dlehman) +- Isolate some boot device operations in blivet.partitioning. (sbueno+anaconda) +- Move bootloader stuff from Blivet to InstallerStorage. (sbueno+anaconda) +- Some small, stupid bugfixes to first installer isolation patch set. + (sbueno+anaconda) +- LVM data are now global (japokorn) +- Update api to reflect changes from isolating installer-specific code. + (sbueno+anaconda) +- Update examples and test cases for changes from isolating installer code. + (sbueno+anaconda) +- Get rid of blivet.blivet's last deps on blivet.osinstall (sbueno+anaconda) +- Get rid of blivet.blivet's dependence on blivet.osinstall.FSSet + (sbueno+anaconda) +- Mv installer-specific functions to install. Create InstallerStorage. + (sbueno+anaconda) +- Move StorageDiscoveryConfig from blivet.blivet to blivet.osinstall + (sbueno+anaconda) +- Move some StorageDiscoveryConfig attrs into Blivet. (sbueno+anaconda) +- Retrieve udev info as needed in handle_format. (dlehman) + +* Tue Sep 19 2017 Vojtech Trefny - 2.1.11-1 +- Remove build requires for pocketlint (rkuska) +- edd_test: don't run on non-x86 (pjones) +- Added support for device tags (japokorn) +- fcoe: don't use dcb for autoconnecting of bnx2x and bnx2fc (#1261703) + (rvykydal) +- fcoe: replace fipvlan with fcoemon (#1085325) (rvykydal) +- Do not use read-only mode for e2fsck (vpodzime) +- Fixed behavior when selinux is disabled (japokorn) +- Do file system check before resize (#1484575) (vpodzime) + +* Thu Aug 17 2017 Vojtech Trefny - 2.1.10-1 +- Use addCleanup for test cleanup instead of clening in tearDown (vtrefny) +- No longer skip test w/o selinux; mocked (japokorn) +- Skip tests when SELinux is disabled (japokorn) +- New test for selinux context setting when mounting (japokorn) +- Add tests for disklabel type selection and partition weight. (dlehman) +- Do not use package version to check version of installed tools (vtrefny) +- Update the upstream git URL (vpodzime) +- Stop enforcing obsolete limits on partition count. (#1460668) (dlehman) +- Do not run FS check as part of updating (re)size info (vpodzime) +- Change how we run e2fsck to check ext filesystems (vpodzime) +- Round the recommended thpool metadata size to extents (vpodzime) +- Respect thin pool's min size when setting its req_size (vpodzime) +- Don't crash during populate when lvm plugin is missing. (dlehman) +- Actually add space for LUKS metadata when encrypting a VG (vpodzime) +- Only consider old and new device sizes when not growing to max (vpodzime) +- Do not reserve space for LVM metadata twice (vpodzime) +- Do not create a temporary list for sum() (vpodzime) +- Refer to self.container as self.vg in the LVMFactory (vpodzime) +- Add a couple of extra comments and docstrings to factories (vpodzime) +- Use existing VG's PE size if available in LVMFactory (vpodzime) +- Add comments warning before a weird nomenclature in factories (vpodzime) +- Don't let device state block modification of the model. (dlehman) +- Fix error message for format create w/ missing external dep. (dlehman) +- Expand coverage of devices_test.dependencies_test a bit. (dlehman) +- Account for external dep availabilty in StorageDevice.controllable. (dlehman) +- Add the appropriate external dependency to LUKSDevice. (dlehman) + +* Thu Jun 01 2017 Vojtech Trefny - 2.1.9-1 +- Adapt to logging module name change (mkolman) +- Updated calls to avoid log spamming (japokorn) +- Add a script for generating and pushing updated documentation (vtrefny) +- pylint: ignore some false positive warnings in blivet.py and lvm.py (vtrefny) +- pylint: remove unused false positives from pocketlint config (vtrefny) +- pylint: disable false positive "not-context-manager" for threading.Lock + (vtrefny) +- pylint: ignore "arguments-differ" warnings in blivet.size.Size (vtrefny) +- pylint: fix various "arguments-differ" warnings (vtrefny) +- pylint: remove init from platform.X86 (vtrefny) +- pylint: fix various errors in tests (vtrefny) +- pylint: ignore "arguments-differ" warning for "do_tasks" method (vtrefny) +- pylint: fix false positive for "catching-non-exception" (vtrefny) +- pylint: fix argument name for Device._remove_parent/_add_parent (vtrefny) +- Always mount & unmount an XFS file system when writing new UUID (vpodzime) +- Do not remove manually created extended partitions (#1440150) (vtrefny) +- Look the disk up for a partition by name not sys_name (vpodzime) +- Disable pylint "no-member" warnings for re module constants (vtrefny) +- Allow custom chunk size specification for MDRaidArrayDevice (vtrefny) +- Add RAID chunk size to the generated kickstart file (vtrefny) +- Use structured logging for the anaconda logger (mkolman) +- Use distutils.spawn.find_executable instead of our custom code (vpodzime) +- Add a method to reset file system's UUID (vpodzime) +- Try to mount and unmount an XFS FS when writing UUID (vpodzime) +- Add a method for a file system to generate a new UUID (vpodzime) +- tests/fsuuid: Implement checking invalid UUIDs (aszlig) +- formats/swap: Support setting UUID (aszlig) +- tests: Add a series of tests for setting UUIDs (aszlig) +- tests: Add tests to check the UUID format checkers (aszlig) +- tasks: Implement setting UUID after FS creation (aszlig) +- formats/fs: Implement setting UUID during mkfs (aszlig) +- formats/fs: Add functionality for checking UUIDs (aszlig) +- tasks/fsmkfs: Add arguments for setting UUID (aszlig) +- Properly unset mountpoint of a snapshot's format (vpodzime) +- Update snapshot's format's exists flag based on its origin (vpodzime) + +* Wed Apr 19 2017 Vojtech Trefny - 2.1.8-1 +- Fix "unknown" SAS device sysfs parsing. (adamw) +- Reserve space in a VG when using LVMThinPFactory (vpodzime) +- Reserve space in a VG instead of padding thin pools on autopart (vpodzime) +- Focus the nonzero disk image size test a bit. (dlehman) +- Add missing tearDown method to luks resize test case. (dlehman) +- Fix some flag stomping in tests. (dlehman) +- Remove the useless method requiredDiskLabelType (vponcova) +- FBA DASD should use the msdos disk label type (vponcova) +- Be more careful when checking for udisks-iscsi availability (vpodzime) +- Do not allow resize of devices with no/unrecoginized formatting. (#1033778) + (dlehman) +- Clean up parent/child relations on partition ctor error. (#1383873) (dlehman) +- Use all ancestors when adding RAID disks to exclusiveDisks (vtrefny) +- Fix detection of linear MD RAID (vtrefny) +- Add 'discard' option to crypttab for newly created LUKS (vpodzime) +- Loop devices w/o backing file are now ignored (japokorn) +- Set parted boot flag when creating EFI filesystem (vtrefny) +- formats/fs: Set NTFS to be formattable (aszlig) +- Do not try to search for 'tmpfs' devices in udev database (vtrefny) +- Fix resize test in fstesting (vtrefny) +- Fix task availability test (vtrefny) +- Shallow copy another alignment property (#1408282) (awilliam) +- Fix the test dependencies (vpodzime) +- Add 'systemd-udev' to dependencies (#1392591) (vtrefny) + +* Sat Feb 11 2017 Fedora Release Engineering - 1:2.1.7-7 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_26_Mass_Rebuild + +* Sat Dec 24 2016 Adam Williamson - 1:2.1.7-6 +- Actually apply the patch mentioned in -5 + +* Fri Dec 23 2016 Adam Williamson - 1:2.1.7-5 +- backport GH#530 to fix #1408282 (crash with Python 3.6) + +* Mon Dec 19 2016 Miro Hrončok - 1:2.1.7-4 +- Rebuild for Python 3.6 + +* Tue Dec 6 2016 Vratislav Podzimek - 2.1.7-3 +- Add 'systemd-udev' to dependencies (#1392591) (vtrefny) + +* Mon Nov 21 2016 Vratislav Podzimek - 2.1.7-2 +- Fix "unknown" SAS device sysfs parsing. (#1394026) (awilliam) + +* Mon Nov 21 2016 Vratislav Podzimek - 2.1.7-1 +- Require BlockDev 2.0 in the gi.require_version() call (vpodzime) +- Fix detection of 'macefi' partitions (#1393846) (awilliam) +- Add device symlinks to the PVs dictionary for MD RAID PVs (#1389130) + (vpodzime) +- iSCSI: turn `iscsi.initiator_set` into a property (awilliam) +- iSCSI: Store auth info in NodeInfo tuples (awilliam) +- Use correct type for port in GVariant tuple (awilliam) +- Use a list comprehension for _to_node_infos (awilliam) +- Device name now checked only for new devices (japokorn) +- Remove several redundant teardown calls. (dlehman) +- Cache and reuse data about multipath members (vpodzime) +- Remove some obsolete pvscan calls. (dlehman) + +* Tue Oct 04 2016 David Lehman - 2.1.6-1 +- add missing populators to populator.helpers (awilliam) + +* Mon Sep 26 2016 David Lehman - 2.1.5-1 +- Move parted changes to after format destroy. (#1378162) (dlehman) +- Add translators comment for unsupported disklabel names (vtrefny) + +* Tue Sep 20 2016 David Lehman - 2.1.4-1 +- Revert unsupported clearing of parted partition 'system'. (dlehman) +- Make sure we create a proper GVariant tuple as args (#1375712) (vpodzime) +- Do not include both size and percent in logvol ks cmd. (dlehman) +- Ignore NVDIMMs at OS installation time. (dlehman) +- Don't crash if lvm refuses to activate an lv. (dlehman) + +* Wed Sep 14 2016 David Lehman - 2.1.3-1 +- Remove some deprecated/obsolete bits from spec file. (dlehman) +- Use %%global instead of %%define for specfile macros. (dlehman) +- Fix URLs pointing to blivet resources. (dlehman) +- UUID is now cleaned when destroying format (japokorn) +- Support disk tags as disk specification for new partitions. (dlehman) +- Add tags property to Device with some defaults for disk variants. (dlehman) +- Add checks to git-multi-merge script (jkonecny) +- UUID now set correctly when reformatting partition (japokorn) +- Eliminate mountpoint symlinks when looking for mounted device (vtrefny) +- iscsi: allow installing bootloader on offload iscsi disks (qla4xxx) + (#1325134) (rvykydal) + +* Fri Aug 05 2016 David Lehman - 2.1.2-1 +- Update release notes to include previous two releases. (dlehman) +- Allign the LV's size up to set the base size for growing (vpodzime) +- Ensure biosboot shows up in kickstart (#1242666) (rmarshall) +- Add tests for the new LV from LVs actions (vpodzime) +- Make sure to add/remove internal LVs when adding/removing a compound LV + (vpodzime) +- Make sure all LVs to create a new LV from are in the DT (vpodzime) +- Make sure internal LVs are added/removed to/from DT properly (vpodzime) +- Make LVs depend on their internal LVs (vpodzime) +- Do not add the LV to devicetree in new_lv_from_lvs() (vpodzime) +- Require libblockdev version with all the functions we need (vpodzime) +- Allow for cascade creation of LVs from LVs (vpodzime) +- Fix removing PVs after removing VG (#1358067) (vtrefny) +- Pass arguments to get_member_raid_sets() in the correct order (#1225184) + (vpodzime) +- Use the new way extra information is provided for LVs (vpodzime) +- Add a method to determine if a udev device is a disk. (vtrefny) +- Fix udev.resolve_glob to match device path too (vtrefny) +- Adapt to the old-new storaged API paths (vpodzime) +- Handle an mpath name as lone exclusive disk. (#984059) (dlehman) +- Add unit tests for disk filter. (dlehman) +- Allow creation of a new LV from other LVs (vpodzime) +- Removed test for snapshot origin existance (jkonecny) +- Don't require existing origin when modeling snapshot (jkonecny) +- Update size for dmraid arrays found during populate. (#1269662) (dlehman) +- Restore the correct default partition table type for AArch64 EFI. (dmarlin) +- Fix args to cancel_disk_actions call from hide(). (dlehman) +- Fix not enough free space after creating extended partition (#1252350) + (vtrefny) +- Add some more unit tests for DeviceTree. (dlehman) +- Add tests for critical format methods. (dlehman) +- Split and include cache data and metadata sizes properly (vpodzime) +- Use internal LVs (if any) to calculate space used by existing LVs (vpodzime) +- Remove an unused calculation of VG's RAID PVs (vpodzime) +- Only include padding to nonexisting thin pools' vg_space_used (vpodzime) +- Require pyudev 0.18 or newer (vtrefny) +- Do not use deprecated pyudev methods (vtrefny) +- Show changes for each branch in git-multi-merge before pushing (vpodzime) + +* Mon Jun 06 2016 David Lehman - 2.1.1-1 +- Ignore all merge commits when making rpm log. (dlehman) +- Try harder to identify a partition's disk when necessary. (dlehman) +- Add some fallback methods for finding a partition's disk. (dlehman) +- Include devices on disklabels unsupported by parted in the devicetree. + (dlehman) +- Don't traceback if we fail to examine an md member. (dlehman) +- Disklabel commit errors can occur for disks, too. (dlehman) +- Add unit tests for device methods. (dlehman) +- ARM platforms: support both msdos and gpt partitions (pbrobinson) +- LUKS data moved to singleton (japokorn) +- Add the P_ keyword to xgettext. (dshea) +- Add xfs to default filesystem types (rmarshall) +- Fix blivet constructor fs support check (rmarshall) +- Do not put LVM stuff into syslog (vpodzime) +- Kickstart missing bootloader partitions (#1242666) (rmarshall) + +* Thu May 12 2016 David Lehman - 2.1.0-1 +- Add name of problematic device to UnusableConfigurationError (vtrefny) +- LVM data are now global (japokorn) +- Allow custom chunk size specification for MDRaidArrayDevice (vtrefny) +- Mock all blockdev's listing functions for populator tests (vpodzime) +- Add zanata-python-client to TEST_DEPENDENCIES (bcl) + +* Thu May 12 2016 David Lehman - 2.0.3-1 +- Fix protected status for extended partitions (vtrefny) +- Improve documentation of the udev.resolve_glob() function (vpodzime) +- Remove the locale list from zanata.xml (dshea) +- Do not test translated strings during make ci. (dshea) +- Squashed 'translation-canary/' changes from 5a45c19..3bc2ad6 (dshea) +- Fix root detection on btrfs in rescue mode (vtrefny) +- Use device's mount options when mounting existing systems (vtrefny) +- Ignore pylint being confused with our mixins' properties (vpodzime) +- Get back to use ROUND_HALF_UP by default (vpodzime) +- Let Python import the formats for us (vpodzime) +- Only call resolve_devspec() in _get_active_mounts() for real devices + (vpodzime) +- Call is_mpath_member() only when it makes sense (dlehman) +- Break the cycle in LVMPhysicalVolume.destroy (#1331630) (vpodzime) +- Use libbytesize's translations for Size tests (vpodzime) +- Compare sizes instead of numbers of sectors (vpodzime) +- Obsolete python-blivet and blivet-data packages. (dlehman) +- Increase the default size of /boot to 1 GB. (#377) (clumens) +- Do not add btrfs volume subvolid to subvolumes mountopts (#1306808) (vtrefny) +- A simple script for multi-merges we now do (vpodzime) +- Update CONTRIBUTING file to match current practices. (dlehman) +- Only import the 'iscsi' singleton when really needed (vpodzime) +- Correctly recognize internal RAID LVs (vpodzime) +- Do not add mdarray with no slave (#1321393) (vtrefny) +- Make sure to add hyperPAV aliases to dasd.conf. (sbueno+anaconda) +- LVM data are now global (japokorn) +- Preserve traceback when re-raising exceptions (vpodzime) + +* Mon Apr 04 2016 David Lehman - 2.0.2-1 +- Fix mistake from PEP8 conversion. (#1323012) (dlehman) +- Set both req_size and size of thin pool when growing LVM (vpodzime) +- Retrieve udev info as needed in handle_format. (#1322943) (dlehman) +- Fix requires after subpackage switcharoo. (dlehman) +- Fix package naming in spec file. (dlehman) + +* Tue Mar 29 2016 David Lehman - 2.0.1-1 +- Make sure EddMatcher.root is a string. (dlehman) +- Move per-thread change accounting to a function. (dlehman) +- Add missing conf kwarg in call to PopulatorMixin ctor. (dlehman) +- Fixes found while porting anaconda to blivet-2.0 (dlehman) +- Mock all blockdev's listing functions for populator tests (vpodzime) + +* Wed Mar 09 2016 David Lehman - 2.0.0-1 +- Bump version to 2.0.0 + +* Wed Mar 09 2016 David Lehman - 2.0.0-0.1.b1 +- Make sure we use the Size class properly (vpodzime) +- Don't store size as int in SameSizeSet (vpodzime) +- Use libbytesize's Size class as a base for our Size class (vpodzime) +- Remove the second section about LUKS resize from release notes (vpodzime) +- Streamline the TOC to only include top-level sections. (dlehman) +- Adjust section hierarchy in intro doc. (dlehman) +- Move testing docs into a file of their own. (dlehman) +- Add an api specification to the docs. (dlehman) +- Add luks resize and API stability efforts to release notes. (dlehman) +- Clean up some of the singleton usage. (dlehman) +- Drop sphinx mocking. (dlehman) +- Reset container_uuid when removing PV from a VG (vtrefny) +- Remove "destroy_format" method from docs (vtrefny) +- Fix AttributeError in pv_free_info (vtrefny) + +* Wed Feb 24 2016 David Lehman - 2.0.0-0.1.a1 +- Update zanata config for 2.0 branches. (dlehman) +- Remove cleanup of rc-release relics from ci target. (dlehman) +- Don't run rc-release as part of ci for now. (dlehman) +- Regenerate blivet.pot. (dlehman) +- Specify encoding of pvtask.py to placate gettext. (dlehman) +- Silence pylint complaint about passed callable. (dlehman) +- Tear down devices on disk images before tearing down the images. (dlehman) +- Update check for thin pool to work with new lv classes. (dlehman) +- Use Blivet.do_it instead of calling ActionList.process in factory example. (dlehman) +- Get rid of examples.common. (dlehman) +- Allow for pre-release builds. (dlehman) +- Fix load_module call in translation-canary. (dlehman) +- Remove a couple of stray python2 invocations. (dlehman) +- Do not call pvmove when removing an empty PV from VG. (vtrefny) +- Add task for finding LVMPhysicalVolume format size (vtrefny) +- Fix TypeError/AttributeError when adding thinpools and snapshots (vtrefny) +- Fix current_size name in StorageDevice.update_size (vtrefny) +- Ignore PEP8 errors E402 and E731 (vtrefny) +- Make sure all checks run on 'make check' (vtrefny) +- PEP8 fixes (vtrefny) +- Add LUKS resize to release notes (vtrefny) +- Add test for LUKS format resize (vtrefny) +- Add a task for finding the size of a LUKS device (vtrefny) +- Use DeviceFormatError and FormatResizeError in DeviceFormat (vtrefny) +- Add LUKS resize support to resize_device method (vtrefny) +- Define min_size for encrypted devices (vtrefny) +- Do not teardown partition when resizing encrypted partition (vtrefny) +- Make partitions with children resizable (vtrefny) +- Make LUKS format resizable (vtrefny) +- Make LUKSDevice resizable (vtrefny) +- Make lukstasks and dfresize task pep8 compliant (vtrefny) +- Add a LUKS resize task. (amulhern) +- Make a top level device format resizing task class. (amulhern) +- Move resize related methods from FS to DeviceFormat (vtrefny) +- Disable spurious import-error from pylint. (dlehman) +- Add blivet.events package to setup.py. (dlehman) +- Remove unused util import from prepboot.py. (dlehman) +- Remove deprecated methods and properties. (dlehman) +- Flesh out the release notes. (dlehman) +- Include python3-bugzilla when running tests (bcl) +- Cleanup wildcard import in misc_test.py (bcl) +- Add an example of event monitoring. (dlehman) +- Mask uevents when updating parted.Disk. (dlehman) +- Handle first-time open of luks devices. (dlehman) +- Add a device populator for opened/decrypted LUKS devices. (dlehman) +- Update sysfs path before updating size in StorageDevice ctor. (dlehman) +- Validate event handling callbacks. (dlehman) +- Hook up the event notify callback. (dlehman) +- Account for changes made in response to each event. (dlehman) +- Add facilities for reporting exceptions that occur in threads. (dlehman) +- Add event handlers via a DeviceTree mixin class. (dlehman) +- Add PopulatorHelper method to update device/formats. (dlehman) +- Add classes for managing external events. (dlehman) +- Add methods to wrap helper getters. (dlehman) +- Only settle udev queue in get_devices when not handling events. (dlehman) +- Allow passing a device to any PopulatorHelper constructor. (dlehman) +- Implement DiskLabelFormatPopulator._get_kwargs. (dlehman) +- Add a property indicating the type to pass to get_format. (dlehman) +- Add functions for resolving between block major and device type. (dlehman) +- Plumb modparent through DeviceTree.recursive_remove. (dlehman) +- Add a flag to preserve the root device in recursive_remove. (dlehman) +- Add container_uuid r/w property to container member format classes. (dlehman) +- Set VG format as existing as part of VG creation. (dlehman) +- Remove old hack meant to remove stale metadata. (dlehman) +- Store disklabel and partition UUIDs when available. (dlehman) +- Add a method to re-read the disklabel from disk. (dlehman) +- Use wipefs to remove disklabels. (dlehman) +- Add support for passing the new size into StorageDevice.updateSize. (dlehman) +- Add a method to cancel all actions related to a specified disk. (dlehman) +- Add a flag to ActionList to indicate in-progresss action processing. (dlehman) +- Avoid failure to generate unit test API docs. (dlehman) +- Add a console logger and a function to activate it. (dlehman) +- Make LoopDevice size consistent with other device types. (dlehman) +- Don't try to use a name bound via 'as' outside the try/except block. (dlehman) +- Remove code for notifying the kernel of changes to block devices. (dlehman) +- Add dependency checks for iSCSI operations (vpodzime) +- Add decorator for guarding methods with external dependency checks (vpodzime) +- Add a function for testing if some DBus object is available (vpodzime) +- Use namedtuple for target info and tiny class for login infos (vpodzime) +- Use the storaged's iSCSI DBus API instead of libiscsi (vpodzime) +- Use the ) +- Add a module for doing DBus operations in the safest possible way (vpodzime) +- Do not retry interruptible system calls. (dshea) +- Document the LV class unification changes in the release notes (vpodzime) +- Adapt our tests to the changes in representation of LVs (vpodzime) +- Adapt our code to changes in the representation of LVs (vpodzime) +- Rewrite the code for representing LVs (vpodzime) +- Add a test for the to-be-used ) +- Add a decorator for guarding methods and properties with a property (vpodzime) +- Transform the is_name_valid() into an instance method (vpodzime) +- Add tests for FS overhead methods (jkonecny) +- Add more class methods for better use of metadata (jkonecny) +- Remove python2 assert regex method name hacks. (dlehman) +- Fix various pylint errors introduced with python-3.5. (dlehman) +- Add a file with release notes (vpodzime) +- Blacklisted attrs should be unwrapped, not omitted. (dlehman) +- Return the device when returning early from degraded md handler. (dlehman) +- Fix application of synchronization metaclass to DeviceTree. (dlehman) +- Fix AttributeError in populator LUKS helper (vtrefny) +- Update spec file for blivet 2.0 builds (vtrefny) +- Add populator.helpers to package (vtrefny) +- Add translator comments to the byte size prefixes. (dshea) +- Integrate translation-canary with blivet. (dshea) +- Update blivet.pot during scratch-bumpver. (dshea) +- Always use setup.py sdist to generate source tarballs. (dshea) +- Squashed 'translation-canary/' content from commit 5a45c19 (dshea) +- Update class and methods in "Introduction to Blivet" (vtrefny) +- Build documentation with python3 sphinx (vtrefny) +- Fix PEP8 violations introduced in the LVM RAID commits (vpodzime) +- Make the main class hierarchies thread-safe. (dlehman) +- Add unit tests for changes related to non-linear LVs (vpodzime) +- Make sure we try to match LVM RAID levels with all their names (vpodzime) +- Don't bother user code with LVM RAID meta data (vpodzime) +- Inherit the RaidDevice mixin in the LVMLogicalVolumeDevice class (vpodzime) +- Account for a pmspare LV creation or growth when determining the cache size (vpodzime) +- Refresh the PV free space info after LV creation (vpodzime) +- Add an early check of the requested LV segment type (vpodzime) +- Add example of LVM cache creation (vpodzime) +- Make sure the slow_pvs+fast_pvs list we pass to libblockdev has no dups (vpodzime) +- Use pv.path instead of constructing it from name and "/dev/" (vpodzime) +- Account for LVM cache space in PVs (vpodzime) +- Fix the twisted logic of lv.metadata_size (vpodzime) +- Replace the 'copies' property of LVs with something more accurate (vpodzime) +- Track information about free space in existing PVs (vpodzime) +- Add guards making sure we are not being tricked with LV seg_type (vpodzime) +- Define and use a new is_raid_lv property of LVMLogicalVolumeDevice (vpodzime) +- Add an example of non-linear LV creation (vpodzime) +- Create non-linear LVs before linear LVs (vpodzime) +- Account for LVM RAID metadata (vpodzime) +- Define RAID level for LV and use it to determine required PV space (vpodzime) +- Add a definition for the striped "RAID level" (vpodzime) +- Track information about free space in a PV (vpodzime) +- Honor the LV segment type when creating it (vpodzime) +- Let LVMLogicalVolumeDevice specify PVs it should be allocated from (vpodzime) +- Define the Device.parent property with the ) +- Adjust to Device now having a list of child devices. (dlehman) +- Maintain a list of child devices in Device. (dlehman) +- Add unit tests to explicitly cover container member set changes. (dlehman) +- Remove ParentList.replace and its usage. (dlehman) +- Improve logging of failure to validate new default fstype. (dlehman) +- Remove unused populated attribute from Populator. (dlehman) +- Stop passing around the iscsi singleton. (dlehman) +- Make the iscsi singleton satisfactory to pylint. (dlehman) +- Remove the various DASD lists from Blivet and DeviceTree. (dlehman) +- Convert Populator to a mixin class. (dlehman) +- Move disk filter bits from Populator into DeviceTree. (dlehman) +- Move the LVM data cache from DeviceTree to Populator. (dlehman) +- Rename per-device Populator entry points. (dlehman) +- Make Populator.udev_device_is_disk a private method. (dlehman) +- Stop writing an mdadm.conf. (dlehman) +- Group disk-image-related methods together in source code. (dlehman) +- Move some code from _populate into separate methods. (dlehman) +- Split various parts of add_udev_device into separate methods. (dlehman) +- Remove some extraneous methods related to ignored devices. (dlehman) +- Only handle loop devices with a backing file. (dlehman) +- Add unit tests for populator helpers. (dlehman) +- Use helper getter functions to find populator helpers. (dlehman) +- Add functions to return a helper class based on device data. (dlehman) +- Move format-type-specific bits into populator helpers. (dlehman) +- Split DiskDevicePopulator up by disk type. (dlehman) +- Move device-type-specific populator bits to populator helpers. (dlehman) +- Add base classes for type-specific Populator helpers. (dlehman) +- Use the mpath_member ID_FS_TYPE set up by the multipath udev rules. (dlehman) +- Make blivet.populator into a subpackage. (dlehman) +- Convert device_get_dm_partition_disk to not be dm-specific. (dlehman) +- Use DeviceTree.__str__ when printing devices in examples. (dlehman) +- Disk image test can only be run as root. (dlehman) +- Fix few more camelCase leftovers (vpodzime) +- Fix various PEP8 violations in recent EDD commits. (dlehman) +- Add PEP8 compliance checking to 'check' target. (dlehman) +- Teardown all devices before tearing disk images down (vpodzime) +- Change doc Introduction to reflect PEP8 compliance changes (vtrefny) +- Few PEP8 compliance related fixes (vtrefny) +- Pass devices arg when calling actions.process (vtrefny) +- Do not catch CryptoError when decrypting LUKS format (#1280239) (vtrefny) +- Fix makebumpver for new conf.py (bcl) +- Bump version numbers to 2.0 before we forget. (bcl) +- Only prepend the root to get the ondisk path if there is some (vpodzime) +- Ignore unused memo_dict arguments in __deepcopy__ methods. (clumens) +- Update the getattr calls with PEP8 property/attribute names (vpodzime) +- Do not create a copy of singleton objects (vpodzime) +- Fix pylint problems with the new default namedtuple stuff. (clumens) +- Do not try to get LVM cache's size from stats for inactive LV (vpodzime) +- edd: Add mostly fixed virt data (pjones) +- edd: Add another terrible seabios dataset (pjones) +- edd: Add test data from a Strawberry Mountain machine w/ lots of SATA. (pjones) +- edd: Fix the error case in the "absurd_virt" test. (pjones) +- edd: Add absurd_virt tests back in (pjones) +- edd: Try to detect multiple ATA/SATA matches and log them. (pjones) +- edd: Split up VirtIO and VirtIO SCSI matching (pjones) +- edd: Log every glob.glob() match in our test data log. (pjones) +- edd: Eradicate fsroot entirely. (pjones) +- edd: add EddEntry.bios_device_number (pjones) +- edd: Make our own assertVerboseListEqual to get rid of truncated output. (pjones) +- edd: Add sysfslink for mbr matches (pjones) +- Make get_sysfs_attr() use our path joiners and add sysfs_readlink() (pjones) +- Make a "Path" object that handles separate fs root for us. (pjones) +- edd: Minor PEP8 fix (pjones) +- Add a much much simpler path normalizer and joiner. (pjones) +- Improve clarity of error when setting new default fstype fails. (dlehman) +- Fix missed rebase of populator test from 169dc6b6. (dlehman) +- Add a class constructor for namedtuples with default values (vpodzime) +- Use lvm.round_size_to_pe() instead of get_lv_physical_size() with the VG size (vpodzime) +- Account for LVM metadata in the LVMFactory (vpodzime) +- Put the LVM metadata size calculation into a separate property (vpodzime) +- Rename size->space in LVMFactory._get_total_space (vpodzime) +- Remove action-oriented wrapper methods from DeviceTree. (dlehman) +- Put DeviceTree methods into a sensible order. (dlehman) +- Fix remaining PEP8 violations. (dlehman) +- Fix PEP8 indentation issues. (dlehman) +- Fix the easy PEP8 violations. (dlehman) +- Make all names conform to PEP8. (dlehman) +- Update dmdev size when setting up disk images (atodorov) + +* Wed Oct 28 2015 Brian C. Lane - 1.16-1 +- Merge pull request #257 from vpodzime/master-singleton_decorator (vpodzime) +- Add pylint stuff to .gitignore (pjones) +- Minor cleanups in set_up_logging() (pjones) +- Make a logger for test data that we can automatically use later (pjones) +- edd: Fix one regexp so it matches against a real system /or/ test data. + (pjones) +- Merge pull request #253 from dashea/libblockdev-python (vpodzime) +- Make the function adding the deprecation doc text more generic (vpodzime) +- Merge pull request #242 from dwlehman/resolveDevice-regex (dlehman) +- Fix an overly inclusive regex in DeviceTree.resolveDevice. (dlehman) +- Merge pull request #244 from atodorov/master (vpodzime) +- Require the python libblockdev packages (dshea) +- Merge pull request #243 from dwlehman/flexible-alignment (dlehman) +- Merge pull request #230 from vpodzime/master-lvm_debug (vpodzime) +- Add a 'debug' flag and use it for LVM debugging (vpodzime) +- Bypass util.run_program to avoid logging deadlock. (dlehman) +- Add an edd test data harvester. (pjones) +- Do not save None as passphrase for LUKS devices (#1269646) (vtrefny) +- edd: make logging work usefully during tests (pjones) +- edd: Get rid of biosdev_to_edd_dir(), it is pointless. (pjones) +- Make distutils.filelist.findall() do the right thing with symlinks maybe. + (pjones) +- edd: Fix some minor 'make check' complaints. (pjones) +- edd: Make devicetree not use edd.edd_dict, instead use blivet's copy. + (pjones) +- edd: Remove the "absurd_virt" test cases for now. (pjones) +- Add a udev settle call after instantiating parted.Disk. (#1267858) (dlehman) +- edd: Add missing directories for absurd_virt test case. (pjones) +- produce coverage-report.log and enable coverage in CI (atodorov) +- Use minimal alignment as needed when allocating small partitions. (dlehman) +- Add support for minimal alignment of very small partitions. (dlehman) +- Add an error class for alignment errors. (dlehman) +- Deprecate createSubVolumes method (vtrefny) +- Change btrfs.do_self_mount to contextmanager (#1266673) (vtrefny) +- edd: Remove a bunch of nonfunctional EDD tests. (pjones) +- edd: Add another set of test cases for our QEMU data. (pjones) +- edd: Add another set of test data. (pjones) +- edd: Add some working tests for EDD. (pjones) +- edd: Add a real EDD dataset captured from a system. (pjones) +- edd: Make our edd matcher able to use a fake sysfs root. (pjones) +- edd: Add EDD 4 code and some logging cleanups. (pjones) +- edd: Try to make EDD support actually match what the kernel does. (pjones) +- Always build python2 and python3 versions. (bcl) +- Switch to using rd.iscsi.initiator (#1268315) (bcl) + +* Fri Oct 02 2015 Brian C. Lane - 1.15-1 +- Update Makefile to default to python3. (dlehman) +- Add test for extended partition minSize (vtrefny) +- Allow resizing of non-leaf partitions (vtrefny) +- Fix minSize for extended partitions (#1254875) (vtrefny) +- Fix calling non-existing method (#1252902) (jkonecny) +- Use the RAID classes to calculate btrfs sizes (#1264696) (dshea) +- Handle sysfs size if it is missing (#1265090) (bcl) +- Convert float to str for better precision in Size (jkonecny) +- Merge pull request #226 from dwlehman/lvactivate-lvmetad (dlehman) +- Wait for auto-activation of LVs when lvmetad is running. (#1261621) (dlehman) +- Add a function to tell us if the lvmetad socket exists. (dlehman) +- Don't teardown FSs when searching for installed systems (#1252902) (jkonecny) +- Merge pull request #218 from vpodzime/master-lvm_on_raid_improvements + (vpodzime) +- Account for bigger LVM meta data due to alignment on MD RAID (vpodzime) +- Calculate the MD RAID superblock size from the right size (vpodzime) +- Don't be naïve about liblvm (vpodzime) + +* Fri Sep 11 2015 Brian C. Lane - 1.14-1 +- Make sure devices are torn down in findExistingInstallations (#1261439) + (vpodzime) +- Merge pull request #211 from dwlehman/multipath-member-metadata (dlehman) +- Merge pull request #212 from dwlehman/recursive-teardown (dlehman) +- Mount efivarfs during os installation (#1260799) (bcl) +- Use --whatprovides when querying for if all requirements are installed. + (clumens) +- Add method for estimated size of formated device (#1224048) (jkonecny) +- Add support for mul,div,sub,add by float to Size (jkonecny) +- Merge pull request #220 from AdamWill/nodev-typo (vpodzime) +- fix typo in NoDevice: updateSize not udpateSize (awilliam) +- Duplicate VG names are problem even if their disks are ignored (#1198367) + (vpodzime) +- Merge pull request #215 from vpodzime/master-lvm_on_raid (vpodzime) +- Do not reserve extra space for metadata in a VG with RAID PVs (vpodzime) +- Merge pull request #207 from vpodzime/master-lvm_pmspare (vpodzime) +- Fix currentSize for extended partitions (#1254899) (vtrefny) +- Catch problems with chassis vendor names (#1256072) (bcl) +- Don't teardown protected devices (jkonecny) +- Don't store UUIDs or labels of multipath members. (dlehman) +- Continue with recursive teardown beyond inactive devices. (dlehman) +- Reserve space for the 'pmspare' LV in a VG (vpodzime) +- Add a property to get cached LVs in a VG (vpodzime) +- Fix VG free space check when shrinking an LV (vpodzime) +- Add a property for Requests to reserve some extra space (vpodzime) +- Use Size instances for sizes in LVM cache's stats (vpodzime) +- Implement metadata size reporting for the LVM cache (vpodzime) + +* Mon Aug 24 2015 Brian C. Lane - 1.13-1 +- Add CONTRIBUTING file to blivet. (sbueno+anaconda) +- Merge pull request #208 from vpodzime/master-luks_catch_exceptions (vpodzime) +- Fix the name of the variable specifying requested libblockdev plugins + (#1256273) (jstodola) +- Merge pull request #209 from vpodzime/master-thinp_fix (vpodzime) +- Change labelFormatOK to classmethods (vtrefny) +- Add 'build' and '.directory' to gitignore (vtrefny) +- Fix copy method (#1254135) (bcl) +- Add OSError to list of errors in updateSysfsPath (#1252949) (bcl) +- Remove the cacheRequest kwarg for thin(pool) LVs (#1254567) (vpodzime) +- Do not propagate low-level blockdev.CryptoError when setting up LUKS + (#1253925) (vpodzime) +- Merge pull request #199 from vpodzime/master-lvm_cache_tests (vpodzime) +- Merge pull request #201 from vpodzime/master-mountsCache_resolve_devspec + (vpodzime) +- Prefer code consistency over pylint's complaints in tests (vpodzime) +- Add a basic test for cached LVMLogicalVolumeDevice's properties (vpodzime) +- Add a basic test for LVMLogicalVolumeDevice's properties (vpodzime) +- Make sure LV's properties reporting size return a Size instance (vpodzime) +- Add unit tests for the LVM cache support (vpodzime) +- Use device name from udev only if it's available (#1252052) (vpodzime) +- Add test for getFreeSpace aligning (vtrefny) +- Allow aligning free regions to disk grainSize (#1244671) (vtrefny) +- Fix _unalignedMaxPartSize for logical partitions (#1250890) (vtrefny) + +* Fri Aug 07 2015 Brian C. Lane - 1.12-1 +- Remove unusable free regions from list when setting up growth. (dlehman) +- Merge pull request #190 from vpodzime/master-lvm_cache_creation (dlehman) +- Merge pull request #194 from dwlehman/mount-cache-symlinks (dlehman) +- Merge pull request #193 from dwlehman/md-fwraid-detection (dlehman) +- Add unit tests to cover md containers. (dlehman) +- Minor cleanup of blivet.formats.fs.BTRFS._preSetup. (dlehman) +- Fix isDisk and partitionable properties for md fwraid. (dlehman) +- Don't use MD_DEVNAME as device name for md partitions. (dlehman) +- Use udev to find name of md members' container. (dlehman) +- Call superclass ctor a bit later to get size attrs set up first. (dlehman) +- updateSize for md containers is a no-op. (dlehman) +- Fix UnboundLocalError in FSMinSize (#1249304) (vtrefny) +- Fix mount cache resolution of devices with symlinks. (#1247803) (dlehman) +- Add kwarg to udev.resolve_devspec to return canonical device name. (dlehman) +- Use slow as well as fast PVs for cached LV's non-cache part (vpodzime) +- Make VG determination in Blivet.newLV() less cryptic (vpodzime) +- Reserve space for LVM cache(s) when growing LVM requests (vpodzime) +- Create cached LVs before non-cached LVs (vpodzime) +- Add support for LVM cache creation to LVM device classes (vpodzime) +- Add generic class for cache creation requests (vpodzime) +- Two minor fixes in LVMLogicalVolumeDevice's constructor's docstring + (vpodzime) + +* Fri Jul 31 2015 Brian C. Lane - 1.11-1 +- Put MDRaidArrayDevice.devices back, but mark it as deprecated. (dlehman) +- Skip tearing down devices when unmounting filesystems (bcl) +- Include details when umount fails (bcl) +- Merge pull request #183 from dwlehman/tests-20150728 (dlehman) +- Merge pull request #182 from dwlehman/devicefactory-20150728 (dlehman) +- Merge pull request #184 from dwlehman/misc-20150728 (dlehman) +- Enable unit test suite in jenkins. (dlehman) +- Disable image-backed unit tests temporarily. (dlehman) +- Add some tests for DeviceFactory. (dlehman) +- Do basic child accounting when replacing a parent. (dlehman) +- Set new raid level on correct device in MDFactory. (dlehman) +- Fix container member switching when toggling member encryption. (dlehman) +- Don't adjust actual lv size based on md metadata space requirements. + (dlehman) +- Merge pull request #57 from vpodzime/master-luks_npass (vpodzime) +- Fix names of the keyword arguments for luks_add_key and luks_remove_key + (vpodzime) +- Make a better effort to clean up loop devices on failure. (dlehman) +- Correctly get current size of disk files. (dlehman) +- Don't warn about missing UUIDs for non-existent containers. (dlehman) +- Only check disks for membership in a multipath. (dlehman) +- Only update md array name if MD_DEVNAME is set. (#1212073) (dlehman) +- Weed out unresolved macros in the check-requires target. (clumens) +- Merge pull request #126 from vpodzime/master-translations_subpackage + (vpodzime) +- Put translations into a subpackage shared by Python 2 and 3 (vpodzime) +- Require pygobject3-base instead of pygobject (#1246842) (dshea) +- Add method to list primary partitions (vtrefny) +- Merge pull request #179 from dwlehman/size-followups (dlehman) +- Fix test for failure to find space for device. (dlehman) +- Make sure factory target size is within the limits of the fstype. (dlehman) +- Unset obsolete format before updating device size. (dlehman) +- Make sure size is numeric before comparing it with format minimum. (dlehman) +- Don't constrain thin lv sizes to vg free space. (dlehman) + +* Fri Jul 24 2015 Brian C. Lane - 1.10-1 +- Merge pull request #177 from AdamWill/1245446 (dlehman) +- use floor division in calculating amount to reclaim (#1245446) (awilliam) +- Remember to use the shell command when calling external stuff in Makefile. + (clumens) +- Add a new makefile target that does everything needed for jenkins. (clumens) +- Add missing gobject introspection Requires (bcl) +- Add install-requires Makefile target (bcl) +- Update md and btrfs unit tests to run with recent size changes. (dlehman) +- Set format attr after super ctor for md. (dlehman) +- Account for container layer in md fwraid array properties. (dlehman) +- Ensure format is a DeviceFormat during initialization. (dlehman) +- Set target size when setting other size attrs. (dlehman) +- Use 'members' attribute to list RAID member devices. (dlehman) +- BTRFS subvolumes shouldn't inherit from RAIDDevice. (dlehman) +- Require a non-empty member set for md disks. (dlehman) +- Mock mount cache while running action tests. (dlehman) +- Account for recent lvm snapshot format changes in tests. (dlehman) +- Bump size of non-existent devices to format minimum. (dlehman) +- Don't pass createOptions along when creating the btrfs device. (clumens) +- Merge pull request #59 from vpodzime/master-tab_tab (vpodzime) +- Implement the __dir__ method of the LazyImportObject class (vpodzime) + +* Thu Jul 16 2015 Brian C. Lane - 1.9-1 +- Apply default size for new partition earlier in constructor. (dlehman) +- Don't pass model to md fwraid constructor. (#1242610) (dlehman) + +* Fri Jul 10 2015 Brian C. Lane - 1.8-1 +- Add a bunch more gi.require_version calls (dshea) +- Merge pull request #170 from dwlehman/size-cleanups (dlehman) +- Add unit tests for device size setters and getters. (dlehman) +- Only return target size if it is set to something meaningful. (dlehman) +- Validate new formats against current device size. (dlehman) +- Device size checks do not apply to existing devices. (dlehman) +- Make sure subclasses size setters use the base setter as appropriate. + (dlehman) +- x-initrd.mount should only be set for /var (#1238603) (bcl) +- There's a python3 anaconda now, so ditch the temporary false positives. + (clumens) +- Fix a syntax error caused by my previous commit. (clumens) +- Fix a duplicate key caused by patch merging. (clumens) +- Add support for specifying arbitrary mkfs options. (clumens) +- Align free regions before choosing one. (dlehman) +- Align partition sizes earlier in the allocation process. (dlehman) +- Don't crash on cleanup with DASDs or iSCSI devices present. (#1166506) + (dlehman) +- Make check-requires errors more readable. (dshea) +- Merge pull request #166 from dwlehman/autopart-snapshot-branch (dlehman) +- Default to a string when sorting mountpoints in FSSet.umountFilesystems. + (dlehman) +- Fix order of arguments to blockdev.thsnapshotcreate. (dlehman) +- Snapshot format exists upon snapshot creation. (dlehman) +- Improve format handling for lvm snapshots. (dlehman) +- Merge pull request #160 from dwlehman/lookup-method-deprecations (dlehman) +- Deprecate some little-used devicetree lookup methods. (dlehman) +- Add a decorator to mark deprecated functions/methods. (dlehman) +- Log python warnings, including DeprecationWarning. (dlehman) +- Catch and relay more exception types from the iscsi process (dshea) +- Use the pipes as contextmanagers to ensure they are closed (dshea) +- Close the unused half of pipes after the fork (dshea) + +* Fri Jun 26 2015 Brian C. Lane - 1.7-1 +- Merge pull request #167 from mulkieran/master-format-copy-b (mulkieran) +- Merge pull request #156 from vpodzime/master-lvm_cache_actually (vpodzime) +- Add cache support to the LVMLogicalVolumeDevice class (vpodzime) +- Copy all DeviceFormat objects using deepcopy. (amulhern) +- Make use of FSTask and FSUnimplementedTask in FS* tasks. (amulhern) +- Add an abstract parent of all filesystem tasks. (amulhern) +- Merge pull request #162 from dwlehman/storage-device-format-type-consistency + (dlehman) +- Merge pull request #138 from dwlehman/partitionable-md (dlehman) +- Document the fact that StorageDevice.format is always a DeviceFormat. + (dlehman) +- Ignore some interruptible system call warnings (dshea) +- Retry interruptible calls (dshea) +- Ignore EINTR from os.close instead of retrying the call (dshea) +- Add kwargs to eintr_retry_call (dshea) +- Specify required version of GI-imported packages (vpodzime) +- Add classes for LVM cache related functionality (vpodzime) +- Add generic classes for cache and cache stats (vpodzime) +- Merge pull request #149 from vpodzime/master-lvm_cache (vpodzime) +- Implement the support for resizing internal metadata LVs of thin pools + (vpodzime) +- Use relations between LVs to determine parent LV (vpodzime) +- Make Blivet.lvs return all LVs not just traditional/thick LVs (vpodzime) +- Accept both list and ParentList when checking LVs parents (vpodzime) +- Create and use internal LVs instead of static values (vpodzime) +- Add classes for the internal LVs of various types (vpodzime) +- Merge pull request #137 from dwlehman/md-boot-metadata-branch (dlehman) +- Treat existing md arrays whose members are all disks like disks. (dlehman) +- Handle formatting after adding devices from format handlers. (dlehman) +- Merge pull request #158 from mulkieran/master-target-size (mulkieran) +- Move parents checking and update into a seprarate methods (vpodzime) +- Rearrange and group some of the StorageDevice's methods/properties (vpodzime) +- Don't crash when processing cached LVs (vpodzime) +- Make roundToNearest() slightly more robust. (amulhern) +- Extend Size.convertTo() to work with arbitrary Size() values. (amulhern) +- Changes to FS._setTargetSize(). (amulhern) +- Increase ext4 maximum size from 16 TiB to 1 EiB (#1231049) (bcl) +- Merge pull request #155 from atodorov/fix_issue_154 (mulkieran) +- Use len of set to check for duplicates in list of packages. (atodorov) +- Merge pull request #153 from mulkieran/master-task-names (mulkieran) +- Omit completely pointless setUp method. (amulhern) +- Make a size refer to a Size object. (amulhern) +- Add __str__ method to various subclasses of Task. (amulhern) +- Don't pass unused mountpoint dict to preCommitFixup. (dlehman) +- Use the default md metadata version for everything except /boot/efi. + (dlehman) + +* Wed Jun 10 2015 Brian C. Lane - 1.6-1 +- Fix indentation in action_test.py (dlehman) +- Merge pull request #133 from atodorov/fix_deprecation_warnings (mulkieran) +- Merge pull request #147 from vojtechtrefny/master_fix_undo_resize (vtrefny) +- Fix setting original size for format resize action. (#1225352) (vtrefny) +- Make unit test assertion expressions fully Python2/3 compatible. (atodorov) +- Merge pull request #151 from mulkieran/master-120 (mulkieran) +- Merge pull request #122 from atodorov/remove_doctest (mulkieran) +- Parameterize Makefile test targets on Python version. (atodorov) +- Merge pull request #148 from mulkieran/master-132 (mulkieran) +- Merge pull request #144 from mulkieran/master-128 (mulkieran) +- Remove facilities for running tests as standalone modules. (atodorov) +- Include automatic and manual test documentation. (atodorov) +- Remove an accidental variable assignment in LVMLogicalVolumeDevice (vpodzime) +- Merge pull request #143 from mulkieran/master-134 (mulkieran) +- Remove two files in tests directory. (atodorov) +- Fix typo in docstring. (atodorov) +- Merge pull request #112 from vpodzime/master-fixed_maps (vpodzime) +- Merge pull request #129 from mulkieran/master-keepers-c (mulkieran) +- Merge pull request #135 from mulkieran/master-test-fixes (mulkieran) +- Convert bytes value to str. (amulhern) +- Change new format lookup name from "msdos" to "disklabel". (amulhern) +- Get rid of pointless test case about arguments for labeling apps. (amulhern) +- Do not raise KeyError if ID_PART_ENTRY_DISK is missing. (amulhern) +- Manage backing store more independently in loop backed test cases. (amulhern) +- Pass floats as string to Decimal constructor everywhere. (amulhern) +- Fix a bug in reading a size specification with a radix in the numeric part. + (amulhern) +- remove mention of doctest b/c target was removed in + fed53d969af0eddaeeca58cdf3e40916497aa305 (atodorov) +- Beware of Python 3's version of the map() built-in function (vpodzime) + +* Thu May 28 2015 Brian C. Lane - 1.5-1 +- Get rid of an unused import in blivet.zfcp (sbueno+anaconda) +- Make appropriate changes to adapt for s390 libblockdev plugin. + (sbueno+anaconda) +- Drop check from the release build target (bcl) +- Merge pull request #127 from vpodzime/master-libblockdev_1.0 (vpodzime) +- Adapt to the new libblockdev initialization API (vpodzime) +- Merge pull request #111 from dwlehman/disk-model-branch (dlehman) +- Store vendor/model information for DiskDevice instances. (dlehman) +- Require new version of pyparted with Python 3 related fixes (vpodzime) +- Merge pull request #114 from vojtechtrefny/fix_lvmsnapshot_size2 (vtrefny) +- Merge pull request #118 from mulkieran/master-hawkey (mulkieran) +- Use python-hawkey instead of rpm-python. (amulhern) +- Add a dead simple test for some basic task and resource functionality. + (amulhern) +- Use COW device to get actual size of LVM snapshots (vtrefny) + +* Mon May 18 2015 Brian C. Lane - 1.4-1 +- Workaround for chrooted mountpoints (#1217578) (vtrefny) +- Merge pull request #116 from mulkieran/master-gerror (mulkieran) +- Filter GLib.GError instead of GLib.Error in pylint false positives. + (amulhern) +- Merge pull request #113 from mulkieran/master-tasks-20150513 (mulkieran) +- Guard tests against device support being missing. (amulhern) +- Add checks for filesystem availability in selinux tests. (amulhern) +- Fix some small mistakes in tests using availability information. (amulhern) +- Get rid of abitrary _resizable variable in tests. (amulhern) +- Don't use utilsAvailable to skip tests. (amulhern) +- Treat a missing plugin as an OK situation. (amulhern) +- Use availability information in device actions. (amulhern) +- Add a check to determine whether the device type is supported. (amulhern) +- If external dependencies are unavailable, cannot support RAID levels. + (amulhern) +- Add availability information to devicelibs files. (amulhern) +- Track external dependencies in devices. (amulhern) +- If lvm is not available, do not do the filtering. (amulhern) +- Add availability checking to non-FS formats. (amulhern) +- Use filesystem tasks in filesystem. (amulhern) +- Add filesystem tasks to tasks directory. (amulhern) +- Add tasks infrastructure to tasks directory. (amulhern) +- Add error to detect errors in discovering availability info. (amulhern) +- Add errors about reading and writing labels to error heirarchy. (amulhern) +- Make assignments that override abstract properties into simple attributes. + (amulhern) +- Move kernel_filesystems functionality into a little library. (amulhern) +- Make labeling(), relabels(), and labelFormatOK() instance methods. (amulhern) +- Merge pull request #108 from vojtechtrefny/progress_callbacks (vtrefny) +- Merge pull request #109 from mulkieran/master-btrfs-c (mulkieran) +- Set a subvolspec format args when making a new BTRFS volume. (amulhern) +- Cache data obtained from /proc/self/mountinfo. (amulhern) +- Add progress report callback for action processing (vtrefny) +- Do not have two ignored variables when one will do. (amulhern) +- Fix a typo in comment. (amulhern) +- Do not use type() in makebumpver. (clumens) +- Merge pull request #100 from mulkieran/master-lvm-a (mulkieran) +- Merge pull request #104 from mulkieran/master-1139222 (mulkieran) +- Include LUKSDevice information in kickstart data (#1139222) (amulhern) +- Un-escape '-'s in names or paths for _all_ lvm lv or vgs. (amulhern) +- Fix a few miscellaneous pylint-caught problems. (clumens) +- Only give Size objects a __div__ method under python2. (clumens) +- Protect against calling testMount on an object that may not have it. + (clumens) +- Add a bunch of false positives to make pylint succeed. (clumens) +- e.message -> str(e) (clumens) +- Disable a pointless override warning. (clumens) +- Ignore the environment-modify pylint warnings for size_test.py. (clumens) +- blockdevError -> BlockDevError (clumens) +- Remove uses of the string module we don't need, ignore warnings on those we + do. (clumens) +- unicode isn't undefined on the python2 code paths. (clumens) +- Use eintr_retry_call from anaconda. (clumens) +- Move blivet to using pocketlint. (clumens) +- Merge pull request #97 from mulkieran/master-1072060 (mulkieran) +- Merge pull request #93 from vojtechtrefny/fix_active_parted (vtrefny) +- If the parent volume has a label, use it in subvol's kickstart (#1072060) + (amulhern) +- Merge pull request #94 from mulkieran/master-raid (mulkieran) +- Allow adding new partitions to disks with active devices (#1212841) (vtrefny) +- Fix "anaconda hangs while trying to discover iscsi..." (#1166652) (jkonecny) +- Move definition of _level attribute above super-constructor call. (amulhern) +- Fix status for LVMPhysicalVolume format (vtrefny) + +* Wed Apr 22 2015 Brian C. Lane - 1.3-1 +- fix conf.py pylint errors (bcl) +- Fix BlockDev import in populator.py (bcl) +- Prevent pylint from going crazy because of libblockdev's ErrorProxy + (vpodzime) +- Make use of the new libblockdev error reporting (vpodzime) +- Add libselinux-python to package dependencies (#1211834) (vtrefny) +- Introduce a new doReqPartition method that is similar to doAutoPartition. + (clumens) +- Merge pull request #81 from mulkieran/master-mount-options (mulkieran) +- Merge pull request #66 from vpodzime/master-py3_final (martin.kolman) +- Encode input for os.write() (mkolman) +- Build the python3-blivet subpackage (vpodzime) +- Do not modify dict while iterating over its values (vpodzime) +- Do not try to compare strings and Nones when sorting mountpoints (vpodzime) +- Always return strings from regular capture output run functions (mkolman) +- Do not use variable from an inner comprehension in tests (vpodzime) +- Implement and test Python 3 division for the Size class (vpodzime) +- Replace python 2 build-in-function cmp() with custom method (vtrefny) +- Do not rely on __sub__ being implemented as __add__ (-1)* (vpodzime) +- Transform our compare functions into key functions and use these instead + (vpodzime) +- Fix the size_test to stop using byte strings (vpodzime) +- Do not define unit strings as byte strings (vpodzime) +- Do not pass context to Decimal numeric operations (vpodzime) +- Don't call object's (as a class) __new__ with extra arguments (vpodzime) +- Make translation to lowerASCII Python[23]-compatible (vpodzime) +- Replace __import__ call with importlib.import_module (vpodzime) +- In FS._postSetup() check the mountpoint options that were actually used. + (amulhern) +- Add kwargs to unmount and move mountpoint check into _preSetup (bcl) +- Do not try importing hidden/backup files as formats (vpodzime) +- Add back DeviceTree's support for saving LUKS passphrases (vpodzime) +- Do not try to stat FileDevice's path if it doesn't exist (vpodzime) +- Merge pull request #76 from dwlehman/unusable-storage-branch (dlehman) +- Add error handling around storageInitialize for unusable setups. (dlehman) +- Include suggestions in error classes for unusable storage configurations. + (dlehman) +- Use partially corrupt gpt disklabels. (dlehman) +- Consolidate common code in DeviceFormat class methods. (dlehman) +- Update get_mount_paths to use mountsCache (bcl) +- Add multiple mountpoint handling to MountsCache (bcl) +- Remove obsolete FIXME from FS.status (bcl) +- Check to see if mountpoint is already mounted (bcl) +- Add isMountpoint to MountsCache (bcl) +- Add ability to unmount specific mountpoints (bcl) +- Fix pylint errors for six.moves import (vtrefny) +- Merge pull request #72 from vojtechtrefny/picklable-size (vpodzime) +- Merge pull request #74 from mulkieran/master-trivia (mulkieran) +- Fix two instances where check_equal() returned True incorrectly. (amulhern) +- Fix typo in 66f2ddb11e85ec6f48535d670dd6f24cb60cbe55. (amulhern) +- Make sure installer_mode is reset to original value. (amulhern) +- Test for Size pickling support (vtrefny) +- Pickling support for Size. (vtrefny) +- Disable pylint bad-super-call in MDRaidArrayDevice.updateSize. (dlehman) +- Merge pull request #68 from dwlehman/parted-device-branch (dlehman) +- Require reallocation after changing an allocated partition's size. (dlehman) +- Move mediaPresent out of Device and into StorageDevice. (dlehman) +- Don't use parted.Device to obtain size info. (dlehman) +- Merge pull request #70 from mulkieran/master-1208536 (mulkieran) +- Prepend /sys to sysfs path for udev lookup (#1208536) (amulhern) +- Fall back on mdadm info if udev info is missing for the array (#1208536) + (amulhern) +- Catch DeviceError as well as ValueError (#1208536) (amulhern) +- Make an MDContainerDevice if that is the right model (#1208536) (amulhern) +- Change raid variable name to raid_items (#1208536) (amulhern) +- Fix swapped args to processActions. (dlehman) +- Merge pull request #63 from dwlehman/disk-selection-branch (dlehman) +- Use VGname-LVname as key for LVinfo cache (vpodzime) +- Add back DeviceTree's methods and properties used from the outside (vpodzime) +- Wrap keys() with a list so that the dictionary can be changed (martin.kolman) +- Add a method to list disks related by lvm/md/btrfs container membership. + (dlehman) +- Make getDependentDevices work with hidden devices. (dlehman) + +* Fri Mar 27 2015 Brian C. Lane - 1.2-1 +- Fix pylint unused variable warnings (vtrefny) +- Add test for mountpoints (vtrefny) +- Replace _mountpoint with systemMountpoint in other modules (vtrefny) +- New method to handle nodev filesystems (vtrefny) +- Add dynamic mountpoint detection support (vtrefny) +- New method to compute md5 hash of file (vtrefny) +- Add information about subvolume to BTRFS format (vtrefny) +- Don't specify priority in fstab if -1 (default) is used (#1203709) (vpodzime) +- Catch GLib.GError in places where we catch StorageError (#1202505) (vpodzime) +- slave_dev is undefined here, use slave_devices[0] instead. (clumens) +- Clean out the mock chroot before attempting to run the rest of the test. + (clumens) +- Move recursiveRemove from Blivet to DeviceTree. (dlehman) +- Factor out adding of sysfs slave (parent) devices into its own method. + (dlehman) +- Add a __str__ method to DeviceTree. (dlehman) +- Allow changing the names of existing devices. (dlehman) +- Remove redundant block for adding fwraid member disks. (dlehman) +- Return a device from addUdevLVDevice if possible. (dlehman) +- Pass a sysfs path to MultipathDevice constructor from Populator. (dlehman) +- Resolve md names in udev info. (dlehman) +- LVMVolumeGroupDevice format should be marked as immutable. (dlehman) +- Don't catch and re-raise device create exceptions as DeviceCreateError. + (dlehman) +- Call superclass _preCreate from BTRFSVolumeDevice._preCreate. (dlehman) +- Move code that populates the device tree into a new class and module. + (dlehman) +- Move action list management into a separate class and module. (dlehman) +- Put an __init__.py in devices_tests directory. (amulhern) +- Require the Python 2 version of pykickstart (#1202255) (vpodzime) +- Use Size method to perform a Size operation (#1200812) (amulhern) +- Extend Size.roundToNearest to allow Size units (#1200812) (amulhern) +- Move code that populates the device tree into a new class and module. + (dlehman) +- Move action list management into a separate class and module. (dlehman) +- Remove a pointless override. (amulhern) +- Display the name of the overridden ancestor in error message. (amulhern) +- Check for simple function calls in pointless overrides. (amulhern) +- Simplify supported methods in FS.py. (amulhern) +- Make hidden property use superclass method where possible. (amulhern) +- Simplify some methods in DeviceFormat class. (amulhern) +- Do supercall in BTRFSVolumeDevice.formatImmutable. (amulhern) +- Add a comment to supported property. (amulhern) +- Get rid of some very old commented out code. (amulhern) +- Put all mock results into the top-level source dir. (clumens) +- Spell TestCase.teardown correctly as tearDown(). (amulhern) +- Make testMount() check return value of util.mount(). (amulhern) +- Remove unused fs_configs. (amulhern) +- Remove side-effects from mountType property. (amulhern) +- Do not make the mountpoint directory in fs.FS.mount(). (amulhern) +- Mount should not be satisfied with anything less than a directory. (amulhern) +- Do not return doFormat() value. (amulhern) +- Put previously removed mountExistingSystem() into osinstall.py. (amulhern) +- Revert "Revive the mountExistingSystem() function and all it needs" + (amulhern) +- Make sure the device is setup before formatting it (#1196397) (bcl) +- Use %%d format string for every value that should be an integer decimal. + (amulhern) +- Robustify PartitionDevice._wipe() method. (amulhern) +- Fix up scientific notation _parseSpec() tests. (amulhern) +- Make size._parseSpec a public method. (amulhern) +- Simplify StorageDevice.disks. (amulhern) +- Simplify StorageDevice.growable. (amulhern) +- Simplify and correct StorageDevice.packages property. (amulhern) +- Remove services infrastructure from devices and formats. (amulhern) +- Split devices tests out into a separate directory. (amulhern) +- Fix dd wipe call. (exclusion) +- Add a script to rebase and merge pull requests (dshea) +- Add pylint false positive to list of pylint false positives. (amulhern) +- Change all instances of GLib.Error to GLib.GError. (amulhern) +- Sort pylint-false-positives using sort's default options with LC_ALL=C. + (amulhern) +- Add ability to match scientific notation in strings. (amulhern) + +* Fri Mar 06 2015 Brian C. Lane - 1.1-1 +- Add scratch, scratch-bumpver and rc-release targets. (bcl) +- Add --newrelease to makebumpver (bcl) +- Add po-empty make target (bcl) +- Revive the mountExistingSystem() function and all it needs (vpodzime) +- Switch translations to use Zanata (bcl) +- Set EFIFS._check to True so that it gets correct fspassno (#1077917) + (amulhern) +- Use format string and arguments for logging function (vpodzime) +- Merge pull request #28 from vpodzime/master-libblockdev (vratislav.podzimek) +- Do not restrict MDRaidArrayDevice's memberDevices to type int (vpodzime) +- Adapt better to libblockdev's md_examine data (vpodzime) +- Set TmpFS._resizable to False. (amulhern) +- Add an additional test for TmpFS. (amulhern) +- Override NoDevFS.notifyKernel() so that it does nothing. (amulhern) +- Add TmpFS._resizefsUnit and use appropriately. (amulhern) +- Rewrite TmpFS class definition. (amulhern) +- Add TmpFS._getExistingSize() method. (amulhern) +- Make _getExistingSize() method more generally useful. (amulhern) +- Remove _getExistingSize() methods with body pass. (amulhern) +- Tidy up the definition of the device property throughout formats package. + (amulhern) +- Add a test to check properties of device paths assigned to formats. + (amulhern) +- Set TmpFSDevice object's _formatImmutable attribute to True. (amulhern) +- Remove no longer needed requires (vpodzime) +- Filter out pylint's "No name 'GLib' in module 'gi.repository'" messages + (vpodzime) +- Add a static method providing list of available PE sizes (vpodzime) +- Use BlockDev's crypto plugin to do LUKS escrow (vpodzime) +- Use BlockDev's DM plugin to work with DM RAID sets (vpodzime) +- Use BlockDev's DM plugin for DM map existence testing (vpodzime) +- Remove tests for the removed devicelibs functions (vpodzime) +- Set and refresh BlockDev's global LVM config if needed (vpodzime) +- Use BlockDev's LVM plugin instead of devicelibs/lvm.py (vpodzime) +- Use BlockDev's BTRFS plugin instead of devicelibs/btrfs.py (vpodzime) +- Use the BlockDev's DM plugin instead of devicelibs/dm.py (vpodzime) +- Use BlockDev's crypto plugin instead of devicelibs/crypto.py (vpodzime) +- Use BlockDev's loop plugin instead of devicelibs/loop.py (vpodzime) +- Use BlockDev's MD plugin instead of devicelibs/mdraid.py (vpodzime) +- Use BlockDev's swap plugin instead of devicelibs/swap.py (vpodzime) +- Use BlockDev's mpath plugin instead of devicelibs/mpath.py (vpodzime) +- First little step towards libblockdev (vpodzime) +- Move the Blivet class into its own module (vpodzime) +- Use a safer method to get a dm partition's disk name. (dlehman) +- Be more careful about overwriting device.originalFormat. (#1192004) (dlehman) + +* Fri Feb 13 2015 David Lehman - 1.0-1 +- Move autopart and installation-specific code outside of __init__.py + (vpodzime) +- Convert _parseUnits to public function (vtrefny) +- LVMFactory: raise exception when adding LV to full fixed size VG (#1170660) + (vtrefny) +- Do not unhide devices with hidden parents (#1158643) (vtrefny) + +* Fri Feb 06 2015 Brian C. Lane - 0.76-1 +- Revert "Switch to temporary transifex project" (bcl) +- Check parent/container type for thin volumes and normal volumes. (dlehman) +- drop useless entries from formatByDefault exceptlist (awilliam) +- Fix import of devicelibs.raid in platform.py (vpodzime) +- Use %%license in python-blivet.spec (bcl) +- Fix import of FALLBACK_DEFAULT_PART_SIZE (vpodzime) +- Make implicit partitions smaller if real requests don't fit anywhere + (vpodzime) +- Use list comprehension instead of filter+lambda in makebumpver (amulhern) +- Revert "Try to deactivate lvm on corrupted gpt disks." (dlehman) +- Virtualize options property methods in DeviceFormat.options definition. + (amulhern) +- Do not redefine size property in TmpFS. (amulhern) +- Do not set self.exists to True in TmpFS.__init__(). (amulhern) +- Simplify NoDevFS.type. (amulhern) +- Set format's mountpoint if it has the mountpoint attribute. (amulhern) +- Do not bother to set device.format.mountopts. (amulhern) +- Tighten up FS.mountable(). (amulhern) +- Simplify FS._getOptions(). (amulhern) +- Simplify setting options variable. (amulhern) +- Be less eager about processing all lines in /proc/meminfo. (amulhern) +- Make error message more useful. (amulhern) +- Add a tiny test for TmpFS. (amulhern) +- More fixes for alignment-related partition allocation failures. (dlehman) +- Do not mix stdout and stderr when running utilities unless requested + (vpodzime) +- Define the _device, _label and _options attributes in constructor (vpodzime) +- Get rid of the has_lvm function (vpodzime) +- Do not create lambda over and over in a cycle (vpodzime) +- Disable pylint check for cached LVM data in more places (vpodzime) +- Fix issue where too many mpath luns crashes installer (#1181336) (rmarshall) +- Allow user-specified values for data alignment of new lvm pvs. (#1178705) + (dlehman) +- Let LVM determine alignment for PV data areas. (#962961) (dlehman) +- Raise UnusableConfigurationError when unusable configuration is detected. + (dlehman) +- Don't raise an exception for failure to scan an ignored disk. (dlehman) +- Try to deactivate lvm on corrupted gpt disks. (dlehman) +- Remove an unused and outdated constant (vpodzime) +- Relax the blivet device name requirements (#1183061) (dshea) + +* Fri Jan 16 2015 Brian C. Lane - 0.75-1 +- Switch to temporary transifex project (bcl) +- Add docstrings to the methods in loop.py (bcl) +- get_loop_name should return an empty name if it isn't found (#980510) (bcl) +- Use dict() instead of dict comprehension. (riehecky) +- Fix the pylint errors in the examples directory. (amulhern) +- Add __init__ file to examples directory. (amulhern) + +* Fri Jan 09 2015 Brian C. Lane - 0.74-1 +- Use _resizefsUnit in resizeArgs() method implementations. (amulhern) +- Do not supply a default implementation for the resizeArgs() method. + (amulhern) +- Use convertTo in humanReadable(). (amulhern) +- Change convertTo() and roundToNearest() so each takes a units specifier. + (amulhern) +- Do not even pretend that ReiserFS is resizable. (amulhern) +- Get whole unit tuple in loop when searching for correct units. (amulhern) +- Make _parseUnits() return a unit constant, rather than a number. (amulhern) +- Add unitStr() method. (amulhern) +- Make _Prefix entries named constants. (amulhern) +- Hoist _BINARY_FACTOR * min_value calculation out of loop. (amulhern) +- Comment _prefixTestHelper() and eliminate some redundancies. (amulhern) +- Eliminate redundant test. (amulhern) +- Avoid using Size constant in FileDevice._create(). (amulhern) +- Do not compare the same two values twice. (amulhern) +- Make possiblePhysicalExtents() a bit more direct. (amulhern) +- Get rid of unnecessary use of long. (amulhern) +- Use _netdev mount option as needed. (#1166509) (dlehman) +- Don't crash when a free region is too small for an aligned partition. + (dlehman) +- Multiple loops shouldn't be fatal (#980510) (bcl) +- If allowing degraded array, attempt to start it (#1090009) (amulhern) +- Add a method that looks at DEVNAME (#1090009) (amulhern) +- Add mdrun method to just start, not assemble, an array. (#1090009) (amulhern) +- Change allow_degraded_mdraid flag to allow_imperfect_devices (#1090009) + (amulhern) +- Remove needsFSCheck() and what only it depends on. (amulhern) +- Remove allowDirty parameter and code that depends on it. (amulhern) +- Eliminate dirtyCB parameter from mountExistingSystem() params. (amulhern) +- Use correct package for FSError. (amulhern) + +* Fri Dec 19 2014 Brian C. Lane - 0.73-1 +- Mountpoint detection for removable devices (vtrefny) +- Fix adding partition after ActionDestroyDevice canceling (vtrefny) +- Avoid exception when aligned start and end are crossed over (exclusion) +- Substitute simple value for single element array. (amulhern) +- Change _matchNames so that it is less restrictive (amulhern) +- Change MDRaidArrayDevice to MDBiosRaidArrayDevice. (amulhern) +- Factor out MDRaidArrayDevice w/ type in ("mdcontainer", "mdbiosraidarray") + (amulhern) +- Make it possible for NTFS to recognize the label it reads. (amulhern) +- Make unnecessarily verbose properties into simple class attributes. + (amulhern) +- Change the generic badly formatted label to one that's bad for all. + (amulhern) +- Don't make overridden values actual properties. (amulhern) +- Check the status of the format being mounted. (amulhern) + +* Thu Dec 04 2014 Brian C. Lane - 0.72-1 +- Add a bunch of simple tests for filesystem formats. (amulhern) +- Get rid of long() related code. (amulhern) +- Add another check for resizable in FS.doResize() (amulhern) +- Simplify FS.free(). (amulhern) +- Make an early exit if self._existingSizeFields is [] (amulhern) +- Change "Aggregate block size:" to "Physical block size:" for JFS. (amulhern) +- Split output from infofs program for size on whitespace. (amulhern) +- Simplify _getSize() and currentSize(). (amulhern) +- Check resizable when assigning a new target size. (amulhern) +- Make default exists value a boolean in DeviceFormat.__init__. (amulhern) +- Remove pointless overrides. (amulhern) +- Add a simple pylint checker for pointless overrides. (amulhern) +- Run dosfsck in non-interactive mode (#1167959) (bcl) + +* Fri Nov 21 2014 Brian C. Lane - 0.71-1 +- Remove redundant import. (amulhern) +- Change inclusion to equality. (amulhern) +- Round filesystem target size to whole resize tool units. (#1163410) (dlehman) +- New method to round a Size to a whole number of a specified unit. (dlehman) +- Fix units for fs min size padding. (dlehman) +- Disable resize operations on filesystems whose current size is unknown. + (dlehman) +- Run fsck before obtaining minimum filesystem size. (#1162215) (dlehman) +- Fix setupDiskImages when the devices are already in the tree. (dlehman) +- Make logging a little less verbose and more useful in FS.mount() (amulhern) +- Make selinux test less precise. (amulhern) +- Do not translate empty strings, gettext translates them into system + information (vtrefny) +- Add a tearDown method to StorageTestCase. (dlehman) +- Remove pointless assignment to _formattable in Iso9660FS. (amulhern) +- Remove BTRFS._resizeArgs() (amulhern) +- Add more arguments to mpathconf (#1154347) (dshea) +- Check the minimum member size for BtrfsVolumeDevices. (amulhern) +- Get rid of FS._getRandomUUID() method. (amulhern) +- Eliminate TmpFS.minSize() (amulhern) +- Don't run selinux context tests when selinux is disabled. (dlehman) +- Temporarily disable a test that isn't working. (dlehman) +- Pass a path (not a name) to devicePathToName. (dlehman) +- devicePathToName should default to returning a basename. (dlehman) +- Fix test that guards forcible removal of dm partition nodes. (dlehman) +- Device status can never be True for non-existent devices. (#1156058) + (dlehman) +- Use super to get much-needed MRO magic in constructor. (#1158968) (dlehman) + +* Thu Nov 06 2014 Brian C. Lane - 0.70-1 +- Add a method that determines whether a number is an exact power of 2. + (amulhern) +- Put size values in Size universe eagerly. (amulhern) +- Update minSize method headers. (amulhern) +- Remove _minSize assignment to 0 where it's inherited from superclass. + (amulhern) +- Make _minInstanceSize, a source of minSize() value, always a Size. (amulhern) +- Fix int * Size operation and add tests (#1158792) (bcl) +- getArch should return ppc64 or ppc64le (#1159271) (bcl) +- Pack data for the wait_for_entropy callback (vpodzime) +- Allow the wait_for_entropy callback enforce continue (vpodzime) + +* Tue Nov 04 2014 Brian C. Lane - 0.69-1 +- Increase max depth of sphinx toc to show subpackage names. (dlehman) +- Temporarily disable the md devicetree tests due to mdadm issues. (dlehman) +- Add ability to set a default fstype for the boot partition (#1112697) (bcl) +- Pass a list of string items to log_method_return. (sbueno+anaconda) +- Require resize target sizes to yield aligned partitions. (#1120964) (dlehman) +- Split out code to determine max unaligned partition size to a property. + (dlehman) +- Allow generating aligned geometry for arbitrary target size. (dlehman) +- Align end sector in the appropriate direction for resize. (#1120964) + (dlehman) +- Specify ntfs resize target in bytes. (#1120964) (dlehman) +- Check new target size against min size and max size. (dlehman) +- Add a number of new tests. (amulhern) +- Add xlate parameter to humanReadable(). (amulhern) +- Rewrite _parseSpec() and convertTo() (amulhern) +- Make _lowerASCII() python 3 compatible and add a method header. (amulhern) +- Use b"", not u"", for _EMPTY_PREFIX. (amulhern) +- Strip lvm WARNING: lines from output (#1157864) (bcl) +- Add testing for MDRaidArrayDevice.mdadmFormatUUID (#1155151) (amulhern) +- Give mdadm format uuids to the outside world (#1155151) (amulhern) +- Make logSize, metaDataSize, and chunkSize always consistently Size objects. + (amulhern) + +* Wed Oct 22 2014 Brian C. Lane - 0.68-1 +- Only write label if there is a label AND labeling application. (amulhern) +- Handle unicode strings in Size spec parsing. (dshea) +- Fix typo in getting Thin Pool profile's name (vpodzime) +- Don't try to get no profile's name (#1151458) (vpodzime) +- Change signature of DiskLabel.addPartition to be more useful. (dlehman) +- Remove unused fallback code from DiskLabel. (dlehman) +- Let udev settle between writing partition flags and formatting. (#1109244) + (dlehman) +- Set _partedDevice attribute before calling device constructor (#1150147) + (amulhern) +- Fixed wrong Runtime Error raise in _preProcessActions (vtrefny) +- Set sysfsPath attribute before calling Device constructor (#1150147) + (amulhern) +- Return all translated strings as unicode (#1144314) (dshea) +- Force __str__ to return str. (dshea) +- Use the i18n module instead of creating new gettext methods (dshea) +- Take care when checking relationship of parent and child UUIDs (#1151649) + (amulhern) +- Further abstract loopbackedtestcase on block_size. (amulhern) +- Update tests to bring into line w/ previous commit (#1150147) (amulhern) +- Abstract ContainerDevice member format check into a method (#1150147) + (amulhern) +- Register DeviceFormat class (#1150147) (amulhern) +- Don't append btrfs mount options to None (#1150872) (dshea) +- Convert int to str before passing it to run_program (#1151129) (amulhern) + +* Thu Oct 09 2014 Brian C. Lane - 0.67-1 +- Don't pass --disable-overwrite to tx pull. (dlehman) +- Avoid unneccesarily tripping raid-level member count checks. (dlehman) +- Allow toggling encryption of raid container members. (#1148373) (dlehman) +- Include the new blivet.devices submodule in the built package. (clumens) +- Add a few test for setting dataLevel and metaDataLevel in BTRFS (amulhern) +- Add dataLevel and metaDataLevel attributes for testing. (amulhern) +- Add isleaf and direct to _state_functions (amulhern) +- Refactor setup of _state_functions into __init__() methods (amulhern) +- Move getting the attribute into the check methods. (amulhern) +- Adjust detection of exceptions raised. (amulhern) +- Update test setup so that it obeys RAID level requirements. (amulhern) +- Use new RaidDevice class in appropriate Device subclasses. (amulhern) +- Add new RaidDevice class for handling RAID aspects of devices. (amulhern) +- Do not set parents attribute if parents param is bad. (amulhern) + +* Wed Oct 08 2014 Brian C. Lane - 0.66-1 +- Organize installer block device name blacklist. (#1148923) (dlehman) +- Add likely to be raised exceptions to catch block (#1150174) (amulhern) +- Canonicalize MD_UUID* values in udev.py (#1147087) (amulhern) +- Split up devices.py. (dlehman) +- Fix some pylint errors introduced in recent commits. (dlehman) +- Return early when setting new size for non-existent partition. (dlehman) +- Raise an exception when we find orphan partitions. (dlehman) +- Fall back to parted to detect dasd disklabels. (dlehman) +- Omit pylint false positive (amulhern) +- Revert "pylint hack" (amulhern) +- Remove unused import (amulhern) +- Remove unused import (amulhern) +- pylint hack (amulhern) +- Make sure autopart requests fit in somewhere (#978266) (vpodzime) +- Work with free region sizes instead of parted.Geometry objects (vpodzime) +- Check that we have big enough free space for the partition request (vpodzime) +- Allow specifying thin pool profiles (vpodzime) +- Allow specifying minimum entropy when creating LUKS (vpodzime) +- Allow user code provide callbacks for various actions/events (vpodzime) +- Change default min_value from 10 to 1 in humanReadable() (amulhern) +- Rewrite of Size.humanReadable() method (amulhern) +- Factor out commonalities in xlated_*_prefix() methods. (amulhern) +- Use named constants for binary and decimal factors. (amulhern) +- Use UPPER_CASE for constants (amulhern) + +* Tue Sep 30 2014 Brian C. Lane - 0.65-1 +- Remove a problematic remnant of singlePV. (dlehman) +- Remove all traces of singlePV. (sbueno+anaconda) +- Change the default /boot part on s390x to not be lvm. (sbueno+anaconda) +- Remove redundant check for parents in Blivet.newBTRFS. (dlehman) +- Use Decimal for math in Size.convertTo. (dlehman) +- Filter out free regions too small for alignment of partitions. (dlehman) +- Disable LVM autobackup when doing image installs (#1066004) (wwoods) +- Add attribute 'flags.lvm_metadata_backup' (wwoods) +- lvm_test: refactoring + minor fix (wwoods) +- devicelibs.lvm: refactor _getConfigArgs()/lvm() (wwoods) +- devicelibs.lvm: fix pvmove(src, dest=DESTPATH) (wwoods) +- Only pad for md metadata if pvs use multiple disks. (dlehman) +- Align free regions used for partition growing calculations. (dlehman) +- Try to align end sector up when aligning new partitions. (dlehman) +- Remove obsolete conversion of size to float. (dlehman) +- Honor size specified for explicit extended partition requests. (dlehman) +- Honor zerombr regardless of clearpart setting. (dlehman) +- Fix treatment of percent as lvm lv size spec. (dlehman) +- Change variable keyword (#1075671) (amulhern) +- Remove unused import (#1075671) (amulhern) +- Don't mix target and discovery credentials (#1037564) (mkolman) +- Make sure /boot/efi is metadata 1.0 if it's on mdraid. (pjones) +- iscsi: fix root argument being overriden by local variable (#1144463) + (rvykydal) +- iscsi: add iscsi singleton back (#1144463) (rvykydal) + +* Fri Sep 19 2014 Brian C. Lane - 0.64-1 +- Fix pylint errors from recent btrfs commits. (dlehman) +- Only cancel actions on disks related to the one we are hiding. (dlehman) +- Cancel actions before hiding descendent devices. (dlehman) +- Improve handling of device removals/additions from the devicetree. (dlehman) +- The first format destroy action should obsolete any others. (dlehman) +- Do not allow modification or removal of protected devices. (dlehman) +- Propagate mount options for btrfs members to all volumes/subvolumes. + (dlehman) +- Properly identify dm devices even when udev info is incomplete. (dlehman) +- Do not mount btrfs to list subvolumes outside installer_mode. (dlehman) +- Reset default subvolume prior to removing the default subvolume. (dlehman) +- Increase max size for btrfs to 16 EiB. (#1114435) (dlehman) +- Improve adjustment for removal of a subvol in BTRFSFactory. (dlehman) +- Set dummy mountpoint in ksdata for lvm thin pools. (dlehman) +- Add an epoch to blivet. (sbueno+anaconda) +- Check if device has enough members when setting RAID level (#1019685) + (amulhern) +- Add BTRFSValueError error and use in btrfs related code (#1019685) (amulhern) +- iscsi: mount partitions in initramfs for root on iscsi (#740106) (rvykydal) +- Remove poolMetaData (#1021505) (amulhern) +- Revert "Allow use of a single path if multipath activation fails. (#1054806)" + (vpodzime) +- Add a release make target (bcl) +- Prefer ID_SERIAL over ID_SERIAL_SHORT (#1138254) (vpodzime) +- Allow use of a single path if multipath activation fails. (#1054806) + (dlehman) + +* Wed Sep 10 2014 Brian C. Lane - 0.63-1 +- Update makebumpver to include flags on first request (bcl) +- Condense and comment some devicelibs.dasd methods (#1070115) (amulhern) +- Add a test file for DASD handling (#1070115) (amulhern) +- Pylint inspired cleanup (#1070115) (amulhern) +- Add a property for read-only devices. (dshea) +- Get rid of misleading comment (#1066721) (amulhern) +- Allow user code creating free space snapshot (vpodzime) +- Add two functions to enable manual addition of ECKD DASDs. (sbueno+anaconda) +- Make prefering leaves the default in getDeviceByPath (#1122081) (amulhern) +- Make _filterDevices() return a generator consistently (#1122081) (amulhern) +- Split string of symlinks into array of strings (#1136214) (amulhern) +- Don't put "Linux" in a root's name if it's already there. (clumens) + +* Thu Aug 28 2014 Brian C. Lane - 0.62-1 +- Mock pyudev since libudev will not be on the builders. (dlehman) +- Update selinux tests for default context of mounts under /tmp. (dlehman) +- Clean up mocking done by udev tests when finished. (dlehman) +- Remove unused lvm and md activation code. (dlehman) +- Bypass size getter when mocking new devices. (dlehman) +- Simplify udev.device_get_uuid. (dlehman) +- Don't pass md array UUID as member format UUID. (dlehman) +- Update md name when lookup relied on UUID. (dlehman) +- Remove an obsolete block related to unpredictable md device names. (dlehman) +- Get md member and array UUIDs for format ctor from udev. (dlehman) +- Look in udev data for md member UUID. (dlehman) +- Remove some unused multipath-specific functions from blivet.udev. (dlehman) +- Adapt multipath detection code to external pyudev module. (dlehman) +- Keep lvm and md metadata separate from udev info. (dlehman) +- Replace our pyudev with the package python-pyudev. (dlehman) +- Add a bunch of tests for mdadd. (amulhern) +- Make has_redundancy() a method rather than a property and revise mdadd. + (amulhern) +- Omit unnecessary class hierarchy related boilerplate. (amulhern) +- Add a test for activation. (amulhern) +- Add a test for mddetail on containers. (amulhern) +- Still attempt to destroy even if remove failed. (amulhern) +- Use long messages for unittest errors. (amulhern) +- Fix mdnominate error message. (amulhern) +- Cosmetic changes for the swapSuggestion function (vpodzime) +- Break once metadata value is found. (amulhern) +- Fix issues reported by pyflakes (vpodzime) +- Remove tests for the sanityCheck (vpodzime) +- Move _verifyLUKSDevicesHaveKey and its exception to anaconda (vpodzime) +- Remove sanityCheck functions from blivet sources (vpodzime) +- Remove an unused closure function (vpodzime) +- Remove two methods that are never called (vpodzime) +- Add some tests for blivet.partitioning.addPartition. (dlehman) +- Add a couple of tests for blivet.partitioning.DiskChunk. (dlehman) +- Add a DiskFile class for testing partitioning code as a non-root user. + (dlehman) +- Add a contextmanager to create and remove sparse tempfiles. (dlehman) +- Fix sphinx formatting of code blocks in devicefactory docstrings. (dlehman) +- Mock selinux when building docs. (dlehman) +- Include doc files when installing on readthedocs. (dlehman) +- _maxLabelChars is no longer used by anything (bcl) +- tests: Add tests for HFSPlus labels (#821201) (bcl) +- Write a fs label for HFS+ ESP (#821201) (bcl) +- Mock non-standard modules so we can generate API docs on readthedocs. + (dlehman) +- Split mdadd into separate functions. (amulhern) +- Refactor mdraid tests. (amulhern) +- Add a method to extract information about an mdraid array (amulhern) +- Extend mdadm() to capture output (amulhern) +- Be more robust in the face of possible changes to mdadm's UUIDs. (amulhern) +- Factor canonicalize_UUID() into separate method. (amulhern) +- Add a docstring to mdraid.mdexamine (amulhern) +- Remove DeviceFormat.probe() method (amulhern) +- Remove all references to mdMinor in current code base. (amulhern) +- Generalize the error message for the array level (amulhern) +- Use super() instead of explicit parent name (amulhern) +- Remove commented out import. (amulhern) +- Make docstring more precise. (amulhern) +- Minor fix of a docstring. (rvykydal) +- Get rid of partedFlags field. (amulhern) + +* Fri Jul 11 2014 Brian C. Lane - 0.61-1 +- Fix conf.py version bumping (bcl) +- Add some tests for Chunk and Request class hierarchy. (dlehman) +- Honor the skip list when allocating leftover sectors. (dlehman) +- A Chunk is done growing when its pool is empty. (dlehman) +- Don't use integer division to calculate a fraction. (dlehman) +- Bump version in sphinx config from scripts/makebumpver. (dlehman) +- Remove spec= from Size usage in intro.rst. (dlehman) +- Attempt to reset the uuid of the mdraid member device (#1070095) (amulhern) +- Add new method udev.device_get_md_device_uuid() method (#1070095) (amulhern) +- Canonicalize mdadm generated UUIDS (#1070095) (amulhern) +- Add a udev.device_get_md_metadata() method to udev and use it. (amulhern) +- Change use of METADATA to MD_METADATA. (amulhern) +- Check for md_level of None (amulhern) +- Do not convert the result of udev.device_get_md_devices() to int. (amulhern) +- Add documentation to udev.device_get_md_*() methods. (amulhern) +- Document udev.device_get_uuid() method. (amulhern) +- Add a few small tests for mdexamine (amulhern) +- Add test for raid level descriptor None. (amulhern) +- Use context manager with assertRaises*() tests. (amulhern) +- Change uuid parameter to array_uuid (amulhern) +- Remove udev_ prefix from udev methods. (amulhern) +- Remove all references to DeviceFormat.majorminor (amulhern) +- Use add_metaclass instead of with_metaclass. (amulhern) +- Disable redefined-builtin warning. (amulhern) +- Use range instead of xrange in generateBackupPassphrase() (amulhern) +- Add a simple test of generateBackupPassphrase() result format (amulhern) +- Python3 compatibility (rkuska) +- Replace python-setuptools-devel BR with python-setuptools (bcl) + +* Wed Jul 02 2014 Brian C. Lane - 0.60-1 +- Do not use udev info to get the name of the device. (amulhern) +- Remove unnecessary fanciness about importing devices. (amulhern) +- Disable some pylint warnings that arise due to anaconda versions. (amulhern) +- Allow RAID1 on EFI (#788313) (amulhern) + +* Thu Jun 26 2014 Brian C. Lane - 0.59-1 +- When logging, indicate whether exception was ignored by blivet. (amulhern) + +* Wed Jun 25 2014 Brian C. Lane - 0.58-1 +- Only import ROOT_PATH if needed (bcl) +- Add early keyword to setUpBootLoader (#1086811) (bcl) +- Only log a warning about labeling if something is wrong (#1075136) (amulhern) +- When adding an md array, allow adding incomplete arrays (#1090009) (amulhern) +- Add a flag to control whether a degraded md raid array is used (#1090009) + (amulhern) +- Remove preferLeaves parameter from getDeviceByPath() (amulhern) +- Factor out commonalities among getDevice[s|]By* methods. (amulhern) +- Omit special check for md devices in addUdevDevice(). (amulhern) +- Remove unused 'slaves' variable. (amulhern) +- Move down or remove assignment to device in add* methods. (amulhern) +- Move DevicelibsTestCase up to the top level of the testing directory. + (amulhern) +- Accept None for btrfs raid levels (#1109195) (amulhern) +- Add a test for a btrfs error associated with small devices (#1109195) + (amulhern) + +* Thu Jun 19 2014 Brian C. Lane - 0.57-1 +- Make DevicelibsTestCase devices configurable. (amulhern) +- Use correct parameters in __init__() in subclasses of unittest.TestCase. + (amulhern) +- Add num_blocks parameter to makeLoopDev(). (amulhern) +- Move skipUnless decorator to the top level class of skipped classes. + (amulhern) +- Explicitly accept a string as well as a RAIDLevel object. (amulhern) +- Update BTRFS initializer comments for level type. (amulhern) +- Remove some extra imports. (amulhern) +- Add method to set the default disklabel (#1078537) (bcl) +- Do not try to activate dmraid sets if the dmraid usage flag is false + (mkolman) +- Use the value of the Anaconda dmraid flag to set the Blivet dmraid flag + (mkolman) +- Use the value of the Anaconda ibft flag to set the Blivet ibft flag (mkolman) +- Ignore _build directory in doc directory. (amulhern) +- Change intersphinx mapping to avoid linkcheck redirect errors. (amulhern) +- Remove doctest target from Makefile. (amulhern) +- Allow the table of contents to go one level deeper. (amulhern) +- Automate generation of the .rst files which just set up the modules. + (amulhern) + +* Thu Jun 12 2014 Brian C. Lane - 0.56-1 +- Skip device name validation for some device types. (dlehman) +- Add a property indicating whether a device is directly accessible. (dlehman) +- Add support for read-only btrfs snapshots. (dlehman) +- Add tests for snapshots. (dlehman) +- Special treatment for getting parted device for old-style lvm snapshots. + (dlehman) +- Some devices have immutable formatting. (dlehman) +- Detect existing btrfs snapshots. (dlehman) +- Drop special accounting for snapshot space usage in VG. (dlehman) +- Use LVMSnapshotDevice when populating the devicetree. (dlehman) +- Add Device classes for snapshots. (dlehman) +- Add ignore_skip keyword arg to lvactivate. (dlehman) +- Add optional kwarg to force removal of a logical volume. (dlehman) +- Add backend functions for creating and managing snapshots. (dlehman) +- Add docstrings for BTRFSVolumeDevice and BTRFSSubVolumeDevice. (dlehman) +- Remove duplicate portion of lvm config string. (dlehman) +- Reset the devicetree before tearing everything down in _cleanUp. (dlehman) +- Make sure disk filters are applied even if populate fails. (dlehman) +- Sync the spec file with downstream (vpodzime) + +* Mon Jun 09 2014 Vratislav Podzimek - 0.55-1 +- IPSeriesPPC now supports GPT in Open Firmware (hamzy) +- Fix device name validation for devices that can contain / (#1103751) (dshea) +- Add a getRaidLevel() convenience method to raid.py (amulhern) +- Make a StorageDevice.raw_device property and use it where appropriate + (amulhern) +- Simplify a small chunk of Blivet.updateKSData() (amulhern) +- Move the code for getting a space requirement from devicefactory to raid. + (amulhern) +- Make all devicefactory classes uses RAID objects instead of strings. + (amulhern) +- Remove devicefactory.get_raid_level from blivet (amulhern) +- Put get_supported_raid_levels in devicefactory.py (amulhern) +- Make BTRFS devices use RAID objects instead of strings for levels (amulhern) +- Add lists of supported RAID levels for btrfs and lvm (amulhern) +- Add "linear" to mdraid's list of supported raid levels. (amulhern) +- Remove getRaidLevel() from mdraid file and make RAID_levels public (amulhern) +- Check for required methods in MDRaidLevels.isRaidLevel. (amulhern) +- Use has_redundancy property to decide how to add a member to an array. + (amulhern) +- Update the mdraid.mdadd comments (amulhern) +- Use has_redundancy raid property when checking whether a device is removable + (amulhern) +- Make createBitmap() a property and update tests appropriately. (amulhern) +- Add a Dup class to the various descendants of RAIDLevel. (amulhern) +- Add an is_uniform property to the RAID levels. (amulhern) +- Add a has_redundancy method that returns True if there is actual redundancy + (amulhern) +- Add Linear and Single to the RAID classes. (amulhern) +- Move Container class to raid package and tidy it up (amulhern) +- Allow the RAID object itself to be a valid RAID descriptor for lookup. + (amulhern) +- Adjust RaidLevel hierarchy so that all raid level objects extend RAIDLevel + (amulhern) +- No longer use _standard_levels as the default set of RAID levels. (amulhern) +- Extract selection of members in complete() into a separate method. (amulhern) +- Remove DMRaidArrayDevice.members property. (amulhern) +- Comment mdraid.mdcreate() and update tests appropriately. (amulhern) +- Import name 'lvm' instead of names from lvm package. (amulhern) + +* Sat Jun 07 2014 Fedora Release Engineering - 0.54-2 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_21_Mass_Rebuild + +* Wed May 28 2014 Brian C. Lane - 0.54-1 +- Add tests for setting device's parent list directly (vpodzime) +- Do not alter the ParentList being iterated over (#1083581) (vpodzime) +- Do not limit ThinLV's size to VG's free space (vpodzime) +- Take extra RAID metadata into account when growing LV (#1093144) (vpodzime) +- Move apply_chunk_growth outside of a for-cycle (vpodzime) +- Multiple arguments for string formatting need to be in parentheses (#1100263) + (mkolman) +- Make print statements Python 3 compatible (mkolman) +- Validate device names (dshea) +- Use a setter for Device.name as foretold by the prophecy of TODO (dshea) + +* Tue May 20 2014 Brian C. Lane - 0.53-1 +- Remove extra quotes from the xfs_db arguments. (dshea) +- Factor duplicate code in __deepcopy__ methods into one method (#1095244) + (amulhern) +- Rearrange code related to handleUdevDeviceFormat() (#1095329) (amulhern) +- Make dumpState catch and log all AttributeErrors (#1095329) (amulhern) +- Add sectorSize property to catch and handle missing partedDevice (#1095329) + (amulhern) +- Get rid of remaining uses of spec keyword for Size() in examples directory. + (amulhern) +- Generalize false positive regular expression for multiple pylint versions + (amulhern) +- Do not run some tests unless running on Jenkins. (amulhern) +- Miscellaneous pylint fixes. (amulhern) +- Globally disable pointless string statement warning (amulhern) +- Disable unused argument warning for 'args' in TmpFSDevice constructor + (amulhern) +- Omit 'args' parameter from formats constructors (amulhern) +- Disabled unused argument warning for kwargs in formats.destroy() (amulhern) +- Omit *args from parameters for format.create() and formats.destroy() + (amulhern) +- Omit *args from parameters in formats.setup() (amulhern) +- Make formats.teardown() not take any extra parameters. (amulhern) +- Make formats.mount use explicit keywords instead of kwargs. (amulhern) +- Remove non-self params from FS.doResize method (amulhern) +- Make doFormat use regular style keyword parameters (amulhern) +- Do not use *args, **kwargs idiom in scheduleCreateFormat. (amulhern) +- Do not use *args, **kwargs idiom in various schedule* auxiliary test methods. + (amulhern) +- Remove upgrading param from turnOnSwap() (amulhern) +- Disable unused-argument warning (amulhern) +- Disable pylint unused-argument warning. (amulhern) + +* Thu May 08 2014 Brian C. Lane - 0.52-1 +- Split ROOT_PATH usage into getTargetPhysicalRoot()/getSysroot() (walters) +- Update and fix copyright info for docs. (dlehman) +- Add some tests for extended partition management. (dlehman) +- Add some tests that verify the results of DeviceTree.populate. (dlehman) +- Add a base class for tests backed by disk image storage. (dlehman) +- Adapt examples to examples/common.py function dispersement. (dlehman) +- Change devices.SparseFileDevice._create to use util.create_sparse_file. + (dlehman) +- Move set_up_logging and create_sparse_file into blivet.util for reuse. + (dlehman) +- Make examples.common.tear_down_disk_images a DeviceTree method. (dlehman) +- Fix handling of devices activated as a side-effect of actions. (dlehman) +- Check for problematic active devices before processing any actions. (dlehman) +- Split some large blocks out of DeviceTree.processActions. (dlehman) +- Explicitly requested extended partitions already have an action. (dlehman) +- Fix handling of extended partitions across various modes of operation. + (dlehman) +- Handle the case of md arrays getting activated from outside blivet. (dlehman) +- Make an extra effort to remove dm partition nodes that want to stay. + (dlehman) +- Fix handling of clearing a partitioned disk and leaving it cleared. (dlehman) +- Don't check for disklabels on partitions. (dlehman) +- Update targetSize to reflect actual size after a device is created. (dlehman) +- Remove redundant msecs from logging timestamp. (dlehman) +- Make signature of Size.__new__ match signature of Decimal.__new__ (amulhern) +- Change Size so that it takes a single value parameter. (amulhern) +- Change all 'format' keyword args to 'fmt' in Device constructors (amulhern) +- Change format keyword argument to fmt in scheduleCreateFormat (amulhern) +- Change keyword parameters in devicetree.findActions (amulhern) +- Change ActionCreateFormat constructor keyword argument to 'fmt' (amulhern) +- Remove unused parameter 'ignoreErrors' from umountFilesystems() (amulhern) +- Remove parameter 'raiseErrors' from mountFilesystems() methods. (amulhern) +- Disable unused argument warning for 'major' and 'minor' (amulhern) +- Set dummy functions as values rather than via function definition syntax. + (amulhern) +- Pass size value to superconstructor for LVMVolumeGroupDevice. (amulhern) +- Sort the pylint-false-positives file (amulhern) +- Do not disable unused argument warning. (amulhern) +- Omit pylint warning about disabled warnings or errors from pylint log. + (amulhern) +- Put the pyblock warning in pylint-false-positives (amulhern) +- Remove obsolete documentation for parameter 'label'. (amulhern) + +* Mon May 05 2014 Brian C. Lane - 0.51-1 +- Adjust the available size on each disk using chunk size. (amulhern) +- Removed some now unused methods from devices (#1085474) (amulhern) +- Rename size() method to get_size() method. (amulhern) +- Remove unused get_size method (#1085474) (amulhern) +- Use raid.size method to get size of device (#1085474) (amulhern) +- Add a size() method to the raid classes (#1085474) (amulhern) +- Move line that might throw an MDRaid exception inside try block (#1085474) + (amulhern) +- Check whether type is mdbiosraidarray before checking smallest member + (#1085474) (amulhern) +- Log if there was a failure to calculate the size of the MDRaidArrayDevice + (#1085474) (amulhern) +- Rename get_raw_array_size to get_net_array_size (#1085474) (amulhern) +- Rename _get_size to _trim, which describes its function better (#1085474) + (amulhern) +- Improve comments on a few methods (#1085474) (amulhern) +- Make RAIDLevels iterable (#1085474) (amulhern) +- Update makebumpver for python-bugzilla 1.0.0 (bcl) +- Disable unused argument warning for 'key_file' in devicelibs.crypto methods + (amulhern) +- Disable unused argument warning for 'del_passphrase' in luks_remove_key + (amulhern) +- Disable unused argument warning for 'data' in doAutoPartition (amulhern) +- Disable unused argument warning for 'info' in handleUdevLuksFormat (amulhern) +- Disable unused argument warning for 'disks' in get_pv_space. (amulhern) +- Remove pointless parameters from unittest methods. (amulhern) +- Disable a no member warning for EddTestFS initializer. (amulhern) +- Get rid of unused argument 'args' in MakeBumpVer constructors (amulhern) +- Changes to _parseOneLine() and its single invocation. (amulhern) +- Remove obsolete comment (amulhern) +- Rename to avoid redefining parameter built-ins (amulhern) +- Change name to avoid redefining built-in (amulhern) +- Remove unused parameter in makeupdates. (amulhern) +- Removed unused argument 'options' from testMount (amulhern) +- Make signature of _setSize match that of the method it overrrides. (amulhern) +- Actually use argv parameter (amulhern) +- Pass fname as first argument to shutil.copy2 (amulhern) +- Remove minimumSector method and _minimumSector attribute (amulhern) +- Disable not-callable pylint warning. (amulhern) +- Set child_factory_fstype to None in DeviceFactory (amulhern) +- Suppress unpacking-non-sequence pylint warning (amulhern) +- Prefix name with defining package (amulhern) +- Update Platform instance from flags instead of replacing it. (#1090646) + (dlehman) +- Rename to avoid redefining built-ins where the redefinition is method local. + (amulhern) +- Set device.format in else block of try/except/else. (amulhern) +- Do not run pylint on sphinx generated conf.py (amulhern) +- Get rid of a redefined builtin while simplifying method. (amulhern) +- Compress loop into generator list comprehension (amulhern) +- Rewrite resize() method to depend on _resizable. (amulhern) +- Remove definition of LVMThinLogicalVolumeDevice._resizable (amulhern) +- Add an attribute docstring for _resizable. (amulhern) +- Correct comment on resizable property (amulhern) + +* Thu Apr 24 2014 Brian C. Lane - 0.50-1 +- Don't apply action until after all checks have passed. (dlehman) +- Apply action for extended partition creation. (dlehman) +- Fix an issue introduced in commit a210eb5c. (dlehman) +- Move changes from action ctors into apply methods. (dlehman) +- Tell lvm to prefer /dev/mapper/ and /dev/md/ to dm-X and mdX nodes. (dlehman) +- Use the right md UUID when trying to look one up from addUdevDevice. + (dlehman) +- Pass UUID of existing md array to superclass constructor. (dlehman) +- Fix accounting related to addition of md member devices. (dlehman) +- Add some more tests for the Size.humanReadable method (vpodzime) +- If size is an integer value, show it as an integer value (vpodzime) +- Make sure that using just k/m/g/... results in KiB/MiB/GiB/... (vpodzime) +- Make humanReadable size use binary prefixes and nicer units (vpodzime) +- Round sizes in humanReadable instead of flooring them (vpodzime) +- Do not assign result of evaluating EddTestFS() to a variable (amulhern) +- Rename bits() to numBits() (amulhern) +- Rename to avoid conflict with name in outer scope. (amulhern) +- Put module level code in a method (amulhern) +- Do not use strip() incorrectly (amulhern) +- Disable E1101 (no-member) error (amulhern) +- Use isResize in isShrink and isGrow. (amulhern) +- Suppress W0612 (unused-variable) false positives (amulhern) +- Suppress W0621 warnings (amulhern) +- Add a stub function for get_bootloader (amulhern) +- Suppress W0602 false positives (amulhern) +- Remove BootLoaderError definitions (amulhern) +- Disable E1003 warning. (amulhern) +- Do not cache the DeviceFormat object (amulhern) +- Suppress W0201 error where attribute is set in __new__. (amulhern) +- Add to false positives an error which is not suppressed by a pragma. + (amulhern) +- Suppress W0201 errors (amulhern) +- Make signature of Size.__str__ match signature of Decimal.__str__ (amulhern) +- Do not evaluate %% operator in log message arguments (amulhern) +- Remove suite() methods in tests (amulhern) +- Remove addKeyFromFile() method (amulhern) +- Import name 'deviceaction' where needed (amulhern) +- Setting variables in __init__ (amulhern) +- Log exception information and disable W0703 warning. (amulhern) +- Disable some W0703 warnings (amulhern) +- Disable some W0703 warnings. (amulhern) +- Add a function that logs available exception info. (amulhern) +- Restrict scope of pylint pragmas as much as possible (amulhern) +- Change all pylint numeric codes to mnemonic strings. (amulhern) + +* Thu Apr 17 2014 Brian C. Lane - 0.49-1 +- Slightly reduce loop and get rid of obsolete comment (amulhern) +- Slightly rewrite loop to avoid a redefining builtin error (amulhern) +- Simplify find_library and fix redefining built-in errors. (amulhern) +- Make loop variables a little more descriptive (amulhern) +- Make regular expressions raw strings. (amulhern) +- Suppress unused variable warning and check for failure. (amulhern) +- Add W0105 warning about attribute docstrings to false positives (amulhern) +- Make signature of setup() in parent class same as in children (amulhern) +- Suppress some correct pylint warnings (amulhern) +- Get _loopMap.values() when all that's needed is the values (amulhern) +- Obvious fix inspired by pylint E0602 error (amulhern) +- Suppress W0631 warning for abbr and prefix. (amulhern) +- Do not do formatting operation in the argument of the translation (amulhern) +- Remove unnecessary global statements (amulhern) +- Disable W0703 message in test (amulhern) +- Explicitly set the module level platform variable (amulhern) + +* Thu Apr 10 2014 Brian C. Lane - 0.48-1 +- Do not execute smallestMember property method twice. (amulhern) +- Remove unnecessary function definitions in abstract properties (amulhern) +- Pass format args as arguments to debug method (#1085057) (amulhern) +- Move udev_settle call from util into fs to break circular dependency + (amulhern) +- Change implicit relative imports to explicit relative imports (amulhern) +- Remove unused imports (amulhern) +- Get rid of os.path import (amulhern) +- Really avoid dynamic import of formats/__init__.py by itself (amulhern) +- Ignore E1101 errors in savePassphrase. (amulhern) +- Add a bunch of E1120 errors to the false positives file (amulhern) +- Make LabelingAsRoot class an abstract class and define two properties + (amulhern) +- Suppress false positive W0631 error. (amulhern) +- Use self.nic instead of nic (amulhern) +- Make sure _state_functions is a dictionary in base class (amulhern) +- Remove unnecessary lambda wrappers on assertion functions (amulhern) +- Obvious fix inspired by an "Undefined variable warning" (amulhern) +- Remove all references to lvm_vg_blacklist and blacklistVG. (amulhern) +- Update for changes in the anaconda errorHandler API. (dshea) +- Remove unused imports. (amulhern) +- Import from the defining module. (amulhern) +- Move import to top level. (amulhern) +- Do not use implicit relative imports (amulhern) +- Remove wildcard import (amulhern) +- Fix a bug and catch a change in lvm's thin pool layout. (dlehman) +- Plumb uuid down through DMDevice. (dlehman) + +* Wed Apr 02 2014 Brian C. Lane - 0.47-1 +- Change labelApp to a more concisely defined abstract property (amulhern) +- Change defaultLabel to a more concisely defined abstract property. (amulhern) +- Change _labelstrRegex to a more concisely defined abstract property. + (amulhern) +- Make reads property a bit more succinct. (amulhern) +- Make name an abstract property and omit _name (amulhern) +- Remove an unused import from devicelibs/raid.py (vpodzime) +- Fix all pylint errors in pylintcodediff (amulhern) +- Don't run test if the git branch is dirty (amulhern) +- Exit if the specified log file does not exist. (amulhern) +- Update lvm devicelibs tests to reflect recent changes. (dlehman) +- Add required LVs as needed instead of trying to sort by attrs. (dlehman) +- Fix missed conversion of rm->missing in vgreduce call. (dlehman) +- Only gather lvm information one time per DeviceTree.populate call. (dlehman) +- Add support for listing everything to pvinfo and lvs. (dlehman) +- Get lv list from lvm in a more straightforward format. (dlehman) +- Gather lv list where we use it to save from having to stash it. (dlehman) +- Split out common lvm parsing code. (dlehman) +- Add tests that use ParentList as part of Device. (dlehman) +- Parent list length doesn't reflect new member in _addParent. (dlehman) +- Rearrange _startEdd to be a little more obvious. (amulhern) +- Raise exceptions using the new syntax (amulhern) +- Do not import logging twice. (amulhern) +- Suppress unused variable warning (amulhern) +- Get rid of writeRandomUUID. (amulhern) +- Remove unused variable but retain call for its side-effects (amulhern) +- Put docstring in class (amulhern) +- Remove appendiceal assignment (amulhern) +- Keep first parameter "self" (amulhern) +- Omit compile flag (amulhern) +- Move lines beneath __main__ into a main method (amulhern) +- Indent with spaces, not tabs (amulhern) +- Change param default [] to None and convert in method (amulhern) +- Change to a semantically equivalent version of FileDevice.path (amulhern) +- Adapt existing tests to changed signature of some methods (amulhern) +- Don't assign return value to unused variable (amulhern) +- Be specific when catching exceptions (dshea) +- Remove appendiceal assignments (amulhern) +- Remove a lot of unused variables extracted from udev info (amulhern) +- Don't get return values from communicate() if they are ignored (amulhern) +- Use the disk's name in log message (amulhern) +- Get rid of old exception unpacking syntax (dshea) +- Rearranged some iffy exception checking (dshea) +- Replace with a semantically equivalent chunk. (amulhern) +- Remove some unused exception names. (amulhern) +- Remove unused assignment to boot. (amulhern) +- Delete method-local pruneFile function. (amulhern) +- Don't comment out function headers but leave their bodies uncommented + (amulhern) +- Get rid of unnecessary pass statements (amulhern) +- Put a field and a method in the base class (amulhern) +- Spell parameter self correctly (amulhern) +- Give abstract method the same signature as its overriding methods. (amulhern) +- Catch correct error and disable warning. (amulhern) + +* Wed Mar 26 2014 Brian C. Lane - 0.46-1 +- Adapt callers to use the new parent list interface. (dlehman) +- Change management of Device parents to use a simple list interface. (dlehman) +- Convert ContainerDevice to an abstract base class. (dlehman) +- Set device uuid before calling Device ctor. (dlehman) +- Improve the mechanism for VG completeness. (dlehman) +- Support mutually-obsoleting actions. (dlehman) +- Add some checking to MDRaidArrayDevice._setSpares. (dlehman) +- Make sorting by action type part of the action classes. (dlehman) +- Add action classes for container member set management. (dlehman) +- Add a property to provide consistent access to parent container device. + (dlehman) +- Add type-specific methods for member set management. (dlehman) +- Adapt callers to new method names for add/remove member device. (dlehman) +- Add a ContainerDevice class to consolidate member management code. (dlehman) +- Add backend functions for container member set management. (dlehman) +- Teardown RAID device once testing is over (amulhern) +- Make lvm tests runnable. (amulhern) +- Make crypt tests runnable. (amulhern) +- Replace unnecessarily complicated expression with string multiplication + (amulhern) +- Suppress unused variable warning for index in range (amulhern) +- Suppress some unused variable warnings. (amulhern) +- Suppress some unused variable warnings (amulhern) +- Update to the new raise syntax (dshea) +- Removed an unnecessary semicolon (dshea) +- Removed a redundant definition of NoDisksError (dshea) +- Specify regular expressions containing backslashes as raw strings (dshea) +- Fixed some questionable indentation (dshea) +- Fix logging function string format warnings. (dshea) +- All size specifications should be Size instances (#1077163) (vpodzime) +- Make sure StorageDevice's self._size is a Size instance (#1077179) (vpodzime) +- Allow creating Size instance from another Size instance (vpodzime) +- Force removal of hidden devices (#1078163) (amulhern) +- Get action_test into working order. (dlehman) +- Update action_test.py to specify sizes using blivet.size.Size. (dlehman) +- Don't corrupt the environment when setting up StorageTestCase. (dlehman) +- Make minSize, maxSize consistent and correct. (dlehman) +- Don't prevent grow actions on devices with no max size. (dlehman) + +* Thu Mar 20 2014 Brian C. Lane - 0.45-1 +- Changes to allow pylint checks to be run on a distribution of the source. + (amulhern) +- Remove non-doing check target (amulhern) +- Add a script to relate pylint errors to lines changed. (amulhern) +- Change output format so that it is suitable for diff-cover. (amulhern) +- Do an initial setup for running pylint tests in blivet. (amulhern) +- Handle None in devicePathToName(#996303) (dshea) +- Remove bootloader.packages from storage.packages (#1074522). (clumens) +- Whitespace fixes for the crypto devicelib module (vpodzime) +- Use random.choice for generating LUKS backup passphrase (vpodzime) +- Trivial fixes for the lvm devicelib module (vpodzime) +- Make vginfo work the same way as pvinfo and other LVM functions (vpodzime) +- Allow NTFS to be mountable. (#748780) (dshea) +- Limit the LV size to VG's free space size (vpodzime) + +* Fri Mar 07 2014 Brian C. Lane - 0.44-1 +- Fix an old typo in zeroing out a PReP partition. (#1072781) (dlehman) +- Only count with the extra metadata extents in new VGs and LVs (#1072999) + (vpodzime) +- Use container's parent's name for PV if available (#1065737) (vpodzime) +- Fix traceback with write_dasd_conf. (#1072911) (sbueno+anaconda) +- When copying a root, also copy hidden devices (#1043763) (amulhern) +- Add hidden flag to devicetree.getDeviceByID (#1043763) (amulhern) +- Only set device for mountpoint if it is not None (#1043763) (amulhern) +- Extend the list of things to be omitted if moddisk is False (#1043763) + (amulhern) +- Set req_name to None at the top of initializer (#1043763) (amulhern) +- Log action cancelation (#1043763) (amulhern) +- Make DeviceTree.hide() remove a larger set (#1043763) (amulhern) +- Re-write the DASD storage code. (#1001070) (sbueno+anaconda) +- Include image install flag when updating from anaconda flags. (#1066008) + (dlehman) + +* Fri Feb 28 2014 Brian C. Lane - 0.43-1 +- Include tmpfs mounts in post-install kickstart (#1061063) (mkolman) +- Count with the extra metadata extents for RAID consistently (#1065737) + (vpodzime) +- Make partitioning error message more friendly (#1020388) (amulhern) +- Fix partition handling across multiple processActions calls. (#1065522) + (dlehman) +- Let the udev queue settle before populating the devicetree. (#1049772) + (dlehman) +- Don't activate or deactivate devices from the action classes. (#1064898) + (dlehman) +- Improve handling of parted.DiskLabelCommitError slightly. (dlehman) +- Make teardownAll work regardless of flags. (dlehman) +- Fix maxSize test when setting device target size. (dlehman) +- Size.convertTo should return a Decimal. (dlehman) +- Don't use float for anything. (dlehman) +- Fix type of block count in PartitionDevice._wipe. (dlehman) +- Fix handling of size argument to devicelibs.lvm.thinlvcreate. (#1062223) + (dlehman) +- return empty set when no matching fcoe nic (#1067159) (bcl) +- Return str from Size.humanReadable (#1066721) (dshea) +- Add a coverage test target (#1064895) (amulhern) +- Filesystem labeling tests will not run without utilities (#1065422) + (amulhern) +- Rename misc_test.py to something more descriptive (#1065422) (amulhern) +- Refactor labeling tests (#1065422) (amulhern) +- Move SwapSpace tests into a separate class (#1065422) (amulhern) + +* Tue Feb 18 2014 Brian C. Lane - 0.42-1 +- Wait for udev to create device node for new md arrays. (#1036014) (dlehman) +- Fix detection of thin pool with non-standard segment types. (#1022810) + (dlehman) +- NFSDevice does not accept the exists kwarg. (#1063413) (dlehman) +- Don't run mpathconf for disk image installations. (#1066008) (dlehman) +- If /etc/os-release exists, check it to identify an installed system. + (clumens) +- Get the unit tests into a runnable state. (dlehman) +- Update Source URL in spec file to use github. (dlehman) + +* Tue Feb 11 2014 Brian C. Lane - 0.41-1 +- ntfs _getSize needs to use Decimal (#1063077) (bcl) +- Separate sanityCheck-ing from doAutoPartition (#1060255) (amulhern) +- Change messages to SanityExceptions objects (#1060255) (amulhern) +- Make a small SanityException hierarchy (#1060255) (amulhern) +- Remove unused exception class (#1060255) (amulhern) +- Add another .decode("utf-8") to humanReadable (#1059807) (dshea) +- makebumpver: Any failure should cancel the bump (bcl) + +* Tue Feb 04 2014 Brian C. Lane - 0.40-1 +- makebumpver: Only remove from list if action is not Resolves (bcl) +- Update bumpver to allow Related bugs (bcl) +- Remove all dependent devices of san device becoming multipath (#1058939) + (rvykydal) +- When repopulating multipath members mark them as multipath (#1056024) + (rvykydal) +- fcoe: parse yet another sysfs structure for bnx2fc devices (#903122) + (rvykydal) +- fcoe: add fcoe=: to boot options for nics added manually (#1040215) + (rvykydal) +- Convert the ntfs minsize to an int (#1060031) (dshea) +- Convert the string representation of Size to a str type. (#1060382) (dshea) +- don't display stage2 missing error as well if the real problem is stage1 + (awilliam) +- Provide a mechanism for platform-specific error messages for stage1 failure + (awilliam) +- Don't add None value to req_disks (#981316) (amulhern) +- Make error message more informative (#1022497) (amulhern) +- Check that file that loop device is going to use exists (#982164) (amulhern) +- Use os.path.isabs to check whether path name is absolute (#994488) (amulhern) + +* Tue Jan 28 2014 Brian C. Lane - 0.39-1 +- escrow: make sure the output directory exists (#1026653) (wwoods) +- provide a more useful error message if user fails to create an ESP (awilliam) +- Tell lvcreate not to ask us any questions and do its job. (#1057066) + (dlehman) + +* Fri Jan 24 2014 Brian C. Lane - 0.38-1 +- Some simple tests for _verifyLUKSDevicesHaveKey (#1023442) (amulhern) +- Verify that LUKS devices have some encryption key (#1023442) (amulhern) + +* Wed Jan 22 2014 Brian C. Lane - 0.37-1 +- Only do SELinux context resets if in installer mode (#1038146) (amulhern) +- Look up SELinux context for lost+found where it is needed (#1038146) + (amulhern) +- Don't reset the SELinux context before the filesystem is mounted (#1038146) + (amulhern) +- Test setting selinux context on lost+found (#1038146) (amulhern) +- Only retrieve the unit specifier once (dshea) +- Fix the Device.id usage. (dshea) +- Accept both English and localized sizes in Size specs. (dshea) +- Use a namedtuple to store information on unit prefixes (dshea) +- Remove en_spec Size parameters. (dshea) +- Fix potential traceback in devicetree.populate. (#1055523) (dlehman) +- Fall back on relabeling app where available (#1038590) (amulhern) +- Change the meaning of label field values (#1038590) (amulhern) +- Enable labeling on NTFS filesystem (#1038590) (amulhern) +- Enable labeling on HFS filesystem (#1038590) (amulhern) +- Add a method that indicates ability to relabel (#1038590) (amulhern) +- Use filesystem creation app to set filesystem label (#1038590) (amulhern) +- Import errors so FSError name is resolved (#1038590) (amulhern) +- Remove BTRFS._getFormatOptions (#1038590) (amulhern) +- Make an additional class for labeling abstractions (#1038590) (amulhern) +- Fix copyright date (#1038590) (amulhern) +- Remove redundant _defaultFormatOptions field (#1038590) (amulhern) +- Remove code about unsetting a label (#1038590) (amulhern) +- Return None if the filesystem has no label (#1038590) (amulhern) +- Removed redundant check for existance of filesystem (#1038590) (amulhern) +- Have writeLabel throw a more informative exception (#1038590) (amulhern) + +* Fri Jan 17 2014 Brian C. Lane - 0.36-1 +- Update the TODO list. (dlehman) +- Multipath, fwraid members need not be in exclusiveDisks. (#1032919) (dlehman) +- Convert parted getLength values to Size (dshea) +- Last of the Device._id -> Device.id (bcl) +- iscsi: in installer automatically log into firmware iscsi targets (#1034291) + (rvykydal) +- Use isinstance for testing numeric types (vpodzime) +- Device._id -> Device.id (clumens) +- Allow resetting partition size to current on-disk size. (#1040352) (dlehman) + +* Fri Jan 10 2014 Brian C. Lane - 0.35-1 +- Convert everything to use Size. (dlehman) +- Allow negative sizes. (dlehman) +- Fix return value of Size.convertTo with a spec of bytes. (dlehman) +- Discard partial bytes in Size constructor. (dlehman) +- Prefer binary prefixes since everything is really based on them. (dlehman) +- Fix a few minor problems introduced by recent raid level changes. (dlehman) +- Move label setter and getter into DeviceFormat class (#1038590) (amulhern) +- Add a test for labeling swap devices (#1038590) (amulhern) +- Default to None to mean none, rather than empty string (#1038590) (amulhern) +- Add a labelFormatOK method to the DeviceFormat's interface (#1038590) + (amulhern) +- Indicate whether the filesystem can label (#1038590) (amulhern) +- Restore ability to write an empty label where possible (#1038590) (amulhern) +- More tests to check writing and reading labels (#1038590) (amulhern) +- Remove fsConfigFromFile (#1038590) (amulhern) +- Changes to the handling of filesystem labeling (#1038590) (amulhern) +- Add some simple tests for file formats. (amulhern) +- Give DeviceFormat objects an id (#1043763) (amulhern) +- Refactor to use ObjectID class (#1043763) (amulhern) +- Make a class that creates a unique-per-class id for objects (#1043763) + (amulhern) +- Revert "Make a class that creates a unique-per-class id for objects + (#1043763)" (amulhern) +- Revert "Give DeviceFormat objects an object_id (#1043763)" (amulhern) +- Make the maximum end sector for PReP boot more benevolent (#1029893) + (vpodzime) +- Give DeviceFormat objects an object_id (#1043763) (amulhern) +- Make a class that creates a unique-per-class id for objects (#1043763) + (amulhern) +- Make get_device_format_class return None if class not found (#1043763) + (amulhern) +- A few simple unit tests for some formats methods (#1043763) (amulhern) +- Don't translate format names (dshea) + +* Thu Dec 19 2013 Brian C. Lane - 0.34-1 +- Forget existing partitions of device becoming a multipath member (#1043444) + (rvykydal) +- Include blivet.devicelibs.raid in the generated documentation. (amulhern) +- Upgrade the comments in raid.py to be compatible with sphinx. (amulhern) +- Make space for LUKS metadata if creating encrypted device (#1038847) + (vpodzime) +- fcoe: give error message in case of fail when adding device (#903122) + (rvykydal) +- fcoe: adapt bnx2fc detection to changed sysfs path structure (#903122) + (rvykydal) +- Update format of iscsi device becoming multipath member (#1039086) (rvykydal) + +* Tue Dec 17 2013 Brian C. Lane - 0.33-1 +- Add initial 64-bit ARM (aarch64) support (#1034435) (dmarlin) +- Convert to sphinx docstrings. (dlehman) +- Add some documentation. (dlehman) +- Move getActiveMounts from Blivet into DeviceTree. (dlehman) +- Add an example of creating lvs using growable requests. (dlehman) +- Remove a whole bunch of unused stuff from Blivet. (dlehman) +- Remove usage of float in Size.humanReadable. (dlehman) +- Add missing abbreviations for binary size units. (dlehman) +- Fix shouldClear for devices with protected descendants. (#902417) (dlehman) +- Use // division so that it continues to be floor division in Python 3. + (amulhern) + +* Thu Dec 12 2013 Brian C. Lane - 0.32-1 +- Work on devicelibs.btrfs methods that require that the device be mounted. + (amulhern) +- Remove some methods from devicelibs.btrfs. (amulhern) +- Add a comment to btrfs.create_volume. (amulhern) +- Add a file to run btrfs tests. (amulhern) +- Remove format.luks.LUKS.removeKeyFromFile. (amulhern) +- Changes to devicelibs.mdraid.mdactivate. (amulhern) +- Restore an import removed in a previous commit. (amulhern) +- Add a PE for LUKS metadata (#1038969) (bcl) +- Adjust currentSize methods slightly. (amulhern) +- Put additional constraints on the ActionResizeDevice initializer. (amulhern) +- Remove redundant checks in existing resize() methods. (amulhern) +- Add some baseline unit tests for BTRFS devices. (amulhern) +- Robustify use of defaultSubVolumeID field. (amulhern) +- Check that a BTRFS subvolume has exactly one parent in constructor. + (amulhern) +- BTRFSSubVolume.volume checks the class of its return value. (amulhern) +- Raise ValueError in BTRFS constructor if no parents specified. (amulhern) +- Add tests for a couple of additional properties for MDRaidArrayDevice. + (amulhern) +- Factor state testing behavior into a separate class. (amulhern) +- Remove redundant condition in if statement. (amulhern) + +* Thu Dec 05 2013 Brian C. Lane - 0.31-1 +- Make RAIDLevel an abstract class using abc. (amulhern) +- Restore a util import that was removed in a recent commit. (amulhern) + +* Wed Dec 04 2013 Brian C. Lane - 0.30-1 +- Always run action's cancel method as part of cancelAction. (dlehman) +- Show Invalid Disk Label for damaged GPT (#1020974) (bcl) +- Make error message in setDefaultFSType more informative (#1019766) (amulhern) +- Set sysfsPath of LUKSDevice when adding to device tree (#1019638) (jsafrane) +- Use given format type as format's name instead of type (vpodzime) + +* Wed Nov 27 2013 Brian C. Lane - 0.29-1 +- btrfs and xfs do not support fsck or dump at boot time (#862871) (bcl) +- Removed raid level constants from mdraid.py. (amulhern) +- Remove raidLevel and get_raid_min_members for mdraid.py. (amulhern) +- Remove raidLevelString in raid and mdraid. (amulhern) +- In devicefactory.py change mdraid procedures call to raid method calls. + (amulhern) +- Removed mdraid.raid_levels (amulhern) +- Removed mdraid.get_raid_max_spares. (amulhern) +- Change MDRaidArrayDevice to use raid package. (amulhern) +- Changed devicelibs.mdraid to make use of devicelibs.raid. (amulhern) +- Implement a RAID class hierarchy. (amulhern) +- A few small tests for MDFactory class. (amulhern) +- Add some additional unit tests in mdraid_tests.py. (amulhern) +- Make MDRaidArrayDevice initializer not except raid level of None. (amulhern) +- Add some basic unit tests for MDRaidArrayDevice. (amulhern) +- Move pyanaconda import into blivet.enable_installer_mode. (amulhern) + +* Mon Nov 25 2013 David Lehman - 0.28-1 +- Clear whole-disk formatting before initializing disks. (#1032380) (dlehman) +- Simplify calculation of vol size when adding a btrfs subvol. (#1033356) + (dlehman) +- Handle passing a btrfs volume as device to BTRFSFactory. (dlehman) +- Add support for detecting btrfs default subvolume. (dlehman) +- Handle nested btrfs subvolumes correctly. (#1016959) (dlehman) +- Mark all format names as translatable (dshea) +- Add parameters for untranslated Size specs. (dshea) +- Fix usage of _ vs N_ (dshea) +- Added a i18n module for gettext functions. (dshea) +- Allow non-ASCII characters in the size spec (dshea) + +* Tue Nov 19 2013 David Lehman - 0.27-1 +- Specify btrfs volumes by UUID in /etc/fstab. (dlehman) +- Catch any exception raised by findExistingInstallations. (#980267) (dlehman) +- Prevent md_node_from_name from raising OSError. (#980267) (dlehman) +- Tidy up tests in devicelibs_test directory. (amulhern) +- Preparation for lv resize is a subset of that for lv destroy. (#1027682) + (dlehman) +- Make sure new values of targetSize are within bounds. (dlehman) +- Devices with non-existent formatting are resizable. (#1027714) (dlehman) +- Do not hide non-existent devices. (#1027846) (dlehman) +- Change XFS maximum to 16EB (#1016035) (bcl) +- Add tmpfs support (#918621) (mkolman) +- Add support for returning machine word length (mkolman) +- Require cryptsetup instead of cryptsetup-luks (#969597) (amulhern) +- Fix initialization of disks containing sun or mac disklabels. (dlehman) +- Newly formatted devices are used unless mountpoint is empty. (#966078) + (dlehman) +- Fix detection of lvm setups. (#1026466) (dlehman) +- Fix handling of overcommitted thin pools in thinp factory. (#1024144) + (dlehman) +- Fix name checking for new thin lvs. (#1024076) (dlehman) + +* Wed Oct 30 2013 Brian C. Lane - 0.26-1 +- Add macefi format type (#1010495) (bcl) +- Allow hfs+ boot devices to have their name set (#1010495) (bcl) +- Update parted partitions on hidden disks when copying a Blivet. (#1023556) + (dlehman) +- Add ack flag checking to makebumpver (bcl) +- Add makebumpver script (bcl) + +* Fri Oct 25 2013 Brian C. Lane - 0.25-1 +- Remove requirement for btrfsctl which no longer exists. (#1012504) (dlehman) +- Allow for adjustment of factory vg after removal of thin pool. (#1021890) (dlehman) +- Add boot description for "disk" devices on s390. (#867777, #903237, #960143) (sbueno+anaconda) +- Add initial spport for aarch64 as we only plan to support UEFI this should be enough (dennis) + +* Wed Oct 16 2013 David Lehman - 0.24-1 +- Close file descriptors other than stdin,stdout,stderr on exec. (#1016467) (dlehman) +- Don't use hardcoded /tmp paths. (#1004404) (dlehman) +- Fix detection of lvm thinp setups. (#1013800) (dlehman) +- Generate a name if necessary when reconfiguring a factory device. (#1019500) (dlehman) +- Handle anaconda's cmdline option to disable mpath friendly names. (#977815) (dlehman) +- Allow specifying which swaps should appear in fstab (vpodzime) +- Do not limit swap size to 10 % of disk space for hibernation (vpodzime) + +* Wed Oct 09 2013 Brian C. Lane - 0.23-1 +- Make sure bootloader is setup after autopart (#1015277) (bcl) +- Let setUpBootLoader raise BootloaderError (#1015277) (bcl) +- Limit the maximum swap size to 10 % of disk space (if given) (vpodzime) +- support ppc64le architecture (hamzy) +- Don't call handleUdevDeviceFormat without udev device (#1009809) (dshea) + +* Fri Sep 06 2013 David Lehman - 0.22-1 +- Allow implicit inclusion of multipath/fwraid by including all members. (dlehman) +- If a device has been removed, omit it from the copied root. (#1004572) (dlehman) +- Thinp metadata and chunk size default to 0 -- not None. (#1004718) (dlehman) +- Revert "Do not try to align partitions to optimal_io_size. (#989333)" (dlehman) + +* Thu Sep 05 2013 Brian C. Lane - 0.21-1 +- Only force luks map names to include UUID during OS installation. (#996457) (dlehman) +- Allow DiskLabelCommitError to reach the caller. (#1001586) (dlehman) +- Do not try to align partitions to optimal_io_size. (#989333) (gustavold) +- Fix rpmlog make target (bcl) +- Add missing changelog lines to spec (bcl) + +* Fri Aug 23 2013 Brian C. Lane - 0.20-1 +- Fix typo in examples/list_devices.py (dlehman) +- Use iscsi-iname instead of trying to reimplemnt it in python. (dlehman) +- Catch exceptions raised while finding old installations. (#981991) (dlehman) +- Keep the dasd list in sync with the devicetree's device list. (#965694) (dlehman) +- Don't save luks keys unless installer_mode flag is set. (#996118) (dlehman) +- Pass mount options to resolveDevice in _parseOneLine (#950206) (vpodzime) +- Fix handling of devices in detected installations in Blivet.copy. (dlehman) +- Clean up detection of lvm raid. (dlehman) +- Tag the first build of each version without the release. (dlehman) +- Remove dangling code block from commit 737169b75af1. (dlehman) + +* Wed Jul 31 2013 Brian C. Lane - 0.19-1 +- Don't waste time looking for devices dependent on leaf devices. (dlehman) +- Add some example code for creation of disk partitions. (dlehman) +- Don't manipulate partition boot flags except in installer mode. (dlehman) +- Add an example of DeviceFactory usage. (dlehman) +- Cosmetic changes for the arch module (vpodzime) +- No more sparc support (vpodzime) +- Cleanup arch.py reredux (hamzy) +- Allow explicit requests for extended partitions. (#891861) (dlehman) +- Fix disklabel handling for multiple calls to processActions. (dlehman) +- Add support for explicit start/end sectors in partition requests. (#881025) (dlehman) +- Store current mount options in getActiveMounts. (#914898) (dlehman) +- Lack of formatting does not preclude device resize. (dlehman) +- Handle negative sizes correctly. (dlehman) +- Fix handling of clearpart type linux in shouldClear. (dlehman) +- Add some tests for clearpart and related functionality. (dlehman) +- Update unit tests and add a make target to run them. (dlehman) +- Don't pass dracut args for lvm thin pools. (dlehman) +- Update the TODO list. (dlehman) +- Fix a copy/paste error. (dlehman) +- Remove transifex-client BuildRequires. (dlehman) + +* Tue Jul 09 2013 Brian C. Lane - 0.18-1 +- Raise XFS max size limit to 100TB. (sbueno+anaconda) +- Add a device factory class for thinly-provisioned lvm. (dlehman) +- Add support for automatic partitioning using lvm thin provisioning. (dlehman) +- Add convenience methods related to lvm thin provisioning. (dlehman) +- Add support for detection of lvm thinp setups. (dlehman) +- Add classes for lvm thin pool and thin volume. (dlehman) +- Add backend support for lvm thinp operations. (dlehman) +- Fix return value of get_pv_space for size of 0. (dlehman) +- Fix ksdata for lvm created in custom spoke based on autopart. (dlehman) +- Only put max size in ksdata if partition is growable. (dlehman) +- Allow subclasses to inherit ksdata classes. (dlehman) + +* Mon Jun 24 2013 Brian C. Lane - 0.17-1 +- Used Python type instead of variable name (#968122) (hamzy) +- Fix detection of valid EFI system partition during autopart. (dlehman) +- New version: 0.16 (bcl) + +* Thu Jun 13 2013 Brian C. Lane - 0.16-1 +- Install utilities for all devices -- not just those being used. (#964586) (dlehman) +- Add a method to apply Blivet settings to ksdata. (dlehman) +- Increase padding for md metadata in lvm factory. (#966795) (dlehman) +- Move lvm-on-md into LVMFactory. (dlehman) +- Switch to a minimum of four members for raid10. (#888879) (dlehman) +- Update the TODO list. (dlehman) +- Deactivate devices before hiding those on ignored disks. (#965213) (dlehman) +- Allow udev queue to settle after writing zeros to disk. (#969182) (hamzy) +- Run lsof when umount fails (bcl) +- Run udev settle before umount (bcl) + +* Mon Jun 03 2013 Brian C. Lane - 0.15-1 +- Switch to the LGPLv2+. (dlehman) +- Clear md arrays' sysfs path after deactivating them. (#954062) (dlehman) +- Factories with existing containers use the container's disk set. (dlehman) +- Don't set up a child factory if the container is set and exists. (dlehman) +- Set a non-zero size for new btrfs subvols in an existing volume. (dlehman) +- Open as many luks devs as possible with any given passphrase. (#965754) (dlehman) +- Make sure container changes worked before applying device changes. (#965805) (dlehman) +- Re-initialize platform in storageInitialize (#962104) (bcl) +- Make a copy of devicetree._devices before using the append operator. (clumens) +- Handle incomplete devices becoming complete on device rescan. (clumens) +- Don't allow a device to be on the hidden list more than once. (clumens) + +* Wed May 15 2013 David Lehman - 0.14-1 +- total_memory calculation needs to round up (#962231) (bcl) +- The dev.node attribute for iscsi devices is not copyable (#962865). (clumens) +- Wipe partitions before they are created (#950145) (bcl) +- Pass ROOT_PATH as an argument instead of importing it. (clumens) +- If no iscsi nodes are discovered, return an empty list instead of None. (clumens) + +* Thu May 09 2013 Brian C. Lane - 0.13-1 +- Make sure createBitmap is updated when level changes (#960271) (bcl) +- Update biosboot error message (#960691) (bcl) + +* Fri May 03 2013 David Lehman - 0.12-1 +- Fix a bug in renaming lvm lvs. (dlehman) +- Add container size policies for unlimited growth and fixed size. (dlehman) +- Remove device factory methods to change container name. (dlehman) +- Override any default subvol when mounting main btrfs volume. (#921757) (dlehman) +- Fix detection of multipath. (#955664) (dlehman) +- When a btrfs subvol's name is changed, change its subvol argument too. (clumens) +- Allow returning hidden disks from the getDeviceBy* methods, if asked. (clumens) +- Fix fipvlan -f argument once more and for good (#836321) (rvykydal) +- Remove the intf parameters from the iscsi class. (clumens) +- Don't relly on /proc/mdstat when enumeraing RAID levels. (jsafrane) +- Set product names in non-installer mode. (jsafrane) +- Fixed checking status of MD RAID which was just deleted. (jsafrane) +- Account for the fact that md's metadata usage is unpredictable. (dlehman) +- Remove members from their containers before destroying them. (dlehman) +- Make get_container work even if there are duplicate names. (dlehman) +- LVMFactory with a container_raid_level means use LVMOnMDFactory. (dlehman) +- Add a check for enough raid members after allocating partitions. (dlehman) +- Make parent_factory an attribute of the DeviceFactory instance. (dlehman) +- All container settings use container_ kwargs. (dlehman) +- Add ability to find raid level of an lvm vg. (dlehman) +- Always pass -f to wipefs since it lies about in-use devices. (#953329) (dlehman) +- Fix a bug extended partition management. (#951765) (dlehman) +- Don't return incomplete devices from getDeviceByFoo methods by default. (dlehman) +- Don't traceback when degraded md raid arrays are present. (#953184) (dlehman) + +* Mon Apr 15 2013 David Lehman - 0.11-1 +- Fix handling of isohybrid media. (#950510) (dlehman) +- Fix getting dracut setup args from dasd.conf. (#950964) (dlehman) + +* Tue Apr 09 2013 David Lehman - 0.10-1 +- Extended partitions containing logical partitions are not leaves. (#949912) (dlehman) +- Remove devices in reverse order in Blivet.recursiveRemove. (#949912) (dlehman) +- Rewrite the DeviceFactory classes. (dlehman) +- Hook up error handling in installer-specific methods. (#948250) (dlehman) +- Don't traceback if fcoe.startup is called without fcoe utils present. (dlehman) +- Fix logic error that causes us to ignore disks in exclusiveDisks. (dlehman) +- Slightly improve currentSize for btrfs volumes. (dlehman) +- Simplify multipath handling. (dlehman) +- Don't expect anaconda udev rules to be in use. (dlehman) +- Drop requires for things only needed for OS installation. (dlehman) +- New version: 0.9 (bcl) +- Only install packages for devices and filesystems used by the OS. (dlehman) +- Fix LVMLogicalVolumeDevice.maxSize. (dlehman) +- Fix handling of name=None in newLV, newMDArray, newVG. (dlehman) +- Allow calls to suggestDeviceName with only a prefix argument. (dlehman) +- Move mdadm superblock size calculation into devicelibs.mdraid. (dlehman) + +* Thu Mar 28 2013 Brian C. Lane - 0.9-1 +- NTFS.minSize is supposed to be a property. (#924410) (dlehman) +- Mount /run during install and fix /sys mount (#922988) (bcl) +- Fix two excptions triggered by calls to copy_to_system. (hamzy) + +* Wed Mar 13 2013 David Lehman - 0.8-1 +- Check for "ip=ibft" cmdline option, not for "ibft". (rvykydal) +- run_program returns an int. (#920584) (dlehman) +- Fix units for lvs output. (dlehman) +- Don't pass an intf arg to ISCSI.stabilize. (#920041) (dlehman) +- Add __version__ to blivet/__init__.py. (dlehman) +- Only run info prog (eg: dumpe2fs) once per filesystem. (dlehman) +- Processing of a PV with no VG metadata is easy. (dlehman) +- Add some convenience properties for displaying DeviceAction info. (dlehman) +- Ignore MTDs, as we do not have the tools to write to them (#916771). (clumens) +- Include udev's list of symbolic links in StorageDevice. (#914724) (dlehman) +- Set a DeviceFormat instance's type attribute to the requested type. (dlehman) +- Allow size specs that do not include a 'b' or 'B'. (#888851) (dlehman) +- Fix reference to 'factory' from within DeviceFactory class. (dlehman) +- Fix problems detecting lvm and md devices. (#914730) (dlehman) +- Allow passing size=None to device factories for unbounded growth. (dlehman) +- Provide a way to set the default fstype for a Blivet instance. (#838145) (dlehman) +- Allow changing the size of encrypted devices via DeviceFactory. (#913169) (dlehman) +- Don't dump storage state except in installer mode. (dlehman) +- Fix device resolution for btrfs. (dlehman) +- Fix device resolution to find named md devices. (dlehman) +- Account for active mounts in normal mode. (#914898) (dlehman) +- Add an example script which lists all devices. (dlehman) +- Add scripts/makeupdates script (bcl) + +* Thu Feb 21 2013 Brian C. Lane - 0.7-1 +- Merge branch 'master' of git+ssh://git.fedorahosted.org/git/blivet (bcl) +- Bring in productName from pyanaconda in installer mode. (#913559) (dlehman) + +* Wed Feb 20 2013 Brian C. Lane - 0.6-1 +- parse buffer output from resize (#913141) (bcl) +- prevent traceback when root device is not defined #rhbz883768 (sbueno+anaconda) +- Move empty_disk to a top-level function, and rename. (clumens) +- Add some high-level comments to DeviceFactory.configure_device. (dlehman) +- Refactor DeviceFactory.set_container_members for clarity. (dlehman) +- Rename the main blivet logger from "storage" to "blivet". (dlehman) +- Use the blivet domain for translations. (dlehman) +- Move DeviceFactory classes and related code into a new file. (dlehman) +- New version: 0.5 (dlehman) + +* Fri Feb 08 2013 David Lehman - 0.5-1 +- Add mountOnly to turnOnFilesystems (bcl) +- Update lvm scanning to account for new ignored device handling. (dlehman) +- Scan in all devices and then hide those that use ignored disks. (dlehman) +- Adjust child counts correctly when unhiding a device. (dlehman) +- Generate lvm config args each time they're needed/used. (dlehman) +- Add ability to grab 70-anaconda.rules udev data directly. (dlehman) +- Add support for active luks mappings at populate time. (dlehman) +- Don't require nss, required only for escrow key support. (dlehman) +- Update the TODO list. (dlehman) +- Add missing constant DMI_CHASSIS_VENDOR. (dlehman) +- Allow for multiple calls to DeviceTree.processActions. (#881023,#846573) (dlehman) +- Use CGit snaphot URL for Source in specfile. (dlehman) +- Streamline some logic in storageInitialize. (dlehman) +- Don't re-add deleted or hidden devices during DeviceTree.populate. (dlehman) +- Only run findExistingInstallations and start iscsi, &c in installer mode. (dlehman) +- Do not change device status during populate in normal mode. (#817064) (dlehman) +- Drop old code related to saving clearPartType from pre-f18. (dlehman) +- check for skipping bootloader in doIt (bcl) +- check for stage1 when not installing bootloader (#882065,#895232) (bcl) +- explicitly detect iso9660 on a disk (#903158) (bcl) +- Fix several problems in python-blivet.spec. (dlehman) +- Remove #!/usr/bin/python from tsort.py (dlehman) +- Update COPYING file. (dlehman) +- Add a Requires for dmidecode on x86. (dlehman) + +* Sun Jan 20 2013 David Lehman - 0.4-1 +- Use a two-part version number instead of three. (dlehman) +- Rename the rpm package from blivet to python-blivet. (dlehman) +- Move get_mount_device, get_mount_paths from pyanaconda.packaging to util. (dlehman) +- Update the TODO list. (dlehman) +- Carry over s390 exclusion of fcoe-utils from anaconda. (dlehman) +- Enable translations via transifex. (dlehman) + +* Fri Jan 18 2013 David Lehman - 0.2-1 +- Add Requires: iscsi-initiator-utils, fcoe-utils, device-mapper-multipath. (dlehman) +- Use a threading lock to control program log output. (dlehman) +- Fix reference to data to refer to ksdata in Blivet constructor. (dlehman) +- Remove the loop around proc.communicate in util._run_program. (dlehman) + +* Tue Jan 15 2013 David Lehman 0.2-1 +- Updated source from final pre-split anaconda source. +- Renamed pyanaconda.storage to blivet throughout. +- Updated spec file to include runtime Requires. + +* Fri Jan 04 2013 David Lehman 0.1-1 +- Created package from anaconda storage module.