From 1d11a1125d7a5445071a60dfd1cc4118ed4fc7ea Mon Sep 17 00:00:00 2001 From: MSVSphere Packaging Team Date: Fri, 29 Mar 2024 16:13:20 +0300 Subject: [PATCH] import python-blivet-3.6.0-8.el8 --- .gitignore | 2 + .python-blivet.metadata | 2 + SOURCES/0001-force-lvm-cli.plugin | 35 + SOURCES/0002-remove-btrfs-plugin.patch | 28 + ...03-Revert-More-consistent-lvm-errors.patch | 330 ++ .../0004-Revert-Terminology-cleanups.patch | 899 +++++ .../0005-DDF-RAID-support-using-mdadm.patch | 86 + ...rt-Remove-the-Blivet.roots-attribute.patch | 77 + ...tributeError-when-getting-stratis-bl.patch | 45 + ...kip-XFS-resize-test-on-CentOS-RHEL-8.patch | 27 + ...09-Revert-Adjust-to-new-XFS-min-size.patch | 160 + ...tImplementedError-for-btrfs-plugin-c.patch | 55 + ...ption-sector-size-512-for-LUKS-devic.patch | 57 + ...-specifying-stripe-size-for-RAID-LVs.patch | 172 + SOURCES/0013-Fix-setting-kickstart-data.patch | 68 + ...y-limit-for-LUKS2-when-running-in-FI.patch | 133 + ...support-for-filesystem-online-resize.patch | 265 ++ ...t-iSCSI-initiator-name-related-fixes.patch | 382 ++ ...pport-for-creating-shared-LVM-setups.patch | 206 + SPECS/python-blivet.spec | 3312 +++++++++++++++++ 20 files changed, 6341 insertions(+) create mode 100644 .gitignore create mode 100644 .python-blivet.metadata create mode 100644 SOURCES/0001-force-lvm-cli.plugin create mode 100644 SOURCES/0002-remove-btrfs-plugin.patch create mode 100644 SOURCES/0003-Revert-More-consistent-lvm-errors.patch create mode 100644 SOURCES/0004-Revert-Terminology-cleanups.patch create mode 100644 SOURCES/0005-DDF-RAID-support-using-mdadm.patch create mode 100644 SOURCES/0006-Revert-Remove-the-Blivet.roots-attribute.patch create mode 100644 SOURCES/0007-Fix-potential-AttributeError-when-getting-stratis-bl.patch create mode 100644 SOURCES/0008-tests-Skip-XFS-resize-test-on-CentOS-RHEL-8.patch create mode 100644 SOURCES/0009-Revert-Adjust-to-new-XFS-min-size.patch create mode 100644 SOURCES/0010-Catch-BlockDevNotImplementedError-for-btrfs-plugin-c.patch create mode 100644 SOURCES/0011-Default-to-encryption-sector-size-512-for-LUKS-devic.patch create mode 100644 SOURCES/0012-Add-support-for-specifying-stripe-size-for-RAID-LVs.patch create mode 100644 SOURCES/0013-Fix-setting-kickstart-data.patch create mode 100644 SOURCES/0014-Do-not-set-memory-limit-for-LUKS2-when-running-in-FI.patch create mode 100644 SOURCES/0015-Add-support-for-filesystem-online-resize.patch create mode 100644 SOURCES/0016-Backport-iSCSI-initiator-name-related-fixes.patch create mode 100644 SOURCES/0017-Add-support-for-creating-shared-LVM-setups.patch create mode 100644 SPECS/python-blivet.spec diff --git a/.gitignore b/.gitignore new file mode 100644 index 0000000..a37b47e --- /dev/null +++ b/.gitignore @@ -0,0 +1,2 @@ +SOURCES/blivet-3.6.0-tests.tar.gz +SOURCES/blivet-3.6.0.tar.gz diff --git a/.python-blivet.metadata b/.python-blivet.metadata new file mode 100644 index 0000000..a41a028 --- /dev/null +++ b/.python-blivet.metadata @@ -0,0 +1,2 @@ +8393baa22cb433d1012e3923ad0bc232401116c6 SOURCES/blivet-3.6.0-tests.tar.gz +e9d95c1165703fed3da1f35a9199197bfff68f98 SOURCES/blivet-3.6.0.tar.gz diff --git a/SOURCES/0001-force-lvm-cli.plugin b/SOURCES/0001-force-lvm-cli.plugin new file mode 100644 index 0000000..3af1d94 --- /dev/null +++ b/SOURCES/0001-force-lvm-cli.plugin @@ -0,0 +1,35 @@ +From 83ccc9f9f14845fcce7a5ba5fa21fbb97b1dbbb7 Mon Sep 17 00:00:00 2001 +From: Vojtech Trefny +Date: Wed, 11 Jul 2018 15:36:24 +0200 +Subject: [PATCH] Force command line based libblockdev LVM plugin + +--- + blivet/__init__.py | 9 +++++++-- + 1 file changed, 7 insertions(+), 2 deletions(-) + +diff --git a/blivet/__init__.py b/blivet/__init__.py +index dd8d0f54..62cc539a 100644 +--- a/blivet/__init__.py ++++ b/blivet/__init__.py +@@ -63,11 +63,16 @@ gi.require_version("BlockDev", "2.0") + from gi.repository import GLib + from gi.repository import BlockDev as blockdev + if arch.is_s390(): +- _REQUESTED_PLUGIN_NAMES = set(("lvm", "btrfs", "swap", "crypto", "loop", "mdraid", "mpath", "dm", "s390", "nvdimm")) ++ _REQUESTED_PLUGIN_NAMES = set(("btrfs", "swap", "crypto", "loop", "mdraid", "mpath", "dm", "s390", "nvdimm")) + else: +- _REQUESTED_PLUGIN_NAMES = set(("lvm", "btrfs", "swap", "crypto", "loop", "mdraid", "mpath", "dm", "nvdimm")) ++ _REQUESTED_PLUGIN_NAMES = set(("btrfs", "swap", "crypto", "loop", "mdraid", "mpath", "dm", "nvdimm")) + + _requested_plugins = blockdev.plugin_specs_from_names(_REQUESTED_PLUGIN_NAMES) ++# XXX force non-dbus LVM plugin ++lvm_plugin = blockdev.PluginSpec() ++lvm_plugin.name = blockdev.Plugin.LVM ++lvm_plugin.so_name = "libbd_lvm.so.2" ++_requested_plugins.append(lvm_plugin) + try: + # do not check for dependencies during libblockdev initializtion, do runtime + # checks instead +-- +2.38.1 + diff --git a/SOURCES/0002-remove-btrfs-plugin.patch b/SOURCES/0002-remove-btrfs-plugin.patch new file mode 100644 index 0000000..26182ae --- /dev/null +++ b/SOURCES/0002-remove-btrfs-plugin.patch @@ -0,0 +1,28 @@ +From c098d4112635b3ea55d5bd7e1817edbd519735fc Mon Sep 17 00:00:00 2001 +From: Vojtech Trefny +Date: Mon, 16 Jul 2018 14:26:11 +0200 +Subject: [PATCH] Remove btrfs from requested libblockdev plugins + +--- + blivet/__init__.py | 4 ++-- + 1 file changed, 2 insertions(+), 2 deletions(-) + +diff --git a/blivet/__init__.py b/blivet/__init__.py +index 62cc539a..bbc7ea3a 100644 +--- a/blivet/__init__.py ++++ b/blivet/__init__.py +@@ -63,9 +63,9 @@ gi.require_version("BlockDev", "2.0") + from gi.repository import GLib + from gi.repository import BlockDev as blockdev + if arch.is_s390(): +- _REQUESTED_PLUGIN_NAMES = set(("btrfs", "swap", "crypto", "loop", "mdraid", "mpath", "dm", "s390", "nvdimm")) ++ _REQUESTED_PLUGIN_NAMES = set(("swap", "crypto", "loop", "mdraid", "mpath", "dm", "s390", "nvdimm")) + else: +- _REQUESTED_PLUGIN_NAMES = set(("btrfs", "swap", "crypto", "loop", "mdraid", "mpath", "dm", "nvdimm")) ++ _REQUESTED_PLUGIN_NAMES = set(("swap", "crypto", "loop", "mdraid", "mpath", "dm", "nvdimm")) + + _requested_plugins = blockdev.plugin_specs_from_names(_REQUESTED_PLUGIN_NAMES) + # XXX force non-dbus LVM plugin +-- +2.38.1 + diff --git a/SOURCES/0003-Revert-More-consistent-lvm-errors.patch b/SOURCES/0003-Revert-More-consistent-lvm-errors.patch new file mode 100644 index 0000000..f6dd209 --- /dev/null +++ b/SOURCES/0003-Revert-More-consistent-lvm-errors.patch @@ -0,0 +1,330 @@ +From f6f90805020d7c6ac46f17a13a00f319fc4351f6 Mon Sep 17 00:00:00 2001 +From: Vojtech Trefny +Date: Wed, 26 May 2021 12:15:54 +0200 +Subject: [PATCH] Revert "More consistent lvm errors (API break)" + +This reverts commit 49ec071c6d0673224a0774d613904387c52c7381. +--- + blivet/devices/lvm.py | 72 +++++++++++------------ + tests/unit_tests/devices_test/lvm_test.py | 14 ++--- + 2 files changed, 43 insertions(+), 43 deletions(-) + +diff --git a/blivet/devices/lvm.py b/blivet/devices/lvm.py +index 38e49e18..b8595d63 100644 +--- a/blivet/devices/lvm.py ++++ b/blivet/devices/lvm.py +@@ -304,7 +304,7 @@ class LVMVolumeGroupDevice(ContainerDevice): + def _add_log_vol(self, lv): + """ Add an LV to this VG. """ + if lv in self._lvs: +- raise errors.DeviceError("lv is already part of this vg") ++ raise ValueError("lv is already part of this vg") + + # verify we have the space, then add it + # do not verify for growing vg (because of ks) +@@ -337,7 +337,7 @@ class LVMVolumeGroupDevice(ContainerDevice): + def _remove_log_vol(self, lv): + """ Remove an LV from this VG. """ + if lv not in self.lvs: +- raise errors.DeviceError("specified lv is not part of this vg") ++ raise ValueError("specified lv is not part of this vg") + + self._lvs.remove(lv) + +@@ -430,7 +430,7 @@ class LVMVolumeGroupDevice(ContainerDevice): + @thpool_reserve.setter + def thpool_reserve(self, value): + if value is not None and not isinstance(value, ThPoolReserveSpec): +- raise AttributeError("Invalid thpool_reserve given, must be of type ThPoolReserveSpec") ++ raise ValueError("Invalid thpool_reserve given, must be of type ThPoolReserveSpec") + self._thpool_reserve = value + + @property +@@ -665,14 +665,14 @@ class LVMLogicalVolumeBase(DMDevice, RaidDevice): + if seg_type not in [None, "linear", "thin", "thin-pool", "cache", "vdo-pool", "vdo", "cache-pool"] + lvm.raid_seg_types: + raise ValueError("Invalid or unsupported segment type: %s" % seg_type) + if seg_type and seg_type in lvm.raid_seg_types and not pvs: +- raise errors.DeviceError("List of PVs has to be given for every non-linear LV") ++ raise ValueError("List of PVs has to be given for every non-linear LV") + elif (not seg_type or seg_type == "linear") and pvs: + if not all(isinstance(pv, LVPVSpec) for pv in pvs): +- raise errors.DeviceError("Invalid specification of PVs for a linear LV: either no or complete " +- "specification (with all space split into PVs has to be given") ++ raise ValueError("Invalid specification of PVs for a linear LV: either no or complete " ++ "specification (with all space split into PVs has to be given") + elif sum(spec.size for spec in pvs) != size: +- raise errors.DeviceError("Invalid specification of PVs for a linear LV: the sum of space " +- "assigned to PVs is not equal to the size of the LV") ++ raise ValueError("Invalid specification of PVs for a linear LV: the sum of space " ++ "assigned to PVs is not equal to the size of the LV") + + # When this device's format is set in the superclass constructor it will + # try to access self.snapshots. +@@ -721,13 +721,13 @@ class LVMLogicalVolumeBase(DMDevice, RaidDevice): + self._from_lvs = from_lvs + if self._from_lvs: + if exists: +- raise errors.DeviceError("Only new LVs can be created from other LVs") ++ raise ValueError("Only new LVs can be created from other LVs") + if size or maxsize or percent: +- raise errors.DeviceError("Cannot specify size for a converted LV") ++ raise ValueError("Cannot specify size for a converted LV") + if fmt: +- raise errors.DeviceError("Cannot specify format for a converted LV") ++ raise ValueError("Cannot specify format for a converted LV") + if any(lv.vg != self.vg for lv in self._from_lvs): +- raise errors.DeviceError("Conversion of LVs only possible inside a VG") ++ raise ValueError("Conversion of LVs only possible inside a VG") + + self._cache = None + if cache_request and not self.exists: +@@ -746,13 +746,13 @@ class LVMLogicalVolumeBase(DMDevice, RaidDevice): + elif isinstance(pv_spec, StorageDevice): + self._pv_specs.append(LVPVSpec(pv_spec, Size(0))) + else: +- raise AttributeError("Invalid PV spec '%s' for the '%s' LV" % (pv_spec, self.name)) ++ raise ValueError("Invalid PV spec '%s' for the '%s' LV" % (pv_spec, self.name)) + # Make sure any destination PVs are actually PVs in this VG + if not set(spec.pv for spec in self._pv_specs).issubset(set(self.vg.parents)): + missing = [r.name for r in + set(spec.pv for spec in self._pv_specs).difference(set(self.vg.parents))] + msg = "invalid destination PV(s) %s for LV %s" % (missing, self.name) +- raise errors.DeviceError(msg) ++ raise ValueError(msg) + if self._pv_specs: + self._assign_pv_space() + +@@ -1130,7 +1130,7 @@ class LVMLogicalVolumeBase(DMDevice, RaidDevice): + else: + msg = "the specified internal LV '%s' doesn't belong to this LV ('%s')" % (int_lv.lv_name, + self.name) +- raise errors.DeviceError(msg) ++ raise ValueError(msg) + + def populate_ksdata(self, data): + super(LVMLogicalVolumeBase, self).populate_ksdata(data) +@@ -1229,7 +1229,7 @@ class LVMInternalLogicalVolumeMixin(object): + def _init_check(self): + # an internal LV should have no parents + if self._parent_lv and self._parents: +- raise errors.DeviceError("an internal LV should have no parents") ++ raise ValueError("an internal LV should have no parents") + + @property + def is_internal_lv(self): +@@ -1289,7 +1289,7 @@ class LVMInternalLogicalVolumeMixin(object): + + @readonly.setter + def readonly(self, value): # pylint: disable=unused-argument +- raise errors.DeviceError("Cannot make an internal LV read-write") ++ raise ValueError("Cannot make an internal LV read-write") + + @property + def type(self): +@@ -1325,7 +1325,7 @@ class LVMInternalLogicalVolumeMixin(object): + def _check_parents(self): + # an internal LV should have no parents + if self._parents: +- raise errors.DeviceError("an internal LV should have no parents") ++ raise ValueError("an internal LV should have no parents") + + def _add_to_parents(self): + # nothing to do here, an internal LV has no parents (in the DeviceTree's +@@ -1335,13 +1335,13 @@ class LVMInternalLogicalVolumeMixin(object): + # internal LVs follow different rules limitting size + def _set_size(self, newsize): + if not isinstance(newsize, Size): +- raise AttributeError("new size must of type Size") ++ raise ValueError("new size must of type Size") + + if not self.takes_extra_space: + if newsize <= self.parent_lv.size: # pylint: disable=no-member + self._size = newsize # pylint: disable=attribute-defined-outside-init + else: +- raise errors.DeviceError("Internal LV cannot be bigger than its parent LV") ++ raise ValueError("Internal LV cannot be bigger than its parent LV") + else: + # same rules apply as for any other LV + raise NotTypeSpecific() +@@ -1419,18 +1419,18 @@ class LVMSnapshotMixin(object): + return + + if self.origin and not isinstance(self.origin, LVMLogicalVolumeDevice): +- raise errors.DeviceError("lvm snapshot origin must be a logical volume") ++ raise ValueError("lvm snapshot origin must be a logical volume") + if self.vorigin and not self.exists: +- raise errors.DeviceError("only existing vorigin snapshots are supported") ++ raise ValueError("only existing vorigin snapshots are supported") + + if isinstance(self.origin, LVMLogicalVolumeDevice) and \ + isinstance(self.parents[0], LVMVolumeGroupDevice) and \ + self.origin.vg != self.parents[0]: +- raise errors.DeviceError("lvm snapshot and origin must be in the same vg") ++ raise ValueError("lvm snapshot and origin must be in the same vg") + + if self.is_thin_lv: + if self.origin and self.size and not self.exists: +- raise errors.DeviceError("thin snapshot size is determined automatically") ++ raise ValueError("thin snapshot size is determined automatically") + + @property + def is_snapshot_lv(self): +@@ -1606,7 +1606,7 @@ class LVMThinPoolMixin(object): + def _check_from_lvs(self): + if self._from_lvs: + if len(self._from_lvs) != 2: +- raise errors.DeviceError("two LVs required to create a thin pool") ++ raise ValueError("two LVs required to create a thin pool") + + def _convert_from_lvs(self): + data_lv, metadata_lv = self._from_lvs +@@ -1652,7 +1652,7 @@ class LVMThinPoolMixin(object): + def _add_log_vol(self, lv): + """ Add an LV to this pool. """ + if lv in self._lvs: +- raise errors.DeviceError("lv is already part of this vg") ++ raise ValueError("lv is already part of this vg") + + # TODO: add some checking to prevent overcommit for preexisting + self.vg._add_log_vol(lv) +@@ -1663,7 +1663,7 @@ class LVMThinPoolMixin(object): + def _remove_log_vol(self, lv): + """ Remove an LV from this pool. """ + if lv not in self._lvs: +- raise errors.DeviceError("specified lv is not part of this vg") ++ raise ValueError("specified lv is not part of this vg") + + self._lvs.remove(lv) + self.vg._remove_log_vol(lv) +@@ -1772,14 +1772,14 @@ class LVMThinLogicalVolumeMixin(object): + """Check that this device has parents as expected""" + if isinstance(self.parents, (list, ParentList)): + if len(self.parents) != 1: +- raise errors.DeviceError("constructor requires a single thin-pool LV") ++ raise ValueError("constructor requires a single thin-pool LV") + + container = self.parents[0] + else: + container = self.parents + + if not container or not isinstance(container, LVMLogicalVolumeDevice) or not container.is_thin_pool: +- raise errors.DeviceError("constructor requires a thin-pool LV") ++ raise ValueError("constructor requires a thin-pool LV") + + @property + def is_thin_lv(self): +@@ -1816,7 +1816,7 @@ class LVMThinLogicalVolumeMixin(object): + + def _set_size(self, newsize): + if not isinstance(newsize, Size): +- raise AttributeError("new size must of type Size") ++ raise ValueError("new size must of type Size") + + newsize = self.vg.align(newsize) + newsize = self.vg.align(util.numeric_type(newsize)) +@@ -2499,7 +2499,7 @@ class LVMLogicalVolumeDevice(LVMLogicalVolumeBase, LVMInternalLogicalVolumeMixin + container = self.parents + + if not isinstance(container, LVMVolumeGroupDevice): +- raise AttributeError("constructor requires a LVMVolumeGroupDevice") ++ raise ValueError("constructor requires a LVMVolumeGroupDevice") + + @type_specific + def _add_to_parents(self): +@@ -2510,12 +2510,12 @@ class LVMLogicalVolumeDevice(LVMLogicalVolumeBase, LVMInternalLogicalVolumeMixin + @type_specific + def _check_from_lvs(self): + """Check the LVs to create this LV from""" +- raise errors.DeviceError("Cannot create a new LV of type '%s' from other LVs" % self.seg_type) ++ raise ValueError("Cannot create a new LV of type '%s' from other LVs" % self.seg_type) + + @type_specific + def _convert_from_lvs(self): + """Convert the LVs to create this LV from into its internal LVs""" +- raise errors.DeviceError("Cannot create a new LV of type '%s' from other LVs" % self.seg_type) ++ raise ValueError("Cannot create a new LV of type '%s' from other LVs" % self.seg_type) + + @property + def external_dependencies(self): +@@ -2535,7 +2535,7 @@ class LVMLogicalVolumeDevice(LVMLogicalVolumeBase, LVMInternalLogicalVolumeMixin + @type_specific + def _set_size(self, newsize): + if not isinstance(newsize, Size): +- raise AttributeError("new size must be of type Size") ++ raise ValueError("new size must be of type Size") + + newsize = self.vg.align(newsize) + log.debug("trying to set lv %s size to %s", self.name, newsize) +@@ -2544,7 +2544,7 @@ class LVMLogicalVolumeDevice(LVMLogicalVolumeBase, LVMInternalLogicalVolumeMixin + # space for it. A similar reasoning applies to shrinking the LV. + if not self.exists and newsize > self.size and newsize > self.vg.free_space + self.vg_space_used: + log.error("failed to set size: %s short", newsize - (self.vg.free_space + self.vg_space_used)) +- raise errors.DeviceError("not enough free space in volume group") ++ raise ValueError("not enough free space in volume group") + + LVMLogicalVolumeBase._set_size(self, newsize) + +@@ -2910,7 +2910,7 @@ class LVMCache(Cache): + spec.size = spec.pv.format.free + space_to_assign -= spec.pv.format.free + if space_to_assign > 0: +- raise errors.DeviceError("Not enough free space in the PVs for this cache: %s short" % space_to_assign) ++ raise ValueError("Not enough free space in the PVs for this cache: %s short" % space_to_assign) + + @property + def size(self): +diff --git a/tests/unit_tests/devices_test/lvm_test.py b/tests/unit_tests/devices_test/lvm_test.py +index 47613fdc..995c2da4 100644 +--- a/tests/unit_tests/devices_test/lvm_test.py ++++ b/tests/unit_tests/devices_test/lvm_test.py +@@ -32,10 +32,10 @@ class LVMDeviceTest(unittest.TestCase): + lv = LVMLogicalVolumeDevice("testlv", parents=[vg], + fmt=blivet.formats.get_format("xfs")) + +- with six.assertRaisesRegex(self, errors.DeviceError, "lvm snapshot origin must be a logical volume"): ++ with six.assertRaisesRegex(self, ValueError, "lvm snapshot origin must be a logical volume"): + LVMLogicalVolumeDevice("snap1", parents=[vg], origin=pv) + +- with six.assertRaisesRegex(self, errors.DeviceError, "only existing vorigin snapshots are supported"): ++ with six.assertRaisesRegex(self, ValueError, "only existing vorigin snapshots are supported"): + LVMLogicalVolumeDevice("snap1", parents=[vg], vorigin=True) + + lv.exists = True +@@ -60,7 +60,7 @@ class LVMDeviceTest(unittest.TestCase): + pool = LVMLogicalVolumeDevice("pool1", parents=[vg], size=Size("500 MiB"), seg_type="thin-pool") + thinlv = LVMLogicalVolumeDevice("thinlv", parents=[pool], size=Size("200 MiB"), seg_type="thin") + +- with six.assertRaisesRegex(self, errors.DeviceError, "lvm snapshot origin must be a logical volume"): ++ with six.assertRaisesRegex(self, ValueError, "lvm snapshot origin must be a logical volume"): + LVMLogicalVolumeDevice("snap1", parents=[pool], origin=pv, seg_type="thin") + + # now make the constructor succeed so we can test some properties +@@ -310,21 +310,21 @@ class LVMDeviceTest(unittest.TestCase): + vg = LVMVolumeGroupDevice("testvg", parents=[pv, pv2]) + + # pvs have to be specified for non-linear LVs +- with self.assertRaises(errors.DeviceError): ++ with self.assertRaises(ValueError): + lv = LVMLogicalVolumeDevice("testlv", parents=[vg], size=Size("512 MiB"), + fmt=blivet.formats.get_format("xfs"), + exists=False, seg_type="raid1") +- with self.assertRaises(errors.DeviceError): ++ with self.assertRaises(ValueError): + lv = LVMLogicalVolumeDevice("testlv", parents=[vg], size=Size("512 MiB"), + fmt=blivet.formats.get_format("xfs"), + exists=False, seg_type="striped") + + # no or complete specification has to be given for linear LVs +- with self.assertRaises(errors.DeviceError): ++ with self.assertRaises(ValueError): + lv = LVMLogicalVolumeDevice("testlv", parents=[vg], size=Size("512 MiB"), + fmt=blivet.formats.get_format("xfs"), + exists=False, pvs=[pv]) +- with self.assertRaises(errors.DeviceError): ++ with self.assertRaises(ValueError): + pv_spec = LVPVSpec(pv, Size("256 MiB")) + pv_spec2 = LVPVSpec(pv2, Size("250 MiB")) + lv = LVMLogicalVolumeDevice("testlv", parents=[vg], size=Size("512 MiB"), +-- +2.38.1 + diff --git a/SOURCES/0004-Revert-Terminology-cleanups.patch b/SOURCES/0004-Revert-Terminology-cleanups.patch new file mode 100644 index 0000000..8260a44 --- /dev/null +++ b/SOURCES/0004-Revert-Terminology-cleanups.patch @@ -0,0 +1,899 @@ +From d8a8d96450bf0d3458671b9b7d23d972aa540396 Mon Sep 17 00:00:00 2001 +From: Vojtech Trefny +Date: Wed, 26 May 2021 12:27:34 +0200 +Subject: [PATCH] Revert "Terminology cleanups" + +This reverts following commits: +- 3d46339fe9cf12e9082fcbe4dc5acc9f92617e8d +- 63c9c7165e5cdfa4a47dcf0ed9d717b71e7921f2 +- 8956b9af8a785ae25e0e7153d2ef0702ce2f567c +--- + blivet/devicefactory.py | 24 +++---- + blivet/devices/dm.py | 9 ++- + blivet/devices/loop.py | 20 +++--- + blivet/devices/luks.py | 26 ++++--- + blivet/errors.py | 2 +- + blivet/partitioning.py | 22 +++++- + blivet/populator/helpers/dm.py | 4 +- + blivet/populator/helpers/luks.py | 4 +- + blivet/populator/helpers/lvm.py | 2 +- + blivet/populator/helpers/mdraid.py | 14 ++-- + blivet/populator/helpers/multipath.py | 8 +-- + blivet/populator/populator.py | 67 ++++++++++--------- + blivet/threads.py | 3 +- + blivet/udev.py | 34 +++++----- + tests/unit_tests/devicefactory_test.py | 10 +-- + .../devices_test/device_size_test.py | 6 +- + tests/unit_tests/populator_test.py | 34 +++++----- + tests/unit_tests/udev_test.py | 12 ++-- + tests/vmtests/vmbackedtestcase.py | 2 +- + 19 files changed, 167 insertions(+), 136 deletions(-) + +diff --git a/blivet/devicefactory.py b/blivet/devicefactory.py +index 6f460f6d..90082c28 100644 +--- a/blivet/devicefactory.py ++++ b/blivet/devicefactory.py +@@ -859,12 +859,12 @@ class DeviceFactory(object): + parent_container.parents.remove(orig_device) + + if self.encrypted and isinstance(self.device, LUKSDevice) and \ +- self.raw_device.format.luks_version != self.luks_version: +- self.raw_device.format.luks_version = self.luks_version ++ self.device.slave.format.luks_version != self.luks_version: ++ self.device.slave.format.luks_version = self.luks_version + + if self.encrypted and isinstance(self.device, LUKSDevice) and \ +- self.raw_device.format.luks_sector_size != self.luks_sector_size: +- self.raw_device.format.luks_sector_size = self.luks_sector_size ++ self.device.slave.format.luks_sector_size != self.luks_sector_size: ++ self.device.slave.format.luks_sector_size = self.luks_sector_size + + def _set_name(self): + if not self.device_name: +@@ -1201,11 +1201,11 @@ class PartitionSetFactory(PartitionFactory): + container.parents.remove(member) + self.storage.destroy_device(member) + members.remove(member) +- self.storage.format_device(member.raw_device, ++ self.storage.format_device(member.slave, + get_format(self.fstype)) +- members.append(member.raw_device) ++ members.append(member.slave) + if container: +- container.parents.append(member.raw_device) ++ container.parents.append(member.slave) + + continue + +@@ -1227,10 +1227,10 @@ class PartitionSetFactory(PartitionFactory): + + continue + +- if member_encrypted and self.encrypted and self.luks_version != member.raw_device.format.luks_version: +- member.raw_device.format.luks_version = self.luks_version +- if member_encrypted and self.encrypted and self.luks_sector_size != member.raw_device.format.luks_sector_size: +- member.raw_device.format.luks_sector_size = self.luks_sector_size ++ if member_encrypted and self.encrypted and self.luks_version != member.slave.format.luks_version: ++ member.slave.format.luks_version = self.luks_version ++ if member_encrypted and self.encrypted and self.luks_sector_size != member.slave.format.luks_sector_size: ++ member.slave.format.luks_sector_size = self.luks_sector_size + + ## + # Prepare previously allocated member partitions for reallocation. +@@ -1290,7 +1290,7 @@ class PartitionSetFactory(PartitionFactory): + + if isinstance(member, LUKSDevice): + self.storage.destroy_device(member) +- member = member.raw_device ++ member = member.slave + + self.storage.destroy_device(member) + +diff --git a/blivet/devices/dm.py b/blivet/devices/dm.py +index 2f936170..ae25e8e6 100644 +--- a/blivet/devices/dm.py ++++ b/blivet/devices/dm.py +@@ -154,6 +154,11 @@ class DMDevice(StorageDevice): + log_method_call(self, self.name, status=self.status) + super(DMDevice, self)._set_name(value) + ++ @property ++ def slave(self): ++ """ This device's backing device. """ ++ return self.parents[0] ++ + + class DMLinearDevice(DMDevice): + _type = "dm-linear" +@@ -189,8 +194,8 @@ class DMLinearDevice(DMDevice): + """ Open, or set up, a device. """ + log_method_call(self, self.name, orig=orig, status=self.status, + controllable=self.controllable) +- parent_length = self.parents[0].current_size / LINUX_SECTOR_SIZE +- blockdev.dm.create_linear(self.name, self.parents[0].path, parent_length, ++ slave_length = self.slave.current_size / LINUX_SECTOR_SIZE ++ blockdev.dm.create_linear(self.name, self.slave.path, slave_length, + self.dm_uuid) + + def _post_setup(self): +diff --git a/blivet/devices/loop.py b/blivet/devices/loop.py +index 0f4d7775..78f88d7d 100644 +--- a/blivet/devices/loop.py ++++ b/blivet/devices/loop.py +@@ -73,7 +73,7 @@ class LoopDevice(StorageDevice): + + def update_name(self): + """ Update this device's name. """ +- if not self.parents[0].status: ++ if not self.slave.status: + # if the backing device is inactive, so are we + return self.name + +@@ -81,7 +81,7 @@ class LoopDevice(StorageDevice): + # if our name is loopN we must already be active + return self.name + +- name = blockdev.loop.get_loop_name(self.parents[0].path) ++ name = blockdev.loop.get_loop_name(self.slave.path) + if name.startswith("loop"): + self.name = name + +@@ -89,24 +89,24 @@ class LoopDevice(StorageDevice): + + @property + def status(self): +- return (self.parents[0].status and ++ return (self.slave.status and + self.name.startswith("loop") and +- blockdev.loop.get_loop_name(self.parents[0].path) == self.name) ++ blockdev.loop.get_loop_name(self.slave.path) == self.name) + + @property + def size(self): +- return self.parents[0].size ++ return self.slave.size + + def _pre_setup(self, orig=False): +- if not os.path.exists(self.parents[0].path): +- raise errors.DeviceError("specified file (%s) does not exist" % self.parents[0].path) ++ if not os.path.exists(self.slave.path): ++ raise errors.DeviceError("specified file (%s) does not exist" % self.slave.path) + return StorageDevice._pre_setup(self, orig=orig) + + def _setup(self, orig=False): + """ Open, or set up, a device. """ + log_method_call(self, self.name, orig=orig, status=self.status, + controllable=self.controllable) +- blockdev.loop.setup(self.parents[0].path) ++ blockdev.loop.setup(self.slave.path) + + def _post_setup(self): + StorageDevice._post_setup(self) +@@ -123,3 +123,7 @@ class LoopDevice(StorageDevice): + StorageDevice._post_teardown(self, recursive=recursive) + self.name = "tmploop%d" % self.id + self.sysfs_path = '' ++ ++ @property ++ def slave(self): ++ return self.parents[0] +diff --git a/blivet/devices/luks.py b/blivet/devices/luks.py +index 2eb1f130..5ab840ea 100644 +--- a/blivet/devices/luks.py ++++ b/blivet/devices/luks.py +@@ -66,13 +66,17 @@ class LUKSDevice(DMCryptDevice): + + @property + def raw_device(self): ++ return self.slave ++ ++ @property ++ def slave(self): + if self._has_integrity: + return self.parents[0].parents[0] + return self.parents[0] + + def _get_size(self): + if not self.exists: +- size = self.raw_device.size - crypto.LUKS_METADATA_SIZE ++ size = self.slave.size - crypto.LUKS_METADATA_SIZE + elif self.resizable and self.target_size != Size(0): + size = self.target_size + else: +@@ -80,8 +84,8 @@ class LUKSDevice(DMCryptDevice): + return size + + def _set_size(self, newsize): +- if not self.exists and not self.raw_device.exists: +- self.raw_device.size = newsize + crypto.LUKS_METADATA_SIZE ++ if not self.exists and not self.slave.exists: ++ self.slave.size = newsize + crypto.LUKS_METADATA_SIZE + + # just run the StorageDevice._set_size to make sure we are in the format limits + super(LUKSDevice, self)._set_size(newsize - crypto.LUKS_METADATA_SIZE) +@@ -108,22 +112,22 @@ class LUKSDevice(DMCryptDevice): + raise ValueError("size is smaller than the minimum for this device") + + # don't allow larger luks than size (or target size) of backing device +- if newsize > (self.raw_device.size - crypto.LUKS_METADATA_SIZE): ++ if newsize > (self.slave.size - crypto.LUKS_METADATA_SIZE): + log.error("requested size %s is larger than size of the backing device %s", +- newsize, self.raw_device.size) ++ newsize, self.slave.size) + raise ValueError("size is larger than the size of the backing device") + + if self.align_target_size(newsize) != newsize: + raise ValueError("new size would violate alignment requirements") + + def _get_target_size(self): +- return self.raw_device.format.target_size ++ return self.slave.format.target_size + + @property + def max_size(self): + """ The maximum size this luks device can be. Maximum is based on the + maximum size of the backing device. """ +- max_luks = self.raw_device.max_size - crypto.LUKS_METADATA_SIZE ++ max_luks = self.slave.max_size - crypto.LUKS_METADATA_SIZE + max_format = self.format.max_size + return min(max_luks, max_format) if max_format else max_luks + +@@ -131,7 +135,7 @@ class LUKSDevice(DMCryptDevice): + def resizable(self): + """ Can this device be resized? """ + return (self._resizable and self.exists and self.format.resizable and +- self.raw_device.resizable and not self._has_integrity) ++ self.slave.resizable and not self._has_integrity) + + def resize(self): + # size of LUKSDevice depends on size of the LUKS format on backing +@@ -139,7 +143,7 @@ class LUKSDevice(DMCryptDevice): + log_method_call(self, self.name, status=self.status) + + def _post_create(self): +- self.name = self.raw_device.format.map_name ++ self.name = self.slave.format.map_name + StorageDevice._post_create(self) + + def _post_teardown(self, recursive=False): +@@ -162,10 +166,10 @@ class LUKSDevice(DMCryptDevice): + self.name = new_name + + def dracut_setup_args(self): +- return set(["rd.luks.uuid=luks-%s" % self.raw_device.format.uuid]) ++ return set(["rd.luks.uuid=luks-%s" % self.slave.format.uuid]) + + def populate_ksdata(self, data): +- self.raw_device.populate_ksdata(data) ++ self.slave.populate_ksdata(data) + data.encrypted = True + super(LUKSDevice, self).populate_ksdata(data) + +diff --git a/blivet/errors.py b/blivet/errors.py +index b886ffec..30c9921a 100644 +--- a/blivet/errors.py ++++ b/blivet/errors.py +@@ -201,7 +201,7 @@ class DeviceTreeError(StorageError): + pass + + +-class NoParentsError(DeviceTreeError): ++class NoSlavesError(DeviceTreeError): + pass + + +diff --git a/blivet/partitioning.py b/blivet/partitioning.py +index ce77e4eb..2cd6554c 100644 +--- a/blivet/partitioning.py ++++ b/blivet/partitioning.py +@@ -32,7 +32,7 @@ import _ped + + from .errors import DeviceError, PartitioningError, AlignmentError + from .flags import flags +-from .devices import Device, PartitionDevice, device_path_to_name ++from .devices import Device, PartitionDevice, LUKSDevice, device_path_to_name + from .size import Size + from .i18n import _ + from .util import stringize, unicodeize, compare +@@ -1635,7 +1635,15 @@ class TotalSizeSet(object): + :param size: the target combined size + :type size: :class:`~.size.Size` + """ +- self.devices = [d.raw_device for d in devices] ++ self.devices = [] ++ for device in devices: ++ if isinstance(device, LUKSDevice): ++ partition = device.slave ++ else: ++ partition = device ++ ++ self.devices.append(partition) ++ + self.size = size + + self.requests = [] +@@ -1673,7 +1681,15 @@ class SameSizeSet(object): + :keyword max_size: the maximum size for growable devices + :type max_size: :class:`~.size.Size` + """ +- self.devices = [d.raw_device for d in devices] ++ self.devices = [] ++ for device in devices: ++ if isinstance(device, LUKSDevice): ++ partition = device.slave ++ else: ++ partition = device ++ ++ self.devices.append(partition) ++ + self.size = size / len(devices) + self.grow = grow + self.max_size = max_size +diff --git a/blivet/populator/helpers/dm.py b/blivet/populator/helpers/dm.py +index 4721390e..0ad065e2 100644 +--- a/blivet/populator/helpers/dm.py ++++ b/blivet/populator/helpers/dm.py +@@ -47,13 +47,13 @@ class DMDevicePopulator(DevicePopulator): + name = udev.device_get_name(self.data) + log_method_call(self, name=name) + sysfs_path = udev.device_get_sysfs_path(self.data) +- parent_devices = self._devicetree._add_parent_devices(self.data) ++ slave_devices = self._devicetree._add_slave_devices(self.data) + device = self._devicetree.get_device_by_name(name) + + if device is None: + device = DMDevice(name, dm_uuid=self.data.get('DM_UUID'), + sysfs_path=sysfs_path, exists=True, +- parents=[parent_devices[0]]) ++ parents=[slave_devices[0]]) + device.protected = True + device.controllable = False + self._devicetree._add_device(device) +diff --git a/blivet/populator/helpers/luks.py b/blivet/populator/helpers/luks.py +index 3221122a..9b5023f8 100644 +--- a/blivet/populator/helpers/luks.py ++++ b/blivet/populator/helpers/luks.py +@@ -43,7 +43,7 @@ class LUKSDevicePopulator(DevicePopulator): + return udev.device_is_dm_luks(data) + + def run(self): +- parents = self._devicetree._add_parent_devices(self.data) ++ parents = self._devicetree._add_slave_devices(self.data) + device = LUKSDevice(udev.device_get_name(self.data), + sysfs_path=udev.device_get_sysfs_path(self.data), + parents=parents, +@@ -58,7 +58,7 @@ class IntegrityDevicePopulator(DevicePopulator): + return udev.device_is_dm_integrity(data) + + def run(self): +- parents = self._devicetree._add_parent_devices(self.data) ++ parents = self._devicetree._add_slave_devices(self.data) + name = udev.device_get_name(self.data) + + try: +diff --git a/blivet/populator/helpers/lvm.py b/blivet/populator/helpers/lvm.py +index 6ef2f417..b549e8d3 100644 +--- a/blivet/populator/helpers/lvm.py ++++ b/blivet/populator/helpers/lvm.py +@@ -58,7 +58,7 @@ class LVMDevicePopulator(DevicePopulator): + log.warning("found non-vg device with name %s", vg_name) + device = None + +- self._devicetree._add_parent_devices(self.data) ++ self._devicetree._add_slave_devices(self.data) + + # LVM provides no means to resolve conflicts caused by duplicated VG + # names, so we're just being optimistic here. Woo! +diff --git a/blivet/populator/helpers/mdraid.py b/blivet/populator/helpers/mdraid.py +index a7602d20..9bec11ef 100644 +--- a/blivet/populator/helpers/mdraid.py ++++ b/blivet/populator/helpers/mdraid.py +@@ -31,7 +31,7 @@ from ... import udev + from ...devicelibs import raid + from ...devices import MDRaidArrayDevice, MDContainerDevice + from ...devices import device_path_to_name +-from ...errors import DeviceError, NoParentsError ++from ...errors import DeviceError, NoSlavesError + from ...flags import flags + from ...storage_log import log_method_call + from .devicepopulator import DevicePopulator +@@ -52,12 +52,12 @@ class MDDevicePopulator(DevicePopulator): + log_method_call(self, name=name) + + try: +- self._devicetree._add_parent_devices(self.data) +- except NoParentsError: +- log.error("no parents found for mdarray %s, skipping", name) ++ self._devicetree._add_slave_devices(self.data) ++ except NoSlavesError: ++ log.error("no slaves found for mdarray %s, skipping", name) + return None + +- # try to get the device again now that we've got all the parents ++ # try to get the device again now that we've got all the slaves + device = self._devicetree.get_device_by_name(name, incomplete=flags.allow_imperfect_devices) + + if device is None: +@@ -74,8 +74,8 @@ class MDDevicePopulator(DevicePopulator): + device.name = name + + if device is None: +- # if we get here, we found all of the parent devices and +- # something must be wrong -- if all of the parents are in ++ # if we get here, we found all of the slave devices and ++ # something must be wrong -- if all of the slaves are in + # the tree, this device should be as well + if name is None: + name = udev.device_get_name(self.data) +diff --git a/blivet/populator/helpers/multipath.py b/blivet/populator/helpers/multipath.py +index 96c0a9ad..10c745bf 100644 +--- a/blivet/populator/helpers/multipath.py ++++ b/blivet/populator/helpers/multipath.py +@@ -40,13 +40,13 @@ class MultipathDevicePopulator(DevicePopulator): + name = udev.device_get_name(self.data) + log_method_call(self, name=name) + +- parent_devices = self._devicetree._add_parent_devices(self.data) ++ slave_devices = self._devicetree._add_slave_devices(self.data) + + device = None +- if parent_devices: +- device = MultipathDevice(name, parents=parent_devices, ++ if slave_devices: ++ device = MultipathDevice(name, parents=slave_devices, + sysfs_path=udev.device_get_sysfs_path(self.data), +- wwn=parent_devices[0].wwn) ++ wwn=slave_devices[0].wwn) + self._devicetree._add_device(device) + + return device +diff --git a/blivet/populator/populator.py b/blivet/populator/populator.py +index 3a419418..068270b2 100644 +--- a/blivet/populator/populator.py ++++ b/blivet/populator/populator.py +@@ -31,7 +31,7 @@ gi.require_version("BlockDev", "2.0") + + from gi.repository import BlockDev as blockdev + +-from ..errors import DeviceError, DeviceTreeError, NoParentsError ++from ..errors import DeviceError, DeviceTreeError, NoSlavesError + from ..devices import DMLinearDevice, DMRaidArrayDevice + from ..devices import FileDevice, LoopDevice + from ..devices import MDRaidArrayDevice +@@ -92,55 +92,56 @@ class PopulatorMixin(object): + + self._cleanup = False + +- def _add_parent_devices(self, info): +- """ Add all parents of a device, raising DeviceTreeError on failure. ++ def _add_slave_devices(self, info): ++ """ Add all slaves of a device, raising DeviceTreeError on failure. + + :param :class:`pyudev.Device` info: the device's udev info +- :raises: :class:`~.errors.DeviceTreeError if no parents are found or +- if we fail to add any parent +- :returns: a list of parent devices ++ :raises: :class:`~.errors.DeviceTreeError if no slaves are found or ++ if we fail to add any slave ++ :returns: a list of slave devices + :rtype: list of :class:`~.StorageDevice` + """ + name = udev.device_get_name(info) + sysfs_path = udev.device_get_sysfs_path(info) +- parent_dir = os.path.normpath("%s/slaves" % sysfs_path) +- parent_names = os.listdir(parent_dir) +- parent_devices = [] +- if not parent_names: +- log.error("no parents found for %s", name) +- raise NoParentsError("no parents found for device %s" % name) +- +- for parent_name in parent_names: +- path = os.path.normpath("%s/%s" % (parent_dir, parent_name)) +- parent_info = udev.get_device(os.path.realpath(path)) +- +- if not parent_info: +- msg = "unable to get udev info for %s" % parent_name ++ slave_dir = os.path.normpath("%s/slaves" % sysfs_path) ++ slave_names = os.listdir(slave_dir) ++ slave_devices = [] ++ if not slave_names: ++ log.error("no slaves found for %s", name) ++ raise NoSlavesError("no slaves found for device %s" % name) ++ ++ for slave_name in slave_names: ++ path = os.path.normpath("%s/%s" % (slave_dir, slave_name)) ++ slave_info = udev.get_device(os.path.realpath(path)) ++ ++ if not slave_info: ++ msg = "unable to get udev info for %s" % slave_name + raise DeviceTreeError(msg) + + # cciss in sysfs is "cciss!cXdYpZ" but we need "cciss/cXdYpZ" +- parent_name = udev.device_get_name(parent_info).replace("!", "/") +- +- parent_dev = self.get_device_by_name(parent_name) +- if not parent_dev and parent_info: +- # we haven't scanned the parent yet, so do it now +- self.handle_device(parent_info) +- parent_dev = self.get_device_by_name(parent_name) +- if parent_dev is None: ++ slave_name = udev.device_get_name(slave_info).replace("!", "/") ++ ++ slave_dev = self.get_device_by_name(slave_name) ++ if not slave_dev and slave_info: ++ # we haven't scanned the slave yet, so do it now ++ self.handle_device(slave_info) ++ slave_dev = self.get_device_by_name(slave_name) ++ if slave_dev is None: + if udev.device_is_dm_lvm(info): +- if parent_name not in lvs_info.cache: ++ if slave_name not in lvs_info.cache: + # we do not expect hidden lvs to be in the tree + continue + +- # if the current parent is still not in ++ # if the current slave is still not in + # the tree, something has gone wrong +- log.error("failure scanning device %s: could not add parent %s", name, parent_name) +- msg = "failed to add parent %s of device %s" % (parent_name, name) ++ log.error("failure scanning device %s: could not add slave %s", name, slave_name) ++ msg = "failed to add slave %s of device %s" % (slave_name, ++ name) + raise DeviceTreeError(msg) + +- parent_devices.append(parent_dev) ++ slave_devices.append(slave_dev) + +- return parent_devices ++ return slave_devices + + def _add_name(self, name): + if name not in self.names: +diff --git a/blivet/threads.py b/blivet/threads.py +index 5e2dff3f..1a5cc6db 100644 +--- a/blivet/threads.py ++++ b/blivet/threads.py +@@ -63,11 +63,12 @@ class SynchronizedMeta(type): + """ + def __new__(cls, name, bases, dct): + new_dct = {} ++ blacklist = dct.get('_unsynchronized_methods', []) + + for n in dct: + obj = dct[n] + # Do not decorate class or static methods. +- if n in dct.get('_unsynchronized_methods', []): ++ if n in blacklist: + pass + elif isinstance(obj, FunctionType): + obj = exclusive(obj) +diff --git a/blivet/udev.py b/blivet/udev.py +index efbc53d6..ddc49a37 100644 +--- a/blivet/udev.py ++++ b/blivet/udev.py +@@ -39,7 +39,7 @@ from gi.repository import BlockDev as blockdev + global_udev = pyudev.Context() + log = logging.getLogger("blivet") + +-ignored_device_names = [] ++device_name_blacklist = [] + """ device name regexes to ignore; this should be empty by default """ + + +@@ -77,7 +77,7 @@ def get_devices(subsystem="block"): + + result = [] + for device in global_udev.list_devices(subsystem=subsystem): +- if not __is_ignored_blockdev(device.sys_name): ++ if not __is_blacklisted_blockdev(device.sys_name): + dev = device_to_dict(device) + result.append(dev) + +@@ -176,13 +176,13 @@ def resolve_glob(glob): + return ret + + +-def __is_ignored_blockdev(dev_name): ++def __is_blacklisted_blockdev(dev_name): + """Is this a blockdev we never want for an install?""" + if dev_name.startswith("ram") or dev_name.startswith("fd"): + return True + +- if ignored_device_names: +- if any(re.search(expr, dev_name) for expr in ignored_device_names): ++ if device_name_blacklist: ++ if any(re.search(expr, dev_name) for expr in device_name_blacklist): + return True + + dev_path = "/sys/class/block/%s" % dev_name +@@ -375,7 +375,7 @@ def device_is_disk(info): + device_is_dm_crypt(info) or + device_is_dm_stratis(info) or + (device_is_md(info) and +- (not device_get_md_container(info) and not all(device_is_disk(d) for d in device_get_parents(info)))))) ++ (not device_get_md_container(info) and not all(device_is_disk(d) for d in device_get_slaves(info)))))) + + + def device_is_partition(info): +@@ -454,18 +454,18 @@ def device_get_devname(info): + return info.get('DEVNAME') + + +-def device_get_parents(info): +- """ Return a list of udev device objects representing this device's parents. """ +- parents_dir = device_get_sysfs_path(info) + "/slaves/" ++def device_get_slaves(info): ++ """ Return a list of udev device objects representing this device's slaves. """ ++ slaves_dir = device_get_sysfs_path(info) + "/slaves/" + names = list() +- if os.path.isdir(parents_dir): +- names = os.listdir(parents_dir) ++ if os.path.isdir(slaves_dir): ++ names = os.listdir(slaves_dir) + +- parents = list() ++ slaves = list() + for name in names: +- parents.append(get_device(device_node="/dev/" + name)) ++ slaves.append(get_device(device_node="/dev/" + name)) + +- return parents ++ return slaves + + + def device_get_holders(info): +@@ -742,7 +742,7 @@ def device_get_partition_disk(info): + disk = None + majorminor = info.get("ID_PART_ENTRY_DISK") + sysfs_path = device_get_sysfs_path(info) +- parents_dir = "%s/slaves" % sysfs_path ++ slaves_dir = "%s/slaves" % sysfs_path + if majorminor: + major, minor = majorminor.split(":") + for device in get_devices(): +@@ -750,8 +750,8 @@ def device_get_partition_disk(info): + disk = device_get_name(device) + break + elif device_is_dm_partition(info): +- if os.path.isdir(parents_dir): +- parents = os.listdir(parents_dir) ++ if os.path.isdir(slaves_dir): ++ parents = os.listdir(slaves_dir) + if len(parents) == 1: + disk = resolve_devspec(parents[0].replace('!', '/')) + else: +diff --git a/tests/unit_tests/devicefactory_test.py b/tests/unit_tests/devicefactory_test.py +index ff6bcb9e..552aadc1 100644 +--- a/tests/unit_tests/devicefactory_test.py ++++ b/tests/unit_tests/devicefactory_test.py +@@ -115,9 +115,9 @@ class DeviceFactoryTestCase(unittest.TestCase): + kwargs.get("encrypted", False) or + kwargs.get("container_encrypted", False)) + if kwargs.get("encrypted", False): +- self.assertEqual(device.parents[0].format.luks_version, ++ self.assertEqual(device.slave.format.luks_version, + kwargs.get("luks_version", crypto.DEFAULT_LUKS_VERSION)) +- self.assertEqual(device.raw_device.format.luks_sector_size, ++ self.assertEqual(device.slave.format.luks_sector_size, + kwargs.get("luks_sector_size", 0)) + + self.assertTrue(set(device.disks).issubset(kwargs["disks"])) +@@ -357,7 +357,7 @@ class LVMFactoryTestCase(DeviceFactoryTestCase): + device = args[0] + + if kwargs.get("encrypted"): +- container = device.parents[0].container ++ container = device.slave.container + else: + container = device.container + +@@ -376,7 +376,7 @@ class LVMFactoryTestCase(DeviceFactoryTestCase): + self.assertIsInstance(pv, member_class) + + if pv.encrypted: +- self.assertEqual(pv.parents[0].format.luks_version, ++ self.assertEqual(pv.slave.format.luks_version, + kwargs.get("luks_version", crypto.DEFAULT_LUKS_VERSION)) + + @patch("blivet.formats.lvmpv.LVMPhysicalVolume.formattable", return_value=True) +@@ -592,7 +592,7 @@ class LVMThinPFactoryTestCase(LVMFactoryTestCase): + device = args[0] + + if kwargs.get("encrypted", False): +- thinlv = device.parents[0] ++ thinlv = device.slave + else: + thinlv = device + +diff --git a/tests/unit_tests/devices_test/device_size_test.py b/tests/unit_tests/devices_test/device_size_test.py +index d0c0a3f4..a1efa86d 100644 +--- a/tests/unit_tests/devices_test/device_size_test.py ++++ b/tests/unit_tests/devices_test/device_size_test.py +@@ -107,8 +107,8 @@ class LUKSDeviceSizeTest(StorageDeviceSizeTest): + + def _get_device(self, *args, **kwargs): + exists = kwargs.get("exists", False) +- parent = StorageDevice(*args, size=kwargs["size"] + crypto.LUKS_METADATA_SIZE, exists=exists) +- return LUKSDevice(*args, **kwargs, parents=[parent]) ++ slave = StorageDevice(*args, size=kwargs["size"] + crypto.LUKS_METADATA_SIZE, exists=exists) ++ return LUKSDevice(*args, **kwargs, parents=[slave]) + + def test_size_getter(self): + initial_size = Size("10 GiB") +@@ -116,4 +116,4 @@ class LUKSDeviceSizeTest(StorageDeviceSizeTest): + + # for LUKS size depends on the backing device size + self.assertEqual(dev.size, initial_size) +- self.assertEqual(dev.raw_device.size, initial_size + crypto.LUKS_METADATA_SIZE) ++ self.assertEqual(dev.slave.size, initial_size + crypto.LUKS_METADATA_SIZE) +diff --git a/tests/unit_tests/populator_test.py b/tests/unit_tests/populator_test.py +index 369fe878..7ba04bac 100644 +--- a/tests/unit_tests/populator_test.py ++++ b/tests/unit_tests/populator_test.py +@@ -86,7 +86,7 @@ class DMDevicePopulatorTestCase(PopulatorHelperTestCase): + @patch.object(DeviceTree, "get_device_by_name") + @patch.object(DMDevice, "status", return_value=True) + @patch.object(DMDevice, "update_sysfs_path") +- @patch.object(DeviceTree, "_add_parent_devices") ++ @patch.object(DeviceTree, "_add_slave_devices") + @patch("blivet.udev.device_get_name") + @patch("blivet.udev.device_get_sysfs_path", return_value=sentinel.sysfs_path) + def test_run(self, *args): +@@ -95,7 +95,7 @@ class DMDevicePopulatorTestCase(PopulatorHelperTestCase): + + devicetree = DeviceTree() + +- # The general case for dm devices is that adding the parent devices ++ # The general case for dm devices is that adding the slave/parent devices + # will result in the dm device itself being in the tree. + device = Mock() + device.id = 0 +@@ -106,7 +106,7 @@ class DMDevicePopulatorTestCase(PopulatorHelperTestCase): + parent = Mock() + parent.id = 0 + parent.parents = [] +- devicetree._add_parent_devices.return_value = [parent] ++ devicetree._add_slave_devices.return_value = [parent] + devicetree._add_device(parent) + devicetree.get_device_by_name.return_value = None + device_name = "dmdevice" +@@ -235,7 +235,7 @@ class LVMDevicePopulatorTestCase(PopulatorHelperTestCase): + # could be the first helper class checked. + + @patch.object(DeviceTree, "get_device_by_name") +- @patch.object(DeviceTree, "_add_parent_devices") ++ @patch.object(DeviceTree, "_add_slave_devices") + @patch("blivet.udev.device_get_name") + @patch("blivet.udev.device_get_lv_vg_name") + def test_run(self, *args): +@@ -247,7 +247,7 @@ class LVMDevicePopulatorTestCase(PopulatorHelperTestCase): + devicetree = DeviceTree() + data = Mock() + +- # Add parent devices and then look up the device. ++ # Add slave/parent devices and then look up the device. + device_get_name.return_value = sentinel.lv_name + devicetree.get_device_by_name.return_value = None + +@@ -267,7 +267,7 @@ class LVMDevicePopulatorTestCase(PopulatorHelperTestCase): + call(sentinel.vg_name), + call(sentinel.lv_name)]) + +- # Add parent devices, but the device is still not in the tree ++ # Add slave/parent devices, but the device is still not in the tree + get_device_by_name.side_effect = None + get_device_by_name.return_value = None + self.assertEqual(helper.run(), None) +@@ -639,7 +639,7 @@ class MDDevicePopulatorTestCase(PopulatorHelperTestCase): + # could be the first helper class checked. + + @patch.object(DeviceTree, "get_device_by_name") +- @patch.object(DeviceTree, "_add_parent_devices") ++ @patch.object(DeviceTree, "_add_slave_devices") + @patch("blivet.udev.device_get_name") + @patch("blivet.udev.device_get_md_uuid") + @patch("blivet.udev.device_get_md_name") +@@ -650,7 +650,7 @@ class MDDevicePopulatorTestCase(PopulatorHelperTestCase): + + devicetree = DeviceTree() + +- # base case: _add_parent_devices gets the array into the tree ++ # base case: _add_slave_devices gets the array into the tree + data = Mock() + device = Mock() + device.parents = [] +@@ -713,12 +713,12 @@ class MultipathDevicePopulatorTestCase(PopulatorHelperTestCase): + # could be the first helper class checked. + + @patch("blivet.udev.device_get_sysfs_path") +- @patch.object(DeviceTree, "_add_parent_devices") ++ @patch.object(DeviceTree, "_add_slave_devices") + @patch("blivet.udev.device_get_name") + def test_run(self, *args): + """Test multipath device populator.""" + device_get_name = args[0] +- add_parent_devices = args[1] ++ add_slave_devices = args[1] + + devicetree = DeviceTree() + # set up some fake udev data to verify handling of specific entries +@@ -733,13 +733,13 @@ class MultipathDevicePopulatorTestCase(PopulatorHelperTestCase): + + device_name = "mpathtest" + device_get_name.return_value = device_name +- parent_1 = Mock(tags=set(), wwn=wwn[2:], id=0) +- parent_1.parents = [] +- parent_2 = Mock(tags=set(), wwn=wwn[2:], id=0) +- parent_2.parents = [] +- devicetree._add_device(parent_1) +- devicetree._add_device(parent_2) +- add_parent_devices.return_value = [parent_1, parent_2] ++ slave_1 = Mock(tags=set(), wwn=wwn[2:], id=0) ++ slave_1.parents = [] ++ slave_2 = Mock(tags=set(), wwn=wwn[2:], id=0) ++ slave_2.parents = [] ++ devicetree._add_device(slave_1) ++ devicetree._add_device(slave_2) ++ add_slave_devices.return_value = [slave_1, slave_2] + + helper = self.helper_class(devicetree, data) + +diff --git a/tests/unit_tests/udev_test.py b/tests/unit_tests/udev_test.py +index b208efa8..ebcd59e2 100644 +--- a/tests/unit_tests/udev_test.py ++++ b/tests/unit_tests/udev_test.py +@@ -49,11 +49,11 @@ class UdevTest(unittest.TestCase): + @mock.patch('blivet.udev.device_is_dm_crypt', return_value=False) + @mock.patch('blivet.udev.device_is_md') + @mock.patch('blivet.udev.device_get_md_container') +- @mock.patch('blivet.udev.device_get_parents') ++ @mock.patch('blivet.udev.device_get_slaves') + def test_udev_device_is_disk_md(self, *args): + import blivet.udev + info = dict(DEVTYPE='disk', SYS_PATH=mock.sentinel.md_path) +- (device_get_parents, device_get_md_container, device_is_md) = args[:3] # pylint: disable=unbalanced-tuple-unpacking ++ (device_get_slaves, device_get_md_container, device_is_md) = args[:3] # pylint: disable=unbalanced-tuple-unpacking + + disk_parents = [dict(DEVTYPE="disk", SYS_PATH='/fake/path/2'), + dict(DEVTYPE="disk", SYS_PATH='/fake/path/3')] +@@ -68,20 +68,20 @@ class UdevTest(unittest.TestCase): + # Intel FW RAID (MD RAID w/ container layer) + # device_get_container will return some mock value which will evaluate to True + device_get_md_container.return_value = mock.sentinel.md_container +- device_get_parents.side_effect = lambda info: list() ++ device_get_slaves.side_effect = lambda info: list() + self.assertTrue(blivet.udev.device_is_disk(info)) + + # Normal MD RAID +- device_get_parents.side_effect = lambda info: partition_parents if info['SYS_PATH'] == mock.sentinel.md_path else list() ++ device_get_slaves.side_effect = lambda info: partition_parents if info['SYS_PATH'] == mock.sentinel.md_path else list() + device_get_md_container.return_value = None + self.assertFalse(blivet.udev.device_is_disk(info)) + + # Dell FW RAID (MD RAID whose members are all whole disks) +- device_get_parents.side_effect = lambda info: disk_parents if info['SYS_PATH'] == mock.sentinel.md_path else list() ++ device_get_slaves.side_effect = lambda info: disk_parents if info['SYS_PATH'] == mock.sentinel.md_path else list() + self.assertTrue(blivet.udev.device_is_disk(info)) + + # Normal MD RAID (w/ at least one non-disk member) +- device_get_parents.side_effect = lambda info: mixed_parents if info['SYS_PATH'] == mock.sentinel.md_path else list() ++ device_get_slaves.side_effect = lambda info: mixed_parents if info['SYS_PATH'] == mock.sentinel.md_path else list() + self.assertFalse(blivet.udev.device_is_disk(info)) + + +diff --git a/tests/vmtests/vmbackedtestcase.py b/tests/vmtests/vmbackedtestcase.py +index 797bac85..6255104f 100644 +--- a/tests/vmtests/vmbackedtestcase.py ++++ b/tests/vmtests/vmbackedtestcase.py +@@ -50,7 +50,7 @@ class VMBackedTestCase(unittest.TestCase): + defined in set_up_disks. + """ + +- udev.ignored_device_names = [r'^zram'] ++ udev.device_name_blacklist = [r'^zram'] + + # + # create disk images +-- +2.38.1 + diff --git a/SOURCES/0005-DDF-RAID-support-using-mdadm.patch b/SOURCES/0005-DDF-RAID-support-using-mdadm.patch new file mode 100644 index 0000000..1232d02 --- /dev/null +++ b/SOURCES/0005-DDF-RAID-support-using-mdadm.patch @@ -0,0 +1,86 @@ +From f6490c469904f4808c63a170210e53acc908b018 Mon Sep 17 00:00:00 2001 +From: Vojtech Trefny +Date: Wed, 17 Aug 2022 14:24:21 +0200 +Subject: [PATCH 1/2] Use MD populator instead of DM to handle DDF RAID format + +--- + blivet/formats/dmraid.py | 2 +- + blivet/formats/mdraid.py | 2 +- + 2 files changed, 2 insertions(+), 2 deletions(-) + +diff --git a/blivet/formats/dmraid.py b/blivet/formats/dmraid.py +index 2ba9dcfe..ce15905d 100644 +--- a/blivet/formats/dmraid.py ++++ b/blivet/formats/dmraid.py +@@ -43,7 +43,7 @@ class DMRaidMember(DeviceFormat): + # + # One problem that presents is the possibility of someone passing + # a dmraid member to the MDRaidArrayDevice constructor. +- _udev_types = ["adaptec_raid_member", "ddf_raid_member", ++ _udev_types = ["adaptec_raid_member", + "hpt37x_raid_member", "hpt45x_raid_member", + "isw_raid_member", + "jmicron_raid_member", "lsi_mega_raid_member", +diff --git a/blivet/formats/mdraid.py b/blivet/formats/mdraid.py +index 41ddef81..4aa3f3b0 100644 +--- a/blivet/formats/mdraid.py ++++ b/blivet/formats/mdraid.py +@@ -41,7 +41,7 @@ class MDRaidMember(DeviceFormat): + """ An mdraid member disk. """ + _type = "mdmember" + _name = N_("software RAID") +- _udev_types = ["linux_raid_member"] ++ _udev_types = ["linux_raid_member", "ddf_raid_member"] + parted_flag = PARTITION_RAID + _formattable = True # can be formatted + _supported = True # is supported +-- +2.38.1 + + +From 5fadd850aae217d7692a6c8a50b2dcd5e61a63cd Mon Sep 17 00:00:00 2001 +From: Vojtech Trefny +Date: Wed, 17 Aug 2022 14:24:58 +0200 +Subject: [PATCH 2/2] Do not read DDF RAID UUID from udev + +The UUID we get from udev isn't the array UUID, we need to get +that using libblockdev. +--- + blivet/populator/helpers/mdraid.py | 16 ++++++++++------ + 1 file changed, 10 insertions(+), 6 deletions(-) + +diff --git a/blivet/populator/helpers/mdraid.py b/blivet/populator/helpers/mdraid.py +index 3479e3f7..a7602d20 100644 +--- a/blivet/populator/helpers/mdraid.py ++++ b/blivet/populator/helpers/mdraid.py +@@ -98,17 +98,21 @@ class MDFormatPopulator(FormatPopulator): + + def _get_kwargs(self): + kwargs = super(MDFormatPopulator, self)._get_kwargs() +- try: +- # ID_FS_UUID contains the array UUID +- kwargs["md_uuid"] = udev.device_get_uuid(self.data) +- except KeyError: +- log.warning("mdraid member %s has no md uuid", udev.device_get_name(self.data)) ++ kwargs["biosraid"] = udev.device_is_biosraid_member(self.data) ++ if not kwargs["biosraid"]: ++ try: ++ # ID_FS_UUID contains the array UUID ++ kwargs["md_uuid"] = udev.device_get_uuid(self.data) ++ except KeyError: ++ log.warning("mdraid member %s has no md uuid", udev.device_get_name(self.data)) ++ else: ++ # for BIOS RAIDs we can't get the UUID from udev, we'll get it from mdadm in `run` below ++ kwargs["md_uuid"] = None + + # reset the uuid to the member-specific value + # this will be None for members of v0 metadata arrays + kwargs["uuid"] = udev.device_get_md_device_uuid(self.data) + +- kwargs["biosraid"] = udev.device_is_biosraid_member(self.data) + return kwargs + + def run(self): +-- +2.38.1 + diff --git a/SOURCES/0006-Revert-Remove-the-Blivet.roots-attribute.patch b/SOURCES/0006-Revert-Remove-the-Blivet.roots-attribute.patch new file mode 100644 index 0000000..76f3db8 --- /dev/null +++ b/SOURCES/0006-Revert-Remove-the-Blivet.roots-attribute.patch @@ -0,0 +1,77 @@ +From 62af1d7f96b8ed8eb8f2732787576161ae5da79f Mon Sep 17 00:00:00 2001 +From: Vojtech Trefny +Date: Thu, 13 Oct 2022 10:47:52 +0200 +Subject: [PATCH] Revert "Remove the Blivet.roots attribute" + +This reverts commit 19a826073345ca6b57a8f9a95ec855892320300e. +--- + blivet/blivet.py | 21 +++++++++++++++++++++ + blivet/devicefactory.py | 3 +++ + 2 files changed, 24 insertions(+) + +diff --git a/blivet/blivet.py b/blivet/blivet.py +index bf72ee9c..dc066b03 100644 +--- a/blivet/blivet.py ++++ b/blivet/blivet.py +@@ -88,6 +88,7 @@ class Blivet(object): + self.devicetree = DeviceTree(ignored_disks=self.ignored_disks, + exclusive_disks=self.exclusive_disks, + disk_images=self.disk_images) ++ self.roots = [] + + @property + def short_product_name(self): +@@ -1314,5 +1315,25 @@ class Blivet(object): + p = partition.disk.format.parted_disk.getPartitionByPath(partition.path) + partition.parted_partition = p + ++ for root in new.roots: ++ root.swaps = [new.devicetree.get_device_by_id(d.id, hidden=True) for d in root.swaps] ++ root.swaps = [s for s in root.swaps if s] ++ ++ removed = set() ++ for (mountpoint, old_dev) in root.mounts.items(): ++ if old_dev is None: ++ continue ++ ++ new_dev = new.devicetree.get_device_by_id(old_dev.id, hidden=True) ++ if new_dev is None: ++ # if the device has been removed don't include this ++ # mountpoint at all ++ removed.add(mountpoint) ++ else: ++ root.mounts[mountpoint] = new_dev ++ ++ for mnt in removed: ++ del root.mounts[mnt] ++ + log.debug("finished Blivet copy") + return new +diff --git a/blivet/devicefactory.py b/blivet/devicefactory.py +index 8105bfc7..6f460f6d 100644 +--- a/blivet/devicefactory.py ++++ b/blivet/devicefactory.py +@@ -383,6 +383,7 @@ class DeviceFactory(object): + # used for error recovery + self.__devices = [] + self.__actions = [] ++ self.__roots = [] + + def _is_container_encrypted(self): + return all(isinstance(p, LUKSDevice) for p in self.device.container.parents) +@@ -994,10 +995,12 @@ class DeviceFactory(object): + _blivet_copy = self.storage.copy() + self.__devices = _blivet_copy.devicetree._devices + self.__actions = _blivet_copy.devicetree._actions ++ self.__roots = _blivet_copy.roots + + def _revert_devicetree(self): + self.storage.devicetree._devices = self.__devices + self.storage.devicetree._actions = self.__actions ++ self.storage.roots = self.__roots + + + class PartitionFactory(DeviceFactory): +-- +2.38.1 + diff --git a/SOURCES/0007-Fix-potential-AttributeError-when-getting-stratis-bl.patch b/SOURCES/0007-Fix-potential-AttributeError-when-getting-stratis-bl.patch new file mode 100644 index 0000000..e117038 --- /dev/null +++ b/SOURCES/0007-Fix-potential-AttributeError-when-getting-stratis-bl.patch @@ -0,0 +1,45 @@ +From 1561bfe8820118178bbb07021adc1cacd875c4c7 Mon Sep 17 00:00:00 2001 +From: Vojtech Trefny +Date: Tue, 18 Oct 2022 12:28:37 +0200 +Subject: [PATCH] Fix potential AttributeError when getting stratis blockdev + info + +--- + blivet/static_data/stratis_info.py | 12 +++++++----- + 1 file changed, 7 insertions(+), 5 deletions(-) + +diff --git a/blivet/static_data/stratis_info.py b/blivet/static_data/stratis_info.py +index bd1c5a18..42f230ee 100644 +--- a/blivet/static_data/stratis_info.py ++++ b/blivet/static_data/stratis_info.py +@@ -124,20 +124,22 @@ class StratisInfo(object): + log.error("Failed to get DBus properties of '%s'", blockdev_path) + return None + ++ blockdev_uuid = str(uuid.UUID(properties["Uuid"])) ++ + pool_path = properties["Pool"] + if pool_path == "/": + pool_name = "" ++ return StratisBlockdevInfo(path=properties["Devnode"], uuid=blockdev_uuid, ++ pool_name="", pool_uuid="", object_path=blockdev_path) + else: + pool_info = self._get_pool_info(properties["Pool"]) + if not pool_info: + return None + pool_name = pool_info.name + +- blockdev_uuid = str(uuid.UUID(properties["Uuid"])) +- +- return StratisBlockdevInfo(path=properties["Devnode"], uuid=blockdev_uuid, +- pool_name=pool_name, pool_uuid=pool_info.uuid, +- object_path=blockdev_path) ++ return StratisBlockdevInfo(path=properties["Devnode"], uuid=blockdev_uuid, ++ pool_name=pool_name, pool_uuid=pool_info.uuid, ++ object_path=blockdev_path) + + def _get_locked_pools_info(self): + locked_pools = [] +-- +2.38.1 + diff --git a/SOURCES/0008-tests-Skip-XFS-resize-test-on-CentOS-RHEL-8.patch b/SOURCES/0008-tests-Skip-XFS-resize-test-on-CentOS-RHEL-8.patch new file mode 100644 index 0000000..634eead --- /dev/null +++ b/SOURCES/0008-tests-Skip-XFS-resize-test-on-CentOS-RHEL-8.patch @@ -0,0 +1,27 @@ +From b747c4ed07937f54a546ffb2f2c8c95e0797dd6c Mon Sep 17 00:00:00 2001 +From: Vojtech Trefny +Date: Thu, 20 Oct 2022 15:19:29 +0200 +Subject: [PATCH] tests: Skip XFS resize test on CentOS/RHEL 8 + +Partitions on loop devices are broken on CentOS/RHEL 8. +--- + tests/skip.yml | 6 ++++++ + 1 file changed, 6 insertions(+) + +diff --git a/tests/skip.yml b/tests/skip.yml +index 568c3fff..66b34493 100644 +--- a/tests/skip.yml ++++ b/tests/skip.yml +@@ -29,3 +29,9 @@ + - distro: "centos" + version: "9" + reason: "Creating RAID 1 LV on CentOS/RHEL 9 causes a system deadlock" ++ ++- test: storage_tests.formats_test.fs_test.XFSTestCase.test_resize ++ skip_on: ++ - distro: ["centos", "enterprise_linux"] ++ version: "8" ++ reason: "Creating partitions on loop devices is broken on CentOS/RHEL 8 latest kernel" +-- +2.37.3 + diff --git a/SOURCES/0009-Revert-Adjust-to-new-XFS-min-size.patch b/SOURCES/0009-Revert-Adjust-to-new-XFS-min-size.patch new file mode 100644 index 0000000..167fd2d --- /dev/null +++ b/SOURCES/0009-Revert-Adjust-to-new-XFS-min-size.patch @@ -0,0 +1,160 @@ +From 9618b84f94187efddc7316c2546bed923a91ecf9 Mon Sep 17 00:00:00 2001 +From: Vojtech Trefny +Date: Thu, 3 Nov 2022 08:36:27 +0100 +Subject: [PATCH 1/2] Revert "Set XFS minimal size to 300 MiB" + +This reverts commit 307d49833771d161314bae50c68e70dc35c3bb36. +--- + blivet/formats/fs.py | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/blivet/formats/fs.py b/blivet/formats/fs.py +index 8c346aa5..33922f3a 100644 +--- a/blivet/formats/fs.py ++++ b/blivet/formats/fs.py +@@ -1091,7 +1091,7 @@ class XFS(FS): + _modules = ["xfs"] + _labelfs = fslabeling.XFSLabeling() + _uuidfs = fsuuid.XFSUUID() +- _min_size = Size("300 MiB") ++ _min_size = Size("16 MiB") + _max_size = Size("16 EiB") + _formattable = True + _linux_native = True +-- +2.38.1 + + +From 24d94922d6879baa85aaa101f6b21efa568a9cbc Mon Sep 17 00:00:00 2001 +From: Vojtech Trefny +Date: Thu, 3 Nov 2022 08:36:39 +0100 +Subject: [PATCH 2/2] Revert "tests: Create bigger devices for XFS testing" + +This reverts commit 467cb8024010b2cabb1e92d9e64f6d3cbe949ad9. +--- + tests/storage_tests/formats_test/fs_test.py | 7 +++---- + tests/storage_tests/formats_test/fslabeling.py | 4 +--- + tests/storage_tests/formats_test/fsuuid.py | 4 +--- + tests/storage_tests/formats_test/labeling_test.py | 2 -- + tests/storage_tests/formats_test/uuid_test.py | 3 --- + 5 files changed, 5 insertions(+), 15 deletions(-) + +diff --git a/tests/storage_tests/formats_test/fs_test.py b/tests/storage_tests/formats_test/fs_test.py +index cf8fb441..97f4cbbe 100644 +--- a/tests/storage_tests/formats_test/fs_test.py ++++ b/tests/storage_tests/formats_test/fs_test.py +@@ -54,7 +54,6 @@ class ReiserFSTestCase(fstesting.FSAsRoot): + + class XFSTestCase(fstesting.FSAsRoot): + _fs_class = fs.XFS +- _DEVICE_SIZE = Size("500 MiB") + + def can_resize(self, an_fs): + resize_tasks = (an_fs._resize, an_fs._size_info) +@@ -96,12 +95,12 @@ class XFSTestCase(fstesting.FSAsRoot): + self.assertFalse(an_fs.resizable) + # Not resizable, so can not do resizing actions. + with self.assertRaises(DeviceFormatError): +- an_fs.target_size = Size("300 MiB") ++ an_fs.target_size = Size("64 MiB") + with self.assertRaises(DeviceFormatError): + an_fs.do_resize() + else: + disk = DiskDevice(os.path.basename(self.loop_devices[0])) +- part = self._create_partition(disk, Size("300 MiB")) ++ part = self._create_partition(disk, Size("50 MiB")) + an_fs = self._fs_class() + an_fs.device = part.path + self.assertIsNone(an_fs.create()) +@@ -114,7 +113,7 @@ class XFSTestCase(fstesting.FSAsRoot): + part = self._create_partition(disk, size=part.size + Size("40 MiB")) + + # Try a reasonable target size +- TARGET_SIZE = Size("325 MiB") ++ TARGET_SIZE = Size("64 MiB") + an_fs.target_size = TARGET_SIZE + self.assertEqual(an_fs.target_size, TARGET_SIZE) + self.assertNotEqual(an_fs._size, TARGET_SIZE) +diff --git a/tests/storage_tests/formats_test/fslabeling.py b/tests/storage_tests/formats_test/fslabeling.py +index ebe0b70a..0e0dc261 100644 +--- a/tests/storage_tests/formats_test/fslabeling.py ++++ b/tests/storage_tests/formats_test/fslabeling.py +@@ -21,10 +21,8 @@ class LabelingAsRoot(loopbackedtestcase.LoopBackedTestCase): + _invalid_label = abc.abstractproperty( + doc="A label which is invalid for this filesystem.") + +- _DEVICE_SIZE = Size("100 MiB") +- + def __init__(self, methodName='run_test'): +- super(LabelingAsRoot, self).__init__(methodName=methodName, device_spec=[self._DEVICE_SIZE]) ++ super(LabelingAsRoot, self).__init__(methodName=methodName, device_spec=[Size("100 MiB")]) + + def setUp(self): + an_fs = self._fs_class() +diff --git a/tests/storage_tests/formats_test/fsuuid.py b/tests/storage_tests/formats_test/fsuuid.py +index 0b9762fd..16aa19a6 100644 +--- a/tests/storage_tests/formats_test/fsuuid.py ++++ b/tests/storage_tests/formats_test/fsuuid.py +@@ -23,11 +23,9 @@ class SetUUID(loopbackedtestcase.LoopBackedTestCase): + _invalid_uuid = abc.abstractproperty( + doc="An invalid UUID for this filesystem.") + +- _DEVICE_SIZE = Size("100 MiB") +- + def __init__(self, methodName='run_test'): + super(SetUUID, self).__init__(methodName=methodName, +- device_spec=[self._DEVICE_SIZE]) ++ device_spec=[Size("100 MiB")]) + + def setUp(self): + an_fs = self._fs_class() +diff --git a/tests/storage_tests/formats_test/labeling_test.py b/tests/storage_tests/formats_test/labeling_test.py +index 0702260a..d24e6619 100644 +--- a/tests/storage_tests/formats_test/labeling_test.py ++++ b/tests/storage_tests/formats_test/labeling_test.py +@@ -1,7 +1,6 @@ + import unittest + + from blivet.formats import device_formats +-from blivet.size import Size + import blivet.formats.fs as fs + import blivet.formats.swap as swap + +@@ -62,7 +61,6 @@ class InitializationTestCase(unittest.TestCase): + class XFSTestCase(fslabeling.CompleteLabelingAsRoot): + _fs_class = fs.XFS + _invalid_label = "root filesystem" +- _DEVICE_SIZE = Size("500 MiB") + + + class FATFSTestCase(fslabeling.CompleteLabelingAsRoot): +diff --git a/tests/storage_tests/formats_test/uuid_test.py b/tests/storage_tests/formats_test/uuid_test.py +index af35c0ee..ee8d452e 100644 +--- a/tests/storage_tests/formats_test/uuid_test.py ++++ b/tests/storage_tests/formats_test/uuid_test.py +@@ -2,7 +2,6 @@ import unittest + + import blivet.formats.fs as fs + import blivet.formats.swap as swap +-from blivet.size import Size + + from . import fsuuid + +@@ -53,14 +52,12 @@ class XFSTestCase(fsuuid.SetUUIDWithMkFs): + _fs_class = fs.XFS + _invalid_uuid = "abcdefgh-ijkl-mnop-qrst-uvwxyz123456" + _valid_uuid = "97e3d40f-dca8-497d-8b86-92f257402465" +- _DEVICE_SIZE = Size("500 MiB") + + + class XFSAfterTestCase(fsuuid.SetUUIDAfterMkFs): + _fs_class = fs.XFS + _invalid_uuid = "abcdefgh-ijkl-mnop-qrst-uvwxyz123456" + _valid_uuid = "97e3d40f-dca8-497d-8b86-92f257402465" +- _DEVICE_SIZE = Size("500 MiB") + + + class FATFSTestCase(fsuuid.SetUUIDWithMkFs): +-- +2.38.1 + diff --git a/SOURCES/0010-Catch-BlockDevNotImplementedError-for-btrfs-plugin-c.patch b/SOURCES/0010-Catch-BlockDevNotImplementedError-for-btrfs-plugin-c.patch new file mode 100644 index 0000000..a3a5f90 --- /dev/null +++ b/SOURCES/0010-Catch-BlockDevNotImplementedError-for-btrfs-plugin-c.patch @@ -0,0 +1,55 @@ +From fed62af06eb1584adbacd821dfe79c2df52c6aa4 Mon Sep 17 00:00:00 2001 +From: Vojtech Trefny +Date: Wed, 2 Nov 2022 12:14:28 +0100 +Subject: [PATCH] Catch BlockDevNotImplementedError for btrfs plugin calls + +This is a workaround for RHEL where the btrfs plugin is not +available and where we might still try to call some libblockdev +functions to gather information about preexisting btrfs devices. +--- + blivet/devices/btrfs.py | 8 ++++---- + 1 file changed, 4 insertions(+), 4 deletions(-) + +diff --git a/blivet/devices/btrfs.py b/blivet/devices/btrfs.py +index 0e029715..1ae6a04d 100644 +--- a/blivet/devices/btrfs.py ++++ b/blivet/devices/btrfs.py +@@ -362,7 +362,7 @@ class BTRFSVolumeDevice(BTRFSDevice, ContainerDevice, RaidDevice): + try: + subvols = blockdev.btrfs.list_subvolumes(mountpoint, + snapshots_only=snapshots_only) +- except blockdev.BtrfsError as e: ++ except (blockdev.BtrfsError, blockdev.BlockDevNotImplementedError) as e: + log.debug("failed to list subvolumes: %s", e) + else: + self._get_default_subvolume_id() +@@ -400,7 +400,7 @@ class BTRFSVolumeDevice(BTRFSDevice, ContainerDevice, RaidDevice): + with self._do_temp_mount() as mountpoint: + try: + subvolid = blockdev.btrfs.get_default_subvolume_id(mountpoint) +- except blockdev.BtrfsError as e: ++ except (blockdev.BtrfsError, blockdev.BlockDevNotImplementedError) as e: + log.debug("failed to get default subvolume id: %s", e) + + self._default_subvolume_id = subvolid +@@ -413,7 +413,7 @@ class BTRFSVolumeDevice(BTRFSDevice, ContainerDevice, RaidDevice): + with self._do_temp_mount() as mountpoint: + try: + blockdev.btrfs.set_default_subvolume(mountpoint, vol_id) +- except blockdev.BtrfsError as e: ++ except (blockdev.BtrfsError, blockdev.BlockDevNotImplementedError) as e: + log.error("failed to set new default subvolume id (%s): %s", + vol_id, e) + # The only time we set a new default subvolume is so we can remove +@@ -471,7 +471,7 @@ class BTRFSVolumeDevice(BTRFSDevice, ContainerDevice, RaidDevice): + if not self.format.vol_uuid: + try: + bd_info = blockdev.btrfs.filesystem_info(self.parents[0].path) +- except blockdev.BtrfsError as e: ++ except (blockdev.BtrfsError, blockdev.BlockDevNotImplementedError) as e: + log.error("failed to get filesystem info for new btrfs volume %s", e) + else: + self.format.vol_uuid = bd_info.uuid +-- +2.38.1 + diff --git a/SOURCES/0011-Default-to-encryption-sector-size-512-for-LUKS-devic.patch b/SOURCES/0011-Default-to-encryption-sector-size-512-for-LUKS-devic.patch new file mode 100644 index 0000000..ed3ede5 --- /dev/null +++ b/SOURCES/0011-Default-to-encryption-sector-size-512-for-LUKS-devic.patch @@ -0,0 +1,57 @@ +From 2aba050e74dc5df483da022dcf436b101c7a4301 Mon Sep 17 00:00:00 2001 +From: Vojtech Trefny +Date: Wed, 11 Jan 2023 14:59:24 +0100 +Subject: [PATCH] Default to encryption sector size 512 for LUKS devices + +We are currently letting cryptsetup decide the optimal encryption +sector size for LUKS. The problem is that for disks with physical +sector size 4096 cryptsetup will default to 4096 encryption sector +size even if the drive logical sector size is 512 which means +these disks cannot be combined with other 512 logical sector size +disks in LVM. This requires a more sophisticated solution in the +future, but for now just default to 512 if not specified by the +user otherwise. + +Resolves: rhbz#2103800 +--- + blivet/formats/luks.py | 10 +++++++--- + tests/unit_tests/formats_tests/luks_test.py | 2 +- + 2 files changed, 8 insertions(+), 4 deletions(-) + +diff --git a/blivet/formats/luks.py b/blivet/formats/luks.py +index 8de4911f..2637e0c5 100644 +--- a/blivet/formats/luks.py ++++ b/blivet/formats/luks.py +@@ -166,9 +166,13 @@ class LUKS(DeviceFormat): + if self.pbkdf_args.type == "pbkdf2" and self.pbkdf_args.max_memory_kb: + log.warning("Memory limit is not used for pbkdf2 and it will be ignored.") + +- self.luks_sector_size = kwargs.get("luks_sector_size") or 0 +- if self.luks_sector_size and self.luks_version != "luks2": +- raise ValueError("Sector size argument is valid only for LUKS version 2.") ++ self.luks_sector_size = kwargs.get("luks_sector_size") ++ if self.luks_version == "luks2": ++ if self.luks_sector_size is None: ++ self.luks_sector_size = 512 # XXX we don't want cryptsetup choose automatically here so fallback to 512 ++ else: ++ if self.luks_sector_size: ++ raise ValueError("Sector size argument is valid only for LUKS version 2.") + + def __repr__(self): + s = DeviceFormat.__repr__(self) +diff --git a/tests/unit_tests/formats_tests/luks_test.py b/tests/unit_tests/formats_tests/luks_test.py +index 5ae6acfe..ec7b7592 100644 +--- a/tests/unit_tests/formats_tests/luks_test.py ++++ b/tests/unit_tests/formats_tests/luks_test.py +@@ -53,7 +53,7 @@ class LUKSNodevTestCase(unittest.TestCase): + + def test_sector_size(self): + fmt = LUKS() +- self.assertEqual(fmt.luks_sector_size, 0) ++ self.assertEqual(fmt.luks_sector_size, 512) + + with self.assertRaises(ValueError): + fmt = LUKS(luks_version="luks1", luks_sector_size=4096) +-- +2.39.0 + diff --git a/SOURCES/0012-Add-support-for-specifying-stripe-size-for-RAID-LVs.patch b/SOURCES/0012-Add-support-for-specifying-stripe-size-for-RAID-LVs.patch new file mode 100644 index 0000000..12eb181 --- /dev/null +++ b/SOURCES/0012-Add-support-for-specifying-stripe-size-for-RAID-LVs.patch @@ -0,0 +1,172 @@ +From 11c3e695d9a2130f325bb5459a9881ff70338f71 Mon Sep 17 00:00:00 2001 +From: Vojtech Trefny +Date: Thu, 9 Mar 2023 13:18:42 +0100 +Subject: [PATCH] Add support for specifying stripe size for RAID LVs + +--- + blivet/devices/lvm.py | 28 +++++++++++++++++--- + tests/storage_tests/devices_test/lvm_test.py | 12 +++++++-- + tests/unit_tests/devices_test/lvm_test.py | 27 +++++++++++++++++++ + 3 files changed, 61 insertions(+), 6 deletions(-) + +diff --git a/blivet/devices/lvm.py b/blivet/devices/lvm.py +index b8595d63..41358e9b 100644 +--- a/blivet/devices/lvm.py ++++ b/blivet/devices/lvm.py +@@ -659,7 +659,8 @@ class LVMLogicalVolumeBase(DMDevice, RaidDevice): + + def __init__(self, name, parents=None, size=None, uuid=None, seg_type=None, + fmt=None, exists=False, sysfs_path='', grow=None, maxsize=None, +- percent=None, cache_request=None, pvs=None, from_lvs=None): ++ percent=None, cache_request=None, pvs=None, from_lvs=None, ++ stripe_size=0): + + if not exists: + if seg_type not in [None, "linear", "thin", "thin-pool", "cache", "vdo-pool", "vdo", "cache-pool"] + lvm.raid_seg_types: +@@ -756,6 +757,15 @@ class LVMLogicalVolumeBase(DMDevice, RaidDevice): + if self._pv_specs: + self._assign_pv_space() + ++ self._stripe_size = stripe_size ++ if not self.exists and self._stripe_size: ++ if self.seg_type not in lvm.raid_seg_types: ++ raise errors.DeviceError("Stripe size can be specified only for RAID volumes") ++ if self.seg_type in ("raid1", "RAID1", "1", 1, "mirror"): ++ raise errors.DeviceError("Specifying stripe size is not allowed for RAID1 or mirror") ++ if self.cache: ++ raise errors.DeviceError("Creating cached LVs with custom stripe size is not supported") ++ + def _assign_pv_space(self): + if not self.is_raid_lv: + # nothing to do for non-RAID (and thus non-striped) LVs here +@@ -2295,7 +2305,7 @@ class LVMLogicalVolumeDevice(LVMLogicalVolumeBase, LVMInternalLogicalVolumeMixin + parent_lv=None, int_type=None, origin=None, vorigin=False, + metadata_size=None, chunk_size=None, profile=None, from_lvs=None, + compression=False, deduplication=False, index_memory=0, +- write_policy=None, cache_mode=None, attach_to=None): ++ write_policy=None, cache_mode=None, attach_to=None, stripe_size=0): + """ + :param name: the device name (generally a device node's basename) + :type name: str +@@ -2375,6 +2385,11 @@ class LVMLogicalVolumeDevice(LVMLogicalVolumeBase, LVMInternalLogicalVolumeMixin + be attached to when created + :type attach_to: :class:`LVMLogicalVolumeDevice` + ++ For RAID LVs only: ++ ++ :keyword stripe_size: size of the RAID stripe ++ :type stripe_size: :class:`~.size.Size` ++ + """ + + if isinstance(parents, (list, ParentList)): +@@ -2395,7 +2410,8 @@ class LVMLogicalVolumeDevice(LVMLogicalVolumeBase, LVMInternalLogicalVolumeMixin + LVMCachePoolMixin.__init__(self, metadata_size, cache_mode, attach_to) + LVMLogicalVolumeBase.__init__(self, name, parents, size, uuid, seg_type, + fmt, exists, sysfs_path, grow, maxsize, +- percent, cache_request, pvs, from_lvs) ++ percent, cache_request, pvs, from_lvs, ++ stripe_size) + LVMVDOPoolMixin.__init__(self, compression, deduplication, index_memory, + write_policy) + LVMVDOLogicalVolumeMixin.__init__(self) +@@ -2651,8 +2667,12 @@ class LVMLogicalVolumeDevice(LVMLogicalVolumeBase, LVMInternalLogicalVolumeMixin + pvs = [spec.pv.path for spec in self._pv_specs] + pvs = pvs or None + ++ extra = dict() ++ if self._stripe_size: ++ extra["stripesize"] = str(int(self._stripe_size.convert_to("KiB"))) ++ + blockdev.lvm.lvcreate(self.vg.name, self._name, self.size, +- type=self.seg_type, pv_list=pvs) ++ type=self.seg_type, pv_list=pvs, **extra) + else: + fast_pvs = [pv.path for pv in self.cache.fast_pvs] + +diff --git a/tests/storage_tests/devices_test/lvm_test.py b/tests/storage_tests/devices_test/lvm_test.py +index a055fc27..97ef1c4b 100644 +--- a/tests/storage_tests/devices_test/lvm_test.py ++++ b/tests/storage_tests/devices_test/lvm_test.py +@@ -1,4 +1,5 @@ + import os ++import subprocess + + from ..storagetestcase import StorageTestCase + +@@ -127,7 +128,7 @@ class LVMTestCase(StorageTestCase): + self.assertTrue(snap.is_snapshot_lv) + self.assertEqual(snap.origin, thinlv) + +- def _test_lvm_raid(self, seg_type, raid_level): ++ def _test_lvm_raid(self, seg_type, raid_level, stripe_size=0): + disk1 = self.storage.devicetree.get_device_by_path(self.vdevs[0]) + self.assertIsNotNone(disk1) + self.storage.initialize_disk(disk1) +@@ -151,7 +152,7 @@ class LVMTestCase(StorageTestCase): + + raidlv = self.storage.new_lv(fmt_type="ext4", size=blivet.size.Size("50 MiB"), + parents=[vg], name="blivetTestRAIDLV", +- seg_type=seg_type, pvs=[pv1, pv2]) ++ seg_type=seg_type, pvs=[pv1, pv2], stripe_size=stripe_size) + self.storage.create_device(raidlv) + + self.storage.do_it() +@@ -163,9 +164,16 @@ class LVMTestCase(StorageTestCase): + self.assertEqual(raidlv.raid_level, raid_level) + self.assertEqual(raidlv.seg_type, seg_type) + ++ if stripe_size: ++ out = subprocess.check_output(["lvs", "-o", "stripe_size", "--noheadings", "--nosuffix", "--units=b", raidlv.vg.name + "/" + raidlv.lvname]) ++ self.assertEqual(out.decode().strip(), str(int(stripe_size.convert_to()))) ++ + def test_lvm_raid_raid0(self): + self._test_lvm_raid("raid0", blivet.devicelibs.raid.RAID0) + ++ def test_lvm_raid_raid0_stripe_size(self): ++ self._test_lvm_raid("raid0", blivet.devicelibs.raid.RAID0, stripe_size=blivet.size.Size("1 MiB")) ++ + def test_lvm_raid_striped(self): + self._test_lvm_raid("striped", blivet.devicelibs.raid.Striped) + +diff --git a/tests/unit_tests/devices_test/lvm_test.py b/tests/unit_tests/devices_test/lvm_test.py +index 995c2da4..d7b55224 100644 +--- a/tests/unit_tests/devices_test/lvm_test.py ++++ b/tests/unit_tests/devices_test/lvm_test.py +@@ -363,6 +363,33 @@ class LVMDeviceTest(unittest.TestCase): + self.assertEqual(pv.format.free, Size("264 MiB")) + self.assertEqual(pv2.format.free, Size("256 MiB")) + ++ def test_lvm_logical_volume_raid_stripe_size(self): ++ pv = StorageDevice("pv1", fmt=blivet.formats.get_format("lvmpv"), ++ size=Size("1025 MiB")) ++ pv2 = StorageDevice("pv2", fmt=blivet.formats.get_format("lvmpv"), ++ size=Size("513 MiB")) ++ vg = LVMVolumeGroupDevice("testvg", parents=[pv, pv2]) ++ ++ with self.assertRaises(blivet.errors.DeviceError): ++ # non-raid LV ++ lv = LVMLogicalVolumeDevice("testlv", parents=[vg], size=Size("1 GiB"), ++ fmt=blivet.formats.get_format("xfs"), ++ exists=False, stripe_size=Size("1 MiB")) ++ ++ with self.assertRaises(blivet.errors.DeviceError): ++ # raid1 LV ++ lv = LVMLogicalVolumeDevice("testlv", parents=[vg], size=Size("1 GiB"), ++ fmt=blivet.formats.get_format("xfs"), ++ exists=False, seg_type="raid1", pvs=[pv, pv2], ++ stripe_size=Size("1 MiB")) ++ ++ lv = LVMLogicalVolumeDevice("testlv", parents=[vg], size=Size("1 GiB"), ++ fmt=blivet.formats.get_format("xfs"), ++ exists=False, seg_type="raid0", pvs=[pv, pv2], ++ stripe_size=Size("1 MiB")) ++ ++ self.assertEqual(lv._stripe_size, Size("1 MiB")) ++ + def test_target_size(self): + pv = StorageDevice("pv1", fmt=blivet.formats.get_format("lvmpv"), + size=Size("1 GiB")) +-- +2.40.1 + diff --git a/SOURCES/0013-Fix-setting-kickstart-data.patch b/SOURCES/0013-Fix-setting-kickstart-data.patch new file mode 100644 index 0000000..1d9a583 --- /dev/null +++ b/SOURCES/0013-Fix-setting-kickstart-data.patch @@ -0,0 +1,68 @@ +From 1af0d3c37a93e431790e641a329a7f34dabf291a Mon Sep 17 00:00:00 2001 +From: Vojtech Trefny +Date: Thu, 2 Mar 2023 12:34:42 +0100 +Subject: [PATCH] Fix setting kickstart data + +When changing our code to PEP8 compliant we also changed some +pykickstart properties like onPart by accident. This PR fixes this. + +Resolves: rhbz#2175166 +--- + blivet/devices/btrfs.py | 4 ++-- + blivet/devices/lvm.py | 2 +- + blivet/devices/partition.py | 6 +++--- + 3 files changed, 6 insertions(+), 6 deletions(-) + +diff --git a/blivet/devices/btrfs.py b/blivet/devices/btrfs.py +index 1ae6a04d..3f56624e 100644 +--- a/blivet/devices/btrfs.py ++++ b/blivet/devices/btrfs.py +@@ -498,8 +498,8 @@ class BTRFSVolumeDevice(BTRFSDevice, ContainerDevice, RaidDevice): + + def populate_ksdata(self, data): + super(BTRFSVolumeDevice, self).populate_ksdata(data) +- data.data_level = self.data_level.name if self.data_level else None +- data.metadata_level = self.metadata_level.name if self.metadata_level else None ++ data.dataLevel = self.data_level.name if self.data_level else None ++ data.metaDataLevel = self.metadata_level.name if self.metadata_level else None + data.devices = ["btrfs.%d" % p.id for p in self.parents] + data.preexist = self.exists + +diff --git a/blivet/devices/lvm.py b/blivet/devices/lvm.py +index 41358e9b..c3132457 100644 +--- a/blivet/devices/lvm.py ++++ b/blivet/devices/lvm.py +@@ -1161,7 +1161,7 @@ class LVMLogicalVolumeBase(DMDevice, RaidDevice): + + if self.req_grow: + # base size could be literal or percentage +- data.max_size_mb = self.req_max_size.convert_to(MiB) ++ data.maxSizeMB = self.req_max_size.convert_to(MiB) + elif data.resize: + data.size = self.target_size.convert_to(MiB) + +diff --git a/blivet/devices/partition.py b/blivet/devices/partition.py +index 89d907c2..0e9250ce 100644 +--- a/blivet/devices/partition.py ++++ b/blivet/devices/partition.py +@@ -982,14 +982,14 @@ class PartitionDevice(StorageDevice): + data.size = self.req_base_size.round_to_nearest(MiB, rounding=ROUND_DOWN).convert_to(spec=MiB) + data.grow = self.req_grow + if self.req_grow: +- data.max_size_mb = self.req_max_size.convert_to(MiB) ++ data.maxSizeMB = self.req_max_size.convert_to(MiB) + + # data.disk = self.disk.name # by-id + if self.req_disks and len(self.req_disks) == 1: + data.disk = self.disk.name +- data.prim_only = self.req_primary ++ data.primOnly = self.req_primary + else: +- data.on_part = self.name # by-id ++ data.onPart = self.name # by-id + + if data.resize: + # on s390x in particular, fractional sizes are reported, which +-- +2.40.1 + diff --git a/SOURCES/0014-Do-not-set-memory-limit-for-LUKS2-when-running-in-FI.patch b/SOURCES/0014-Do-not-set-memory-limit-for-LUKS2-when-running-in-FI.patch new file mode 100644 index 0000000..e6e90c5 --- /dev/null +++ b/SOURCES/0014-Do-not-set-memory-limit-for-LUKS2-when-running-in-FI.patch @@ -0,0 +1,133 @@ +From c2b06150df0b876c7d442097b6c9ca90c9ca2ecc Mon Sep 17 00:00:00 2001 +From: Vojtech Trefny +Date: Thu, 4 May 2023 11:35:44 +0200 +Subject: [PATCH] Do not set memory limit for LUKS2 when running in FIPS mode + +With FIPS enabled LUKS uses pbkdf and not argon so the memory +limit is not a valid parameter. + +Resolves: rhbz#2183437 +--- + blivet/devicelibs/crypto.py | 11 +++++++ + blivet/formats/luks.py | 12 ++++---- + tests/unit_tests/formats_tests/luks_test.py | 30 +++++++++++++++++++ + .../unit_tests/formats_tests/methods_test.py | 3 +- + 4 files changed, 50 insertions(+), 6 deletions(-) + +diff --git a/blivet/devicelibs/crypto.py b/blivet/devicelibs/crypto.py +index f0caf0f7..68e68db1 100644 +--- a/blivet/devicelibs/crypto.py ++++ b/blivet/devicelibs/crypto.py +@@ -21,6 +21,7 @@ + # + + import hashlib ++import os + + import gi + gi.require_version("BlockDev", "2.0") +@@ -100,3 +101,13 @@ def calculate_integrity_metadata_size(device_size, algorithm=DEFAULT_INTEGRITY_A + jsize = (jsize / SECTOR_SIZE + 1) * SECTOR_SIZE # round up to sector + + return msize + jsize ++ ++ ++def is_fips_enabled(): ++ if not os.path.exists("/proc/sys/crypto/fips_enabled"): ++ # if the file doesn't exist, we are definitely not in FIPS mode ++ return False ++ ++ with open("/proc/sys/crypto/fips_enabled", "r") as f: ++ enabled = f.read() ++ return enabled.strip() == "1" +diff --git a/blivet/formats/luks.py b/blivet/formats/luks.py +index 2637e0c5..adf3c711 100644 +--- a/blivet/formats/luks.py ++++ b/blivet/formats/luks.py +@@ -303,11 +303,13 @@ class LUKS(DeviceFormat): + if luks_data.pbkdf_args: + self.pbkdf_args = luks_data.pbkdf_args + else: +- mem_limit = crypto.calculate_luks2_max_memory() +- if mem_limit: +- self.pbkdf_args = LUKS2PBKDFArgs(max_memory_kb=int(mem_limit.convert_to(KiB))) +- luks_data.pbkdf_args = self.pbkdf_args +- log.info("PBKDF arguments for LUKS2 not specified, using defaults with memory limit %s", mem_limit) ++ # argon is not used with FIPS so we don't need to adjust the memory when in FIPS mode ++ if not crypto.is_fips_enabled(): ++ mem_limit = crypto.calculate_luks2_max_memory() ++ if mem_limit: ++ self.pbkdf_args = LUKS2PBKDFArgs(max_memory_kb=int(mem_limit.convert_to(KiB))) ++ luks_data.pbkdf_args = self.pbkdf_args ++ log.info("PBKDF arguments for LUKS2 not specified, using defaults with memory limit %s", mem_limit) + + if self.pbkdf_args: + pbkdf = blockdev.CryptoLUKSPBKDF(type=self.pbkdf_args.type, +diff --git a/tests/unit_tests/formats_tests/luks_test.py b/tests/unit_tests/formats_tests/luks_test.py +index ec7b7592..1127e968 100644 +--- a/tests/unit_tests/formats_tests/luks_test.py ++++ b/tests/unit_tests/formats_tests/luks_test.py +@@ -6,9 +6,14 @@ except ImportError: + import unittest + + from blivet.formats.luks import LUKS ++from blivet.size import Size ++from blivet.static_data import luks_data + + + class LUKSNodevTestCase(unittest.TestCase): ++ def setUp(self): ++ luks_data.pbkdf_args = None ++ + def test_create_discard_option(self): + # flags.discard_new=False --> no discard + fmt = LUKS(exists=False) +@@ -51,6 +56,31 @@ class LUKSNodevTestCase(unittest.TestCase): + fmt = LUKS(cipher="aes-cbc-plain64") + self.assertEqual(fmt.key_size, 0) + ++ def test_luks2_pbkdf_memory_fips(self): ++ fmt = LUKS() ++ with patch("blivet.formats.luks.blockdev.crypto") as bd: ++ # fips enabled, pbkdf memory should not be set ++ with patch("blivet.formats.luks.crypto") as crypto: ++ attrs = {"is_fips_enabled.return_value": True, ++ "get_optimal_luks_sector_size.return_value": 0, ++ "calculate_luks2_max_memory.return_value": Size("256 MiB")} ++ crypto.configure_mock(**attrs) ++ ++ fmt._create() ++ crypto.calculate_luks2_max_memory.assert_not_called() ++ self.assertEqual(bd.luks_format.call_args[1]["extra"].pbkdf.max_memory_kb, 0) ++ ++ # fips disabled, pbkdf memory should be set ++ with patch("blivet.formats.luks.crypto") as crypto: ++ attrs = {"is_fips_enabled.return_value": False, ++ "get_optimal_luks_sector_size.return_value": 0, ++ "calculate_luks2_max_memory.return_value": Size("256 MiB")} ++ crypto.configure_mock(**attrs) ++ ++ fmt._create() ++ crypto.calculate_luks2_max_memory.assert_called() ++ self.assertEqual(bd.luks_format.call_args[1]["extra"].pbkdf.max_memory_kb, 256 * 1024) ++ + def test_sector_size(self): + fmt = LUKS() + self.assertEqual(fmt.luks_sector_size, 512) +diff --git a/tests/unit_tests/formats_tests/methods_test.py b/tests/unit_tests/formats_tests/methods_test.py +index 2743b7db..5d30c260 100644 +--- a/tests/unit_tests/formats_tests/methods_test.py ++++ b/tests/unit_tests/formats_tests/methods_test.py +@@ -366,7 +366,8 @@ class LUKSMethodsTestCase(FormatMethodsTestCase): + + def _test_create_backend(self): + self.format.exists = False +- self.format.create() ++ with patch("blivet.devicelibs.crypto.is_fips_enabled", return_value=False): ++ self.format.create() + self.assertTrue(self.patches["blockdev"].crypto.luks_format.called) # pylint: disable=no-member + + def _test_setup_backend(self): +-- +2.40.1 + diff --git a/SOURCES/0015-Add-support-for-filesystem-online-resize.patch b/SOURCES/0015-Add-support-for-filesystem-online-resize.patch new file mode 100644 index 0000000..39f30e8 --- /dev/null +++ b/SOURCES/0015-Add-support-for-filesystem-online-resize.patch @@ -0,0 +1,265 @@ +From eb16230427fc1081f8515e6ad69ccf99ca521e5d Mon Sep 17 00:00:00 2001 +From: Vojtech Trefny +Date: Tue, 4 Apr 2023 13:31:40 +0200 +Subject: [PATCH 1/2] Add support for filesystem online resize + +Resolves: rhbz#2168680 +--- + blivet/devices/lvm.py | 13 ++++++++----- + blivet/devices/partition.py | 11 ++++++----- + blivet/flags.py | 3 +++ + blivet/formats/fs.py | 32 ++++++++++++++++++++++++++++---- + blivet/formats/fslib.py | 7 +++++++ + 5 files changed, 52 insertions(+), 14 deletions(-) + +diff --git a/blivet/devices/lvm.py b/blivet/devices/lvm.py +index c3132457..ca45c4b5 100644 +--- a/blivet/devices/lvm.py ++++ b/blivet/devices/lvm.py +@@ -42,6 +42,7 @@ from .. import errors + from .. import util + from ..storage_log import log_method_call + from .. import udev ++from ..flags import flags + from ..size import Size, KiB, MiB, ROUND_UP, ROUND_DOWN + from ..static_data.lvm_info import lvs_info + from ..tasks import availability +@@ -2729,12 +2730,14 @@ class LVMLogicalVolumeDevice(LVMLogicalVolumeBase, LVMInternalLogicalVolumeMixin + # Setup VG parents (in case they are dmraid partitions for example) + self.vg.setup_parents(orig=True) + +- if self.original_format.exists: +- self.original_format.teardown() +- if self.format.exists: +- self.format.teardown() ++ if not flags.allow_online_fs_resize: ++ if self.original_format.exists: ++ self.original_format.teardown() ++ if self.format.exists: ++ self.format.teardown() ++ ++ udev.settle() + +- udev.settle() + blockdev.lvm.lvresize(self.vg.name, self._name, self.size) + + @type_specific +diff --git a/blivet/devices/partition.py b/blivet/devices/partition.py +index 0e9250ce..6ae4b8d3 100644 +--- a/blivet/devices/partition.py ++++ b/blivet/devices/partition.py +@@ -745,11 +745,12 @@ class PartitionDevice(StorageDevice): + if not self.exists: + raise errors.DeviceError("device has not been created") + +- # don't teardown when resizing luks +- if self.format.type == "luks" and self.children: +- self.children[0].format.teardown() +- else: +- self.teardown() ++ if not flags.allow_online_fs_resize: ++ # don't teardown when resizing luks ++ if self.format.type == "luks" and self.children: ++ self.children[0].format.teardown() ++ else: ++ self.teardown() + + if not self.sysfs_path: + return +diff --git a/blivet/flags.py b/blivet/flags.py +index 6364164d..ecfa7ad7 100644 +--- a/blivet/flags.py ++++ b/blivet/flags.py +@@ -91,6 +91,9 @@ class Flags(object): + + self.debug_threads = False + ++ # Allow online filesystem resizes ++ self.allow_online_fs_resize = False ++ + def get_boot_cmdline(self): + with open("/proc/cmdline") as f: + buf = f.read().strip() +diff --git a/blivet/formats/fs.py b/blivet/formats/fs.py +index 33922f3a..3f553eb0 100644 +--- a/blivet/formats/fs.py ++++ b/blivet/formats/fs.py +@@ -56,7 +56,7 @@ from ..i18n import N_ + from .. import udev + from ..mounts import mounts_cache + +-from .fslib import kernel_filesystems ++from .fslib import kernel_filesystems, FSResize + + import logging + log = logging.getLogger("blivet") +@@ -88,6 +88,9 @@ class FS(DeviceFormat): + # value is already unpredictable and can change in the future... + _metadata_size_factor = 1.0 + ++ # support for resize: grow/shrink, online/offline ++ _resize_support = 0 ++ + config_actions_map = {"label": "write_label"} + + def __init__(self, **kwargs): +@@ -436,12 +439,27 @@ class FS(DeviceFormat): + self.write_uuid() + + def _pre_resize(self): +- # file systems need a check before being resized +- self.do_check() ++ if self.status: ++ if flags.allow_online_fs_resize: ++ if self.target_size > self.size and not self._resize_support & FSResize.ONLINE_GROW: ++ raise FSError("This filesystem doesn't support online growing") ++ if self.target_size < self.size and not self._resize_support & FSResize.ONLINE_SHRINK: ++ raise FSError("This filesystem doesn't support online shrinking") ++ else: ++ raise FSError("Resizing of mounted filesystems is disabled") ++ ++ if self.status: ++ # fsck tools in general don't allow checks on mounted filesystems ++ log.debug("Filesystem on %s is mounted, not checking", self.device) ++ else: ++ # file systems need a check before being resized ++ self.do_check() ++ + super(FS, self)._pre_resize() + + def _post_resize(self): +- self.do_check() ++ if not self.status: ++ self.do_check() + super(FS, self)._post_resize() + + def do_check(self): +@@ -838,6 +856,7 @@ class Ext2FS(FS): + _formattable = True + _supported = True + _resizable = True ++ _resize_support = FSResize.ONLINE_GROW | FSResize.OFFLINE_GROW | FSResize.OFFLINE_SHRINK + _linux_native = True + _max_size = Size("8 TiB") + _dump = True +@@ -1097,6 +1116,7 @@ class XFS(FS): + _linux_native = True + _supported = True + _resizable = True ++ _resize_support = FSResize.ONLINE_GROW | FSResize.OFFLINE_GROW + _packages = ["xfsprogs"] + _fsck_class = fsck.XFSCK + _info_class = fsinfo.XFSInfo +@@ -1247,6 +1267,7 @@ class NTFS(FS): + _labelfs = fslabeling.NTFSLabeling() + _uuidfs = fsuuid.NTFSUUID() + _resizable = True ++ _resize_support = FSResize.OFFLINE_GROW | FSResize.OFFLINE_SHRINK + _formattable = True + _supported = True + _min_size = Size("1 MiB") +@@ -1490,6 +1511,9 @@ class TmpFS(NoDevFS): + # same, nothing actually needs to be set + pass + ++ def _pre_resize(self): ++ self.do_check() ++ + def do_resize(self): + # Override superclass method to record whether mount options + # should include an explicit size specification. +diff --git a/blivet/formats/fslib.py b/blivet/formats/fslib.py +index ea93b1fd..8722e942 100644 +--- a/blivet/formats/fslib.py ++++ b/blivet/formats/fslib.py +@@ -36,3 +36,10 @@ def update_kernel_filesystems(): + + + update_kernel_filesystems() ++ ++ ++class FSResize(): ++ OFFLINE_SHRINK = 1 << 1 ++ OFFLINE_GROW = 1 << 2 ++ ONLINE_SHRINK = 1 << 3 ++ ONLINE_GROW = 1 << 4 +-- +2.40.1 + + +From 3fce5d0bfd7b09a976ff49feed15077477c6a425 Mon Sep 17 00:00:00 2001 +From: Vojtech Trefny +Date: Thu, 6 Apr 2023 14:02:11 +0200 +Subject: [PATCH 2/2] Add a test case for filesystem online resize + +Related: rhbz#2168680 +--- + tests/storage_tests/formats_test/fs_test.py | 43 ++++++++++++++++++++- + 1 file changed, 42 insertions(+), 1 deletion(-) + +diff --git a/tests/storage_tests/formats_test/fs_test.py b/tests/storage_tests/formats_test/fs_test.py +index 97f4cbbe..1d42dc21 100644 +--- a/tests/storage_tests/formats_test/fs_test.py ++++ b/tests/storage_tests/formats_test/fs_test.py +@@ -6,9 +6,10 @@ import parted + + import blivet.formats.fs as fs + from blivet.size import Size, ROUND_DOWN +-from blivet.errors import DeviceFormatError ++from blivet.errors import DeviceFormatError, FSError + from blivet.formats import get_format + from blivet.devices import PartitionDevice, DiskDevice ++from blivet.flags import flags + + from .loopbackedtestcase import LoopBackedTestCase + +@@ -26,6 +27,46 @@ class Ext3FSTestCase(Ext2FSTestCase): + class Ext4FSTestCase(Ext3FSTestCase): + _fs_class = fs.Ext4FS + ++ def test_online_resize(self): ++ an_fs = self._fs_class() ++ if not an_fs.formattable: ++ self.skipTest("can not create filesystem %s" % an_fs.name) ++ an_fs.device = self.loop_devices[0] ++ self.assertIsNone(an_fs.create()) ++ an_fs.update_size_info() ++ ++ if not self.can_resize(an_fs): ++ self.skipTest("filesystem is not resizable") ++ ++ # shrink offline first (ext doesn't support online shrinking) ++ TARGET_SIZE = Size("64 MiB") ++ an_fs.target_size = TARGET_SIZE ++ self.assertEqual(an_fs.target_size, TARGET_SIZE) ++ self.assertNotEqual(an_fs._size, TARGET_SIZE) ++ self.assertIsNone(an_fs.do_resize()) ++ ++ with tempfile.TemporaryDirectory() as mountpoint: ++ an_fs.mount(mountpoint=mountpoint) ++ ++ # grow back when mounted ++ TARGET_SIZE = Size("100 MiB") ++ an_fs.target_size = TARGET_SIZE ++ self.assertEqual(an_fs.target_size, TARGET_SIZE) ++ self.assertNotEqual(an_fs._size, TARGET_SIZE) ++ ++ # should fail, online resize disabled by default ++ with self.assertRaisesRegex(FSError, "Resizing of mounted filesystems is disabled"): ++ an_fs.do_resize() ++ ++ # enable online resize ++ flags.allow_online_fs_resize = True ++ an_fs.do_resize() ++ flags.allow_online_fs_resize = False ++ self._test_sizes(an_fs) ++ self.assertEqual(an_fs.system_mountpoint, mountpoint) ++ ++ an_fs.unmount() ++ + + class FATFSTestCase(fstesting.FSAsRoot): + _fs_class = fs.FATFS +-- +2.40.1 + diff --git a/SOURCES/0016-Backport-iSCSI-initiator-name-related-fixes.patch b/SOURCES/0016-Backport-iSCSI-initiator-name-related-fixes.patch new file mode 100644 index 0000000..f61a188 --- /dev/null +++ b/SOURCES/0016-Backport-iSCSI-initiator-name-related-fixes.patch @@ -0,0 +1,382 @@ +From d06c45db59d0e917dbab4c283f2f04c8f9206a6e Mon Sep 17 00:00:00 2001 +From: Vojtech Trefny +Date: Mon, 6 Mar 2023 10:51:42 +0100 +Subject: [PATCH 1/5] Allow changing iSCSI initiator name after setting it + +Resolves: rhbz#2083139 +--- + blivet/iscsi.py | 13 +++++++++++-- + 1 file changed, 11 insertions(+), 2 deletions(-) + +diff --git a/blivet/iscsi.py b/blivet/iscsi.py +index 86451db3..0d063f2a 100644 +--- a/blivet/iscsi.py ++++ b/blivet/iscsi.py +@@ -212,14 +212,23 @@ class iSCSI(object): + @initiator.setter + @storaged_iscsi_required(critical=True, eval_mode=util.EvalMode.onetime) + def initiator(self, val): +- if self.initiator_set and val != self._initiator: +- raise ValueError(_("Unable to change iSCSI initiator name once set")) + if len(val) == 0: + raise ValueError(_("Must provide an iSCSI initiator name")) + ++ active = self._get_active_sessions() ++ if active: ++ raise errors.ISCSIError(_("Cannot change initiator name with an active session")) ++ + log.info("Setting up iSCSI initiator name %s", self.initiator) + args = GLib.Variant("(sa{sv})", (val, None)) + self._call_initiator_method("SetInitiatorName", args) ++ ++ if self.initiator_set and val != self._initiator: ++ log.info("Restarting iscsid after initiator name change") ++ rc = util.run_program(["systemctl", "restart", "iscsid"]) ++ if rc != 0: ++ raise errors.ISCSIError(_("Failed to restart iscsid after initiator name change")) ++ + self._initiator = val + + def active_nodes(self, target=None): +-- +2.40.1 + + +From b71991d65c270c023364b03c499b4bf3e245fbd0 Mon Sep 17 00:00:00 2001 +From: Vojtech Trefny +Date: Mon, 6 Mar 2023 15:10:28 +0100 +Subject: [PATCH 2/5] Add a basic test case for the iscsi module + +Related: rhbz#2083139 +--- + tests/storage_tests/__init__.py | 2 + + tests/storage_tests/iscsi_test.py | 157 +++++++++++++++++++++++++++++ + 3 files changed, 162 insertions(+) + create mode 100644 tests/storage_tests/iscsi_test.py + +diff --git a/tests/storage_tests/__init__.py b/tests/storage_tests/__init__.py +index 3b2a6cc4..e69fcc34 100644 +--- a/tests/storage_tests/__init__.py ++++ b/tests/storage_tests/__init__.py +@@ -3,3 +3,5 @@ from .formats_test import * + + from .partitioning_test import * + from .unsupported_disklabel_test import * ++ ++from .iscsi_test import * +diff --git a/tests/storage_tests/iscsi_test.py b/tests/storage_tests/iscsi_test.py +new file mode 100644 +index 00000000..00cc7c36 +--- /dev/null ++++ b/tests/storage_tests/iscsi_test.py +@@ -0,0 +1,157 @@ ++import glob ++import os ++import re ++import shutil ++import subprocess ++import unittest ++ ++from contextlib import contextmanager ++ ++from .storagetestcase import create_sparse_tempfile ++ ++ ++def read_file(filename, mode="r"): ++ with open(filename, mode) as f: ++ content = f.read() ++ return content ++ ++ ++@contextmanager ++def udev_settle(): ++ try: ++ yield ++ finally: ++ os.system("udevadm settle") ++ ++ ++def _delete_backstore(name): ++ status = subprocess.call(["targetcli", "/backstores/fileio/ delete %s" % name], ++ stdout=subprocess.DEVNULL) ++ if status != 0: ++ raise RuntimeError("Failed to delete the '%s' fileio backstore" % name) ++ ++ ++def delete_iscsi_target(iqn, backstore=None): ++ status = subprocess.call(["targetcli", "/iscsi delete %s" % iqn], ++ stdout=subprocess.DEVNULL) ++ if status != 0: ++ raise RuntimeError("Failed to delete the '%s' iscsi device" % iqn) ++ ++ if backstore is not None: ++ _delete_backstore(backstore) ++ ++ ++def create_iscsi_target(fpath, initiator_name=None): ++ """ ++ Creates a new iSCSI target (using targetcli) on top of the ++ :param:`fpath` backing file. ++ ++ :param str fpath: path of the backing file ++ :returns: iSCSI IQN, backstore name ++ :rtype: tuple of str ++ ++ """ ++ ++ # "register" the backing file as a fileio backstore ++ store_name = os.path.basename(fpath) ++ status = subprocess.call(["targetcli", "/backstores/fileio/ create %s %s" % (store_name, fpath)], stdout=subprocess.DEVNULL) ++ if status != 0: ++ raise RuntimeError("Failed to register '%s' as a fileio backstore" % fpath) ++ ++ out = subprocess.check_output(["targetcli", "/backstores/fileio/%s info" % store_name]) ++ out = out.decode("utf-8") ++ store_wwn = None ++ for line in out.splitlines(): ++ if line.startswith("wwn: "): ++ store_wwn = line[5:] ++ if store_wwn is None: ++ raise RuntimeError("Failed to determine '%s' backstore's wwn" % store_name) ++ ++ # create a new iscsi device ++ out = subprocess.check_output(["targetcli", "/iscsi create"]) ++ out = out.decode("utf-8") ++ match = re.match(r'Created target (.*).', out) ++ if match: ++ iqn = match.groups()[0] ++ else: ++ _delete_backstore(store_name) ++ raise RuntimeError("Failed to create a new iscsi target") ++ ++ if initiator_name: ++ status = subprocess.call(["targetcli", "/iscsi/%s/tpg1/acls create %s" % (iqn, initiator_name)], stdout=subprocess.DEVNULL) ++ if status != 0: ++ delete_iscsi_target(iqn, store_name) ++ raise RuntimeError("Failed to set ACLs for '%s'" % iqn) ++ ++ with udev_settle(): ++ status = subprocess.call(["targetcli", "/iscsi/%s/tpg1/luns create /backstores/fileio/%s" % (iqn, store_name)], stdout=subprocess.DEVNULL) ++ if status != 0: ++ delete_iscsi_target(iqn, store_name) ++ raise RuntimeError("Failed to create a new LUN for '%s' using '%s'" % (iqn, store_name)) ++ ++ status = subprocess.call(["targetcli", "/iscsi/%s/tpg1 set attribute generate_node_acls=1" % iqn], stdout=subprocess.DEVNULL) ++ if status != 0: ++ raise RuntimeError("Failed to set ACLs for '%s'" % iqn) ++ ++ return iqn, store_name ++ ++ ++@unittest.skipUnless(os.geteuid() == 0, "requires root privileges") ++@unittest.skipUnless(os.environ.get("JENKINS_HOME"), "jenkins only test") ++@unittest.skipUnless(shutil.which("iscsiadm"), "iscsiadm not available") ++class ISCSITestCase(unittest.TestCase): ++ ++ _disk_size = 512 * 1024**2 ++ initiator = 'iqn.1994-05.com.redhat:iscsi-test' ++ ++ def setUp(self): ++ self.addCleanup(self._clean_up) ++ ++ self._dev_file = None ++ self.dev = None ++ ++ self._dev_file = create_sparse_tempfile("blivet_test", self._disk_size) ++ try: ++ self.dev, self.backstore = create_iscsi_target(self._dev_file, self.initiator) ++ except RuntimeError as e: ++ raise RuntimeError("Failed to setup targetcli device for testing: %s" % e) ++ ++ def _force_logout(self): ++ subprocess.call(["iscsiadm", "--mode", "node", "--logout", "--name", self.dev], stdout=subprocess.DEVNULL) ++ ++ def _clean_up(self): ++ self._force_logout() ++ delete_iscsi_target(self.dev, self.backstore) ++ os.unlink(self._dev_file) ++ ++ def test_discover_login(self): ++ from blivet.iscsi import iscsi, has_iscsi ++ ++ if not has_iscsi(): ++ self.skipTest("iSCSI not available, skipping") ++ ++ iscsi.initiator = self.initiator ++ nodes = iscsi.discover("127.0.0.1") ++ self.assertTrue(nodes) ++ ++ if len(nodes) > 1: ++ self.skipTest("Discovered more than one iSCSI target on localhost, skipping") ++ ++ self.assertEqual(nodes[0].address, "127.0.0.1") ++ self.assertEqual(nodes[0].port, 3260) ++ self.assertEqual(nodes[0].name, self.dev) ++ ++ # change the initiator name ++ iscsi.initiator = self.initiator + "_1" ++ self.assertEqual(iscsi.initiator, self.initiator + "_1") ++ ++ # try to login ++ ret, err = iscsi.log_into_node(nodes[0]) ++ self.assertTrue(ret, "Login failed: %s" % err) ++ ++ # check the session for initiator name ++ sessions = glob.glob("/sys/class/iscsi_session/*/") ++ self.assertTrue(sessions) ++ self.assertEqual(len(sessions), 1) ++ initiator = read_file(sessions[0] + "initiatorname").strip() ++ self.assertEqual(initiator, iscsi.initiator) +-- +2.40.1 + + +From 65e8150a7404e37dd2740841a88e7f2565836406 Mon Sep 17 00:00:00 2001 +From: Vojtech Trefny +Date: Mon, 6 Mar 2023 15:14:40 +0100 +Subject: [PATCH 3/5] tests: Use blivet-specific prefix for targetcli backing + files + +The code is originally from libblockdev hence the "bd" prefix, we +should use a different prefix for blivet to be able to identify +which test suite failed to clean the files. + +Related: rhbz#2083139 +--- + tests/storage_tests/storagetestcase.py | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/tests/storage_tests/storagetestcase.py b/tests/storage_tests/storagetestcase.py +index 35d57ce9..9f859977 100644 +--- a/tests/storage_tests/storagetestcase.py ++++ b/tests/storage_tests/storagetestcase.py +@@ -39,7 +39,7 @@ def create_sparse_tempfile(name, size): + :param size: the file size (in bytes) + :returns: the path to the newly created file + """ +- (fd, path) = tempfile.mkstemp(prefix="bd.", suffix="-%s" % name) ++ (fd, path) = tempfile.mkstemp(prefix="blivet.", suffix="-%s" % name) + os.close(fd) + create_sparse_file(path, size) + return path +-- +2.40.1 + + +From 41278ef1b3f949303fd30fff2ccdde75f713c9f8 Mon Sep 17 00:00:00 2001 +From: Vojtech Trefny +Date: Wed, 19 Jul 2023 13:57:39 +0200 +Subject: [PATCH 4/5] iscsi: Save firmware initiator name to + /etc/iscsi/initiatorname.iscsi + +Resolves: rhbz#2084043 +--- + blivet/iscsi.py | 5 +++++ + 1 file changed, 5 insertions(+) + +diff --git a/blivet/iscsi.py b/blivet/iscsi.py +index 0d063f2a..8080a671 100644 +--- a/blivet/iscsi.py ++++ b/blivet/iscsi.py +@@ -160,6 +160,11 @@ class iSCSI(object): + self._initiator = initiatorname + except Exception as e: # pylint: disable=broad-except + log.info("failed to get initiator name from iscsi firmware: %s", str(e)) ++ else: ++ # write the firmware initiator to /etc/iscsi/initiatorname.iscsi ++ log.info("Setting up firmware iSCSI initiator name %s", self.initiator) ++ args = GLib.Variant("(sa{sv})", (initiatorname, None)) ++ self._call_initiator_method("SetInitiatorName", args) + + # So that users can write iscsi() to get the singleton instance + def __call__(self): +-- +2.40.1 + + +From fce8b73965d968aab546bc7e0ecb65d1995da46f Mon Sep 17 00:00:00 2001 +From: Vojtech Trefny +Date: Wed, 19 Jul 2023 10:38:45 +0200 +Subject: [PATCH 5/5] tests: Improve iscsi_test.ISCSITestCase + +Changed how we create the initiator name ACLs based on RTT test +case for rhbz#2084043 and also improved the test case itself. + +Related: rhbz#2083139 +--- + tests/storage_tests/iscsi_test.py | 36 +++++++++++++++++++++---------- + 1 file changed, 25 insertions(+), 11 deletions(-) + +diff --git a/tests/storage_tests/iscsi_test.py b/tests/storage_tests/iscsi_test.py +index 00cc7c36..6cc83a59 100644 +--- a/tests/storage_tests/iscsi_test.py ++++ b/tests/storage_tests/iscsi_test.py +@@ -77,21 +77,17 @@ def create_iscsi_target(fpath, initiator_name=None): + _delete_backstore(store_name) + raise RuntimeError("Failed to create a new iscsi target") + +- if initiator_name: +- status = subprocess.call(["targetcli", "/iscsi/%s/tpg1/acls create %s" % (iqn, initiator_name)], stdout=subprocess.DEVNULL) +- if status != 0: +- delete_iscsi_target(iqn, store_name) +- raise RuntimeError("Failed to set ACLs for '%s'" % iqn) +- + with udev_settle(): + status = subprocess.call(["targetcli", "/iscsi/%s/tpg1/luns create /backstores/fileio/%s" % (iqn, store_name)], stdout=subprocess.DEVNULL) + if status != 0: + delete_iscsi_target(iqn, store_name) + raise RuntimeError("Failed to create a new LUN for '%s' using '%s'" % (iqn, store_name)) + +- status = subprocess.call(["targetcli", "/iscsi/%s/tpg1 set attribute generate_node_acls=1" % iqn], stdout=subprocess.DEVNULL) +- if status != 0: +- raise RuntimeError("Failed to set ACLs for '%s'" % iqn) ++ if initiator_name: ++ status = subprocess.call(["targetcli", "/iscsi/%s/tpg1/acls create %s" % (iqn, initiator_name)], stdout=subprocess.DEVNULL) ++ if status != 0: ++ delete_iscsi_target(iqn, store_name) ++ raise RuntimeError("Failed to set ACLs for '%s'" % iqn) + + return iqn, store_name + +@@ -130,6 +126,7 @@ class ISCSITestCase(unittest.TestCase): + if not has_iscsi(): + self.skipTest("iSCSI not available, skipping") + ++ # initially set the initiator to the correct/allowed one + iscsi.initiator = self.initiator + nodes = iscsi.discover("127.0.0.1") + self.assertTrue(nodes) +@@ -141,11 +138,28 @@ class ISCSITestCase(unittest.TestCase): + self.assertEqual(nodes[0].port, 3260) + self.assertEqual(nodes[0].name, self.dev) + +- # change the initiator name ++ # change the initiator name to a wrong one + iscsi.initiator = self.initiator + "_1" + self.assertEqual(iscsi.initiator, self.initiator + "_1") + +- # try to login ++ # check the change made it to /etc/iscsi/initiatorname.iscsi ++ initiator_file = read_file("/etc/iscsi/initiatorname.iscsi").strip() ++ self.assertEqual(initiator_file, "InitiatorName=%s" % self.initiator + "_1") ++ ++ # try to login (should fail) ++ ret, err = iscsi.log_into_node(nodes[0]) ++ self.assertFalse(ret) ++ self.assertIn("authorization failure", err) ++ ++ # change the initiator name back to the correct one ++ iscsi.initiator = self.initiator ++ self.assertEqual(iscsi.initiator, self.initiator) ++ ++ # check the change made it to /etc/iscsi/initiatorname.iscsi ++ initiator_file = read_file("/etc/iscsi/initiatorname.iscsi").strip() ++ self.assertEqual(initiator_file, "InitiatorName=%s" % self.initiator) ++ ++ # try to login (should work now) + ret, err = iscsi.log_into_node(nodes[0]) + self.assertTrue(ret, "Login failed: %s" % err) + +-- +2.40.1 + diff --git a/SOURCES/0017-Add-support-for-creating-shared-LVM-setups.patch b/SOURCES/0017-Add-support-for-creating-shared-LVM-setups.patch new file mode 100644 index 0000000..4bf0733 --- /dev/null +++ b/SOURCES/0017-Add-support-for-creating-shared-LVM-setups.patch @@ -0,0 +1,206 @@ +From faef0408d2f7c61aade6d187389c61e64f9f373b Mon Sep 17 00:00:00 2001 +From: Vojtech Trefny +Date: Thu, 20 Apr 2023 12:35:30 +0200 +Subject: [PATCH] Add support for creating shared LVM setups + +This feature is requested by GFS2 for the storage role. This adds +support for creating shared VGs and activating LVs in shared mode. + +Resolves: RHEL-14021 +--- + blivet/devices/lvm.py | 44 +++++++++++++++++++---- + blivet/tasks/availability.py | 9 +++++ + tests/unit_tests/devices_test/lvm_test.py | 25 +++++++++++++ + 3 files changed, 72 insertions(+), 6 deletions(-) + +diff --git a/blivet/devices/lvm.py b/blivet/devices/lvm.py +index ca45c4b5..068c5368 100644 +--- a/blivet/devices/lvm.py ++++ b/blivet/devices/lvm.py +@@ -97,7 +97,8 @@ class LVMVolumeGroupDevice(ContainerDevice): + + def __init__(self, name, parents=None, size=None, free=None, + pe_size=None, pe_count=None, pe_free=None, pv_count=None, +- uuid=None, exists=False, sysfs_path='', exported=False): ++ uuid=None, exists=False, sysfs_path='', exported=False, ++ shared=False): + """ + :param name: the device name (generally a device node's basename) + :type name: str +@@ -124,6 +125,11 @@ class LVMVolumeGroupDevice(ContainerDevice): + :type pv_count: int + :keyword uuid: the VG UUID + :type uuid: str ++ ++ For non-existing VGs only: ++ ++ :keyword shared: whether to create this VG as shared ++ :type shared: bool + """ + # These attributes are used by _add_parent, so they must be initialized + # prior to instantiating the superclass. +@@ -137,6 +143,7 @@ class LVMVolumeGroupDevice(ContainerDevice): + self.pe_count = util.numeric_type(pe_count) + self.pe_free = util.numeric_type(pe_free) + self.exported = exported ++ self._shared = shared + + # TODO: validate pe_size if given + if not self.pe_size: +@@ -254,7 +261,19 @@ class LVMVolumeGroupDevice(ContainerDevice): + """ Create the device. """ + log_method_call(self, self.name, status=self.status) + pv_list = [pv.path for pv in self.parents] +- blockdev.lvm.vgcreate(self.name, pv_list, self.pe_size) ++ extra = dict() ++ if self._shared: ++ extra["shared"] = "" ++ blockdev.lvm.vgcreate(self.name, pv_list, self.pe_size, **extra) ++ ++ if self._shared: ++ if availability.BLOCKDEV_LVM_PLUGIN_SHARED.available: ++ try: ++ blockdev.lvm.vglock_start(self.name) ++ except blockdev.LVMError as err: ++ raise errors.LVMError(err) ++ else: ++ raise errors.LVMError("Shared LVM is not fully supported: %s" % ",".join(availability.BLOCKDEV_LVM_PLUGIN_SHARED.availability_errors)) + + def _post_create(self): + self._complete = True +@@ -661,7 +680,7 @@ class LVMLogicalVolumeBase(DMDevice, RaidDevice): + def __init__(self, name, parents=None, size=None, uuid=None, seg_type=None, + fmt=None, exists=False, sysfs_path='', grow=None, maxsize=None, + percent=None, cache_request=None, pvs=None, from_lvs=None, +- stripe_size=0): ++ stripe_size=0, shared=False): + + if not exists: + if seg_type not in [None, "linear", "thin", "thin-pool", "cache", "vdo-pool", "vdo", "cache-pool"] + lvm.raid_seg_types: +@@ -690,6 +709,7 @@ class LVMLogicalVolumeBase(DMDevice, RaidDevice): + self.seg_type = seg_type or "linear" + self._raid_level = None + self.ignore_skip_activation = 0 ++ self._shared = shared + + self.req_grow = None + self.req_max_size = Size(0) +@@ -2306,7 +2326,8 @@ class LVMLogicalVolumeDevice(LVMLogicalVolumeBase, LVMInternalLogicalVolumeMixin + parent_lv=None, int_type=None, origin=None, vorigin=False, + metadata_size=None, chunk_size=None, profile=None, from_lvs=None, + compression=False, deduplication=False, index_memory=0, +- write_policy=None, cache_mode=None, attach_to=None, stripe_size=0): ++ write_policy=None, cache_mode=None, attach_to=None, stripe_size=0, ++ shared=False): + """ + :param name: the device name (generally a device node's basename) + :type name: str +@@ -2337,6 +2358,8 @@ class LVMLogicalVolumeDevice(LVMLogicalVolumeBase, LVMInternalLogicalVolumeMixin + :type cache_request: :class:`~.devices.lvm.LVMCacheRequest` + :keyword pvs: list of PVs to allocate extents from (size could be specified for each PV) + :type pvs: list of :class:`~.devices.StorageDevice` or :class:`LVPVSpec` objects (tuples) ++ :keyword shared: whether to activate the newly create LV in shared mode ++ :type shared: bool + + For internal LVs only: + +@@ -2412,7 +2435,7 @@ class LVMLogicalVolumeDevice(LVMLogicalVolumeBase, LVMInternalLogicalVolumeMixin + LVMLogicalVolumeBase.__init__(self, name, parents, size, uuid, seg_type, + fmt, exists, sysfs_path, grow, maxsize, + percent, cache_request, pvs, from_lvs, +- stripe_size) ++ stripe_size, shared) + LVMVDOPoolMixin.__init__(self, compression, deduplication, index_memory, + write_policy) + LVMVDOLogicalVolumeMixin.__init__(self) +@@ -2634,7 +2657,13 @@ class LVMLogicalVolumeDevice(LVMLogicalVolumeBase, LVMInternalLogicalVolumeMixin + log_method_call(self, self.name, orig=orig, status=self.status, + controllable=self.controllable) + ignore_skip_activation = self.is_snapshot_lv or self.ignore_skip_activation > 0 +- blockdev.lvm.lvactivate(self.vg.name, self._name, ignore_skip=ignore_skip_activation) ++ if self._shared: ++ if availability.BLOCKDEV_LVM_PLUGIN_SHARED.available: ++ blockdev.lvm.lvactivate(self.vg.name, self._name, ignore_skip=ignore_skip_activation, shared=True) ++ else: ++ raise errors.LVMError("Shared LVM is not fully supported: %s" % ",".join(availability.BLOCKDEV_LVM_PLUGIN_SHARED.availability_errors)) ++ else: ++ blockdev.lvm.lvactivate(self.vg.name, self._name, ignore_skip=ignore_skip_activation) + + @type_specific + def _pre_create(self): +@@ -2672,6 +2701,9 @@ class LVMLogicalVolumeDevice(LVMLogicalVolumeBase, LVMInternalLogicalVolumeMixin + if self._stripe_size: + extra["stripesize"] = str(int(self._stripe_size.convert_to("KiB"))) + ++ if self._shared: ++ extra["activate"] = "sy" ++ + blockdev.lvm.lvcreate(self.vg.name, self._name, self.size, + type=self.seg_type, pv_list=pvs, **extra) + else: +diff --git a/blivet/tasks/availability.py b/blivet/tasks/availability.py +index bba1ba84..85945c77 100644 +--- a/blivet/tasks/availability.py ++++ b/blivet/tasks/availability.py +@@ -435,6 +435,14 @@ if hasattr(blockdev.LVMTech, "VDO"): + else: + BLOCKDEV_LVM_TECH_VDO = _UnavailableMethod(error_msg="Installed version of libblockdev doesn't support LVM VDO technology") + ++if hasattr(blockdev.LVMTech, "SHARED"): ++ BLOCKDEV_LVM_SHARED = BlockDevTechInfo(plugin_name="lvm", ++ check_fn=blockdev.lvm_is_tech_avail, ++ technologies={blockdev.LVMTech.SHARED: blockdev.LVMTechMode.MODIFY}) # pylint: disable=no-member ++ BLOCKDEV_LVM_TECH_SHARED = BlockDevMethod(BLOCKDEV_LVM_SHARED) ++else: ++ BLOCKDEV_LVM_TECH_SHARED = _UnavailableMethod(error_msg="Installed version of libblockdev doesn't support shared LVM technology") ++ + # libblockdev mdraid plugin required technologies and modes + BLOCKDEV_MD_ALL_MODES = (blockdev.MDTechMode.CREATE | + blockdev.MDTechMode.DELETE | +@@ -476,6 +484,7 @@ BLOCKDEV_DM_PLUGIN_RAID = blockdev_plugin("libblockdev dm plugin (raid technolog + BLOCKDEV_LOOP_PLUGIN = blockdev_plugin("libblockdev loop plugin", BLOCKDEV_LOOP_TECH) + BLOCKDEV_LVM_PLUGIN = blockdev_plugin("libblockdev lvm plugin", BLOCKDEV_LVM_TECH) + BLOCKDEV_LVM_PLUGIN_VDO = blockdev_plugin("libblockdev lvm plugin (vdo technology)", BLOCKDEV_LVM_TECH_VDO) ++BLOCKDEV_LVM_PLUGIN_SHARED = blockdev_plugin("libblockdev lvm plugin (shared LVM technology)", BLOCKDEV_LVM_TECH_SHARED) + BLOCKDEV_MDRAID_PLUGIN = blockdev_plugin("libblockdev mdraid plugin", BLOCKDEV_MD_TECH) + BLOCKDEV_MPATH_PLUGIN = blockdev_plugin("libblockdev mpath plugin", BLOCKDEV_MPATH_TECH) + BLOCKDEV_SWAP_PLUGIN = blockdev_plugin("libblockdev swap plugin", BLOCKDEV_SWAP_TECH) +diff --git a/tests/unit_tests/devices_test/lvm_test.py b/tests/unit_tests/devices_test/lvm_test.py +index d7b55224..e645309f 100644 +--- a/tests/unit_tests/devices_test/lvm_test.py ++++ b/tests/unit_tests/devices_test/lvm_test.py +@@ -476,6 +476,31 @@ class LVMDeviceTest(unittest.TestCase): + lv.setup() + lvm.lvactivate.assert_called_with(vg.name, lv.lvname, ignore_skip=False) + ++ @patch("blivet.tasks.availability.BLOCKDEV_LVM_PLUGIN_SHARED", ++ new=blivet.tasks.availability.ExternalResource(blivet.tasks.availability.AvailableMethod, "")) ++ def test_lv_activate_shared(self): ++ pv = StorageDevice("pv1", fmt=blivet.formats.get_format("lvmpv"), ++ size=Size("1 GiB"), exists=True) ++ vg = LVMVolumeGroupDevice("testvg", parents=[pv], exists=True) ++ lv = LVMLogicalVolumeDevice("data_lv", parents=[vg], size=Size("500 MiB"), exists=True, shared=True) ++ ++ with patch("blivet.devices.lvm.blockdev.lvm") as lvm: ++ with patch.object(lv, "_pre_setup"): ++ lv.setup() ++ lvm.lvactivate.assert_called_with(vg.name, lv.lvname, ignore_skip=False, shared=True) ++ ++ @patch("blivet.tasks.availability.BLOCKDEV_LVM_PLUGIN_SHARED", ++ new=blivet.tasks.availability.ExternalResource(blivet.tasks.availability.AvailableMethod, "")) ++ def test_vg_create_shared(self): ++ pv = StorageDevice("pv1", fmt=blivet.formats.get_format("lvmpv"), ++ size=Size("1 GiB"), exists=True) ++ vg = LVMVolumeGroupDevice("testvg", parents=[pv], shared=True) ++ ++ with patch("blivet.devices.lvm.blockdev.lvm") as lvm: ++ vg._create() ++ lvm.vgcreate.assert_called_with(vg.name, [pv.path], Size("4 MiB"), shared="") ++ lvm.vglock_start.assert_called_with(vg.name) ++ + def test_vg_is_empty(self): + pv = StorageDevice("pv1", fmt=blivet.formats.get_format("lvmpv"), + size=Size("1024 MiB")) +-- +2.41.0 + diff --git a/SPECS/python-blivet.spec b/SPECS/python-blivet.spec new file mode 100644 index 0000000..0b5f6e1 --- /dev/null +++ b/SPECS/python-blivet.spec @@ -0,0 +1,3312 @@ +%define is_rhel 0%{?rhel} != 0 + +# python3 is not available on RHEL <=7 +%if %{is_rhel} && 0%{?rhel} <= 7 +# disable python3 by default +%bcond_with python3 +%else +%bcond_without python3 +%endif + +# python2 is not available on RHEL > 7 and not needed on Fedora > 28 +%if 0%{?rhel} > 7 || 0%{?fedora} > 28 +# disable python2 by default +%bcond_with python2 +%else +%bcond_without python2 +%endif + +Summary: A python module for system storage configuration +Name: python-blivet +Url: https://storageapis.wordpress.com/projects/blivet +Version: 3.6.0 + +#%%global prerelease .b2 +# prerelease, if defined, should be something like .a1, .b1, .b2.dev1, or .c2 +Release: 8%{?prerelease}%{?dist} +Epoch: 1 +License: LGPLv2+ +%global realname blivet +%global realversion %{version}%{?prerelease} +Source0: http://github.com/storaged-project/blivet/archive/%{realname}-%{realversion}.tar.gz +Source1: http://github.com/storaged-project/blivet/archive/%{realname}-%{realversion}-tests.tar.gz +Patch0: 0001-force-lvm-cli.plugin +Patch1: 0002-remove-btrfs-plugin.patch +Patch2: 0003-Revert-More-consistent-lvm-errors.patch +Patch3: 0004-Revert-Terminology-cleanups.patch +Patch4: 0005-DDF-RAID-support-using-mdadm.patch +Patch5: 0006-Revert-Remove-the-Blivet.roots-attribute.patch +Patch6: 0007-Fix-potential-AttributeError-when-getting-stratis-bl.patch +Patch7: 0008-tests-Skip-XFS-resize-test-on-CentOS-RHEL-8.patch +Patch8: 0009-Revert-Adjust-to-new-XFS-min-size.patch +Patch9: 0010-Catch-BlockDevNotImplementedError-for-btrfs-plugin-c.patch +Patch10: 0011-Default-to-encryption-sector-size-512-for-LUKS-devic.patch +Patch11: 0012-Add-support-for-specifying-stripe-size-for-RAID-LVs.patch +Patch12: 0013-Fix-setting-kickstart-data.patch +Patch13: 0014-Do-not-set-memory-limit-for-LUKS2-when-running-in-FI.patch +Patch14: 0015-Add-support-for-filesystem-online-resize.patch +Patch15: 0016-Backport-iSCSI-initiator-name-related-fixes.patch +Patch16: 0017-Add-support-for-creating-shared-LVM-setups.patch + +# Versions of required components (done so we make sure the buildrequires +# match the requires versions of things). +%global partedver 3.2 +%global pypartedver 3.10.4 +%global utillinuxver 2.15.1 +%global libblockdevver 2.24 +%global libbytesizever 0.3 +%global pyudevver 0.18 + +BuildArch: noarch + +%description +The python-blivet package is a python module for examining and modifying +storage configuration. + +%package -n %{realname}-data +Summary: Data for the %{realname} python module. + +BuildRequires: make +BuildRequires: systemd + +Conflicts: python-blivet < 1:2.0.0 +Conflicts: python3-blivet < 1:2.0.0 + +%description -n %{realname}-data +The %{realname}-data package provides data files required by the %{realname} +python module. + +%if %{with python3} +%package -n python3-%{realname} +Summary: A python3 package for examining and modifying storage configuration. + +%{?python_provide:%python_provide python3-%{realname}} + +BuildRequires: gettext +BuildRequires: python3-devel +BuildRequires: python3-setuptools + +%{?__python3:Requires: %{__python3}} +Requires: python3-six +Requires: python3-pyudev >= %{pyudevver} +Requires: parted >= %{partedver} +Requires: python3-pyparted >= %{pypartedver} +Requires: libselinux-python3 +Requires: python3-blockdev >= %{libblockdevver} +Recommends: libblockdev-btrfs >= %{libblockdevver} +Recommends: libblockdev-crypto >= %{libblockdevver} +Recommends: libblockdev-dm >= %{libblockdevver} +Recommends: libblockdev-fs >= %{libblockdevver} +Recommends: libblockdev-kbd >= %{libblockdevver} +Recommends: libblockdev-loop >= %{libblockdevver} +Recommends: libblockdev-lvm >= %{libblockdevver} +Recommends: libblockdev-mdraid >= %{libblockdevver} +Recommends: libblockdev-mpath >= %{libblockdevver} +Recommends: libblockdev-nvdimm >= %{libblockdevver} +Recommends: libblockdev-part >= %{libblockdevver} +Recommends: libblockdev-swap >= %{libblockdevver} +Recommends: libblockdev-s390 >= %{libblockdevver} +Requires: python3-bytesize >= %{libbytesizever} +Requires: util-linux >= %{utillinuxver} +Requires: lsof +Requires: python3-gobject-base +Requires: systemd-udev +Requires: %{realname}-data = %{epoch}:%{version}-%{release} + +Obsoletes: blivet-data < 1:2.0.0 + +%if %{without python2} +Obsoletes: python2-blivet < 1:2.0.2-2 +Obsoletes: python-blivet < 1:2.0.2-2 +%else +Obsoletes: python-blivet < 1:2.0.0 +%endif + +%description -n python3-%{realname} +The python3-%{realname} is a python3 package for examining and modifying storage +configuration. +%endif + +%if %{with python2} +%package -n python2-%{realname} +Summary: A python2 package for examining and modifying storage configuration. + +%{?python_provide:%python_provide python2-%{realname}} + +BuildRequires: gettext +BuildRequires: python2-devel +BuildRequires: python2-setuptools + +Requires: python2 +Requires: python2-six +Requires: python2-pyudev >= %{pyudevver} +Requires: parted >= %{partedver} +Requires: python2-pyparted >= %{pypartedver} +Requires: python2-libselinux +Requires: python2-blockdev >= %{libblockdevver} +Recommends: libblockdev-btrfs >= %{libblockdevver} +Recommends: libblockdev-crypto >= %{libblockdevver} +Recommends: libblockdev-dm >= %{libblockdevver} +Recommends: libblockdev-fs >= %{libblockdevver} +Recommends: libblockdev-kbd >= %{libblockdevver} +Recommends: libblockdev-loop >= %{libblockdevver} +Recommends: libblockdev-lvm >= %{libblockdevver} +Recommends: libblockdev-mdraid >= %{libblockdevver} +Recommends: libblockdev-mpath >= %{libblockdevver} +Recommends: libblockdev-nvdimm >= %{libblockdevver} +Recommends: libblockdev-part >= %{libblockdevver} +Recommends: libblockdev-swap >= %{libblockdevver} +Recommends: libblockdev-s390 >= %{libblockdevver} +Requires: python2-bytesize >= %{libbytesizever} +Requires: util-linux >= %{utillinuxver} +Requires: lsof +Requires: python2-hawkey +Requires: %{realname}-data = %{epoch}:%{version}-%{release} + +Requires: systemd-udev +Requires: python2-gobject-base + +Obsoletes: blivet-data < 1:2.0.0 +Obsoletes: python-blivet < 1:2.0.0 + +%description -n python2-%{realname} +The python2-%{realname} is a python2 package for examining and modifying storage +configuration. +%endif + +%prep +%autosetup -n %{realname}-%{realversion} -N +%autosetup -n %{realname}-%{realversion} -b1 -p1 + +%build +%{?with_python2:make PYTHON=%{__python2}} +%{?with_python3:make PYTHON=%{__python3}} + +%install +%{?with_python2:make PYTHON=%{__python2} DESTDIR=%{buildroot} install} +%{?with_python3:make PYTHON=%{__python3} DESTDIR=%{buildroot} install} + +%find_lang %{realname} + +%files -n %{realname}-data -f %{realname}.lang +%{_sysconfdir}/dbus-1/system.d/* +%{_datadir}/dbus-1/system-services/* +%{_libexecdir}/* +%{_unitdir}/* + +%if %{with python2} +%files -n python2-%{realname} +%license COPYING +%doc README.md ChangeLog examples +%{python2_sitelib}/* +%endif + +%if %{with python3} +%files -n python3-%{realname} +%license COPYING +%doc README.md ChangeLog examples +%{python3_sitelib}/* +%endif + +%changelog +* Mon Oct 30 2023 Vojtech Trefny - 3.6.0-8 +- Add support for creating shared LVM setups + Resolves: RHEL-14021 + +* Mon Jul 24 2023 Jan Pokorny - 3.6.0-7 +Backport iSCSI initiator name related fixes: +- Allow changing iSCSI initiator name after setting it + Resolves: rhbz#2083139 +- Add a basic test case for the iscsi module + Related: rhbz#2083139 +- tests: Use blivet-specific prefix for targetcli backing files + Related: rhbz#2083139 +- iscsi: Save firmware initiator name to /etc/iscsi/initiatorname.iscsi + Resolves: rhbz#2084043 +- tests: Improve iscsi_test.ISCSITestCase + Related: rhbz#2083139 + +* Thu May 18 2023 Vojtech Trefny - 3.6.0-6 +- Fix setting kickstart data + Resolves: rhbz#2175166 +- Do not set memory limit for LUKS2 when running in FIPS mode + Resolves: rhbz#2183437 +- Add support for filesystem online resize + Resolves: rhbz#2168680 + +* Tue May 02 2023 Vojtech Trefny - 3.6.0-5 +- Add support for specifying stripe size for RAID LVs + Resolves: rhbz#2142550 + +* Thu Jan 19 2023 Vojtech Trefny - 3.6.0-4 +- Default to encryption sector size 512 for LUKS devices + Resolves: rhbz#2160465 + +* Thu Nov 03 2022 Vojtech Trefny - 3.6.0-3 +- Catch BlockDevNotImplementedError for btrfs plugin calls + Resolves: rhbz#2139169 +- Revert "Adjust to new XFS min size" + Resolves: rhbz#2139187 + +* Fri Oct 21 2022 Vojtech Trefny - 3.6.0-2 +- Skip XFS resize test on CentOS/RHEL 8 + Related: rhbz#2123712 + +* Fri Oct 21 2022 Vojtech Trefny - 3.6.0-1 +- Rebase to the latest upstream release 3.6.0 + Resolves: rhbz#2123712 + +* Thu Aug 18 2022 Vojtech Trefny - 3.4.0-13 +- DDF RAID support using mdadm + Resolves: rhbz#2063791 + +* Mon Jun 20 2022 Vojtech Trefny - 3.4.0-12 +- Add support for NPIV-enabled zFCP devices + Resolves: rhbz#1497087 + +* Thu Jun 02 2022 Vojtech Trefny - 3.4.0-11 +- Fix running gating tests on AWS/Xen machines + Resolves: rhbz#2093207 + +* Thu Jun 02 2022 Vojtech Trefny - 3.4.0-10 +- Fix getting PV info in LVMPhysicalVolume from the cache + Resolves: rhbz#2079220 +- Do not crash when changing disklabel on disks with active devices + Resolves: rhbz#2078801 +- ActionDestroyDevice should not obsolete ActionRemoveMember + Resolves: rhbz#2076958 +- Correctly set vg_name after adding/removing a PV from a VG + Resolves: rhbz#2081276 +- Use LVM PV format current_size in LVMVolumeGroupDevice._remove + Related: rhbz#2081276 +- Add support for creating LVM cache pools + Resolves: rhbz#2055198 + +* Mon Jan 10 2022 Vojtech Trefny - 3.4.0-9 +- Translation update + Resolves: rhbz#2003050 + +* Tue Dec 14 2021 ojtech Trefny - 3.4.0-8 +- Replace all log_exception_info calls with log.info + Resolves: rhbz#2028134 + +* Fri Nov 26 2021 Vojtech Trefny - 3.4.0-7 +- Release number bump + Related: rhbz#1988276 + +* Fri Nov 26 2021 Vojtech Trefny - 3.4.0-6 +- Improve error message printed for missing dependecies + Resolves: rhbz#1988276 +- Use bigger chunk size for thinpools bigger than ~15.88 TiB + Resolves: rhbz#1949953 + +* Wed Aug 4 2021 Vojtech Trefny - 3.4.0-5 +- Fix running upstream test suite in gating + Resolves: rhbz#1990232 + +* Mon Aug 2 2021 Vojtech Trefny - 3.4.0-4 +- Do not set chunk size for RAID 1 + Resolves: rhbz#1987170 + +* Wed Jul 21 2021 Vojtech Trefny - 3.4.0-3 +- Fix resolving devices with names that look like BIOS drive number + Resolves: rhbz#1983309 + +* Wed Jul 7 2021 Vojtech Trefny - 3.4.0-2 +- Fix activating old style LVM snapshots + Resolves: rhbz#1961739 + +* Wed May 5 2021 Vojtech Trefny - 3.4.0-1 +- Rebase to latest upstream release 3.4.0 + Resolves: rhbz#1918357 + +* Tue Feb 9 2021 Vojtech Trefny - 3.2.2-9 +- LVM VDO support + Resolves: rhbz#1509337 + +* Mon Jan 11 2021 Vojtech Trefny - 3.2.2-8 +- Let parted fix fixable issues with partition table + Resolves: rhbz#1846869 +- Fix possible UnicodeDecodeError when reading sysfs attributes + Resolves: rhbz#1849326 + +* Wed Nov 18 2020 Vojtech Trefny - 3.2.2-7 +- Add support for XFS format grow + Resolves: rhbz#1862349 +- Do not limit swap to 128 GiB + Resolves: rhbz#1656485 +- Use UnusableConfigurationError for partially hidden multipath devices + Resolves: rhbz#1877052 +- Fix possible UnicodeDecodeError when reading model from sysfs + Resolves: rhbz#1849326 +- Add basic support for LVM VDO devices + Resolves: rhbz#1828745 + +* Thu Aug 20 2020 Vojtech Trefny - 3.2.2-6 +- Fix name resolution for MD devices and partitions on them + Resolves: rhbz#1862904 +- Fix ignoring disk devices with parents or children + Resolves: rhbz#1866243 + +* Thu Jul 16 2020 Vojtech Trefny - 3.2.2-5 +- set allowed disk labels for s390x as standard ones (msdos + gpt) plus dasd + Resolves: rhbz#1855200 +- Do not use BlockDev.utils_have_kernel_module to check for modules + Resolves: rhbz#1855344 + +* Thu Jul 09 2020 Vojtech Trefny - 3.2.2-4 +- Blivet RHEL 8.3 localization update + Resolves: rhbz#182056 +- Do not use FSAVAIL and FSUSE% options when running lsblk + Resolves: rhbz#1853624 + +* Tue Jun 30 2020 Vojtech Trefny - 3.2.2-3 +- Round down to nearest MiB value when writing ks parittion info + Resolves: rhbz#1850670 + +* Wed Jun 24 2020 Vojtech Trefny - 3.2.2-2 +- Add extra sleep after pvremove call + Resolves: rhbz#1640601 + +* Fri May 22 2020 Vojtech Trefny - 3.2.2-1 +- Rebase to the latest upstream release 3.2.2 + Resolves: rhbz#1714970 + +* Mon Mar 02 2020 Vojtech Trefny - 3.1.0-20 +- add `-y' to lvm.pvcreate + Resolves: rhbz#1768494 + +* Wed Jan 29 2020 Vojtech Trefny - 3.1.0-19 +- Override LVM skip-activation to allow for thorough removal + Resolves: rhbz#1766498 +- Make sure LVs are writable before wiping + Related: rhbz#1766498 +- Fix udev test names so they actually get run. + Related: rhbz#1758102 +- Add recognition of Dell FW RAID to udev.device_is_disk. + Resolves: rhbz#1758102 +- Align base sizes up if smaller than min I/O size. + Resolves: rhbz#1781106 +- Make minimal and optimal alignment getters public. + Related: rhbz#1781106 + +* Tue Nov 19 2019 Vojtech Trefny - 3.1.0-18 +- Check for PV sector size when creating new VG + Resolves: rhbz#1754446 + +* Wed Oct 02 2019 David Lehman - 3.1.0-17 +- Fix util.detect_virt function + Resolves: rhbz#1676935 + +* Mon Aug 05 2019 Vojtech Trefny - 3.1.0-16 +- Minor cleanups to reduce log noise + Related: rhbz#1579375 + +* Mon Jul 15 2019 Vojtech Trefny - 3.1.0-15 +- Do not crash if 'dm.get_member_raid_sets' fails + Resolves: rhbz#1704289 + +* Tue Jul 02 2019 Vojtech Trefny - 3.1.0-14 +- Correctly handle non-unicode iSCSI initiator names + Resolves: rhbz#1632117 + +* Tue Jun 18 2019 Vojtech Trefny - 3.1.0-13 +- Fix reading LV attributes in LVMVolumeGroupDevice.status + Resolves: rhbz#1721381 + +* Fri Jun 14 2019 Vojtech Trefny - 3.1.0-12 +- Deactivate incomplete VGs along with everything else + Resolves: rhbz#1635125 +- Automatically adjust size of growable devices for new format + Resolves: rhbz#1680013 +- Add flag for protecting cdrom devices during populate + Resolves: rhbz#1719648 +- Clean up some errors evident in installer logs + Resolves: rhbz#1579375 +- Use dasd disklabel for vm disks backed by dasds + Resolves: rhbz#1676935 + +* Thu May 16 2019 Vojtech Trefny - 3.1.0-11 +- Various test fixes for RHEL 8 + Related: rhbz#1682561 +- Add upstream test suite to the SRPM + Related: rhbz#1682561 + +* Wed Apr 03 2019 David Lehman - 3.1.0-10 +- Ensure correct type of mpath cache member list. + Related: rhbz#1672971 + +* Mon Feb 25 2019 David Lehman - 3.1.0-9 +- Update to latest translations. + Resolves: rhbz#1608337 +- Require libfc instead of fcoe for offloaded FCoE. + Resolves: rhbz#1575953 +- Use udev to determine if disk is a multipath member. + Related: rhbz#1575953 +- Don't crash if blockdev mpath plugin isn't available. + Resolves: rhbz#1672971 + +* Tue Jan 15 2019 Vojtech Trefny - 3.1.0-8 +- Copy the iSCSI initiator name file to the installed system (vtrefny) + Resolves: rhbz#1664587 + +* Mon Dec 17 2018 Vojtech Trefny - 3.1.0-7 +- Wipe all stale metadata after creating md array (dlehman) + Resolves: rhbz#1639682 + +* Tue Oct 16 2018 David Lehman - 3.1.0-6 +- Fix options for ISCSI functions (vtrefny) + Resolves: rhbz#1635569 + +* Thu Sep 27 2018 Vojtech Trefny - 3.1.0-5 +- arm: add support for EFI on ARMv7 (probinson) + Related: rhbz#1623882 +- Aarch64 platforms: Fix gpt defaults for 64 bit arm platforms (probinson) + Resolves: rhbz#1623882 +- arch: arm: drop get_arm_machine function (probinson) + Related: rhbz#1623882 +- arch: arm: drop omap specifics for partitioning (probinson) + Related: rhbz#1623882 + +* Thu Sep 20 2018 Tomas Orsava - 3.1.0-4 +- Require the Python interpreter directly instead of using the package name +- Related: rhbz#1619153 + +* Wed Sep 19 2018 Vojtech Trefny - 3.1.0-3 +- Check device dependencies only for device actions + Related: rhbz#1605213 +- Allow removing btrfs volumes without btrfs support + Resolves: rhbz#1605213 + +* Tue Aug 21 2018 Vojtech Trefny - 3.1.0-2 +- Create a separate availability check for dmraid support + Resolves: rhbz#1617958 + +* Fri Aug 10 2018 David Lehman - 3.1.0-1 +- Allow configuring default LUKS2 PBKDF arguments using luks_data (vtrefny) + Related: rhbz#1561352 +- Fix the populate_kickstart method in LUKS (vtrefny) + Related: rhbz#1561352 +- Allow specifying extra arguments for PBKDF when creating LUKS2 (vtrefny) + Related: rhbz#1561352 +- Add support for LUKS2 to DeviceFactory (vtrefny) + Resolves: rhbz#1561352 +- DeviceFactory: use min_luks_entropy from kwargs (vtrefny) + Related: rhbz#1561352 +- Fix passing 'min_luks_entropy' when creating LUKS format (vtrefny) + Related: rhbz#1561352 +- Use passphrase/key file when resizing LUKS2 format (vtrefny) + Related: rhbz#1561352 +- Require libblockdev 2.17 (vtrefny) + Related: rhbz#1561352 +- Add support for LUKS2 format (vtrefny) + Related: rhbz#1561352 +- Add initial support for DM Integrity "format" (vtrefny) + Related: rhbz#1561352 +- Do not try to add LUKSDevice in LUKSFormatPopulator (vtrefny) + Related: rhbz#1561352 +- Add support for dm-integrity devices (vtrefny) + Related: rhbz#1561352 +- Fixed various issues preventing successful build (japokorn) + Related: rhbz#1561352 + +* Mon Jul 30 2018 David Lehman - 3.1.0-0.1.b2 +- Do not ignore "Image out-of-sync" internal LVs (vtrefny) +- Fixed error message when slave is missing (japokorn) +- Ensure WWNs are set for multipath and dmraid. (dlehman) +- Use ID_WWN_WITH_EXTENSION for WWNs. (dlehman) +- Ignore pylint error "bad-option-value" for new pylint errors (vtrefny) +- Fix errors found by new pylint 2.0.0 (vtrefny) +- Fix caching logic in ExternalResource. (dlehman) +- Use DiskFile to allow testing missing dependencies as non-root. (dlehman) +- Restore availability caching after disabling for tests. (dlehman) +- Preserve original blockdev plugin list in test cleanup. (dlehman) +- Fix positional/key-word arguments in util.Path (vtrefny) +- fix doc for is_s390() (dan) +- The key size of LUKS should be 0 by default (vponcova) +- Do not use rpm to check for Zanata client (vtrefny) +- Fixed create_device fail behavior (japokorn) +- Fixed KS forcing zerombr onto RO disk (japokorn) +- Fix BIOS device number regex in edd module. (#1552236) (dlehman) +- Shrink devices before growing others with common ancestors. (#1539422) (dlehman) +- Do not copy ksdata. (rvykydal) +- Find and remove stale LVM metadata immediately after creating md array. (dlehman) +- Adapt mock imports for compatibility w/ python2 & python3. (dlehman) +- Use py2-compatible syntax to get system architecture. (dlehman) + +* Mon Jul 16 2018 Vojtech Trefny - 3.1.0-0.3.b1 +- Remove btrfs from requested libblockdev plugins (vtrefny) + +* Wed Jul 11 2018 Vojtech Trefny - 3.1.0-0.2.b1 +- Force command line based libblockdev LVM plugin (vtrefny) + +* Wed May 02 2018 David Lehman - 3.1.0-0.1.b1 +- Add 'nvdimm' tag for NVDIMM namespaces (vtrefny) +- Add test for NVDIMMNamespaceDevicePopulator (vtrefny) +- Add populator helper for NVDIMM namespaces (vtrefny) +- Add 'NVDIMMNamespaceDevice' device representing NVDIMM namespaces (vtrefny) +- Add a function for identifying NVDIMM namespaces (vtrefny) +- Add a singleton for NVDIMM namespaces management (vtrefny) +- Add NVDIMM plugin to list of requested plugins (vtrefny) + +* Fri Apr 20 2018 David Lehman - 3.0.1-1 +- Weak dependencies for libblockdev plugins (japokorn) +- Translate log levels from libblockdev to python log levels (vtrefny) +- Try to wait after stopping an MD array (vtrefny) +- Replace deprecated iscsi_firmware dracut option (rvykydal) +- Fix how we check return value for call_sync in safe_dbus (vtrefny) +- Conditionalize the Python 2 subpackage and don't build it on EL > 7 and + Fedora > 28 (miro) +- Fix python3 conditional in rpm spec file. (dlehman) +- Fix upstream URL in spec (vtrefny) +- Allow device specification by node to udev.get_device. (#1524700) (dlehman) +- Do not try to update potfile during make all (vtrefny) +- Use '-p1' when applying patches with autosetup (vtrefny) +- Remove dependency on pocketlint (vtrefny) +- Dasd is a valid label type on s390x (#1538550) (vponcova) +- fcoe: remove /etc/fcoe dir if it exists before copying configuration + (#1542846) (rvykydal) +- Avoid UnitTest.subTest due to python2 incompatibility. (dlehman) +- Adapt action test mock imports for compatibility w/ python2 & python3. + (dlehman) +- Use explicit super() syntax in config actions for py2 compat. (dlehman) +- Use libblockdev runtime dependency checks (#1501249) (vtrefny) +- Fix minor typos (yurchor) + +* Mon Apr 02 2018 David Lehman - 1:3.0.0-0.6.1.b1 +- Use bcond for with python3, allow it on RHEL > 7 (mhroncok) +- Conditionalize the Python 2 subpackage and don't build it on EL > 7 and Fedora > 28 (mhroncok) + +* Tue Mar 20 2018 David Lehman - 1:3.0.0-0.6.b1 +- Don't use a 'wwn' kwarg for MDBiosRaidArrayDevice (#1557957) (awilliam) + +* Sat Mar 17 2018 Iryna Shcherbina - 1:3.0.0-0.5.b1 +- Update Python 2 dependency declarations to new packaging standards + (See https://fedoraproject.org/wiki/FinalizingFedoraSwitchtoPython3) + +* Mon Mar 12 2018 David Lehman - 1:3.0.0-0.4.b1 +- Allow device specification by node to udev.get_device. (#1524700) + +* Tue Mar 06 2018 Vojtech Trefny - 1:3.0.0-0.3.b1 +- Dasd is a valid label type on s390x (#1538550) + +* Fri Feb 09 2018 Fedora Release Engineering - 1:3.0.0-0.2.b1 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_28_Mass_Rebuild + +* Wed Nov 08 2017 David Lehman - 3.0.0-0.1.b1 +- Add some reasonable default value for LANG variable in size_test (vtrefny) +- Remove ksdata from Blivet. (dlehman) +- Fix AttributeError in fsminsize (#1502587) (vtrefny) +- Remove Blivet.write_dasd_conf and now-unused Blivet.write. (dlehman) +- Move blivet.partspec into pyanaconda. (dlehman) +- Make uboot partition weight match analogs on other platforms. (dlehman) +- Move some cmdline option checking into Flags. (dlehman) +- Move platform module into pyanaconda. (dlehman) +- Add and use new platform detection functions in arch. (dlehman) +- Move disklabel selection logic into DiskLabel. (dlehman) +- Move new partition weight calculation into PartitionDevice. (dlehman) +- Move osinstall and autopart into pyanaconda. (dlehman) +- Move default thin pool space reservation into devices.lvm. (dlehman) +- DM device subsystem is now obtained by libblockdev (japokorn) +- Document DBus interface. (dlehman) +- Mark the DBus interface as unstable. (dlehman) +- Do not try to use protected disks for autopart (vtrefny) +- Use InstallerStorage in setupDiskImagesNonZeroSizeTestCase (vtrefny) +- Clearpart test tag fixes (japokorn) +- Added support for device tags (japokorn) +- Use Ansible playbook to install test dependencies (vtrefny) +- Use addCleanup for VM tests too (vtrefny) +- Skip tests when SELinux is disabled (japokorn) +- Revert "Use libmount for MountsCache" (vtrefny) +- Only run log_method_call when flags.debug is set. (dlehman) +- Adjust Makefile and spec file for Python 2 compatibility (vtrefny) +- Adapt to anaconda_log rename (mkolman) +- Followup for custom six move for mock. (dlehman) +- Silence pylint with regard to custom six move of mock. (dlehman) +- Allow overriding PYTHONPATH when running unit tests. (dlehman) +- Supply some missing patches during device name tests. (dlehman) +- Allow time for event handling in unit tests. (dlehman) +- python2: Don't try to call unbound method w/ wrong class type. (dlehman) +- python2: threading compatibility. (dlehman) +- python2: compatibility for wraps when used on methods. (dlehman) +- python2: adapt to absence of inspect.signature. (dlehman) +- python2: python2 has no unittest.assertLogs. (dlehman) +- python2: Handle unittest.assertRaisesRegex rename. (dlehman) +- python2: Add a custom six move for mock. (dlehman) +- python2: EddEntry support for len() and indexing. (dlehman) +- python2: Don't use 'default' kwarg to 'min' (dlehman) +- python2: Use six.wraps instead of functools.wraps. (dlehman) +- python2: Use six.raise_from for chained exceptions. (dlehman) +- python2: Use six.next for iterator advancement. (dlehman) +- python2: Explicit args to super function. (dlehman) +- python2: Explicitly declare new-style classes. (dlehman) +- python2: Use six.add_metaclass instead of metaclass kwarg. (dlehman) +- Catch AttributeError if pyanaconda is missing in populator_test. (dlehman) +- Use relative imports in blivet.dbus.blivet. (dlehman) +- pylint: disable pylint warning for InstallerStorage.get_free_space (vtrefny) +- pylint: ignore some pylint warnings in tests (vtrefny) +- Use "flags.keep_empty_ext_partitions" instead of "installer_mode" (vtrefny) +- Add a WWN attr to all disk device classes. (dlehman) +- Fix flag access in selinux test. (dlehman) +- Collect HW RAID info before populating devicetree. (dlehman) +- Add HW RAID properties to DiskDevice. (dlehman) +- Add a devicelibs module for disks. (dlehman) +- Add 'jbod' as an alias for 'linear' RAID level. (dlehman) +- Add some tests for DependencyGuard (dlehman) +- Introduce the discard_new flag and use it (vpodzime) +- Use the 'C.UTF-8' locale instead of '' (vpodzime) +- Add anaconda-core, libvirt and paramiko to TEST_DEPENDENCIES (vpodzime) +- Get rid of the merge-pr script (vpodzime) +- Adjust vmtest to new DeviceFactory constructor API (vtrefny) +- Obtain factory defaults from passed-in device, if there is one. (dlehman) +- Use **kwargs for device factory ctor. (dlehman) +- Use a property to adjust factory size based on encrypted bool. (dlehman) +- Functional testing: Add support for libvirt authentication (vtrefny) +- Fixed merge error (japokorn) +- Enable LVMOnMDTestCase (vtrefny) +- LVMThinSnapShotTestCase: Fix creating of the thin snapshot (vtrefny) +- Create a better test summary when running tests in a VM (vtrefny) +- Add a script to run tests in a virtual machine (vtrefny) +- Move BlivetResetTestCases from ImageBackedTestCase to VMBackedTestCase + (vtrefny) +- Add a test case for tests running in a virtual machine (vtrefny) +- Do not try to create format for snapshots in create_device (vtrefny) +- Use None as mountpoint for new snapshots (vtrefny) +- Do not try to unset flags on other devices than partitions (vtrefny) +- Fix TypeError when calling blivet.reset() (vtrefny) +- Broke backwards API compatibility of LUKS handling (japokorn) +- Default to LVM in the device factory. (dlehman) +- Add callbacks for populate (vpodzime) +- Fix checks when changing fslabel using actions (vtrefny) +- Remove deprecated method udev.device_is_realdisk (vtrefny) +- Use libmount for MountsCache (vtrefny) +- Fix initialization of ignored, exclusive disks. (dlehman) +- Fix devicetree tests to use callbacks instead of record_change. (dlehman) +- Change udev.device_is_disk to match disks only (vtrefny) +- Fix udev.resolve_glob to match device path too (vtrefny) +- Add tests for configuration actions (vtrefny) +- Allow changing format label using configuration actions (vtrefny) +- Add new actions for configuring formats and devices (vtrefny) +- Quickfix of merge bugs (japokorn) +- Remove action objects before resetting via dbus. (dlehman) +- Clean up dbus object management a bit. (dlehman) +- Only overwrite current format if the new one is different. (dlehman) +- Add a Factory method to DBusBlivet. (dlehman) +- Update example dbus client to account for Format interface. (dlehman) +- Adjust zanata version for new branch. (dlehman) +- Allow custom chunk size specification for MDRaidArrayDevice (vtrefny) +- Add zanata-python-client to TEST_DEPENDENCIES (bcl) +- Allow custom chunk size specification for MDRaidArrayDevice (vtrefny) +- Add zanata-python-client to TEST_DEPENDENCIES (bcl) +- Add a Commit method to DBusBlivet. (dlehman) +- Update unit tests. (dlehman) +- Move removed devices and formats into different subtrees. (dlehman) +- Use the object manager to look up objects. (dlehman) +- Add mappings of objects by id and object path to ObjectManager. (dlehman) +- Add an id property to DBusObject. (dlehman) +- Add an Action interface to the dbus service. (dlehman) +- Make sure DBusFormat's Type property is always a string. (dlehman) +- Pass blivet objects to blivet methods. (dlehman) +- Fix root detection on btrfs in rescue mode (vtrefny) +- Use device's mount options when mounting existing systems (vtrefny) +- Add a Commit method to DBusBlivet. (dlehman) +- Update unit tests. (dlehman) +- Move removed devices and formats into different subtrees. (dlehman) +- Use the object manager to look up objects. (dlehman) +- Add mappings of objects by id and object path to ObjectManager. (dlehman) +- Add an id property to DBusObject. (dlehman) +- Add an Action interface to the dbus service. (dlehman) +- Make sure DBusFormat's Type property is always a string. (dlehman) +- Pass blivet objects to blivet methods. (dlehman) +- Move some more installer-specific methods and values into blivet.osinstall. + (sbueno+anaconda) +- Mv copy_to_system from blivet.util to blivet.osinstall (sbueno+anaconda) +- Get rid of flags.installer_mode (sbueno+anaconda) +- Create flags.keep_empty_ext_partitions (sbueno+anaconda) +- Create flags.selinux_reset_fcon (sbueno+anaconda) +- Create flags.auto_dev_updates (sbueno+anaconda) +- Add a Format interface to the dbus service. (dlehman) +- Always require the rounding mode to be specified for Size (vpodzime) +- Add method DBusBlivet.InitializeDisk. (dlehman) +- Add a unit test for DBusBlivet.RemoveDevice. (dlehman) +- Maintain a mapping of object path to DBusDevice in DBusBlivet. (dlehman) +- Correctly handle failures in ResolveDevice. (dlehman) +- Add a RemoveDevice method to DBusBlivet. (dlehman) +- Convert event handling change accounting to use blivet callbacks. (dlehman) +- Add a set of callbacks for changes to blivet's view of things. (dlehman) +- Allow replacing an active format within blivet's model. (dlehman) +- Add the beginnings of an example client. (dlehman) +- Add a Device interface to the dbus service. (dlehman) +- Add an ObjectManager interface to the dbus service. (dlehman) +- Make DBusBlivet names more dbus-like. (dlehman) +- Clean up org.freedesktop.DBus.Properties code in DBusObject a bit. (dlehman) +- Move constants into a separate module. (dlehman) +- Convert some private methods to public properties. (dlehman) +- Import the whole dbus module in a couple of places. (dlehman) +- Add a minimal dbus interface. (dlehman) +- Rearrange the setup call to minimize changes on updates. (dlehman) +- Remove unused readthedocs code from setup.py. (dlehman) +- Ignore all merge commits when making rpm log. (dlehman) +- Isolate some boot device operations in blivet.partitioning. (sbueno+anaconda) +- Move bootloader stuff from Blivet to InstallerStorage. (sbueno+anaconda) +- Some small, stupid bugfixes to first installer isolation patch set. + (sbueno+anaconda) +- LVM data are now global (japokorn) +- Update api to reflect changes from isolating installer-specific code. + (sbueno+anaconda) +- Update examples and test cases for changes from isolating installer code. + (sbueno+anaconda) +- Get rid of blivet.blivet's last deps on blivet.osinstall (sbueno+anaconda) +- Get rid of blivet.blivet's dependence on blivet.osinstall.FSSet + (sbueno+anaconda) +- Mv installer-specific functions to install. Create InstallerStorage. + (sbueno+anaconda) +- Move StorageDiscoveryConfig from blivet.blivet to blivet.osinstall + (sbueno+anaconda) +- Move some StorageDiscoveryConfig attrs into Blivet. (sbueno+anaconda) +- Retrieve udev info as needed in handle_format. (dlehman) + +* Tue Sep 19 2017 Vojtech Trefny - 2.1.11-1 +- Remove build requires for pocketlint (rkuska) +- edd_test: don't run on non-x86 (pjones) +- Added support for device tags (japokorn) +- fcoe: don't use dcb for autoconnecting of bnx2x and bnx2fc (#1261703) + (rvykydal) +- fcoe: replace fipvlan with fcoemon (#1085325) (rvykydal) +- Do not use read-only mode for e2fsck (vpodzime) +- Fixed behavior when selinux is disabled (japokorn) +- Do file system check before resize (#1484575) (vpodzime) + +* Thu Aug 17 2017 Vojtech Trefny - 2.1.10-1 +- Use addCleanup for test cleanup instead of clening in tearDown (vtrefny) +- No longer skip test w/o selinux; mocked (japokorn) +- Skip tests when SELinux is disabled (japokorn) +- New test for selinux context setting when mounting (japokorn) +- Add tests for disklabel type selection and partition weight. (dlehman) +- Do not use package version to check version of installed tools (vtrefny) +- Update the upstream git URL (vpodzime) +- Stop enforcing obsolete limits on partition count. (#1460668) (dlehman) +- Do not run FS check as part of updating (re)size info (vpodzime) +- Change how we run e2fsck to check ext filesystems (vpodzime) +- Round the recommended thpool metadata size to extents (vpodzime) +- Respect thin pool's min size when setting its req_size (vpodzime) +- Don't crash during populate when lvm plugin is missing. (dlehman) +- Actually add space for LUKS metadata when encrypting a VG (vpodzime) +- Only consider old and new device sizes when not growing to max (vpodzime) +- Do not reserve space for LVM metadata twice (vpodzime) +- Do not create a temporary list for sum() (vpodzime) +- Refer to self.container as self.vg in the LVMFactory (vpodzime) +- Add a couple of extra comments and docstrings to factories (vpodzime) +- Use existing VG's PE size if available in LVMFactory (vpodzime) +- Add comments warning before a weird nomenclature in factories (vpodzime) +- Don't let device state block modification of the model. (dlehman) +- Fix error message for format create w/ missing external dep. (dlehman) +- Expand coverage of devices_test.dependencies_test a bit. (dlehman) +- Account for external dep availabilty in StorageDevice.controllable. (dlehman) +- Add the appropriate external dependency to LUKSDevice. (dlehman) + +* Thu Jun 01 2017 Vojtech Trefny - 2.1.9-1 +- Adapt to logging module name change (mkolman) +- Updated calls to avoid log spamming (japokorn) +- Add a script for generating and pushing updated documentation (vtrefny) +- pylint: ignore some false positive warnings in blivet.py and lvm.py (vtrefny) +- pylint: remove unused false positives from pocketlint config (vtrefny) +- pylint: disable false positive "not-context-manager" for threading.Lock + (vtrefny) +- pylint: ignore "arguments-differ" warnings in blivet.size.Size (vtrefny) +- pylint: fix various "arguments-differ" warnings (vtrefny) +- pylint: remove init from platform.X86 (vtrefny) +- pylint: fix various errors in tests (vtrefny) +- pylint: ignore "arguments-differ" warning for "do_tasks" method (vtrefny) +- pylint: fix false positive for "catching-non-exception" (vtrefny) +- pylint: fix argument name for Device._remove_parent/_add_parent (vtrefny) +- Always mount & unmount an XFS file system when writing new UUID (vpodzime) +- Do not remove manually created extended partitions (#1440150) (vtrefny) +- Look the disk up for a partition by name not sys_name (vpodzime) +- Disable pylint "no-member" warnings for re module constants (vtrefny) +- Allow custom chunk size specification for MDRaidArrayDevice (vtrefny) +- Add RAID chunk size to the generated kickstart file (vtrefny) +- Use structured logging for the anaconda logger (mkolman) +- Use distutils.spawn.find_executable instead of our custom code (vpodzime) +- Add a method to reset file system's UUID (vpodzime) +- Try to mount and unmount an XFS FS when writing UUID (vpodzime) +- Add a method for a file system to generate a new UUID (vpodzime) +- tests/fsuuid: Implement checking invalid UUIDs (aszlig) +- formats/swap: Support setting UUID (aszlig) +- tests: Add a series of tests for setting UUIDs (aszlig) +- tests: Add tests to check the UUID format checkers (aszlig) +- tasks: Implement setting UUID after FS creation (aszlig) +- formats/fs: Implement setting UUID during mkfs (aszlig) +- formats/fs: Add functionality for checking UUIDs (aszlig) +- tasks/fsmkfs: Add arguments for setting UUID (aszlig) +- Properly unset mountpoint of a snapshot's format (vpodzime) +- Update snapshot's format's exists flag based on its origin (vpodzime) + +* Wed Apr 19 2017 Vojtech Trefny - 2.1.8-1 +- Fix "unknown" SAS device sysfs parsing. (adamw) +- Reserve space in a VG when using LVMThinPFactory (vpodzime) +- Reserve space in a VG instead of padding thin pools on autopart (vpodzime) +- Focus the nonzero disk image size test a bit. (dlehman) +- Add missing tearDown method to luks resize test case. (dlehman) +- Fix some flag stomping in tests. (dlehman) +- Remove the useless method requiredDiskLabelType (vponcova) +- FBA DASD should use the msdos disk label type (vponcova) +- Be more careful when checking for udisks-iscsi availability (vpodzime) +- Do not allow resize of devices with no/unrecoginized formatting. (#1033778) + (dlehman) +- Clean up parent/child relations on partition ctor error. (#1383873) (dlehman) +- Use all ancestors when adding RAID disks to exclusiveDisks (vtrefny) +- Fix detection of linear MD RAID (vtrefny) +- Add 'discard' option to crypttab for newly created LUKS (vpodzime) +- Loop devices w/o backing file are now ignored (japokorn) +- Set parted boot flag when creating EFI filesystem (vtrefny) +- formats/fs: Set NTFS to be formattable (aszlig) +- Do not try to search for 'tmpfs' devices in udev database (vtrefny) +- Fix resize test in fstesting (vtrefny) +- Fix task availability test (vtrefny) +- Shallow copy another alignment property (#1408282) (awilliam) +- Fix the test dependencies (vpodzime) +- Add 'systemd-udev' to dependencies (#1392591) (vtrefny) + +* Sat Feb 11 2017 Fedora Release Engineering - 1:2.1.7-7 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_26_Mass_Rebuild + +* Sat Dec 24 2016 Adam Williamson - 1:2.1.7-6 +- Actually apply the patch mentioned in -5 + +* Fri Dec 23 2016 Adam Williamson - 1:2.1.7-5 +- backport GH#530 to fix #1408282 (crash with Python 3.6) + +* Mon Dec 19 2016 Miro Hrončok - 1:2.1.7-4 +- Rebuild for Python 3.6 + +* Tue Dec 6 2016 Vratislav Podzimek - 2.1.7-3 +- Add 'systemd-udev' to dependencies (#1392591) (vtrefny) + +* Mon Nov 21 2016 Vratislav Podzimek - 2.1.7-2 +- Fix "unknown" SAS device sysfs parsing. (#1394026) (awilliam) + +* Mon Nov 21 2016 Vratislav Podzimek - 2.1.7-1 +- Require BlockDev 2.0 in the gi.require_version() call (vpodzime) +- Fix detection of 'macefi' partitions (#1393846) (awilliam) +- Add device symlinks to the PVs dictionary for MD RAID PVs (#1389130) + (vpodzime) +- iSCSI: turn `iscsi.initiator_set` into a property (awilliam) +- iSCSI: Store auth info in NodeInfo tuples (awilliam) +- Use correct type for port in GVariant tuple (awilliam) +- Use a list comprehension for _to_node_infos (awilliam) +- Device name now checked only for new devices (japokorn) +- Remove several redundant teardown calls. (dlehman) +- Cache and reuse data about multipath members (vpodzime) +- Remove some obsolete pvscan calls. (dlehman) + +* Tue Oct 04 2016 David Lehman - 2.1.6-1 +- add missing populators to populator.helpers (awilliam) + +* Mon Sep 26 2016 David Lehman - 2.1.5-1 +- Move parted changes to after format destroy. (#1378162) (dlehman) +- Add translators comment for unsupported disklabel names (vtrefny) + +* Tue Sep 20 2016 David Lehman - 2.1.4-1 +- Revert unsupported clearing of parted partition 'system'. (dlehman) +- Make sure we create a proper GVariant tuple as args (#1375712) (vpodzime) +- Do not include both size and percent in logvol ks cmd. (dlehman) +- Ignore NVDIMMs at OS installation time. (dlehman) +- Don't crash if lvm refuses to activate an lv. (dlehman) + +* Wed Sep 14 2016 David Lehman - 2.1.3-1 +- Remove some deprecated/obsolete bits from spec file. (dlehman) +- Use %%global instead of %%define for specfile macros. (dlehman) +- Fix URLs pointing to blivet resources. (dlehman) +- UUID is now cleaned when destroying format (japokorn) +- Support disk tags as disk specification for new partitions. (dlehman) +- Add tags property to Device with some defaults for disk variants. (dlehman) +- Add checks to git-multi-merge script (jkonecny) +- UUID now set correctly when reformatting partition (japokorn) +- Eliminate mountpoint symlinks when looking for mounted device (vtrefny) +- iscsi: allow installing bootloader on offload iscsi disks (qla4xxx) + (#1325134) (rvykydal) + +* Fri Aug 05 2016 David Lehman - 2.1.2-1 +- Update release notes to include previous two releases. (dlehman) +- Allign the LV's size up to set the base size for growing (vpodzime) +- Ensure biosboot shows up in kickstart (#1242666) (rmarshall) +- Add tests for the new LV from LVs actions (vpodzime) +- Make sure to add/remove internal LVs when adding/removing a compound LV + (vpodzime) +- Make sure all LVs to create a new LV from are in the DT (vpodzime) +- Make sure internal LVs are added/removed to/from DT properly (vpodzime) +- Make LVs depend on their internal LVs (vpodzime) +- Do not add the LV to devicetree in new_lv_from_lvs() (vpodzime) +- Require libblockdev version with all the functions we need (vpodzime) +- Allow for cascade creation of LVs from LVs (vpodzime) +- Fix removing PVs after removing VG (#1358067) (vtrefny) +- Pass arguments to get_member_raid_sets() in the correct order (#1225184) + (vpodzime) +- Use the new way extra information is provided for LVs (vpodzime) +- Add a method to determine if a udev device is a disk. (vtrefny) +- Fix udev.resolve_glob to match device path too (vtrefny) +- Adapt to the old-new storaged API paths (vpodzime) +- Handle an mpath name as lone exclusive disk. (#984059) (dlehman) +- Add unit tests for disk filter. (dlehman) +- Allow creation of a new LV from other LVs (vpodzime) +- Removed test for snapshot origin existance (jkonecny) +- Don't require existing origin when modeling snapshot (jkonecny) +- Update size for dmraid arrays found during populate. (#1269662) (dlehman) +- Restore the correct default partition table type for AArch64 EFI. (dmarlin) +- Fix args to cancel_disk_actions call from hide(). (dlehman) +- Fix not enough free space after creating extended partition (#1252350) + (vtrefny) +- Add some more unit tests for DeviceTree. (dlehman) +- Add tests for critical format methods. (dlehman) +- Split and include cache data and metadata sizes properly (vpodzime) +- Use internal LVs (if any) to calculate space used by existing LVs (vpodzime) +- Remove an unused calculation of VG's RAID PVs (vpodzime) +- Only include padding to nonexisting thin pools' vg_space_used (vpodzime) +- Require pyudev 0.18 or newer (vtrefny) +- Do not use deprecated pyudev methods (vtrefny) +- Show changes for each branch in git-multi-merge before pushing (vpodzime) + +* Mon Jun 06 2016 David Lehman - 2.1.1-1 +- Ignore all merge commits when making rpm log. (dlehman) +- Try harder to identify a partition's disk when necessary. (dlehman) +- Add some fallback methods for finding a partition's disk. (dlehman) +- Include devices on disklabels unsupported by parted in the devicetree. + (dlehman) +- Don't traceback if we fail to examine an md member. (dlehman) +- Disklabel commit errors can occur for disks, too. (dlehman) +- Add unit tests for device methods. (dlehman) +- ARM platforms: support both msdos and gpt partitions (pbrobinson) +- LUKS data moved to singleton (japokorn) +- Add the P_ keyword to xgettext. (dshea) +- Add xfs to default filesystem types (rmarshall) +- Fix blivet constructor fs support check (rmarshall) +- Do not put LVM stuff into syslog (vpodzime) +- Kickstart missing bootloader partitions (#1242666) (rmarshall) + +* Thu May 12 2016 David Lehman - 2.1.0-1 +- Add name of problematic device to UnusableConfigurationError (vtrefny) +- LVM data are now global (japokorn) +- Allow custom chunk size specification for MDRaidArrayDevice (vtrefny) +- Mock all blockdev's listing functions for populator tests (vpodzime) +- Add zanata-python-client to TEST_DEPENDENCIES (bcl) + +* Thu May 12 2016 David Lehman - 2.0.3-1 +- Fix protected status for extended partitions (vtrefny) +- Improve documentation of the udev.resolve_glob() function (vpodzime) +- Remove the locale list from zanata.xml (dshea) +- Do not test translated strings during make ci. (dshea) +- Squashed 'translation-canary/' changes from 5a45c19..3bc2ad6 (dshea) +- Fix root detection on btrfs in rescue mode (vtrefny) +- Use device's mount options when mounting existing systems (vtrefny) +- Ignore pylint being confused with our mixins' properties (vpodzime) +- Get back to use ROUND_HALF_UP by default (vpodzime) +- Let Python import the formats for us (vpodzime) +- Only call resolve_devspec() in _get_active_mounts() for real devices + (vpodzime) +- Call is_mpath_member() only when it makes sense (dlehman) +- Break the cycle in LVMPhysicalVolume.destroy (#1331630) (vpodzime) +- Use libbytesize's translations for Size tests (vpodzime) +- Compare sizes instead of numbers of sectors (vpodzime) +- Obsolete python-blivet and blivet-data packages. (dlehman) +- Increase the default size of /boot to 1 GB. (#377) (clumens) +- Do not add btrfs volume subvolid to subvolumes mountopts (#1306808) (vtrefny) +- A simple script for multi-merges we now do (vpodzime) +- Update CONTRIBUTING file to match current practices. (dlehman) +- Only import the 'iscsi' singleton when really needed (vpodzime) +- Correctly recognize internal RAID LVs (vpodzime) +- Do not add mdarray with no slave (#1321393) (vtrefny) +- Make sure to add hyperPAV aliases to dasd.conf. (sbueno+anaconda) +- LVM data are now global (japokorn) +- Preserve traceback when re-raising exceptions (vpodzime) + +* Mon Apr 04 2016 David Lehman - 2.0.2-1 +- Fix mistake from PEP8 conversion. (#1323012) (dlehman) +- Set both req_size and size of thin pool when growing LVM (vpodzime) +- Retrieve udev info as needed in handle_format. (#1322943) (dlehman) +- Fix requires after subpackage switcharoo. (dlehman) +- Fix package naming in spec file. (dlehman) + +* Tue Mar 29 2016 David Lehman - 2.0.1-1 +- Make sure EddMatcher.root is a string. (dlehman) +- Move per-thread change accounting to a function. (dlehman) +- Add missing conf kwarg in call to PopulatorMixin ctor. (dlehman) +- Fixes found while porting anaconda to blivet-2.0 (dlehman) +- Mock all blockdev's listing functions for populator tests (vpodzime) + +* Wed Mar 09 2016 David Lehman - 2.0.0-1 +- Bump version to 2.0.0 + +* Wed Mar 09 2016 David Lehman - 2.0.0-0.1.b1 +- Make sure we use the Size class properly (vpodzime) +- Don't store size as int in SameSizeSet (vpodzime) +- Use libbytesize's Size class as a base for our Size class (vpodzime) +- Remove the second section about LUKS resize from release notes (vpodzime) +- Streamline the TOC to only include top-level sections. (dlehman) +- Adjust section hierarchy in intro doc. (dlehman) +- Move testing docs into a file of their own. (dlehman) +- Add an api specification to the docs. (dlehman) +- Add luks resize and API stability efforts to release notes. (dlehman) +- Clean up some of the singleton usage. (dlehman) +- Drop sphinx mocking. (dlehman) +- Reset container_uuid when removing PV from a VG (vtrefny) +- Remove "destroy_format" method from docs (vtrefny) +- Fix AttributeError in pv_free_info (vtrefny) + +* Wed Feb 24 2016 David Lehman - 2.0.0-0.1.a1 +- Update zanata config for 2.0 branches. (dlehman) +- Remove cleanup of rc-release relics from ci target. (dlehman) +- Don't run rc-release as part of ci for now. (dlehman) +- Regenerate blivet.pot. (dlehman) +- Specify encoding of pvtask.py to placate gettext. (dlehman) +- Silence pylint complaint about passed callable. (dlehman) +- Tear down devices on disk images before tearing down the images. (dlehman) +- Update check for thin pool to work with new lv classes. (dlehman) +- Use Blivet.do_it instead of calling ActionList.process in factory example. (dlehman) +- Get rid of examples.common. (dlehman) +- Allow for pre-release builds. (dlehman) +- Fix load_module call in translation-canary. (dlehman) +- Remove a couple of stray python2 invocations. (dlehman) +- Do not call pvmove when removing an empty PV from VG. (vtrefny) +- Add task for finding LVMPhysicalVolume format size (vtrefny) +- Fix TypeError/AttributeError when adding thinpools and snapshots (vtrefny) +- Fix current_size name in StorageDevice.update_size (vtrefny) +- Ignore PEP8 errors E402 and E731 (vtrefny) +- Make sure all checks run on 'make check' (vtrefny) +- PEP8 fixes (vtrefny) +- Add LUKS resize to release notes (vtrefny) +- Add test for LUKS format resize (vtrefny) +- Add a task for finding the size of a LUKS device (vtrefny) +- Use DeviceFormatError and FormatResizeError in DeviceFormat (vtrefny) +- Add LUKS resize support to resize_device method (vtrefny) +- Define min_size for encrypted devices (vtrefny) +- Do not teardown partition when resizing encrypted partition (vtrefny) +- Make partitions with children resizable (vtrefny) +- Make LUKS format resizable (vtrefny) +- Make LUKSDevice resizable (vtrefny) +- Make lukstasks and dfresize task pep8 compliant (vtrefny) +- Add a LUKS resize task. (amulhern) +- Make a top level device format resizing task class. (amulhern) +- Move resize related methods from FS to DeviceFormat (vtrefny) +- Disable spurious import-error from pylint. (dlehman) +- Add blivet.events package to setup.py. (dlehman) +- Remove unused util import from prepboot.py. (dlehman) +- Remove deprecated methods and properties. (dlehman) +- Flesh out the release notes. (dlehman) +- Include python3-bugzilla when running tests (bcl) +- Cleanup wildcard import in misc_test.py (bcl) +- Add an example of event monitoring. (dlehman) +- Mask uevents when updating parted.Disk. (dlehman) +- Handle first-time open of luks devices. (dlehman) +- Add a device populator for opened/decrypted LUKS devices. (dlehman) +- Update sysfs path before updating size in StorageDevice ctor. (dlehman) +- Validate event handling callbacks. (dlehman) +- Hook up the event notify callback. (dlehman) +- Account for changes made in response to each event. (dlehman) +- Add facilities for reporting exceptions that occur in threads. (dlehman) +- Add event handlers via a DeviceTree mixin class. (dlehman) +- Add PopulatorHelper method to update device/formats. (dlehman) +- Add classes for managing external events. (dlehman) +- Add methods to wrap helper getters. (dlehman) +- Only settle udev queue in get_devices when not handling events. (dlehman) +- Allow passing a device to any PopulatorHelper constructor. (dlehman) +- Implement DiskLabelFormatPopulator._get_kwargs. (dlehman) +- Add a property indicating the type to pass to get_format. (dlehman) +- Add functions for resolving between block major and device type. (dlehman) +- Plumb modparent through DeviceTree.recursive_remove. (dlehman) +- Add a flag to preserve the root device in recursive_remove. (dlehman) +- Add container_uuid r/w property to container member format classes. (dlehman) +- Set VG format as existing as part of VG creation. (dlehman) +- Remove old hack meant to remove stale metadata. (dlehman) +- Store disklabel and partition UUIDs when available. (dlehman) +- Add a method to re-read the disklabel from disk. (dlehman) +- Use wipefs to remove disklabels. (dlehman) +- Add support for passing the new size into StorageDevice.updateSize. (dlehman) +- Add a method to cancel all actions related to a specified disk. (dlehman) +- Add a flag to ActionList to indicate in-progresss action processing. (dlehman) +- Avoid failure to generate unit test API docs. (dlehman) +- Add a console logger and a function to activate it. (dlehman) +- Make LoopDevice size consistent with other device types. (dlehman) +- Don't try to use a name bound via 'as' outside the try/except block. (dlehman) +- Remove code for notifying the kernel of changes to block devices. (dlehman) +- Add dependency checks for iSCSI operations (vpodzime) +- Add decorator for guarding methods with external dependency checks (vpodzime) +- Add a function for testing if some DBus object is available (vpodzime) +- Use namedtuple for target info and tiny class for login infos (vpodzime) +- Use the storaged's iSCSI DBus API instead of libiscsi (vpodzime) +- Use the ) +- Add a module for doing DBus operations in the safest possible way (vpodzime) +- Do not retry interruptible system calls. (dshea) +- Document the LV class unification changes in the release notes (vpodzime) +- Adapt our tests to the changes in representation of LVs (vpodzime) +- Adapt our code to changes in the representation of LVs (vpodzime) +- Rewrite the code for representing LVs (vpodzime) +- Add a test for the to-be-used ) +- Add a decorator for guarding methods and properties with a property (vpodzime) +- Transform the is_name_valid() into an instance method (vpodzime) +- Add tests for FS overhead methods (jkonecny) +- Add more class methods for better use of metadata (jkonecny) +- Remove python2 assert regex method name hacks. (dlehman) +- Fix various pylint errors introduced with python-3.5. (dlehman) +- Add a file with release notes (vpodzime) +- Blacklisted attrs should be unwrapped, not omitted. (dlehman) +- Return the device when returning early from degraded md handler. (dlehman) +- Fix application of synchronization metaclass to DeviceTree. (dlehman) +- Fix AttributeError in populator LUKS helper (vtrefny) +- Update spec file for blivet 2.0 builds (vtrefny) +- Add populator.helpers to package (vtrefny) +- Add translator comments to the byte size prefixes. (dshea) +- Integrate translation-canary with blivet. (dshea) +- Update blivet.pot during scratch-bumpver. (dshea) +- Always use setup.py sdist to generate source tarballs. (dshea) +- Squashed 'translation-canary/' content from commit 5a45c19 (dshea) +- Update class and methods in "Introduction to Blivet" (vtrefny) +- Build documentation with python3 sphinx (vtrefny) +- Fix PEP8 violations introduced in the LVM RAID commits (vpodzime) +- Make the main class hierarchies thread-safe. (dlehman) +- Add unit tests for changes related to non-linear LVs (vpodzime) +- Make sure we try to match LVM RAID levels with all their names (vpodzime) +- Don't bother user code with LVM RAID meta data (vpodzime) +- Inherit the RaidDevice mixin in the LVMLogicalVolumeDevice class (vpodzime) +- Account for a pmspare LV creation or growth when determining the cache size (vpodzime) +- Refresh the PV free space info after LV creation (vpodzime) +- Add an early check of the requested LV segment type (vpodzime) +- Add example of LVM cache creation (vpodzime) +- Make sure the slow_pvs+fast_pvs list we pass to libblockdev has no dups (vpodzime) +- Use pv.path instead of constructing it from name and "/dev/" (vpodzime) +- Account for LVM cache space in PVs (vpodzime) +- Fix the twisted logic of lv.metadata_size (vpodzime) +- Replace the 'copies' property of LVs with something more accurate (vpodzime) +- Track information about free space in existing PVs (vpodzime) +- Add guards making sure we are not being tricked with LV seg_type (vpodzime) +- Define and use a new is_raid_lv property of LVMLogicalVolumeDevice (vpodzime) +- Add an example of non-linear LV creation (vpodzime) +- Create non-linear LVs before linear LVs (vpodzime) +- Account for LVM RAID metadata (vpodzime) +- Define RAID level for LV and use it to determine required PV space (vpodzime) +- Add a definition for the striped "RAID level" (vpodzime) +- Track information about free space in a PV (vpodzime) +- Honor the LV segment type when creating it (vpodzime) +- Let LVMLogicalVolumeDevice specify PVs it should be allocated from (vpodzime) +- Define the Device.parent property with the ) +- Adjust to Device now having a list of child devices. (dlehman) +- Maintain a list of child devices in Device. (dlehman) +- Add unit tests to explicitly cover container member set changes. (dlehman) +- Remove ParentList.replace and its usage. (dlehman) +- Improve logging of failure to validate new default fstype. (dlehman) +- Remove unused populated attribute from Populator. (dlehman) +- Stop passing around the iscsi singleton. (dlehman) +- Make the iscsi singleton satisfactory to pylint. (dlehman) +- Remove the various DASD lists from Blivet and DeviceTree. (dlehman) +- Convert Populator to a mixin class. (dlehman) +- Move disk filter bits from Populator into DeviceTree. (dlehman) +- Move the LVM data cache from DeviceTree to Populator. (dlehman) +- Rename per-device Populator entry points. (dlehman) +- Make Populator.udev_device_is_disk a private method. (dlehman) +- Stop writing an mdadm.conf. (dlehman) +- Group disk-image-related methods together in source code. (dlehman) +- Move some code from _populate into separate methods. (dlehman) +- Split various parts of add_udev_device into separate methods. (dlehman) +- Remove some extraneous methods related to ignored devices. (dlehman) +- Only handle loop devices with a backing file. (dlehman) +- Add unit tests for populator helpers. (dlehman) +- Use helper getter functions to find populator helpers. (dlehman) +- Add functions to return a helper class based on device data. (dlehman) +- Move format-type-specific bits into populator helpers. (dlehman) +- Split DiskDevicePopulator up by disk type. (dlehman) +- Move device-type-specific populator bits to populator helpers. (dlehman) +- Add base classes for type-specific Populator helpers. (dlehman) +- Use the mpath_member ID_FS_TYPE set up by the multipath udev rules. (dlehman) +- Make blivet.populator into a subpackage. (dlehman) +- Convert device_get_dm_partition_disk to not be dm-specific. (dlehman) +- Use DeviceTree.__str__ when printing devices in examples. (dlehman) +- Disk image test can only be run as root. (dlehman) +- Fix few more camelCase leftovers (vpodzime) +- Fix various PEP8 violations in recent EDD commits. (dlehman) +- Add PEP8 compliance checking to 'check' target. (dlehman) +- Teardown all devices before tearing disk images down (vpodzime) +- Change doc Introduction to reflect PEP8 compliance changes (vtrefny) +- Few PEP8 compliance related fixes (vtrefny) +- Pass devices arg when calling actions.process (vtrefny) +- Do not catch CryptoError when decrypting LUKS format (#1280239) (vtrefny) +- Fix makebumpver for new conf.py (bcl) +- Bump version numbers to 2.0 before we forget. (bcl) +- Only prepend the root to get the ondisk path if there is some (vpodzime) +- Ignore unused memo_dict arguments in __deepcopy__ methods. (clumens) +- Update the getattr calls with PEP8 property/attribute names (vpodzime) +- Do not create a copy of singleton objects (vpodzime) +- Fix pylint problems with the new default namedtuple stuff. (clumens) +- Do not try to get LVM cache's size from stats for inactive LV (vpodzime) +- edd: Add mostly fixed virt data (pjones) +- edd: Add another terrible seabios dataset (pjones) +- edd: Add test data from a Strawberry Mountain machine w/ lots of SATA. (pjones) +- edd: Fix the error case in the "absurd_virt" test. (pjones) +- edd: Add absurd_virt tests back in (pjones) +- edd: Try to detect multiple ATA/SATA matches and log them. (pjones) +- edd: Split up VirtIO and VirtIO SCSI matching (pjones) +- edd: Log every glob.glob() match in our test data log. (pjones) +- edd: Eradicate fsroot entirely. (pjones) +- edd: add EddEntry.bios_device_number (pjones) +- edd: Make our own assertVerboseListEqual to get rid of truncated output. (pjones) +- edd: Add sysfslink for mbr matches (pjones) +- Make get_sysfs_attr() use our path joiners and add sysfs_readlink() (pjones) +- Make a "Path" object that handles separate fs root for us. (pjones) +- edd: Minor PEP8 fix (pjones) +- Add a much much simpler path normalizer and joiner. (pjones) +- Improve clarity of error when setting new default fstype fails. (dlehman) +- Fix missed rebase of populator test from 169dc6b6. (dlehman) +- Add a class constructor for namedtuples with default values (vpodzime) +- Use lvm.round_size_to_pe() instead of get_lv_physical_size() with the VG size (vpodzime) +- Account for LVM metadata in the LVMFactory (vpodzime) +- Put the LVM metadata size calculation into a separate property (vpodzime) +- Rename size->space in LVMFactory._get_total_space (vpodzime) +- Remove action-oriented wrapper methods from DeviceTree. (dlehman) +- Put DeviceTree methods into a sensible order. (dlehman) +- Fix remaining PEP8 violations. (dlehman) +- Fix PEP8 indentation issues. (dlehman) +- Fix the easy PEP8 violations. (dlehman) +- Make all names conform to PEP8. (dlehman) +- Update dmdev size when setting up disk images (atodorov) + +* Wed Oct 28 2015 Brian C. Lane - 1.16-1 +- Merge pull request #257 from vpodzime/master-singleton_decorator (vpodzime) +- Add pylint stuff to .gitignore (pjones) +- Minor cleanups in set_up_logging() (pjones) +- Make a logger for test data that we can automatically use later (pjones) +- edd: Fix one regexp so it matches against a real system /or/ test data. + (pjones) +- Merge pull request #253 from dashea/libblockdev-python (vpodzime) +- Make the function adding the deprecation doc text more generic (vpodzime) +- Merge pull request #242 from dwlehman/resolveDevice-regex (dlehman) +- Fix an overly inclusive regex in DeviceTree.resolveDevice. (dlehman) +- Merge pull request #244 from atodorov/master (vpodzime) +- Require the python libblockdev packages (dshea) +- Merge pull request #243 from dwlehman/flexible-alignment (dlehman) +- Merge pull request #230 from vpodzime/master-lvm_debug (vpodzime) +- Add a 'debug' flag and use it for LVM debugging (vpodzime) +- Bypass util.run_program to avoid logging deadlock. (dlehman) +- Add an edd test data harvester. (pjones) +- Do not save None as passphrase for LUKS devices (#1269646) (vtrefny) +- edd: make logging work usefully during tests (pjones) +- edd: Get rid of biosdev_to_edd_dir(), it is pointless. (pjones) +- Make distutils.filelist.findall() do the right thing with symlinks maybe. + (pjones) +- edd: Fix some minor 'make check' complaints. (pjones) +- edd: Make devicetree not use edd.edd_dict, instead use blivet's copy. + (pjones) +- edd: Remove the "absurd_virt" test cases for now. (pjones) +- Add a udev settle call after instantiating parted.Disk. (#1267858) (dlehman) +- edd: Add missing directories for absurd_virt test case. (pjones) +- produce coverage-report.log and enable coverage in CI (atodorov) +- Use minimal alignment as needed when allocating small partitions. (dlehman) +- Add support for minimal alignment of very small partitions. (dlehman) +- Add an error class for alignment errors. (dlehman) +- Deprecate createSubVolumes method (vtrefny) +- Change btrfs.do_self_mount to contextmanager (#1266673) (vtrefny) +- edd: Remove a bunch of nonfunctional EDD tests. (pjones) +- edd: Add another set of test cases for our QEMU data. (pjones) +- edd: Add another set of test data. (pjones) +- edd: Add some working tests for EDD. (pjones) +- edd: Add a real EDD dataset captured from a system. (pjones) +- edd: Make our edd matcher able to use a fake sysfs root. (pjones) +- edd: Add EDD 4 code and some logging cleanups. (pjones) +- edd: Try to make EDD support actually match what the kernel does. (pjones) +- Always build python2 and python3 versions. (bcl) +- Switch to using rd.iscsi.initiator (#1268315) (bcl) + +* Fri Oct 02 2015 Brian C. Lane - 1.15-1 +- Update Makefile to default to python3. (dlehman) +- Add test for extended partition minSize (vtrefny) +- Allow resizing of non-leaf partitions (vtrefny) +- Fix minSize for extended partitions (#1254875) (vtrefny) +- Fix calling non-existing method (#1252902) (jkonecny) +- Use the RAID classes to calculate btrfs sizes (#1264696) (dshea) +- Handle sysfs size if it is missing (#1265090) (bcl) +- Convert float to str for better precision in Size (jkonecny) +- Merge pull request #226 from dwlehman/lvactivate-lvmetad (dlehman) +- Wait for auto-activation of LVs when lvmetad is running. (#1261621) (dlehman) +- Add a function to tell us if the lvmetad socket exists. (dlehman) +- Don't teardown FSs when searching for installed systems (#1252902) (jkonecny) +- Merge pull request #218 from vpodzime/master-lvm_on_raid_improvements + (vpodzime) +- Account for bigger LVM meta data due to alignment on MD RAID (vpodzime) +- Calculate the MD RAID superblock size from the right size (vpodzime) +- Don't be naïve about liblvm (vpodzime) + +* Fri Sep 11 2015 Brian C. Lane - 1.14-1 +- Make sure devices are torn down in findExistingInstallations (#1261439) + (vpodzime) +- Merge pull request #211 from dwlehman/multipath-member-metadata (dlehman) +- Merge pull request #212 from dwlehman/recursive-teardown (dlehman) +- Mount efivarfs during os installation (#1260799) (bcl) +- Use --whatprovides when querying for if all requirements are installed. + (clumens) +- Add method for estimated size of formated device (#1224048) (jkonecny) +- Add support for mul,div,sub,add by float to Size (jkonecny) +- Merge pull request #220 from AdamWill/nodev-typo (vpodzime) +- fix typo in NoDevice: updateSize not udpateSize (awilliam) +- Duplicate VG names are problem even if their disks are ignored (#1198367) + (vpodzime) +- Merge pull request #215 from vpodzime/master-lvm_on_raid (vpodzime) +- Do not reserve extra space for metadata in a VG with RAID PVs (vpodzime) +- Merge pull request #207 from vpodzime/master-lvm_pmspare (vpodzime) +- Fix currentSize for extended partitions (#1254899) (vtrefny) +- Catch problems with chassis vendor names (#1256072) (bcl) +- Don't teardown protected devices (jkonecny) +- Don't store UUIDs or labels of multipath members. (dlehman) +- Continue with recursive teardown beyond inactive devices. (dlehman) +- Reserve space for the 'pmspare' LV in a VG (vpodzime) +- Add a property to get cached LVs in a VG (vpodzime) +- Fix VG free space check when shrinking an LV (vpodzime) +- Add a property for Requests to reserve some extra space (vpodzime) +- Use Size instances for sizes in LVM cache's stats (vpodzime) +- Implement metadata size reporting for the LVM cache (vpodzime) + +* Mon Aug 24 2015 Brian C. Lane - 1.13-1 +- Add CONTRIBUTING file to blivet. (sbueno+anaconda) +- Merge pull request #208 from vpodzime/master-luks_catch_exceptions (vpodzime) +- Fix the name of the variable specifying requested libblockdev plugins + (#1256273) (jstodola) +- Merge pull request #209 from vpodzime/master-thinp_fix (vpodzime) +- Change labelFormatOK to classmethods (vtrefny) +- Add 'build' and '.directory' to gitignore (vtrefny) +- Fix copy method (#1254135) (bcl) +- Add OSError to list of errors in updateSysfsPath (#1252949) (bcl) +- Remove the cacheRequest kwarg for thin(pool) LVs (#1254567) (vpodzime) +- Do not propagate low-level blockdev.CryptoError when setting up LUKS + (#1253925) (vpodzime) +- Merge pull request #199 from vpodzime/master-lvm_cache_tests (vpodzime) +- Merge pull request #201 from vpodzime/master-mountsCache_resolve_devspec + (vpodzime) +- Prefer code consistency over pylint's complaints in tests (vpodzime) +- Add a basic test for cached LVMLogicalVolumeDevice's properties (vpodzime) +- Add a basic test for LVMLogicalVolumeDevice's properties (vpodzime) +- Make sure LV's properties reporting size return a Size instance (vpodzime) +- Add unit tests for the LVM cache support (vpodzime) +- Use device name from udev only if it's available (#1252052) (vpodzime) +- Add test for getFreeSpace aligning (vtrefny) +- Allow aligning free regions to disk grainSize (#1244671) (vtrefny) +- Fix _unalignedMaxPartSize for logical partitions (#1250890) (vtrefny) + +* Fri Aug 07 2015 Brian C. Lane - 1.12-1 +- Remove unusable free regions from list when setting up growth. (dlehman) +- Merge pull request #190 from vpodzime/master-lvm_cache_creation (dlehman) +- Merge pull request #194 from dwlehman/mount-cache-symlinks (dlehman) +- Merge pull request #193 from dwlehman/md-fwraid-detection (dlehman) +- Add unit tests to cover md containers. (dlehman) +- Minor cleanup of blivet.formats.fs.BTRFS._preSetup. (dlehman) +- Fix isDisk and partitionable properties for md fwraid. (dlehman) +- Don't use MD_DEVNAME as device name for md partitions. (dlehman) +- Use udev to find name of md members' container. (dlehman) +- Call superclass ctor a bit later to get size attrs set up first. (dlehman) +- updateSize for md containers is a no-op. (dlehman) +- Fix UnboundLocalError in FSMinSize (#1249304) (vtrefny) +- Fix mount cache resolution of devices with symlinks. (#1247803) (dlehman) +- Add kwarg to udev.resolve_devspec to return canonical device name. (dlehman) +- Use slow as well as fast PVs for cached LV's non-cache part (vpodzime) +- Make VG determination in Blivet.newLV() less cryptic (vpodzime) +- Reserve space for LVM cache(s) when growing LVM requests (vpodzime) +- Create cached LVs before non-cached LVs (vpodzime) +- Add support for LVM cache creation to LVM device classes (vpodzime) +- Add generic class for cache creation requests (vpodzime) +- Two minor fixes in LVMLogicalVolumeDevice's constructor's docstring + (vpodzime) + +* Fri Jul 31 2015 Brian C. Lane - 1.11-1 +- Put MDRaidArrayDevice.devices back, but mark it as deprecated. (dlehman) +- Skip tearing down devices when unmounting filesystems (bcl) +- Include details when umount fails (bcl) +- Merge pull request #183 from dwlehman/tests-20150728 (dlehman) +- Merge pull request #182 from dwlehman/devicefactory-20150728 (dlehman) +- Merge pull request #184 from dwlehman/misc-20150728 (dlehman) +- Enable unit test suite in jenkins. (dlehman) +- Disable image-backed unit tests temporarily. (dlehman) +- Add some tests for DeviceFactory. (dlehman) +- Do basic child accounting when replacing a parent. (dlehman) +- Set new raid level on correct device in MDFactory. (dlehman) +- Fix container member switching when toggling member encryption. (dlehman) +- Don't adjust actual lv size based on md metadata space requirements. + (dlehman) +- Merge pull request #57 from vpodzime/master-luks_npass (vpodzime) +- Fix names of the keyword arguments for luks_add_key and luks_remove_key + (vpodzime) +- Make a better effort to clean up loop devices on failure. (dlehman) +- Correctly get current size of disk files. (dlehman) +- Don't warn about missing UUIDs for non-existent containers. (dlehman) +- Only check disks for membership in a multipath. (dlehman) +- Only update md array name if MD_DEVNAME is set. (#1212073) (dlehman) +- Weed out unresolved macros in the check-requires target. (clumens) +- Merge pull request #126 from vpodzime/master-translations_subpackage + (vpodzime) +- Put translations into a subpackage shared by Python 2 and 3 (vpodzime) +- Require pygobject3-base instead of pygobject (#1246842) (dshea) +- Add method to list primary partitions (vtrefny) +- Merge pull request #179 from dwlehman/size-followups (dlehman) +- Fix test for failure to find space for device. (dlehman) +- Make sure factory target size is within the limits of the fstype. (dlehman) +- Unset obsolete format before updating device size. (dlehman) +- Make sure size is numeric before comparing it with format minimum. (dlehman) +- Don't constrain thin lv sizes to vg free space. (dlehman) + +* Fri Jul 24 2015 Brian C. Lane - 1.10-1 +- Merge pull request #177 from AdamWill/1245446 (dlehman) +- use floor division in calculating amount to reclaim (#1245446) (awilliam) +- Remember to use the shell command when calling external stuff in Makefile. + (clumens) +- Add a new makefile target that does everything needed for jenkins. (clumens) +- Add missing gobject introspection Requires (bcl) +- Add install-requires Makefile target (bcl) +- Update md and btrfs unit tests to run with recent size changes. (dlehman) +- Set format attr after super ctor for md. (dlehman) +- Account for container layer in md fwraid array properties. (dlehman) +- Ensure format is a DeviceFormat during initialization. (dlehman) +- Set target size when setting other size attrs. (dlehman) +- Use 'members' attribute to list RAID member devices. (dlehman) +- BTRFS subvolumes shouldn't inherit from RAIDDevice. (dlehman) +- Require a non-empty member set for md disks. (dlehman) +- Mock mount cache while running action tests. (dlehman) +- Account for recent lvm snapshot format changes in tests. (dlehman) +- Bump size of non-existent devices to format minimum. (dlehman) +- Don't pass createOptions along when creating the btrfs device. (clumens) +- Merge pull request #59 from vpodzime/master-tab_tab (vpodzime) +- Implement the __dir__ method of the LazyImportObject class (vpodzime) + +* Thu Jul 16 2015 Brian C. Lane - 1.9-1 +- Apply default size for new partition earlier in constructor. (dlehman) +- Don't pass model to md fwraid constructor. (#1242610) (dlehman) + +* Fri Jul 10 2015 Brian C. Lane - 1.8-1 +- Add a bunch more gi.require_version calls (dshea) +- Merge pull request #170 from dwlehman/size-cleanups (dlehman) +- Add unit tests for device size setters and getters. (dlehman) +- Only return target size if it is set to something meaningful. (dlehman) +- Validate new formats against current device size. (dlehman) +- Device size checks do not apply to existing devices. (dlehman) +- Make sure subclasses size setters use the base setter as appropriate. + (dlehman) +- x-initrd.mount should only be set for /var (#1238603) (bcl) +- There's a python3 anaconda now, so ditch the temporary false positives. + (clumens) +- Fix a syntax error caused by my previous commit. (clumens) +- Fix a duplicate key caused by patch merging. (clumens) +- Add support for specifying arbitrary mkfs options. (clumens) +- Align free regions before choosing one. (dlehman) +- Align partition sizes earlier in the allocation process. (dlehman) +- Don't crash on cleanup with DASDs or iSCSI devices present. (#1166506) + (dlehman) +- Make check-requires errors more readable. (dshea) +- Merge pull request #166 from dwlehman/autopart-snapshot-branch (dlehman) +- Default to a string when sorting mountpoints in FSSet.umountFilesystems. + (dlehman) +- Fix order of arguments to blockdev.thsnapshotcreate. (dlehman) +- Snapshot format exists upon snapshot creation. (dlehman) +- Improve format handling for lvm snapshots. (dlehman) +- Merge pull request #160 from dwlehman/lookup-method-deprecations (dlehman) +- Deprecate some little-used devicetree lookup methods. (dlehman) +- Add a decorator to mark deprecated functions/methods. (dlehman) +- Log python warnings, including DeprecationWarning. (dlehman) +- Catch and relay more exception types from the iscsi process (dshea) +- Use the pipes as contextmanagers to ensure they are closed (dshea) +- Close the unused half of pipes after the fork (dshea) + +* Fri Jun 26 2015 Brian C. Lane - 1.7-1 +- Merge pull request #167 from mulkieran/master-format-copy-b (mulkieran) +- Merge pull request #156 from vpodzime/master-lvm_cache_actually (vpodzime) +- Add cache support to the LVMLogicalVolumeDevice class (vpodzime) +- Copy all DeviceFormat objects using deepcopy. (amulhern) +- Make use of FSTask and FSUnimplementedTask in FS* tasks. (amulhern) +- Add an abstract parent of all filesystem tasks. (amulhern) +- Merge pull request #162 from dwlehman/storage-device-format-type-consistency + (dlehman) +- Merge pull request #138 from dwlehman/partitionable-md (dlehman) +- Document the fact that StorageDevice.format is always a DeviceFormat. + (dlehman) +- Ignore some interruptible system call warnings (dshea) +- Retry interruptible calls (dshea) +- Ignore EINTR from os.close instead of retrying the call (dshea) +- Add kwargs to eintr_retry_call (dshea) +- Specify required version of GI-imported packages (vpodzime) +- Add classes for LVM cache related functionality (vpodzime) +- Add generic classes for cache and cache stats (vpodzime) +- Merge pull request #149 from vpodzime/master-lvm_cache (vpodzime) +- Implement the support for resizing internal metadata LVs of thin pools + (vpodzime) +- Use relations between LVs to determine parent LV (vpodzime) +- Make Blivet.lvs return all LVs not just traditional/thick LVs (vpodzime) +- Accept both list and ParentList when checking LVs parents (vpodzime) +- Create and use internal LVs instead of static values (vpodzime) +- Add classes for the internal LVs of various types (vpodzime) +- Merge pull request #137 from dwlehman/md-boot-metadata-branch (dlehman) +- Treat existing md arrays whose members are all disks like disks. (dlehman) +- Handle formatting after adding devices from format handlers. (dlehman) +- Merge pull request #158 from mulkieran/master-target-size (mulkieran) +- Move parents checking and update into a seprarate methods (vpodzime) +- Rearrange and group some of the StorageDevice's methods/properties (vpodzime) +- Don't crash when processing cached LVs (vpodzime) +- Make roundToNearest() slightly more robust. (amulhern) +- Extend Size.convertTo() to work with arbitrary Size() values. (amulhern) +- Changes to FS._setTargetSize(). (amulhern) +- Increase ext4 maximum size from 16 TiB to 1 EiB (#1231049) (bcl) +- Merge pull request #155 from atodorov/fix_issue_154 (mulkieran) +- Use len of set to check for duplicates in list of packages. (atodorov) +- Merge pull request #153 from mulkieran/master-task-names (mulkieran) +- Omit completely pointless setUp method. (amulhern) +- Make a size refer to a Size object. (amulhern) +- Add __str__ method to various subclasses of Task. (amulhern) +- Don't pass unused mountpoint dict to preCommitFixup. (dlehman) +- Use the default md metadata version for everything except /boot/efi. + (dlehman) + +* Wed Jun 10 2015 Brian C. Lane - 1.6-1 +- Fix indentation in action_test.py (dlehman) +- Merge pull request #133 from atodorov/fix_deprecation_warnings (mulkieran) +- Merge pull request #147 from vojtechtrefny/master_fix_undo_resize (vtrefny) +- Fix setting original size for format resize action. (#1225352) (vtrefny) +- Make unit test assertion expressions fully Python2/3 compatible. (atodorov) +- Merge pull request #151 from mulkieran/master-120 (mulkieran) +- Merge pull request #122 from atodorov/remove_doctest (mulkieran) +- Parameterize Makefile test targets on Python version. (atodorov) +- Merge pull request #148 from mulkieran/master-132 (mulkieran) +- Merge pull request #144 from mulkieran/master-128 (mulkieran) +- Remove facilities for running tests as standalone modules. (atodorov) +- Include automatic and manual test documentation. (atodorov) +- Remove an accidental variable assignment in LVMLogicalVolumeDevice (vpodzime) +- Merge pull request #143 from mulkieran/master-134 (mulkieran) +- Remove two files in tests directory. (atodorov) +- Fix typo in docstring. (atodorov) +- Merge pull request #112 from vpodzime/master-fixed_maps (vpodzime) +- Merge pull request #129 from mulkieran/master-keepers-c (mulkieran) +- Merge pull request #135 from mulkieran/master-test-fixes (mulkieran) +- Convert bytes value to str. (amulhern) +- Change new format lookup name from "msdos" to "disklabel". (amulhern) +- Get rid of pointless test case about arguments for labeling apps. (amulhern) +- Do not raise KeyError if ID_PART_ENTRY_DISK is missing. (amulhern) +- Manage backing store more independently in loop backed test cases. (amulhern) +- Pass floats as string to Decimal constructor everywhere. (amulhern) +- Fix a bug in reading a size specification with a radix in the numeric part. + (amulhern) +- remove mention of doctest b/c target was removed in + fed53d969af0eddaeeca58cdf3e40916497aa305 (atodorov) +- Beware of Python 3's version of the map() built-in function (vpodzime) + +* Thu May 28 2015 Brian C. Lane - 1.5-1 +- Get rid of an unused import in blivet.zfcp (sbueno+anaconda) +- Make appropriate changes to adapt for s390 libblockdev plugin. + (sbueno+anaconda) +- Drop check from the release build target (bcl) +- Merge pull request #127 from vpodzime/master-libblockdev_1.0 (vpodzime) +- Adapt to the new libblockdev initialization API (vpodzime) +- Merge pull request #111 from dwlehman/disk-model-branch (dlehman) +- Store vendor/model information for DiskDevice instances. (dlehman) +- Require new version of pyparted with Python 3 related fixes (vpodzime) +- Merge pull request #114 from vojtechtrefny/fix_lvmsnapshot_size2 (vtrefny) +- Merge pull request #118 from mulkieran/master-hawkey (mulkieran) +- Use python-hawkey instead of rpm-python. (amulhern) +- Add a dead simple test for some basic task and resource functionality. + (amulhern) +- Use COW device to get actual size of LVM snapshots (vtrefny) + +* Mon May 18 2015 Brian C. Lane - 1.4-1 +- Workaround for chrooted mountpoints (#1217578) (vtrefny) +- Merge pull request #116 from mulkieran/master-gerror (mulkieran) +- Filter GLib.GError instead of GLib.Error in pylint false positives. + (amulhern) +- Merge pull request #113 from mulkieran/master-tasks-20150513 (mulkieran) +- Guard tests against device support being missing. (amulhern) +- Add checks for filesystem availability in selinux tests. (amulhern) +- Fix some small mistakes in tests using availability information. (amulhern) +- Get rid of abitrary _resizable variable in tests. (amulhern) +- Don't use utilsAvailable to skip tests. (amulhern) +- Treat a missing plugin as an OK situation. (amulhern) +- Use availability information in device actions. (amulhern) +- Add a check to determine whether the device type is supported. (amulhern) +- If external dependencies are unavailable, cannot support RAID levels. + (amulhern) +- Add availability information to devicelibs files. (amulhern) +- Track external dependencies in devices. (amulhern) +- If lvm is not available, do not do the filtering. (amulhern) +- Add availability checking to non-FS formats. (amulhern) +- Use filesystem tasks in filesystem. (amulhern) +- Add filesystem tasks to tasks directory. (amulhern) +- Add tasks infrastructure to tasks directory. (amulhern) +- Add error to detect errors in discovering availability info. (amulhern) +- Add errors about reading and writing labels to error heirarchy. (amulhern) +- Make assignments that override abstract properties into simple attributes. + (amulhern) +- Move kernel_filesystems functionality into a little library. (amulhern) +- Make labeling(), relabels(), and labelFormatOK() instance methods. (amulhern) +- Merge pull request #108 from vojtechtrefny/progress_callbacks (vtrefny) +- Merge pull request #109 from mulkieran/master-btrfs-c (mulkieran) +- Set a subvolspec format args when making a new BTRFS volume. (amulhern) +- Cache data obtained from /proc/self/mountinfo. (amulhern) +- Add progress report callback for action processing (vtrefny) +- Do not have two ignored variables when one will do. (amulhern) +- Fix a typo in comment. (amulhern) +- Do not use type() in makebumpver. (clumens) +- Merge pull request #100 from mulkieran/master-lvm-a (mulkieran) +- Merge pull request #104 from mulkieran/master-1139222 (mulkieran) +- Include LUKSDevice information in kickstart data (#1139222) (amulhern) +- Un-escape '-'s in names or paths for _all_ lvm lv or vgs. (amulhern) +- Fix a few miscellaneous pylint-caught problems. (clumens) +- Only give Size objects a __div__ method under python2. (clumens) +- Protect against calling testMount on an object that may not have it. + (clumens) +- Add a bunch of false positives to make pylint succeed. (clumens) +- e.message -> str(e) (clumens) +- Disable a pointless override warning. (clumens) +- Ignore the environment-modify pylint warnings for size_test.py. (clumens) +- blockdevError -> BlockDevError (clumens) +- Remove uses of the string module we don't need, ignore warnings on those we + do. (clumens) +- unicode isn't undefined on the python2 code paths. (clumens) +- Use eintr_retry_call from anaconda. (clumens) +- Move blivet to using pocketlint. (clumens) +- Merge pull request #97 from mulkieran/master-1072060 (mulkieran) +- Merge pull request #93 from vojtechtrefny/fix_active_parted (vtrefny) +- If the parent volume has a label, use it in subvol's kickstart (#1072060) + (amulhern) +- Merge pull request #94 from mulkieran/master-raid (mulkieran) +- Allow adding new partitions to disks with active devices (#1212841) (vtrefny) +- Fix "anaconda hangs while trying to discover iscsi..." (#1166652) (jkonecny) +- Move definition of _level attribute above super-constructor call. (amulhern) +- Fix status for LVMPhysicalVolume format (vtrefny) + +* Wed Apr 22 2015 Brian C. Lane - 1.3-1 +- fix conf.py pylint errors (bcl) +- Fix BlockDev import in populator.py (bcl) +- Prevent pylint from going crazy because of libblockdev's ErrorProxy + (vpodzime) +- Make use of the new libblockdev error reporting (vpodzime) +- Add libselinux-python to package dependencies (#1211834) (vtrefny) +- Introduce a new doReqPartition method that is similar to doAutoPartition. + (clumens) +- Merge pull request #81 from mulkieran/master-mount-options (mulkieran) +- Merge pull request #66 from vpodzime/master-py3_final (martin.kolman) +- Encode input for os.write() (mkolman) +- Build the python3-blivet subpackage (vpodzime) +- Do not modify dict while iterating over its values (vpodzime) +- Do not try to compare strings and Nones when sorting mountpoints (vpodzime) +- Always return strings from regular capture output run functions (mkolman) +- Do not use variable from an inner comprehension in tests (vpodzime) +- Implement and test Python 3 division for the Size class (vpodzime) +- Replace python 2 build-in-function cmp() with custom method (vtrefny) +- Do not rely on __sub__ being implemented as __add__ (-1)* (vpodzime) +- Transform our compare functions into key functions and use these instead + (vpodzime) +- Fix the size_test to stop using byte strings (vpodzime) +- Do not define unit strings as byte strings (vpodzime) +- Do not pass context to Decimal numeric operations (vpodzime) +- Don't call object's (as a class) __new__ with extra arguments (vpodzime) +- Make translation to lowerASCII Python[23]-compatible (vpodzime) +- Replace __import__ call with importlib.import_module (vpodzime) +- In FS._postSetup() check the mountpoint options that were actually used. + (amulhern) +- Add kwargs to unmount and move mountpoint check into _preSetup (bcl) +- Do not try importing hidden/backup files as formats (vpodzime) +- Add back DeviceTree's support for saving LUKS passphrases (vpodzime) +- Do not try to stat FileDevice's path if it doesn't exist (vpodzime) +- Merge pull request #76 from dwlehman/unusable-storage-branch (dlehman) +- Add error handling around storageInitialize for unusable setups. (dlehman) +- Include suggestions in error classes for unusable storage configurations. + (dlehman) +- Use partially corrupt gpt disklabels. (dlehman) +- Consolidate common code in DeviceFormat class methods. (dlehman) +- Update get_mount_paths to use mountsCache (bcl) +- Add multiple mountpoint handling to MountsCache (bcl) +- Remove obsolete FIXME from FS.status (bcl) +- Check to see if mountpoint is already mounted (bcl) +- Add isMountpoint to MountsCache (bcl) +- Add ability to unmount specific mountpoints (bcl) +- Fix pylint errors for six.moves import (vtrefny) +- Merge pull request #72 from vojtechtrefny/picklable-size (vpodzime) +- Merge pull request #74 from mulkieran/master-trivia (mulkieran) +- Fix two instances where check_equal() returned True incorrectly. (amulhern) +- Fix typo in 66f2ddb11e85ec6f48535d670dd6f24cb60cbe55. (amulhern) +- Make sure installer_mode is reset to original value. (amulhern) +- Test for Size pickling support (vtrefny) +- Pickling support for Size. (vtrefny) +- Disable pylint bad-super-call in MDRaidArrayDevice.updateSize. (dlehman) +- Merge pull request #68 from dwlehman/parted-device-branch (dlehman) +- Require reallocation after changing an allocated partition's size. (dlehman) +- Move mediaPresent out of Device and into StorageDevice. (dlehman) +- Don't use parted.Device to obtain size info. (dlehman) +- Merge pull request #70 from mulkieran/master-1208536 (mulkieran) +- Prepend /sys to sysfs path for udev lookup (#1208536) (amulhern) +- Fall back on mdadm info if udev info is missing for the array (#1208536) + (amulhern) +- Catch DeviceError as well as ValueError (#1208536) (amulhern) +- Make an MDContainerDevice if that is the right model (#1208536) (amulhern) +- Change raid variable name to raid_items (#1208536) (amulhern) +- Fix swapped args to processActions. (dlehman) +- Merge pull request #63 from dwlehman/disk-selection-branch (dlehman) +- Use VGname-LVname as key for LVinfo cache (vpodzime) +- Add back DeviceTree's methods and properties used from the outside (vpodzime) +- Wrap keys() with a list so that the dictionary can be changed (martin.kolman) +- Add a method to list disks related by lvm/md/btrfs container membership. + (dlehman) +- Make getDependentDevices work with hidden devices. (dlehman) + +* Fri Mar 27 2015 Brian C. Lane - 1.2-1 +- Fix pylint unused variable warnings (vtrefny) +- Add test for mountpoints (vtrefny) +- Replace _mountpoint with systemMountpoint in other modules (vtrefny) +- New method to handle nodev filesystems (vtrefny) +- Add dynamic mountpoint detection support (vtrefny) +- New method to compute md5 hash of file (vtrefny) +- Add information about subvolume to BTRFS format (vtrefny) +- Don't specify priority in fstab if -1 (default) is used (#1203709) (vpodzime) +- Catch GLib.GError in places where we catch StorageError (#1202505) (vpodzime) +- slave_dev is undefined here, use slave_devices[0] instead. (clumens) +- Clean out the mock chroot before attempting to run the rest of the test. + (clumens) +- Move recursiveRemove from Blivet to DeviceTree. (dlehman) +- Factor out adding of sysfs slave (parent) devices into its own method. + (dlehman) +- Add a __str__ method to DeviceTree. (dlehman) +- Allow changing the names of existing devices. (dlehman) +- Remove redundant block for adding fwraid member disks. (dlehman) +- Return a device from addUdevLVDevice if possible. (dlehman) +- Pass a sysfs path to MultipathDevice constructor from Populator. (dlehman) +- Resolve md names in udev info. (dlehman) +- LVMVolumeGroupDevice format should be marked as immutable. (dlehman) +- Don't catch and re-raise device create exceptions as DeviceCreateError. + (dlehman) +- Call superclass _preCreate from BTRFSVolumeDevice._preCreate. (dlehman) +- Move code that populates the device tree into a new class and module. + (dlehman) +- Move action list management into a separate class and module. (dlehman) +- Put an __init__.py in devices_tests directory. (amulhern) +- Require the Python 2 version of pykickstart (#1202255) (vpodzime) +- Use Size method to perform a Size operation (#1200812) (amulhern) +- Extend Size.roundToNearest to allow Size units (#1200812) (amulhern) +- Move code that populates the device tree into a new class and module. + (dlehman) +- Move action list management into a separate class and module. (dlehman) +- Remove a pointless override. (amulhern) +- Display the name of the overridden ancestor in error message. (amulhern) +- Check for simple function calls in pointless overrides. (amulhern) +- Simplify supported methods in FS.py. (amulhern) +- Make hidden property use superclass method where possible. (amulhern) +- Simplify some methods in DeviceFormat class. (amulhern) +- Do supercall in BTRFSVolumeDevice.formatImmutable. (amulhern) +- Add a comment to supported property. (amulhern) +- Get rid of some very old commented out code. (amulhern) +- Put all mock results into the top-level source dir. (clumens) +- Spell TestCase.teardown correctly as tearDown(). (amulhern) +- Make testMount() check return value of util.mount(). (amulhern) +- Remove unused fs_configs. (amulhern) +- Remove side-effects from mountType property. (amulhern) +- Do not make the mountpoint directory in fs.FS.mount(). (amulhern) +- Mount should not be satisfied with anything less than a directory. (amulhern) +- Do not return doFormat() value. (amulhern) +- Put previously removed mountExistingSystem() into osinstall.py. (amulhern) +- Revert "Revive the mountExistingSystem() function and all it needs" + (amulhern) +- Make sure the device is setup before formatting it (#1196397) (bcl) +- Use %%d format string for every value that should be an integer decimal. + (amulhern) +- Robustify PartitionDevice._wipe() method. (amulhern) +- Fix up scientific notation _parseSpec() tests. (amulhern) +- Make size._parseSpec a public method. (amulhern) +- Simplify StorageDevice.disks. (amulhern) +- Simplify StorageDevice.growable. (amulhern) +- Simplify and correct StorageDevice.packages property. (amulhern) +- Remove services infrastructure from devices and formats. (amulhern) +- Split devices tests out into a separate directory. (amulhern) +- Fix dd wipe call. (exclusion) +- Add a script to rebase and merge pull requests (dshea) +- Add pylint false positive to list of pylint false positives. (amulhern) +- Change all instances of GLib.Error to GLib.GError. (amulhern) +- Sort pylint-false-positives using sort's default options with LC_ALL=C. + (amulhern) +- Add ability to match scientific notation in strings. (amulhern) + +* Fri Mar 06 2015 Brian C. Lane - 1.1-1 +- Add scratch, scratch-bumpver and rc-release targets. (bcl) +- Add --newrelease to makebumpver (bcl) +- Add po-empty make target (bcl) +- Revive the mountExistingSystem() function and all it needs (vpodzime) +- Switch translations to use Zanata (bcl) +- Set EFIFS._check to True so that it gets correct fspassno (#1077917) + (amulhern) +- Use format string and arguments for logging function (vpodzime) +- Merge pull request #28 from vpodzime/master-libblockdev (vratislav.podzimek) +- Do not restrict MDRaidArrayDevice's memberDevices to type int (vpodzime) +- Adapt better to libblockdev's md_examine data (vpodzime) +- Set TmpFS._resizable to False. (amulhern) +- Add an additional test for TmpFS. (amulhern) +- Override NoDevFS.notifyKernel() so that it does nothing. (amulhern) +- Add TmpFS._resizefsUnit and use appropriately. (amulhern) +- Rewrite TmpFS class definition. (amulhern) +- Add TmpFS._getExistingSize() method. (amulhern) +- Make _getExistingSize() method more generally useful. (amulhern) +- Remove _getExistingSize() methods with body pass. (amulhern) +- Tidy up the definition of the device property throughout formats package. + (amulhern) +- Add a test to check properties of device paths assigned to formats. + (amulhern) +- Set TmpFSDevice object's _formatImmutable attribute to True. (amulhern) +- Remove no longer needed requires (vpodzime) +- Filter out pylint's "No name 'GLib' in module 'gi.repository'" messages + (vpodzime) +- Add a static method providing list of available PE sizes (vpodzime) +- Use BlockDev's crypto plugin to do LUKS escrow (vpodzime) +- Use BlockDev's DM plugin to work with DM RAID sets (vpodzime) +- Use BlockDev's DM plugin for DM map existence testing (vpodzime) +- Remove tests for the removed devicelibs functions (vpodzime) +- Set and refresh BlockDev's global LVM config if needed (vpodzime) +- Use BlockDev's LVM plugin instead of devicelibs/lvm.py (vpodzime) +- Use BlockDev's BTRFS plugin instead of devicelibs/btrfs.py (vpodzime) +- Use the BlockDev's DM plugin instead of devicelibs/dm.py (vpodzime) +- Use BlockDev's crypto plugin instead of devicelibs/crypto.py (vpodzime) +- Use BlockDev's loop plugin instead of devicelibs/loop.py (vpodzime) +- Use BlockDev's MD plugin instead of devicelibs/mdraid.py (vpodzime) +- Use BlockDev's swap plugin instead of devicelibs/swap.py (vpodzime) +- Use BlockDev's mpath plugin instead of devicelibs/mpath.py (vpodzime) +- First little step towards libblockdev (vpodzime) +- Move the Blivet class into its own module (vpodzime) +- Use a safer method to get a dm partition's disk name. (dlehman) +- Be more careful about overwriting device.originalFormat. (#1192004) (dlehman) + +* Fri Feb 13 2015 David Lehman - 1.0-1 +- Move autopart and installation-specific code outside of __init__.py + (vpodzime) +- Convert _parseUnits to public function (vtrefny) +- LVMFactory: raise exception when adding LV to full fixed size VG (#1170660) + (vtrefny) +- Do not unhide devices with hidden parents (#1158643) (vtrefny) + +* Fri Feb 06 2015 Brian C. Lane - 0.76-1 +- Revert "Switch to temporary transifex project" (bcl) +- Check parent/container type for thin volumes and normal volumes. (dlehman) +- drop useless entries from formatByDefault exceptlist (awilliam) +- Fix import of devicelibs.raid in platform.py (vpodzime) +- Use %%license in python-blivet.spec (bcl) +- Fix import of FALLBACK_DEFAULT_PART_SIZE (vpodzime) +- Make implicit partitions smaller if real requests don't fit anywhere + (vpodzime) +- Use list comprehension instead of filter+lambda in makebumpver (amulhern) +- Revert "Try to deactivate lvm on corrupted gpt disks." (dlehman) +- Virtualize options property methods in DeviceFormat.options definition. + (amulhern) +- Do not redefine size property in TmpFS. (amulhern) +- Do not set self.exists to True in TmpFS.__init__(). (amulhern) +- Simplify NoDevFS.type. (amulhern) +- Set format's mountpoint if it has the mountpoint attribute. (amulhern) +- Do not bother to set device.format.mountopts. (amulhern) +- Tighten up FS.mountable(). (amulhern) +- Simplify FS._getOptions(). (amulhern) +- Simplify setting options variable. (amulhern) +- Be less eager about processing all lines in /proc/meminfo. (amulhern) +- Make error message more useful. (amulhern) +- Add a tiny test for TmpFS. (amulhern) +- More fixes for alignment-related partition allocation failures. (dlehman) +- Do not mix stdout and stderr when running utilities unless requested + (vpodzime) +- Define the _device, _label and _options attributes in constructor (vpodzime) +- Get rid of the has_lvm function (vpodzime) +- Do not create lambda over and over in a cycle (vpodzime) +- Disable pylint check for cached LVM data in more places (vpodzime) +- Fix issue where too many mpath luns crashes installer (#1181336) (rmarshall) +- Allow user-specified values for data alignment of new lvm pvs. (#1178705) + (dlehman) +- Let LVM determine alignment for PV data areas. (#962961) (dlehman) +- Raise UnusableConfigurationError when unusable configuration is detected. + (dlehman) +- Don't raise an exception for failure to scan an ignored disk. (dlehman) +- Try to deactivate lvm on corrupted gpt disks. (dlehman) +- Remove an unused and outdated constant (vpodzime) +- Relax the blivet device name requirements (#1183061) (dshea) + +* Fri Jan 16 2015 Brian C. Lane - 0.75-1 +- Switch to temporary transifex project (bcl) +- Add docstrings to the methods in loop.py (bcl) +- get_loop_name should return an empty name if it isn't found (#980510) (bcl) +- Use dict() instead of dict comprehension. (riehecky) +- Fix the pylint errors in the examples directory. (amulhern) +- Add __init__ file to examples directory. (amulhern) + +* Fri Jan 09 2015 Brian C. Lane - 0.74-1 +- Use _resizefsUnit in resizeArgs() method implementations. (amulhern) +- Do not supply a default implementation for the resizeArgs() method. + (amulhern) +- Use convertTo in humanReadable(). (amulhern) +- Change convertTo() and roundToNearest() so each takes a units specifier. + (amulhern) +- Do not even pretend that ReiserFS is resizable. (amulhern) +- Get whole unit tuple in loop when searching for correct units. (amulhern) +- Make _parseUnits() return a unit constant, rather than a number. (amulhern) +- Add unitStr() method. (amulhern) +- Make _Prefix entries named constants. (amulhern) +- Hoist _BINARY_FACTOR * min_value calculation out of loop. (amulhern) +- Comment _prefixTestHelper() and eliminate some redundancies. (amulhern) +- Eliminate redundant test. (amulhern) +- Avoid using Size constant in FileDevice._create(). (amulhern) +- Do not compare the same two values twice. (amulhern) +- Make possiblePhysicalExtents() a bit more direct. (amulhern) +- Get rid of unnecessary use of long. (amulhern) +- Use _netdev mount option as needed. (#1166509) (dlehman) +- Don't crash when a free region is too small for an aligned partition. + (dlehman) +- Multiple loops shouldn't be fatal (#980510) (bcl) +- If allowing degraded array, attempt to start it (#1090009) (amulhern) +- Add a method that looks at DEVNAME (#1090009) (amulhern) +- Add mdrun method to just start, not assemble, an array. (#1090009) (amulhern) +- Change allow_degraded_mdraid flag to allow_imperfect_devices (#1090009) + (amulhern) +- Remove needsFSCheck() and what only it depends on. (amulhern) +- Remove allowDirty parameter and code that depends on it. (amulhern) +- Eliminate dirtyCB parameter from mountExistingSystem() params. (amulhern) +- Use correct package for FSError. (amulhern) + +* Fri Dec 19 2014 Brian C. Lane - 0.73-1 +- Mountpoint detection for removable devices (vtrefny) +- Fix adding partition after ActionDestroyDevice canceling (vtrefny) +- Avoid exception when aligned start and end are crossed over (exclusion) +- Substitute simple value for single element array. (amulhern) +- Change _matchNames so that it is less restrictive (amulhern) +- Change MDRaidArrayDevice to MDBiosRaidArrayDevice. (amulhern) +- Factor out MDRaidArrayDevice w/ type in ("mdcontainer", "mdbiosraidarray") + (amulhern) +- Make it possible for NTFS to recognize the label it reads. (amulhern) +- Make unnecessarily verbose properties into simple class attributes. + (amulhern) +- Change the generic badly formatted label to one that's bad for all. + (amulhern) +- Don't make overridden values actual properties. (amulhern) +- Check the status of the format being mounted. (amulhern) + +* Thu Dec 04 2014 Brian C. Lane - 0.72-1 +- Add a bunch of simple tests for filesystem formats. (amulhern) +- Get rid of long() related code. (amulhern) +- Add another check for resizable in FS.doResize() (amulhern) +- Simplify FS.free(). (amulhern) +- Make an early exit if self._existingSizeFields is [] (amulhern) +- Change "Aggregate block size:" to "Physical block size:" for JFS. (amulhern) +- Split output from infofs program for size on whitespace. (amulhern) +- Simplify _getSize() and currentSize(). (amulhern) +- Check resizable when assigning a new target size. (amulhern) +- Make default exists value a boolean in DeviceFormat.__init__. (amulhern) +- Remove pointless overrides. (amulhern) +- Add a simple pylint checker for pointless overrides. (amulhern) +- Run dosfsck in non-interactive mode (#1167959) (bcl) + +* Fri Nov 21 2014 Brian C. Lane - 0.71-1 +- Remove redundant import. (amulhern) +- Change inclusion to equality. (amulhern) +- Round filesystem target size to whole resize tool units. (#1163410) (dlehman) +- New method to round a Size to a whole number of a specified unit. (dlehman) +- Fix units for fs min size padding. (dlehman) +- Disable resize operations on filesystems whose current size is unknown. + (dlehman) +- Run fsck before obtaining minimum filesystem size. (#1162215) (dlehman) +- Fix setupDiskImages when the devices are already in the tree. (dlehman) +- Make logging a little less verbose and more useful in FS.mount() (amulhern) +- Make selinux test less precise. (amulhern) +- Do not translate empty strings, gettext translates them into system + information (vtrefny) +- Add a tearDown method to StorageTestCase. (dlehman) +- Remove pointless assignment to _formattable in Iso9660FS. (amulhern) +- Remove BTRFS._resizeArgs() (amulhern) +- Add more arguments to mpathconf (#1154347) (dshea) +- Check the minimum member size for BtrfsVolumeDevices. (amulhern) +- Get rid of FS._getRandomUUID() method. (amulhern) +- Eliminate TmpFS.minSize() (amulhern) +- Don't run selinux context tests when selinux is disabled. (dlehman) +- Temporarily disable a test that isn't working. (dlehman) +- Pass a path (not a name) to devicePathToName. (dlehman) +- devicePathToName should default to returning a basename. (dlehman) +- Fix test that guards forcible removal of dm partition nodes. (dlehman) +- Device status can never be True for non-existent devices. (#1156058) + (dlehman) +- Use super to get much-needed MRO magic in constructor. (#1158968) (dlehman) + +* Thu Nov 06 2014 Brian C. Lane - 0.70-1 +- Add a method that determines whether a number is an exact power of 2. + (amulhern) +- Put size values in Size universe eagerly. (amulhern) +- Update minSize method headers. (amulhern) +- Remove _minSize assignment to 0 where it's inherited from superclass. + (amulhern) +- Make _minInstanceSize, a source of minSize() value, always a Size. (amulhern) +- Fix int * Size operation and add tests (#1158792) (bcl) +- getArch should return ppc64 or ppc64le (#1159271) (bcl) +- Pack data for the wait_for_entropy callback (vpodzime) +- Allow the wait_for_entropy callback enforce continue (vpodzime) + +* Tue Nov 04 2014 Brian C. Lane - 0.69-1 +- Increase max depth of sphinx toc to show subpackage names. (dlehman) +- Temporarily disable the md devicetree tests due to mdadm issues. (dlehman) +- Add ability to set a default fstype for the boot partition (#1112697) (bcl) +- Pass a list of string items to log_method_return. (sbueno+anaconda) +- Require resize target sizes to yield aligned partitions. (#1120964) (dlehman) +- Split out code to determine max unaligned partition size to a property. + (dlehman) +- Allow generating aligned geometry for arbitrary target size. (dlehman) +- Align end sector in the appropriate direction for resize. (#1120964) + (dlehman) +- Specify ntfs resize target in bytes. (#1120964) (dlehman) +- Check new target size against min size and max size. (dlehman) +- Add a number of new tests. (amulhern) +- Add xlate parameter to humanReadable(). (amulhern) +- Rewrite _parseSpec() and convertTo() (amulhern) +- Make _lowerASCII() python 3 compatible and add a method header. (amulhern) +- Use b"", not u"", for _EMPTY_PREFIX. (amulhern) +- Strip lvm WARNING: lines from output (#1157864) (bcl) +- Add testing for MDRaidArrayDevice.mdadmFormatUUID (#1155151) (amulhern) +- Give mdadm format uuids to the outside world (#1155151) (amulhern) +- Make logSize, metaDataSize, and chunkSize always consistently Size objects. + (amulhern) + +* Wed Oct 22 2014 Brian C. Lane - 0.68-1 +- Only write label if there is a label AND labeling application. (amulhern) +- Handle unicode strings in Size spec parsing. (dshea) +- Fix typo in getting Thin Pool profile's name (vpodzime) +- Don't try to get no profile's name (#1151458) (vpodzime) +- Change signature of DiskLabel.addPartition to be more useful. (dlehman) +- Remove unused fallback code from DiskLabel. (dlehman) +- Let udev settle between writing partition flags and formatting. (#1109244) + (dlehman) +- Set _partedDevice attribute before calling device constructor (#1150147) + (amulhern) +- Fixed wrong Runtime Error raise in _preProcessActions (vtrefny) +- Set sysfsPath attribute before calling Device constructor (#1150147) + (amulhern) +- Return all translated strings as unicode (#1144314) (dshea) +- Force __str__ to return str. (dshea) +- Use the i18n module instead of creating new gettext methods (dshea) +- Take care when checking relationship of parent and child UUIDs (#1151649) + (amulhern) +- Further abstract loopbackedtestcase on block_size. (amulhern) +- Update tests to bring into line w/ previous commit (#1150147) (amulhern) +- Abstract ContainerDevice member format check into a method (#1150147) + (amulhern) +- Register DeviceFormat class (#1150147) (amulhern) +- Don't append btrfs mount options to None (#1150872) (dshea) +- Convert int to str before passing it to run_program (#1151129) (amulhern) + +* Thu Oct 09 2014 Brian C. Lane - 0.67-1 +- Don't pass --disable-overwrite to tx pull. (dlehman) +- Avoid unneccesarily tripping raid-level member count checks. (dlehman) +- Allow toggling encryption of raid container members. (#1148373) (dlehman) +- Include the new blivet.devices submodule in the built package. (clumens) +- Add a few test for setting dataLevel and metaDataLevel in BTRFS (amulhern) +- Add dataLevel and metaDataLevel attributes for testing. (amulhern) +- Add isleaf and direct to _state_functions (amulhern) +- Refactor setup of _state_functions into __init__() methods (amulhern) +- Move getting the attribute into the check methods. (amulhern) +- Adjust detection of exceptions raised. (amulhern) +- Update test setup so that it obeys RAID level requirements. (amulhern) +- Use new RaidDevice class in appropriate Device subclasses. (amulhern) +- Add new RaidDevice class for handling RAID aspects of devices. (amulhern) +- Do not set parents attribute if parents param is bad. (amulhern) + +* Wed Oct 08 2014 Brian C. Lane - 0.66-1 +- Organize installer block device name blacklist. (#1148923) (dlehman) +- Add likely to be raised exceptions to catch block (#1150174) (amulhern) +- Canonicalize MD_UUID* values in udev.py (#1147087) (amulhern) +- Split up devices.py. (dlehman) +- Fix some pylint errors introduced in recent commits. (dlehman) +- Return early when setting new size for non-existent partition. (dlehman) +- Raise an exception when we find orphan partitions. (dlehman) +- Fall back to parted to detect dasd disklabels. (dlehman) +- Omit pylint false positive (amulhern) +- Revert "pylint hack" (amulhern) +- Remove unused import (amulhern) +- Remove unused import (amulhern) +- pylint hack (amulhern) +- Make sure autopart requests fit in somewhere (#978266) (vpodzime) +- Work with free region sizes instead of parted.Geometry objects (vpodzime) +- Check that we have big enough free space for the partition request (vpodzime) +- Allow specifying thin pool profiles (vpodzime) +- Allow specifying minimum entropy when creating LUKS (vpodzime) +- Allow user code provide callbacks for various actions/events (vpodzime) +- Change default min_value from 10 to 1 in humanReadable() (amulhern) +- Rewrite of Size.humanReadable() method (amulhern) +- Factor out commonalities in xlated_*_prefix() methods. (amulhern) +- Use named constants for binary and decimal factors. (amulhern) +- Use UPPER_CASE for constants (amulhern) + +* Tue Sep 30 2014 Brian C. Lane - 0.65-1 +- Remove a problematic remnant of singlePV. (dlehman) +- Remove all traces of singlePV. (sbueno+anaconda) +- Change the default /boot part on s390x to not be lvm. (sbueno+anaconda) +- Remove redundant check for parents in Blivet.newBTRFS. (dlehman) +- Use Decimal for math in Size.convertTo. (dlehman) +- Filter out free regions too small for alignment of partitions. (dlehman) +- Disable LVM autobackup when doing image installs (#1066004) (wwoods) +- Add attribute 'flags.lvm_metadata_backup' (wwoods) +- lvm_test: refactoring + minor fix (wwoods) +- devicelibs.lvm: refactor _getConfigArgs()/lvm() (wwoods) +- devicelibs.lvm: fix pvmove(src, dest=DESTPATH) (wwoods) +- Only pad for md metadata if pvs use multiple disks. (dlehman) +- Align free regions used for partition growing calculations. (dlehman) +- Try to align end sector up when aligning new partitions. (dlehman) +- Remove obsolete conversion of size to float. (dlehman) +- Honor size specified for explicit extended partition requests. (dlehman) +- Honor zerombr regardless of clearpart setting. (dlehman) +- Fix treatment of percent as lvm lv size spec. (dlehman) +- Change variable keyword (#1075671) (amulhern) +- Remove unused import (#1075671) (amulhern) +- Don't mix target and discovery credentials (#1037564) (mkolman) +- Make sure /boot/efi is metadata 1.0 if it's on mdraid. (pjones) +- iscsi: fix root argument being overriden by local variable (#1144463) + (rvykydal) +- iscsi: add iscsi singleton back (#1144463) (rvykydal) + +* Fri Sep 19 2014 Brian C. Lane - 0.64-1 +- Fix pylint errors from recent btrfs commits. (dlehman) +- Only cancel actions on disks related to the one we are hiding. (dlehman) +- Cancel actions before hiding descendent devices. (dlehman) +- Improve handling of device removals/additions from the devicetree. (dlehman) +- The first format destroy action should obsolete any others. (dlehman) +- Do not allow modification or removal of protected devices. (dlehman) +- Propagate mount options for btrfs members to all volumes/subvolumes. + (dlehman) +- Properly identify dm devices even when udev info is incomplete. (dlehman) +- Do not mount btrfs to list subvolumes outside installer_mode. (dlehman) +- Reset default subvolume prior to removing the default subvolume. (dlehman) +- Increase max size for btrfs to 16 EiB. (#1114435) (dlehman) +- Improve adjustment for removal of a subvol in BTRFSFactory. (dlehman) +- Set dummy mountpoint in ksdata for lvm thin pools. (dlehman) +- Add an epoch to blivet. (sbueno+anaconda) +- Check if device has enough members when setting RAID level (#1019685) + (amulhern) +- Add BTRFSValueError error and use in btrfs related code (#1019685) (amulhern) +- iscsi: mount partitions in initramfs for root on iscsi (#740106) (rvykydal) +- Remove poolMetaData (#1021505) (amulhern) +- Revert "Allow use of a single path if multipath activation fails. (#1054806)" + (vpodzime) +- Add a release make target (bcl) +- Prefer ID_SERIAL over ID_SERIAL_SHORT (#1138254) (vpodzime) +- Allow use of a single path if multipath activation fails. (#1054806) + (dlehman) + +* Wed Sep 10 2014 Brian C. Lane - 0.63-1 +- Update makebumpver to include flags on first request (bcl) +- Condense and comment some devicelibs.dasd methods (#1070115) (amulhern) +- Add a test file for DASD handling (#1070115) (amulhern) +- Pylint inspired cleanup (#1070115) (amulhern) +- Add a property for read-only devices. (dshea) +- Get rid of misleading comment (#1066721) (amulhern) +- Allow user code creating free space snapshot (vpodzime) +- Add two functions to enable manual addition of ECKD DASDs. (sbueno+anaconda) +- Make prefering leaves the default in getDeviceByPath (#1122081) (amulhern) +- Make _filterDevices() return a generator consistently (#1122081) (amulhern) +- Split string of symlinks into array of strings (#1136214) (amulhern) +- Don't put "Linux" in a root's name if it's already there. (clumens) + +* Thu Aug 28 2014 Brian C. Lane - 0.62-1 +- Mock pyudev since libudev will not be on the builders. (dlehman) +- Update selinux tests for default context of mounts under /tmp. (dlehman) +- Clean up mocking done by udev tests when finished. (dlehman) +- Remove unused lvm and md activation code. (dlehman) +- Bypass size getter when mocking new devices. (dlehman) +- Simplify udev.device_get_uuid. (dlehman) +- Don't pass md array UUID as member format UUID. (dlehman) +- Update md name when lookup relied on UUID. (dlehman) +- Remove an obsolete block related to unpredictable md device names. (dlehman) +- Get md member and array UUIDs for format ctor from udev. (dlehman) +- Look in udev data for md member UUID. (dlehman) +- Remove some unused multipath-specific functions from blivet.udev. (dlehman) +- Adapt multipath detection code to external pyudev module. (dlehman) +- Keep lvm and md metadata separate from udev info. (dlehman) +- Replace our pyudev with the package python-pyudev. (dlehman) +- Add a bunch of tests for mdadd. (amulhern) +- Make has_redundancy() a method rather than a property and revise mdadd. + (amulhern) +- Omit unnecessary class hierarchy related boilerplate. (amulhern) +- Add a test for activation. (amulhern) +- Add a test for mddetail on containers. (amulhern) +- Still attempt to destroy even if remove failed. (amulhern) +- Use long messages for unittest errors. (amulhern) +- Fix mdnominate error message. (amulhern) +- Cosmetic changes for the swapSuggestion function (vpodzime) +- Break once metadata value is found. (amulhern) +- Fix issues reported by pyflakes (vpodzime) +- Remove tests for the sanityCheck (vpodzime) +- Move _verifyLUKSDevicesHaveKey and its exception to anaconda (vpodzime) +- Remove sanityCheck functions from blivet sources (vpodzime) +- Remove an unused closure function (vpodzime) +- Remove two methods that are never called (vpodzime) +- Add some tests for blivet.partitioning.addPartition. (dlehman) +- Add a couple of tests for blivet.partitioning.DiskChunk. (dlehman) +- Add a DiskFile class for testing partitioning code as a non-root user. + (dlehman) +- Add a contextmanager to create and remove sparse tempfiles. (dlehman) +- Fix sphinx formatting of code blocks in devicefactory docstrings. (dlehman) +- Mock selinux when building docs. (dlehman) +- Include doc files when installing on readthedocs. (dlehman) +- _maxLabelChars is no longer used by anything (bcl) +- tests: Add tests for HFSPlus labels (#821201) (bcl) +- Write a fs label for HFS+ ESP (#821201) (bcl) +- Mock non-standard modules so we can generate API docs on readthedocs. + (dlehman) +- Split mdadd into separate functions. (amulhern) +- Refactor mdraid tests. (amulhern) +- Add a method to extract information about an mdraid array (amulhern) +- Extend mdadm() to capture output (amulhern) +- Be more robust in the face of possible changes to mdadm's UUIDs. (amulhern) +- Factor canonicalize_UUID() into separate method. (amulhern) +- Add a docstring to mdraid.mdexamine (amulhern) +- Remove DeviceFormat.probe() method (amulhern) +- Remove all references to mdMinor in current code base. (amulhern) +- Generalize the error message for the array level (amulhern) +- Use super() instead of explicit parent name (amulhern) +- Remove commented out import. (amulhern) +- Make docstring more precise. (amulhern) +- Minor fix of a docstring. (rvykydal) +- Get rid of partedFlags field. (amulhern) + +* Fri Jul 11 2014 Brian C. Lane - 0.61-1 +- Fix conf.py version bumping (bcl) +- Add some tests for Chunk and Request class hierarchy. (dlehman) +- Honor the skip list when allocating leftover sectors. (dlehman) +- A Chunk is done growing when its pool is empty. (dlehman) +- Don't use integer division to calculate a fraction. (dlehman) +- Bump version in sphinx config from scripts/makebumpver. (dlehman) +- Remove spec= from Size usage in intro.rst. (dlehman) +- Attempt to reset the uuid of the mdraid member device (#1070095) (amulhern) +- Add new method udev.device_get_md_device_uuid() method (#1070095) (amulhern) +- Canonicalize mdadm generated UUIDS (#1070095) (amulhern) +- Add a udev.device_get_md_metadata() method to udev and use it. (amulhern) +- Change use of METADATA to MD_METADATA. (amulhern) +- Check for md_level of None (amulhern) +- Do not convert the result of udev.device_get_md_devices() to int. (amulhern) +- Add documentation to udev.device_get_md_*() methods. (amulhern) +- Document udev.device_get_uuid() method. (amulhern) +- Add a few small tests for mdexamine (amulhern) +- Add test for raid level descriptor None. (amulhern) +- Use context manager with assertRaises*() tests. (amulhern) +- Change uuid parameter to array_uuid (amulhern) +- Remove udev_ prefix from udev methods. (amulhern) +- Remove all references to DeviceFormat.majorminor (amulhern) +- Use add_metaclass instead of with_metaclass. (amulhern) +- Disable redefined-builtin warning. (amulhern) +- Use range instead of xrange in generateBackupPassphrase() (amulhern) +- Add a simple test of generateBackupPassphrase() result format (amulhern) +- Python3 compatibility (rkuska) +- Replace python-setuptools-devel BR with python-setuptools (bcl) + +* Wed Jul 02 2014 Brian C. Lane - 0.60-1 +- Do not use udev info to get the name of the device. (amulhern) +- Remove unnecessary fanciness about importing devices. (amulhern) +- Disable some pylint warnings that arise due to anaconda versions. (amulhern) +- Allow RAID1 on EFI (#788313) (amulhern) + +* Thu Jun 26 2014 Brian C. Lane - 0.59-1 +- When logging, indicate whether exception was ignored by blivet. (amulhern) + +* Wed Jun 25 2014 Brian C. Lane - 0.58-1 +- Only import ROOT_PATH if needed (bcl) +- Add early keyword to setUpBootLoader (#1086811) (bcl) +- Only log a warning about labeling if something is wrong (#1075136) (amulhern) +- When adding an md array, allow adding incomplete arrays (#1090009) (amulhern) +- Add a flag to control whether a degraded md raid array is used (#1090009) + (amulhern) +- Remove preferLeaves parameter from getDeviceByPath() (amulhern) +- Factor out commonalities among getDevice[s|]By* methods. (amulhern) +- Omit special check for md devices in addUdevDevice(). (amulhern) +- Remove unused 'slaves' variable. (amulhern) +- Move down or remove assignment to device in add* methods. (amulhern) +- Move DevicelibsTestCase up to the top level of the testing directory. + (amulhern) +- Accept None for btrfs raid levels (#1109195) (amulhern) +- Add a test for a btrfs error associated with small devices (#1109195) + (amulhern) + +* Thu Jun 19 2014 Brian C. Lane - 0.57-1 +- Make DevicelibsTestCase devices configurable. (amulhern) +- Use correct parameters in __init__() in subclasses of unittest.TestCase. + (amulhern) +- Add num_blocks parameter to makeLoopDev(). (amulhern) +- Move skipUnless decorator to the top level class of skipped classes. + (amulhern) +- Explicitly accept a string as well as a RAIDLevel object. (amulhern) +- Update BTRFS initializer comments for level type. (amulhern) +- Remove some extra imports. (amulhern) +- Add method to set the default disklabel (#1078537) (bcl) +- Do not try to activate dmraid sets if the dmraid usage flag is false + (mkolman) +- Use the value of the Anaconda dmraid flag to set the Blivet dmraid flag + (mkolman) +- Use the value of the Anaconda ibft flag to set the Blivet ibft flag (mkolman) +- Ignore _build directory in doc directory. (amulhern) +- Change intersphinx mapping to avoid linkcheck redirect errors. (amulhern) +- Remove doctest target from Makefile. (amulhern) +- Allow the table of contents to go one level deeper. (amulhern) +- Automate generation of the .rst files which just set up the modules. + (amulhern) + +* Thu Jun 12 2014 Brian C. Lane - 0.56-1 +- Skip device name validation for some device types. (dlehman) +- Add a property indicating whether a device is directly accessible. (dlehman) +- Add support for read-only btrfs snapshots. (dlehman) +- Add tests for snapshots. (dlehman) +- Special treatment for getting parted device for old-style lvm snapshots. + (dlehman) +- Some devices have immutable formatting. (dlehman) +- Detect existing btrfs snapshots. (dlehman) +- Drop special accounting for snapshot space usage in VG. (dlehman) +- Use LVMSnapshotDevice when populating the devicetree. (dlehman) +- Add Device classes for snapshots. (dlehman) +- Add ignore_skip keyword arg to lvactivate. (dlehman) +- Add optional kwarg to force removal of a logical volume. (dlehman) +- Add backend functions for creating and managing snapshots. (dlehman) +- Add docstrings for BTRFSVolumeDevice and BTRFSSubVolumeDevice. (dlehman) +- Remove duplicate portion of lvm config string. (dlehman) +- Reset the devicetree before tearing everything down in _cleanUp. (dlehman) +- Make sure disk filters are applied even if populate fails. (dlehman) +- Sync the spec file with downstream (vpodzime) + +* Mon Jun 09 2014 Vratislav Podzimek - 0.55-1 +- IPSeriesPPC now supports GPT in Open Firmware (hamzy) +- Fix device name validation for devices that can contain / (#1103751) (dshea) +- Add a getRaidLevel() convenience method to raid.py (amulhern) +- Make a StorageDevice.raw_device property and use it where appropriate + (amulhern) +- Simplify a small chunk of Blivet.updateKSData() (amulhern) +- Move the code for getting a space requirement from devicefactory to raid. + (amulhern) +- Make all devicefactory classes uses RAID objects instead of strings. + (amulhern) +- Remove devicefactory.get_raid_level from blivet (amulhern) +- Put get_supported_raid_levels in devicefactory.py (amulhern) +- Make BTRFS devices use RAID objects instead of strings for levels (amulhern) +- Add lists of supported RAID levels for btrfs and lvm (amulhern) +- Add "linear" to mdraid's list of supported raid levels. (amulhern) +- Remove getRaidLevel() from mdraid file and make RAID_levels public (amulhern) +- Check for required methods in MDRaidLevels.isRaidLevel. (amulhern) +- Use has_redundancy property to decide how to add a member to an array. + (amulhern) +- Update the mdraid.mdadd comments (amulhern) +- Use has_redundancy raid property when checking whether a device is removable + (amulhern) +- Make createBitmap() a property and update tests appropriately. (amulhern) +- Add a Dup class to the various descendants of RAIDLevel. (amulhern) +- Add an is_uniform property to the RAID levels. (amulhern) +- Add a has_redundancy method that returns True if there is actual redundancy + (amulhern) +- Add Linear and Single to the RAID classes. (amulhern) +- Move Container class to raid package and tidy it up (amulhern) +- Allow the RAID object itself to be a valid RAID descriptor for lookup. + (amulhern) +- Adjust RaidLevel hierarchy so that all raid level objects extend RAIDLevel + (amulhern) +- No longer use _standard_levels as the default set of RAID levels. (amulhern) +- Extract selection of members in complete() into a separate method. (amulhern) +- Remove DMRaidArrayDevice.members property. (amulhern) +- Comment mdraid.mdcreate() and update tests appropriately. (amulhern) +- Import name 'lvm' instead of names from lvm package. (amulhern) + +* Sat Jun 07 2014 Fedora Release Engineering - 0.54-2 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_21_Mass_Rebuild + +* Wed May 28 2014 Brian C. Lane - 0.54-1 +- Add tests for setting device's parent list directly (vpodzime) +- Do not alter the ParentList being iterated over (#1083581) (vpodzime) +- Do not limit ThinLV's size to VG's free space (vpodzime) +- Take extra RAID metadata into account when growing LV (#1093144) (vpodzime) +- Move apply_chunk_growth outside of a for-cycle (vpodzime) +- Multiple arguments for string formatting need to be in parentheses (#1100263) + (mkolman) +- Make print statements Python 3 compatible (mkolman) +- Validate device names (dshea) +- Use a setter for Device.name as foretold by the prophecy of TODO (dshea) + +* Tue May 20 2014 Brian C. Lane - 0.53-1 +- Remove extra quotes from the xfs_db arguments. (dshea) +- Factor duplicate code in __deepcopy__ methods into one method (#1095244) + (amulhern) +- Rearrange code related to handleUdevDeviceFormat() (#1095329) (amulhern) +- Make dumpState catch and log all AttributeErrors (#1095329) (amulhern) +- Add sectorSize property to catch and handle missing partedDevice (#1095329) + (amulhern) +- Get rid of remaining uses of spec keyword for Size() in examples directory. + (amulhern) +- Generalize false positive regular expression for multiple pylint versions + (amulhern) +- Do not run some tests unless running on Jenkins. (amulhern) +- Miscellaneous pylint fixes. (amulhern) +- Globally disable pointless string statement warning (amulhern) +- Disable unused argument warning for 'args' in TmpFSDevice constructor + (amulhern) +- Omit 'args' parameter from formats constructors (amulhern) +- Disabled unused argument warning for kwargs in formats.destroy() (amulhern) +- Omit *args from parameters for format.create() and formats.destroy() + (amulhern) +- Omit *args from parameters in formats.setup() (amulhern) +- Make formats.teardown() not take any extra parameters. (amulhern) +- Make formats.mount use explicit keywords instead of kwargs. (amulhern) +- Remove non-self params from FS.doResize method (amulhern) +- Make doFormat use regular style keyword parameters (amulhern) +- Do not use *args, **kwargs idiom in scheduleCreateFormat. (amulhern) +- Do not use *args, **kwargs idiom in various schedule* auxiliary test methods. + (amulhern) +- Remove upgrading param from turnOnSwap() (amulhern) +- Disable unused-argument warning (amulhern) +- Disable pylint unused-argument warning. (amulhern) + +* Thu May 08 2014 Brian C. Lane - 0.52-1 +- Split ROOT_PATH usage into getTargetPhysicalRoot()/getSysroot() (walters) +- Update and fix copyright info for docs. (dlehman) +- Add some tests for extended partition management. (dlehman) +- Add some tests that verify the results of DeviceTree.populate. (dlehman) +- Add a base class for tests backed by disk image storage. (dlehman) +- Adapt examples to examples/common.py function dispersement. (dlehman) +- Change devices.SparseFileDevice._create to use util.create_sparse_file. + (dlehman) +- Move set_up_logging and create_sparse_file into blivet.util for reuse. + (dlehman) +- Make examples.common.tear_down_disk_images a DeviceTree method. (dlehman) +- Fix handling of devices activated as a side-effect of actions. (dlehman) +- Check for problematic active devices before processing any actions. (dlehman) +- Split some large blocks out of DeviceTree.processActions. (dlehman) +- Explicitly requested extended partitions already have an action. (dlehman) +- Fix handling of extended partitions across various modes of operation. + (dlehman) +- Handle the case of md arrays getting activated from outside blivet. (dlehman) +- Make an extra effort to remove dm partition nodes that want to stay. + (dlehman) +- Fix handling of clearing a partitioned disk and leaving it cleared. (dlehman) +- Don't check for disklabels on partitions. (dlehman) +- Update targetSize to reflect actual size after a device is created. (dlehman) +- Remove redundant msecs from logging timestamp. (dlehman) +- Make signature of Size.__new__ match signature of Decimal.__new__ (amulhern) +- Change Size so that it takes a single value parameter. (amulhern) +- Change all 'format' keyword args to 'fmt' in Device constructors (amulhern) +- Change format keyword argument to fmt in scheduleCreateFormat (amulhern) +- Change keyword parameters in devicetree.findActions (amulhern) +- Change ActionCreateFormat constructor keyword argument to 'fmt' (amulhern) +- Remove unused parameter 'ignoreErrors' from umountFilesystems() (amulhern) +- Remove parameter 'raiseErrors' from mountFilesystems() methods. (amulhern) +- Disable unused argument warning for 'major' and 'minor' (amulhern) +- Set dummy functions as values rather than via function definition syntax. + (amulhern) +- Pass size value to superconstructor for LVMVolumeGroupDevice. (amulhern) +- Sort the pylint-false-positives file (amulhern) +- Do not disable unused argument warning. (amulhern) +- Omit pylint warning about disabled warnings or errors from pylint log. + (amulhern) +- Put the pyblock warning in pylint-false-positives (amulhern) +- Remove obsolete documentation for parameter 'label'. (amulhern) + +* Mon May 05 2014 Brian C. Lane - 0.51-1 +- Adjust the available size on each disk using chunk size. (amulhern) +- Removed some now unused methods from devices (#1085474) (amulhern) +- Rename size() method to get_size() method. (amulhern) +- Remove unused get_size method (#1085474) (amulhern) +- Use raid.size method to get size of device (#1085474) (amulhern) +- Add a size() method to the raid classes (#1085474) (amulhern) +- Move line that might throw an MDRaid exception inside try block (#1085474) + (amulhern) +- Check whether type is mdbiosraidarray before checking smallest member + (#1085474) (amulhern) +- Log if there was a failure to calculate the size of the MDRaidArrayDevice + (#1085474) (amulhern) +- Rename get_raw_array_size to get_net_array_size (#1085474) (amulhern) +- Rename _get_size to _trim, which describes its function better (#1085474) + (amulhern) +- Improve comments on a few methods (#1085474) (amulhern) +- Make RAIDLevels iterable (#1085474) (amulhern) +- Update makebumpver for python-bugzilla 1.0.0 (bcl) +- Disable unused argument warning for 'key_file' in devicelibs.crypto methods + (amulhern) +- Disable unused argument warning for 'del_passphrase' in luks_remove_key + (amulhern) +- Disable unused argument warning for 'data' in doAutoPartition (amulhern) +- Disable unused argument warning for 'info' in handleUdevLuksFormat (amulhern) +- Disable unused argument warning for 'disks' in get_pv_space. (amulhern) +- Remove pointless parameters from unittest methods. (amulhern) +- Disable a no member warning for EddTestFS initializer. (amulhern) +- Get rid of unused argument 'args' in MakeBumpVer constructors (amulhern) +- Changes to _parseOneLine() and its single invocation. (amulhern) +- Remove obsolete comment (amulhern) +- Rename to avoid redefining parameter built-ins (amulhern) +- Change name to avoid redefining built-in (amulhern) +- Remove unused parameter in makeupdates. (amulhern) +- Removed unused argument 'options' from testMount (amulhern) +- Make signature of _setSize match that of the method it overrrides. (amulhern) +- Actually use argv parameter (amulhern) +- Pass fname as first argument to shutil.copy2 (amulhern) +- Remove minimumSector method and _minimumSector attribute (amulhern) +- Disable not-callable pylint warning. (amulhern) +- Set child_factory_fstype to None in DeviceFactory (amulhern) +- Suppress unpacking-non-sequence pylint warning (amulhern) +- Prefix name with defining package (amulhern) +- Update Platform instance from flags instead of replacing it. (#1090646) + (dlehman) +- Rename to avoid redefining built-ins where the redefinition is method local. + (amulhern) +- Set device.format in else block of try/except/else. (amulhern) +- Do not run pylint on sphinx generated conf.py (amulhern) +- Get rid of a redefined builtin while simplifying method. (amulhern) +- Compress loop into generator list comprehension (amulhern) +- Rewrite resize() method to depend on _resizable. (amulhern) +- Remove definition of LVMThinLogicalVolumeDevice._resizable (amulhern) +- Add an attribute docstring for _resizable. (amulhern) +- Correct comment on resizable property (amulhern) + +* Thu Apr 24 2014 Brian C. Lane - 0.50-1 +- Don't apply action until after all checks have passed. (dlehman) +- Apply action for extended partition creation. (dlehman) +- Fix an issue introduced in commit a210eb5c. (dlehman) +- Move changes from action ctors into apply methods. (dlehman) +- Tell lvm to prefer /dev/mapper/ and /dev/md/ to dm-X and mdX nodes. (dlehman) +- Use the right md UUID when trying to look one up from addUdevDevice. + (dlehman) +- Pass UUID of existing md array to superclass constructor. (dlehman) +- Fix accounting related to addition of md member devices. (dlehman) +- Add some more tests for the Size.humanReadable method (vpodzime) +- If size is an integer value, show it as an integer value (vpodzime) +- Make sure that using just k/m/g/... results in KiB/MiB/GiB/... (vpodzime) +- Make humanReadable size use binary prefixes and nicer units (vpodzime) +- Round sizes in humanReadable instead of flooring them (vpodzime) +- Do not assign result of evaluating EddTestFS() to a variable (amulhern) +- Rename bits() to numBits() (amulhern) +- Rename to avoid conflict with name in outer scope. (amulhern) +- Put module level code in a method (amulhern) +- Do not use strip() incorrectly (amulhern) +- Disable E1101 (no-member) error (amulhern) +- Use isResize in isShrink and isGrow. (amulhern) +- Suppress W0612 (unused-variable) false positives (amulhern) +- Suppress W0621 warnings (amulhern) +- Add a stub function for get_bootloader (amulhern) +- Suppress W0602 false positives (amulhern) +- Remove BootLoaderError definitions (amulhern) +- Disable E1003 warning. (amulhern) +- Do not cache the DeviceFormat object (amulhern) +- Suppress W0201 error where attribute is set in __new__. (amulhern) +- Add to false positives an error which is not suppressed by a pragma. + (amulhern) +- Suppress W0201 errors (amulhern) +- Make signature of Size.__str__ match signature of Decimal.__str__ (amulhern) +- Do not evaluate %% operator in log message arguments (amulhern) +- Remove suite() methods in tests (amulhern) +- Remove addKeyFromFile() method (amulhern) +- Import name 'deviceaction' where needed (amulhern) +- Setting variables in __init__ (amulhern) +- Log exception information and disable W0703 warning. (amulhern) +- Disable some W0703 warnings (amulhern) +- Disable some W0703 warnings. (amulhern) +- Add a function that logs available exception info. (amulhern) +- Restrict scope of pylint pragmas as much as possible (amulhern) +- Change all pylint numeric codes to mnemonic strings. (amulhern) + +* Thu Apr 17 2014 Brian C. Lane - 0.49-1 +- Slightly reduce loop and get rid of obsolete comment (amulhern) +- Slightly rewrite loop to avoid a redefining builtin error (amulhern) +- Simplify find_library and fix redefining built-in errors. (amulhern) +- Make loop variables a little more descriptive (amulhern) +- Make regular expressions raw strings. (amulhern) +- Suppress unused variable warning and check for failure. (amulhern) +- Add W0105 warning about attribute docstrings to false positives (amulhern) +- Make signature of setup() in parent class same as in children (amulhern) +- Suppress some correct pylint warnings (amulhern) +- Get _loopMap.values() when all that's needed is the values (amulhern) +- Obvious fix inspired by pylint E0602 error (amulhern) +- Suppress W0631 warning for abbr and prefix. (amulhern) +- Do not do formatting operation in the argument of the translation (amulhern) +- Remove unnecessary global statements (amulhern) +- Disable W0703 message in test (amulhern) +- Explicitly set the module level platform variable (amulhern) + +* Thu Apr 10 2014 Brian C. Lane - 0.48-1 +- Do not execute smallestMember property method twice. (amulhern) +- Remove unnecessary function definitions in abstract properties (amulhern) +- Pass format args as arguments to debug method (#1085057) (amulhern) +- Move udev_settle call from util into fs to break circular dependency + (amulhern) +- Change implicit relative imports to explicit relative imports (amulhern) +- Remove unused imports (amulhern) +- Get rid of os.path import (amulhern) +- Really avoid dynamic import of formats/__init__.py by itself (amulhern) +- Ignore E1101 errors in savePassphrase. (amulhern) +- Add a bunch of E1120 errors to the false positives file (amulhern) +- Make LabelingAsRoot class an abstract class and define two properties + (amulhern) +- Suppress false positive W0631 error. (amulhern) +- Use self.nic instead of nic (amulhern) +- Make sure _state_functions is a dictionary in base class (amulhern) +- Remove unnecessary lambda wrappers on assertion functions (amulhern) +- Obvious fix inspired by an "Undefined variable warning" (amulhern) +- Remove all references to lvm_vg_blacklist and blacklistVG. (amulhern) +- Update for changes in the anaconda errorHandler API. (dshea) +- Remove unused imports. (amulhern) +- Import from the defining module. (amulhern) +- Move import to top level. (amulhern) +- Do not use implicit relative imports (amulhern) +- Remove wildcard import (amulhern) +- Fix a bug and catch a change in lvm's thin pool layout. (dlehman) +- Plumb uuid down through DMDevice. (dlehman) + +* Wed Apr 02 2014 Brian C. Lane - 0.47-1 +- Change labelApp to a more concisely defined abstract property (amulhern) +- Change defaultLabel to a more concisely defined abstract property. (amulhern) +- Change _labelstrRegex to a more concisely defined abstract property. + (amulhern) +- Make reads property a bit more succinct. (amulhern) +- Make name an abstract property and omit _name (amulhern) +- Remove an unused import from devicelibs/raid.py (vpodzime) +- Fix all pylint errors in pylintcodediff (amulhern) +- Don't run test if the git branch is dirty (amulhern) +- Exit if the specified log file does not exist. (amulhern) +- Update lvm devicelibs tests to reflect recent changes. (dlehman) +- Add required LVs as needed instead of trying to sort by attrs. (dlehman) +- Fix missed conversion of rm->missing in vgreduce call. (dlehman) +- Only gather lvm information one time per DeviceTree.populate call. (dlehman) +- Add support for listing everything to pvinfo and lvs. (dlehman) +- Get lv list from lvm in a more straightforward format. (dlehman) +- Gather lv list where we use it to save from having to stash it. (dlehman) +- Split out common lvm parsing code. (dlehman) +- Add tests that use ParentList as part of Device. (dlehman) +- Parent list length doesn't reflect new member in _addParent. (dlehman) +- Rearrange _startEdd to be a little more obvious. (amulhern) +- Raise exceptions using the new syntax (amulhern) +- Do not import logging twice. (amulhern) +- Suppress unused variable warning (amulhern) +- Get rid of writeRandomUUID. (amulhern) +- Remove unused variable but retain call for its side-effects (amulhern) +- Put docstring in class (amulhern) +- Remove appendiceal assignment (amulhern) +- Keep first parameter "self" (amulhern) +- Omit compile flag (amulhern) +- Move lines beneath __main__ into a main method (amulhern) +- Indent with spaces, not tabs (amulhern) +- Change param default [] to None and convert in method (amulhern) +- Change to a semantically equivalent version of FileDevice.path (amulhern) +- Adapt existing tests to changed signature of some methods (amulhern) +- Don't assign return value to unused variable (amulhern) +- Be specific when catching exceptions (dshea) +- Remove appendiceal assignments (amulhern) +- Remove a lot of unused variables extracted from udev info (amulhern) +- Don't get return values from communicate() if they are ignored (amulhern) +- Use the disk's name in log message (amulhern) +- Get rid of old exception unpacking syntax (dshea) +- Rearranged some iffy exception checking (dshea) +- Replace with a semantically equivalent chunk. (amulhern) +- Remove some unused exception names. (amulhern) +- Remove unused assignment to boot. (amulhern) +- Delete method-local pruneFile function. (amulhern) +- Don't comment out function headers but leave their bodies uncommented + (amulhern) +- Get rid of unnecessary pass statements (amulhern) +- Put a field and a method in the base class (amulhern) +- Spell parameter self correctly (amulhern) +- Give abstract method the same signature as its overriding methods. (amulhern) +- Catch correct error and disable warning. (amulhern) + +* Wed Mar 26 2014 Brian C. Lane - 0.46-1 +- Adapt callers to use the new parent list interface. (dlehman) +- Change management of Device parents to use a simple list interface. (dlehman) +- Convert ContainerDevice to an abstract base class. (dlehman) +- Set device uuid before calling Device ctor. (dlehman) +- Improve the mechanism for VG completeness. (dlehman) +- Support mutually-obsoleting actions. (dlehman) +- Add some checking to MDRaidArrayDevice._setSpares. (dlehman) +- Make sorting by action type part of the action classes. (dlehman) +- Add action classes for container member set management. (dlehman) +- Add a property to provide consistent access to parent container device. + (dlehman) +- Add type-specific methods for member set management. (dlehman) +- Adapt callers to new method names for add/remove member device. (dlehman) +- Add a ContainerDevice class to consolidate member management code. (dlehman) +- Add backend functions for container member set management. (dlehman) +- Teardown RAID device once testing is over (amulhern) +- Make lvm tests runnable. (amulhern) +- Make crypt tests runnable. (amulhern) +- Replace unnecessarily complicated expression with string multiplication + (amulhern) +- Suppress unused variable warning for index in range (amulhern) +- Suppress some unused variable warnings. (amulhern) +- Suppress some unused variable warnings (amulhern) +- Update to the new raise syntax (dshea) +- Removed an unnecessary semicolon (dshea) +- Removed a redundant definition of NoDisksError (dshea) +- Specify regular expressions containing backslashes as raw strings (dshea) +- Fixed some questionable indentation (dshea) +- Fix logging function string format warnings. (dshea) +- All size specifications should be Size instances (#1077163) (vpodzime) +- Make sure StorageDevice's self._size is a Size instance (#1077179) (vpodzime) +- Allow creating Size instance from another Size instance (vpodzime) +- Force removal of hidden devices (#1078163) (amulhern) +- Get action_test into working order. (dlehman) +- Update action_test.py to specify sizes using blivet.size.Size. (dlehman) +- Don't corrupt the environment when setting up StorageTestCase. (dlehman) +- Make minSize, maxSize consistent and correct. (dlehman) +- Don't prevent grow actions on devices with no max size. (dlehman) + +* Thu Mar 20 2014 Brian C. Lane - 0.45-1 +- Changes to allow pylint checks to be run on a distribution of the source. + (amulhern) +- Remove non-doing check target (amulhern) +- Add a script to relate pylint errors to lines changed. (amulhern) +- Change output format so that it is suitable for diff-cover. (amulhern) +- Do an initial setup for running pylint tests in blivet. (amulhern) +- Handle None in devicePathToName(#996303) (dshea) +- Remove bootloader.packages from storage.packages (#1074522). (clumens) +- Whitespace fixes for the crypto devicelib module (vpodzime) +- Use random.choice for generating LUKS backup passphrase (vpodzime) +- Trivial fixes for the lvm devicelib module (vpodzime) +- Make vginfo work the same way as pvinfo and other LVM functions (vpodzime) +- Allow NTFS to be mountable. (#748780) (dshea) +- Limit the LV size to VG's free space size (vpodzime) + +* Fri Mar 07 2014 Brian C. Lane - 0.44-1 +- Fix an old typo in zeroing out a PReP partition. (#1072781) (dlehman) +- Only count with the extra metadata extents in new VGs and LVs (#1072999) + (vpodzime) +- Use container's parent's name for PV if available (#1065737) (vpodzime) +- Fix traceback with write_dasd_conf. (#1072911) (sbueno+anaconda) +- When copying a root, also copy hidden devices (#1043763) (amulhern) +- Add hidden flag to devicetree.getDeviceByID (#1043763) (amulhern) +- Only set device for mountpoint if it is not None (#1043763) (amulhern) +- Extend the list of things to be omitted if moddisk is False (#1043763) + (amulhern) +- Set req_name to None at the top of initializer (#1043763) (amulhern) +- Log action cancelation (#1043763) (amulhern) +- Make DeviceTree.hide() remove a larger set (#1043763) (amulhern) +- Re-write the DASD storage code. (#1001070) (sbueno+anaconda) +- Include image install flag when updating from anaconda flags. (#1066008) + (dlehman) + +* Fri Feb 28 2014 Brian C. Lane - 0.43-1 +- Include tmpfs mounts in post-install kickstart (#1061063) (mkolman) +- Count with the extra metadata extents for RAID consistently (#1065737) + (vpodzime) +- Make partitioning error message more friendly (#1020388) (amulhern) +- Fix partition handling across multiple processActions calls. (#1065522) + (dlehman) +- Let the udev queue settle before populating the devicetree. (#1049772) + (dlehman) +- Don't activate or deactivate devices from the action classes. (#1064898) + (dlehman) +- Improve handling of parted.DiskLabelCommitError slightly. (dlehman) +- Make teardownAll work regardless of flags. (dlehman) +- Fix maxSize test when setting device target size. (dlehman) +- Size.convertTo should return a Decimal. (dlehman) +- Don't use float for anything. (dlehman) +- Fix type of block count in PartitionDevice._wipe. (dlehman) +- Fix handling of size argument to devicelibs.lvm.thinlvcreate. (#1062223) + (dlehman) +- return empty set when no matching fcoe nic (#1067159) (bcl) +- Return str from Size.humanReadable (#1066721) (dshea) +- Add a coverage test target (#1064895) (amulhern) +- Filesystem labeling tests will not run without utilities (#1065422) + (amulhern) +- Rename misc_test.py to something more descriptive (#1065422) (amulhern) +- Refactor labeling tests (#1065422) (amulhern) +- Move SwapSpace tests into a separate class (#1065422) (amulhern) + +* Tue Feb 18 2014 Brian C. Lane - 0.42-1 +- Wait for udev to create device node for new md arrays. (#1036014) (dlehman) +- Fix detection of thin pool with non-standard segment types. (#1022810) + (dlehman) +- NFSDevice does not accept the exists kwarg. (#1063413) (dlehman) +- Don't run mpathconf for disk image installations. (#1066008) (dlehman) +- If /etc/os-release exists, check it to identify an installed system. + (clumens) +- Get the unit tests into a runnable state. (dlehman) +- Update Source URL in spec file to use github. (dlehman) + +* Tue Feb 11 2014 Brian C. Lane - 0.41-1 +- ntfs _getSize needs to use Decimal (#1063077) (bcl) +- Separate sanityCheck-ing from doAutoPartition (#1060255) (amulhern) +- Change messages to SanityExceptions objects (#1060255) (amulhern) +- Make a small SanityException hierarchy (#1060255) (amulhern) +- Remove unused exception class (#1060255) (amulhern) +- Add another .decode("utf-8") to humanReadable (#1059807) (dshea) +- makebumpver: Any failure should cancel the bump (bcl) + +* Tue Feb 04 2014 Brian C. Lane - 0.40-1 +- makebumpver: Only remove from list if action is not Resolves (bcl) +- Update bumpver to allow Related bugs (bcl) +- Remove all dependent devices of san device becoming multipath (#1058939) + (rvykydal) +- When repopulating multipath members mark them as multipath (#1056024) + (rvykydal) +- fcoe: parse yet another sysfs structure for bnx2fc devices (#903122) + (rvykydal) +- fcoe: add fcoe=: to boot options for nics added manually (#1040215) + (rvykydal) +- Convert the ntfs minsize to an int (#1060031) (dshea) +- Convert the string representation of Size to a str type. (#1060382) (dshea) +- don't display stage2 missing error as well if the real problem is stage1 + (awilliam) +- Provide a mechanism for platform-specific error messages for stage1 failure + (awilliam) +- Don't add None value to req_disks (#981316) (amulhern) +- Make error message more informative (#1022497) (amulhern) +- Check that file that loop device is going to use exists (#982164) (amulhern) +- Use os.path.isabs to check whether path name is absolute (#994488) (amulhern) + +* Tue Jan 28 2014 Brian C. Lane - 0.39-1 +- escrow: make sure the output directory exists (#1026653) (wwoods) +- provide a more useful error message if user fails to create an ESP (awilliam) +- Tell lvcreate not to ask us any questions and do its job. (#1057066) + (dlehman) + +* Fri Jan 24 2014 Brian C. Lane - 0.38-1 +- Some simple tests for _verifyLUKSDevicesHaveKey (#1023442) (amulhern) +- Verify that LUKS devices have some encryption key (#1023442) (amulhern) + +* Wed Jan 22 2014 Brian C. Lane - 0.37-1 +- Only do SELinux context resets if in installer mode (#1038146) (amulhern) +- Look up SELinux context for lost+found where it is needed (#1038146) + (amulhern) +- Don't reset the SELinux context before the filesystem is mounted (#1038146) + (amulhern) +- Test setting selinux context on lost+found (#1038146) (amulhern) +- Only retrieve the unit specifier once (dshea) +- Fix the Device.id usage. (dshea) +- Accept both English and localized sizes in Size specs. (dshea) +- Use a namedtuple to store information on unit prefixes (dshea) +- Remove en_spec Size parameters. (dshea) +- Fix potential traceback in devicetree.populate. (#1055523) (dlehman) +- Fall back on relabeling app where available (#1038590) (amulhern) +- Change the meaning of label field values (#1038590) (amulhern) +- Enable labeling on NTFS filesystem (#1038590) (amulhern) +- Enable labeling on HFS filesystem (#1038590) (amulhern) +- Add a method that indicates ability to relabel (#1038590) (amulhern) +- Use filesystem creation app to set filesystem label (#1038590) (amulhern) +- Import errors so FSError name is resolved (#1038590) (amulhern) +- Remove BTRFS._getFormatOptions (#1038590) (amulhern) +- Make an additional class for labeling abstractions (#1038590) (amulhern) +- Fix copyright date (#1038590) (amulhern) +- Remove redundant _defaultFormatOptions field (#1038590) (amulhern) +- Remove code about unsetting a label (#1038590) (amulhern) +- Return None if the filesystem has no label (#1038590) (amulhern) +- Removed redundant check for existance of filesystem (#1038590) (amulhern) +- Have writeLabel throw a more informative exception (#1038590) (amulhern) + +* Fri Jan 17 2014 Brian C. Lane - 0.36-1 +- Update the TODO list. (dlehman) +- Multipath, fwraid members need not be in exclusiveDisks. (#1032919) (dlehman) +- Convert parted getLength values to Size (dshea) +- Last of the Device._id -> Device.id (bcl) +- iscsi: in installer automatically log into firmware iscsi targets (#1034291) + (rvykydal) +- Use isinstance for testing numeric types (vpodzime) +- Device._id -> Device.id (clumens) +- Allow resetting partition size to current on-disk size. (#1040352) (dlehman) + +* Fri Jan 10 2014 Brian C. Lane - 0.35-1 +- Convert everything to use Size. (dlehman) +- Allow negative sizes. (dlehman) +- Fix return value of Size.convertTo with a spec of bytes. (dlehman) +- Discard partial bytes in Size constructor. (dlehman) +- Prefer binary prefixes since everything is really based on them. (dlehman) +- Fix a few minor problems introduced by recent raid level changes. (dlehman) +- Move label setter and getter into DeviceFormat class (#1038590) (amulhern) +- Add a test for labeling swap devices (#1038590) (amulhern) +- Default to None to mean none, rather than empty string (#1038590) (amulhern) +- Add a labelFormatOK method to the DeviceFormat's interface (#1038590) + (amulhern) +- Indicate whether the filesystem can label (#1038590) (amulhern) +- Restore ability to write an empty label where possible (#1038590) (amulhern) +- More tests to check writing and reading labels (#1038590) (amulhern) +- Remove fsConfigFromFile (#1038590) (amulhern) +- Changes to the handling of filesystem labeling (#1038590) (amulhern) +- Add some simple tests for file formats. (amulhern) +- Give DeviceFormat objects an id (#1043763) (amulhern) +- Refactor to use ObjectID class (#1043763) (amulhern) +- Make a class that creates a unique-per-class id for objects (#1043763) + (amulhern) +- Revert "Make a class that creates a unique-per-class id for objects + (#1043763)" (amulhern) +- Revert "Give DeviceFormat objects an object_id (#1043763)" (amulhern) +- Make the maximum end sector for PReP boot more benevolent (#1029893) + (vpodzime) +- Give DeviceFormat objects an object_id (#1043763) (amulhern) +- Make a class that creates a unique-per-class id for objects (#1043763) + (amulhern) +- Make get_device_format_class return None if class not found (#1043763) + (amulhern) +- A few simple unit tests for some formats methods (#1043763) (amulhern) +- Don't translate format names (dshea) + +* Thu Dec 19 2013 Brian C. Lane - 0.34-1 +- Forget existing partitions of device becoming a multipath member (#1043444) + (rvykydal) +- Include blivet.devicelibs.raid in the generated documentation. (amulhern) +- Upgrade the comments in raid.py to be compatible with sphinx. (amulhern) +- Make space for LUKS metadata if creating encrypted device (#1038847) + (vpodzime) +- fcoe: give error message in case of fail when adding device (#903122) + (rvykydal) +- fcoe: adapt bnx2fc detection to changed sysfs path structure (#903122) + (rvykydal) +- Update format of iscsi device becoming multipath member (#1039086) (rvykydal) + +* Tue Dec 17 2013 Brian C. Lane - 0.33-1 +- Add initial 64-bit ARM (aarch64) support (#1034435) (dmarlin) +- Convert to sphinx docstrings. (dlehman) +- Add some documentation. (dlehman) +- Move getActiveMounts from Blivet into DeviceTree. (dlehman) +- Add an example of creating lvs using growable requests. (dlehman) +- Remove a whole bunch of unused stuff from Blivet. (dlehman) +- Remove usage of float in Size.humanReadable. (dlehman) +- Add missing abbreviations for binary size units. (dlehman) +- Fix shouldClear for devices with protected descendants. (#902417) (dlehman) +- Use // division so that it continues to be floor division in Python 3. + (amulhern) + +* Thu Dec 12 2013 Brian C. Lane - 0.32-1 +- Work on devicelibs.btrfs methods that require that the device be mounted. + (amulhern) +- Remove some methods from devicelibs.btrfs. (amulhern) +- Add a comment to btrfs.create_volume. (amulhern) +- Add a file to run btrfs tests. (amulhern) +- Remove format.luks.LUKS.removeKeyFromFile. (amulhern) +- Changes to devicelibs.mdraid.mdactivate. (amulhern) +- Restore an import removed in a previous commit. (amulhern) +- Add a PE for LUKS metadata (#1038969) (bcl) +- Adjust currentSize methods slightly. (amulhern) +- Put additional constraints on the ActionResizeDevice initializer. (amulhern) +- Remove redundant checks in existing resize() methods. (amulhern) +- Add some baseline unit tests for BTRFS devices. (amulhern) +- Robustify use of defaultSubVolumeID field. (amulhern) +- Check that a BTRFS subvolume has exactly one parent in constructor. + (amulhern) +- BTRFSSubVolume.volume checks the class of its return value. (amulhern) +- Raise ValueError in BTRFS constructor if no parents specified. (amulhern) +- Add tests for a couple of additional properties for MDRaidArrayDevice. + (amulhern) +- Factor state testing behavior into a separate class. (amulhern) +- Remove redundant condition in if statement. (amulhern) + +* Thu Dec 05 2013 Brian C. Lane - 0.31-1 +- Make RAIDLevel an abstract class using abc. (amulhern) +- Restore a util import that was removed in a recent commit. (amulhern) + +* Wed Dec 04 2013 Brian C. Lane - 0.30-1 +- Always run action's cancel method as part of cancelAction. (dlehman) +- Show Invalid Disk Label for damaged GPT (#1020974) (bcl) +- Make error message in setDefaultFSType more informative (#1019766) (amulhern) +- Set sysfsPath of LUKSDevice when adding to device tree (#1019638) (jsafrane) +- Use given format type as format's name instead of type (vpodzime) + +* Wed Nov 27 2013 Brian C. Lane - 0.29-1 +- btrfs and xfs do not support fsck or dump at boot time (#862871) (bcl) +- Removed raid level constants from mdraid.py. (amulhern) +- Remove raidLevel and get_raid_min_members for mdraid.py. (amulhern) +- Remove raidLevelString in raid and mdraid. (amulhern) +- In devicefactory.py change mdraid procedures call to raid method calls. + (amulhern) +- Removed mdraid.raid_levels (amulhern) +- Removed mdraid.get_raid_max_spares. (amulhern) +- Change MDRaidArrayDevice to use raid package. (amulhern) +- Changed devicelibs.mdraid to make use of devicelibs.raid. (amulhern) +- Implement a RAID class hierarchy. (amulhern) +- A few small tests for MDFactory class. (amulhern) +- Add some additional unit tests in mdraid_tests.py. (amulhern) +- Make MDRaidArrayDevice initializer not except raid level of None. (amulhern) +- Add some basic unit tests for MDRaidArrayDevice. (amulhern) +- Move pyanaconda import into blivet.enable_installer_mode. (amulhern) + +* Mon Nov 25 2013 David Lehman - 0.28-1 +- Clear whole-disk formatting before initializing disks. (#1032380) (dlehman) +- Simplify calculation of vol size when adding a btrfs subvol. (#1033356) + (dlehman) +- Handle passing a btrfs volume as device to BTRFSFactory. (dlehman) +- Add support for detecting btrfs default subvolume. (dlehman) +- Handle nested btrfs subvolumes correctly. (#1016959) (dlehman) +- Mark all format names as translatable (dshea) +- Add parameters for untranslated Size specs. (dshea) +- Fix usage of _ vs N_ (dshea) +- Added a i18n module for gettext functions. (dshea) +- Allow non-ASCII characters in the size spec (dshea) + +* Tue Nov 19 2013 David Lehman - 0.27-1 +- Specify btrfs volumes by UUID in /etc/fstab. (dlehman) +- Catch any exception raised by findExistingInstallations. (#980267) (dlehman) +- Prevent md_node_from_name from raising OSError. (#980267) (dlehman) +- Tidy up tests in devicelibs_test directory. (amulhern) +- Preparation for lv resize is a subset of that for lv destroy. (#1027682) + (dlehman) +- Make sure new values of targetSize are within bounds. (dlehman) +- Devices with non-existent formatting are resizable. (#1027714) (dlehman) +- Do not hide non-existent devices. (#1027846) (dlehman) +- Change XFS maximum to 16EB (#1016035) (bcl) +- Add tmpfs support (#918621) (mkolman) +- Add support for returning machine word length (mkolman) +- Require cryptsetup instead of cryptsetup-luks (#969597) (amulhern) +- Fix initialization of disks containing sun or mac disklabels. (dlehman) +- Newly formatted devices are used unless mountpoint is empty. (#966078) + (dlehman) +- Fix detection of lvm setups. (#1026466) (dlehman) +- Fix handling of overcommitted thin pools in thinp factory. (#1024144) + (dlehman) +- Fix name checking for new thin lvs. (#1024076) (dlehman) + +* Wed Oct 30 2013 Brian C. Lane - 0.26-1 +- Add macefi format type (#1010495) (bcl) +- Allow hfs+ boot devices to have their name set (#1010495) (bcl) +- Update parted partitions on hidden disks when copying a Blivet. (#1023556) + (dlehman) +- Add ack flag checking to makebumpver (bcl) +- Add makebumpver script (bcl) + +* Fri Oct 25 2013 Brian C. Lane - 0.25-1 +- Remove requirement for btrfsctl which no longer exists. (#1012504) (dlehman) +- Allow for adjustment of factory vg after removal of thin pool. (#1021890) (dlehman) +- Add boot description for "disk" devices on s390. (#867777, #903237, #960143) (sbueno+anaconda) +- Add initial spport for aarch64 as we only plan to support UEFI this should be enough (dennis) + +* Wed Oct 16 2013 David Lehman - 0.24-1 +- Close file descriptors other than stdin,stdout,stderr on exec. (#1016467) (dlehman) +- Don't use hardcoded /tmp paths. (#1004404) (dlehman) +- Fix detection of lvm thinp setups. (#1013800) (dlehman) +- Generate a name if necessary when reconfiguring a factory device. (#1019500) (dlehman) +- Handle anaconda's cmdline option to disable mpath friendly names. (#977815) (dlehman) +- Allow specifying which swaps should appear in fstab (vpodzime) +- Do not limit swap size to 10 % of disk space for hibernation (vpodzime) + +* Wed Oct 09 2013 Brian C. Lane - 0.23-1 +- Make sure bootloader is setup after autopart (#1015277) (bcl) +- Let setUpBootLoader raise BootloaderError (#1015277) (bcl) +- Limit the maximum swap size to 10 % of disk space (if given) (vpodzime) +- support ppc64le architecture (hamzy) +- Don't call handleUdevDeviceFormat without udev device (#1009809) (dshea) + +* Fri Sep 06 2013 David Lehman - 0.22-1 +- Allow implicit inclusion of multipath/fwraid by including all members. (dlehman) +- If a device has been removed, omit it from the copied root. (#1004572) (dlehman) +- Thinp metadata and chunk size default to 0 -- not None. (#1004718) (dlehman) +- Revert "Do not try to align partitions to optimal_io_size. (#989333)" (dlehman) + +* Thu Sep 05 2013 Brian C. Lane - 0.21-1 +- Only force luks map names to include UUID during OS installation. (#996457) (dlehman) +- Allow DiskLabelCommitError to reach the caller. (#1001586) (dlehman) +- Do not try to align partitions to optimal_io_size. (#989333) (gustavold) +- Fix rpmlog make target (bcl) +- Add missing changelog lines to spec (bcl) + +* Fri Aug 23 2013 Brian C. Lane - 0.20-1 +- Fix typo in examples/list_devices.py (dlehman) +- Use iscsi-iname instead of trying to reimplemnt it in python. (dlehman) +- Catch exceptions raised while finding old installations. (#981991) (dlehman) +- Keep the dasd list in sync with the devicetree's device list. (#965694) (dlehman) +- Don't save luks keys unless installer_mode flag is set. (#996118) (dlehman) +- Pass mount options to resolveDevice in _parseOneLine (#950206) (vpodzime) +- Fix handling of devices in detected installations in Blivet.copy. (dlehman) +- Clean up detection of lvm raid. (dlehman) +- Tag the first build of each version without the release. (dlehman) +- Remove dangling code block from commit 737169b75af1. (dlehman) + +* Wed Jul 31 2013 Brian C. Lane - 0.19-1 +- Don't waste time looking for devices dependent on leaf devices. (dlehman) +- Add some example code for creation of disk partitions. (dlehman) +- Don't manipulate partition boot flags except in installer mode. (dlehman) +- Add an example of DeviceFactory usage. (dlehman) +- Cosmetic changes for the arch module (vpodzime) +- No more sparc support (vpodzime) +- Cleanup arch.py reredux (hamzy) +- Allow explicit requests for extended partitions. (#891861) (dlehman) +- Fix disklabel handling for multiple calls to processActions. (dlehman) +- Add support for explicit start/end sectors in partition requests. (#881025) (dlehman) +- Store current mount options in getActiveMounts. (#914898) (dlehman) +- Lack of formatting does not preclude device resize. (dlehman) +- Handle negative sizes correctly. (dlehman) +- Fix handling of clearpart type linux in shouldClear. (dlehman) +- Add some tests for clearpart and related functionality. (dlehman) +- Update unit tests and add a make target to run them. (dlehman) +- Don't pass dracut args for lvm thin pools. (dlehman) +- Update the TODO list. (dlehman) +- Fix a copy/paste error. (dlehman) +- Remove transifex-client BuildRequires. (dlehman) + +* Tue Jul 09 2013 Brian C. Lane - 0.18-1 +- Raise XFS max size limit to 100TB. (sbueno+anaconda) +- Add a device factory class for thinly-provisioned lvm. (dlehman) +- Add support for automatic partitioning using lvm thin provisioning. (dlehman) +- Add convenience methods related to lvm thin provisioning. (dlehman) +- Add support for detection of lvm thinp setups. (dlehman) +- Add classes for lvm thin pool and thin volume. (dlehman) +- Add backend support for lvm thinp operations. (dlehman) +- Fix return value of get_pv_space for size of 0. (dlehman) +- Fix ksdata for lvm created in custom spoke based on autopart. (dlehman) +- Only put max size in ksdata if partition is growable. (dlehman) +- Allow subclasses to inherit ksdata classes. (dlehman) + +* Mon Jun 24 2013 Brian C. Lane - 0.17-1 +- Used Python type instead of variable name (#968122) (hamzy) +- Fix detection of valid EFI system partition during autopart. (dlehman) +- New version: 0.16 (bcl) + +* Thu Jun 13 2013 Brian C. Lane - 0.16-1 +- Install utilities for all devices -- not just those being used. (#964586) (dlehman) +- Add a method to apply Blivet settings to ksdata. (dlehman) +- Increase padding for md metadata in lvm factory. (#966795) (dlehman) +- Move lvm-on-md into LVMFactory. (dlehman) +- Switch to a minimum of four members for raid10. (#888879) (dlehman) +- Update the TODO list. (dlehman) +- Deactivate devices before hiding those on ignored disks. (#965213) (dlehman) +- Allow udev queue to settle after writing zeros to disk. (#969182) (hamzy) +- Run lsof when umount fails (bcl) +- Run udev settle before umount (bcl) + +* Mon Jun 03 2013 Brian C. Lane - 0.15-1 +- Switch to the LGPLv2+. (dlehman) +- Clear md arrays' sysfs path after deactivating them. (#954062) (dlehman) +- Factories with existing containers use the container's disk set. (dlehman) +- Don't set up a child factory if the container is set and exists. (dlehman) +- Set a non-zero size for new btrfs subvols in an existing volume. (dlehman) +- Open as many luks devs as possible with any given passphrase. (#965754) (dlehman) +- Make sure container changes worked before applying device changes. (#965805) (dlehman) +- Re-initialize platform in storageInitialize (#962104) (bcl) +- Make a copy of devicetree._devices before using the append operator. (clumens) +- Handle incomplete devices becoming complete on device rescan. (clumens) +- Don't allow a device to be on the hidden list more than once. (clumens) + +* Wed May 15 2013 David Lehman - 0.14-1 +- total_memory calculation needs to round up (#962231) (bcl) +- The dev.node attribute for iscsi devices is not copyable (#962865). (clumens) +- Wipe partitions before they are created (#950145) (bcl) +- Pass ROOT_PATH as an argument instead of importing it. (clumens) +- If no iscsi nodes are discovered, return an empty list instead of None. (clumens) + +* Thu May 09 2013 Brian C. Lane - 0.13-1 +- Make sure createBitmap is updated when level changes (#960271) (bcl) +- Update biosboot error message (#960691) (bcl) + +* Fri May 03 2013 David Lehman - 0.12-1 +- Fix a bug in renaming lvm lvs. (dlehman) +- Add container size policies for unlimited growth and fixed size. (dlehman) +- Remove device factory methods to change container name. (dlehman) +- Override any default subvol when mounting main btrfs volume. (#921757) (dlehman) +- Fix detection of multipath. (#955664) (dlehman) +- When a btrfs subvol's name is changed, change its subvol argument too. (clumens) +- Allow returning hidden disks from the getDeviceBy* methods, if asked. (clumens) +- Fix fipvlan -f argument once more and for good (#836321) (rvykydal) +- Remove the intf parameters from the iscsi class. (clumens) +- Don't relly on /proc/mdstat when enumeraing RAID levels. (jsafrane) +- Set product names in non-installer mode. (jsafrane) +- Fixed checking status of MD RAID which was just deleted. (jsafrane) +- Account for the fact that md's metadata usage is unpredictable. (dlehman) +- Remove members from their containers before destroying them. (dlehman) +- Make get_container work even if there are duplicate names. (dlehman) +- LVMFactory with a container_raid_level means use LVMOnMDFactory. (dlehman) +- Add a check for enough raid members after allocating partitions. (dlehman) +- Make parent_factory an attribute of the DeviceFactory instance. (dlehman) +- All container settings use container_ kwargs. (dlehman) +- Add ability to find raid level of an lvm vg. (dlehman) +- Always pass -f to wipefs since it lies about in-use devices. (#953329) (dlehman) +- Fix a bug extended partition management. (#951765) (dlehman) +- Don't return incomplete devices from getDeviceByFoo methods by default. (dlehman) +- Don't traceback when degraded md raid arrays are present. (#953184) (dlehman) + +* Mon Apr 15 2013 David Lehman - 0.11-1 +- Fix handling of isohybrid media. (#950510) (dlehman) +- Fix getting dracut setup args from dasd.conf. (#950964) (dlehman) + +* Tue Apr 09 2013 David Lehman - 0.10-1 +- Extended partitions containing logical partitions are not leaves. (#949912) (dlehman) +- Remove devices in reverse order in Blivet.recursiveRemove. (#949912) (dlehman) +- Rewrite the DeviceFactory classes. (dlehman) +- Hook up error handling in installer-specific methods. (#948250) (dlehman) +- Don't traceback if fcoe.startup is called without fcoe utils present. (dlehman) +- Fix logic error that causes us to ignore disks in exclusiveDisks. (dlehman) +- Slightly improve currentSize for btrfs volumes. (dlehman) +- Simplify multipath handling. (dlehman) +- Don't expect anaconda udev rules to be in use. (dlehman) +- Drop requires for things only needed for OS installation. (dlehman) +- New version: 0.9 (bcl) +- Only install packages for devices and filesystems used by the OS. (dlehman) +- Fix LVMLogicalVolumeDevice.maxSize. (dlehman) +- Fix handling of name=None in newLV, newMDArray, newVG. (dlehman) +- Allow calls to suggestDeviceName with only a prefix argument. (dlehman) +- Move mdadm superblock size calculation into devicelibs.mdraid. (dlehman) + +* Thu Mar 28 2013 Brian C. Lane - 0.9-1 +- NTFS.minSize is supposed to be a property. (#924410) (dlehman) +- Mount /run during install and fix /sys mount (#922988) (bcl) +- Fix two excptions triggered by calls to copy_to_system. (hamzy) + +* Wed Mar 13 2013 David Lehman - 0.8-1 +- Check for "ip=ibft" cmdline option, not for "ibft". (rvykydal) +- run_program returns an int. (#920584) (dlehman) +- Fix units for lvs output. (dlehman) +- Don't pass an intf arg to ISCSI.stabilize. (#920041) (dlehman) +- Add __version__ to blivet/__init__.py. (dlehman) +- Only run info prog (eg: dumpe2fs) once per filesystem. (dlehman) +- Processing of a PV with no VG metadata is easy. (dlehman) +- Add some convenience properties for displaying DeviceAction info. (dlehman) +- Ignore MTDs, as we do not have the tools to write to them (#916771). (clumens) +- Include udev's list of symbolic links in StorageDevice. (#914724) (dlehman) +- Set a DeviceFormat instance's type attribute to the requested type. (dlehman) +- Allow size specs that do not include a 'b' or 'B'. (#888851) (dlehman) +- Fix reference to 'factory' from within DeviceFactory class. (dlehman) +- Fix problems detecting lvm and md devices. (#914730) (dlehman) +- Allow passing size=None to device factories for unbounded growth. (dlehman) +- Provide a way to set the default fstype for a Blivet instance. (#838145) (dlehman) +- Allow changing the size of encrypted devices via DeviceFactory. (#913169) (dlehman) +- Don't dump storage state except in installer mode. (dlehman) +- Fix device resolution for btrfs. (dlehman) +- Fix device resolution to find named md devices. (dlehman) +- Account for active mounts in normal mode. (#914898) (dlehman) +- Add an example script which lists all devices. (dlehman) +- Add scripts/makeupdates script (bcl) + +* Thu Feb 21 2013 Brian C. Lane - 0.7-1 +- Merge branch 'master' of git+ssh://git.fedorahosted.org/git/blivet (bcl) +- Bring in productName from pyanaconda in installer mode. (#913559) (dlehman) + +* Wed Feb 20 2013 Brian C. Lane - 0.6-1 +- parse buffer output from resize (#913141) (bcl) +- prevent traceback when root device is not defined #rhbz883768 (sbueno+anaconda) +- Move empty_disk to a top-level function, and rename. (clumens) +- Add some high-level comments to DeviceFactory.configure_device. (dlehman) +- Refactor DeviceFactory.set_container_members for clarity. (dlehman) +- Rename the main blivet logger from "storage" to "blivet". (dlehman) +- Use the blivet domain for translations. (dlehman) +- Move DeviceFactory classes and related code into a new file. (dlehman) +- New version: 0.5 (dlehman) + +* Fri Feb 08 2013 David Lehman - 0.5-1 +- Add mountOnly to turnOnFilesystems (bcl) +- Update lvm scanning to account for new ignored device handling. (dlehman) +- Scan in all devices and then hide those that use ignored disks. (dlehman) +- Adjust child counts correctly when unhiding a device. (dlehman) +- Generate lvm config args each time they're needed/used. (dlehman) +- Add ability to grab 70-anaconda.rules udev data directly. (dlehman) +- Add support for active luks mappings at populate time. (dlehman) +- Don't require nss, required only for escrow key support. (dlehman) +- Update the TODO list. (dlehman) +- Add missing constant DMI_CHASSIS_VENDOR. (dlehman) +- Allow for multiple calls to DeviceTree.processActions. (#881023,#846573) (dlehman) +- Use CGit snaphot URL for Source in specfile. (dlehman) +- Streamline some logic in storageInitialize. (dlehman) +- Don't re-add deleted or hidden devices during DeviceTree.populate. (dlehman) +- Only run findExistingInstallations and start iscsi, &c in installer mode. (dlehman) +- Do not change device status during populate in normal mode. (#817064) (dlehman) +- Drop old code related to saving clearPartType from pre-f18. (dlehman) +- check for skipping bootloader in doIt (bcl) +- check for stage1 when not installing bootloader (#882065,#895232) (bcl) +- explicitly detect iso9660 on a disk (#903158) (bcl) +- Fix several problems in python-blivet.spec. (dlehman) +- Remove #!/usr/bin/python from tsort.py (dlehman) +- Update COPYING file. (dlehman) +- Add a Requires for dmidecode on x86. (dlehman) + +* Sun Jan 20 2013 David Lehman - 0.4-1 +- Use a two-part version number instead of three. (dlehman) +- Rename the rpm package from blivet to python-blivet. (dlehman) +- Move get_mount_device, get_mount_paths from pyanaconda.packaging to util. (dlehman) +- Update the TODO list. (dlehman) +- Carry over s390 exclusion of fcoe-utils from anaconda. (dlehman) +- Enable translations via transifex. (dlehman) + +* Fri Jan 18 2013 David Lehman - 0.2-1 +- Add Requires: iscsi-initiator-utils, fcoe-utils, device-mapper-multipath. (dlehman) +- Use a threading lock to control program log output. (dlehman) +- Fix reference to data to refer to ksdata in Blivet constructor. (dlehman) +- Remove the loop around proc.communicate in util._run_program. (dlehman) + +* Tue Jan 15 2013 David Lehman 0.2-1 +- Updated source from final pre-split anaconda source. +- Renamed pyanaconda.storage to blivet throughout. +- Updated spec file to include runtime Requires. + +* Fri Jan 04 2013 David Lehman 0.1-1 +- Created package from anaconda storage module.