diff --git a/.gitignore b/.gitignore
index 01bfdc6..47aba01 100644
--- a/.gitignore
+++ b/.gitignore
@@ -27,3 +27,4 @@ clog
 /PHP_CodeSniffer-3.3.0.tgz
 /PHP_CodeSniffer-3.3.1.tgz
 /PHP_CodeSniffer-3.3.2.tgz
+/PHP_CodeSniffer-3.4.0.tgz
diff --git a/php-pear-PHP-CodeSniffer.spec b/php-pear-PHP-CodeSniffer.spec
index ea1afed..28c85f4 100644
--- a/php-pear-PHP-CodeSniffer.spec
+++ b/php-pear-PHP-CodeSniffer.spec
@@ -13,7 +13,7 @@
 %global pear_name     PHP_CodeSniffer
 
 Name:           php-pear-PHP-CodeSniffer
-Version:        3.3.2
+Version:        3.4.0
 Release:        1%{?dist}
 Summary:        PHP coding standards enforcement tool
 
@@ -25,11 +25,7 @@ BuildArch:      noarch
 BuildRequires:  php(language) >= 5.4
 BuildRequires:  php-pear
 # to run test suite
-%if 0%{?fedora} >= 28 || 0%{?rhel} >= 8
 %global phpunit %{_bindir}/phpunit7
-%else
-%global phpunit %{_bindir}/phpunit6
-%endif
 BuildRequires:  %{phpunit}
 
 Requires(post): %{__pear}
@@ -90,7 +86,7 @@ install -pm 644 %{pear_name}.xml %{buildroot}%{pear_xmldir}
 %check
 cd %{pear_name}-%{version}
 
-# Version 3.3.2: Tests: 354, Assertions: 410, Skipped: 3.
+# Version 3.4.0: Tests: 364, Assertions: 419, Skipped: 3.
 ret=0
 for cmdarg in "php %{phpunit}" "php70 %{_bindir}/phpunit6" php71 php72 php73; do
   if which $cmdarg; then
@@ -123,6 +119,9 @@ fi
 
 
 %changelog
+* Thu Dec 20 2018 Remi Collet <remi@remirepo.net> - 3.4.0-1
+- update to 3.4.0
+
 * Mon Sep 24 2018 Remi Collet <remi@remirepo.net> - 3.3.2-1
 - update to 3.3.2
 
diff --git a/sources b/sources
index 8d11b70..d97163e 100644
--- a/sources
+++ b/sources
@@ -1 +1 @@
-SHA512 (PHP_CodeSniffer-3.3.2.tgz) = 461253553678fff4521a41883e94cc29558eaa8cd1b36787c115edfe76618da1d8dbfcb4ea421554472c5a6cfa2d22576d1e9f28359b86639c1ed2c4bf3e6d1f
+SHA512 (PHP_CodeSniffer-3.4.0.tgz) = ea5a59de28927895275a4f7959a1dcae7fbaef17a2531046f7e267a63b51a801fc5a926e1fe7ac823f8fcf28f08d0747916b45bebce8424c6320e58388da6b41