From f261884288840a56b20a47d9de6563b94aa0ad9a Mon Sep 17 00:00:00 2001 From: Paul Howarth Date: Sun, 13 Oct 2019 17:59:11 +0100 Subject: [PATCH] Spec tidy-up - Use author-independent source URL - Classify buildreqs by usage - Simplify find command using -delete - Don't need to remove empty directories from the buildroot - Fix permissions verbosely - Package LICENSE file - Make %files list more explicit --- perl-UNIVERSAL-can.rpmlintrc | 2 ++ perl-UNIVERSAL-can.spec | 51 +++++++++++++++++++++++++----------- 2 files changed, 38 insertions(+), 15 deletions(-) create mode 100644 perl-UNIVERSAL-can.rpmlintrc diff --git a/perl-UNIVERSAL-can.rpmlintrc b/perl-UNIVERSAL-can.rpmlintrc new file mode 100644 index 0000000..33bf320 --- /dev/null +++ b/perl-UNIVERSAL-can.rpmlintrc @@ -0,0 +1,2 @@ +from Config import * +addFilter("spelling-error %description -l en_US (invocants|subclasses) -> ") diff --git a/perl-UNIVERSAL-can.spec b/perl-UNIVERSAL-can.spec index 5dc2346..6d07bbf 100644 --- a/perl-UNIVERSAL-can.spec +++ b/perl-UNIVERSAL-can.spec @@ -1,19 +1,30 @@ Name: perl-UNIVERSAL-can Version: 1.20140328 -Release: 14%{?dist} +Release: 15%{?dist} Summary: Hack around people calling UNIVERSAL::can() as a function License: GPL+ or Artistic URL: https://metacpan.org/release/UNIVERSAL-can -Source0: https://cpan.metacpan.org/authors/id/C/CH/CHROMATIC/UNIVERSAL-can-%{version}.tar.gz +Source0: https://cpan.metacpan.org/modules/by-module/UNIVERSAL/UNIVERSAL-can-%{version}.tar.gz BuildArch: noarch -BuildRequires: perl-generators -BuildRequires: perl(ExtUtils::MakeMaker) -BuildRequires: perl(Test::Simple) >= 0.60 -BuildRequires: perl(Test::Pod) >= 1.14 -BuildRequires: perl(Test::Pod::Coverage) >= 1.04 -Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version)) - -%{?perl_default_filter} +# Build: +BuildRequires: coreutils +BuildRequires: findutils +BuildRequires: make +BuildRequires: perl-generators +BuildRequires: perl-interpreter +BuildRequires: perl(ExtUtils::MakeMaker) >= 6.30 +# Module: +BuildRequires: perl(Scalar::Util) +BuildRequires: perl(strict) +BuildRequires: perl(vars) +BuildRequires: perl(warnings) +BuildRequires: perl(warnings::register) +# Test Suite: +BuildRequires: perl(lib) +BuildRequires: perl(overload) +BuildRequires: perl(Test::More) +# Dependencies: +Requires: perl(:MODULE_COMPAT_%(eval "`perl -V:version`"; echo $version)) %description The UNIVERSAL class provides a few default methods so that all objects @@ -34,19 +45,29 @@ make %{?_smp_mflags} %install make pure_install DESTDIR=%{buildroot} -find %{buildroot} -type f -name .packlist -exec rm -f {} ';' -find %{buildroot} -depth -type d -exec rmdir {} ';' 2>/dev/null -%{_fixperms} %{buildroot} +find %{buildroot} -type f -name .packlist -delete +%{_fixperms} -c %{buildroot} %check -PERL_RUN_ALL_TESTS=1 make test +make test %files +%license LICENSE %doc Changes README %{perl_vendorlib}/UNIVERSAL/ -%{_mandir}/man3/*.3* +%{_mandir}/man3/UNIVERSAL::can.3* %changelog +* Sun Oct 13 2019 Paul Howarth - 1.20140328-15 +- Spec tidy-up + - Use author-independent source URL + - Classify buildreqs by usage + - Simplify find command using -delete + - Don't need to remove empty directories from the buildroot + - Fix permissions verbosely + - Package LICENSE file + - Make %%files list more explicit + * Fri Jul 26 2019 Fedora Release Engineering - 1.20140328-14 - Rebuilt for https://fedoraproject.org/wiki/Fedora_31_Mass_Rebuild