Spec tidy-up

- Use author-independent source URL
- Specify all build dependencies
- Use DESTDIR rather than PERL_INSTALL_ROOT
- Simplify find command using -delete
- Don't need to remove empty directories from the buildroot
- Fix permissions verbosely
- Don't display developer dependencies as we're not running extra tests

perl-Test-Number-Delta.spec

@@ -1,18 +1,33 @@
 Name:           perl-Test-Number-Delta
 Version:        1.06
-Release:        14%{?dist}
+Release:        15%{?dist}
 Summary:        Compare the difference between numbers against a given tolerance
 License:        GPL+ or Artistic
 URL:            https://metacpan.org/release/Test-Number-Delta
-Source0:        https://cpan.metacpan.org/authors/id/D/DA/DAGOLDEN/Test-Number-Delta-%{version}.tar.gz
+Source0:        https://cpan.metacpan.org/modules/by-module/Test/Test-Number-Delta-%{version}.tar.gz
 BuildArch:      noarch
+# Build
+BuildRequires:  coreutils
+BuildRequires:  findutils
+BuildRequires:  make
 BuildRequires:  perl-generators
-BuildRequires:  perl(ExtUtils::MakeMaker)
-BuildRequires:  perl(Test::Builder) >= 0.32
+BuildRequires:  perl-interpreter
+BuildRequires:  perl(ExtUtils::MakeMaker) >= 6.17
+# Module
+BuildRequires:  perl(Carp)
+BuildRequires:  perl(Exporter)
+BuildRequires:  perl(strict)
+BuildRequires:  perl(Test::Builder)
+BuildRequires:  perl(vars)
+BuildRequires:  perl(warnings)
+# Test Suite
+BuildRequires:  perl(File::Spec)
 BuildRequires:  perl(Test::Builder::Tester) >= 1.02
-BuildRequires:  perl(Test::Pod)
-BuildRequires:  perl(Test::Pod::Coverage)
-Requires:       perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version))
+BuildRequires:  perl(Test::More)
+# Optional Tests
+BuildRequires:  perl(CPAN::Meta) >= 2.120900
+# Dependencies
+Requires:       perl(:MODULE_COMPAT_%(eval "`perl -V:version`"; echo $version))
 
 %description
 At some point or another, most programmers find they need to compare
@@ -27,29 +42,38 @@ a function for use with Test::Harness.
 
 
 %build
-%{__perl} Makefile.PL INSTALLDIRS=vendor
+perl Makefile.PL INSTALLDIRS=vendor
 make
 
 
 %install
-make pure_install PERL_INSTALL_ROOT=$RPM_BUILD_ROOT
-find $RPM_BUILD_ROOT -type f -name .packlist -exec rm -f {} ';'
-find $RPM_BUILD_ROOT -type d -depth -exec rmdir {} 2>/dev/null ';'
-chmod -R u+w $RPM_BUILD_ROOT/*
+make pure_install DESTDIR=%{buildroot}
+find %{buildroot} -type f -name .packlist -delete
+%{_fixperms} -c %{buildroot}
 
 
 %check
-AUTHOR_TESTING=1 make test
+make test
 
 
 %files
 %doc Changes
 %license LICENSE
 %{perl_vendorlib}/Test/
-%{_mandir}/man3/*.3pm*
+%{_mandir}/man3/Test::Number::Delta.3*
 
 
 %changelog
+* Fri Oct 11 2019 Paul Howarth <paul@city-fan.org> - 1.06-15
+- Spec tidy-up
+  - Use author-independent source URL
+  - Specify all build dependencies
+  - Use DESTDIR rather than PERL_INSTALL_ROOT
+  - Simplify find command using -delete
+  - Don't need to remove empty directories from the buildroot
+  - Fix permissions verbosely
+  - Don't display developer dependencies as we're not running extra tests
+
 * Fri Jul 26 2019 Fedora Release Engineering <releng@fedoraproject.org> - 1.06-14
 - Rebuilt for https://fedoraproject.org/wiki/Fedora_31_Mass_Rebuild