Spec tidy-up

- Use author-independent source URL
- Use %{make_build} and %{make_install}
- Fix permissions verbosely
- Make %files list more explicit
- Package LICENSE file
- Drop redundant use of %{?perl_default_filter}

perl-Test-MockObject.spec

@@ -1,13 +1,13 @@
 Name:           perl-Test-MockObject
 Version:        1.20180705
-Release:        4%{?dist}
+Release:        5%{?dist}
 Summary:        Perl extension for emulating troublesome interfaces
 License:        GPL+ or Artistic
 URL:            https://metacpan.org/release/Test-MockObject
-Source0:        https://cpan.metacpan.org/authors/id/C/CH/CHROMATIC/Test-MockObject-%{version}.tar.gz
+Source0:        https://cpan.metacpan.org/modules/by-module/Test/Test-MockObject-%{version}.tar.gz
 BuildArch:      noarch
+# Build:
 BuildRequires:  coreutils
-BuildRequires:  findutils
 BuildRequires:  make
 BuildRequires:  perl-generators
 BuildRequires:  perl-interpreter
@@ -25,18 +25,17 @@ BuildRequires:  perl(UNIVERSAL::can) >= 1.20110617
 BuildRequires:  perl(UNIVERSAL::isa) >= 1.20110614
 # Tests:
 BuildRequires:  perl(base)
+BuildRequires:  perl(CGI) >= 4.15
 BuildRequires:  perl(fields)
 BuildRequires:  perl(overload)
 BuildRequires:  perl(Test::Exception) >= 0.31
 BuildRequires:  perl(Test::More) >= 0.98
 BuildRequires:  perl(Test::Warn) >= 0.23
 BuildRequires:  perl(vars)
-BuildRequires:  perl(CGI) >= 4.15
-Requires:       perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version))
+# Dependencies:
+Requires:       perl(:MODULE_COMPAT_%(eval "`perl -V:version`"; echo $version))
 Requires:       perl(Carp)
 
-%{?perl_default_filter}
-
 %description
 Test::MockObject is a highly polymorphic testing object, capable of
 looking like all sorts of objects.  This makes white-box testing much
@@ -49,22 +48,33 @@ Now you have no excuse.)
 %setup -q -n Test-MockObject-%{version}
 
 %build
-perl Makefile.PL INSTALLDIRS=vendor NO_PACKLIST=1
-make %{?_smp_mflags}
+perl Makefile.PL INSTALLDIRS=vendor NO_PACKLIST=1 NO_PERLLOCAL=1
+%{make_build}
 
 %install
-make pure_install DESTDIR=%{buildroot}
-%{_fixperms} %{buildroot}
+%{make_install}
+%{_fixperms} -c %{buildroot}
 
 %check
-PERL_RUN_ALL_TESTS=1 make test
+make test
 
 %files
 %doc Changes README
+%license LICENSE
 %{perl_vendorlib}/Test/
-%{_mandir}/man3/*.3pm*
+%{_mandir}/man3/Test::MockObject.3*
+%{_mandir}/man3/Test::MockObject::Extends.3*
 
 %changelog
+* Sun Oct 13 2019 Paul Howarth <paul@city-fan.org> - 1.20180705-5
+- Spec tidy-up
+  - Use author-independent source URL
+  - Use %%{make_build} and %%{make_install}
+  - Fix permissions verbosely
+  - Make %%files list more explicit
+  - Package LICENSE file
+  - Drop redundant use of %%{?perl_default_filter}
+
 * Fri Jul 26 2019 Fedora Release Engineering <releng@fedoraproject.org> - 1.20180705-4
 - Rebuilt for https://fedoraproject.org/wiki/Fedora_31_Mass_Rebuild