Spec clean-up

- Drop %defattr, redundant since rpm 4.4
- Drop buildroot cleaning in %install section
- Drop legacy Group: tag
- Use %license where possible
- Simplify find command using -delete
- Classify buildreqs by usage

perl-Params-Coerce.spec

@@ -1,34 +1,51 @@
 Name:		perl-Params-Coerce
 Version:	0.14
-Release:	29%{?dist}
+Release:	30%{?dist}
 Summary:	Allows your classes to do coercion of parameters
 License:	GPL+ or Artistic
-Group:		Development/Libraries
 URL:		https://metacpan.org/release/Params-Coerce
-Source0:	https://cpan.metacpan.org/authors/id/A/AD/ADAMK/Params-Coerce-%{version}.tar.gz
-# Fix building on Perl without "." in @INC, CPAN RT#121730
-Patch0:		Params-Coerce-0.14-Fix-building-on-Perl-without-.-in-INC.patch
+Source0:	https://cpan.metacpan.org/modules/by-module/Params/Params-Coerce-%{version}.tar.gz
+Patch0:		https://rt.cpan.org/Ticket/Attachment/1727800/928987/Params-Coerce-0.14-Fix-building-on-Perl-without-.-in-INC.patch
 BuildArch:	noarch
+# Module Build
+BuildRequires:	coreutils
+BuildRequires:	findutils
+BuildRequires:	make
 BuildRequires:	perl-generators
-BuildRequires:	perl(Carp)
+BuildRequires:	perl-interpreter
+# Dependencies of bundled Module::Install
+BuildRequires:	perl(Config)
 BuildRequires:	perl(Cwd)
 BuildRequires:	perl(ExtUtils::MakeMaker)
+BuildRequires:	perl(ExtUtils::Manifest)
+BuildRequires:	perl(File::Find)
 BuildRequires:	perl(File::Path)
 BuildRequires:	perl(File::Spec)
+BuildRequires:	perl(FindBin)
+BuildRequires:	perl(YAML)
+# Module Runtime
+BuildRequires:	perl(Carp)
 BuildRequires:	perl(Params::Util) >= 0.05
 BuildRequires:	perl(Scalar::Util) >= 1.11
+BuildRequires:	perl(strict)
+BuildRequires:	perl(vars)
+# Test Suite
 BuildRequires:	perl(Test::More)
+# Optional Tests
 BuildRequires:	perl(Test::Pod) >= 1.00
+# Dependencies
 Requires:	perl(:MODULE_COMPAT_%(eval "`perl -V:version`"; echo $version))
 
 %description
 A big part of good API design is that we should be able to be flexible in
 the ways that we take parameters. Params::Coerce attempts to encourage this,
-by making it easier to take a variety of different arguments, while adding 
+by making it easier to take a variety of different arguments, while adding
 negligible additional complexity to your code.
 
 %prep
 %setup -q -n Params-Coerce-%{version}
+
+# Fix building on Perl without "." in @INC (CPAN RT#121730)
 %patch0 -p1
 
 %build
@@ -36,22 +53,33 @@ perl Makefile.PL INSTALLDIRS=vendor
 make %{?_smp_mflags}
 
 %install
-rm -rf %{buildroot}
 make pure_install DESTDIR=%{buildroot}
-find %{buildroot} -type f -name .packlist -exec rm -f {} \;
-find %{buildroot} -depth -type d -exec rmdir {} \; 2>/dev/null
-%{_fixperms} %{buildroot}
+find %{buildroot} -type f -name .packlist -delete
+%{_fixperms} -c %{buildroot}
 
 %check
 make test AUTOMATED_TESTING=1
 
 %files
-%defattr(-,root,root,-)
-%doc Changes LICENSE README
+%if 0%{?_licensedir:1}
+%license LICENSE
+%else
+%doc LICENSE
+%endif
+%doc Changes README
 %{perl_vendorlib}/Params/
-%{_mandir}/man3/Params::Coerce.3pm*
+%{_mandir}/man3/Params::Coerce.3*
 
 %changelog
+* Fri Jul  6 2018 Paul Howarth <paul@city-fan.org> - 0.14-30
+- Spec clean-up
+  - Drop %%defattr, redundant since rpm 4.4
+  - Drop buildroot cleaning in %%install section
+  - Drop legacy Group: tag
+  - Use %%license where possible
+  - Simplify find command using -delete
+  - Classify buildreqs by usage
+
 * Thu Jun 28 2018 Jitka Plesnikova <jplesnik@redhat.com> - 0.14-29
 - Perl 5.28 rebuild