From 34b4845332030d6367c989d7ebce89fa5055aa60 Mon Sep 17 00:00:00 2001
From: Paul Howarth <paul@city-fan.org>
Date: Fri, 25 Oct 2019 08:50:00 +0100
Subject: [PATCH] Spec tidy-up

- Use author-independent source URL
- Drop redundant use of %{?perl_default_filter}
- Follow upstream guidance (META.json) on run-time dependencies
- Use %{make_build} and %{make_install}
- Fix permissions verbosely
- Make %files list more explicit
---
 perl-Clone-Choose.spec | 40 +++++++++++++++++++++++++---------------
 1 file changed, 25 insertions(+), 15 deletions(-)

diff --git a/perl-Clone-Choose.spec b/perl-Clone-Choose.spec
index d38f260..cdda1bf 100644
--- a/perl-Clone-Choose.spec
+++ b/perl-Clone-Choose.spec
@@ -1,11 +1,12 @@
 Name:           perl-Clone-Choose
 Version:        0.010
-Release:        6%{?dist}
+Release:        7%{?dist}
 Summary:        Choose appropriate clone utility
 License:        GPL+ or Artistic
 URL:            https://metacpan.org/release/Clone-Choose
-Source0:        https://cpan.metacpan.org/authors/id/H/HE/HERMES/Clone-Choose-%{version}.tar.gz
+Source0:        https://cpan.metacpan.org/modules/by-module/Clone/Clone-Choose-%{version}.tar.gz
 BuildArch:      noarch
+# Build
 BuildRequires:  coreutils
 BuildRequires:  make
 BuildRequires:  perl-generators
@@ -17,18 +18,19 @@ BuildRequires:  perl(strict)
 BuildRequires:  perl(warnings)
 # Run-time
 BuildRequires:  perl(Carp)
+# Optional Run-time
+BuildRequires:  perl(Clone) >= 0.10
+BuildRequires:  perl(Clone::PP)
 BuildRequires:  perl(Module::Runtime)
+BuildRequires:  perl(Storable)
 # Tests
 BuildRequires:  perl(Scalar::Util)
 BuildRequires:  perl(Test::More) >= 0.90
 BuildRequires:  perl(Test::Without::Module)
-# Optional tests
-BuildRequires:  perl(Clone)
-BuildRequires:  perl(Clone::PP)
-BuildRequires:  perl(Storable)
-Requires:  perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version))
-
-%{?perl_default_filter}
+# Dependencies
+Requires:       perl(:MODULE_COMPAT_%(eval "`perl -V:version`"; echo $version))
+Recommends:     perl(Module::Runtime)
+Requires:       perl(Storable)
 
 %description
 %{summary}.
@@ -37,13 +39,12 @@ Requires:  perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version))
 %setup -q -n Clone-Choose-%{version}
 
 %build
-%{__perl} Makefile.PL INSTALLDIRS=vendor NO_PACKLIST=1
-make %{?_smp_mflags}
+perl Makefile.PL INSTALLDIRS=vendor NO_PACKLIST=1 NO_PERLLOCAL=1
+%{make_build}
 
 %install
-make pure_install DESTDIR=%{buildroot}
-chmod -x %{buildroot}%{perl_vendorlib}/Clone/Choose.pm
-%{_fixperms} %{buildroot}/*
+%{make_install}
+%{_fixperms} -c %{buildroot}
 
 %check
 make test
@@ -51,9 +52,18 @@ make test
 %files
 %doc Changes README.md
 %{perl_vendorlib}/Clone/
-%{_mandir}/man3/*.3*
+%{_mandir}/man3/Clone::Choose.3*
 
 %changelog
+* Fri Oct 25 2019 Paul Howarth <paul@city-fan.org> - 0.010-7
+- Spec tidy-up
+  - Use author-independent source URL
+  - Drop redundant use of %%{?perl_default_filter}
+  - Follow upstream guidance (META.json) on run-time dependencies
+  - Use %%{make_build} and %%{make_install}
+  - Fix permissions verbosely
+  - Make %%files list more explicit
+
 * Fri Jul 26 2019 Fedora Release Engineering <releng@fedoraproject.org> - 0.010-6
 - Rebuilt for https://fedoraproject.org/wiki/Fedora_31_Mass_Rebuild