From 2cef27f5bfd2ff9c415b74b2299cbf44f80975f4 Mon Sep 17 00:00:00 2001 From: Adam Williamson Date: Wed, 25 May 2022 14:46:08 -0700 Subject: [PATCH 2/2] 18-qemu-options.t: drop some fragile and unnecessary asserts It's really not our job to test exactly what qemu does when we call it with `-M ? -version`, and that behaviour seems to vary anyhow, so let's drop these. https://progress.opensuse.org/issues/111602 Signed-off-by: Adam Williamson --- t/18-qemu-options.t | 2 -- 1 file changed, 2 deletions(-) diff --git a/t/18-qemu-options.t b/t/18-qemu-options.t index 4ef4a015..80fcd797 100755 --- a/t/18-qemu-options.t +++ b/t/18-qemu-options.t @@ -74,8 +74,6 @@ subtest qemu_append_option => sub { run_isotovideo(@common_options, QEMU_APPEND => 'M ? -version'); like($log, qr/-M \?/, '-M ? option added'); like($log, qr/-version/, '-version option added'); - like($log, qr/QEMU emulator version/, 'QEMU version printed'); - unlike($log, qr/Supported machines are\:/, 'Supported machines not listed'); unlike($log, qr/\: invalid option/, 'no invalid option detected'); like($log, qr/QEMU terminated before QMP connection could be established/, 'connecting to QMP socket aborted'); $ENV{QEMU_QMP_CONNECT_ATTEMPTS} = $qmp_connect_attempts; -- 2.36.1