Resolves: rhbz#1458800 CVE-2017-9432 Stack-buffer overflow in the StarWriterStruct::DatabaseName::read
parent
a97b516c22
commit
f3d2341450
@ -0,0 +1,27 @@
|
||||
From 2d6253c7a692a3d92785dd990fce7256ea05e794 Mon Sep 17 00:00:00 2001
|
||||
From: David Tardon <dtardon@redhat.com>
|
||||
Date: Fri, 7 Apr 2017 19:28:55 +0200
|
||||
Subject: [PATCH] ofz#1029 use correct loop index
|
||||
|
||||
To be honest, I think this would be clearer as two separate reads to two
|
||||
separate vars...
|
||||
---
|
||||
src/lib/StarWriterStruct.cxx | 2 +-
|
||||
1 file changed, 1 insertion(+), 1 deletion(-)
|
||||
|
||||
diff --git a/src/lib/StarWriterStruct.cxx b/src/lib/StarWriterStruct.cxx
|
||||
index 5893302..d1ad366 100644
|
||||
--- a/src/lib/StarWriterStruct.cxx
|
||||
+++ b/src/lib/StarWriterStruct.cxx
|
||||
@@ -327,7 +327,7 @@ bool DatabaseName::read(StarZone &zone)
|
||||
}
|
||||
data.m_name=libstoff::getString(text);
|
||||
int positions[2];
|
||||
- for (int j=0; j<2; ++j) positions[i]=int(input->readULong(4));
|
||||
+ for (int j=0; j<2; ++j) positions[j]=int(input->readULong(4));
|
||||
data.m_selection=STOFFVec2i(positions[0],positions[1]);
|
||||
m_dataList.push_back(data);
|
||||
}
|
||||
--
|
||||
2.13.0
|
||||
|
Loading…
Reference in new issue