You can not select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
38 lines
1.3 KiB
38 lines
1.3 KiB
From edce1de156f1daa71875e210c1d55ad8d3aefc90 Mon Sep 17 00:00:00 2001
|
|
From: Vit Mojzis <vmojzis@redhat.com>
|
|
Date: Fri, 25 Oct 2024 20:30:13 +0200
|
|
Subject: [PATCH] libselinux/setexecfilecon: Remove useless rc check
|
|
|
|
Fixes:
|
|
Error: IDENTICAL_BRANCHES (CWE-398):
|
|
libselinux-3.6/src/setexecfilecon.c:45: implicit_else: The code from the above if-then branch is identical to the code after the if statement.
|
|
libselinux-3.6/src/setexecfilecon.c:43: identical_branches: The same code is executed when the condition "rc < 0" is true or false, because the code in the if-then branch and after the if statement is identical. Should the if statement be removed?
|
|
\# 41|
|
|
\# 42| rc = setexeccon(newcon);
|
|
\# 43|-> if (rc < 0)
|
|
\# 44| goto out;
|
|
\# 45| out:
|
|
|
|
Signed-off-by: Vit Mojzis <vmojzis@redhat.com>
|
|
Acked-by: James Carter <jwcart2@gmail.com>
|
|
---
|
|
libselinux/src/setexecfilecon.c | 2 --
|
|
1 file changed, 2 deletions(-)
|
|
|
|
diff --git a/libselinux/src/setexecfilecon.c b/libselinux/src/setexecfilecon.c
|
|
index 2c6505a9..4b31e775 100644
|
|
--- a/libselinux/src/setexecfilecon.c
|
|
+++ b/libselinux/src/setexecfilecon.c
|
|
@@ -40,8 +40,6 @@ int setexecfilecon(const char *filename, const char *fallback_type)
|
|
}
|
|
|
|
rc = setexeccon(newcon);
|
|
- if (rc < 0)
|
|
- goto out;
|
|
out:
|
|
|
|
if (rc < 0 && security_getenforce() == 0)
|
|
--
|
|
2.47.0
|
|
|