parent
7c1cc9b7ca
commit
338d156047
@ -1,42 +0,0 @@
|
||||
From f4e496af66bc6a779f600158cc42b986d654f143 Mon Sep 17 00:00:00 2001
|
||||
From: Julien Nabet <serval2412@yahoo.fr>
|
||||
Date: Mon, 14 Dec 2020 19:45:22 +0100
|
||||
Subject: [PATCH] Related tdf#138888: fix assertion on avmedia/MediaControlBase
|
||||
|
||||
Assertion when trying to insert a video in Impress, see bt:
|
||||
https://bugs.documentfoundation.org/attachment.cgi?id=168161
|
||||
|
||||
According to https://en.cppreference.com/w/cpp/algorithm/clamp
|
||||
"behavior is undefined if the value of lo is greater than hi"
|
||||
|
||||
Regression from:
|
||||
commit 36b3b357fe2a882db6a5f5a006239e16200fb847
|
||||
Author: Noel <noelgrandin@gmail.com>
|
||||
Date: Thu Nov 12 16:10:56 2020 +0200
|
||||
|
||||
replace std::min(std::max()) with std::clamp
|
||||
|
||||
Change-Id: Idf33eb6c662b60174678f990f98aefc72edec2a6
|
||||
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107722
|
||||
Tested-by: Jenkins
|
||||
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
||||
---
|
||||
avmedia/source/framework/MediaControlBase.cxx | 2 +-
|
||||
1 file changed, 1 insertion(+), 1 deletion(-)
|
||||
|
||||
diff --git a/avmedia/source/framework/MediaControlBase.cxx b/avmedia/source/framework/MediaControlBase.cxx
|
||||
index ef92cce8a736..890bb04d805b 100644
|
||||
--- a/avmedia/source/framework/MediaControlBase.cxx
|
||||
+++ b/avmedia/source/framework/MediaControlBase.cxx
|
||||
@@ -64,7 +64,7 @@ void MediaControlBase::UpdateVolumeSlider( MediaItem const & aMediaItem )
|
||||
{
|
||||
mxVolumeSlider->set_sensitive(true);
|
||||
const sal_Int32 nVolumeDB = aMediaItem.getVolumeDB();
|
||||
- mxVolumeSlider->set_value( std::clamp( nVolumeDB, sal_Int32(0), AVMEDIA_DB_RANGE ) );
|
||||
+ mxVolumeSlider->set_value( std::clamp( nVolumeDB, AVMEDIA_DB_RANGE, sal_Int32(0)) );
|
||||
}
|
||||
}
|
||||
|
||||
--
|
||||
2.31.1
|
||||
|
@ -0,0 +1,201 @@
|
||||
From 3a19d8b8309070f8c14f3a3b4dc4b098ad64190f Mon Sep 17 00:00:00 2001
|
||||
From: =?UTF-8?q?Caol=C3=A1n=20McNamara?= <caolanm@redhat.com>
|
||||
Date: Wed, 9 Jun 2021 10:20:57 +0100
|
||||
Subject: [PATCH 1/2] dtd files are not xml files and shouldn't have xml
|
||||
headers
|
||||
|
||||
so rpminspect is correct in complaining that they are not valid xml
|
||||
on inspecting files claiming to be xml
|
||||
|
||||
Change-Id: I70379989326c2ea63e6a54b3658ebea4684fa5df
|
||||
---
|
||||
framework/dtd/accelerator.dtd | 1 -
|
||||
framework/dtd/event.dtd | 1 -
|
||||
framework/dtd/groupuinames.dtd | 1 -
|
||||
framework/dtd/image.dtd | 1 -
|
||||
framework/dtd/menubar.dtd | 1 -
|
||||
framework/dtd/statusbar.dtd | 1 -
|
||||
framework/dtd/toolbar.dtd | 1 -
|
||||
i18npool/source/localedata/data/locale.dtd | 1 -
|
||||
officecfg/registry/component-schema.dtd | 1 -
|
||||
officecfg/registry/component-update.dtd | 1 -
|
||||
package/dtd/Manifest.dtd | 1 -
|
||||
xmerge/source/xmerge/converter.dtd | 1 -
|
||||
xmloff/dtd/office.dtd | 1 -
|
||||
xmlscript/dtd/dialog.dtd | 1 -
|
||||
xmlscript/dtd/libraries.dtd | 2 --
|
||||
xmlscript/dtd/library.dtd | 2 --
|
||||
xmlscript/dtd/module.dtd | 2 --
|
||||
17 files changed, 20 deletions(-)
|
||||
|
||||
diff --git a/framework/dtd/accelerator.dtd b/framework/dtd/accelerator.dtd
|
||||
index f4dcac65242d..912b652d3cf5 100644
|
||||
--- a/framework/dtd/accelerator.dtd
|
||||
+++ b/framework/dtd/accelerator.dtd
|
||||
@@ -1,4 +1,3 @@
|
||||
-<?xml version="1.0" encoding="UTF-8"?>
|
||||
<!--
|
||||
* This file is part of the LibreOffice project.
|
||||
*
|
||||
diff --git a/framework/dtd/event.dtd b/framework/dtd/event.dtd
|
||||
index 7a66d15e571b..5af4a3dd267f 100644
|
||||
--- a/framework/dtd/event.dtd
|
||||
+++ b/framework/dtd/event.dtd
|
||||
@@ -1,4 +1,3 @@
|
||||
-<?xml version="1.0" encoding="UTF-8"?>
|
||||
<!--
|
||||
* This file is part of the LibreOffice project.
|
||||
*
|
||||
diff --git a/framework/dtd/groupuinames.dtd b/framework/dtd/groupuinames.dtd
|
||||
index a29b77a4f13e..218939cf9bae 100644
|
||||
--- a/framework/dtd/groupuinames.dtd
|
||||
+++ b/framework/dtd/groupuinames.dtd
|
||||
@@ -24,4 +24,3 @@
|
||||
groupuinames:name CDATA #REQUIRED
|
||||
groupuinames:default-ui-name CDATA #REQUIRED
|
||||
>
|
||||
-
|
||||
diff --git a/framework/dtd/image.dtd b/framework/dtd/image.dtd
|
||||
index 59b0f3f92f08..fb69a5e5f4c8 100644
|
||||
--- a/framework/dtd/image.dtd
|
||||
+++ b/framework/dtd/image.dtd
|
||||
@@ -1,4 +1,3 @@
|
||||
-<?xml version="1.0" encoding="UTF-8"?>
|
||||
<!--
|
||||
* This file is part of the LibreOffice project.
|
||||
*
|
||||
diff --git a/framework/dtd/menubar.dtd b/framework/dtd/menubar.dtd
|
||||
index b41431f6d0ef..b3469f7324a6 100644
|
||||
--- a/framework/dtd/menubar.dtd
|
||||
+++ b/framework/dtd/menubar.dtd
|
||||
@@ -1,4 +1,3 @@
|
||||
-<?xml version="1.0" encoding="UTF-8"?>
|
||||
<!--
|
||||
* This file is part of the LibreOffice project.
|
||||
*
|
||||
diff --git a/framework/dtd/statusbar.dtd b/framework/dtd/statusbar.dtd
|
||||
index 9f4e9e2a35c3..40a5609b7cf6 100644
|
||||
--- a/framework/dtd/statusbar.dtd
|
||||
+++ b/framework/dtd/statusbar.dtd
|
||||
@@ -1,4 +1,3 @@
|
||||
-<?xml version="1.0" encoding="UTF-8"?>
|
||||
<!--
|
||||
* This file is part of the LibreOffice project.
|
||||
*
|
||||
diff --git a/framework/dtd/toolbar.dtd b/framework/dtd/toolbar.dtd
|
||||
index 6f2c38260524..7f8ee24e8ab9 100644
|
||||
--- a/framework/dtd/toolbar.dtd
|
||||
+++ b/framework/dtd/toolbar.dtd
|
||||
@@ -1,4 +1,3 @@
|
||||
-<?xml version="1.0" encoding="UTF-8"?>
|
||||
<!--
|
||||
* This file is part of the LibreOffice project.
|
||||
*
|
||||
diff --git a/i18npool/source/localedata/data/locale.dtd b/i18npool/source/localedata/data/locale.dtd
|
||||
index 103ab1721c4e..60006d87f439 100644
|
||||
--- a/i18npool/source/localedata/data/locale.dtd
|
||||
+++ b/i18npool/source/localedata/data/locale.dtd
|
||||
@@ -1,4 +1,3 @@
|
||||
-<?xml version="1.0" encoding="UTF-8"?>
|
||||
<!--
|
||||
* This file is part of the LibreOffice project.
|
||||
*
|
||||
diff --git a/officecfg/registry/component-schema.dtd b/officecfg/registry/component-schema.dtd
|
||||
index 242b9c6ea513..70bd51bf7d13 100644
|
||||
--- a/officecfg/registry/component-schema.dtd
|
||||
+++ b/officecfg/registry/component-schema.dtd
|
||||
@@ -1,4 +1,3 @@
|
||||
-<?xml version="1.0" encoding="UTF-8"?>
|
||||
<!--
|
||||
* This file is part of the LibreOffice project.
|
||||
*
|
||||
diff --git a/officecfg/registry/component-update.dtd b/officecfg/registry/component-update.dtd
|
||||
index d99ee499249e..0659e412305b 100644
|
||||
--- a/officecfg/registry/component-update.dtd
|
||||
+++ b/officecfg/registry/component-update.dtd
|
||||
@@ -1,4 +1,3 @@
|
||||
-<?xml version="1.0" encoding="UTF-8"?>
|
||||
<!--
|
||||
* This file is part of the LibreOffice project.
|
||||
*
|
||||
diff --git a/package/dtd/Manifest.dtd b/package/dtd/Manifest.dtd
|
||||
index 2dbdbf00c81d..9e16a007a799 100644
|
||||
--- a/package/dtd/Manifest.dtd
|
||||
+++ b/package/dtd/Manifest.dtd
|
||||
@@ -46,4 +46,3 @@
|
||||
manifest:key-derivation-name CDATA #REQUIRED
|
||||
manifest:salt CDATA #REQUIRED
|
||||
manifest:iteration-count CDATA #REQUIRED>
|
||||
-
|
||||
diff --git a/xmerge/source/xmerge/converter.dtd b/xmerge/source/xmerge/converter.dtd
|
||||
index f7c09f5c2c58..81ecbe69d80e 100644
|
||||
--- a/xmerge/source/xmerge/converter.dtd
|
||||
+++ b/xmerge/source/xmerge/converter.dtd
|
||||
@@ -82,4 +82,3 @@
|
||||
<!ELEMENT converter-target EMPTY>
|
||||
|
||||
<!ATTLIST converter-target type CDATA #REQUIRED>
|
||||
-
|
||||
diff --git a/xmloff/dtd/office.dtd b/xmloff/dtd/office.dtd
|
||||
index e056d57e5525..5da82955640b 100644
|
||||
--- a/xmloff/dtd/office.dtd
|
||||
+++ b/xmloff/dtd/office.dtd
|
||||
@@ -1,4 +1,3 @@
|
||||
-<?xml version="1.0" encoding="UTF-8"?>
|
||||
<!--
|
||||
* This file is part of the LibreOffice project.
|
||||
*
|
||||
diff --git a/xmlscript/dtd/dialog.dtd b/xmlscript/dtd/dialog.dtd
|
||||
index 1b7e6355631f..7290b8d22257 100644
|
||||
--- a/xmlscript/dtd/dialog.dtd
|
||||
+++ b/xmlscript/dtd/dialog.dtd
|
||||
@@ -1,4 +1,3 @@
|
||||
-<?xml version="1.0" encoding="UTF-8"?>
|
||||
<!--
|
||||
* This file is part of the LibreOffice project.
|
||||
*
|
||||
diff --git a/xmlscript/dtd/libraries.dtd b/xmlscript/dtd/libraries.dtd
|
||||
index 270d89209bba..3b3b82e535b8 100644
|
||||
--- a/xmlscript/dtd/libraries.dtd
|
||||
+++ b/xmlscript/dtd/libraries.dtd
|
||||
@@ -1,4 +1,3 @@
|
||||
-<?xml version="1.0" encoding="UTF-8"?>
|
||||
<!--
|
||||
* This file is part of the LibreOffice project.
|
||||
*
|
||||
@@ -33,4 +32,3 @@
|
||||
library:link %boolean; #REQUIRED
|
||||
library:readonly %boolean; #IMPLIED
|
||||
>
|
||||
-
|
||||
diff --git a/xmlscript/dtd/library.dtd b/xmlscript/dtd/library.dtd
|
||||
index 4f1512692ad6..c0341ed545b5 100644
|
||||
--- a/xmlscript/dtd/library.dtd
|
||||
+++ b/xmlscript/dtd/library.dtd
|
||||
@@ -1,4 +1,3 @@
|
||||
-<?xml version="1.0" encoding="UTF-8"?>
|
||||
<!--
|
||||
* This file is part of the LibreOffice project.
|
||||
*
|
||||
@@ -32,4 +31,3 @@
|
||||
<!ATTLIST library:element
|
||||
library:name CDATA #REQUIRED
|
||||
>
|
||||
-
|
||||
diff --git a/xmlscript/dtd/module.dtd b/xmlscript/dtd/module.dtd
|
||||
index 5b36ac033d89..b77d62f46498 100644
|
||||
--- a/xmlscript/dtd/module.dtd
|
||||
+++ b/xmlscript/dtd/module.dtd
|
||||
@@ -1,4 +1,3 @@
|
||||
-<?xml version="1.0" encoding="UTF-8"?>
|
||||
<!--
|
||||
* This file is part of the LibreOffice project.
|
||||
*
|
||||
@@ -23,4 +22,3 @@
|
||||
script:name CDATA #REQUIRED
|
||||
script:language CDATA #REQUIRED
|
||||
>
|
||||
-
|
||||
--
|
||||
2.31.1
|
||||
|
@ -1,42 +0,0 @@
|
||||
From fd87193917a26437ffd6ce08a33bb22e7b7353fd Mon Sep 17 00:00:00 2001
|
||||
From: =?UTF-8?q?Caol=C3=A1n=20McNamara?= <caolanm@redhat.com>
|
||||
Date: Tue, 4 May 2021 21:04:40 +0100
|
||||
Subject: [PATCH] rhbz#1956977 crash on switch from active comment to slide
|
||||
sorter
|
||||
|
||||
Change-Id: I2b5a5cb8b0631971b775a70d96f2cbf0c118c090
|
||||
---
|
||||
sd/source/ui/annotations/annotationmanager.cxx | 7 +++++--
|
||||
1 file changed, 5 insertions(+), 2 deletions(-)
|
||||
|
||||
diff --git a/sd/source/ui/annotations/annotationmanager.cxx b/sd/source/ui/annotations/annotationmanager.cxx
|
||||
index 155862469313..898eb201d78e 100644
|
||||
--- a/sd/source/ui/annotations/annotationmanager.cxx
|
||||
+++ b/sd/source/ui/annotations/annotationmanager.cxx
|
||||
@@ -947,10 +947,13 @@ IMPL_LINK_NOARG(AnnotationManagerImpl, UpdateTagsHdl, void*, void)
|
||||
|
||||
void AnnotationManagerImpl::CreateTags()
|
||||
{
|
||||
-
|
||||
if( !(mxCurrentPage.is() && mpDoc) )
|
||||
return;
|
||||
|
||||
+ auto xViewShell = mrBase.GetMainViewShell();
|
||||
+ if (!xViewShell)
|
||||
+ return;
|
||||
+
|
||||
try
|
||||
{
|
||||
int nIndex = 1;
|
||||
@@ -963,7 +966,7 @@ void AnnotationManagerImpl::CreateTags()
|
||||
{
|
||||
Reference< XAnnotation > xAnnotation( xEnum->nextElement() );
|
||||
Color aColor( GetColorLight( mpDoc->GetAnnotationAuthorIndex( xAnnotation->getAuthor() ) ) );
|
||||
- rtl::Reference< AnnotationTag > xTag( new AnnotationTag( *this, *mrBase.GetMainViewShell()->GetView(), xAnnotation, aColor, nIndex++, maFont ) );
|
||||
+ rtl::Reference< AnnotationTag > xTag( new AnnotationTag( *this, *xViewShell->GetView(), xAnnotation, aColor, nIndex++, maFont ) );
|
||||
maTagVector.push_back(xTag);
|
||||
|
||||
if( xAnnotation == mxSelectedAnnotation )
|
||||
--
|
||||
2.31.1
|
||||
|
@ -0,0 +1,40 @@
|
||||
From ba66a3c76c8bd2f7f1e86b4a628b92951fcf82b3 Mon Sep 17 00:00:00 2001
|
||||
From: =?UTF-8?q?Caol=C3=A1n=20McNamara?= <caolanm@redhat.com>
|
||||
Date: Wed, 9 Jun 2021 09:35:28 +0100
|
||||
Subject: [PATCH 2/2] xmllint: Namespace prefix menu on menuseparator is not
|
||||
defined
|
||||
|
||||
xmllint --noout dbaccess/uiconfig/dbapp/toolbar/formobjectbar.xml
|
||||
dbaccess/uiconfig/dbapp/toolbar/formobjectbar.xml:24: namespace error : Namespace prefix menu on menuseparator is not defined
|
||||
<menu:menuseparator/>
|
||||
|
||||
should be a toolbarseparator here
|
||||
|
||||
a problem since...
|
||||
|
||||
commit 4f810905fa74128871f2fe924a3d28a79f4e4261
|
||||
Date: Tue Mar 5 15:42:19 2019 +0100
|
||||
|
||||
sync dbaccess ui files with swriter ui file structure
|
||||
|
||||
Change-Id: I000efac56a0af10bca7c22fba6f88f469ae9b272
|
||||
---
|
||||
dbaccess/uiconfig/dbapp/toolbar/formobjectbar.xml | 2 +-
|
||||
1 file changed, 1 insertion(+), 1 deletion(-)
|
||||
|
||||
diff --git a/dbaccess/uiconfig/dbapp/toolbar/formobjectbar.xml b/dbaccess/uiconfig/dbapp/toolbar/formobjectbar.xml
|
||||
index b3c2c9c37eef..78e698df3883 100644
|
||||
--- a/dbaccess/uiconfig/dbapp/toolbar/formobjectbar.xml
|
||||
+++ b/dbaccess/uiconfig/dbapp/toolbar/formobjectbar.xml
|
||||
@@ -21,7 +21,7 @@
|
||||
<toolbar:toolbaritem xlink:href=".uno:DBNewForm"/>
|
||||
<toolbar:toolbaritem xlink:href=".uno:DBFormOpen"/>
|
||||
<toolbar:toolbaritem xlink:href=".uno:DBFormEdit"/>
|
||||
- <menu:menuseparator/>
|
||||
+ <toolbar:toolbarseparator/>
|
||||
<toolbar:toolbaritem xlink:href=".uno:DBFormDelete"/>
|
||||
<toolbar:toolbaritem xlink:href=".uno:DBFormRename"/>
|
||||
<toolbar:toolbarseparator/>
|
||||
--
|
||||
2.31.1
|
||||
|
Loading…
Reference in new issue