coverity: fix comparison

f41
David Tardon 7 years ago
parent 7cbe0ad6c2
commit bbbe2e4c03

@ -0,0 +1,25 @@
From 9fc5c84f0e5ba6266df3057c80af8279e03b7c04 Mon Sep 17 00:00:00 2001
From: Markus Mohrhard <markus.mohrhard@googlemail.com>
Date: Mon, 19 Sep 2016 21:04:02 +0200
Subject: [PATCH] -Wtautological-compare, compare against the 'other' parameter
---
src/parser/json_parser_thread.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/parser/json_parser_thread.cpp b/src/parser/json_parser_thread.cpp
index 6f4dd2d3..5e3515e8 100644
--- a/src/parser/json_parser_thread.cpp
+++ b/src/parser/json_parser_thread.cpp
@@ -77,7 +77,7 @@ bool parse_token::operator== (const parse_token& other) const
case parse_token_t::parse_error:
if (pstring(error_value.p, error_value.len) != pstring(other.error_value.p, other.error_value.len))
return false;
- if (error_value.offset != error_value.offset)
+ if (error_value.offset != other.error_value.offset)
return false;
break;
default:
--
2.14.1

@ -26,6 +26,8 @@ BuildRequires: pkgconfig(python3)
%endif
BuildRequires: pkgconfig(zlib)
Patch0: 0001-Wtautological-compare-compare-against-the-other-para.patch
%description
%{name} is a standalone file import filter library for spreadsheet
documents. Currently under development are ODS, XLSX and CSV import

Loading…
Cancel
Save