From 353229f2ce45e0831715c34d64d4621561eb020d Mon Sep 17 00:00:00 2001 From: Tomas Henzl Date: Fri, 9 Oct 2020 14:06:36 -0400 Subject: [PATCH 18/33] [scsi] scsi: mpt3sas: A small correction in _base_process_reply_queue Message-id: <20201009140636.7976-19-thenzl@redhat.com> Patchwork-id: 330375 Patchwork-instance: patchwork O-Subject: [RHEL8.4 e-stor PATCH 18/18] scsi: mpt3sas: A small correction in _base_process_reply_queue Bugzilla: 1851440 RH-Acked-by: Ewan Milne RH-Acked-by: Jarod Wilson RH-Acked-by: Maurizio Lombardi RH-Acked-by: Tony Camuso There is no need to compute modulo. A simple comparison is good enough. Link: https://lore.kernel.org/r/20200911180057.14633-1-thenzl@redhat.com Acked-by: sreekanth reddy Signed-off-by: Tomas Henzl Signed-off-by: Martin K. Petersen (cherry picked from commit 3d49f7426e6c4e9c41d0aa88f0a76616912a383e) Signed-off-by: Jan Stancek --- drivers/scsi/mpt3sas/mpt3sas_base.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.c b/drivers/scsi/mpt3sas/mpt3sas_base.c index e08ad13714d4..b096917fc314 100644 --- a/drivers/scsi/mpt3sas/mpt3sas_base.c +++ b/drivers/scsi/mpt3sas/mpt3sas_base.c @@ -1626,7 +1626,7 @@ _base_process_reply_queue(struct adapter_reply_queue *reply_q) * So that FW can find enough entries to post the Reply * Descriptors in the reply descriptor post queue. */ - if (!base_mod64(completed_cmds, ioc->thresh_hold)) { + if (completed_cmds >= ioc->thresh_hold) { if (ioc->combined_reply_queue) { writel(reply_q->reply_post_host_index | ((msix_index & 7) << -- 2.13.6