You can not select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
47 lines
1.8 KiB
47 lines
1.8 KiB
4 years ago
|
From 0ab9801eaedaa796d86505ee3022d80cf1b8d755 Mon Sep 17 00:00:00 2001
|
||
|
|
From: Tomas Henzl <thenzl@redhat.com>
|
||
|
|
Date: Fri, 9 Oct 2020 14:06:31 -0400
|
||
|
|
Subject: [PATCH 13/33] [scsi] scsi: mpt3sas: Remove superfluous memset()
|
||
|
|
|
||
|
|
Message-id: <20201009140636.7976-14-thenzl@redhat.com>
|
||
|
|
Patchwork-id: 330369
|
||
|
|
Patchwork-instance: patchwork
|
||
|
|
O-Subject: [RHEL8.4 e-stor PATCH 13/18] scsi: mpt3sas: Remove superfluous memset()
|
||
|
|
Bugzilla: 1851440
|
||
|
|
RH-Acked-by: Ewan Milne <emilne@redhat.com>
|
||
|
|
RH-Acked-by: Jarod Wilson <jarod@redhat.com>
|
||
|
|
RH-Acked-by: Maurizio Lombardi <mlombard@redhat.com>
|
||
|
|
RH-Acked-by: Tony Camuso <tcamuso@redhat.com>
|
||
|
|
|
||
|
|
Fixes coccicheck warning:
|
||
|
|
|
||
|
|
./drivers/scsi/mpt3sas/mpt3sas_base.c:5247:16-34: WARNING: dma_alloc_coherent use in ioc -> request already zeroes out memory, so memset is not needed
|
||
|
|
|
||
|
|
dma_alloc_coherent() already zeroes out memory so memset() is not needed.
|
||
|
|
|
||
|
|
Link: https://lore.kernel.org/r/1596079918-41115-4-git-send-email-liheng40@huawei.com
|
||
|
|
Signed-off-by: Li Heng <liheng40@huawei.com>
|
||
|
|
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
|
||
|
|
(cherry picked from commit 4a636e9c7a2107b9a590f08d6f8f8a917e6b85de)
|
||
|
|
Signed-off-by: Tomas Henzl <thenzl@redhat.com>
|
||
|
|
Signed-off-by: Jan Stancek <jstancek@redhat.com>
|
||
|
|
---
|
||
|
|
drivers/scsi/mpt3sas/mpt3sas_base.c | 1 -
|
||
|
|
1 file changed, 1 deletion(-)
|
||
|
|
|
||
|
|
diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.c b/drivers/scsi/mpt3sas/mpt3sas_base.c
|
||
|
|
index 53a835b37fa9..4aae441211bd 100644
|
||
|
|
--- a/drivers/scsi/mpt3sas/mpt3sas_base.c
|
||
|
|
+++ b/drivers/scsi/mpt3sas/mpt3sas_base.c
|
||
|
|
@@ -5259,7 +5259,6 @@ _base_allocate_memory_pools(struct MPT3SAS_ADAPTER *ioc)
|
||
|
|
_base_release_memory_pools(ioc);
|
||
|
|
goto retry_allocation;
|
||
|
|
}
|
||
|
|
- memset(ioc->request, 0, sz);
|
||
|
|
|
||
|
|
if (retry_sz)
|
||
|
|
ioc_err(ioc, "request pool: dma_alloc_coherent succeed: hba_depth(%d), chains_per_io(%d), frame_sz(%d), total(%d kb)\n",
|
||
|
|
--
|
||
|
|
2.13.6
|
||
|
|
|