You can not select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
230 lines
8.7 KiB
230 lines
8.7 KiB
From 1d36a371eef28ade02138f1079eeecbcd8eb0741 Mon Sep 17 00:00:00 2001
|
|
From: Alaa Hleihel <ahleihel@redhat.com>
|
|
Date: Tue, 19 May 2020 07:48:49 -0400
|
|
Subject: [PATCH 227/312] [infiniband] net/mlx5: E-Switch, Move source port on
|
|
reg_c0 to the upper 16 bits
|
|
|
|
Message-id: <20200519074934.6303-19-ahleihel@redhat.com>
|
|
Patchwork-id: 310517
|
|
Patchwork-instance: patchwork
|
|
O-Subject: [RHEL8.3 BZ 1663246 18/63] net/mlx5: E-Switch, Move source port on reg_c0 to the upper 16 bits
|
|
Bugzilla: 1790219 1790218 1663246
|
|
RH-Acked-by: Marcelo Leitner <mleitner@redhat.com>
|
|
RH-Acked-by: Jarod Wilson <jarod@redhat.com>
|
|
RH-Acked-by: John Linville <linville@redhat.com>
|
|
RH-Acked-by: Ivan Vecera <ivecera@redhat.com>
|
|
RH-Acked-by: Tony Camuso <tcamuso@redhat.com>
|
|
RH-Acked-by: Kamal Heib <kheib@redhat.com>
|
|
|
|
Bugzilla: http://bugzilla.redhat.com/1663246
|
|
Bugzilla: http://bugzilla.redhat.com/1790219
|
|
Bugzilla: http://bugzilla.redhat.com/1790218
|
|
Upstream: v5.7-rc1
|
|
|
|
commit 0f0d3827c0b4d6c3d219a73ea103077dc5bc17aa
|
|
Author: Paul Blakey <paulb@mellanox.com>
|
|
Date: Sun Feb 16 12:01:26 2020 +0200
|
|
|
|
net/mlx5: E-Switch, Move source port on reg_c0 to the upper 16 bits
|
|
|
|
Multi chain support requires the miss path to continue the processing
|
|
from the last chain id, and for that we need to save the chain
|
|
miss tag (a mapping for 32bit chain id) on reg_c0 which will
|
|
come in a next patch.
|
|
|
|
Currently reg_c0 is exclusively used to store the source port
|
|
metadata, giving it 32bit, it is created from 16bits of vcha_id,
|
|
and 16bits of vport number.
|
|
|
|
We will move this source port metadata to upper 16bits, and leave the
|
|
lower bits for the chain miss tag. We compress the reg_c0 source port
|
|
metadata to 16bits by taking 8 bits from vhca_id, and 8bits from
|
|
the vport number.
|
|
|
|
Since we compress the vport number to 8bits statically, and leave two
|
|
top ids for special PF/ECPF numbers, we will only support a max of 254
|
|
vports with this strategy.
|
|
|
|
Signed-off-by: Paul Blakey <paulb@mellanox.com>
|
|
Reviewed-by: Oz Shlomo <ozsh@mellanox.com>
|
|
Reviewed-by: Mark Bloch <markb@mellanox.com>
|
|
Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>
|
|
|
|
Signed-off-by: Alaa Hleihel <ahleihel@redhat.com>
|
|
Signed-off-by: Frantisek Hrbata <fhrbata@redhat.com>
|
|
---
|
|
drivers/infiniband/hw/mlx5/main.c | 3 +-
|
|
.../ethernet/mellanox/mlx5/core/eswitch_offloads.c | 64 ++++++++++++++++++----
|
|
include/linux/mlx5/eswitch.h | 32 ++++++++++-
|
|
3 files changed, 87 insertions(+), 12 deletions(-)
|
|
|
|
Index: src/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c
|
|
===================================================================
|
|
--- src.orig/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c 2020-10-06 17:42:12.209236893 +0200
|
|
+++ src/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c 2020-10-06 17:42:12.226236747 +0200
|
|
@@ -260,7 +260,8 @@
|
|
attr->in_rep->vport));
|
|
|
|
misc2 = MLX5_ADDR_OF(fte_match_param, spec->match_criteria, misc_parameters_2);
|
|
- MLX5_SET_TO_ONES(fte_match_set_misc2, misc2, metadata_reg_c_0);
|
|
+ MLX5_SET(fte_match_set_misc2, misc2, metadata_reg_c_0,
|
|
+ mlx5_eswitch_get_vport_metadata_mask());
|
|
|
|
spec->match_criteria_enable |= MLX5_MATCH_MISC_PARAMETERS_2;
|
|
misc = MLX5_ADDR_OF(fte_match_param, spec->match_criteria, misc_parameters);
|
|
@@ -805,7 +806,8 @@
|
|
if (mlx5_eswitch_vport_match_metadata_enabled(esw)) {
|
|
misc = MLX5_ADDR_OF(fte_match_param, spec->match_criteria,
|
|
misc_parameters_2);
|
|
- MLX5_SET_TO_ONES(fte_match_set_misc2, misc, metadata_reg_c_0);
|
|
+ MLX5_SET(fte_match_set_misc2, misc, metadata_reg_c_0,
|
|
+ mlx5_eswitch_get_vport_metadata_mask());
|
|
|
|
spec->match_criteria_enable = MLX5_MATCH_MISC_PARAMETERS_2;
|
|
} else {
|
|
@@ -1035,8 +1037,9 @@
|
|
match_criteria_enable,
|
|
MLX5_MATCH_MISC_PARAMETERS_2);
|
|
|
|
- MLX5_SET_TO_ONES(fte_match_param, match_criteria,
|
|
- misc_parameters_2.metadata_reg_c_0);
|
|
+ MLX5_SET(fte_match_param, match_criteria,
|
|
+ misc_parameters_2.metadata_reg_c_0,
|
|
+ mlx5_eswitch_get_vport_metadata_mask());
|
|
} else {
|
|
MLX5_SET(create_flow_group_in, flow_group_in,
|
|
match_criteria_enable,
|
|
@@ -1321,7 +1324,8 @@
|
|
mlx5_eswitch_get_vport_metadata_for_match(esw, vport));
|
|
|
|
misc = MLX5_ADDR_OF(fte_match_param, spec->match_criteria, misc_parameters_2);
|
|
- MLX5_SET_TO_ONES(fte_match_set_misc2, misc, metadata_reg_c_0);
|
|
+ MLX5_SET(fte_match_set_misc2, misc, metadata_reg_c_0,
|
|
+ mlx5_eswitch_get_vport_metadata_mask());
|
|
|
|
spec->match_criteria_enable = MLX5_MATCH_MISC_PARAMETERS_2;
|
|
} else {
|
|
@@ -1791,11 +1795,19 @@
|
|
static const struct mlx5_flow_spec spec = {};
|
|
struct mlx5_flow_act flow_act = {};
|
|
int err = 0;
|
|
+ u32 key;
|
|
+
|
|
+ key = mlx5_eswitch_get_vport_metadata_for_match(esw, vport->vport);
|
|
+ key >>= ESW_SOURCE_PORT_METADATA_OFFSET;
|
|
|
|
MLX5_SET(set_action_in, action, action_type, MLX5_ACTION_TYPE_SET);
|
|
- MLX5_SET(set_action_in, action, field, MLX5_ACTION_IN_FIELD_METADATA_REG_C_0);
|
|
- MLX5_SET(set_action_in, action, data,
|
|
- mlx5_eswitch_get_vport_metadata_for_match(esw, vport->vport));
|
|
+ MLX5_SET(set_action_in, action, field,
|
|
+ MLX5_ACTION_IN_FIELD_METADATA_REG_C_0);
|
|
+ MLX5_SET(set_action_in, action, data, key);
|
|
+ MLX5_SET(set_action_in, action, offset,
|
|
+ ESW_SOURCE_PORT_METADATA_OFFSET);
|
|
+ MLX5_SET(set_action_in, action, length,
|
|
+ ESW_SOURCE_PORT_METADATA_BITS);
|
|
|
|
vport->ingress.offloads.modify_metadata =
|
|
mlx5_modify_header_alloc(esw->dev, MLX5_FLOW_NAMESPACE_ESW_INGRESS,
|
|
@@ -2673,9 +2685,41 @@
|
|
}
|
|
EXPORT_SYMBOL(mlx5_eswitch_vport_match_metadata_enabled);
|
|
|
|
-u32 mlx5_eswitch_get_vport_metadata_for_match(const struct mlx5_eswitch *esw,
|
|
+u32 mlx5_eswitch_get_vport_metadata_for_match(struct mlx5_eswitch *esw,
|
|
u16 vport_num)
|
|
{
|
|
- return ((MLX5_CAP_GEN(esw->dev, vhca_id) & 0xffff) << 16) | vport_num;
|
|
+ u32 vport_num_mask = GENMASK(ESW_VPORT_BITS - 1, 0);
|
|
+ u32 vhca_id_mask = GENMASK(ESW_VHCA_ID_BITS - 1, 0);
|
|
+ u32 vhca_id = MLX5_CAP_GEN(esw->dev, vhca_id);
|
|
+ u32 val;
|
|
+
|
|
+ /* Make sure the vhca_id fits the ESW_VHCA_ID_BITS */
|
|
+ WARN_ON_ONCE(vhca_id >= BIT(ESW_VHCA_ID_BITS));
|
|
+
|
|
+ /* Trim vhca_id to ESW_VHCA_ID_BITS */
|
|
+ vhca_id &= vhca_id_mask;
|
|
+
|
|
+ /* Make sure pf and ecpf map to end of ESW_VPORT_BITS range so they
|
|
+ * don't overlap with VF numbers, and themselves, after trimming.
|
|
+ */
|
|
+ WARN_ON_ONCE((MLX5_VPORT_UPLINK & vport_num_mask) <
|
|
+ vport_num_mask - 1);
|
|
+ WARN_ON_ONCE((MLX5_VPORT_ECPF & vport_num_mask) <
|
|
+ vport_num_mask - 1);
|
|
+ WARN_ON_ONCE((MLX5_VPORT_UPLINK & vport_num_mask) ==
|
|
+ (MLX5_VPORT_ECPF & vport_num_mask));
|
|
+
|
|
+ /* Make sure that the VF vport_num fits ESW_VPORT_BITS and don't
|
|
+ * overlap with pf and ecpf.
|
|
+ */
|
|
+ if (vport_num != MLX5_VPORT_UPLINK &&
|
|
+ vport_num != MLX5_VPORT_ECPF)
|
|
+ WARN_ON_ONCE(vport_num >= vport_num_mask - 1);
|
|
+
|
|
+ /* We can now trim vport_num to ESW_VPORT_BITS */
|
|
+ vport_num &= vport_num_mask;
|
|
+
|
|
+ val = (vhca_id << ESW_VPORT_BITS) | vport_num;
|
|
+ return val << (32 - ESW_SOURCE_PORT_METADATA_BITS);
|
|
}
|
|
EXPORT_SYMBOL(mlx5_eswitch_get_vport_metadata_for_match);
|
|
Index: src/include/linux/mlx5/eswitch.h
|
|
===================================================================
|
|
--- src.orig/include/linux/mlx5/eswitch.h 2020-10-06 17:41:30.578594215 +0200
|
|
+++ src/include/linux/mlx5/eswitch.h 2020-10-06 17:42:12.226236747 +0200
|
|
@@ -71,8 +71,32 @@
|
|
mlx5_eswitch_get_encap_mode(const struct mlx5_core_dev *dev);
|
|
|
|
bool mlx5_eswitch_vport_match_metadata_enabled(const struct mlx5_eswitch *esw);
|
|
+
|
|
+/* Reg C0 usage:
|
|
+ * Reg C0 = < ESW_VHCA_ID_BITS(8) | ESW_VPORT BITS(8) | ESW_CHAIN_TAG(16) >
|
|
+ *
|
|
+ * Highest 8 bits of the reg c0 is the vhca_id, next 8 bits is vport_num,
|
|
+ * the rest (lowest 16 bits) is left for tc chain tag restoration.
|
|
+ * VHCA_ID + VPORT comprise the SOURCE_PORT matching.
|
|
+ */
|
|
+#define ESW_VHCA_ID_BITS 8
|
|
+#define ESW_VPORT_BITS 8
|
|
+#define ESW_SOURCE_PORT_METADATA_BITS (ESW_VHCA_ID_BITS + ESW_VPORT_BITS)
|
|
+#define ESW_SOURCE_PORT_METADATA_OFFSET (32 - ESW_SOURCE_PORT_METADATA_BITS)
|
|
+#define ESW_CHAIN_TAG_METADATA_BITS (32 - ESW_SOURCE_PORT_METADATA_BITS)
|
|
+
|
|
+static inline u32 mlx5_eswitch_get_vport_metadata_mask(void)
|
|
+{
|
|
+ return GENMASK(31, 32 - ESW_SOURCE_PORT_METADATA_BITS);
|
|
+}
|
|
+
|
|
+# ifndef __GENKSYMS__
|
|
+u32 mlx5_eswitch_get_vport_metadata_for_match(struct mlx5_eswitch *esw,
|
|
+ u16 vport_num);
|
|
+# else
|
|
u32 mlx5_eswitch_get_vport_metadata_for_match(const struct mlx5_eswitch *esw,
|
|
u16 vport_num);
|
|
+# endif
|
|
u8 mlx5_eswitch_mode(struct mlx5_eswitch *esw);
|
|
#else /* CONFIG_MLX5_ESWITCH */
|
|
|
|
@@ -94,11 +118,17 @@
|
|
};
|
|
|
|
static inline u32
|
|
-mlx5_eswitch_get_vport_metadata_for_match(const struct mlx5_eswitch *esw,
|
|
+mlx5_eswitch_get_vport_metadata_for_match(struct mlx5_eswitch *esw,
|
|
int vport_num)
|
|
{
|
|
return 0;
|
|
};
|
|
+
|
|
+static inline u32
|
|
+mlx5_eswitch_get_vport_metadata_mask(void)
|
|
+{
|
|
+ return 0;
|
|
+}
|
|
#endif /* CONFIG_MLX5_ESWITCH */
|
|
|
|
#endif
|