You can not select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
134 lines
5.1 KiB
134 lines
5.1 KiB
From 4c84687ee7bae8c9bd1722d4159ed004a09d817d Mon Sep 17 00:00:00 2001
|
|
From: Alaa Hleihel <ahleihel@redhat.com>
|
|
Date: Sun, 10 May 2020 14:52:32 -0400
|
|
Subject: [PATCH 057/312] [netdrv] net/mlx5e: kTLS, Size of a Dump WQE is fixed
|
|
|
|
Message-id: <20200510145245.10054-70-ahleihel@redhat.com>
|
|
Patchwork-id: 306608
|
|
Patchwork-instance: patchwork
|
|
O-Subject: [RHEL8.3 BZ 1789378 v2 69/82] net/mlx5e: kTLS, Size of a Dump WQE is fixed
|
|
Bugzilla: 1789378
|
|
RH-Acked-by: Kamal Heib <kheib@redhat.com>
|
|
RH-Acked-by: Jarod Wilson <jarod@redhat.com>
|
|
RH-Acked-by: Tony Camuso <tcamuso@redhat.com>
|
|
RH-Acked-by: Jonathan Toppins <jtoppins@redhat.com>
|
|
|
|
Bugzilla: http://bugzilla.redhat.com/1789378
|
|
Upstream: v5.4-rc6
|
|
|
|
commit 9b1fef2f23c1141c9936debe633ff16e44c6137b
|
|
Author: Tariq Toukan <tariqt@mellanox.com>
|
|
Date: Sun Sep 1 13:53:26 2019 +0300
|
|
|
|
net/mlx5e: kTLS, Size of a Dump WQE is fixed
|
|
|
|
No Eth segment, so no dynamic inline headers.
|
|
The size of a Dump WQE is fixed, use constants and remove
|
|
unnecessary checks.
|
|
|
|
Fixes: d2ead1f360e8 ("net/mlx5e: Add kTLS TX HW offload support")
|
|
Signed-off-by: Tariq Toukan <tariqt@mellanox.com>
|
|
Reviewed-by: Eran Ben Elisha <eranbe@mellanox.com>
|
|
Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>
|
|
|
|
Signed-off-by: Alaa Hleihel <ahleihel@redhat.com>
|
|
Signed-off-by: Frantisek Hrbata <fhrbata@redhat.com>
|
|
---
|
|
drivers/net/ethernet/mellanox/mlx5/core/en/txrx.h | 2 +-
|
|
drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls.h | 9 ++++++++-
|
|
.../net/ethernet/mellanox/mlx5/core/en_accel/ktls_tx.c | 17 +++--------------
|
|
3 files changed, 12 insertions(+), 16 deletions(-)
|
|
|
|
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en/txrx.h b/drivers/net/ethernet/mellanox/mlx5/core/en/txrx.h
|
|
index 182d5c5664eb..25f9dda578ac 100644
|
|
--- a/drivers/net/ethernet/mellanox/mlx5/core/en/txrx.h
|
|
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en/txrx.h
|
|
@@ -23,7 +23,7 @@
|
|
#define MLX5E_SQ_TLS_ROOM \
|
|
(MLX5_SEND_WQE_MAX_WQEBBS + \
|
|
MLX5E_KTLS_STATIC_WQEBBS + MLX5E_KTLS_PROGRESS_WQEBBS + \
|
|
- MAX_SKB_FRAGS * MLX5E_KTLS_MAX_DUMP_WQEBBS)
|
|
+ MAX_SKB_FRAGS * MLX5E_KTLS_DUMP_WQEBBS)
|
|
#endif
|
|
|
|
#define INL_HDR_START_SZ (sizeof(((struct mlx5_wqe_eth_seg *)NULL)->inline_hdr.start))
|
|
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls.h b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls.h
|
|
index c4c128908b6e..eb692feba4a6 100644
|
|
--- a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls.h
|
|
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls.h
|
|
@@ -21,7 +21,14 @@
|
|
MLX5_ST_SZ_BYTES(tls_progress_params))
|
|
#define MLX5E_KTLS_PROGRESS_WQEBBS \
|
|
(DIV_ROUND_UP(MLX5E_KTLS_PROGRESS_WQE_SZ, MLX5_SEND_WQE_BB))
|
|
-#define MLX5E_KTLS_MAX_DUMP_WQEBBS 2
|
|
+
|
|
+struct mlx5e_dump_wqe {
|
|
+ struct mlx5_wqe_ctrl_seg ctrl;
|
|
+ struct mlx5_wqe_data_seg data;
|
|
+};
|
|
+
|
|
+#define MLX5E_KTLS_DUMP_WQEBBS \
|
|
+ (DIV_ROUND_UP(sizeof(struct mlx5e_dump_wqe), MLX5_SEND_WQE_BB))
|
|
|
|
enum {
|
|
MLX5E_TLS_PROGRESS_PARAMS_AUTH_STATE_NO_OFFLOAD = 0,
|
|
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls_tx.c b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls_tx.c
|
|
index 90c6ce530a18..ac54767b7d86 100644
|
|
--- a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls_tx.c
|
|
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls_tx.c
|
|
@@ -250,11 +250,6 @@ tx_post_resync_params(struct mlx5e_txqsq *sq,
|
|
mlx5e_ktls_tx_post_param_wqes(sq, priv_tx, skip_static_post, true);
|
|
}
|
|
|
|
-struct mlx5e_dump_wqe {
|
|
- struct mlx5_wqe_ctrl_seg ctrl;
|
|
- struct mlx5_wqe_data_seg data;
|
|
-};
|
|
-
|
|
static int
|
|
tx_post_resync_dump(struct mlx5e_txqsq *sq, skb_frag_t *frag, u32 tisn, bool first)
|
|
{
|
|
@@ -262,7 +257,6 @@ tx_post_resync_dump(struct mlx5e_txqsq *sq, skb_frag_t *frag, u32 tisn, bool fir
|
|
struct mlx5_wqe_data_seg *dseg;
|
|
struct mlx5e_dump_wqe *wqe;
|
|
dma_addr_t dma_addr = 0;
|
|
- u8 num_wqebbs;
|
|
u16 ds_cnt;
|
|
int fsz;
|
|
u16 pi;
|
|
@@ -270,7 +264,6 @@ tx_post_resync_dump(struct mlx5e_txqsq *sq, skb_frag_t *frag, u32 tisn, bool fir
|
|
wqe = mlx5e_sq_fetch_wqe(sq, sizeof(*wqe), &pi);
|
|
|
|
ds_cnt = sizeof(*wqe) / MLX5_SEND_WQE_DS;
|
|
- num_wqebbs = DIV_ROUND_UP(ds_cnt, MLX5_SEND_WQEBB_NUM_DS);
|
|
|
|
cseg = &wqe->ctrl;
|
|
dseg = &wqe->data;
|
|
@@ -291,12 +284,8 @@ tx_post_resync_dump(struct mlx5e_txqsq *sq, skb_frag_t *frag, u32 tisn, bool fir
|
|
dseg->byte_count = cpu_to_be32(fsz);
|
|
mlx5e_dma_push(sq, dma_addr, fsz, MLX5E_DMA_MAP_PAGE);
|
|
|
|
- tx_fill_wi(sq, pi, num_wqebbs, frag, fsz);
|
|
- sq->pc += num_wqebbs;
|
|
-
|
|
- WARN(num_wqebbs > MLX5E_KTLS_MAX_DUMP_WQEBBS,
|
|
- "unexpected DUMP num_wqebbs, %d > %d",
|
|
- num_wqebbs, MLX5E_KTLS_MAX_DUMP_WQEBBS);
|
|
+ tx_fill_wi(sq, pi, MLX5E_KTLS_DUMP_WQEBBS, frag, fsz);
|
|
+ sq->pc += MLX5E_KTLS_DUMP_WQEBBS;
|
|
|
|
return 0;
|
|
}
|
|
@@ -368,7 +357,7 @@ mlx5e_ktls_tx_handle_ooo(struct mlx5e_ktls_offload_context_tx *priv_tx,
|
|
stats->tls_ooo++;
|
|
|
|
num_wqebbs = MLX5E_KTLS_STATIC_WQEBBS + MLX5E_KTLS_PROGRESS_WQEBBS +
|
|
- (info.nr_frags ? info.nr_frags * MLX5E_KTLS_MAX_DUMP_WQEBBS : 1);
|
|
+ (info.nr_frags ? info.nr_frags * MLX5E_KTLS_DUMP_WQEBBS : 1);
|
|
pi = mlx5_wq_cyc_ctr2ix(wq, sq->pc);
|
|
contig_wqebbs_room = mlx5_wq_cyc_get_contig_wqebbs(wq, pi);
|
|
if (unlikely(contig_wqebbs_room < num_wqebbs))
|
|
--
|
|
2.13.6
|
|
|