You can not select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
37 lines
1.4 KiB
37 lines
1.4 KiB
2 years ago
|
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
||
|
|
From: Daniel Axtens <dja@axtens.net>
|
||
|
|
Date: Mon, 6 Feb 2023 10:03:21 -0500
|
||
|
|
Subject: [PATCH] ieee1275: drop len -= 1 quirk in heap_init
|
||
|
|
|
||
|
|
This was apparently 'required by some firmware': commit dc9468500919
|
||
|
|
("2007-02-12 Hollis Blanchard <hollis@penguinppc.org>").
|
||
|
|
|
||
|
|
It's not clear what firmware that was, and what platform from 14 years ago
|
||
|
|
which exhibited the bug then is still both in use and buggy now.
|
||
|
|
|
||
|
|
It doesn't cause issues on qemu (mac99 or pseries) or under PFW for Power8.
|
||
|
|
|
||
|
|
I don't have access to old Mac hardware, but if anyone feels especially
|
||
|
|
strongly we can put it under some feature flag. I really want to disable
|
||
|
|
it under pseries because it will mess with region merging.
|
||
|
|
|
||
|
|
Signed-off-by: Daniel Axtens <dja@axtens.net>
|
||
|
|
Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
|
||
|
|
(cherry picked from commit fc639d430297321ee4f77c5d2d698f698cec0dc7)
|
||
|
|
---
|
||
|
|
grub-core/kern/ieee1275/init.c | 1 -
|
||
|
|
1 file changed, 1 deletion(-)
|
||
|
|
|
||
|
|
diff --git a/grub-core/kern/ieee1275/init.c b/grub-core/kern/ieee1275/init.c
|
||
|
|
index 8ae405bc79..c8d551759d 100644
|
||
|
|
--- a/grub-core/kern/ieee1275/init.c
|
||
|
|
+++ b/grub-core/kern/ieee1275/init.c
|
||
|
|
@@ -168,7 +168,6 @@ heap_init (grub_uint64_t addr, grub_uint64_t len, grub_memory_type_t type,
|
||
|
|
addr = 0x180000;
|
||
|
|
}
|
||
|
|
}
|
||
|
|
- len -= 1; /* Required for some firmware. */
|
||
|
|
|
||
|
|
/* Never exceed HEAP_MAX_SIZE */
|
||
|
|
if (*total + len > HEAP_MAX_SIZE)
|