You can not select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
38 lines
1.4 KiB
38 lines
1.4 KiB
9 months ago
|
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
||
|
|
From: Daniel Axtens <dja@axtens.net>
|
||
|
|
Date: Tue, 18 Jan 2022 14:29:20 +1100
|
||
|
|
Subject: [PATCH] net/tftp: Avoid a trivial UAF
|
||
|
|
|
||
|
|
Under tftp errors, we print a tftp error message from the tftp header.
|
||
|
|
However, the tftph pointer is a pointer inside nb, the netbuff. Previously,
|
||
|
|
we were freeing the nb and then dereferencing it. Don't do that, use it
|
||
|
|
and then free it later.
|
||
|
|
|
||
|
|
This isn't really _bad_ per se, especially as we're single-threaded, but
|
||
|
|
it trips up fuzzers.
|
||
|
|
|
||
|
|
Signed-off-by: Daniel Axtens <dja@axtens.net>
|
||
|
|
Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
|
||
|
|
(cherry picked from commit 956f4329cec23e4375182030ca9b2be631a61ba5)
|
||
|
|
(cherry picked from commit dbe9abcdee6ce796811111b67e3f24eefe2135d1)
|
||
|
|
(cherry picked from commit 72ae9c5d389d2c0337c44edead6e00db0bb84039)
|
||
|
|
---
|
||
|
|
grub-core/net/tftp.c | 2 +-
|
||
|
|
1 file changed, 1 insertion(+), 1 deletion(-)
|
||
|
|
|
||
|
|
diff --git a/grub-core/net/tftp.c b/grub-core/net/tftp.c
|
||
|
|
index 69a9ba6979..09e1511ccf 100644
|
||
|
|
--- a/grub-core/net/tftp.c
|
||
|
|
+++ b/grub-core/net/tftp.c
|
||
|
|
@@ -252,9 +252,9 @@ tftp_receive (grub_net_udp_socket_t sock __attribute__ ((unused)),
|
||
|
|
return GRUB_ERR_NONE;
|
||
|
|
case TFTP_ERROR:
|
||
|
|
data->have_oack = 1;
|
||
|
|
- grub_netbuff_free (nb);
|
||
|
|
grub_error (GRUB_ERR_IO, "%s", tftph->u.err.errmsg);
|
||
|
|
grub_error_save (&data->save_err);
|
||
|
|
+ grub_netbuff_free (nb);
|
||
|
|
return GRUB_ERR_NONE;
|
||
|
|
default:
|
||
|
|
grub_netbuff_free (nb);
|