You can not select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
55 lines
1.6 KiB
55 lines
1.6 KiB
7 months ago
|
From 6720d36b6623c5e48c070d86acf61198b33e144e Mon Sep 17 00:00:00 2001
|
||
|
|
From: Fangrui Song <maskray@google.com>
|
||
|
|
Date: Tue, 2 Nov 2021 20:59:52 -0700
|
||
|
|
Subject: [PATCH] x86-64: Replace movzx with movzbl
|
||
|
|
Content-type: text/plain; charset=UTF-8
|
||
|
|
|
||
|
|
Clang cannot assemble movzx in the AT&T dialect mode.
|
||
|
|
|
||
|
|
../sysdeps/x86_64/strcmp.S:2232:16: error: invalid operand for instruction
|
||
|
|
movzx (%rsi), %ecx
|
||
|
|
^~~~
|
||
|
|
|
||
|
|
Change movzx to movzbl, which follows the AT&T dialect and is used
|
||
|
|
elsewhere in the file.
|
||
|
|
|
||
|
|
Reviewed-by: H.J. Lu <hjl.tools@gmail.com>
|
||
|
|
---
|
||
|
|
sysdeps/x86_64/multiarch/strcmp-sse42.S | 4 ++--
|
||
|
|
sysdeps/x86_64/strcmp.S | 4 ++--
|
||
|
|
2 files changed, 4 insertions(+), 4 deletions(-)
|
||
|
|
|
||
|
|
diff --git a/sysdeps/x86_64/multiarch/strcmp-sse42.S b/sysdeps/x86_64/multiarch/strcmp-sse42.S
|
||
|
|
index a1ebea46..d8fdeb3a 100644
|
||
|
|
--- a/sysdeps/x86_64/multiarch/strcmp-sse42.S
|
||
|
|
+++ b/sysdeps/x86_64/multiarch/strcmp-sse42.S
|
||
|
|
@@ -1771,8 +1771,8 @@ LABEL(strcmp_exitz):
|
||
|
|
.p2align 4
|
||
|
|
// XXX Same as code above
|
||
|
|
LABEL(Byte0):
|
||
|
|
- movzx (%rsi), %ecx
|
||
|
|
- movzx (%rdi), %eax
|
||
|
|
+ movzbl (%rsi), %ecx
|
||
|
|
+ movzbl (%rdi), %eax
|
||
|
|
|
||
|
|
#if defined USE_AS_STRCASECMP_L || defined USE_AS_STRNCASECMP_L
|
||
|
|
leaq _nl_C_LC_CTYPE_tolower+128*4(%rip), %rdx
|
||
|
|
diff --git a/sysdeps/x86_64/strcmp.S b/sysdeps/x86_64/strcmp.S
|
||
|
|
index f47c8ad4..aa6df898 100644
|
||
|
|
--- a/sysdeps/x86_64/strcmp.S
|
||
|
|
+++ b/sysdeps/x86_64/strcmp.S
|
||
|
|
@@ -2232,8 +2232,8 @@ LABEL(strcmp_exitz):
|
||
|
|
|
||
|
|
.p2align 4
|
||
|
|
LABEL(Byte0):
|
||
|
|
- movzx (%rsi), %ecx
|
||
|
|
- movzx (%rdi), %eax
|
||
|
|
+ movzbl (%rsi), %ecx
|
||
|
|
+ movzbl (%rdi), %eax
|
||
|
|
|
||
|
|
#if defined USE_AS_STRCASECMP_L || defined USE_AS_STRNCASECMP_L
|
||
|
|
leaq _nl_C_LC_CTYPE_tolower+128*4(%rip), %rdx
|
||
|
|
--
|
||
|
|
GitLab
|
||
|
|
|